RE: [PATCH 1/2] use abstracted bit count functions

2023-08-25 Thread Long Li
> Subject: [PATCH 1/2] use abstracted bit count functions > > Now that DPDK provides such bit count functions, make use of them. > > This patch was prepared with a "brutal" commandline: > > $ old=__builtin_clzll; new=rte_clz64; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed

[PATCH v2] mbuf: add ESP packet type

2023-08-25 Thread Alexander Kozyrev
Support the IP Encapsulating Security Payload (ESP) in transport mode. Signed-off-by: Alexander Kozyrev --- lib/mbuf/rte_mbuf_ptype.h | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/lib/mbuf/rte_mbuf_ptype.h b/lib/mbuf/rte_mbuf_ptype.h index 1

RE: [PATCH] mbuf: add ESP packet type

2023-08-25 Thread Alexander Kozyrev
> From: Morten Brørup > Non-fragment criteria seems to be missing: > > * | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0> > > Also missing here: > * | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0> > You are right, thank you, sending v2 with updated description.

[PATCH 3/3] test/event: add event link profile test

2023-08-25 Thread pbhagavatula
From: Pavan Nikhilesh Add test case to verify event link profiles. Signed-off-by: Pavan Nikhilesh --- app/test/test_eventdev.c | 117 +++ 1 file changed, 117 insertions(+) diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c index 29354a24c9..b3

[PATCH 2/3] event/cnxk: implement event link profiles

2023-08-25 Thread pbhagavatula
From: Pavan Nikhilesh Implement event link profiles support on CN10K and CN9K. Both the platforms support up to 2 link profiles. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst | 1 + doc/guides/eventdevs/features/cnxk.ini | 3 +- doc/guides/rel_notes/release_23_11.

[PATCH 1/3] eventdev: introduce link profiles

2023-08-25 Thread pbhagavatula
From: Pavan Nikhilesh A collection of event queues linked to an event port can be associated with a unique identifier called as a profile, multiple such profiles can be created based on the event device capability using the function `rte_event_port_profile_links_set` which takes arguments similar

[PATCH 0/3] Introduce event link profiles

2023-08-25 Thread pbhagavatula
From: Pavan Nikhilesh A collection of event queues linked to an event port can be associated with unique identifier called as a profile, multiple such profiles can be configured based on the event device capability using the function `rte_event_port_profile_links_set` which takes arguments simila

[PATCH] net/mlx5: fix jump ipool entry size

2023-08-25 Thread Dariusz Sosnowski
In mlx5 PMD, MLX5_IPOOL_JUMP ipool configuration is used to initialize the ipool containing either: - flow table entry when DV flow engine is chosen or, - group table entry when HW steering flow engine is chosen. Default configuration for MLX5_IPOOL_JUMP ipool specified entry size as size of mlx5

RE: [PATCH] drivers: add dependencies for some classes

2023-08-25 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Friday, 25 August 2023 19.03 > > A few classes meson.build were not expressing dependencies to the > associated device library. Define std_deps for baseband, gpu and regex > drivers. > > Signed-off-by: David Marchand > --- On the

Re: [PATCH] drivers: add dependencies for some classes

2023-08-25 Thread Bruce Richardson
On Fri, Aug 25, 2023 at 07:02:36PM +0200, David Marchand wrote: > A few classes meson.build were not expressing dependencies to the > associated device library. Define std_deps for baseband, gpu and regex > drivers. > > Signed-off-by: David Marchand > --- > drivers/baseband/acc/meson.build

[PATCH] drivers: add dependencies for some classes

2023-08-25 Thread David Marchand
A few classes meson.build were not expressing dependencies to the associated device library. Define std_deps for baseband, gpu and regex drivers. Signed-off-by: David Marchand --- drivers/baseband/acc/meson.build | 2 +- drivers/baseband/fpga_5gnr_fec/meson.build | 2 +- drivers/baseba

Re: [PATCH 2/2] devtools: forbid use of builtin helpers for bit count

2023-08-25 Thread Tyler Retzlaff
On Fri, Aug 25, 2023 at 12:18:11PM +0200, David Marchand wrote: > Now that DPDK provides some bit count operations, flag it to avoid > reintroducing __builtin_*. > > Signed-off-by: David Marchand > --- Acked-by: Tyler Retzlaff

Re: [PATCH 1/2] use abstracted bit count functions

2023-08-25 Thread Tyler Retzlaff
On Fri, Aug 25, 2023 at 12:18:10PM +0200, David Marchand wrote: > Now that DPDK provides such bit count functions, make use of them. > > This patch was prepared with a "brutal" commandline: > > $ old=__builtin_clzll; new=rte_clz64; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs

RE: [PATCH] build: make crypto libraries optional

2023-08-25 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 25 August 2023 16.57 > > Cryptodev and the libraries which depend on it can be made optional, > as they can be disabled without breaking the build. > > Signed-off-by: Bruce Richardson > --- Thank you, Bruce. You know I

Re: [PATCH] remove wrappers for GCC < 4.8

2023-08-25 Thread Tyler Retzlaff
On Thu, Aug 24, 2023 at 10:52:04AM +0200, David Marchand wrote: > Hello Tyler, > > On Thu, Aug 24, 2023 at 10:30 AM David Marchand > wrote: > > diff --git a/lib/eal/include/rte_debug.h b/lib/eal/include/rte_debug.h > > index 2c4b94a7c9..74593cd4d4 100644 > > --- a/lib/eal/include/rte_debug.h > >

RE: [PATCH] eal/x86: fix build on systems with WAITPKG support

2023-08-25 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 25 August 2023 17.29 > > When doing a build for a system with WAITPKG support and a modern > compiler, we get build errors for the "_umonitor" intrinsic, due to the > casting away of the "volatile" on the parameter. > >

Re: [PATCH] build: add pdcp to optional libs

2023-08-25 Thread Tyler Retzlaff
On Fri, Aug 25, 2023 at 03:18:54PM +0100, Bruce Richardson wrote: > The pdcp library is disabled when its dependent library "reorder" is not > being built. > > ../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp" > Message: Disabling pdcp [lib/pdcp]: missing internal dependency

Re: [PATCH v5 3/3] power: amd power monitor support

2023-08-25 Thread Tyler Retzlaff
On Thu, Aug 24, 2023 at 10:04:42AM +0100, Ferruh Yigit wrote: > On 8/23/2023 5:03 PM, Tyler Retzlaff wrote: > > On Wed, Aug 23, 2023 at 10:19:39AM +0100, Ferruh Yigit wrote: > >> On 8/22/2023 11:30 PM, Konstantin Ananyev wrote: > >>> 18/08/2023 14:48, Bruce Richardson пишет: > On Fri, Aug 18,

Re: [PATCH v11 06/16] eal: use prefetch intrinsics

2023-08-25 Thread Tyler Retzlaff
On Fri, Aug 25, 2023 at 10:44:01AM +0200, David Marchand wrote: > On Thu, Aug 24, 2023 at 5:54 PM Tyler Retzlaff > wrote: > > > > On Thu, Aug 24, 2023 at 04:18:06PM +0200, David Marchand wrote: > > > On Thu, Aug 24, 2023 at 2:47 PM Morten Brørup > > > wrote: > > > > > From: David Marchand [mailt

Re: [PATCH v11 05/16] eal: use umonitor umwait and tpause intrinsics

2023-08-25 Thread Tyler Retzlaff
On Fri, Aug 25, 2023 at 04:12:59PM +0100, Bruce Richardson wrote: > On Fri, Aug 25, 2023 at 04:56:51PM +0200, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Friday, 25 August 2023 16.13 > > > > > > On Fri, Aug 11, 2023 at 12:20:47PM -0700, Tyler R

[PATCH] eal/x86: fix build on systems with WAITPKG support

2023-08-25 Thread Bruce Richardson
When doing a build for a system with WAITPKG support and a modern compiler, we get build errors for the "_umonitor" intrinsic, due to the casting away of the "volatile" on the parameter. ../lib/eal/x86/rte_power_intrinsics.c: In function 'rte_power_monitor': ../lib/eal/x86/rte_power_intrinsics.c:1

Re: [PATCH v11 05/16] eal: use umonitor umwait and tpause intrinsics

2023-08-25 Thread Bruce Richardson
On Fri, Aug 25, 2023 at 04:56:51PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Friday, 25 August 2023 16.13 > > > > On Fri, Aug 11, 2023 at 12:20:47PM -0700, Tyler Retzlaff wrote: > > > Inline assembly is not supported for MSVC x64 instead u

[PATCH] build: make crypto libraries optional

2023-08-25 Thread Bruce Richardson
Cryptodev and the libraries which depend on it can be made optional, as they can be disabled without breaking the build. Signed-off-by: Bruce Richardson --- lib/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index c1602e818a..099b0ed18a 10064

RE: [PATCH v11 05/16] eal: use umonitor umwait and tpause intrinsics

2023-08-25 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 25 August 2023 16.13 > > On Fri, Aug 11, 2023 at 12:20:47PM -0700, Tyler Retzlaff wrote: > > Inline assembly is not supported for MSVC x64 instead use _umonitor, > > _umwait and _tpause intrinsics. > > > > Signed-off-by:

CI Testing Automated Recheck Request Framework

2023-08-25 Thread Adam Hassick
Hello DPDK developers, Currently, various testing labs perform CI testing on new patch series sent to dev@dpdk.org and report their results to https://patchwork.dpdk.org/project/dpdk/list/. On each series on the patch list, the results appear in the test category contexts for IOL (community lab),

[PATCH] build: add pdcp to optional libs

2023-08-25 Thread Bruce Richardson
The pdcp library is disabled when its dependent library "reorder" is not being built. ../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp" Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder" As such, it is not a mandatory library, and can be marked as saf

Re: [PATCH v11 05/16] eal: use umonitor umwait and tpause intrinsics

2023-08-25 Thread Bruce Richardson
On Fri, Aug 11, 2023 at 12:20:47PM -0700, Tyler Retzlaff wrote: > Inline assembly is not supported for MSVC x64 instead use _umonitor, > _umwait and _tpause intrinsics. > > Signed-off-by: Tyler Retzlaff > Acked-by: Morten Brørup > Acked-by: Konstantin Ananyev > --- > lib/eal/x86/rte_power_intr

RE: [PATCH 8/8] net/ntnic: adds socket connection to PMD

2023-08-25 Thread Christian Koue Muf
On Wednesday, August 16, 2023 4:46 PM Stephen Hemminger wrote: > On Wed, 16 Aug 2023 15:25:52 +0200 > Mykola Kostenok wrote: > > > From: Christian Koue Muf > > > > The socket connection is used by Napatech's tools for monitoring and > > rte_flow programming from other processes. > > > > Sign

RE: [PATCH v1] eventdev/eth_rx: fix null pointer dereference

2023-08-25 Thread Naga Harish K, S V
> -Original Message- > From: Kundapura, Ganapati > Sent: Thursday, August 24, 2023 1:54 PM > To: jer...@marvell.com; Naga Harish K, S V ; > dev@dpdk.org > Cc: Jayatheerthan, Jay ; Gujjar, Abhinandan S > > Subject: [PATCH v1] eventdev/eth_rx: fix null pointer dereference > > On passing

[Bug 1280] rte_mempool_create returning error "EAL: eal_memalloc_alloc_seg_bulk(): couldn't find suitable memseg_list"

2023-08-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1280 Bug ID: 1280 Summary: rte_mempool_create returning error "EAL: eal_memalloc_alloc_seg_bulk(): couldn't find suitable memseg_list" Product: DPDK Version: 21.11 H

Re: [PATCH] test/security: fix buffer leaks in error path

2023-08-25 Thread Hemant Agrawal
On 22-Aug-23 11:03 PM, Akhil Goyal wrote: In case of failure of a test in macsec autotest, the buffers were not getting cleaned. Added appropriate code to clean the buffers. Fixes: 993ea577a006 ("test/security: add inline MACsec cases") Cc: sta...@dpdk.org Signed-off-by: Akhil Goyal --- ap

[PATCH v2 1/1] net/cnxk: support MACsec PN threshold events on multiple ports

2023-08-25 Thread Ankur Dwivedi
Adds sa to port mapping in roc mcs. The sa to port map is updated when the sa is created. A portid field is also added to macsec event callback function. The above changes helps to propagate the tx and rx pn threshold events to the correct ethernet device. Signed-off-by: Ankur Dwivedi --- driver

[PATCH v2 0/1] support for MACsec PN threshold events on multiple ports

2023-08-25 Thread Ankur Dwivedi
This patch series adds support for packet number threshold events to be received on the respective ethernet port. For this a sa to port mapping is created during sa creation. When the pn threshold event is received then the check for port id is made to receive the event on the correct port. v2: -

[PATCH 1/2] use abstracted bit count functions

2023-08-25 Thread David Marchand
Now that DPDK provides such bit count functions, make use of them. This patch was prepared with a "brutal" commandline: $ old=__builtin_clzll; new=rte_clz64; git grep -lw $old :^lib/eal/include/rte_bitops.h | xargs sed -i -e "s#\<$old\>#$new#g" $ old=__builtin_clz; new=rte_clz32; git grep -

[PATCH 2/2] devtools: forbid use of builtin helpers for bit count

2023-08-25 Thread David Marchand
Now that DPDK provides some bit count operations, flag it to avoid reintroducing __builtin_*. Signed-off-by: David Marchand --- devtools/checkpatches.sh | 8 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 43f5e36a18..55fabc5458 10

[PATCH v2 17/17] common/idpf/base: update version

2023-08-25 Thread Simei Su
Update README Signed-off-by: Simei Su --- drivers/common/idpf/base/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/idpf/base/README b/drivers/common/idpf/base/README index 693049c057..457b5a81f3 100644 --- a/drivers/common/idpf/base/README +++ b/driv

[PATCH v2 16/17] common/idpf/base: remove unused Tx descriptor types

2023-08-25 Thread Simei Su
Remove the unused TX descriptor types and mark them as reserved. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_lan_txrx.h | 132 ++- 1 file changed, 10 insertions(+), 122 deletions(-) diff --git a/drivers/common/idpf/base/idpf_la

[PATCH v2 15/17] common/idpf/base: dont declare union with 'flex'

2023-08-25 Thread Simei Su
In idpf_flex_tx_desc structure, instead of naming the union with 'flex', use no name union as the union name is not really necessary there. This reduces the level of indirection in the hotpath. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_lan_txrx.h

[PATCH v2 14/17] common/idpf/base: use 'type functionname(args)' style

2023-08-25 Thread Simei Su
Instead of splitting the function name and function type into multiple lines, use then in a single line. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_controlq.c | 5 ++--- drivers/common/idpf/base/idpf_controlq_setup.c | 5 ++--- 2 files chang

[PATCH v2 13/17] common/idpf/base: use GENMASK macro

2023-08-25 Thread Simei Su
Instead of using a custom defined macro for generating a mask, use the standard GENMASK macro. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_lan_pf_regs.h | 26 ++--- drivers/common/idpf/base/idpf_lan_txrx.h| 116 +--- drivers/co

[PATCH v2 12/17] common/idpf/base: refine comments and alignment

2023-08-25 Thread Simei Su
Refine the macros and definitions by using 'tab' spaces and new lines wherever necessary. Also refine the comment in 'idpf_ctlq_setup_regs' and remove the TODO comment in idpf_rss_hash enum as it doesn't make any sense. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common

[PATCH v2 10/17] common/idpf/base: use 'void' return type

2023-08-25 Thread Simei Su
As idpf_ctlq_deinit always returns success, make it 'void' instead of returning only success. This also changes the return type for idpf_deinit_hw as 'void'. Based on the upstream comments, explicit __le16 typecasting is not necessary as CPU_TO_LE16 is already being used. Signed-off-by: Pavan Kum

[PATCH v2 11/17] common/idpf/base: refactor descriptor 'ret val' stripping

2023-08-25 Thread Simei Su
Conditional check is not necessary to strip and get status bits from the descriptor. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_controlq.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/common/idpf/base/idpf_con

[PATCH v2 09/17] common/idpf/base: use local pointer before updating 'CQ out'

2023-08-25 Thread Simei Su
Instead of updating directly to 'cq_out' double pointer, use a local pointer and update only when we return success. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_controlq.c | 43 +--- 1 file changed, 23 insertions(+), 20 deletion

[PATCH v2 08/17] common/idpf/base: define non-flexible size structure for ADI

2023-08-25 Thread Simei Su
Customer has a requirement to use the legacy fixed size, single chunk structure for ADI creation - one chunk for queue and one chunk for vector. This is described in detail in customer case https://issuetracker.google.com/issues/270157802. On the other hand, upstream code review patch has been pos

[PATCH v2 06/17] common/idpf/base: add necessary check

2023-08-25 Thread Simei Su
Add necessary check for payload and message buffer. Signed-off-by: Julianx Grajkowski Signed-off-by: Simei Su --- .mailmap | 1 + drivers/common/idpf/base/idpf_common.c | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap i

[PATCH v2 07/17] common/idpf/base: add union for SW cookie fields in ctlq msg

2023-08-25 Thread Simei Su
Instead of using something like a byte offset, we can add a union to the struct here to enable direct addressing. Signed-off-by: Alan Brady Signed-off-by: Simei Su --- .mailmap | 1 + drivers/common/idpf/base/idpf_controlq_api.h | 5 + 2 files changed, 6

[PATCH v2 05/17] common/idpf/base: add some adi specific fields

2023-08-25 Thread Simei Su
a) Add maximum ADI count in capabilities message b) Add PF side ADI index to create_adi message c) Define another constant to indicate 'Function active' state of ADI Signed-off-by: Shailendra Bhatnagar Signed-off-by: Simei Su --- .mailmap | 1 + drivers/common/idpf/b

[PATCH v2 04/17] common/idpf/base: remove mailbox registers

2023-08-25 Thread Simei Su
Removing mailbox register offsets as the mapping to device register offsets are different between CVL and MEV (they are swapped out) individual drivers will define the offsets based on how registers are hardware addressed. However the it will begin with VDEV_MBX_START offset. Signed-off-by: Madhu

[PATCH v2 03/17] common/idpf/base: initial PTP support

2023-08-25 Thread Simei Su
Adding a few PTP capabilities to determine which PTP features are enabled - legacy cross time, ptm, device clock control, PTP Tx timestamp with direct registers access, PTP Tx timestamp using virtchnl messages. Creating structures and opcodes to support feautres introduced by capabilities. Signed

[PATCH v2 01/17] common/idpf/base: enable support for physical port stats

2023-08-25 Thread Simei Su
Add support to indicate physical port representor and query its statistics. Signed-off-by: Zhenning Xiao Signed-off-by: Jayaprakash Shanmugam Signed-off-by: Simei Su --- .mailmap | 2 + drivers/common/idpf/base/virtchnl2.h | 80 +++- 2 files

[PATCH v2 02/17] common/idpf/base: add miss completion capabilities

2023-08-25 Thread Simei Su
Add miss completion tag to other capabilities list, to indicate support for detecting a miss completion based on the upper bit of the completion tag. Signed-off-by: Josh Hay Signed-off-by: Simei Su --- .mailmap | 1 + drivers/common/idpf/base/virtchnl2.h | 4 2

[PATCH v2 00/17] update idpf base code

2023-08-25 Thread Simei Su
This patch set updates idpf base code. v2: * Add two patches for share code update. * Add version update. * Fix coding style issue. Simei Su (17): common/idpf/base: enable support for physical port stats common/idpf/base: add miss completion capabilities common/idpf/base: initial PTP suppor

Re: [dpdk-dev] [PATCH 0/4] Add external contiguous memory support to Virtio-user

2023-08-25 Thread David Marchand
On Fri, Dec 13, 2019 at 3:13 PM Maxime Coquelin wrote: > > Somme applications/frameworks using DPDK allocate their own memory > for its buffers. This is the case of Seastar, and also VPP. > > It is currently not possible to use Virtio-user PMD with these > applications because Virtio-user requires

Re: 32 bit arch optimization suggestion

2023-08-25 Thread Bruce Richardson
On Fri, Aug 25, 2023 at 11:40:32AM +0200, Morten Brørup wrote: > I was wondering... > > How widely is DPDK used with 32 bit architectures? > > Both phys_addr_t and rte_iova_t are cast as uint64_t in rte_common.h. Should > they be uint32_t on 32 bit arch? > I don't think they can be. Even if the

32 bit arch optimization suggestion

2023-08-25 Thread Morten Brørup
I was wondering... How widely is DPDK used with 32 bit architectures? Both phys_addr_t and rte_iova_t are cast as uint64_t in rte_common.h. Should they be uint32_t on 32 bit arch? If so, the rte_mbuf structure has 12 unused byte in the first cache line on 32 bit arch. Now, moving the "next" (

Re: cache thrashing question

2023-08-25 Thread Bruce Richardson
On Fri, Aug 25, 2023 at 11:06:01AM +0200, Morten Brørup wrote: > +CC mempool maintainers > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Friday, 25 August 2023 10.23 > > > > On Fri, Aug 25, 2023 at 08:45:12AM +0200, Morten Brørup wrote: > > > Bruce, > > > > > > With thi

RE: [PATCH v11 06/16] eal: use prefetch intrinsics

2023-08-25 Thread Morten Brørup
Regarding the vhost lib... > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, 24 August 2023 14.26 > > On Thu, Aug 24, 2023 at 2:06 PM David Marchand > wrote: > > I had a look at the vhost library and I think the compiler thinks size may > be 0. > > Changing the loop on

RE: [PATCH v1 5/5] net/cpfl: add fxp flow engine

2023-08-25 Thread Xing, Beilei
> -Original Message- > From: Zhang, Yuying > Sent: Saturday, August 12, 2023 3:55 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Wu, Jingjing > Cc: Zhang, Yuying > Subject: [PATCH v1 5/5] net/cpfl: add fxp flow engine > > Adapt fxp low level as a flow engine. > > Signed-off-b

RE: cache thrashing question

2023-08-25 Thread Morten Brørup
+CC mempool maintainers > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 25 August 2023 10.23 > > On Fri, Aug 25, 2023 at 08:45:12AM +0200, Morten Brørup wrote: > > Bruce, > > > > With this patch [1], it is noted that the ring producer and consumer data > should not be

Re: [PATCH v2] eal: provide per lcore macros for MSVC

2023-08-25 Thread David Marchand
On Tue, Jul 11, 2023 at 6:10 PM Stephen Hemminger wrote: > > On Tue, 11 Jul 2023 08:52:27 -0700 > Tyler Retzlaff wrote: > > > Provide per lcore macros that use __declspec(thread) and uses C23 > > typeof. > > > > Signed-off-by: Tyler Retzlaff > Acked-by: Stephen Hemminger Applied, thanks. --

Re: [PATCH v11 00/16] msvc integration changes

2023-08-25 Thread David Marchand
On Fri, Aug 11, 2023 at 9:21 PM Tyler Retzlaff wrote: > > In accordance with draft plan > http://mails.dpdk.org/archives/web/2023-February/002023.html > introduces conditionally compiled code to enable building with MSVC that > _does not_ require C99/C11 meaning it can be integrated now. > > This

Re: [PATCH v11 07/16] eal: use byte swap intrinsics

2023-08-25 Thread David Marchand
On Fri, Aug 11, 2023 at 9:21 PM Tyler Retzlaff wrote: > > Inline assembly is not supported for MSVC x64 instead expand > use _byteswap_u{ushort,ulong,uint64} intrinsics instead. > > Signed-off-by: Tyler Retzlaff > Acked-by: Morten Brørup For the record, I rebased this patch on top of https://pa

Re: [PATCH v11 06/16] eal: use prefetch intrinsics

2023-08-25 Thread David Marchand
On Thu, Aug 24, 2023 at 5:54 PM Tyler Retzlaff wrote: > > On Thu, Aug 24, 2023 at 04:18:06PM +0200, David Marchand wrote: > > On Thu, Aug 24, 2023 at 2:47 PM Morten Brørup > > wrote: > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > > However, I am a bit puzzled why the prefe

Re: [PATCH v5 0/4] enable use of the MSVC compiler

2023-08-25 Thread David Marchand
On Wed, Aug 16, 2023 at 11:56 PM Tyler Retzlaff wrote: > > Introduce minimum changes to the build system to allow use of the MSVC > compiler. > > This change is intended to enable a phased approach to allowing DPDK to > built with MSVC. Building with MSVC removes barriers to enterprise > customers

RE: [PATCH v1 4/5] net/cpfl: add fxp rule module

2023-08-25 Thread Xing, Beilei
> -Original Message- > From: Zhang, Yuying > Sent: Saturday, August 12, 2023 3:55 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Wu, Jingjing > Cc: Zhang, Yuying > Subject: [PATCH v1 4/5] net/cpfl: add fxp rule module > > Added low level fxp module for rule packing / creation

Re: [PATCH v8 0/3] eal: provide abstracted bit counting functions

2023-08-25 Thread David Marchand
On Tue, Apr 4, 2023 at 2:12 AM Tyler Retzlaff wrote: > > As discussed technical board meeting 2023-02-22 > http://mails.dpdk.org/archives/dev/2023-February/263516.html > > We will bring support in pieces for the MSVC compiler, there will be > some abstractions and functions introduced before the c

[PATCH v3] crypto/ipsec_mb: add digest encrypted feature

2023-08-25 Thread Brian Dooley
AESNI_MB PMD does not support Digest Encrypted. This patch adds a check and support for this feature. Signed-off-by: Brian Dooley --- v2: Fixed CHECKPATCH warning v3: Add Digest encrypted support to docs --- doc/guides/cryptodevs/features/aesni_mb.ini | 1 + drivers/crypto/ipsec_mb/pmd_aesni_m

Re: [PATCH] build: move enabled applications list declaration

2023-08-25 Thread David Marchand
On Fri, Aug 11, 2023 at 3:28 PM David Marchand wrote: > > No functional impact foreseen. Simply move this variable and rename it > for consistency with other similar variables. > > Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by Tyler Retzlaff Applied, thanks. -- David Ma

Re: [PATCH] build: move AVX512 check to x86 config

2023-08-25 Thread David Marchand
On Fri, Aug 11, 2023 at 3:10 PM David Marchand wrote: > > The AVX512 check only matters to x86 compilation with gcc. > Move it where appropriate. > > Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by Tyler Retzlaff Applied, thanks. -- David Marchand

Re: [PATCH v2] remove compatibility wrappers for GCC < 4.8

2023-08-25 Thread David Marchand
On Thu, Aug 24, 2023 at 11:34 AM David Marchand wrote: > > As we made our move to C11, GCC requirements has been bumped. > Wrappers for old versions of GCC can be dropped. > > Signed-off-by: David Marchand > Acked-by: Bruce Richardson Applied, thanks. -- David Marchand

Re: cache thrashing question

2023-08-25 Thread Bruce Richardson
On Fri, Aug 25, 2023 at 08:45:12AM +0200, Morten Brørup wrote: > Bruce, > > With this patch [1], it is noted that the ring producer and consumer data > should not be on adjacent cache lines, for performance reasons. > > [1]: > https://git.dpdk.org/dpdk/commit/lib/librte_ring/rte_ring.h?id=d9f0d

RE: [PATCH] common/idpf: rework single queue Tx function

2023-08-25 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Friday, August 25, 2023 3:21 PM > To: Wu, Jingjing ; Xing, Beilei > ; > Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Wenjun1 ; Su, Simei > > Subject: [PATCH] common/idpf: rework single queue Tx function > > This patch replaces flex Tx descriptor

RE: [PATCH] common/idpf: rework single queue Tx function

2023-08-25 Thread Wu, Wenjun1
> -Original Message- > From: Su, Simei > Sent: Friday, August 25, 2023 3:21 PM > To: Wu, Jingjing ; Xing, Beilei > ; > Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Wenjun1 ; Su, Simei > > Subject: [PATCH] common/idpf: rework single queue Tx function > > This patch replaces flex Tx descriptor

RE: [PATCH v1 4/5] net/cpfl: add fxp rule module

2023-08-25 Thread Xing, Beilei
> -Original Message- > From: Zhang, Yuying > Sent: Saturday, August 12, 2023 3:55 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Wu, Jingjing > Cc: Zhang, Yuying > Subject: [PATCH v1 4/5] net/cpfl: add fxp rule module > > Added low level fxp module for rule packing / creation

Re: [PATCH v2 1/3] eventdev: introduce event dispatcher

2023-08-25 Thread Jerin Jacob
On Thu, Aug 24, 2023 at 4:47 PM Mattias Rönnblom wrote: > > On 2023-08-22 14:32, Jerin Jacob wrote: > >> Well, Eventdev does that already, except on systems where all required > >> event adapters have the appropriate INTERNAL_PORT capability. > > > > Yes. The difference is, one is for HW feature

[PATCH] common/idpf: rework single queue Tx function

2023-08-25 Thread Simei Su
This patch replaces flex Tx descriptor structure with base Tx descriptor. Signed-off-by: Simei Su --- drivers/common/idpf/idpf_common_rxtx.c| 72 +-- drivers/common/idpf/idpf_common_rxtx.h| 2 +- drivers/common/idpf/idpf_common_rxtx_avx512.c | 36 +- driv

Re: [PATCH v1] eventdev/eth_rx: fix null pointer dereference

2023-08-25 Thread Jerin Jacob
On Thu, Aug 24, 2023 at 1:53 PM Ganapati Kundapura wrote: > > On passing NULL as a last parameter to xxx_create_ext_with_params(), > rxa_config_params_validate() uses default values and dereferences > NULL pointer leading to segmentation fault. > > Fixed by returning after using default values wit