error: No probed ethernet devices

Hi team, I am trying to run dpdk-testpmd utility, but I am not able to make it work even though I have already used dpdk-devbind.py utility. I haven't been able to find the solution yet, could you please help me? I get the following output while executing ./usertools/dpdk-devbind.py -s: Networ

RE: [EXT] [PATCH v4 19/19] drivers: remove use of term sanity check

-Original Message- From: Stephen Hemminger Sent: Thursday, August 3, 2023 4:56 AM To: dev@dpdk.org Cc: Stephen Hemminger ; Hemant Agrawal ; Sachin Saxena ; Nithin Kumar Dabilpuram ; Kiran Kumar Kokkilagadda ; Sunil Kumar Kori ; Satha Koteswara Rao Kottidi ; Andrew Rybchenko ; Bruc

RE: [RFC] ring: further performance improvements with C11

> -Original Message- > From: Thomas Monjalon > Sent: Monday, July 31, 2023 7:31 AM > To: Wathsala Wathawana Vithanage > Cc: Honnappa Nagarahalli ; > konstantin.v.anan...@yandex.ru; Ruifeng Wang ; > dev@dpdk.org; nd ; step...@networkplumber.org; > jer...@marvell.com; Morten Brørup ; Tyl

RE: [PATCH v2 3/8] net/rnp: add device init and uninit

Thanks a lot, this problem that I have never been thought about it. Regards Wenbo. -Original Message- From: Stephen Hemminger Sent: 2023年8月3日 0:08 To: Wenbo Cao Cc: Anatoly Burakov ; dev@dpdk.org; ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru Subject: Re: [PATCH v2 3/8] net/rnp:

RE: [PATCH v2 4/8] net/rnp: add mbx basic api feature

Hello, Stephen Fort this struct is used for communicate with firmware or Pf communicate with vf. It is used for sync the communicative event. It isn't used for performance sampling. For u32(uint32_t) is because of the hardware register is 32bit read/write. So this counter size is enouth. >+struct r

RE: [PATCH v2 2/8] net/rnp: add ethdev probe and remove

Hello Stephen, Thanks for your comment. For vfio-pci mode we can support it, but when multiple rerun dpdk-app, In rte_eal_init the logical of vfio will reset pcie. The firmware will be core-dump for read pcie Configuration Space, when the pcie is in reset state. This bug is resolving and testing,

RE: [PATCH] ethdev: introduce generic flow item and action

> -Original Message- > From: Morten Brørup > Sent: Thursday, August 3, 2023 1:56 AM > To: Dumitrescu, Cristian ; Ori Kam > ; Jerin Jacob > Cc: Zhang, Qi Z ; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; david.march...@redhat.com; > Richardson, Bruce ; jer...@marvell.com; > ferruh.yi...@amd

Re: [PATCH] eal/windows: resolve conversion and truncation warnings

On Thu, Aug 03, 2023 at 02:44:45AM +0300, Dmitry Kozlyuk wrote: > 2023-08-02 15:41 (UTC-0700), Tyler Retzlaff: > > one thing that confuses me a little and this change won't break how the > > code already works (just makes the cast redundant) is that for mingw > > sizeof(long) is being reported as 8

Re: [PATCH 1/2] eal: remove RTE_CPUFLAG_NUMFLAGS

On Wed, Aug 2, 2023, 23:12 Sivaprasad Tummala wrote: > This patch removes RTE_CPUFLAG_NUMFLAGS to allow new CPU > features without breaking ABI each time. > I'm not sure I understand the reason for removing the last element canary. It's quite useful in the coffee that you're refactoring. Isn't it

Re: [PATCH] eal/windows: resolve conversion and truncation warnings

2023-08-02 15:41 (UTC-0700), Tyler Retzlaff: > one thing that confuses me a little and this change won't break how the > code already works (just makes the cast redundant) is that for mingw > sizeof(long) is being reported as 8 bytes. > > this is in spec relative to the C standard but it does leav

[PATCH v4 19/19] drivers: remove use of term sanity check

Replace non-inclusive language with better comments. Covers multiple drivers Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +- drivers/common/cnxk/roc_npa.c | 2 +- drivers/common/dpaax/caamflib/desc.h | 2 +- driver

[PATCH v4 18/19] crypto/bcmfs: replace term sanity check

Do not use non-inclusive naming here. Signed-off-by: Stephen Hemminger --- drivers/crypto/bcmfs/hw/bcmfs4_rm.c | 6 +++--- drivers/crypto/bcmfs/hw/bcmfs5_rm.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/bcmfs/hw/bcmfs4_rm.c b/drivers/crypto/bcmfs/hw

[PATCH v4 17/19] net/cxgbe: remove use of term sanity

Remove non-inclusive terminolgy. Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_ethdev.c | 10 ++ drivers/net/cxgbe/cxgbevf_main.c | 4 ++-- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c

[PATCH v4 16/19] net/txgbe: replace term sanity

Don't use term sanity. Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ipsec.c | 2 +- drivers/net/txgbe/txgbe_rxtx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ipsec.c b/drivers/net/txgbe/txgbe_ipsec.c index f9f8108fb894..cadb094

[PATCH v4 15/19] event/opdl: remove term sanity

Don't use non-inclusive term. Signed-off-by: Stephen Hemminger --- drivers/event/opdl/opdl_evdev.c | 2 +- drivers/event/opdl/opdl_evdev_init.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c index 9ce8

[PATCH v4 13/19] net/bnx2x: remove reference to sanity

Replace "sanity check" Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/bnx2x/bnx2x_stats.c | 8 drivers/net/bnx2x/ecore_sp.c| 2 +- drivers/net/bnx2x/elink.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drive

[PATCH v4 14/19] cnxk: replace term sanity

Do not use non-inclusive naming. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_nix_tm_ops.c | 2 +- drivers/common/cnxk/roc_npa.c| 4 ++-- drivers/net/cnxk/cnxk_ethdev.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/common/cnxk/roc_

[PATCH v4 12/19] net/bnxt: replace use of term sanity

Do not use non-inclusive terms. Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- drivers/net/bnxt/hsi_struct_def_dpdk.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 06f1

[PATCH v4 11/19] net/ark: replace use of term sanity

Do not use non inclusive terms. Signed-off-by: Stephen Hemminger --- drivers/net/ark/ark_ethdev.c| 8 drivers/net/ark/ark_ethdev_rx.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index b2995427c8ca

[PATCH v4 10/19] net/sfc: remove term "sanity check"

Remove term sanity check in comment. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko --- drivers/net/sfc/sfc_dp_rx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_dp_rx.h b/drivers/net/sfc/sfc_dp_rx.h index 9f9bf2898881..dfb4fb98844b 100644

[PATCH v4 09/19] net/mlx[45]: remove word sanity

The term "sanity" is on non-inclusive naming list. Remove it from the Nvidia drivers. Signed-off-by: Stephen Hemminger --- drivers/common/mlx5/linux/mlx5_common_os.c | 2 +- drivers/net/mlx4/mlx4.c| 2 +- drivers/net/mlx4/mlx4_flow.c | 6 +++--- drivers/net/mlx5

[PATCH v4 08/19] net/fm10k, net/ixgbe: remove word sanity

Remove non-inclusive term sanity from these Intel drivers. Signed-off-by: Stephen Hemminger --- drivers/net/fm10k/fm10k_ethdev.c | 2 +- drivers/net/fm10k/fm10k_rxtx.c | 2 +- drivers/net/ixgbe/ixgbe_fdir.c | 2 +- drivers/net/ixgbe/ixgbe_ipsec.c | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 2

[PATCH v4 07/19] net/ring: replace use of sanity

Don't use term sanity check Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index c43dccea7ffe..3f8faff2c94b 100644 --- a/drivers/net/

[PATCH v4 06/19] doc/eventdev_pipeline: remove sanity

The word sanity check is unnecessary here. Signed-off-by: Stephen Hemminger --- doc/guides/gpus/cuda.rst | 2 +- doc/guides/sample_app_ug/eventdev_pipeline.rst | 2 +- doc/guides/tools/testbbdev.rst | 8 3 files changed, 6 insertions(+), 6 deletions

[PATCH v4 05/19] lib: replace use of sanity check in comments and messages

Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Signed-off-by: Stephen Hemminger --- lib/graph/graph.c | 2 +- lib/graph/graph_stats.c | 2 +- lib/graph/node.c| 2 +- lib/jobstats/rte_jobstats.c | 6 +++--- lib/metrics/rte_metrics.c | 2 +- lib

[PATCH v4 04/19] examples: remove term sanity

Do not use non-inclusive terms. Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/event_helper.c | 2 +- examples/qos_sched/args.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-secgw/event_helper.c i

[PATCH v4 03/19] test: replace use word sanity

The word "sanity" is on the not-allowed inclusive naming list. Replace the unnecessary usage in tests. Signed-off-by: Stephen Hemminger --- app/test/test_bitmap.c | 4 +-- app/test/test_bpf.c| 6 ++-- app/test/test_common.c | 2 +- app/test/test_distrib

[PATCH v4 02/19] eal: replace use of sanity check in comments and messages

Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- lib/eal/common/eal_common_memory.c | 2 +- lib/eal/common/eal_common_proc.c | 3 ++- lib/eal/common/eal_common_trace.c | 2 +- lib/eal/common/eal_memcfg.h

[PATCH v4 01/19] mbuf: replace term sanity check

Replace rte_mbuf_sanity_check() with rte_mbuf_verify() to match the similar macro RTE_VERIFY() in rte_debug.h The term sanity check is on the Tier 2 list of words that should be replaced. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko Acked-by: Morten Brørup --- app/test/test_mbu

[PATCH v4 00/19] replace use of term "sanity check"

This set of patches removes almost all use of the term sanity check in DPDK. Did not address base drivers which come from vendors. It is up to them to fix that. The term sanity-check and related formats are on the Inclusive Naming Tier 2 (Strongly Consider Replacing) word list. https://inclusivena

Re: Drivers, architectures, processor families, etc.

On Wed, 2 Aug 2023 15:49:54 -0600 Philip Prindeville wrote: > Hi, > > I'm trying to come up with some Kconfig logic for OpenWRT packaging to help > users select the right build options for their hardware. > > Most OpenWRT developers typically cross-compile, so we obviously can't rely > on det

Re: [PATCH] eal/windows: resolve conversion and truncation warnings

On Thu, Aug 03, 2023 at 01:29:00AM +0300, Dmitry Kozlyuk wrote: > 2023-08-02 13:48 (UTC-0700), Tyler Retzlaff: > > * Initialize const int NS_PER_SEC with an integer literal instead of > > double thereby avoiding implicit conversion from double to int. > > > > * Cast the result of the expression

Re: [PATCH] eal/windows: resolve conversion and truncation warnings

2023-08-02 13:48 (UTC-0700), Tyler Retzlaff: > * Initialize const int NS_PER_SEC with an integer literal instead of > double thereby avoiding implicit conversion from double to int. > > * Cast the result of the expression assigned to timspec.tv_nsec to long. Typo: "timespec". > Windows build

Drivers, architectures, processor families, etc.

Hi, I'm trying to come up with some Kconfig logic for OpenWRT packaging to help users select the right build options for their hardware. Most OpenWRT developers typically cross-compile, so we obviously can't rely on detection on the build host as that's rarely the same as the target machine. L

[PATCH v10 13/13] eal: do not define typeof macro when building with MSVC

When building with MSVC do not assume typeof is a macro and don't define a typeof macro that conflicts with C23 typeof keyword. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/include/rte_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/include/rte_common

[PATCH v10 09/13] eal: hide typedefs based on GCC vector extensions

When compiling with MSVC don't expose typedefs based on GCC vector extensions. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/include/generic/rte_vect.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/include/generic/rte_vect.h b/lib/eal/include/generic/rte_v

[PATCH v10 10/13] eal: expand most macros to empty when using MSVC

For now expand a lot of common rte macros empty. The catch here is we need to test that most of the macros do what they should but at the same time they are blocking work needed to bootstrap of the unit tests. Later we will return and provide (where possible) expansions that work correctly for msv

[PATCH v10 05/13] eal: use umonitor umwait and tpause intrinsics

Inline assembly is not supported for MSVC x64 instead use _umonitor, _umwait and _tpause intrinsics. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Konstantin Ananyev --- lib/eal/x86/rte_power_intrinsics.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/e

[PATCH v10 08/13] eal: hide GCC extension based alignment markers

When compiling with MSVC don't expose typedefs used as alignment markers. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/include/rte_common.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h index 15765b4..2f4

[PATCH v10 11/13] eal: exclude exposure of rte atomic APIs for MSVC builds

It's discouraged to use rte_atomics APIs instead standard APIs should be used from C11. Since MSVC is a new toolchain/platform combination block visibility of the rte_atomic APIs from day 1. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/include/generic/rte_atomic.h | 7 +

[PATCH v10 12/13] eal: always define MSVC as little endian

The MSVC compiler does not target big endian platforms so define little endian always. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/include/generic/rte_byteorder.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/include/generic/rte_byteorder.h b/lib/eal/inclu

[PATCH v10 07/13] eal: use byte swap intrinsics

Inline assembly is not supported for MSVC x64 instead expand use _byteswap_u{ushort,ulong,uint64} intrinsics instead. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/include/generic/rte_byteorder.h | 11 +++ lib/eal/x86/include/rte_byteorder.h | 4 2 files ch

[PATCH v10 06/13] eal: use prefetch intrinsics

Inline assembly is not supported for MSVC x64 instead use _mm_prefetch and _mm_cldemote intrinsics. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Konstantin Ananyev --- lib/eal/x86/include/rte_prefetch.h | 25 + 1 file chang

[PATCH v10 04/13] eal: use cpuid and cpuidex intrinsics

Inline assembly is not supported for MSVC x64 instead use __cpuid and __cpuidex intrinsics. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/x86/rte_cpuflags.c | 6 +- lib/eal/x86/rte_cpuid.h | 7 +++ lib/eal/x86/rte_cycles.c | 36 ++

[PATCH v10 03/13] eal: use barrier intrinsics

Inline assembly is not supported for MSVC x64 instead expand rte_compiler_barrier as _ReadWriteBarrier and for rte_smp_mb _m_mfence intrinsics. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson Acked-by: Konstantin Ananyev Acked-by: Morten Brørup --- lib/eal/include/generic/rte_atomic.

[PATCH v10 02/13] eal: use rtm and xtest intrinsics

Inline assembly is not supported for MSVC x64. Convert code to use _xend, _xabort and _xtest intrinsics. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson Acked-by: Konstantin Ananyev Acked-by: Morten Brørup --- config/x86/meson.build| 6 ++ lib/eal/x86/include/rte_rtm.h |

[PATCH v10 01/13] eal: use rdtsc intrinsic

Inline assembly is not supported for MSVC x64. Convert code to use __rdtsc intrinsic. Signed-off-by: Tyler Retzlaff Acked-by: Konstantin Ananyev Acked-by: Morten Brørup --- lib/eal/x86/include/rte_cycles.h | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/e

[PATCH v10 00/13] msvc integration changes

In accordance with draft plan http://mails.dpdk.org/archives/web/2023-February/002023.html introduces conditionally compiled code to enable building with MSVC that _does not_ require C99/C11 meaning it can be integrated now. This series covers minimal changes for item #2 in draft plan for EAL depe

[PATCH] telemetry: avoid truncation of strlcpy return before check

strlcpy returns type size_t when directly assigning to struct rte_tel_data data_len field it may be truncated leading to compromised length check that follows Since the limit in the check is < UINT_MAX the value returned is safe to be cast to unsigned int (which may be narrower than size_t) but on

[PATCH 1/2] eal: remove RTE_CPUFLAG_NUMFLAGS

This patch removes RTE_CPUFLAG_NUMFLAGS to allow new CPU features without breaking ABI each time. Signed-off-by: Sivaprasad Tummala --- lib/eal/arm/include/rte_cpuflags_32.h| 1 - lib/eal/arm/include/rte_cpuflags_64.h| 1 - lib/eal/arm/rte_cpuflags.c | 7 +-- lib/eal/lo

[PATCH 2/2] test/cpuflags: remove RTE_CPUFLAG_NUMFLAGS

This patch removes RTE_CPUFLAG_NUMFLAGS to allow new CPU features without breaking ABI each time. Signed-off-by: Sivaprasad Tummala --- app/test/test_cpuflags.c | 9 - 1 file changed, 9 deletions(-) diff --git a/app/test/test_cpuflags.c b/app/test/test_cpuflags.c index a0e342ae48..2b856

[PATCH] eal/windows: resolve conversion and truncation warnings

* Initialize const int NS_PER_SEC with an integer literal instead of double thereby avoiding implicit conversion from double to int. * Cast the result of the expression assigned to timspec.tv_nsec to long. Windows builds generate integer truncation warning for this assignment since the resul

RE: [PATCH] ethdev: introduce generic flow item and action

> From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Wednesday, 2 August 2023 19.23 > > > From: Ori Kam > > Sent: Wednesday, August 2, 2023 5:06 PM > > > > Hi Qi, > > > > In addition to my previous email, > > I fully support you’re your idea to update the rte_flow API > > s

RE: [PATCH] ethdev: introduce generic flow item and action

> -Original Message- > From: Ori Kam > Sent: Wednesday, August 2, 2023 5:06 PM > To: Ori Kam ; Morten Brørup > ; Dumitrescu, Cristian > ; Jerin Jacob > Cc: Zhang, Qi Z ; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; david.march...@redhat.com; > Richardson, Bruce ; jer...@marvell.com; > fer

[RFC PATCH 1/1] cmdline/dpdk-cmdline-gen: generate boilerplate for simple cmds

Provide a script for application developers to quickly generate the boilerplate code necessary for using the cmdline library. This initial version works only with commands using simple strings and numbers, but this is sufficient for many use-cases. Future extensions could, no doubt, expand support

[RFC PATCH 0/1] make cmdline library easier to use

And now for something completely different... :-) While it's nice that DPDK includes a commandline library for easily adding interactivity to applications, the library itself is a little clunky to use, due to the massive amounts of boilerplate definitions required. Having used it recently on an ap

RE: [PATCH] ethdev: introduce generic flow item and action

> -Original Message- > From: Ori Kam > Sent: Wednesday, August 2, 2023 4:47 PM > To: Morten Brørup ; Dumitrescu, Cristian > ; Jerin Jacob > Cc: Zhang, Qi Z ; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; david.march...@redhat.com; > Richardson, Bruce ; jer...@marvell.com; > ferruh.yi...@am

21.11.5 patches review and test

Hi all, Here is a list of patches targeted for stable release 21.11.5. The planned date for the final release is 22nd August. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validati

Re: [PATCH] eventdev: fix alignment padding

On Tue, May 23, 2023 at 8:45 PM Jerin Jacob wrote: > > On Wed, May 17, 2023 at 7:05 PM Morten Brørup > wrote: > > > Shiva, > > Please send ABI change notice for this for 23.11 NOW. > Once it is Acked and merged. I will merge the patch for 23.11 release. > > I am marking the patch as DEFERRED in

RE: [PATCH] ethdev: introduce generic flow item and action

> -Original Message- > From: Morten Brørup > Sent: Wednesday, August 2, 2023 4:25 PM > To: Dumitrescu, Cristian ; Jerin Jacob > > Cc: Zhang, Qi Z ; tho...@monjalon.net; > or...@nvidia.com; david.march...@redhat.com; Richardson, Bruce > ; jer...@marvell.com; ferruh.yi...@amd.com; > techb

Re: [PATCH v1] eventdev/crypto: flush ops when circ buffer is full

On Tue, Aug 1, 2023 at 11:15 AM Ganapati Kundapura wrote: > > crypto ops from the circ buffer are not getting flushed > to crypto dev when crypto dev becomes busy and circ buffer > gets full. > > This patch flushes ops from circ buffer when circ buffer is full > instead of returning without flushi

Re: [PATCH v2 7/8] net/rnp add devargs runtime parsing functions

On Wed, 2 Aug 2023 08:11:05 + Wenbo Cao wrote: > + if (strcmp(key, RNP_HW_MAC_LOOPBACK_ARG) == 0) { > + uint16_t *n = extra_args; > + *n = (uint16_t)strtoul(value, NULL, 10); > + if (*n == USHRT_MAX && errno == ERANGE) > + return -1

Re: [PATCH v2] eventdev/eth_rx: update adapter create APIs

On Wed, Aug 2, 2023 at 7:58 PM Naga Harish K, S V wrote: > > Hi Jerin, Hi Harish, > > The API “rte_event_eth_rx_adapter_create_with_params()” is an extension to > rte_event_eth_rx_adapter_create() with an additional adapter configuration > params structure. > There is no equivalent API existi

Re: [PATCH v2 4/8] net/rnp: add mbx basic api feature

On Wed, 2 Aug 2023 08:11:02 + Wenbo Cao wrote: > +struct rnp_mbx_stats { > + u32 msgs_tx; > + u32 msgs_rx; > + > + u32 acks; > + u32 reqs; > + u32 rsts; > +}; Easy to cause wraparound of 32 bits in these stats. Why use u32 and not uint32_t or uint64_t. > +struct rnp_mbx

Re: [PATCH v2] build: check drivers class dependencies early

On Tue, Aug 01, 2023 at 03:01:31PM +0100, Bruce Richardson wrote: > On Tue, Aug 01, 2023 at 03:41:33PM +0200, David Marchand wrote: > > Drivers implementing a class of devices (for example, drivers/event) > > depend on the associated abstraction library (lib/eventdev). > > This dependency is expres

Re: [PATCH v2 3/8] net/rnp: add device init and uninit

On Wed, 2 Aug 2023 08:11:01 + Wenbo Cao wrote: > +struct rnp_hw { > + void *back; > + char *iobar0; > + uint32_t iobar0_len; > + char *iobar4; > + uint32_t iobar4_len; If possible, don't use untyped pointer for link list (back). The iobar's should probably be void * or b

Re: [PATCH v2 2/8] net/rnp: add ethdev probe and remove

On Wed, 2 Aug 2023 08:11:00 + Wenbo Cao wrote: > +RTE_PMD_REGISTER_PCI(net_rnp, rte_rnp_pmd); > +RTE_PMD_REGISTER_PCI_TABLE(net_rnp, pci_id_rnp_map); > +RTE_PMD_REGISTER_KMOD_DEP(net_txgbe, "igb_uio | uio_pci_generic"); Will this driver work with VFIO? Vfio is preferred over igb_uio.

RE: [PATCH] ethdev: introduce generic flow item and action

Hi Qi, In addition to my previous email, I fully support you’re your idea to update the rte_flow API so it will be easier for P4 integration, I just think the suggested approach is not the correct one at least not as appears in the RFC. I think it will be good if we can discuss some uses cases

Re: [PATCH v3] Add support for IBM Z s390x

It looks like this is still from v2, v3 (fixes the build issue, missing operator) was submit the same day.. The abi-test failure referenced is present on v3 (which the bot has only accepted today). Patch v4 will be split as requested. Thanks. - David Miller On Wed, Aug 2, 2023 at 10:34 AM David

RE: [PATCH] ethdev: introduce generic flow item and action

Hi Qi > -Original Message- > From: Morten Brørup > Sent: Wednesday, August 2, 2023 6:25 PM > > > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > > Sent: Wednesday, 2 August 2023 16.06 > > > > > From: Jerin Jacob > > > Sent: Wednesday, August 2, 2023 12:22 PM > > > >

Re: [PATCH v3] Add support for IBM Z s390x

Hello, I'm happy to split it, I will resubmit when these changes are made. I was planning to spend some time to figure out why the CI abi test is failing / it had previously passed all tests locally. The (one) long term maintainer will be Mathew S Thoennes . I will relay your concerns about CI

Re: [PATCH v3] Add support for IBM Z s390x

Hello David, On Wed, Jul 26, 2023 at 3:35 AM David Miller wrote: > > Minimal changes to drivers and app to support the IBM s390x. This seems a bit more than "minimal changes" :-). > > Signed-off-by: David Miller > Reviewed-by: Mathew S Thoennes > --- > app/test-acl/main.c

RE: [PATCH] ethdev: introduce generic flow item and action

> From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Wednesday, 2 August 2023 16.06 > > > From: Jerin Jacob > > Sent: Wednesday, August 2, 2023 12:22 PM > > > > On Wed, Aug 2, 2023 at 4:31 PM Morten Brørup > > wrote: > > > > > > > From: Morten Brørup [mailto:m...@smartshar

[Bug 1271] Using dumpcap to capture packets with multiple pmds and enable mbuf check can lead to dpdk proc core

https://bugs.dpdk.org/show_bug.cgi?id=1271 Bug ID: 1271 Summary: Using dumpcap to capture packets with multiple pmds and enable mbuf check can lead to dpdk proc core Product: DPDK Version: 23.11 Hardware: All

RE: [dpdk-dev] [PATCH] update Intel roadmap for 21.11

Hi Thomas, There is one patch needs review, we can remove it if it gets merged. http://patches.dpdk.org/project/dpdk/patch/20230627132421.1946338-1-abdullah.sevin...@intel.com/ -Original Message- From: Thomas Monjalon Sent: Monday, July 31, 2023 7:17 AM To: Mcnamara, John ; Sevincer, A

RE: [PATCH] ethdev: introduce generic flow item and action

> From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Wednesday, 2 August 2023 16.06 > > Hi Morten, > > Thanks for your reply, comments inline below. > > > From: Morten Brørup > > Sent: Wednesday, August 2, 2023 11:25 AM > > > > > From: Qi Zhang [mailto:qi.z.zh...@intel.co

RE: [PATCH v2] eventdev/eth_rx: update adapter create APIs

Hi Jerin, The API “rte_event_eth_rx_adapter_create_with_params()” is an extension to rte_event_eth_rx_adapter_create() with an additional adapter configuration params structure. There is no equivalent API existing today for the “rte_event_eth_rx_adapter_create_ext()” API which takes additi

RE: [PATCH] ethdev: introduce generic flow item and action

> -Original Message- > From: Jerin Jacob > Sent: Wednesday, August 2, 2023 12:22 PM > To: Morten Brørup > Cc: Zhang, Qi Z ; tho...@monjalon.net; > or...@nvidia.com; david.march...@redhat.com; Richardson, Bruce > ; jer...@marvell.com; ferruh.yi...@amd.com; > techbo...@dpdk.org; Mcnamara,

RE: [PATCH] ethdev: introduce generic flow item and action

Hi Morten, Thanks for your reply, comments inline below. > -Original Message- > From: Morten Brørup > Sent: Wednesday, August 2, 2023 11:25 AM > To: Zhang, Qi Z ; tho...@monjalon.net; > or...@nvidia.com; david.march...@redhat.com; Richardson, Bruce > ; jer...@marvell.com; ferruh.yi...@am

Re: [PATCH v4] build: update DPDK to use C11 standard

On Wed, Aug 2, 2023 at 2:32 AM David Marchand wrote: > What about the LTS releases testing? > > > -- > David Marchand > > Okay, we will disable rhel7 testing for dpdk main and next branches, but leave testing on for the LTS releases.

Re: [PATCH] ci: fix race on container image name

David Marchand writes: > We had a race on the container image name when the prepare job was > running a day before the build job was triggered. > > Example: > - a prepare job generated image name on 2023/08/01: > > 2023-08-01T23:59:32.9711845Z ++ date -u +%Y-%m-%d > 2023-08-01T23:59:32.971348

Re: [PATCH v5] build: update DPDK to use C11 standard

On Wed, Aug 02, 2023 at 01:31:34PM +0100, Bruce Richardson wrote: > As previously announced, DPDK 23.11 will require a C11 supporting > compiler and will use the C11 standard in all builds. > > Forcing use of the C standard, rather than the standard with > GNU extensions, means that some posix def

[PATCH v5] build: update DPDK to use C11 standard

As previously announced, DPDK 23.11 will require a C11 supporting compiler and will use the C11 standard in all builds. Forcing use of the C standard, rather than the standard with GNU extensions, means that some posix definitions which are not in the C standard are unavailable by default. We fix

[Bug 1270] drivers/dma/skeleton/ is not setting pthread affinity based on the lcore shared as arguments

https://bugs.dpdk.org/show_bug.cgi?id=1270 Bug ID: 1270 Summary: drivers/dma/skeleton/ is not setting pthread affinity based on the lcore shared as arguments Product: DPDK Version: 23.07 Hardware: All OS: Li

RE: [PATCH] net/mlx5: fix leak in sysfs port name translation

> -Original Message- > From: David Marchand > Sent: Tuesday, August 1, 2023 6:19 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Bing Zhao > Subject: [PATCH] net/mlx5: fix leak in sysfs port name translation > > getline() may allo

Re: [PATCH] ethdev: introduce generic flow item and action

On Wed, Aug 2, 2023 at 4:31 PM Morten Brørup wrote: > > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > Sent: Wednesday, 2 August 2023 12.25 > > > > > From: Qi Zhang [mailto:qi.z.zh...@intel.com] > > > Sent: Wednesday, 2 August 2023 19.35 > > > > > > From: Cristian Dumitrescu > > >

RE: [PATCH] ethdev: introduce generic flow item and action

> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Wednesday, 2 August 2023 12.25 > > > From: Qi Zhang [mailto:qi.z.zh...@intel.com] > > Sent: Wednesday, 2 August 2023 19.35 > > > > From: Cristian Dumitrescu > > > > For network devices that are programmable through languages such a

RE: [PATCH] ethdev: introduce generic flow item and action

> From: Qi Zhang [mailto:qi.z.zh...@intel.com] > Sent: Wednesday, 2 August 2023 19.35 > > From: Cristian Dumitrescu > > For network devices that are programmable through languages such as > the P4 language, there are no pre-defined flow items and actions. > > The format of the protocol header a

Re: [PATCH v3] build: update DPDK to use C11 standard

On Tue, Aug 01, 2023 at 03:00:06PM +0100, Bruce Richardson wrote: > +David Christensen > > On Tue, Aug 01, 2023 at 01:47:19PM +, Ali Alnubani wrote: > > > -Original Message- > > > From: Bruce Richardson > > > Sent: Tuesday, August 1, 2023 4:22 PM > > > To: Ali Alnubani > > > Cc: Davi

Re: [PATCH v1] mempool: fix some errors in html api

> > So, how do we want to fix this: > > 1. Specify the allowed return values in the documentation for the mempool > library callback types, and require the mempool drivers to follow the updated > specification? > 2. Update mempool API documentation to list the many currently possible error

RE: [RFC] ring: further performance improvements with C11

> For improved performance over the current C11 based ring implementation > following changes were made. > (1) Replace tail store with RELEASE semantics in __rte_ring_update_tail > with a RELEASE fence. Replace load of the tail with ACQUIRE semantics > in __rte_ring_move_prod_head and __rte_ring

RE: [PATCH] ethdev: introduce generic flow item and action

> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, August 3, 2023 1:35 AM > To: tho...@monjalon.net; or...@nvidia.com; david.march...@redhat.com; > Richardson, Bruce ; jer...@marvell.com; > ferruh.yi...@amd.com > Cc: cristian.dumiter...@intel.com; techbo...@dpdk.org; Mcnamara, J

RE: [RFC] lib/ethdev: introduce table driven APIs

> -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, July 19, 2023 2:39 PM > To: Ori Kam ; Jerin Jacob ; > Zhang, Qi Z > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > david.march...@redhat.com; Richardson, Bruce > ; jer...@marvell.com; ferruh.yi...@amd.com; > Mcnamara,

[PATCH] ethdev: introduce generic flow item and action

From: Cristian Dumitrescu For network devices that are programmable through languages such as the P4 language, there are no pre-defined flow items and actions. The format of the protocol header and metadata fields that are used to specify the flow items that make up the flow pattern, as well as

RE: [PATCH v1] mempool: fix some errors in html api

+CC various mempool driver maintainers > From: Rma Ma [mailto:rma...@jaguarmicro.com] > Sent: Monday, 3 July 2023 08.18 > > This patch fix some error descriptions of > return value in mempool api which affect in html api. > > Signed-off-by: Rma Ma > --- > lib/mempool/rte_mempool.h | 12 ++-

[PATCH v2 8/8] net/rnp handle device interrupts

Handle device lsc interrupt event Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 5 + drivers/net/rnp/base/rnp_mac_regs.h | 279 drivers/net/rnp/rnp.h | 8 + drivers/net/rnp/rnp_ethdev.c| 17 ++ drivers/net/rnp/rnp_mbx.h

[PATCH v2 3/8] net/rnp: add device init and uninit

Add basic init and uninit function Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 18 drivers/net/rnp/meson.build | 1 + drivers/net/rnp/rnp.h | 25 + drivers/net/rnp/rnp_ethdev.c | 196 +- drivers/net/rnp/rnp_logs.h| 34

[PATCH v2 7/8] net/rnp add devargs runtime parsing functions

add various runtime devargs command line options supported by this driver. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp.h| 22 + drivers/net/rnp/rnp_ethdev.c | 164 +++ drivers/net/rnp/rnp_mbx_fw.c | 164 +++ driver

[PATCH v2 6/8] net/rnp add port info resource init

Add Api For FW Mac Info, Port Resoucre info init Code For Different Shape Of Nic Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_api.c | 48 +++ drivers/net/rnp/base/rnp_api.h | 10 ++ drivers/net/rnp/base/rnp_hw.h | 19 +++ drivers/net/rnp/meson.build| 1 + drivers/net/rnp/r

[PATCH v2 2/8] net/rnp: add ethdev probe and remove

Add basic PCIe ethdev probe and remove. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp.h| 13 ++ drivers/net/rnp/rnp_ethdev.c | 83 2 files changed, 96 insertions(+) create mode 100644 drivers/net/rnp/rnp.h diff --git a/drivers/net/rnp/rnp.h b

  1   2   >