[AMD Official Use Only - General]
@Yigit, Ferruh thanks for bringing this to my attention,
The output of the modified
```
Socket 0 Numa 0
---
Core 0 [0, 128]
Core 1 [1, 129]
Core 2 [2, 130]
Core 3 [3, 131]
.
Core 29 [29, 157]
Core 30 [30, 158]
Co
10/07/2023 23:29, Tyler Retzlaff:
> Provide per lcore macros that use __declspec(thread) and uses C23
> typeof.
>
> Signed-off-by: Tyler Retzlaff
> ---
> +#ifndef RTE_TOOLCHAIN_MSVC
> /**
> * Macro to define a per lcore variable "var" of type "type", don't
> * use keywords like "static" or "
10/07/2023 16:41, Stephen Hemminger:
> On Mon, 10 Jul 2023 09:55:59 +0100
> Ferruh Yigit wrote:
>
> > On 7/10/2023 3:32 AM, Rongwei Liu wrote:
> > > Hi Ferruh & Andrew & Ori & Thomas:
> > > Sorry, we can't commit the PMD implementation for "IPv6 extension push
> > > remove" feature in time for
Provide driver flag which gives an option to map the cdx
device resource before probing the device driver.
Also, make rte_cdx_map_device() API as public to map
device resource separately.
Signed-off-by: Abhijit Gangurde
---
v3:
- Changed APIs to __rte_experimental.
v2:
- Corrected _RTE_BUS_C
> Replace explicit packet offset computations with
> rte_pktmbuf_mtod_offset().
>
> Signed-off-by: Stephen Hemminger
Acked-by: Anoob Joseph
> Replace explicit packet offset computations with
> rte_pktmbuf_mtod_offset().
>
> Signed-off-by: Stephen Hemminger
Acked-by: Anoob Joseph
> -Original Message-
> From: markus.th...@tu-ilmenau.de
> Sent: Thursday, July 6, 2023 7:45 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; Zhang, Qi Z
> ; Michael Rossberg ilmenau.de>
> Subject: [PATCH] net/ice: allow setting CIR
>
> From: Michael Rossberg
>
> ice only allowed to set peak
Acked-by: Gowrishankar Muthukrishnan
UDP header and L2 header (if any) length is included in sa->hdr_len.
Take care of that in L3 header and pakcet length calculation.
Fixes: 01eef5907fc3 ("ipsec: support NAT-T")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Liang
Acked-by: Konstantin Ananyev
Acked-by: Radu Nicolau
---
lib/ipsec/esp_o
UDP header and L2 header (if any) length is included in sa->hdr_len.
Take care of that in L3 header and pakcet length caculation.
Fixes: 01eef5907fc3 ("ipsec: support NAT-T")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Liang
Acked-by: Konstantin Ananyev
Acked-by: Radu Nicolau
---
lib/ipsec/esp_ou
Please add Cc.
Reviewed-by: Chengwen Feng
On 2023/7/11 9:18, Kaiyu Zhang wrote:
> sanity check is performed after a rte_eth_dev object is allocated.
> The object is not freed if the check fails, though in the current
> reality this never happens, but it's better programming paradigm
> to move the
On 2023/7/11 1:07, Stephen Hemminger wrote:
> CodeQL is an analyzer (like Coverity) for static analysis
> https://codeql.github.com/
>
> Followup from earlier set from Sinan.
> Rebased to main and consolidated for easier review
>
> Sinan Kaya (4):
> ethdev: check return result of rte_eth_dev
sanity check is performed after a rte_eth_dev object is allocated.
The object is not freed if the check fails, though in the current
reality this never happens, but it's better programming paradigm
to move the quick check up front to the start of
rte_eth_dev_pci_generic_probe.
Signed-off-by: Kaiyu
From: Long Li
The hardware specification specifies that WQE_COUNT should set to 0 for
the Receive Queue. Although currently the hardware doesn't enforce the
check, in the future releases it may check on this value.
Signed-off-by: Long Li
---
Change log:
v2: added "Signed-off-by"
drivers/net/m
From: Long Li
This counter should set to uint16_t, the same type as pkt_received.
Otherwise, it may overflow when pkt_received goes over 256.
Thanks Xinhao Kong for debugging this.
Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
Cc: sta...@dpdk.org
Signed-off-by: Long
Tested-by: Patrick Robb
On Mon, Jul 10, 2023 at 12:23 PM wrote:
> From: Jeremy Spewock
>
> added paramiko to the dependency files
>
> Signed-off-by: Jeremy Spewock
> ---
> dts/poetry.lock| 160 ++---
> dts/pyproject.toml | 1 +
> 2 files changed,
Thanks for the suggestion! It's fixed in the latest version.
On Thu, Jul 6, 2023 at 1:08 PM Stephen Hemminger
wrote:
> On Thu, 29 Jun 2023 17:33:00 +
> Bili Dong wrote:
>
> > +
> > +/**
> > + * The following bytes access helper functions are expected to work
> > + * without any particular i
An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its
use case in P4. We implement it in this patch so it could be easily
registered in the pipeline later.
Signed-off-by: Bili Dong
---
v9:
* Marked internl helper functions as @internal. (re Stephen Hemminger
)
v8:
* Removed unne
From: Long Li
The hardware specification specifies that WQE_COUNT should set to 0 for
the Receive Queue. Although currently the hardware doesn't enforce the
check, in the future releases it may check on this value.
---
drivers/net/mana/mana.h | 2 +-
drivers/net/mana/rx.c | 11 +++
2
From: Long Li
This counter should set to uint16_t, the same type as pkt_received.
Otherwise, it may overflow when pkt_received goes over 256.
Thanks Xinhao Kong for debugging.
Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
Cc: sta...@dpdk.org
---
drivers/net/mana/rx
Provide MSVC compatible macros RTE_DEFINE_PER_LCORE and
RTE_DECLARE_PER_LCORE that expand appropriately for Windows/MSVC
NOTICE:
It is intentional that devtools/checkpatches.pl generates an error
about parenthesis to allow comparison with clang/gcc versions of
these macros which also do not have
Provide per lcore macros that use __declspec(thread) and uses C23
typeof.
Signed-off-by: Tyler Retzlaff
---
lib/eal/include/rte_per_lcore.h | 8
1 file changed, 8 insertions(+)
diff --git a/lib/eal/include/rte_per_lcore.h b/lib/eal/include/rte_per_lcore.h
index eaedf0c..4ef8905 100644
On Wed, Jul 05, 2023 at 03:48:01PM -0700, Stephen Hemminger wrote:
> This aligns getopt, getopt_long, etc to have the same const
> attributes as Linux and FreeBSD. The changes are derived from
> the FreeBSD version of getopt_long.
>
> Signed-off-by: Stephen Hemminger
> ---
Acked-by: Tyler Retzla
Found by devtools/cocci/nullfree.cocci
Fixes: 2d970c663314 ("cryptodev: add asymmetric SM2 algorithm")
Cc: gmuthukri...@marvell.com
Signed-off-by: Stephen Hemminger
---
app/test/test_cryptodev_asym.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/app/test/test_cryptodev_as
>+Would you be able to get an ack from Timothy?
Thanks Thomas, requested ack from Timothy.
On Mon, Jul 03, 2023 at 02:14:06PM +0200, Thomas Monjalon wrote:
> When looking at threads in a system, it can be confusing
> to find some unknown threads without a clue it is started by DPDK.
>
> Let's start all thread names with "dpdk-"
> plus the driver name if it comes from a driver.
>
> One
On 7/10/2023 5:45 PM, Stephen Hemminger wrote:
> On Thu, 17 Mar 2022 19:43:47 +0200
> ido g wrote:
>
>> Support rte_eth_dev_set_mtu by pcap vdevs
>> Enforce mtu on rx/tx
>> For more details see https://bugs.dpdk.org/show_bug.cgi?id=961
>>
>> Signed-off-by: ido g
>
> Feeling less convinced that
From: Sinan Kaya
In rte_eth_vdev_allocate result of call to rte_vdev_device_name is
dereferenced here and may be null.
Signed-off-by: Sinan Kaya
Signed-off-by: Stephen Hemminger
---
lib/ethdev/ethdev_vdev.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ethdev/ethdev_vdev.h b/lib/e
From: Sinan Kaya
In malloc_heap_add_memory result of call to malloc_elem_join_adjacent_free
is dereferenced here and may be null.
In alloc_pages_on_heap result of call to rte_mem_virt2memseg_list
is dereferenced here and may be null.
In eal_memalloc_is_contig result of call to rte_fbarray_get
i
From: Sinan Kaya
In memzone_lookup_thread_unsafe result of call to rte_fbarray_get
is dereferenced here and may be null.
In memzone_reserve_aligned_thread_unsafe result of call
to malloc_elem_from_data is dereferenced here and may be null.
Signed-off-by: Sinan Kaya
Signed-off-by: Stephen Hemmi
From: Sinan Kaya
rte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get
is not checked, potentially leaving dev_info uninitialized.
Signed-off-by: Sinan Kaya
Signed-off-by: Stephen Hemminger
Reviewed-by: Morten Brørup
---
lib/ethdev/rte_class_eth.c | 4 +++-
1 file chang
Patches get flagged as in error if mailmap missing.
Signed-off-by: Stephen Hemminger
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff --git a/.mailmap b/.mailmap
index d200f363394d..91557940e3d9 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1285,6 +1285,7 @@ Simon Ellmann
Simon Horman
Si
CodeQL is an analyzer (like Coverity) for static analysis
https://codeql.github.com/
Followup from earlier set from Sinan.
Rebased to main and consolidated for easier review
Sinan Kaya (4):
ethdev: check return result of rte_eth_dev_info_get
memzone: check result of rte_fbarray_get and malloc
From: Jeremy Spewock
added paramiko to the dependency files
Signed-off-by: Jeremy Spewock
---
dts/poetry.lock| 160 ++---
dts/pyproject.toml | 1 +
2 files changed, 124 insertions(+), 37 deletions(-)
diff --git a/dts/poetry.lock b/dts/poetry.lock
From: Jeremy Spewock
Adds a new test suite for running smoke tests that verify general
configuration aspects of the system under test. If any of these tests
fail, the DTS execution terminates as part of a "fail-fast" model.
Signed-off-by: Jeremy Spewock
---
dts/conf.yaml
From: Jeremy Spewock
This version of the series addresses comments and improvements listed on
the previous non-RFC patch.
RFCs for this patch:
* v3: https://mails.dpdk.org/archives/dev/2023-June/269859.html
* v2: https://mails.dpdk.org/archives/dev/2023-May/267915.html
* v1: https://mails.dpdk.o
On Mon, 10 Jul 2023 09:55:59 +0100
Ferruh Yigit wrote:
> On 7/10/2023 3:32 AM, Rongwei Liu wrote:
> > Hi Ferruh & Andrew & Ori & Thomas:
> > Sorry, we can't commit the PMD implementation for "IPv6 extension push
> > remove" feature in time for this release.
> > There are some dis-agreeme
Hi,
> -Original Message-
> From: Ori Kam
> Sent: Thursday, July 6, 2023 3:36 PM
> To: Matan Azrad ; Slava Ovsiienko
> ; Suanming Mou ; Bing
> Zhao
> Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh
>
> Subject: [PATCH] net/mlx5: fix query for NIC flow cap
>
> Add query for nic flow table s
On 2023-07-07 18:57:12 -0700, Stephen Hemminger wrote:
> Replace explicit packet offset computations with rte_pktmbuf_mtod_offset().
>
> Signed-off-by: Stephen Hemminger
Reviewed-by: Niklas Söderlund
> ---
> drivers/net/nfp/flower/nfp_flower_cmsg.h | 3 ++-
> drivers/net/nfp/flower/nfp_flower
On 7/7/2023 1:17 AM, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> On a fatal CQE error when coalescing is used, update the correct index
> and allow proceeding to the next CQE.
>
> Fixes: 3409e0f172f6 ("net/mana: implement Rx CQE coalescing">
> Signed-off-by: Long Li
>
Applied to dpdk-n
On 7/7/2023 7:01 PM, Long Li wrote:
>> Subject: Re: [PATCH] net/mana: fix wrong indexing on CQE error when
>> coalescing
>> is used
>>
>> On 7/7/2023 1:17 AM, lon...@linuxonhyperv.com wrote:
>>> From: Long Li
>>>
>>> On a fatal CQE error when coalescing is used, update the correct index
>>> and a
Hi,
> -Original Message-
> From: Bing Zhao
> Sent: Friday, June 30, 2023 8:43 AM
> To: Matan Azrad ; Slava Ovsiienko
> ; Ori Kam ; Suanming Mou
> ; Raslan Darawsheh
> Cc: dev@dpdk.org; Michael Baum
> Subject: [PATCH 1/7] net/mlx5: fix the modify field check of tag
>
> The new member "t
On 7/10/2023 8:39 AM, Ori Kam wrote:
> Hi Bing
>
>> -Original Message-
>> From: Bing Zhao
>> Sent: Friday, June 30, 2023 4:30 PM
>>
>> When creating a template table, the object pointer of the
>> command line "struct context" was set with an offset from the
>> original out buffer if there
On 10-Jul-23 10:24 AM, Konstantin Ananyev wrote:
07/07/2023 14:26, Radu Nicolau пишет:
On 07-Jul-23 1:51 PM, Xiao Liang wrote:
sa->hdr_len and prm->tun.hdr_len don't include L2 length so both
should
start in the diagram at the end of the ETH header.
So the right way to compute datagram len
On Mon, Jul 10, 2023 at 1:09 PM Zhirun Yan wrote:
>
> This function is used for mcore dispatch model only, correct the check to
> make sure it is the expected model. And specific the model by
> rte_graph_worker_model_set() before call it in test. Update release notes
> for new mcore dispatch model
07/07/2023 14:26, Radu Nicolau пишет:
On 07-Jul-23 1:51 PM, Xiao Liang wrote:
sa->hdr_len and prm->tun.hdr_len don't include L2 length so both should
start in the diagram at the end of the ETH header.
So the right way to compute datagram length is
dgram_len = mb->pkt_len - sqh_len - sa->hdr_l
On Mon, Jul 10, 2023 at 1:09 PM Zhirun Yan wrote:
>
> rte_graph_clone() should use valid param rather than NULL pointer, cause it
rte_graph_clone() should use a valid param rather than NULL pointer as
> needs the param for alloc work queue memory for mcore dispatch model in
> graph_sched_wq_crea
18/04/2023 09:46, Xiao Liang пишет:
UDP header length is included in sa->hdr_len. Take care of that in
L3 header and pakcet length calculation.
Fixes: 01eef5907fc3 ("ipsec: support NAT-T")
Signed-off-by: Xiao Liang
---
lib/ipsec/esp_outb.c | 2 +-
lib/ipsec/sa.c | 2 +-
2 files chang
On 7/10/2023 3:32 AM, Rongwei Liu wrote:
> Hi Ferruh & Andrew & Ori & Thomas:
> Sorry, we can't commit the PMD implementation for "IPv6 extension push
> remove" feature in time for this release.
> There are some dis-agreements which need to be addressed internally.
> We will con
Currently available NVIDIA NICs and DPUs
do not have a capability to calculate the UDP checksum
in the header added using encapsulation flow actions.
This limitation was not documented in mlx5 PMD docs.
This patch adds this limitation to the docs and
describes application requirements.
Signed-off
On 7/8/2023 2:52 AM, Stephen Hemminger wrote:
> On Fri, 7 Jul 2023 20:43:51 +
> Long Li wrote:
>
>>> Subject: Re: [PATCH] net/netvsc: set the correct queue state
>>>
>>> On Fri, 7 Jul 2023 11:53:16 -0700
>>> lon...@linuxonhyperv.com wrote:
>>>
From: Long Li
Set the queue s
Hi Thomas,
On 2023/7/10 14:49, Thomas Monjalon wrote:
> 09/07/2023 05:23, fengchengwen:
>> Hi Thomas,
>>
>> On 2023/7/7 18:40, Thomas Monjalon wrote:
>>> 26/05/2023 10:42, Chengwen Feng:
Add tracepoints at important APIs for tracing support.
Signed-off-by: Chengwen Feng
Acked-
Hi Bing
> -Original Message-
> From: Bing Zhao
> Sent: Friday, June 30, 2023 4:30 PM
>
> When creating a template table, the object pointer of the
> command line "struct context" was set with an offset from the
> original out buffer if there is a template ID.
>
> If the "rules_number" i
This function is used for mcore dispatch model only, correct the check to
make sure it is the expected model. And specific the model by
rte_graph_worker_model_set() before call it in test. Update release notes
for new mcore dispatch model.
Fixes: ecb22a294980 ("graph: introduce graph bind unbind A
rte_graph_clone() should use valid param rather than NULL pointer, cause it
needs the param for alloc work queue memory for mcore dispatch model in
graph_sched_wq_create().
Fixes: 67e2303cd823 ("test/graph: add functional tests for mcore dispatch
model")
Signed-off-by: Zhirun Yan
---
app/test/
Fix graph clone issue in functional test.
Correct graph model check in graph core binding.
Update release note for mcore dispatch model.
Zhirun Yan (2):
graph: fix graph functional tests with valid params
graph: fix graph model check in core binding
app/test/test_graph.c |
56 matches
Mail list logo
