RE: [PATCH v2 02/22] lib: add pdcp protocol

2023-05-17 Thread Anoob Joseph
Hi Akhil, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 16, 2023 9:01 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Mattia

RE: [PATCH v2 08/22] pdcp: add IV generation routines

2023-05-17 Thread Akhil Goyal
> Subject: [PATCH v2 08/22] pdcp: add IV generation routines > > For PDCP, IV generated has varying formats depending on the ciphering and > authentication algorithm used. Add routines to populate IV accordingly. > > Signed-off-by: Anoob Joseph > Signed-off-by: Volodymyr Fialko > --- > lib/pdc

RE: [PATCH v2 07/22] pdcp: add pre and post process for DL

2023-05-17 Thread Akhil Goyal
> static int > pdcp_pre_post_func_set(struct rte_pdcp_entity *entity, const struct > rte_pdcp_entity_conf *conf) > { > + struct entity_priv *en_priv = entity_priv_get(entity); > + > entity->pre_process = NULL; > entity->post_process = NULL; > > @@ -342,6 +756,13 @@ pdcp_pre_post

RE: [PATCH v2 06/22] pdcp: add pre and post process for UL

2023-05-17 Thread Akhil Goyal
> Subject: [PATCH v2 06/22] pdcp: add pre and post process for UL > > Add routines to perform pre & post processing based on the type of > entity. To avoid checks in datapath, there are different function > pointers registered based on the following, > 1. Control plane v/s user plane > 2. 12 bit v

Re: [PATCH 1/5] common/cnxk: fix IPsec IPv6 tunnel address byte swap

2023-05-17 Thread Jerin Jacob
On Tue, Apr 25, 2023 at 4:11 PM Rahul Bhansali wrote: > > Fix the IPsec IPv6 tunnel address bytes swap during SA > configurations in session create/update. > > Fixes: 78d03027f2c ("common/cnxk: add IPsec common code") Fix the following in the series Is it candidate for Cc: sta...@dpdk.org backp

RE: [PATCH v1 3/7] doc: fix wrong indentation in RSS action description

2023-05-17 Thread Ori Kam
Hi Michael, > -Original Message- > From: Michael Baum > Sent: Tuesday, May 16, 2023 9:38 AM > > The RSS action description inside "Generic flow API (rte_flow)" > documentation, lists the values supported for a encapsulation level > field. > > For "2" value, it uses 3 spaces as an indent

Minutes of Technical Board Meeting, 2023-02-08

2023-05-17 Thread Hemant Agrawal
NOTE: The technical board meetings are on every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK community members are welcome to attend. NOTE: Next meeting will be on Wednesday 2023-02-22 @3pm UTC, and will be chaired by Honnappa. Members Attending --

Re: [PATCH 02/21] common/cnxk: add pool BPID to RQ while using common pool

2023-05-17 Thread Jerin Jacob
On Tue, Apr 11, 2023 at 2:42 PM Nithin Dabilpuram wrote: > > From: Shijith Thotton > > When RQs of two different traffic classes are using the same mempool, > BPIDs could differ between the RQs and BPID of only one RQ can be > configured per pool. In such cases, a new BPID is configured on both R

Re: [PATCH 21/21] common/cnxk: support of 1:n pool:aura per NIX LF

2023-05-17 Thread Jerin Jacob
On Tue, Apr 11, 2023 at 2:44 PM Nithin Dabilpuram wrote: > > From: Rahul Bhansali > > This will add the support of 1:n pool:aura per NIX LF when > inl_cpt_channel devargs is set to inline device, otherwise > it will create 1:1 pool:aura for CN103/CN106B0 SOCs. > > With 1:N, global pool will be cr

RE: [PATCH] net/bonding: replace master/slave to main/member

2023-05-17 Thread Chaoyong He
> On Wed, 17 May 2023 14:59:05 +0800 > Chaoyong He wrote: > > > This patch replaces the usage of the word 'master/slave' with more > > appropriate word 'main/member' in bonding PMD as well as in its docs > > and examples. Also the test app and testpmd were modified to use the > > new wording. >

Re: [PATCH] app/test-pmd : Add 2.5Gbps and 5Gbps support to test-pmd

2023-05-17 Thread Stephen Hemminger
On Thu, 18 May 2023 01:16:14 +0200 julien_d...@jaube.fr wrote: > From: Julien Aube > > Signed-off-by: Julien Aube Enumerating all possible speeds is getting cumbersome, maybe time for a change Acked-by: Stephen Hemminger

RE: [PATCH 07/20] net/nfp: remove word sanity

2023-05-17 Thread Chaoyong He
That looks good, thanks! Actually, we also will delete it in an upcoming patch, so it's okay to remove it here. Reviewed-by: Chaoyong He > -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 18, 2023 12:16 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Chaoyong He > ;

[PATCH v2] drivers/net/bnx2x : Add experimental 2.5Gbps support for BCM578xx.

2023-05-17 Thread julien_dpdk
From: Julien Aube This has been tested with GPON's ONU SFP but requires a specific firmware configuration. Signed-off-by: Julien Aube --- doc/guides/nics/bnx2x.rst | 4 drivers/net/bnx2x/elink.c | 19 +-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/doc

[PATCH v2] app/test-pmd : Add 2.5Gbps and 5Gbps support to test-pmd

2023-05-17 Thread julien_dpdk
From: Julien Aube This extends the support for 2.5iG and 5G NIC commonly found today Signed-off-by: Julien Aube --- app/test-pmd/cmdline.c | 14 +- app/test-pmd/parameters.c | 6 ++ doc/guides/testpmd_app_ug/run_app.rst | 2 ++ doc

RE: [PATCH v14] app/procinfo: display eventdev xstats

2023-05-17 Thread Sevincer, Abdullah
> +The cast will cause truncation of large values, so this might be a nop. > +If you really want to check, then something like: > + unsigned long evdev_id; > + char *endp; > + evdev_id = strtoul(list, &endp, 0); > + if (!*list || !*endp || evdev_id >= RTE_EVENT_MAX_DEVS) { > +

[PATCH] drivers/net/bnx2x : Add experimental 2.5Gbps support for BCM578xx.

2023-05-17 Thread julien_dpdk
From: Julien Aube This has been tested with GPON's ONU SFP but requires a specific firmware configuration. Signed-off-by: Julien Aube --- doc/guides/nics/bnx2x.rst | 4 drivers/net/bnx2x/elink.c | 20 ++-- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/d

[PATCH] drivers/net/bnx2x : Offer maintainership for bnx2x

2023-05-17 Thread julien_dpdk
From: Julien Aube Signed-off-by: Julien Aube --- MAINTAINERS | 1 + doc/guides/rel_notes/deprecation.rst | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8df23e5099..c5a65c2684 100644 --- a/MAINTAINERS +++ b/MAINTAIN

[PATCH] app/test-pmd : Add 2.5Gbps and 5Gbps support to test-pmd

2023-05-17 Thread julien_dpdk
From: Julien Aube Signed-off-by: Julien Aube --- app/test-pmd/cmdline.c | 16 ++-- app/test-pmd/parameters.c | 6 ++ doc/guides/testpmd_app_ug/run_app.rst | 2 ++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- 4 files changed,

RE: [PATCH 01/20] mbuf: replace term sanity check

2023-05-17 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 17 May 2023 18.16 > > The term sanity check is on the Tier 2 list of words > that should be replaced. > > Signed-off-by: Stephen Hemminger > --- Naming is hard... I have shared a bunch of unfiltered thoughts below,

Re: [PATCH v14] app/procinfo: display eventdev xstats

2023-05-17 Thread Stephen Hemminger
On Wed, 17 May 2023 17:37:24 -0500 Abdullah Sevincer wrote: > +static int > +parse_eventdev_dump_xstats_params(char *list) > +{ > + uint8_t evdev_id; > + evdev_id = (uint8_t)atoi(list); > + > + if (evdev_id >= RTE_EVENT_MAX_DEVS) { > + printf("Invalid eventdev id, id shoul

[PATCH v14] app/procinfo: display eventdev xstats

2023-05-17 Thread Abdullah Sevincer
This commit extends proc-info application to display xstats for the eventdev devices. New command line arguments are introduced to display xstats for eventdev devices. The command example is like: For displaying a specific port stats (e.g. port 1): ./dpdk-proc-info -- --show-edev-port-xstats=1:0

Re: [PATCH] net/gve: support queue start and stop operations

2023-05-17 Thread Ferruh Yigit
On 5/9/2023 4:07 AM, Junfeng Guo wrote: > Add support for queue operations for GQI: > - gve_rx_queue_start > - gve_tx_queue_start > - gve_rx_queue_stop > - gve_tx_queue_stop > > Add support for queue operations for DQO: > - gve_rx_queue_start_dqo > - gve_tx_queue_start_dqo > - gve_rx_queue_

Re: [PATCH 00/20] Replace use of term sanity-check

2023-05-17 Thread Tyler Retzlaff
On Wed, May 17, 2023 at 09:15:43AM -0700, Stephen Hemminger wrote: > This set of patches removes almost all use of the term sanity > in DPDK. The term sanity-check and related formats are on the > Inclusive Naming Tier 2 (Strongly Consider Replacing) word list. > https://inclusivenaming.org/word-li

Re: [PATCH 0/2] net/hns3: add some features for hns3 pmd

2023-05-17 Thread Ferruh Yigit
On 4/21/2023 10:53 AM, Dongdong Liu wrote: > This patchset is to add some features for hns3 pmd. > > Chengwen Feng (1): > net/hns3: support dump media type > > Dongdong Liu (1): > net/hns3: simplify for hardware csum offloading Series applied to dpdk-next-net/main, thanks.

[PATCH v13] app/procinfo: display eventdev xstats

2023-05-17 Thread Abdullah Sevincer
This commit extends proc-info application to display xstats for the eventdev devices. New command line arguments are introduced to display xstats for eventdev devices. The command example is like: For displaying a specific port stats (e.g. port 1): ./dpdk-proc-info -- --show-edev-port-xstats=1:0

[PATCH 4/4] app/test: add rsa kat and pwct tests

2023-05-17 Thread Arek Kusztal
Added RSA PWCT and KAT tests. Now it complies with setup/teardown logic. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 1050 ++-- app/test/test_cryptodev_asym_util.h| 10 - app/test/test_cryptodev_rsa_test_vectors.h | 600 ++- 3 f

[PATCH 3/4] app/test: refactor mod inv tests

2023-05-17 Thread Arek Kusztal
Added new modular multiplicative inverse function. Now it handles changes to the generic setup. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 140 ++--- app/test/test_cryptodev_asym_util.h| 9 -- app/test/test_cryptodev_mod_test_vectors.h

[PATCH 2/4] app/test: refactor mod exp test case

2023-05-17 Thread Arek Kusztal
Refactored modular exponentiation test case. Added multiple vectors to be checked in KAT tests. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 201 app/test/test_cryptodev_asym_util.h| 9 - app/test/test_cryptodev_mod_test_vectors.h | 567 +---

[PATCH 1/4] app/test: remove testsuite calls from ut setup

2023-05-17 Thread Arek Kusztal
Unit test setup should be responsible for setting unit test parateres only, analogous rules should apply to ut teardown function. Cryptodev start/stop functions should be used once - during setting the testsuite. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 310 ++

[PATCH 0/4] Replace obsolote test cases.

2023-05-17 Thread Arek Kusztal
This patchset removes obsolete test cases for RSA, MOD EXP, MOD INV. Doing that, new way of handling of ut_setup, ut_teardown was proposed. Now both behave like constructor/desctuctor to the unit tests. It frees particular alghoritrm function from any kind of responsability to free resource. Functi

[PATCH] net/mlx5: fix drop action attribute validation

2023-05-17 Thread Dariusz Sosnowski
Before this patch, DROP flow action was rejected for all egress flow rules, which was not correct for all cases. When Verbs flow engine is used (dv_flow_en=0) DROP flow action is implemented using IBV_FLOW_SPEC_ACTION_DROP IBV action. This action is supported on ingress only. This patch amends the

[PATCH 2/2] net/mlx5: add modify field actions number validation

2023-05-17 Thread Dariusz Sosnowski
This patch adds validation for the number of modify field actions, when working with HW Steering. If translation of modify field actions generated more HW commands than supported by the FW, then proper error is returned. Additionally, number of generated commands is logged, along with a number of

[PATCH 0/2] net/mlx5: add modify field actions number validation

2023-05-17 Thread Dariusz Sosnowski
This patchset adds validation for the number of modify field actions, when working with HW Steering. Dariusz Sosnowski (2): common/mlx5: query maximum modify header pattern length net/mlx5: add modify field actions number validation drivers/common/mlx5/mlx5_devx_cmds.c | 14 drivers

[PATCH 1/2] common/mlx5: query maximum modify header pattern length

2023-05-17 Thread Dariusz Sosnowski
This patch adds querying the HCA capabilities for maximum supported pattern length for Header Modify Pattern objects. Signed-off-by: Dariusz Sosnowski Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 14 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ drive

Re: [PATCH 5/5] mempool/cnxk: add support for exchanging mbufs between pools

2023-05-17 Thread Jerin Jacob
On Tue, Apr 11, 2023 at 1:26 PM Ashwin Sekhar T K wrote: > > Add the following cnxk mempool PMD APIs to facilitate exchanging mbufs > between pools. > * rte_pmd_cnxk_mempool_is_hwpool() - Allows user to check whether a pool >is hwpool or not. > * rte_pmd_cnxk_mempool_range_check_disable() -

Re: [PATCH] doc/ark: replace word segregation

2023-05-17 Thread Ferruh Yigit
On 4/3/2023 6:31 AM, Tyler Retzlaff wrote: > On Sun, Apr 02, 2023 at 03:53:56PM -0700, Stephen Hemminger wrote: >> The word "segregation" brings up troubling memorys. >> Instead, use the term seperation which is what DPDK flow docs use. >> >> Signed-off-by: Stephen Hemminger > > Acked-by: Tyler R

Re: [PATCH] lib/kni : fix memory-leak on rte_kni_rx_burst

2023-05-17 Thread Ferruh Yigit
On 5/16/2023 11:48 AM, Yasin CANER wrote: > Coverity issue: > Bugzilla ID: 1227 > Fixes: > Cc: sta...@dpdk.org > Cc: step...@networkplumber.org > > Adding new condition to check buffer is removed or not. > it prevent allocation each time when rte_kni_rx_burst function called > that cause memory-le

[PATCH v3] build: announce requirement for C11

2023-05-17 Thread Bruce Richardson
Add a deprecation notice informing users that we will require a C11 compiler from 23.11 release onwards. This requirement was agreed by technical board to enable use of newer C language features, e.g. standard atomics. [1] [1] http://inbox.dpdk.org/dev/dbapr08mb58148cec3e1454e8848a938998...@dbapr

Re: [PATCH v3 1/4] vhost: change vhost_virtqueue access lock to a read/write one

2023-05-17 Thread Maxime Coquelin
Hi Eelco, On 5/17/23 11:08, Eelco Chaudron wrote: This change will allow the vhost interrupt datapath handling to be split between two processed without one of them holding an explicit lock. As I had a tuned PVP benchmarking setup at hand, I ran a 0.02% loss RFC2544 test with and without this

RE: [PATCH v1 2/7] doc: fix blank line in asynchronous operations description

2023-05-17 Thread Ori Kam
Hi Michael, > -Original Message- > From: Michael Baum > Sent: Tuesday, May 16, 2023 9:38 AM > > The asynchronous operations description inside "Generic flow API > (rte_flow)" documentation, adds some bullets to describe asynchronous > operations behavior. > > Before the first bullet, mi

RE: [PATCH v1 1/2] net/mlx5: disallow duplicated tag index in pattern template

2023-05-17 Thread Ori Kam
Hi Rongwei, > -Original Message- > From: Rongwei Liu > Sent: Tuesday, May 16, 2023 8:43 AM > > Duplicated tag index in pattern template will most likely cause > matching failures such as "template tag index is 0 data mask 0xff / > tag index is 0 data mask 0x / end" > > If the upper

RE: [dpdk-dev][PATCH] ethdev: add send queue flow matching item

2023-05-17 Thread Ori Kam
I think we will move to support this but I can't give you time line > -Original Message- > From: Jan Viktorin > Sent: Friday, May 12, 2023 2:24 PM > To: kirankum...@marvell.com; Ori Kam > Cc: Aman Singh ; Yuying Zhang > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Ferruh Yigit ; Andrew >

RE: [PATCH v1 1/3] ethdev: add flow item for RoCE infiniband BTH

2023-05-17 Thread Ori Kam
Hi Bill, > -Original Message- > From: Bill Zhou > Sent: Thursday, May 11, 2023 10:55 AM > Subject: [PATCH v1 1/3] ethdev: add flow item for RoCE infiniband BTH > > IB(InfiniBand) is one type of networking used in high-performance > computing with high throughput and low latency. Like Eth

RE: [PATCH v2] ethdev: add Tx queue flow matching item

2023-05-17 Thread Ori Kam
Hi Kirankumark, > -Original Message- > From: kirankum...@marvell.com > Sent: Monday, May 8, 2023 4:50 PM > > From: Kiran Kumar K > > Adding support for Tx queue flow matching item. > This item is valid only for egress rules. > An example use case would be that application can > set dif

Re: [v2] net/gve: check driver compatibility

2023-05-17 Thread Ferruh Yigit
On 5/8/2023 8:15 PM, Rushil Gupta wrote: > Change gve_driver_info fields to report DPDK as OS type and DPDK RTE > version as OS version, reserving driver_version fields for GVE driver > version based on features. > > Signed-off-by: Rushil Gupta > Signed-off-by: Joshua Washington > Signed-off-by:

RE: [RFC PATCH v3] ethdev: add indirect list flow action

2023-05-17 Thread Ori Kam
Hi Gregory First I'm assuming this is just RFC, since there is no code implementation. > -Original Message- > From: Gregory Etelson > Sent: Sunday, May 7, 2023 12:51 PM > > Indirect API creates a shared flow action with unique action handle. > Flow rules can access the shared flow actio

Re: [RFC PATCH v3 0/4] dts: add dts api docs

2023-05-17 Thread Bruce Richardson
On Thu, May 11, 2023 at 11:14:04AM +0200, Juraj Linkeš wrote: > Augment the meson build system with dts api generation. The api docs are > generated from Python docstrings in DTS using Sphinx. The format of > choice is the Google format [0]. > > The guides html sphinx configuration is used to pres

[PATCH] lib/cryptodev: move RSA padding information into xform

2023-05-17 Thread Gowrishankar Muthukrishnan
RSA padding information could be a xform entity rather than part of crypto op, as it seems associated with hashing algorithm used for the entire crypto session, where this algorithm is used in message digest itself. Even in virtIO standard spec, this info is associated in the asymmetric session cre

RE: [PATCH] crypto/openssl: fix memory leak

2023-05-17 Thread Ji, Kai
Hi gowrishankar, Is that the same fix ? https://patches.dpdk.org/project/dpdk/patch/20230511135944.142416-1-ciara.po...@intel.com/ regards Kai > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Wednesday, May 17, 2023 5:45 PM > To: dev@dpdk.org > Cc: ano...@marvell.com;

RE: [PATCH] crypto/openssl: fix memory leak

2023-05-17 Thread Akhil Goyal
> Subject: [PATCH] crypto/openssl: fix memory leak > > Memory allocated through OPENSSL_malloc should be freed only > through OPENSSL_free. > > Signed-off-by: Gowrishankar Muthukrishnan Patch already submitted. https://patches.dpdk.org/project/dpdk/patch/20230511135944.142416-1-ciara.po...@intel

[PATCH] lib/cryptodev: set minimal output buffer size for RSA op

2023-05-17 Thread Gowrishankar Muthukrishnan
Depending on RSA op, the output buffer size could be set minimal expected memory, rather than 0 as today. This will allow PMD to do any validation on the size, in case an application did not create enough memory or even in case of any memory fault. Signed-off-by: Gowrishankar Muthukrishnan --- a

RE: [PATCH v2] crypto/ipsec_mb: fix allocating mb_mgr in session

2023-05-17 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Wednesday, May 17, 2023 4:19 PM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Power, Ciara ; sta...@dpdk.org > Subject: [PATCH v2] crypto/ipsec_mb: fix allocating mb_mgr in session > > When configuring the

RE: [PATCH] crypto/ipsec_mb: fix allocating mb_mgr in session

2023-05-17 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Wednesday, May 17, 2023 4:14 PM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Power, Ciara ; sta...@dpdk.org > Subject: [PATCH] crypto/ipsec_mb: fix allocating mb_mgr in session > > When configuring the se

[PATCH] crypto/openssl: fix memory leak

2023-05-17 Thread Gowrishankar Muthukrishnan
Memory allocated through OPENSSL_malloc should be freed only through OPENSSL_free. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/

RE: [PATCH v2 0/8] add AESNI_MB optimisations

2023-05-17 Thread Ji, Kai
Series-acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Tuesday, May 16, 2023 4:24 PM > To: dev@dpdk.org > Cc: Ji, Kai ; gak...@marvell.com; Power, Ciara > > Subject: [PATCH v2 0/8] add AESNI_MB optimisations > > This patchset adds some optimisations for AESNI_MB PMD,

[PATCH 19/20] crypto/bcmfs: replace term sanity check

2023-05-17 Thread Stephen Hemminger
Do not use non-inclusive naming here. Signed-off-by: Stephen Hemminger --- drivers/crypto/bcmfs/hw/bcmfs4_rm.c | 6 +++--- drivers/crypto/bcmfs/hw/bcmfs5_rm.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/bcmfs/hw/bcmfs4_rm.c b/drivers/crypto/bcmfs/hw

[PATCH 20/20] Remove use of term sanity check

2023-05-17 Thread Stephen Hemminger
Replace non-inclusive language with better comments. Signed-off-by: Stephen Hemminger --- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +- drivers/common/dpaax/caamflib/desc.h | 2 +- drivers/dma/idxd/idxd_pci.c | 2 +- drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- driver

[PATCH 18/20] net/cxgbe: remove use of term sanity

2023-05-17 Thread Stephen Hemminger
Remove non-inclusive terminolgy. Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_ethdev.c | 10 ++ drivers/net/cxgbe/cxgbevf_main.c | 4 ++-- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c

[PATCH 17/20] net/txgbe: replace term sanity

2023-05-17 Thread Stephen Hemminger
Don't use term sanity. Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ipsec.c | 2 +- drivers/net/txgbe/txgbe_rxtx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ipsec.c b/drivers/net/txgbe/txgbe_ipsec.c index f9f8108fb894..cadb094

[PATCH 15/20] cnxk: replace term sanity

2023-05-17 Thread Stephen Hemminger
Do not use non-inclusive naming. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_nix_tm_ops.c | 2 +- drivers/common/cnxk/roc_npa.c| 4 ++-- drivers/net/cnxk/cnxk_ethdev.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/common/cnxk/roc_

[PATCH 16/20] event/opdl: remove term sanity

2023-05-17 Thread Stephen Hemminger
Don't use non-inclusive term. Signed-off-by: Stephen Hemminger --- drivers/event/opdl/opdl_evdev.c | 2 +- drivers/event/opdl/opdl_evdev_init.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c index 9ce8

[PATCH 14/20] net/bnx2x: remove reference to sanity

2023-05-17 Thread Stephen Hemminger
Replace "sanity check" Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/bnx2x/bnx2x_stats.c | 8 drivers/net/bnx2x/ecore_sp.c| 2 +- drivers/net/bnx2x/elink.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drive

[PATCH 13/20] net/bnxt: replace use of term sanity

2023-05-17 Thread Stephen Hemminger
Do not use non-inclusive terms. Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 51e1e2d6b39b..5370293fed8d 100644 --- a/drivers/net/bnxt/bnxt_hw

[PATCH 12/20] net/ark: replace use of term sanity

2023-05-17 Thread Stephen Hemminger
Do not use non inclusive terms. Signed-off-by: Stephen Hemminger --- drivers/net/ark/ark_ethdev.c| 8 drivers/net/ark/ark_ethdev_rx.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index b2995427c8ca

[PATCH 11/20] net/sfc: remove term "sanity check"

2023-05-17 Thread Stephen Hemminger
Remove term sanity check in comment. Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc_dp_rx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_dp_rx.h b/drivers/net/sfc/sfc_dp_rx.h index 246adbd87cde..c64db488f652 100644 --- a/drivers/net/sfc/sfc_dp

[PATCH 10/20] net/mlx[45]: remove word sanity

2023-05-17 Thread Stephen Hemminger
The term "sanity" is on non-inclusive naming list. Remove it from the Nvidia drivers. Signed-off-by: Stephen Hemminger --- drivers/common/mlx5/linux/mlx5_common_os.c | 2 +- drivers/net/mlx4/mlx4.c| 2 +- drivers/net/mlx4/mlx4_flow.c | 6 +++--- drivers/net/mlx5

[PATCH 09/20] net/fm10k, net/ixgbe: remove word sanity

2023-05-17 Thread Stephen Hemminger
Remove non-inclusive term sanity from these Intel drivers. Signed-off-by: Stephen Hemminger --- drivers/net/fm10k/fm10k_ethdev.c | 2 +- drivers/net/fm10k/fm10k_rxtx.c | 2 +- drivers/net/ixgbe/ixgbe_fdir.c | 2 +- drivers/net/ixgbe/ixgbe_ipsec.c | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 2

[PATCH 08/20] doc/eventdev_pipeline: remove sanity

2023-05-17 Thread Stephen Hemminger
The word sanity check is unnecessary here. Signed-off-by: Stephen Hemminger --- doc/guides/gpus/cuda.rst | 2 +- doc/guides/sample_app_ug/eventdev_pipeline.rst | 2 +- doc/guides/tools/testbbdev.rst | 8 3 files changed, 6 insertions(+), 6 deletions

[PATCH 06/20] lib: replace use of sanity check in comments and messages

2023-05-17 Thread Stephen Hemminger
Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Signed-off-by: Stephen Hemminger --- lib/graph/graph.c | 2 +- lib/graph/graph_stats.c | 2 +- lib/graph/node.c| 2 +- lib/jobstats/rte_jobstats.c | 6 +++--- lib/metrics/rte_metrics.c | 2 +- lib

[PATCH 07/20] net/nfp: remove word sanity

2023-05-17 Thread Stephen Hemminger
There are two small uses of the non-inclusive term "sanity". One in comment is easily removed, other is in a macro that was defined but never used. Signed-off-by: Stephen Hemminger --- drivers/net/nfp/nfp_flow.c | 2 +- drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h | 13 ---

[PATCH 05/20] examples: remove term sanity

2023-05-17 Thread Stephen Hemminger
Do not use non-inclusive terms. Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/event_helper.c | 2 +- examples/qos_sched/args.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-secgw/event_helper.c i

[PATCH 04/20] test: replace use word sanity

2023-05-17 Thread Stephen Hemminger
The word "sanity" is on the not-allowed inclusive naming list. Replace the unnecessary usage in tests. Signed-off-by: Stephen Hemminger --- app/test/test_bitmap.c | 4 +-- app/test/test_bpf.c| 6 ++-- app/test/test_common.c | 2 +- app/test/test_distrib

[PATCH 03/20] net/ring: replace use of sanity

2023-05-17 Thread Stephen Hemminger
--- drivers/net/ring/rte_eth_ring.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index e8bc9b627102..e36742fda84f 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -3

[PATCH 02/20] eal: replace use of sanity check in comments and messages

2023-05-17 Thread Stephen Hemminger
Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_memory.c | 2 +- lib/eal/common/eal_common_proc.c | 3 ++- lib/eal/common/eal_common_trace.c | 2 +- lib/eal/common/eal_memcfg.h| 2 +- lib/eal/common

[PATCH 01/20] mbuf: replace term sanity check

2023-05-17 Thread Stephen Hemminger
The term sanity check is on the Tier 2 list of words that should be replaced. Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 30 ++--- doc/guides/prog_guide/mbuf_lib.rst | 4 +- drivers/net/avp/avp_ethdev.c | 18 drivers/net/sfc/sfc_ef100_rx.c

[PATCH 00/20] Replace use of term sanity-check

2023-05-17 Thread Stephen Hemminger
This set of patches removes almost all use of the term sanity in DPDK. The term sanity-check and related formats are on the Inclusive Naming Tier 2 (Strongly Consider Replacing) word list. https://inclusivenaming.org/word-lists/tier-2/sanity-check/ Did not address base drivers which come from vend

RE: [PATCH] test/crypto: remove redundant code

2023-05-17 Thread Power, Ciara
> -Original Message- > From: Anoob Joseph > Sent: Friday 12 May 2023 15:22 > To: Akhil Goyal ; Fan Zhang > ; Power, Ciara > Cc: Hemant Agrawal ; Gagandeep Singh > ; Jerin Jacob ; Tejasree Kondoj > ; dev@dpdk.org > Subject: [PATCH] test/crypto: remove redundant code > > Code for regist

RE: [PATCH 2/2] test/crypto: specify correct parameters with null algos

2023-05-17 Thread Power, Ciara
Hi Anoob, > -Original Message- > From: Anoob Joseph > Sent: Friday 12 May 2023 06:34 > To: Akhil Goyal ; Fan Zhang > ; Power, Ciara > Cc: Hemant Agrawal ; Jerin Jacob > ; Tejasree Kondoj ; > dev@dpdk.org > Subject: [PATCH 2/2] test/crypto: specify correct parameters with null algos > >

RE: [PATCH v2] test/crypto: free memory in error and skip paths

2023-05-17 Thread Power, Ciara
> -Original Message- > From: Anoob Joseph > Sent: Wednesday 17 May 2023 11:55 > To: Akhil Goyal ; Fan Zhang > ; Power, Ciara > Cc: Hemant Agrawal ; Jerin Jacob > ; Tejasree Kondoj ; > dev@dpdk.org > Subject: [PATCH v2] test/crypto: free memory in error and skip paths > > In multi sess

RE: [PATCH 1/2] test/crypto: use separate keys for auth and cipher

2023-05-17 Thread Power, Ciara
> -Original Message- > From: Anoob Joseph > Sent: Friday 12 May 2023 06:34 > To: Akhil Goyal ; Fan Zhang > ; Power, Ciara > Cc: Hemant Agrawal ; Jerin Jacob > ; Tejasree Kondoj ; > dev@dpdk.org > Subject: [PATCH 1/2] test/crypto: use separate keys for auth and cipher > > The mixed tes

RE: [PATCH v2] app/crypto-perf: check crypto result

2023-05-17 Thread Power, Ciara
> -Original Message- > From: Anoob Joseph > Sent: Thursday 20 April 2023 13:23 > To: Power, Ciara ; Akhil Goyal > > Cc: Jerin Jacob ; Tejasree Kondoj > ; dev@dpdk.org > Subject: [PATCH v2] app/crypto-perf: check crypto result > > Check crypto result in latency tests. Checking result w

Re: [PATCH] app/testpmd: fix GTP L2 len in checksum engine

2023-05-17 Thread Ferruh Yigit
On 4/25/2023 12:59 PM, Singh, Aman Deep wrote: > > On 4/2/2023 5:56 PM, Raslan Darawsheh wrote: >> GTP header can be followed by an optional 32 bits extension. >> >> But, l2_len value statically set to RTE_ETHER_GTP_HLEN >> which is defined to be >> (sizeof(struct rte_udp_hdr) + sizeof(st

[PATCH v2] crypto/ipsec_mb: fix allocating mb_mgr in session

2023-05-17 Thread Ciara Power
When configuring the session, use the queue pair mb_mgr that was already allocated if possible. If this doesn't exist, then allocate a new mb_mgr. This reduces unnecessary cycles creating an mb_mgr for every session configured. Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework")

RE: seeking community input on adapting DPDK to P4Runtime backend

2023-05-17 Thread Ori Kam
Hi Zhang, rte_flow is an excellent candidate for implementing P4. We and some internal tests that shows great promise in this regard. I would be very happy to supply any needed information and have discussion on how to continue with this project. Please see inline detailed answers. Best, Ori Ka

[PATCH] crypto/ipsec_mb: fix allocating mb_mgr in session

2023-05-17 Thread Ciara Power
When configuring the session, use the queue pair mb_mgr that was already allocated if possible. If this doesn't exist, then allocate a new mb_mgr. This reduces unnecessary cycles creating an mb_mgr for every session configured. Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework")

Re: [PATCH v3] eventdev/eth_tx: fix runtime parameter test

2023-05-17 Thread Jerin Jacob
On Wed, May 17, 2023 at 4:06 PM Naga Harish K S V wrote: > > TX adapter capability check logic is simplified. > The UT has been updated to skip the test, if the API > to set runtime parameters is not supported. > > Fixes: 1d176c7add08 ("eventdev/eth_tx: support runtime set/get parameters") > Cc: s

Re: [PATCH] ethdev: prefer offload names in logs

2023-05-17 Thread Ferruh Yigit
On 3/9/2023 8:16 AM, David Marchand wrote: > +static char * > +eth_dev_offload_names(uint64_t bitmask, const char > *(*offload_name)(uint64_t)) > +{ > + uint64_t offload; > + char *names; > + > + if (bitmask == 0) { > + names = strdup(""); > + goto out; > +

Re: [PATCH] ethdev: prefer offload names in logs

2023-05-17 Thread Ferruh Yigit
On 3/9/2023 4:21 PM, Stephen Hemminger wrote: > On Thu, 9 Mar 2023 09:16:33 +0100 > David Marchand wrote: > >> +RTE_ETHDEV_LOG(ERR, "Ethdev port_id=%u requested Rx offloads >> '%s' in %s(). " >> +"Device supports '%s' Rx offloads but does not support >> '%s'.\n"

Re: [PATCH v1] eventdev/crypto: refactor circular buffer size

2023-05-17 Thread Jerin Jacob
On Wed, May 17, 2023 at 10:23 AM Gujjar, Abhinandan S wrote: > > > > -Original Message- > > From: Kundapura, Ganapati > > Sent: Tuesday, April 18, 2023 2:46 PM > > To: jer...@marvell.com; Gujjar, Abhinandan S > > ; dev@dpdk.org > > Cc: Naga Harish K, S V ; Jayatheerthan, Jay > > > > Subj

Re: [RFC PATCH 1/5] eventdev: add power monitoring API on event port

2023-05-17 Thread Burakov, Anatoly
On 4/19/2023 10:54 AM, Sivaprasad Tummala wrote: A new API to allow power monitoring condition on event port to optimize power when no events are arriving on an event port for the worker core to process in an eventdev based pipelined application. Signed-off-by: Sivaprasad Tummala --- General

DPDK 21.11.4 released

2023-05-17 Thread Kevin Traynor
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-21.11.4.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=21.11 This LTS release contains ~300 fixes from main branch up to DPDK 22.11. Thanks to the authors who helped with backports and to the

Re: [RFC PATCH 4/5] power: add eventdev support for power management

2023-05-17 Thread Burakov, Anatoly
On 4/19/2023 10:54 AM, Sivaprasad Tummala wrote: Add eventdev support to enable power saving when no events are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wai

📣 Call for Content

2023-05-17 Thread Ben Thomas
*This month *we're starting to ramp up our communication efforts, which will be shared across DPDK & Linux Foundation channels. *What can you do?* Send your content to promote, which will be featured throughout the month.*Examples of content:* - Links to tech updates, news events, meetings etc

Minutes of Technical Board Meeting, 2023-May-3

2023-05-17 Thread Stephen Hemminger
Minutes of Technical Board Meeting, 2023-May-3 NOTE: The technical board meets every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK community members are welcome to attend. NOTE: Next meeting will be on Wednesday 2023-May-17 @3pm UTC, and will be chaired

Re: [RFC PATCH 3/5] eventdev: support optional dequeue callbacks

2023-05-17 Thread Burakov, Anatoly
On 4/19/2023 10:54 AM, Sivaprasad Tummala wrote: Add optional support for inline event processing within dequeue call. For a dequeue callback, events dequeued from the event port were passed them to a callback function if configured, to allow additional processing. e.g. unpack batch of packets fr

Re: [PATCH] eventdev/timer: move buffer flush call

2023-05-17 Thread Jerin Jacob
On Thu, Apr 13, 2023 at 1:26 AM Erik Gabriel Carrillo wrote: > > The SW event timer adapter attempts to flush its event buffer on every > adapter tick. If events remain in the buffer after the attempt, another > attempt to flush won't occur until the next adapter tick, which delays > the enqueue o

Re: [PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-05-17 Thread Ferruh Yigit
On 5/17/2023 12:46 PM, lihuisong (C) wrote: > > 在 2023/5/17 16:53, Ferruh Yigit 写道: >> On 5/17/2023 8:45 AM, lihuisong (C) wrote: >>> 在 2023/5/16 22:13, Ferruh Yigit 写道: On 5/16/2023 12:47 PM, lihuisong (C) wrote: > Hi Ferruh, > > There is no result on techboard. > How to deal

RE: [PATCH] eventdev: fix alignment padding

2023-05-17 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Wednesday, 17 May 2023 15.20 > > On Tue, Apr 18, 2023 at 8:46 PM Mattias Rönnblom > wrote: > > > > On 2023-04-18 16:07, Morten Brørup wrote: > > >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > >> Sent: Tuesday, 18 Apr

Re: [PATCH] eventdev: fix alignment padding

2023-05-17 Thread Jerin Jacob
On Tue, Apr 18, 2023 at 8:46 PM Mattias Rönnblom wrote: > > On 2023-04-18 16:07, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > >> Sent: Tuesday, 18 April 2023 14.31 > >> > >> On 2023-04-18 12:45, Sivaprasad Tummala wrote: > >>> fixed the padding required

Re: [PATCH v1] event/cnxk: fix setting event attributes in empty get work

2023-05-17 Thread Jerin Jacob
On Thu, Apr 27, 2023 at 12:24 PM Pavan Nikhilesh Bhagavatula wrote: > > > > > -Original Message- > > From: Shijith Thotton > > Sent: Thursday, April 27, 2023 11:58 AM > > To: Jerin Jacob Kollanukkaran > > Cc: Shijith Thotton ; dev@dpdk.org; Pavan > > Nikhilesh Bhagavatula ; sta...@dpdk.o

  1   2   >