[PATCH 9/9] raw/skeleton: fix segment fault when parse devargs

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. self_test). Fixes: 55ca1b0f215

[PATCH 7/9] net/virtio: fix segment fault when parse devargs

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. vectorized,vdpa). Fixes: 4710e

[PATCH 8/9] dma/skeleton: fix segment fault when parse devargs

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. lcore). Fixes: 05d5fc66a269 ("

[PATCH 6/9] net/hns3: fix segment fault when parse runtime config

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. rx_func_hint). Fixes: a124f9e9

[PATCH 4/9] cryptodev: fix segment fault when parse input args

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. socket_id,max_nb_queue_pairs).

[PATCH 5/9] cryptodev: fix null name when parse input args

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. If the input args is just "name" (which mean only has keys), then it will get (null) name in rte_cryptodev_

[PATCH 1/9] kvargs: detailed definition of callback prototype

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function (which prototype is arg_handler_t) parameter 'value' is NULL when parsed 'only keys'. But where there is no detailed definition of 'value' maybe NULL, so this

[PATCH 3/9] compressdev: fix null name when parse input args

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. If the input args is just "name" (which mean only has keys), then it will get (null) name in rte_compressde

[PATCH 0/9] fix kvargs callback prototype not clearly defined

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. But where there is no detailed definition of 'value' maybe NULL. this leads to a lot of processing errors

[PATCH 2/9] compressdev: fix segment fault when parse input args

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. socket_id). Fixes: ed7dd94f7f6

[PATCH 9/9] raw/skeleton: fix segment fault when parse devargs

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. self_test). Fixes: 55ca1b0f215

[PATCH 0/9] fix kvargs callback prototype not clearly defined

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. But where there is no detailed definition of 'value' maybe NULL. this leads to a lot of processing errors

[PATCH 2/9] compressdev: fix segment fault when parse input args

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. socket_id). Fixes: ed7dd94f7f6

[PATCH 8/9] dma/skeleton: fix segment fault when parse devargs

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. lcore). Fixes: 05d5fc66a269 ("

[PATCH 5/9] cryptodev: fix null name when parse input args

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. If the input args is just "name" (which mean only has keys), then it will get (null) name in rte_cryptodev_

[PATCH 6/9] net/hns3: fix segment fault when parse runtime config

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. rx_func_hint). Fixes: a124f9e9

[PATCH 3/9] compressdev: fix null name when parse input args

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. If the input args is just "name" (which mean only has keys), then it will get (null) name in rte_compressde

[PATCH 4/9] cryptodev: fix segment fault when parse input args

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. socket_id,max_nb_queue_pairs).

[PATCH 7/9] net/virtio: fix segment fault when parse devargs

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. vectorized,vdpa). Fixes: 4710e

[PATCH 1/9] kvargs: detailed definition of callback prototype

2023-03-01 Thread Chengwen Feng
The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function (which prototype is arg_handler_t) parameter 'value' is NULL when parsed 'only keys'. But where there is no detailed definition of 'value' maybe NULL, so this

[PATCH] pipeline: fix rss configuration

2023-03-01 Thread Yogesh Jangra
Currently, the rss object is configured after action, which leads to rss instruction failure, when rss instruction is called from action block. To resolve the error, rss object is configured before action and apply block. Fixes: 8ba342ce6f0 (pipeline: add RSS) Signed-off-by: Yogesh Jangra Signed

Re: [PATCH 2/5] net/hns3: replace fp ops config function

2023-03-01 Thread Dongdong Liu
On 2023/3/1 11:06, Chengwen Feng wrote: This patch replace hns3_eth_dev_fp_ops_config() with rte_eth_fp_ops_setup(). Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Dongdong Liu Thanks, Dongdong

Re: [RFC 1/2] eal: add bitset type

2023-03-01 Thread Mattias Rönnblom
On 2023-02-28 19:46, Tyler Retzlaff wrote: > On Tue, Feb 28, 2023 at 10:39:15AM +0100, Mattias Rönnblom wrote: >> Introduce a set of functions and macros that operate on sets of bits, >> kept in arrays of 64-bit elements. >> >> RTE bitset is designed for bitsets which are larger than what fits in >

[PATCH] pipeline: fix rss configuration

2023-03-01 Thread Yogesh Jangra
Currently, the rss object is configured after action, which leads to rss instruction failure, when rss instruction is called from action block. To resolve the error, rss object is configured before action and apply block. Fixes: 8ba342ce6f0 (pipeline: add RSS) Signed-off-by: Yogesh Jangra Signed

RE: [PATCH v5 00/39] Implementation of ML CNXK driver

2023-03-01 Thread Prince Takkar
> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:37 PM > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla ; Srikanth > Yalavarthi > Subject: [PATCH v5 00/39] Impleme

[PATCH] pipeline: fix rss configuration

2023-03-01 Thread Yogesh Jangra
From: yjangra Currently, the rss object is configured after action, which leads to rss instruction failure, when rss instruction is called from action block. To resolve the error, rss object is configured before action and apply block. Fixes: 8ba342ce6f0 (pipeline: add RSS) Signed-off-by: Yoges

[PATCH] pipeline: fix rss configuration

2023-03-01 Thread yjangra
Currently, the rss object is configured after action, which leads to rss instruction failure, when rss instruction is called from action block. To resolve the error, rss object is configured before action and apply block. Fixes: 8ba342ce6f0 (pipeline: add RSS) Signed-off-by: Yogesh Jangra Signed

RE: [PATCH v2] eal: fix thread race in control thread creation

2023-03-01 Thread Honnappa Nagarahalli
> > > > > > When ctrl_thread_init transitions params->ctrl_thread_status from > > > CTRL_THREAD_LAUNCHING the creating thread and new thread may run > > > concurrently leading to unsynchronized access to params. > > IMO, the code will be simpler if we did not free 'params' in > 'rte_thread_create

RE: [PATCH v4 04/12] app/mldev: add test case to validate model ops

2023-03-01 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:20 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla > Subject: [PATCH v4 04/12] app/m

[PATCH v8 21/21] net/cpfl: add xstats ops

2023-03-01 Thread Mingxia Liu
Add support for these device ops: - dev_xstats_get - dev_xstats_get_names - dev_xstats_reset Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 78 ++ 1 file changed, 78 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpf

[PATCH v8 20/21] net/cpfl: support scalar scatter Rx datapath for single queue model

2023-03-01 Thread Mingxia Liu
This patch add single q recv scatter Rx function. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 27 +++ drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 31 insertions(+), 1 deleti

[PATCH v8 19/21] net/cpfl: add RSS set/get ops

2023-03-01 Thread Mingxia Liu
Add support for these device ops: - rss_reta_update - rss_reta_query - rss_hash_update - rss_hash_conf_get Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 271 - 1 file changed, 270 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_e

[PATCH v8 18/21] net/cpfl: add HW statistics

2023-03-01 Thread Mingxia Liu
This patch add hardware packets/bytes statistics. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 87 ++ 1 file changed, 87 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 8ed6308a36..1f41bb8977 100

[PATCH v8 17/21] net/cpfl: add AVX512 data path for split queue model

2023-03-01 Thread Mingxia Liu
Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_rxtx.c| 56 +++-- drivers/net/cpfl/cpfl_rxtx_vec_common.h | 20 - drivers/net/cpfl/meson.build| 6 ++- 3 file

[PATCH v8 16/21] net/cpfl: support timestamp offload

2023-03-01 Thread Mingxia Liu
Add support for timestamp offload. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 8685c6e27b..8e

[PATCH v8 15/21] net/cpfl: add AVX512 data path for single queue model

2023-03-01 Thread Mingxia Liu
Add support of AVX512 vector data path for single queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- doc/guides/nics/cpfl.rst| 24 +- drivers/net/cpfl/cpfl_ethdev.c | 3 +- drivers/net/cpfl/cpfl_rxtx.c| 93 ++ dr

[PATCH v8 14/21] net/cpfl: support Tx offloading

2023-03-01 Thread Mingxia Liu
Add Tx offloading support: - support TSO for single queue model and split queue model. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/features/c

[PATCH v8 13/21] net/cpfl: support Rx offloading

2023-03-01 Thread Mingxia Liu
Add Rx offloading support: - support CHKSUM and RSS offload for split queue model - support CHKSUM offload for single queue model Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 2 ++ drivers/net/cpfl/cpfl_ethdev.c| 6 ++ 2 files changed, 8 insertions(+) diff --git

[PATCH v8 12/21] net/cpfl: support RSS

2023-03-01 Thread Mingxia Liu
Add RSS support. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 60 ++ drivers/net/cpfl/cpfl_ethdev.h | 15 + 2 files changed, 75 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index b09c7d4996.

[PATCH v8 11/21] net/cpfl: support write back based on ITR expire

2023-03-01 Thread Mingxia Liu
ITR is the interval between two interrupts, it can be understood as a timer here. WB_ON_ITR(write back on ITR expire) is used for receiving packets without interrupts or full cache line, then packets can be received one by one. To enable WB_ON_ITR, need to enable some interrupt with 'idpf_vport_ir

[PATCH v8 10/21] net/cpfl: support basic Tx data path

2023-03-01 Thread Mingxia Liu
Add basic Tx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 +++ drivers/net/cpfl/cpfl_rxtx.c | 20 drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 24 insertions(+) diff --git a/drivers/net/cpf

[PATCH v8 09/21] net/cpfl: support basic Rx data path

2023-03-01 Thread Mingxia Liu
Add basic Rx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 18 ++ drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 21 insertions(+) diff --git a/drivers/net/cpfl/c

[PATCH v8 08/21] net/cpfl: support MTU configuration

2023-03-01 Thread Mingxia Liu
Add dev ops mtu_set. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 27 +++ 2 files changed, 28 insertions(+) diff --git a/doc/guides/nics/features/cpfl.ini b/doc/guides/nics/features/cpfl.ini index a2d1ca9e1

[PATCH v8 07/21] net/cpfl: support queue release

2023-03-01 Thread Mingxia Liu
Add support for queue operations: - rx_queue_release - tx_queue_release Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 24 drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 28 insertions(+) diff --git a/d

[PATCH v8 06/21] net/cpfl: support queue stop

2023-03-01 Thread Mingxia Liu
Add support for these device ops: - rx_queue_stop - tx_queue_stop Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 10 +++- drivers/net/cpfl/cpfl_rxtx.c | 98 ++ drivers/net/cpfl/cpfl_rxtx.h | 3 ++ 3 files changed, 110 insertions(+), 1 delet

[PATCH v8 05/21] net/cpfl: support queue start

2023-03-01 Thread Mingxia Liu
Add support for these device ops: - rx_queue_start - tx_queue_start Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 41 ++ drivers/net/cpfl/cpfl_rxtx.c | 138 + drivers/net/cpfl/cpfl_rxtx.h | 4 + 3 files changed, 183 insertions(+)

[PATCH v8 04/21] net/cpfl: support device start and stop

2023-03-01 Thread Mingxia Liu
Add dev ops dev_start, dev_stop and link_update. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 35 ++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 99fd86d6d0..dbd3f056e7 1006

[PATCH v8 03/21] net/cpfl: add Rx queue setup

2023-03-01 Thread Mingxia Liu
Add support for rx_queue_setup ops. There are two queue modes supported, single queue mode and split queue mode for Rx queue. For the single queue model, the descriptor RX queue is used by SW to post buffer descriptors to HW, and it's also used by HW to post completed descriptors to SW. For the

[PATCH v8 02/21] net/cpfl: add Tx queue setup

2023-03-01 Thread Mingxia Liu
Add support for tx_queue_setup ops. There are two queue modes, single queue mode and split queue mode for Tx queue. For the single queue model, the descriptor TX queue is used by SW to post buffer descriptors to HW, and it's also used by HW to post completed descriptors to SW. For the split queu

[PATCH v8 01/21] net/cpfl: support device initialization

2023-03-01 Thread Mingxia Liu
Support device init and add the following dev ops: - dev_configure - dev_close - dev_infos_get - link_update - dev_supported_ptypes_get Signed-off-by: Mingxia Liu --- MAINTAINERS| 8 + doc/guides/nics/cpfl.rst | 85 +++ doc/guides/nics/features/c

[PATCH v8 00/21] add support for cpfl PMD in DPDK

2023-03-01 Thread Mingxia Liu
The patchset introduced the cpfl (Control Plane Function Library) PMD for Intel?? IPU E2100???s Configure Physical Function (Device ID: 0x1453) The cpfl PMD inherits all the features from idpf PMD which will follow an ongoing standard data plan function spec https://www.oasis-open.org/committees/t

Re: [PATCH v2] eal: fix thread race in control thread creation

2023-03-01 Thread Tyler Retzlaff
On Thu, Mar 02, 2023 at 01:30:13AM +, Honnappa Nagarahalli wrote: > > > > -Original Message- > > From: Tyler Retzlaff > > Sent: Wednesday, March 1, 2023 3:10 PM > > To: dev@dpdk.org; david.march...@redhat.com > > Cc: tho...@monjalon.net; Tyler Retzlaff > > Subject: [PATCH v2] eal: f

RE: [PATCH v2] eal: fix thread race in control thread creation

2023-03-01 Thread Honnappa Nagarahalli
> -Original Message- > From: Tyler Retzlaff > Sent: Wednesday, March 1, 2023 3:10 PM > To: dev@dpdk.org; david.march...@redhat.com > Cc: tho...@monjalon.net; Tyler Retzlaff > Subject: [PATCH v2] eal: fix thread race in control thread creation > > When ctrl_thread_init transitions para

[PATCH 13/17] drivers/event: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 10/17] net/mlx5: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 14/17] dma/skeleton: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 16/17] app/test: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 15/17] drivers/common: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 12/17] net/cxgbe: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 17/17] test-eventdev: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 11/17] net/iavf: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 07/17] examples/vhost: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 09/17] net/octeontx: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 06/17] bbdev: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 08/17] net/virtio: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 05/17] distributor: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 04/17] eal: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 03/17] stack: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 00/17] use __atomic operations returning previous value

2023-03-01 Thread Tyler Retzlaff
This series replaces uses of __atomic_{add,and,or,sub,xor}_fetch with __atomic_fetch_{add,and,or,sub,xor} intrinsics. The latter omits generation of code that is only needed if the returned value is actually used. Additionally, this change simplifies adapting dpdk to standard atomics planned for

[PATCH 01/17] vhost: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH 02/17] telemetry: use previous value atomic fetch operations

2023-03-01 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

Reminder - DPDK Community CI Testing Meeting - Tomorrow 3/2/23 at

2023-03-01 Thread Nathan Southern
Good evening, Tomorrow, 2 Mar. 2023, the DPDK Project will hold its CI Community Testing Meeting at 6am PT/9am ET/1400h GMT/1500h CET. Zoom information to follow. We look forward to seeing you there. Thanks, Nathan Nathan C. Southern, Project Coordinator Data Plane Development Kit The Linux

[PATCH v2] eal: fix thread race in control thread creation

2023-03-01 Thread Tyler Retzlaff
When ctrl_thread_init transitions params->ctrl_thread_status from CTRL_THREAD_LAUNCHING the creating thread and new thread may run concurrently leading to unsynchronized access to params. This permits races for both the failure and success paths after ctrl_thread_status is stored. * params->ret

[PATCH v2] eal: fix thread race in control thread creation

2023-03-01 Thread Tyler Retzlaff
When ctrl_thread_init transitions params->ctrl_thread_status from CTRL_THREAD_LAUNCHING the creating thread and new thread may run concurrently leading to unsynchronized access to params. This permits races for both the failure and success paths after ctrl_thread_status is stored. * params->ret

Re: [PATCH v5 2/6] eal: add thread lifetime management

2023-03-01 Thread Tyler Retzlaff
On Wed, Mar 01, 2023 at 09:11:43AM +0100, David Marchand wrote: > Hello Tyler, > > On Wed, Oct 5, 2022 at 7:07 PM Tyler Retzlaff > wrote: > > diff --git a/lib/eal/unix/rte_thread.c b/lib/eal/unix/rte_thread.c > > index 9126595..d4c1a7f 100644 > > --- a/lib/eal/unix/rte_thread.c > > +++ b/lib/eal/

[PATCH v3] vhost: fix madvise arguments alignment

2023-03-01 Thread Mike Pattrick
The arguments passed to madvise should be aligned to the alignment of the backing memory. Now we keep track of each regions alignment and use then when setting coredump preferences. To facilitate this, a new member was added to rte_vhost_mem_region. A new function was added to easily translate memo

[PATCH v4] bus: add platform bus

2023-03-01 Thread Tomasz Duszynski
Platform bus is a software bus under Linux that manages devices which generally do not have built-in discovery mechanisms. Linux normally learns about platform devices directly from device-tree during boot-up phase. Up to this point, whenever some userspace app needed control over platform device

RE: [PATCH] crypto/qat: fix SM3 auth mode

2023-03-01 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Power, Ciara > Sent: Wednesday, March 1, 2023 2:59 PM > To: Ji, Kai > Cc: dev@dpdk.org; Power, Ciara ; Kusztal, ArkadiuszX > ; sta...@dpdk.org > Subject: [PATCH] crypto/qat: fix SM3 auth mode > > The SM3 auth mode is now set to 0 for QAT, to support plain

[Bug 1167] apps segfault at startup in debug mode

2023-03-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1167 Ali Alnubani (alia...@nvidia.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|-

RE: [RFC 0/2] Add high-performance timer facility

2023-03-01 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Wednesday, 1 March 2023 16.50 > > On 2023-03-01 14:31, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > >> Sent: Wednesday, 1 March 2023 12.18 > >> > >> On 2023-02-28 17:01, Morten Brør

Re: [PATCH] doc: add gpudev to the Doxygen index

2023-03-01 Thread Ferruh Yigit
On 3/1/2023 4:27 PM, Thomas Monjalon wrote: > When introducing the library gpudev, > it has been forgotten to add a link in the API index. > > Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library") > Cc: sta...@dpdk.org > > Signed-off-by: Thomas Monjalon Acked-by: Ferruh Yigit

[PATCH 5/5] test/crypto: add chained ZUC256 testcases

2023-03-01 Thread Ciara Power
Testcases are added for ZUC256 cipher-auth, auth-cipher, and auth-cipher-verify. 4 byte, 8 byte, and 16 byte tags are tested for each chained type. Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 110 app/test/test_cryptodev_zuc_test_vectors.h | 714 +

[PATCH 4/5] test/crypto: fix capability check for ZUC cipher auth

2023-03-01 Thread Ciara Power
The cipher-auth test function for ZUC was not using the improved cipher and auth capability check functions. This meant the required key and IV lengths were not being checked, leading to problems with ZUC256 tests running, and failing, on devices that only support ZUC128. Fixes: 27b787132484 ("tes

[PATCH 3/5] test/crypto: fix auth op parameter for ZUC256 tests

2023-03-01 Thread Ciara Power
The incorrect value was being passed to the ZUC authentication test function, indicating the opposite of the intended GENERATE/VERIFY op. This is fixed to use the auth op enum rather than a value. Fixes: 83397b9f0739 ("test/crypto: add further ZUC test cases") Signed-off-by: Ciara Power --- app

[PATCH 2/5] test/crypto: fix ZUC digest length in comparison

2023-03-01 Thread Ciara Power
The digest length used in ZUC tests for verifying the digest was hardcoded at 4 bytes, which was suitable for ZUC128 only. Now that ZUC256 is supported by these test functions, the digest length can vary. Using the test vector digest length directly in these comparisons allows for variable digest

[PATCH 0/5] test/crypto: add ZUC256 chained tests

2023-03-01 Thread Ciara Power
This patchset adds chained testcases for each ZUC256 digest size: - cipher-auth - auth-cipher - auth-cipher-verify To add these tests, some improvements were made to the existing code, allowing for the user to easily differentiate ZUC256 and ZUC128 tests. Some fixes are also included, that

[PATCH 1/5] test/crypto: improve readability of ZUC256 tests

2023-03-01 Thread Ciara Power
There were some ZUC256 tests for hash generate and hash verify mixed in with the ZUC128 tests, with no indication in the test name that they were for ZUC256. These are now grouped with other ZUC256 tests, and all ZUC256 hash test names are modified to be more uniform, and indicate the digest lengt

Re: [PATCH v2 1/4] eal/windows: fix pedantic build

2023-03-01 Thread Thomas Monjalon
12/01/2023 21:37, Thomas Monjalon: > MinGW GCC 12 shows an illegal pointer conversion > when included in a pedantic module: > > lib/eal/windows/include/pthread.h:137:41: error: > ISO C forbids conversion of object pointer to function pointer type > [-Werror=pedantic] > 137 | hThread =

[PATCH] doc: add gpudev to the Doxygen index

2023-03-01 Thread Thomas Monjalon
When introducing the library gpudev, it has been forgotten to add a link in the API index. Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- doc/api/doxy-api-index.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/

Re: [PATCH v1] ethdev: remove bitfields from trace

2023-03-01 Thread Thomas Monjalon
28/02/2023 17:29, Ferruh Yigit: > On 2/28/2023 3:55 PM, Ankur Dwivedi wrote: > > To capture bitfield variables in trace, the pointer to the structure > > containing the bitfields was referenced. But during trace point > > registration the pointer contains invalid address. Referencing this > > inval

Re: [RFC 0/2] Add high-performance timer facility

2023-03-01 Thread Mattias Rönnblom
On 2023-03-01 14:31, Morten Brørup wrote: >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] >> Sent: Wednesday, 1 March 2023 12.18 >> >> On 2023-02-28 17:01, Morten Brørup wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Tuesday, 28 February 2023 1

Re: [PATCH v2] net/ice: fix ice dcf control thread crash

2023-03-01 Thread Kevin Traynor
On 13/02/2023 07:16, Ke Zhang wrote: The control thread accesses the hardware resources after the resources were released, resulting in a segment error. This commit fixes the bug by exiting thread before resource released. Please add the "Fixes: xyz" tag for the commit that introduced this bu

Re: [PATCH v2] ethdev: add link speed 400G

2023-03-01 Thread Ajit Khaparde
On Wed, Mar 1, 2023 at 3:16 AM Thomas Monjalon wrote: > > There are some devices supporting 400G speed, > and it is well standardized in IEEE. > > Signed-off-by: Thomas Monjalon > Reviewed-by: Morten Brørup > Acked-by: Andrew Rybchenko > Acked-by: Chengwen Feng Acked-by: Ajit Khaparde smime

Re: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field

2023-03-01 Thread Andrew Rybchenko
On 3/1/23 14:37, Thomas Monjalon wrote: 28/02/2023 19:02, Ferruh Yigit: 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to user via ethdev APIs but it is used internally to set "stats->rx_nombuf' which is exposed via ehtdev stat APIs. But telemetry exposes this field to user

[PATCH] crypto/qat: fix SM3 auth mode

2023-03-01 Thread Ciara Power
The SM3 auth mode is now set to 0 for QAT, to support plain hash only. This should also be added to the capabilities for GEN3 and GEN4. SM3 HMAC is not supported. Fixes: 75fd4bbc94ab ("crypto/qat: support SM3 hash algorithm") Cc: arkadiuszx.kusz...@intel.com Cc: sta...@dpdk.org Signed-off-by: Cia

RE: [RFC 0/2] Add high-performance timer facility

2023-03-01 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Wednesday, 1 March 2023 12.18 > > On 2023-02-28 17:01, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > >> Sent: Tuesday, 28 February 2023 10.39 > > > > I have been looking for a high p

RE: [EXT] [PATCH] crypto/openssl: support SM3/SM4 in openssl

2023-03-01 Thread Akhil Goyal
> Subject: [EXT] [PATCH] crypto/openssl: support SM3/SM4 in openssl You should update the title with version number to identify each Version and remove confusion. Also, I see that there are compilation issues reported by CI http://mails.dpdk.org/archives/test-report/2023-February/360051.html Ple

RE: [PATCH v2 00/11] fixes and improvements to cnxk crypto PMD

2023-03-01 Thread Akhil Goyal
> Subject: [PATCH v2 00/11] fixes and improvements to cnxk crypto PMD > > This series adds cn10k scatter gather support and improvements > to cnxk crypto PMD. > > v2: > * Fixed clang build failure Series applied to dpdk-next-crypto Fixed few patch title and descriptions Thanks.

Re: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field

2023-03-01 Thread Thomas Monjalon
28/02/2023 19:02, Ferruh Yigit: > 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to > user via ethdev APIs but it is used internally to set "stats->rx_nombuf' > which is exposed via ehtdev stat APIs. > > But telemetry exposes this field to user via "/ethdev/info", > instead us

[PATCH] doc: update CNXK event device guide

2023-03-01 Thread pbhagavatula
From: Pavan Nikhilesh Update CNXK event device guide to include WQE stashing parameters that are enabled by default. Fixes: ca88db3ae76d ("event/cnxk: support WQE stashing ") Signed-off-by: Pavan Nikhilesh --- Please squash doc/guides/eventdevs/cnxk.rst | 3 ++- 1 file changed, 2 insertions

  1   2   >