[PATCH v3 2/2] net/mlx5: add MPLS tunnel support for HWS

2023-02-22 Thread Michael Baum
Add support for MPLS tunnel item in HWS. Signed-off-by: Michael Baum Acked-by: Ori Kam --- doc/guides/nics/mlx5.rst | 4 doc/guides/rel_notes/release_23_03.rst | 1 + drivers/net/mlx5/mlx5_flow_hw.c| 1 + 3 files changed, 6 insertions(+) diff --git a/doc/guides/nics/

[PATCH v3 1/2] net/mlx5/hws: support matching on MPLSoUDP

2023-02-22 Thread Michael Baum
From: Erez Shitrit Add support for matching MPLS labels while it is under UDP protocol. Matching up to 5 MPLS labels with or without the MPLS value. Signed-off-by: Erez Shitrit --- drivers/net/mlx5/hws/mlx5dr_definer.c | 183 +- drivers/net/mlx5/hws/mlx5dr_definer.h |

[PATCH v3 0/2] net/mlx5: support MPLSoUDP for HWS

2023-02-22 Thread Michael Baum
Add support for matching/encap/decap MPLSoUDP including multiple MPLS headers. v2: - Rebase. - Fix typo in comment. v3: - Update to capital letters at the beginning of sentences in comments. Erez Shitrit (1): net/mlx5/hws: support matching on MPLSoUDP Michael Baum (1): net/mlx5: add MPLS

RE: [PATCH v11 21/22] hash: move rte_hash_set_alg out header

2023-02-22 Thread Ruifeng Wang
> -Original Message- > From: Ruifeng Wang > Sent: Thursday, February 23, 2023 3:11 PM > To: Stephen Hemminger ; dev@dpdk.org > Cc: Yipeng Wang ; Sameh Gobriel > ; Bruce > Richardson ; Vladimir Medvedkin > ; > nd > Subject: RE: [PATCH v11 21/22] hash: move rte_hash_set_alg out header > >

RE: [PATCH v11 21/22] hash: move rte_hash_set_alg out header

2023-02-22 Thread Ruifeng Wang
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, February 23, 2023 5:56 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Yipeng Wang > ; > Sameh Gobriel ; Bruce Richardson > ; > Vladimir Medvedkin ; Ruifeng Wang > > Subject: [PATCH v11 21/22] hash: move rte_hash_set_alg

[PATCH v3] app/testpmd: fix secondary process not forwarding

2023-02-22 Thread Shiyang He
Under multi-process scenario, the secondary process gets queue state from the wrong location (the global variable 'ports'). Therefore, the secondary process can not forward since "stream_init" is not called. This commit fixes the issue by calling 'rte_eth_rx/tx_queue_info_get' to get queue state f

[PATCH v3 7/7] net/mlx5: add error message

2023-02-22 Thread Rongwei Liu
When pattern/action template creation fails the testpmd expects error details. The driver did not set the error structure and testpmd failed with a segmentation fault. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_hw.c | 15 ++- 1 file chan

[PATCH v3 6/7] doc/mlx5: update mlx5 doc

2023-02-22 Thread Rongwei Liu
Add flex item matching and modify field feature into mlx5 documents. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index f182baa37e

[PATCH v3 4/7] net/mlx5: add flex item modify field implementation

2023-02-22 Thread Rongwei Liu
Add flex item modify field HWS implementation. The minimum modify boundary is one byte. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_prm.h | 1 + drivers/net/mlx5/mlx5_flow.h| 3 + drivers/net/mlx5/mlx5_flow_dv.c | 165 +

[PATCH v3 5/7] net/mlx5: return error for sws modify field

2023-02-22 Thread Rongwei Liu
Return unsupported error message when application tries to modify flex item field. Validation of packet modifications actions for SW Steering checked if either source or destination field of MODIFY_FIELD action was a flex item. When DEC_TTL action is used, DEC_TTL action does not have any action c

[PATCH v3 3/7] net/mlx5/hws: add hws flex item matching support

2023-02-22 Thread Rongwei Liu
Support flex item matching in hws and syntax follows sws exactly. Flex item should be created in advance and follow current json mapping logic. Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/hws/mlx5dr_definer.c | 83 ++

[PATCH v3 2/7] net/mlx5: add IPv6 protocol as flex item input

2023-02-22 Thread Rongwei Liu
Support IPv6 protocol as new flex item input link. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_flex.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_flex.c b/drivers/net/mlx5/mlx5_flow_flex.c inde

[PATCH v3 0/7] add flex item implementation

2023-02-22 Thread Rongwei Liu
Implement the flex item matching and modify field in HWS. v3: add error message for testpmd output. Rongwei Liu (7): net/mlx5: enable hws flex item create net/mlx5: add IPv6 protocol as flex item input net/mlx5/hws: add hws flex item matching support net/mlx5: add flex item modify field i

[PATCH v3 1/7] net/mlx5: enable hws flex item create

2023-02-22 Thread Rongwei Liu
Enable flex item create and destroy with dv_flow_en=2 Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 27 +++ drivers/net/mlx5/mlx5_flow_hw.c | 2 ++ 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/drive

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-22 Thread Levend Sayar
Thanks Junfeng for acknowledging. > On 23 Feb 2023, at 07:34, Guo, Junfeng wrote: > > Acked-by: Junfeng Guo mailto:junfeng@intel.com>> > >> -Original Message- >> From: Ferruh Yigit mailto:ferruh.yi...@amd.com>> >> Sent: Tuesday, February 21, 2023 18:31 >> To: Levend Sayar mailto:lev

Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats

2023-02-22 Thread Levend Sayar
Thanks Junfeng for acknowledging. > On 23 Feb 2023, at 05:49, Guo, Junfeng wrote: > > Thanks! > >> -Original Message- >> From: Levend Sayar >> Sent: Wednesday, February 22, 2023 00:44 >> To: Ferruh Yigit >> Cc: Guo, Junfeng ; dev@dpdk.org >> Subject: Re: [PATCH v5] net/gve: add Rx/Tx

RE: [RFC v3 06/10] net/gve: support basic Rx data path for DQO

2023-02-22 Thread Guo, Junfeng
> -Original Message- > From: Honnappa Nagarahalli > Sent: Friday, February 17, 2023 23:18 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; > ferruh.yi...@amd.com; Xing, Beilei > Cc: dev@dpdk.org; Li, Xiaoyun ; Zhang, Helin > ; Rushil Gupta ; Jordan > Kimbrough ; Jeroen de Borst > ;

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-22 Thread Honnappa Nagarahalli
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, February 22, 2023 7:15 PM > To: Honnappa Nagarahalli > Cc: Konstantin Ananyev ; Fengchengwen > ; Ruifeng Wang ; > Ashok Kaladi ; jer...@marvell.com; > tho...@monjalon.net; dev@dpdk.org; s.v.naga.haris...@intel.com; > eri

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-22 Thread Honnappa Nagarahalli
> > >>> > > >>> On 2023/2/20 14:08, Ashok Kaladi wrote: > > If ethdev enqueue or dequeue function is called during > > eth_dev_fp_ops_setup(), it may get pre-empted after setting the > > function pointers, but before setting the pointer to port data. > > In this case the newly

[PATCH v2] vhost: fix madvise arguments alignment

2023-02-22 Thread Mike Pattrick
The arguments passed to madvise should be aligned to the alignment of the backing memory. Now we keep track of each regions alignment and use then when setting coredump preferences. To facilitate this, a new member was added to rte_vhost_mem_region. A new function was added to easily translate memo

RE: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-22 Thread Guo, Junfeng
Acked-by: Junfeng Guo > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 21, 2023 18:31 > To: Levend Sayar > Cc: Guo, Junfeng ; dev@dpdk.org; Stephen > Hemminger > Subject: Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update > > On 2/21/2023 10:07 AM, Lev

RE: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode

2023-02-22 Thread Zhang, Qi Z
> -Original Message- > From: Kevin Traynor > Sent: Thursday, February 23, 2023 12:49 AM > To: Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org; Xing, Beilei > ; Xueming(Steven) Li ; Luca > Boccassi > Subject: Re: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode > > On 26/12/20

Re: MAC address set requires decision

2023-02-22 Thread Hemant Agrawal
On 22-Feb-23 11:25 PM, Honnappa Nagarahalli wrote: -Original Message- From: Richardson, Bruce Sent: Thursday, February 16, 2023 9:05 AM To: Ferruh Yigit;techbo...@dpdk.org Cc: Huisong Li; Chengwen Feng Subject: RE: MAC address set requires decision Alternative suggestions: 1. Don't a

RE: [PATCH] common/idpf: fix Rx queue configuration

2023-02-22 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Thursday, February 23, 2023 11:17 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Xing, Beilei ; sta...@dpdk.org > Subject: [PATCH] common/idpf: fix Rx queue configuration > > From: Beilei Xing > > IDPF PMD enables 2 buffer queues by defau

[PATCH] common/idpf: fix Rx queue configuration

2023-02-22 Thread beilei . xing
From: Beilei Xing IDPF PMD enables 2 buffer queues by default. According to the data sheet, if there is a second buffer queue, the second buffer queue is valid only if bugq2_ena is set. Fixes: c2494d783d31 ("net/idpf: support queue start") Fixes: 8b95ced47a13 ("common/idpf: add Rx/Tx queue struc

[PATCH] vhost: fix slot index in async split virtqueue Tx

2023-02-22 Thread Cheng Jiang
The slot_idx in the asynchronous Vhost split virtqueue dequeue data path is supposed to be decreased by 1 when desc_to_mbuf() fails. Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring") Cc: sta...@dpdk.org Signed-off-by: Cheng Jiang --- lib/vhost/virtio_net.c | 1 + 1 file change

[PATCH] net/sfc: replace of RTE_LOGTYPE_PMD

2023-02-22 Thread Stephen Hemminger
The static LOGTYPE PMD will go away in the future. Replace its use in the sfc driver with the same static type as is already used in RTE_LOG_REGISTER macro. These drivers are trying to do things that other drivers are not in creating log types. IMHO it should follow the other driver usage pattern.

RE: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats

2023-02-22 Thread Guo, Junfeng
Thanks! > -Original Message- > From: Levend Sayar > Sent: Wednesday, February 22, 2023 00:44 > To: Ferruh Yigit > Cc: Guo, Junfeng ; dev@dpdk.org > Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats > > Thanks Ferruh for the review. > > > On 21 Feb 2023, at 18:58,

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-22 Thread Stephen Hemminger
On Wed, 22 Feb 2023 22:48:25 + Honnappa Nagarahalli wrote: > > -Original Message- > > From: Konstantin Ananyev > > Sent: Wednesday, February 22, 2023 4:41 AM > > To: Fengchengwen ; Stephen Hemminger > > ; Ruifeng Wang > > Cc: Ashok Kaladi ; jer...@marvell.com; > > tho...@monjalon.ne

[PATCH v6] app/procinfo: display eventdev xstats for PMD data

2023-02-22 Thread Abdullah Sevincer
This commit extends proc-info application to display xstats and PMD dump data for the eventdev devices. New command line arguments are introduced to display stats for eventdev devices. The command example is like: For displaying a specific port stats (e.g. port 1): dpdk-proc-info -- --edev-stats-

[PATCH] net/mana: fix incorrectly reported counters in stats

2023-02-22 Thread longli
From: Long Li For per port counters and we should report summed values from all queues. Cc: sta...@dpdk.org Signed-off-by: Long Li --- drivers/net/mana/mana.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c inde

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-22 Thread Honnappa Nagarahalli
> -Original Message- > From: Konstantin Ananyev > Sent: Wednesday, February 22, 2023 4:41 AM > To: Fengchengwen ; Stephen Hemminger > ; Ruifeng Wang > Cc: Ashok Kaladi ; jer...@marvell.com; > tho...@monjalon.net; Honnappa Nagarahalli > ; dev@dpdk.org; > s.v.naga.haris...@intel.com; erik

Re: [PATCH v2] net/bnxt: remove compile-time option for IEEE 1588

2023-02-22 Thread Ajit Khaparde
On Wed, Feb 22, 2023 at 10:22 AM Ajit Khaparde wrote: > > The drivers are supposed to enable/disable features dynamically > instead of compile time options. > Remove the compile time option RTE_LIBRTE_IEEE1588. > > This patch is an improved and bnxt specific version of the previous > submission wh

[PATCH v11 22/22] hash: convert RTE_LOGTYPE_HASH to dynamic type

2023-02-22 Thread Stephen Hemminger
Use dynamic type for hash and add subtypes for crc and gfni. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/hash/rte_cuckoo_hash.c | 5 + lib/hash/rte_fbk_hash.c | 5 + lib/hash/rte_thash.c|

[PATCH v11 21/22] hash: move rte_hash_set_alg out header

2023-02-22 Thread Stephen Hemminger
The code for setting algorithm for hash is not at all perf sensitive, and doing it inline has a couple of problems. First, it means that if multiple files include the header, then the initialization gets done multiple times. But also, it makes it harder to fix usage of RTE_LOG(). Despite what the

[PATCH v11 20/22] hash: move rte_thash_gfni stubs out of header file

2023-02-22 Thread Stephen Hemminger
Having stubs in header file makes it harder to update RTE_LOG(). Also modify to only print warning once. Signed-off-by: Stephen Hemminger --- lib/hash/meson.build | 8 ++- lib/hash/rte_thash_gfni.c | 47 +++ lib/hash/rte_thash_gfni.h | 30 ---

[PATCH v11 18/22] app/test: remove use of RTE_LOGTYPE_PIPELINE

2023-02-22 Thread Stephen Hemminger
Instead of using static type PIPELINE for logging in test application use stderr instead. If not testing RTE_LOG() better to not use it since log also goes to syslog. Signed-off-by: Stephen Hemminger --- app/test/test_table_acl.c | 50 -- app/test/test_table

[PATCH v11 19/22] pipeline: replace RTE_LOGTYPE_PIPELINE with dynamic type

2023-02-22 Thread Stephen Hemminger
Use a dynamically allocated logtype. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/pipeline/rte_pipeline.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/e

[PATCH v11 16/22] port: replace RTE_LOGTYPE_PORT with dynamic type

2023-02-22 Thread Stephen Hemminger
Split up the single static RTE_LOGTYPE_PORT into separate sub types for each component: port.ethdev, port.evendev, ... Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/port/rte_port_ethdev.c | 3 +++ lib/port/rte_port_ev

[PATCH v11 17/22] table: convert RTE_LOGTYPE_TABLE to dynamic logtype

2023-02-22 Thread Stephen Hemminger
Use logtype suffixes for various components of this library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/table/rte_table_acl.c | 3 +++ lib/table/rte_table_array.c | 3 +++ lib/table/rte_table_hash_cuck

[PATCH v11 15/22] examples/ipsecgw: replace RTE_LOGTYPE_PORT

2023-02-22 Thread Stephen Hemminger
Looks like some code got copy/paste in to the IPSEC gateway example from another place. Shouldn't be using RTE_LOGTYPE_PORT here. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: akhil.go...@nxp.com Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/sa.c | 6 +++-

[PATCH v11 14/22] sched: replace RTE_LOGTYPE_SCHED with dynamic type

2023-02-22 Thread Stephen Hemminger
Also can remove unused RTE_LOGTYPE_METER Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 2 -- lib/eal/include/rte_log.h | 4 ++-- lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 + lib/sched/rte_sched_log.h | 4 5 files chan

[PATCH v11 13/22] kni: replace RTE_LOGTYPE_KNI with dynamic type

2023-02-22 Thread Stephen Hemminger
Even though KNI will eventually disappear, fix the logtype now. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/kni/rte_kni.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/comm

[PATCH v11 12/22] lpm: replace RTE_LOGTYPE_LPM with dynamic types

2023-02-22 Thread Stephen Hemminger
Split lpm and lpm6 into separate log types since they are in different files and user may want to change log levels for IPv4 vs IPv6. For rib and fib libraries give them own types as well. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h

[PATCH v11 11/22] mempool: replace RTE_LOGTYPE_MEMPOOL with dynamic type

2023-02-22 Thread Stephen Hemminger
Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mempool/rte_mempool.c | 2 ++ lib/mempool/rte_mempool.h | 8 lib/mempool/version.map | 3 +++

[PATCH v11 10/22] ring: replace RTE_LOGTYPE_RING with dynamic type

2023-02-22 Thread Stephen Hemminger
The logtype for ring only used in library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/ring/rte_ring.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b

[PATCH v11 09/22] power: replace RTE_LOGTYPE_POWER with dynamic type

2023-02-22 Thread Stephen Hemminger
Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/power/guest_channel.c | 3 ++- lib/power/power_c

[PATCH v11 08/22] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER

2023-02-22 Thread Stephen Hemminger
Convert to using a dynamic logtype for the application. Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- examples/l3fwd-power/main.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index f57c5

[PATCH v11 07/22] examples/power: replace use of RTE_LOGTYPE_POWER

2023-02-22 Thread Stephen Hemminger
Don't use static logtype in sample application. Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- examples/distributor/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index 21304d661873..542f76cf9664 10

[PATCH v11 06/22] acl: replace LOGTYPE_ACL with dynamic type

2023-02-22 Thread Stephen Hemminger
Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC. For ACL library use a dynamic type. The one message using RTE_LOGTYPE_MALLOC should have been under the ACL logtype anyway. The test code should not have been using fixed log type so just change that to stderr. Signed-off-by: Stephen Hemminger -

[PATCH v11 05/22] mbuf: replace RTE_LOGTYPE_MBUF with dynamic type

2023-02-22 Thread Stephen Hemminger
Introduce a new dynamic logtype for mbuf related messages. Since this is used in multiple files put one macro in mbuf_log.h Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mbuf/mbuf_log.h | 4 lib/mbuf/rte_m

[PATCH v11 04/22] efd: replace RTE_LOGTYPE_EFD with dynamic type

2023-02-22 Thread Stephen Hemminger
Replace all uses of the global logtype with a dynamic log type. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/efd/rte_efd.c | 4 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/eal/com

[PATCH v11 03/22] log: drop unused RTE_LOGTYPE_TIMER

2023-02-22 Thread Stephen Hemminger
The timer code does not use rte_log. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c index 894701e8c

[PATCH v11 02/22] eal: drop no longer used GSO logtype

2023-02-22 Thread Stephen Hemminger
The message that used this was replaced in previous patch. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common

[PATCH v11 01/22] gso: don't log message on non TCP/UDP

2023-02-22 Thread Stephen Hemminger
If a large packet is passed into GSO routines of unknown protocol then library would log a message. Better to tell the application instead of logging. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Reviewed-by: Jiayu Hu Signed-off-by: Stephen Hemminger --- lib/gso/rte_gso.c | 5 ++--- lib/gs

[PATCH v11 00/22] Convert static log type values in libraries

2023-02-22 Thread Stephen Hemminger
This patchset removes the main uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. There are several options on how to treat the old static types: leave them there, mark as deprecated, or remove them. This version removes them since there i

RE: [PATCH v1 07/13] test/bbdev: add support for BLER for 4G

2023-02-22 Thread Vargas, Hernan
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, February 20, 2023 9:44 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; Rix, Tom > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v1 07/13] test/bbdev: add support for BLER for 4G > > > >

[PATCH] vhost: fix madvise arguments alignment

2023-02-22 Thread Mike Pattrick
The arguments passed to madvise should be aligned to the alignment of the backing memory. Now we keep track of each regions alignment and use then when setting coredump preferences. To facilitate this, a new member was added to rte_vhost_mem_region. A new function was added to easily translate memo

[PATCH v2 2/2] net/mlx5: add MPLS tunnel support for HWS

2023-02-22 Thread Michael Baum
Add support for MPLS tunnel item in HWS. Signed-off-by: Michael Baum Acked-by: Ori Kam --- doc/guides/nics/mlx5.rst | 4 doc/guides/rel_notes/release_23_03.rst | 1 + drivers/net/mlx5/mlx5_flow_hw.c| 1 + 3 files changed, 6 insertions(+) diff --git a/doc/guides/nics/

[PATCH v2 0/2] net/mlx5: support MPLSoUDP for HWS

2023-02-22 Thread Michael Baum
Add support for matching/encap/decap MPLSoUDP including multiple MPLS headers. v2: - Rebase. - Fix typo in comment. Erez Shitrit (1): net/mlx5/hws: support matching on MPLSoUDP Michael Baum (1): net/mlx5: add MPLS tunnel support for HWS doc/guides/nics/mlx5.rst | 4 + do

[PATCH v2 1/2] net/mlx5/hws: support matching on MPLSoUDP

2023-02-22 Thread Michael Baum
From: Erez Shitrit Add support for matching MPLS labels while it is under UDP protocol. Matching up to 5 MPLS labels with or without the MPLS value. Signed-off-by: Erez Shitrit --- drivers/net/mlx5/hws/mlx5dr_definer.c | 183 +- drivers/net/mlx5/hws/mlx5dr_definer.h |

RE: [PATCH v2 04/16] test/bbdev: add timeout for latency tests

2023-02-22 Thread Vargas, Hernan
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, February 20, 2023 10:33 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; Rix, Tom > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v2 04/16] test/bbdev: add timeout for latency tests > > >

RE: [PATCH v2] eal: abstract compiler atomics

2023-02-22 Thread Honnappa Nagarahalli
> -Original Message- > From: Tyler Retzlaff > Sent: Wednesday, February 22, 2023 12:10 PM > To: dev@dpdk.org > Cc: david.march...@redhat.com; tho...@monjalon.net; > m...@smartsharesystems.com; Honnappa Nagarahalli > ; bruce.richard...@intel.com > Subject: Re: [PATCH v2] eal: abstract co

Re: [RFC PATCH 0/1] Specify C-standard requirement for DPDK builds

2023-02-22 Thread Tyler Retzlaff
On Thu, Jan 12, 2023 at 11:35:55AM +, Bruce Richardson wrote: > Traditionally, DPDK has never specified a minimum C standard used either > in DPDK builds or for applications using DPDK. Following discussion > on-list about C standards, this RFC attempts to start the process of > codifying what

[PATCH v2] net/bnxt: remove compile-time option for IEEE 1588

2023-02-22 Thread Ajit Khaparde
The drivers are supposed to enable/disable features dynamically instead of compile time options. Remove the compile time option RTE_LIBRTE_IEEE1588. This patch is an improved and bnxt specific version of the previous submission which tried to remove the option tree wide, but was completely disabli

Re: [PATCH v2] eal: abstract compiler atomics

2023-02-22 Thread Tyler Retzlaff
On Wed, Feb 08, 2023 at 01:43:37PM -0800, Tyler Retzlaff wrote: > Introduce an abstraction for compiler specific atomics and a meson > option to allow standard C11 atomics use. notice, this patch series is being withdrawn as it is no longer needed. as per technical board meeting this morning we w

Re: [PATCH v3 3/3] baseband/acc: add check for empty queue

2023-02-22 Thread Maxime Coquelin
On 2/22/23 17:40, Hernan Vargas wrote: Add optimization to return early if there are no available descriptors in ring to dequeue. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/baseband/acc/rte_acc100_p

Re: [PATCH v3 2/3] baseband/acc: remove unused ops check

2023-02-22 Thread Maxime Coquelin
On 2/22/23 17:40, Hernan Vargas wrote: Remove unnecessary debug check for ops. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index

RE: MAC address set requires decision

2023-02-22 Thread Honnappa Nagarahalli
Hello, Moving this discussion to the dev mailing list as per the request in Techboard meeting today. I could not find a single email with all the responses from Techboard members. So, some of the comments need to be repeated. But this is the base response. Thanks, Honnappa > -Origi

Re: [PATCH 2/2] app/testpmd: user assigned flow ID to flows

2023-02-22 Thread Thomas Monjalon
22/02/2023 15:11, Eli Britstein: > Currently, testpmd assigns its own IDs, as indices, to created flows. > Later, the flow index is used as the ID for flow operations (query, > destroy, dump). > > Allow the user to assign a user-id, to be later used as an alternative > to the flow index testpmd as

Re: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode

2023-02-22 Thread Kevin Traynor
On 26/12/2022 05:50, Zhang, Qi Z wrote: -Original Message- From: Qiming Yang Sent: Friday, December 16, 2022 11:12 AM To: dev@dpdk.org; Xing, Beilei Cc: Yang, Qiming Subject: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode This patch change the interrupt interval fro

Re: [PATCH v4 03/10] dts: add dpdk build on sut

2023-02-22 Thread Bruce Richardson
On Mon, Feb 13, 2023 at 04:28:39PM +0100, Juraj Linkeš wrote: > Add the ability to build DPDK and apps on the SUT, using a configured > target. > > Signed-off-by: Juraj Linkeš > --- > dts/framework/config/__init__.py | 2 + > dts/framework/exception.py| 17 ++

RE: [PATCH v4 06/19] remove repeated word 'in'

2023-02-22 Thread Van Haaren, Harry
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, February 22, 2023 4:25 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Van Haaren, Harry > ; Dongdong Liu ; Yisen > Zhuang ; Matan Azrad ; > Viacheslav Ovsiienko ; Andrew Rybchenko > ; Matz, Olivier > Subject: [PATCH v4 06/

Re: [PATCH v4 00/10] dts: add hello world testcase

2023-02-22 Thread Bruce Richardson
On Mon, Feb 20, 2023 at 11:13:45AM +0100, Juraj Linkeš wrote: > Thanks for the comments, Bruce. > > On Fri, Feb 17, 2023 at 6:26 PM Bruce Richardson > wrote: > > > > On Mon, Feb 13, 2023 at 04:28:36PM +0100, Juraj Linkeš wrote: > > > Add code needed to run the HelloWorld testcase which just runs

[PATCH v3 3/3] baseband/acc: add check for empty queue

2023-02-22 Thread Hernan Vargas
Add optimization to return early if there are no available descriptors in ring to dequeue. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c

[PATCH v3 2/3] baseband/acc: remove unused ops check

2023-02-22 Thread Hernan Vargas
Remove unnecessary debug check for ops. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index baab459436..c242f7737a 100644 --- a/drivers/b

[PATCH v3 1/3] baseband/acc: fix check after deref and dead code

2023-02-22 Thread Hernan Vargas
Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null. Coverity issue: 381646, 381631 Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin

[PATCH v3 0/3] DPDK Coverity issue 381631, 381646

2023-02-22 Thread Hernan Vargas
v3: Split commits further for clarity. v2: Split code unrelated to coverity fix in separate commit. v1: Upstream fix to 23.03 for potential issue of dereferencing a pointer before null check. Hernan Vargas (3): baseband/acc: fix check after deref and dead code baseband/acc: remove unused ops

Re: [PATCH v10 07/22] examples/power: replace use of RTE_LOGTYPE_POWER

2023-02-22 Thread Hunt, David
On 22/02/2023 16:07, Stephen Hemminger wrote: Don't use static logtype in sample application. Signed-off-by: Stephen Hemminger --- examples/distributor/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index

Re: [PATCH v10 08/22] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER

2023-02-22 Thread Hunt, David
On 22/02/2023 16:07, Stephen Hemminger wrote: Convert to using a dynamic logtype for the application. Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/

Re: [PATCH v10 09/22] power: replace RTE_LOGTYPE_POWER with dynamic type

2023-02-22 Thread Hunt, David
On 22/02/2023 16:07, Stephen Hemminger wrote: Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/power/guest_channel.c

Re: [PATCH v7 09/22] power: replace RTE_LOGTYPE_POWER with dynamic type

2023-02-22 Thread Hunt, David
On 15/02/2023 17:23, Stephen Hemminger wrote: Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h| 2 +- lib/power/guest_channel.c

Re: [PATCH v9 07/22] examples/power: replace use of RTE_LOGTYPE_POWER

2023-02-22 Thread Hunt, David
On 21/02/2023 19:01, Stephen Hemminger wrote: Don't use static logtype in sample application. Signed-off-by: Stephen Hemminger --- examples/distributor/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index

Re: [PATCH v9 08/22] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER

2023-02-22 Thread Hunt, David
On 21/02/2023 19:01, Stephen Hemminger wrote: Convert to using a dynamic logtype for the application. Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/

Re: [PATCH v9 09/22] power: replace RTE_LOGTYPE_POWER with dynamic type

2023-02-22 Thread Hunt, David
On 21/02/2023 19:01, Stephen Hemminger wrote: Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/power/guest_channel.c

RE: [PATCH v2 2/2] test/mempool: add zero-copy API's

2023-02-22 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 22 February 2023 13.41 > > 22/02/2023 09:24, Morten Brørup: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Wednesday, 22 February 2023 09.01 > > > > > > 21/02/2023 21:18, Kamalakshitha Aligeri: > > > > Hi

Re: [PATCH v4 02/19] remove repeated word 'to'

2023-02-22 Thread Hunt, David
On 22/02/2023 16:25, Stephen Hemminger wrote: Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- app/test/test_resource.c | 2 +- lib/pipeline/rte_swx_ctl.c | 2 +- lib/power/guest_channel.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/a

Re: [PATCH v4 05/19] remove repeated word 'on'

2023-02-22 Thread Hunt, David
On 22/02/2023 16:25, Stephen Hemminger wrote: Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_8023ad.h | 2 +- examples/vm_power_manager/channel_monitor.h | 2 +- examples/vm_power_manager/oob_monitor.h | 2 +- 3 files chang

Re: [PATCH v4 09/19] remove repeated word 'worker'

2023-02-22 Thread Hunt, David
On 22/02/2023 16:25, Stephen Hemminger wrote: Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- lib/distributor/rte_distributor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.

RE: [PATCH v4 02/19] remove repeated word 'to'

2023-02-22 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, February 22, 2023 4:25 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, Cristian > ; Hunt, David > Subject: [PATCH v4 02/19] remove repeated word 'to' > > Found by doing duplicate word scan. > > Signed-off-b

[PATCH v4 19/19] remove repeated word 'all'

2023-02-22 Thread Stephen Hemminger
Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/ecore_sp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h index 1f4d5a3ebe29..c0b4d431c879 100644 --- a/drivers/net/bnx2x/ec

[PATCH v4 18/19] remove repeated word 'be'

2023-02-22 Thread Stephen Hemminger
Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger Acked-by: Devendra Singh Rawat Acked-by: Rasesh Mody --- drivers/net/qede/qede_filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c i

[PATCH v4 17/19] remove repeated word 'expected'

2023-02-22 Thread Stephen Hemminger
Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- lib/bpf/rte_bpf_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bpf/rte_bpf_ethdev.h b/lib/bpf/rte_bpf_ethdev.h index 135062c9e13c..1cca2e6c95a2 100644 --- a/lib/bpf/rte_bpf_ethdev.h +++ b/l

[PATCH v4 16/19] remove repeated word 'individual'

2023-02-22 Thread Stephen Hemminger
Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_filter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/cxgbe_filter.h b/drivers/net/cxgbe/cxgbe_filter.h index 46ebf833381e..6e099a5c1cfc 100644 --- a/drivers/

[PATCH v4 15/19] remove repeated word 'page'

2023-02-22 Thread Stephen Hemminger
Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/ecore_fw_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/ecore_fw_defs.h b/drivers/net/bnx2x/ecore_fw_defs.h index 6fc1fce7e29c..ab1abf6b34b3 100644 --- a/driv

[PATCH v4 14/19] remove repeated word 'groups'

2023-02-22 Thread Stephen Hemminger
Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- app/test/test_ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c index cf71f99b964f..c2a52ec30527 100644 --- a/app/test/test_ipsec.c +++ b/app/test/test

[PATCH v4 13/19] remove repeated word 'override'

2023-02-22 Thread Stephen Hemminger
Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal ctxt_type == DPAA2_SEC_PDCP && sess->pdcp.hfn_ovd) { uint32_t hfn_ovd = *(uint32_t *)((uint8_t *)op + sess->pdcp.hfn_ovd_offset); - /

[PATCH v4 12/19] remove repeated word 'that'

2023-02-22 Thread Stephen Hemminger
Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_ctrl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ctrl.h b/drivers/net/nfp/nfp_ctrl.h index 1069ff948555..2269925b74cf 100644 -

[PATCH v4 11/19] remove repeated word 'table'

2023-02-22 Thread Stephen Hemminger
Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c index 0c75fd36da20..d3313085560d 100644 --- a/drivers/net

[PATCH v4 10/19] remove repeated word 'or'

2023-02-22 Thread Stephen Hemminger
Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c index 5b13cb5c947e..e9d45f24c419 100644 --- a/drivers/net/cxgbe/sge.c +++ b/drive

  1   2   >