[PATCH] net/hns3: support disable IOVA as PA mode

2023-02-13 Thread Chengwen Feng
Claim PMD supports pmd_supports_disable_iova_as_pa. Signed-off-by: Chengwen Feng --- drivers/net/hns3/hns3_rxtx_vec_neon.h | 2 +- drivers/net/hns3/hns3_rxtx_vec_sve.c | 13 + drivers/net/hns3/meson.build | 7 +-- 3 files changed, 11 insertions(+), 11 deletions(-) di

[PATCH 2/2] net/ice: support mark action in switch

2023-02-13 Thread Zhirun Yan
This patch add mark action in switch filter. Signed-off-by: Zhirun Yan --- drivers/net/ice/ice_switch_filter.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c index 110d8895fe..1ff4b1afda 100644 --- a/drivers

[PATCH 1/2] net/ice/base: add ability to set markid via switch filter

2023-02-13 Thread Zhirun Yan
Support to add large action to set 32 bits markid via switch filter. Signed-off-by: Zhirun Yan --- drivers/net/ice/base/ice_switch.c | 216 +- drivers/net/ice/base/ice_switch.h | 44 ++ drivers/net/ice/base/ice_type.h | 1 + 3 files changed, 258 insertions(+)

RE: [PATCH v4 01/12] app/mldev: implement test framework for mldev

2023-02-13 Thread Shivah Shankar Shankar Narayan Rao
> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:20 PM > To: Thomas Monjalon ; Srikanth Yalavarthi > > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla > Subject: [PAT

[PATCH v5 22/22] hash: convert RTE_LOGTYPE_HASH to dynamic type

2023-02-13 Thread Stephen Hemminger
Use dynamic type for hash and add subtypes for crc and gfni. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/hash/rte_cuckoo_hash.c | 5 + lib/hash/rte_fbk_hash.c | 3 +++ lib/hash/rte_hash_crc.c | 3

[PATCH v5 21/22] hash: move rte_hash_set_alg out header

2023-02-13 Thread Stephen Hemminger
The code for setting algorithm for hash is not at all perf sensitive, and doing it inline has a couple of problems. First, it means that if multiple files include the header, then the initialization gets done multiple times. But also, it makes it harder to fix usage of RTE_LOG(). Despite what the

[PATCH v5 20/22] hash: move rte_thash_gfni stubs out of header file

2023-02-13 Thread Stephen Hemminger
Having stubs in header file makes it harder to update RTE_LOG(). Also modify to only print warning once. Signed-off-by: Stephen Hemminger --- lib/hash/meson.build | 8 +++- lib/hash/rte_thash_gfni.c | 43 +++ lib/hash/rte_thash_gfni.h | 28 +-

[PATCH v5 19/22] pipeline: replace RTE_LOGTYPE_PIPELINE with dynamic type

2023-02-13 Thread Stephen Hemminger
Use a dynamically allocated logtype. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/pipeline/rte_pipeline.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/e

[PATCH v5 18/22] app/test: remove use of RTE_LOGTYPE_PIPELINE

2023-02-13 Thread Stephen Hemminger
Instead of using static type PIPELINE for logging in test application use stderr instead. If not testing RTE_LOG() better to not use it since log also goes to syslog. Signed-off-by: Stephen Hemminger --- app/test/test_table_acl.c | 50 -- app/test/test_table

[PATCH v5 17/22] table: convert RTE_LOGTYPE_TABLE to dynamic logtype

2023-02-13 Thread Stephen Hemminger
Use logtype suffixes for various components of this library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/table/rte_table_acl.c | 3 +++ lib/table/rte_table_array.c | 3 +++ lib/table/rte_table_hash_cuck

[PATCH v5 16/22] port: replace RTE_LOGTYPE_PORT with dynamic type

2023-02-13 Thread Stephen Hemminger
Split up the single static RTE_LOGTYPE_PORT into separate sub types for each component: port.ethdev, port.evendev, ... Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/port/rte_port_ethdev.c | 3 +++ lib/port/rte_port_ev

[PATCH v5 15/22] examples/ipsecgw: replace RTE_LOGTYPE_PORT

2023-02-13 Thread Stephen Hemminger
Looks like some code got copy/paste in to the IPSEC gateway example from another place. Shouldn't be using RTE_LOGTYPE_PORT here. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: akhil.go...@nxp.com Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/sa.c | 6 +++-

[PATCH v5 14/22] sched: replace RTE_LOGTYPE_SCHED with dynamic type

2023-02-13 Thread Stephen Hemminger
Also can remove unused RTE_LOGTYPE_METER Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 2 -- lib/eal/include/rte_log.h | 4 ++-- lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 + lib/sched/rte_sched_log.h | 4 5 files chan

[PATCH v5 13/22] kni: replace RTE_LOGTYPE_KNI with dynamic type

2023-02-13 Thread Stephen Hemminger
Even though KNI will eventually disappear, fix the logtype now. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/kni/rte_kni.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/comm

[PATCH v5 12/22] lpm: replace RTE_LOGTYPE_LPM with dynamic types

2023-02-13 Thread Stephen Hemminger
Split lpm and lpm6 into separate log types since they are in different files and user may want to change log levels for IPv4 vs IPv6. For rib and fib libraries give them own types as well. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h

[PATCH v5 11/22] mempool: replace RTE_LOGTYPE_MEMPOOL with dynamic type

2023-02-13 Thread Stephen Hemminger
Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mempool/rte_mempool.c | 3 +++ lib/mempool/rte_mempool_log.h | 4 lib/mempool/rte_mempool_ops.c | 1 + 5 fil

[PATCH v5 10/22] ring: replace RTE_LOGTYPE_RING with dynamic type

2023-02-13 Thread Stephen Hemminger
The logtype for ring only used in library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/ring/rte_ring.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b

[PATCH v5 09/22] power: replace RTE_LOGTYPE_POWER with dynamic type

2023-02-13 Thread Stephen Hemminger
Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h| 2 +- lib/power/guest_channel.c| 3 ++- lib/power/power_common.c | 2

[PATCH v5 08/22] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER

2023-02-13 Thread Stephen Hemminger
Convert to using a dynamic logtype for the application. Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index caf26b373e8d..8e094c1bdda5

[PATCH v5 07/22] examples/power: replace use of RTE_LOGTYPE_POWER

2023-02-13 Thread Stephen Hemminger
Don't use static static logtype in sample application. Signed-off-by: Stephen Hemminger --- examples/distributor/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index 21304d661873..542f76cf9664 100644 --- a/exam

[PATCH v5 06/22] acl: replace LOGTYPE_ACL with dynamic type

2023-02-13 Thread Stephen Hemminger
Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC. For ACL library use a dynamic type. The one message using RTE_LOGTYPE_MALLOC should have been under the ACL logtype anyway. The test code should not have been using fixed log type so just change that to stderr. Signed-off-by: Stephen Hemminger -

[PATCH v5 05/22] mbuf: replace RTE_LOGTYPE_MBUF with dynamic type

2023-02-13 Thread Stephen Hemminger
Introduce a new dynamic logtype for mbuf related messages. Since this is used in multiple files put one macro in mbuf_log.h Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mbuf/mbuf_log.h | 4 lib/mbuf/rte_m

[PATCH v5 04/22] efd: replace RTE_LOGTYPE_EFD with dynamic type

2023-02-13 Thread Stephen Hemminger
Replace all uses of the global logtype with a dynamic log type. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/efd/rte_efd.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/comm

[PATCH v5 03/22] log: drop unused RTE_LOGTYPE_TIMER

2023-02-13 Thread Stephen Hemminger
The timer code does not use rte_log. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c index 894701e8c

[PATCH v5 02/22] eal: drop no longer used GSO logtype

2023-02-13 Thread Stephen Hemminger
The message that used this was replaced in previous patch. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common

[PATCH v5 01/22] gso: don't log message on non TCP/UDP

2023-02-13 Thread Stephen Hemminger
If a large packet is passed into GSO routines of unknown protocol then library would log a message. Better to tell the application instead of logging. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Cc: jiayu...@intel.com Signed-off-by: Stephen Hemminger --- lib/gso/rte_gso.c | 5 ++--- 1 file

[PATCH v5 00/22] Replace us of static logtypes

2023-02-13 Thread Stephen Hemminger
This patchset removes the main uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. Note: there is one patch in this series that will get flagged incorrectly as an ABI change. v5 - fix use of LOGTYPE PORT and POWER in examples v4 - use sim

Re: [PATCH v2] ethdev: telemetry xstats support hide zero

2023-02-13 Thread fengchengwen
On 2023/2/14 2:18, Ferruh Yigit wrote: > On 2/13/2023 2:34 AM, Chengwen Feng wrote: >> The number of xstats may be large, after the hide zero option is added, >> only non-zero values can be displayed. >> >> So display xstats with hide zero: >> /ethdev/xstats,0,hide_zero=true >> and without hid

RE: [PATCH] net/iavf: fix mbuf VLAN offload flags in the L2TAG2 path with AVX2

2023-02-13 Thread Zhang, Qi Z
> -Original Message- > From: Lu, Wenzhuo > Sent: Wednesday, December 14, 2022 10:06 AM > To: mschmidt ; dev@dpdk.org > Cc: Richardson, Bruce ; Wu, Jingjing > ; Xing, Beilei ; Wang, Haiyue > > Subject: RE: [PATCH] net/iavf: fix mbuf VLAN offload flags in the L2TAG2 > path with AVX2 > >

[PATCH v3] ethdev: telemetry xstats support hide zero

2023-02-13 Thread Chengwen Feng
The number of xstats may be large, after the hide zero option is added, only non-zero values can be displayed. So display xstats with hide zero: /ethdev/xstats,0,hide_zero=true and without hide zero: /ethdev/xstats,0,hide_zero=false or /ethdev/xstats,0 Signed-off-by: Chen

Re: [PATCH 1/2] doc: clarify the existing net/ark guide

2023-02-13 Thread Ferruh Yigit
On 2/13/2023 7:58 PM, Shepard Siegel wrote: > Add detail for the existing Arkville configurations FX0 and FX1. > Corrected minor errors of omission. > > Signed-off-by: Shepard Siegel Series applied to dpdk-next-net/main, thanks.

Re: [PATCH 2/2] net/ark: add new ark PCIe device

2023-02-13 Thread Ferruh Yigit
On 2/13/2023 7:58 PM, Shepard Siegel wrote: > @@ -350,7 +352,6 @@ Supported Features > -- > > * Dynamic ARK PMD extensions > -* Dynamic per-queue MBUF (re)sizing up to 32KB Keeping feature based on discussion in previous version.

Re: [PATCH] eal: introduce atomics abstraction

2023-02-13 Thread Tyler Retzlaff
On Mon, Feb 13, 2023 at 05:04:49AM +, Honnappa Nagarahalli wrote: > Hi Tyler, > Few more comments inline. Let us continue to make progress, I will add > this topic for Techboard discussion for 22nd Feb. > > > -Original Message- > > From: Tyler Retzlaff > > Sent: Friday, Februar

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

2023-02-13 Thread Ferruh Yigit
On 2/13/2023 5:31 PM, Shepard Siegel wrote: > Yes, what is different here is that the MBUF size is communicated > from the PMD to the hardware which *changes its behavior* of data motion > to optimize throughput and latency as a function of that setting. And it > does that per-queue. And can be don

RE: [PATCH v1 07/13] test/bbdev: add support for BLER for 4G

2023-02-13 Thread Vargas, Hernan
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 31, 2023 4:20 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; Rix, Tom > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v1 07/13] test/bbdev: add support for BLER for 4G > > > > On 1/17/2

RE: [PATCH v1 08/13] test/bbdev: extend support for large TB

2023-02-13 Thread Vargas, Hernan
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 31, 2023 5:29 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; Rix, Tom > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v1 08/13] test/bbdev: extend support for large TB > > > >

RE: [RFC] eal: use same atomic intrinsics for gcc and clang

2023-02-13 Thread Honnappa Nagarahalli
> > On Fri, Feb 10, 2023 at 07:56:22PM -0600, Honnappa Nagarahalli wrote: > > The size generic atomic intrinsics generate the same code as the size > > specific intrinsics for gcc. Use size generic intrinsics for both gcc > > and clang. > > > > Fixes: 7bdccb93078e ("eal: fix ARM build with clang

Re: [RFC] eal: use same atomic intrinsics for gcc and clang

2023-02-13 Thread Tyler Retzlaff
On Fri, Feb 10, 2023 at 07:56:22PM -0600, Honnappa Nagarahalli wrote: > The size generic atomic intrinsics generate the same > code as the size specific intrinsics for gcc. Use size > generic intrinsics for both gcc and clang. > > Fixes: 7bdccb93078e ("eal: fix ARM build with clang") > Cc: sta...@

[PATCH v4 19/19] hash: convert RTE_LOGTYPE_HASH to dynamic type

2023-02-13 Thread Stephen Hemminger
Use dynamic type for hash and add subtypes for crc and gfni. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/hash/rte_cuckoo_hash.c | 5 + lib/hash/rte_fbk_hash.c | 3 +++ lib/hash/rte_hash_crc.c | 3

[PATCH v4 18/19] hash: move rte_hash_set_alg out header

2023-02-13 Thread Stephen Hemminger
The code for setting algorithm for hash is not at all perf sensitive, and doing it inline has a couple of problems. First, it means that if multiple files include the header, then the initialization gets done multiple times. But also, it makes it harder to fix usage of RTE_LOG(). Despite what the

[PATCH v4 17/19] hash: move rte_thash_gfni stubs out of header file

2023-02-13 Thread Stephen Hemminger
Having stubs in header file makes it harder to update RTE_LOG(). Also modify to only print warning once. Signed-off-by: Stephen Hemminger --- lib/hash/meson.build | 8 +++- lib/hash/rte_thash_gfni.c | 43 +++ lib/hash/rte_thash_gfni.h | 28 +-

[PATCH v4 16/19] pipeline: replace RTE_LOGTYPE_PIPELINE with dynamic type

2023-02-13 Thread Stephen Hemminger
Use a dynamicly allocated logtype Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/pipeline/rte_pipeline.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/

[PATCH v4 15/19] app/test: remove use of RTE_LOGTYPE_PIPELINE

2023-02-13 Thread Stephen Hemminger
Instead of using static type PIPELINE for logging in test application use stderr instead. If not testing RTE_LOG() better to not use it since log also goes to syslog. Signed-off-by: Stephen Hemminger --- app/test/test_table_acl.c | 50 -- app/test/test_table

[PATCH v4 14/19] table: convert RTE_LOGTYPE_TABLE to dynamic logtype

2023-02-13 Thread Stephen Hemminger
Use logtype suffixes for various components of this library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/table/rte_table_acl.c | 3 +++ lib/table/rte_table_array.c | 3 +++ lib/table/rte_table_hash_cuck

[PATCH v4 13/19] port: replace RTE_LOGTYPE_PORT with dynamic type

2023-02-13 Thread Stephen Hemminger
Split up the single static RTE_LOGTYPE_PORT into separate sub types for each component: port.ethdev, port.evendev, ... Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/port/rte_port_ethdev.c | 3 +++ lib/port/rte_port_ev

[PATCH v4 12/19] sched: replace RTE_LOGTYPE_SCHED with dynamic type

2023-02-13 Thread Stephen Hemminger
Also can remove unused RTE_LOGTYPE_METER Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 2 -- lib/eal/include/rte_log.h | 4 ++-- lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 + lib/sched/rte_sched_log.h | 4 5 files chan

[PATCH v4 10/19] lpm: replace RTE_LOGTYPE_LPM with dynamic types

2023-02-13 Thread Stephen Hemminger
Split lpm and lpm6 into separate log types since they are in different files and user may want to change log levels for IPv4 vs IPv6. For rib and fib libraries give them own types as well. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h

[PATCH v4 11/19] kni: replace RTE_LOGTYPE_KNI with dynamic type

2023-02-13 Thread Stephen Hemminger
Even though KNI will eventually disappear, fix the logtype now. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/kni/rte_kni.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/comm

[PATCH v4 09/19] mempool: replace RTE_LOGTYPE_MEMPOOL with dynamic type

2023-02-13 Thread Stephen Hemminger
Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mempool/rte_mempool.c | 3 +++ lib/mempool/rte_mempool_log.h | 4 lib/mempool/rte_mempool_ops.c | 1 + 5 fil

[PATCH v4 08/19] ring: replace RTE_LOGTYPE_RING with dynamic type

2023-02-13 Thread Stephen Hemminger
The logtype for ring only used in library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/ring/rte_ring.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b

[PATCH v4 07/19] power: replace RTE_LOGTYPE_POWER with dynamic type

2023-02-13 Thread Stephen Hemminger
Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h| 2 +- lib/power/guest_channel.c| 3 ++- lib/power/power_common.c | 2

[PATCH v4 06/19] acl: replace LOGTYPE_ACL with dynamic type

2023-02-13 Thread Stephen Hemminger
Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC. For ACL library use a dynamic type. The one message using RTE_LOGTYPE_MALLOC should have been under the ACL logtype anyway. The test code should not have been using fixed log type so just change that to stderr. Signed-off-by: Stephen Hemminger -

[PATCH v4 05/19] mbuf: replace RTE_LOGTYPE_MBUF with dynamic type

2023-02-13 Thread Stephen Hemminger
Introduce a new dynamic logtype for mbuf related messages. Since this is used in multiple files put one macro in mbuf_log.h Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mbuf/mbuf_log.h | 4 lib/mbuf/rte_m

[PATCH v4 04/19] efd: replace RTE_LOGTYPE_EFD with dynamic type

2023-02-13 Thread Stephen Hemminger
Replace all uses of the global logtype with a dynamic log type. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/efd/rte_efd.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/comm

[PATCH v4 03/19] log: drop unused RTE_LOGTYPE_TIMER

2023-02-13 Thread Stephen Hemminger
The timer code does not use rte_log. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c index 894701e8c

[PATCH v4 02/19] eal: drop no longer used GSO logtype

2023-02-13 Thread Stephen Hemminger
The message that used this was replaced in previous patch. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common

[PATCH v4 01/19] gso: don't log message on non TCP/UDP

2023-02-13 Thread Stephen Hemminger
If a large packet is passed into GSO routines of unknown protocol then library would log a message. Better to tell the application instead of logging. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Cc: jiayu...@intel.com Signed-off-by: Stephen Hemminger --- lib/gso/rte_gso.c | 5 ++--- 1 file

[PATCH 1/2] doc: clarify the existing net/ark guide

2023-02-13 Thread Shepard Siegel
Add detail for the existing Arkville configurations FX0 and FX1. Corrected minor errors of omission. Signed-off-by: Shepard Siegel --- doc/guides/nics/ark.rst | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rs

[PATCH 2/2] net/ark: add new ark PCIe device

2023-02-13 Thread Shepard Siegel
This patch adds the Arkville FX2 to known PCIe device list Update documentation and release notes. Signed-off-by: Shepard Siegel --- doc/guides/nics/ark.rst| 3 ++- doc/guides/rel_notes/release_23_03.rst | 4 drivers/net/ark/ark_ethdev.c | 1 + 3 files changed, 7 i

[PATCH v4 00/19] Replace use of static logtypes

2023-02-13 Thread Stephen Hemminger
This patchset removes the main uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. Note: there is one patch in this series that will get flagged incorrectly as an ABI change. v4 - use simpler/shorter method for setting local LOGTYPE s

RE: [PATCH v1 09/13] test/bbdev: bbdev-test cannot compare some scenarios

2023-02-13 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 31, 2023 4:16 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; Rix, Tom > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v1 09/13] test/bbdev: bbdev-test cannot compare some > sce

[PATCH v3 2/2] test/mempool: add zero-copy API's

2023-02-13 Thread Kamalakshitha Aligeri
Added mempool test cases with zero-copy get and put API's Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang Acked-by: Morten Brørup --- Link: http://patches.dpdk.org/project/dpdk/patch/20230213122437.122858-1...@smartsharesystems.com/ app/test/test_memp

[PATCH v3 1/2] net/i40e: replace put function

2023-02-13 Thread Kamalakshitha Aligeri
Integrated zero-copy put API in mempool cache in i40e PMD. On Ampere Altra server, l3fwd single core's performance improves by 5% with the new API Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Link: http://patches.dpdk.org/project/dpdk/patch/202302

[PATCH v3 0/2] Integrated mempool cache zero-copy API's

2023-02-13 Thread Kamalakshitha Aligeri
In i40e PMD, for fast_free path in Tx, freeing mbufs firstly need to do an extra memcpy due to the special structure of ‘txep’. Thus, replaced the put_bulk function with the zero-copy put API to avoid the cost of this memcpy On Ampere-altra server, for single-core DPDK l3fwd test, throughput improv

Re: [PATCH v2] ethdev: telemetry xstats support hide zero

2023-02-13 Thread Ferruh Yigit
On 2/13/2023 2:34 AM, Chengwen Feng wrote: > The number of xstats may be large, after the hide zero option is added, > only non-zero values can be displayed. > > So display xstats with hide zero: > /ethdev/xstats,0,hide_zero=true > and without hide zero (same as the original): > /ethde

RE: [PATCH] eal: introduce atomics abstraction

2023-02-13 Thread Morten Brørup
Hi Ben, Only bug fixes are backported to LTS. Not even new NIC drivers are backported. Reference: https://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported -Morten

Observed issues with the FIPS sample app

2023-02-13 Thread Patrick Robb
Hello all, At the UNH Community Lab, we are now running CI testing for cryptodev validation using the FIPS sample application. In setting up testing we have run into issues with the sample app documentation being out of date. In places it points to dependency versions which do not work with the sa

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

2023-02-13 Thread Shepard Siegel
Yes, what is different here is that the MBUF size is communicated from the PMD to the hardware which *changes its behavior* of data motion to optimize throughput and latency as a function of that setting. And it does that per-queue. And can be done at runtime (that's the dynamic part). ... To the b

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

2023-02-13 Thread Ferruh Yigit
On 2/13/2023 5:09 PM, Shepard Siegel wrote: > Hi Ferruh, > > Yes, there will probably be next versions in the future. If you don't > mind making the marker length adjustment, that would be great. > > Regarding MBUF (re)sizing  - Arkville supports the ability to configure > or reconfigure the MBUF

Re: [PATCH 2/4] net/ark: add new device to PCIe allowlist

2023-02-13 Thread Shepard Siegel
Hi Ferruh, If you dont mind squashing 2/4 3/4 4/4 together, that would be great. Thank you for correcting on the allowlist, s..b "supported PCIe ids list" instead. best, Shep On Mon, Feb 13, 2023 at 10:51 AM Ferruh Yigit wrote: > On 2/13/2023 2:58 PM, Shepard Siegel wrote: > > This patch add

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

2023-02-13 Thread Shepard Siegel
Hi Ferruh, Yes, there will probably be next versions in the future. If you don't mind making the marker length adjustment, that would be great. Regarding MBUF (re)sizing - Arkville supports the ability to configure or reconfigure the MBUF size used on a per-queue basis. This feature is useful wh

RE: [PATCH v1] config: make max memzones definition configurable

2023-02-13 Thread Ophir Munk
Since the new rte API was "discussed in recent years" and it is also dependent on different driver vendors acceptance - I suggest that the compilation option will be applied now. The new rte API effort will start in parallel. Once accepted - it will replace the compilation option. > -Origin

Re: [PATCH] eal: introduce atomics abstraction

2023-02-13 Thread Ben Magistro
On Mon, Feb 13, 2023 at 10:55 AM Bruce Richardson < bruce.richard...@intel.com> wrote: > On Mon, Feb 13, 2023 at 10:28:40AM -0500, Ben Magistro wrote: > >There is a thread discussing a change to the standard [1] but I have > >not seen anything explicit yet about moving to C11. I am person

RE: [PATCH] disable lock annotation with clang 3.4.2

2023-02-13 Thread Raslan Darawsheh
> -Original Message- > From: Morten Brørup > Sent: Monday, February 13, 2023 6:09 PM > To: Bruce Richardson ; David Marchand > > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Raslan Darawsheh ; > Chenbo Xia ; Maxime Coquelin > > Subject: RE: [PATCH] disable lock annotatio

RE: [PATCH] disable lock annotation with clang 3.4.2

2023-02-13 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 13 February 2023 15.55 > > On Mon, Feb 13, 2023 at 03:44:55PM +0100, David Marchand wrote: > > Venerable RHEL7 clang 3.4.2 has (at least) two issues with lock > > annotations. > > > > A first one with regards to the attri

RE: [PATCH v3 0/4] compressdev: add LZ4 support

2023-02-13 Thread Michael Baum
On 2/13/2023 17:47 PM, Zhang, Fan wrote: > Hi, > > The patchset only have library change and added performance tests. > > We shall have at least one PMD to support the added algorithms and unit test > updated for the PMD/algorithms. There is another patchset which adds it in MLX5 compress PMD:

Re: [PATCH] eal: introduce atomics abstraction

2023-02-13 Thread Bruce Richardson
On Mon, Feb 13, 2023 at 10:28:40AM -0500, Ben Magistro wrote: >There is a thread discussing a change to the standard [1] but I have >not seen anything explicit yet about moving to C11. I am personally in >favor of making the jump to C11 now as part of the 23.x branch and >provided

Re: [PATCH v6 1/3] ethdev: skip congestion management configuration

2023-02-13 Thread Ferruh Yigit
On 2/13/2023 3:44 PM, Jerin Jacob wrote: > On Mon, Feb 13, 2023 at 7:25 PM Ferruh Yigit wrote: >> >> On 2/13/2023 12:34 PM, Ori Kam wrote: >>> >>> -Original Message- From: Ferruh Yigit Sent: Saturday, 11 February 2023 1:10 On 2/10/2023 8:26 AM, Rakesh Kudurumalla

Re: [PATCH 2/4] net/ark: add new device to PCIe allowlist

2023-02-13 Thread Ferruh Yigit
On 2/13/2023 2:58 PM, Shepard Siegel wrote: > This patch adds the Arkville FX2 device to the PCIe allowlist. > > Signed-off-by: Shepard Siegel > --- > drivers/net/ark/ark_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.

Re: [PATCH v3 0/4] compressdev: add LZ4 support

2023-02-13 Thread Zhang, Fan
Hi, The patchset only have library change and added performance tests. We shall have at least one PMD to support the added algorithms and unit test updated for the PMD/algorithms. Regards, Fan On 2/13/2023 6:11 AM, Michael Baum wrote: Add support for LZ4 compression algorithm for both API

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

2023-02-13 Thread Ferruh Yigit
On 2/13/2023 2:58 PM, Shepard Siegel wrote: > Add detail for the existing Arkville configurations FX0 and FX1. > Corrected minor errors of omission. > > Signed-off-by: Shepard Siegel > --- > doc/guides/nics/ark.rst | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/doc

Re: [PATCH v6 1/3] ethdev: skip congestion management configuration

2023-02-13 Thread Jerin Jacob
On Mon, Feb 13, 2023 at 7:25 PM Ferruh Yigit wrote: > > On 2/13/2023 12:34 PM, Ori Kam wrote: > > > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Saturday, 11 February 2023 1:10 > >> > >> On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote: > >>> Introduce new flow action to ski

[PATCH v4 10/10] doc: update DTS setup and test suite cookbook

2023-02-13 Thread Juraj Linkeš
Document how to configure and run DTS. Also add documentation related to new features: SUT setup and a brief test suite implementation cookbook. Signed-off-by: Juraj Linkeš --- doc/guides/tools/dts.rst | 145 ++- 1 file changed, 144 insertions(+), 1 deletion(-

[PATCH v4 09/10] dts: add test results module

2023-02-13 Thread Juraj Linkeš
The module stores the results and errors from all executions, build targets, test suites and test cases. The result consist of the result of the setup and the teardown of each testing stage (listed above) and the results of the inner stages. The innermost stage is the case, which also contains the

[PATCH v4 08/10] dts: add test suite config and runner

2023-02-13 Thread Juraj Linkeš
The config allows users to specify which test suites and test cases within test suites to run. Also add test suite running capabilities to dts runner. Signed-off-by: Juraj Linkeš --- dts/conf.yaml | 2 ++ dts/framework/config/__init__.py | 29 +

[PATCH v4 07/10] dts: add hello world testsuite

2023-02-13 Thread Juraj Linkeš
The test suite implements test cases defined in the corresponding test plan. Signed-off-by: Juraj Linkeš --- dts/framework/remote_session/__init__.py | 2 +- dts/framework/remote_session/os_session.py| 16 - .../remote_session/remote/__init__.py | 2 +- dts/framework/testb

[PATCH v4 06/10] dts: add test suite module

2023-02-13 Thread Juraj Linkeš
The module implements the base class that all test suites inherit from. It implements methods common to all test suites. The derived test suites implement test cases and any particular setup needed for the suite or tests. Signed-off-by: Juraj Linkeš --- dts/conf.yaml

[PATCH v4 05/10] dts: add node memory setup

2023-02-13 Thread Juraj Linkeš
Setup hugepages on nodes. This is useful not only on SUT nodes, but also on TG nodes which use TGs that utilize hugepages. The setup is opt-in, i.e. users need to supply hugepage configuration to instruct DTS to configure them. It not configured, hugepage configuration will be skipped. This is hel

[PATCH v4 04/10] dts: add dpdk execution handling

2023-02-13 Thread Juraj Linkeš
Add methods for setting up and shutting down DPDK apps and for constructing EAL parameters. Signed-off-by: Juraj Linkeš --- dts/conf.yaml | 4 + dts/framework/config/__init__.py | 8 + dts/framework/config/conf_yaml_schema.json| 25 ++ dts/fr

[PATCH v4 03/10] dts: add dpdk build on sut

2023-02-13 Thread Juraj Linkeš
Add the ability to build DPDK and apps on the SUT, using a configured target. Signed-off-by: Juraj Linkeš --- dts/framework/config/__init__.py | 2 + dts/framework/exception.py| 17 ++ dts/framework/remote_session/os_session.py| 90 +- dts/framewo

Re: [PATCH] eal: introduce atomics abstraction

2023-02-13 Thread Ben Magistro
There is a thread discussing a change to the standard [1] but I have not seen anything explicit yet about moving to C11. I am personally in favor of making the jump to C11 now as part of the 23.x branch and provided my thoughts in the linked thread (what other projects using DPDK have as minimum c

[PATCH v4 02/10] dts: add ssh command verification

2023-02-13 Thread Juraj Linkeš
This is a basic capability needed to check whether the command execution was successful or not. If not, raise a RemoteCommandExecutionError. When a failure is expected, the caller is supposed to catch the exception. Signed-off-by: Juraj Linkeš --- dts/framework/exception.py|

[PATCH v4 01/10] dts: add node and os abstractions

2023-02-13 Thread Juraj Linkeš
The abstraction model in DTS is as follows: Node, defining and implementing methods common to and the base of SUT (system under test) Node and TG (traffic generator) Node. Remote Session, defining and implementing methods common to any remote session implementation, such as SSH Session. OSSession,

[PATCH v4 00/10] dts: add hello world testcase

2023-02-13 Thread Juraj Linkeš
Add code needed to run the HelloWorld testcase which just runs the hello world dpdk application. The patchset currently heavily refactors this original DTS code needed to run the testcase: * The whole architecture has been redone into more sensible class hierarchy * DPDK build on the System unde

Re: [PATCH 1/2] net/ark: add new device to PCIe allowlist

2023-02-13 Thread Shepard Siegel
Thank you Ferruh, We have rolled all changes, including your suggestion on the Release Note, into the four distinct patches in this patchset which collectively brings the ark PMD up to date for this new capability. best, Shep On Mon, Feb 13, 2023 at 8:46 AM Ferruh Yigit wrote: > On 2/11/2023

[PATCH 4/4] doc: update Release Notes

2023-02-13 Thread Shepard Siegel
New Arkville FX2 device for PCIe Gen5x16 supported with net/ark Signed-off-by: Shepard Siegel --- doc/guides/rel_notes/release_23_03.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst index 7527c6d57f..7941

[PATCH 3/4] doc: update ark guide to include new PCIe device

2023-02-13 Thread Shepard Siegel
Add descriptions of the new FX2 device to the existing devices. Signed-off-by: Shepard Siegel --- doc/guides/nics/ark.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index edaa02dc96..bbd7419d99 100644 --- a/doc/guides/nics/ark.rst +++

[PATCH 2/4] net/ark: add new device to PCIe allowlist

2023-02-13 Thread Shepard Siegel
This patch adds the Arkville FX2 device to the PCIe allowlist. Signed-off-by: Shepard Siegel --- drivers/net/ark/ark_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index c654a229f7..b2995427c8 100644 --- a/drivers/net/ark/

[PATCH 1/4] doc: clarify the existing net/ark guide

2023-02-13 Thread Shepard Siegel
Add detail for the existing Arkville configurations FX0 and FX1. Corrected minor errors of omission. Signed-off-by: Shepard Siegel --- doc/guides/nics/ark.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index ba00f14e8

Re: [PATCH] disable lock annotation with clang 3.4.2

2023-02-13 Thread Bruce Richardson
On Mon, Feb 13, 2023 at 03:44:55PM +0100, David Marchand wrote: > Venerable RHEL7 clang 3.4.2 has (at least) two issues with lock > annotations. > > A first one with regards to the attribute position: > ../lib/vhost/vhost.h:518:2: error: GCC does not allow > assert_exclusive_lock attribute i

  1   2   >