[PATCH] common/cnxk: remove unnecessary locks

2023-02-01 Thread pbhagavatula
From: Pavan Nikhilesh Remove unnecessary locks as locking is now taken care by mbox_get and mbox_put. Signed-off-by: Pavan Nikhilesh --- Depends-on: 26537 drivers/common/cnxk/roc_sso.c | 25 - drivers/common/cnxk/roc_sso_priv.h | 1 - 2 files changed, 26 deletio

RE: [PATCH v7 0/4] add support for self monitoring

2023-02-01 Thread Tomasz Duszynski
Hi Morten, >-Original Message- >From: Morten Brørup >Sent: Wednesday, February 1, 2023 2:51 PM >To: Tomasz Duszynski ; dev@dpdk.org >Cc: roret...@linux.microsoft.com; ruifeng.w...@arm.com; >bruce.richard...@intel.com; Jerin Jacob >Kollanukkaran ; mattias.ronnb...@ericsson.com; >tho...@m

[PATCH] acl: fix trie splitting

2023-02-01 Thread Arthur Leung
When using a large number of ACL rules, the trie is supposed to split when there are over 2048 nodes. However, node_count is negative, so node_count > context->cur_node_max never actually runs, so all the nodes created from the rules end up being in one trie. Original PR with sample files and te

RE: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-01 Thread Shivah Shankar Shankar Narayan Rao
-Original Message- From: jer...@marvell.com Sent: Monday, November 14, 2022 5:32 PM To: dev@dpdk.org; Thomas Monjalon ; Bruce Richardson ; Srikanth Yalavarthi Cc: ferruh.yi...@xilinx.com; ajit.khapa...@broadcom.com; abo...@pensando.io; andrew.rybche...@oktetlabs.ru; beilei.x...@intel.c

RE: [PATCH v3 5/6] common/idpf: add alarm to support handle vchnl message

2023-02-01 Thread Liu, Mingxia
> -Original Message- > From: Wu, Jingjing > Sent: Thursday, February 2, 2023 12:24 PM > To: Liu, Mingxia ; dev@dpdk.org > Cc: Xing, Beilei > Subject: RE: [PATCH v3 5/6] common/idpf: add alarm to support handle vchnl > message > > > @@ -83,12 +84,49 @@ static int > > idpf_dev_link_upd

RE: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer

2023-02-01 Thread Ori Kam
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, 1 February 2023 20:37 > > On Wed, Feb 1, 2023 at 11:19 PM Ori Kam wrote: > > > > > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Friday, 27 January 2023 8:23 > > > To: Ori Kam > > > Cc: Rakesh Kuduru

RE: [PATCH v3 3/6] common/idpf: support single q scatter RX datapath

2023-02-01 Thread Liu, Mingxia
> -Original Message- > From: Wu, Jingjing > Sent: Thursday, February 2, 2023 11:46 AM > To: Liu, Mingxia ; dev@dpdk.org > Cc: Xing, Beilei ; Wu, Wenjun1 > > Subject: RE: [PATCH v3 3/6] common/idpf: support single q scatter RX > datapath > > > > > +uint16_t > > +idpf_singleq_recv_scatt

[PATCH v3 2/2] net/igc: enable launch time offloading

2023-02-01 Thread Simei Su
The LaunchTime defines the scheduling time of the packet from the packet buffer to the MAC. The launchtime of each packet is specified as an offset applied to the BaseT registers while BaseT is automatically incremented each cycle. This patch supports Tx timestamp based packet pacing by leveraging

[PATCH v3 1/2] net/igc/base: expose packet pacing registers

2023-02-01 Thread Simei Su
Add definitions for packet pacing(launch time offloading) related registers. Signed-off-by: Simei Su --- drivers/net/igc/base/igc_defines.h | 9 + drivers/net/igc/base/igc_regs.h| 8 2 files changed, 17 insertions(+) diff --git a/drivers/net/igc/base/igc_defines.h b/driver

[PATCH v3 0/2] net/igc: support launch time offloading

2023-02-01 Thread Simei Su
[PATCH v3 1/2] expose packet pacing registers [PATCH v3 2/2] enable launch time offloading v3: * Fix coding style issue. v2: * Refine title and commit log. * Add release notes. * Rename variable name. Simei Su (2): net/igc/base: expose packet pacing registers net/igc: enable launch time offl

RE: [PATCH v2] net/iavf: enable tx outer checksum offload on avx512

2023-02-01 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ke1 > Sent: Thursday, February 2, 2023 2:25 PM > To: Zeng, ZhichaoX ; dev@dpdk.org > Cc: Zhang, Qi Z ; Zhou, YidingX > ; Wu, Jingjing ; Xing, Beilei > ; Richardson, Bruce ; > Konstantin Ananyev > Subject: RE: [PATCH v2] net/iavf: enable tx outer checksu

RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API

2023-02-01 Thread Deng, KaiwenX
> -Original Message- > From: Yang, Qiming > Sent: Thursday, February 2, 2023 2:10 PM > To: Deng, KaiwenX ; dev@dpdk.org > Cc: sta...@dpdk.org; Zhou, YidingX ; Wu, > Wenjun1 ; Zhao1, Wei ; > Xing, Beilei ; Lu, Wenzhuo ; > Dai, Wei > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for g

RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API

2023-02-01 Thread Peng, Yuan
> -Original Message- > From: Kaiwen Deng > Sent: Saturday, January 28, 2023 3:15 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhou, YidingX ; Deng, > KaiwenX ; Yang, Qiming > ; Wu, Wenjun1 ; Zhao1, > Wei ; Xing, Beilei ; Lu, > Wenzhuo ; Dai, Wei > Subject: [PATCH] net/ixgbe: enable IPv

RE: [PATCH v2] net/iavf: enable tx outer checksum offload on avx512

2023-02-01 Thread Xu, Ke1
> -Original Message- > From: Zeng, ZhichaoX > Sent: Thursday, February 2, 2023 1:59 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhou, YidingX > ; Xu, Ke1 ; Zeng, ZhichaoX > ; Wu, Jingjing ; Xing, > Beilei ; Richardson, Bruce > ; Konstantin Ananyev > > Subject: [PATCH v2] net/iavf: enable tx

RE: [PATCH] net/iavf: add check for mbuf

2023-02-01 Thread Xing, Beilei
> -Original Message- > From: Ye, MingjinX > Sent: Tuesday, January 31, 2023 1:20 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; > sta...@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Subject: [PATCH] net/iavf: add check for mbuf > > The scalar Tx path would se

RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API

2023-02-01 Thread Yang, Qiming
Hi, Kaiwen The code looks good to me. Can you ask someone to test this behavior and add a tested-by? Qiming > -Original Message- > From: Deng, KaiwenX > Sent: Saturday, January 28, 2023 3:15 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhou, YidingX ; Deng, > KaiwenX ; Yang, Qiming > ;

[PATCH v2] net/iavf: enable tx outer checksum offload on avx512

2023-02-01 Thread Zhichao Zeng
This patch is to enable outer checksum offload on avx512 Tx path for tunnel packet by adding Tx path with context descriptor and adjusting path select logic. Signed-off-by: Yiding Zhou Signed-off-by: Zhichao Zeng --- v2: fix path select logic --- drivers/net/iavf/iavf_rxtx.c| 21 +

RE: [PATCH v3] net/i40e: rework maximum frame size configuration

2023-02-01 Thread Yang, Qiming
Hi, > -Original Message- > From: Su, Simei > Sent: Tuesday, January 31, 2023 6:32 PM > To: Xing, Beilei ; Zhang, Yuying > ; david.march...@redhat.com > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > ; Su, Simei ; > sta...@dpdk.org > Subject: [PATCH v3] net/i40e: rework maximum frame size

RE: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-01 Thread Shivah Shankar Shankar Narayan Rao
> -Original Message- > From: jer...@marvell.com > Sent: Monday, November 14, 2022 5:32 PM > To: dev@dpdk.org; Thomas Monjalon ; Bruce > Richardson ; Srikanth Yalavarthi > > Cc: ferruh.yi...@xilinx.com; ajit.khapa...@broadcom.com; > abo...@pensando.io; andrew.rybche...@oktetlabs.ru; > beil

RE: [PATCH v3 5/6] common/idpf: add alarm to support handle vchnl message

2023-02-01 Thread Wu, Jingjing
> @@ -83,12 +84,49 @@ static int > idpf_dev_link_update(struct rte_eth_dev *dev, >__rte_unused int wait_to_complete) > { > + struct idpf_vport *vport = dev->data->dev_private; > struct rte_eth_link new_link; > > memset(&new_link, 0, sizeof(new_link)); > > -

RE: [PATCH v5 2/4] mldev: implement ML IO type handling functions

2023-02-01 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Wednesday, February 1, 2023 2:43 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu > Subject: [PATCH v5 2/4] mldev: implement ML IO type handling fun

RE: [PATCH v3 3/6] common/idpf: support single q scatter RX datapath

2023-02-01 Thread Wu, Jingjing
> > +uint16_t > +idpf_singleq_recv_scatter_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > +uint16_t nb_pkts) > +{ > + struct idpf_rx_queue *rxq = rx_queue; > + volatile union virtchnl2_rx_desc *rx_ring = rxq->rx_ring; > + volatile union virtchnl2_rx_desc

RE: [PATCH v3 2/6] common/idpf: add RSS set/get ops

2023-02-01 Thread Wu, Jingjing
> +static int idpf_config_rss_hf(struct idpf_vport *vport, uint64_t rss_hf) > +{ > + uint64_t hena = 0, valid_rss_hf = 0; According to the coding style, only the last variable on a line should be initialized. > + int ret = 0; > + uint16_t i; > + > + /** > + * RTE_ETH_RSS_IPV4

RE: [PATCH v3 01/11] ethdev: add flex item modify field support

2023-02-01 Thread Rongwei Liu
Hi Andrew, Can you share some comments on the modified version v3? BR Rongwei > -Original Message- > From: Rongwei Liu > Sent: Monday, January 30, 2023 21:20 > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang

RE: [PATCH v8] doc: add PMD known issue

2023-02-01 Thread Ye, MingjinX
> -Original Message- > From: Stephen Hemminger > Sent: 2023年1月29日 1:18 > To: Ye, MingjinX > Cc: dev@dpdk.org; Yang, Qiming ; > sta...@dpdk.org; Zhou, YidingX ; Zhang, Qi Z > > Subject: Re: [PATCH v8] doc: add PMD known issue > > On Sat, 28 Jan 2023 06:01:38 + > Mingjin Ye wrote:

RE: [PATCH v5 2/3] ethdev: add modify IPv6 protocol field

2023-02-01 Thread Rongwei Liu
Hi Stephen BR Rongwei > -Original Message- > From: Stephen Hemminger > Sent: Thursday, February 2, 2023 00:56 > To: Rongwei Liu > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Raslan Darawsheh > ; Aman Singh ; Yuying > Zhang ;

Re: [PATCH V7] ethdev: fix one address occupies two entries in MAC addrs

2023-02-01 Thread lihuisong (C)
在 2023/2/2 0:37, Thomas Monjalon 写道: 01/02/2023 14:15, Huisong Li: The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by .mac_addr_set(). However, if the new default one has been added as a non-default MAC address by .mac_addr_add(

Re: [PATCH] eal: introduce atomics abstraction

2023-02-01 Thread Tyler Retzlaff
On Wed, Feb 01, 2023 at 01:07:59AM +, Honnappa Nagarahalli wrote: > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, January 31, 2023 4:42 PM > > To: Honnappa Nagarahalli > > Cc: dev@dpdk.org; bruce.richard...@intel.com; m...@smartsharesystems.com; > > Tyler Retzla

Re: [PATCH v2] app/testpmd: expand noisy neighbour forward mode support

2023-02-01 Thread Mike Pattrick
On Wed, Feb 1, 2023 at 10:19 AM Singh, Aman Deep wrote: > > Hi Mike, > > Thanks a lot for the patch. > > On 1/26/2023 10:25 AM, Mike Pattrick wrote: > > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of

Re: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer

2023-02-01 Thread Jerin Jacob
On Wed, Feb 1, 2023 at 11:19 PM Ori Kam wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Friday, 27 January 2023 8:23 > > To: Ori Kam > > Cc: Rakesh Kudurumalla ; Stephen Hemminger > > ; NBU-Contact-Thomas Monjalon > > (EXTERNAL) ; Ferruh Yigit ; > > Andrew Rybchenko ;

RE: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer

2023-02-01 Thread Ori Kam
> -Original Message- > From: Jerin Jacob > Sent: Friday, 27 January 2023 8:23 > To: Ori Kam > Cc: Rakesh Kudurumalla ; Stephen Hemminger > ; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; Ferruh Yigit ; > Andrew Rybchenko ; dev@dpdk.org; > NBU-Contact-Adrien Mazarguil (EXTERNAL) > Subject:

RE: [PATCH v5 6/8] ethdev: use ARP protocol struct for flow matching

2023-02-01 Thread Ori Kam
Hi Ferruh and Thomas > -Original Message- > From: Ferruh Yigit > Sent: Thursday, 26 January 2023 18:19 > From: Thomas Monjalon > > As announced in the deprecation notice, flow item structures > should re-use the protocol header definitions from the directory lib/net/. > > The protocol

RE: [PATCH v5 4/8] ethdev: use GRE protocol struct for flow matching

2023-02-01 Thread Ori Kam
Hi Ferruh and Thomas, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, 26 January 2023 18:19 > From: Thomas Monjalon > > As announced in the deprecation notice, flow item structures > should re-use the protocol header definitions from the directory lib/net/. > > The protocol

RE: [PATCH v5 3/8] ethdev: use VXLAN protocol struct for flow matching

2023-02-01 Thread Ori Kam
Hi Ferruh and Thomas, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, 26 January 2023 18:19 > > From: Thomas Monjalon > > As announced in the deprecation notice, flow item structures > should re-use the protocol header definitions from the directory lib/net/. > > In the ca

Re: [PATCH v2] mailmap: update contributor entry

2023-02-01 Thread Thomas Monjalon
24/01/2023 14:01, Viacheslav Galaktionov: > -Viacheslav Galaktionov > +Viacheslav Galaktionov > Applied

Re: [PATCH 1/1] mailmap: update contributor entry

2023-02-01 Thread Thomas Monjalon
24/01/2023 14:55, Ivan Malov: > -Ivan Malov > +Ivan Malov Applied

RE: [PATCH v5 1/8] ethdev: use Ethernet protocol struct for flow matching

2023-02-01 Thread Ori Kam
Hi Ferrurh and Thomas, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, 26 January 2023 18:19 > > From: Thomas Monjalon > > As announced in the deprecation notice, flow item structures > should re-use the protocol header definitions from the directory lib/net/. > The Etherne

Re: [EXT] Re: [dpdk-dev] [PATCH v1 00/12] mldev: introduce machine learning device library

2023-02-01 Thread Jerin Jacob
On Wed, Feb 1, 2023 at 10:27 PM Thomas Monjalon wrote: > > 28/01/2023 12:27, Jerin Jacob: > > I see main comments are on param update and get the capablities. > > To enable that, please propose the changes around > > rte_ml_model_params_update(), > > rte_ml_model_info. We should able to take that

Re: [PATCH] mailmap: update mailmap with second email address

2023-02-01 Thread Thomas Monjalon
06/01/2023 23:12, Tyler Retzlaff: > +Tyler Retzlaff > Tyler Retzlaff I think it should be on the same line with the first being your preferred one.

Re: [PATCH v2] .mailmap:update

2023-02-01 Thread Thomas Monjalon
02/01/2023 08:19, wushao...@chinatelecom.cn: > From: Shaohua Wu > > update .mailmap Which version are you updating? I don't find your name in the main branch.

RE: [PATCH v8 1/2] ethdev: add query_update sync and async function calls

2023-02-01 Thread Ori Kam
Hi Gregory,. > -Original Message- > From: Gregory Etelson > Sent: Wednesday, 1 February 2023 17:17 > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; Ori Kam > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Ferruh Yigit ; Andrew > Rybchenko > Subject: [PATCH v8

Re: [PATCH v1] examples/l3fwd: fix for coverity scan

2023-02-01 Thread Thomas Monjalon
10/01/2023 15:56, Mohammad Iqbal Ahmad: > This patch fixes (Logically dead code) coverity issue. > This patch also fixes (Uninitialized scalar variable) coverity issue. > > Coverity issue: 381687 > Coverity issue: 381686 > Fixes: 6a094e328598 ("examples/l3fwd: implement FIB lookup method") > > Si

Re: [EXT] Re: [dpdk-dev] [PATCH v1 00/12] mldev: introduce machine learning device library

2023-02-01 Thread Thomas Monjalon
28/01/2023 12:27, Jerin Jacob: > I see main comments are on param update and get the capablities. > To enable that, please propose the changes around > rte_ml_model_params_update(), > rte_ml_model_info. We should able to take that and send v2. Sorry I don't have the bandwidth to work on mldev now

Re: [PATCH v5 2/3] ethdev: add modify IPv6 protocol field

2023-02-01 Thread Stephen Hemminger
On Wed, 1 Feb 2023 13:35:10 +0200 Rongwei Liu wrote: > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 7a8516829c..b8156ebca2 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -811,7 +811,8 @@ static const char *const modify_field_i

Re: [PATCH V7] ethdev: fix one address occupies two entries in MAC addrs

2023-02-01 Thread Thomas Monjalon
01/02/2023 14:15, Huisong Li: > The dev->data->mac_addrs[0] will be changed to a new MAC address when > applications modify the default MAC address by .mac_addr_set(). However, > if the new default one has been added as a non-default MAC address by > .mac_addr_add(), the .mac_addr_set() doesn't rem

RE: [PATCH v2 0/4] ethdev: add template table insertion and matching types

2023-02-01 Thread Ori Kam
Hi Alex, > -Original Message- > From: Alexander Kozyrev > Sent: Friday, 27 January 2023 1:28 > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > ferruh.yi...@amd.com; andrew.rybche...@oktetlabs.ru; Ori Kam > > Subject: [PATCH v2 0/4] ethdev: add template table insertion

RE: [PATCH v2 2/2] ethdev: introduce the PHY affinity field in Tx queue API

2023-02-01 Thread Jiawei(Jonny) Wang
Hi, > -Original Message- > From: Andrew Rybchenko > Subject: Re: [PATCH v2 2/2] ethdev: introduce the PHY affinity field in Tx > queue > API > > On 1/30/23 20:00, Jiawei Wang wrote: > > For the multiple hardware ports connect to a single DPDK port > > (mhpsdp), the previous patch intro

RE: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-02-01 Thread Ankur Dwivedi
>-Original Message- >From: Ferruh Yigit >Sent: Wednesday, February 1, 2023 12:08 AM >To: Ankur Dwivedi ; dev@dpdk.org; David >Marchand ; Jerin Jacob Kollanukkaran >; Andrew Rybchenko > >Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com; >ch...@att.com; humi...@huawei.com; linvi..

[PATCH v2 2/2] compressdev: remove useless list end enums

2023-02-01 Thread Michael Baum
The both "RTE_COMP_ALGO_LIST_END" and "RTE_COMP_HASH_ALGO_LIST_END" are useless. This patch removes them from the library. Signed-off-by: Michael Baum --- lib/compressdev/rte_comp.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h index

[PATCH v2 1/2] compressdev: fix end of comp PMD list macro conflict

2023-02-01 Thread Michael Baum
The "rte_compressdev_info_get()" function retrieves the contextual information of a device. The output structure "dev_info" contains a list of devices supported capabilities for each supported algorithm. In this function description, it says the element after the last valid element has op field se

[PATCH v2 0/2] compressdev: fix end of list enums conflict

2023-02-01 Thread Michael Baum
Handle the conflict about which enum value is used as end of list. v2: add patch to remove useless list end enums. Michael Baum (2): compressdev: fix end of comp PMD list macro conflict compressdev: remove useless list end enums drivers/compress/mlx5/mlx5_compress.c| 4 +--- drivers

Re: Multi-versioning for backward compatibility

2023-02-01 Thread Dmitry Kozlyuk
2023-02-01 14:54 (UTC+), Arseniy Aharonov: > This method can't work in Windows with MSVC (at least to the best of my > knowledge). In Windows generally, not limited to MSVC. > How does DPDK solve if in Windows for MSVC? I failed to find the answer. It just doesn't. Fortunately, symbol ver

Re: [PATCH v4 1/4] mldev: add headers for internal ML functions

2023-02-01 Thread Thomas Monjalon
Hi Anup, Your ack is lost in patch lines. Please make sure your email client is quoting the original email lines, so we can distinguish your answer from the original email. Also you can drop useless lines when replying (see how I removed patch content here). 01/02/2023 14:54, Anup Prabhu: > >

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Jerin Jacob
On Wed, Feb 1, 2023 at 8:20 PM Ferruh Yigit wrote: > > On 2/1/2023 1:48 PM, Jerin Jacob wrote: > > On Wed, Feb 1, 2023 at 5:06 PM Ferruh Yigit wrote: > >> > >> On 2/1/2023 11:15 AM, Jerin Jacob wrote: > >>> On Wed, Feb 1, 2023 at 4:35 PM Thomas Monjalon > >>> wrote: > > 01/02/2023 11:

Re: [PATCH v2] app/testpmd: expand noisy neighbour forward mode support

2023-02-01 Thread Singh, Aman Deep
Hi Mike, Thanks a lot for the patch. On 1/26/2023 10:25 AM, Mike Pattrick wrote: Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding packets as is. However, this limited the usefulness of noisy neighbour simulation. This feature has now been expanded into al

[PATCH v8 2/2] ethdev: add quota flow action and item

2023-02-01 Thread Gregory Etelson
Quota action limits traffic according to pre-defined configuration. Quota reflects overall traffic usage regardless bandwidth. Quota flow action initialized with signed tokens number value. Quota flow action updates tokens number according to these rules: 1. if quota was configured to count packet

[PATCH v8 1/2] ethdev: add query_update sync and async function calls

2023-02-01 Thread Gregory Etelson
Current API allows either query or update indirect flow action. If indirect action must be conditionally updated according to it's present state application must first issue action query then analyze returned data and if needed issue update request. When the update will be processed, action state c

RE: [PATCH v7 2/2] ethdev: add quota flow action and item

2023-02-01 Thread Gregory Etelson
Hello Andrew, [] > On 1/24/23 12:37, Gregory Etelson wrote: > > Quota action limits traffic according to pre-defined configuration. > > Quota reflects overall traffic usage regardless bandwidth. > > Quota flow action initialized with signed tokens number value. > > Quota flow action updates token

RE: [PATCH v2 1/2] ethdev: add PHY affinity match item

2023-02-01 Thread Jiawei(Jonny) Wang
Hi, > -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, February 1, 2023 4:50 PM > On 1/30/23 20:00, Jiawei Wang wrote: > > For the multiple hardware ports connect to a single DPDK port > > (mhpsdp), > > Sorry, what is mhpsdp? > (m)ultiple (h)ardware (p)orts (s)ingle (D)PD

Multi-versioning for backward compatibility

2023-02-01 Thread Arseniy Aharonov
Hi, In the codebase of DPDK I saw that it uses the glibc approach to mangle symbol names with a library version to maintain different implementations of the same function per version. So that app

RE: [PATCH v7 1/2] ethdev: add query_update sync and async function calls

2023-02-01 Thread Gregory Etelson
Hello Andrew, [] > > diff --git a/doc/guides/rel_notes/release_23_03.rst > b/doc/guides/rel_notes/release_23_03.rst > > index c15f6fbb9f..5b98e18032 100644 > > --- a/doc/guides/rel_notes/release_23_03.rst > > +++ b/doc/guides/rel_notes/release_23_03.rst > > @@ -68,6 +68,13 @@ New Features > >

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Ferruh Yigit
On 2/1/2023 1:48 PM, Jerin Jacob wrote: > On Wed, Feb 1, 2023 at 5:06 PM Ferruh Yigit wrote: >> >> On 2/1/2023 11:15 AM, Jerin Jacob wrote: >>> On Wed, Feb 1, 2023 at 4:35 PM Thomas Monjalon wrote: 01/02/2023 11:58, Andrew Rybchenko: > On 2/1/23 13:48, Jerin Jacob wrote: >> On W

Re: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16

2023-02-01 Thread Nicolau, Radu
Hi On 2/1/2023 2:16 PM, Akhil Goyal wrote: Hi Radu, Subject: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16 Set AES-CTR IV length as 16 instead of taking from SA config option since the application populates 16B IV in the datapath. AES-CTR requires 16B IV constructed from nonce

RE: [EXT] [PATCH] crypto/qat: add curve25519 and curve448 functions

2023-02-01 Thread Akhil Goyal
> This commit adds qat functions for curve25519 and > curve448. > > Signed-off-by: Arek Kusztal > --- Please review

RE: [EXT] [PATCH] crypto/qat: remove openssl 3.0 deprecated functions

2023-02-01 Thread Akhil Goyal
> This commit removes OpenSSL 3.0 deprecated functions > from Intel QuickAssist Technology PMD. It does not remove > all deprecated functions, this will be added in later versions. > > Signed-off-by: Arek Kusztal Reviews please.

RE: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Ori Kam
Hi Ivan, > -Original Message- > From: Ivan Malov > Sent: Wednesday, 1 February 2023 16:04 > > On Wed, 1 Feb 2023, Thomas Monjalon wrote: > > > 01/02/2023 12:50, Ivan Malov: > >> On Wed, 1 Feb 2023, Thomas Monjalon wrote: > >>> 31/01/2023 06:30, Ivan Malov: > I still hope community

RE: [EXT] [dpdk-dev] [PATCH v1 1/1] compress/octeontx: scatter gather mode feature support

2023-02-01 Thread Akhil Goyal
> Subject: [EXT] [dpdk-dev] [PATCH v1 1/1] compress/octeontx: scatter gather > mode feature support Rename title to compress/octeontx: support scatter gather mode Fix checkpatch warning. Add documentation update in .ini file. > Scatter gather mode feature support is added to compress or decompr

RE: [PATCH v4 2/4] mldev: implement ML IO type handling functions

2023-02-01 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Wednesday, February 1, 2023 2:35 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu > Subject: [PATCH v4 2/4] mldev: implement ML IO type handling fun

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Thomas Monjalon
01/02/2023 15:04, Ivan Malov: > On Wed, 1 Feb 2023, Thomas Monjalon wrote: > > The template flow API is experimental and will probably remain as such > > for a long time, so if you find a more elegant approach, > > we will consider it. > > Thanks for explaining this. > > You know, now you mention

RE: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16

2023-02-01 Thread Akhil Goyal
Hi Radu, > Subject: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16 > > Set AES-CTR IV length as 16 instead of taking from > SA config option since the application populates > 16B IV in the datapath. AES-CTR requires 16B IV > constructed from nonce and counter. > > Signed-off-by: Te

RE: [PATCH v4 2/4] mldev: implement ML IO type handling functions

2023-02-01 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Wednesday, February 1, 2023 2:35 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu > Subject: [PATCH v4 2/4] mldev: implement ML IO type handling fun

RE: [PATCH] crypto/qat: enable asymmetric crypto on gen3 device

2023-02-01 Thread Akhil Goyal
> Acked-by: Kai Ji > > > Subject: [PATCH] crypto/qat: enable asymmetric crypto on gen3 device > > > > This commit enables asymmetric crypto in generation three devices. > > > > Signed-off-by: Ciara Power Applied to dpdk-next-crypto Thanks.

RE: [PATCH] test/crypto: add missing MAC-I to PDCP vectors

2023-02-01 Thread Akhil Goyal
> Subject: [PATCH] test/crypto: add missing MAC-I to PDCP vectors > > Existing PDCP 12-bit C/U-plane output vectors with NULL encryption + NULL > integrity do not contain the MAC-I (32-bit of all zeros according to the > specification). > Vectors for other SN length (5, 18 bits) have the MAC-I set

RE: [PATCH] test/crypto: fix typo in AES test

2023-02-01 Thread Akhil Goyal
> Acked-by: Kai Ji > > > > > Fix the spelling of scater to scatter in cryptodev AES test vector > > header file > > > > Fixes: 2692b02e03b2 ("test/crypto: add multi-segment out-of-place AES- > > XTS") > > Cc: shi...@nvidia.com > > > > Signed-off-by: Vikash Poddar > > --- Cc: sta...@dpdk.org App

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Ivan Malov
On Wed, 1 Feb 2023, Thomas Monjalon wrote: 01/02/2023 12:50, Ivan Malov: On Wed, 1 Feb 2023, Thomas Monjalon wrote: 31/01/2023 06:30, Ivan Malov: I still hope community will comment on the possibility to provide a hint mechanism for always-the-same match items, with the perspective of becomin

RE: [PATCH v6 1/2] ethdev: add query_update sync and async function calls

2023-02-01 Thread Gregory Etelson
Hello Andrew, > > > >> On 1/20/23 13:46, Gregory Etelson wrote: > > and it's async version `rte_flow_async_action_handle_query_update` > > to atomically query and update flow action. > > Sorry, may be I'm missing something, but after reading previous > discussion I have a fe

RE: [EXT] [PATCH] compressdev: fix end of comp PMD list macro conflict

2023-02-01 Thread Akhil Goyal
> > Hi, > > > > > > > > > > After this change, I'm not sure about the purpose of > > > > > "RTE_COMP_ALGO_LIST_END". > > > > > There is no any other use of it in DPDK code, and it isn't > > > > > represent the number of algorithms supported by the API since the > > > > > "RTE_COMP_ALGO_UNSPECIFIED"

RE: [PATCH v4 2/4] mldev: implement ML IO type handling functions

2023-02-01 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Wednesday, February 1, 2023 2:35 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu > Subject: [PATCH v4 2/4] mldev: implement ML IO type handling fun

RE: [PATCH v4 1/4] mldev: add headers for internal ML functions

2023-02-01 Thread Anup Prabhu
-Original Message- From: Srikanth Yalavarthi Sent: Wednesday, February 1, 2023 2:35 PM To: Srikanth Yalavarthi Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao ; Jerin Jacob Kollanukkaran ; Anup Prabhu Subject: [PATCH v4 1/4] mldev: add headers for internal ML functions Added h

RE: [PATCH v4 2/4] mldev: implement ML IO type handling functions

2023-02-01 Thread Anup Prabhu
-Original Message- From: Srikanth Yalavarthi Sent: Wednesday, February 1, 2023 2:35 PM To: Srikanth Yalavarthi Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao ; Jerin Jacob Kollanukkaran ; Anup Prabhu Subject: [PATCH v4 2/4] mldev: implement ML IO type handling functions Imple

RE: [PATCH v7 0/4] add support for self monitoring

2023-02-01 Thread Morten Brørup
> From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] > Sent: Wednesday, 1 February 2023 14.18 > > This series adds self monitoring support i.e allows to configure and > read performance measurement unit (PMU) counters in runtime without > using perf utility. This has certain adventages when ap

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Thomas Monjalon
01/02/2023 12:38, Andrew Rybchenko: > On 2/1/23 14:18, Thomas Monjalon wrote: > > 01/02/2023 12:10, Andrew Rybchenko: > >> On 2/1/23 13:58, Thomas Monjalon wrote: > >>> 01/02/2023 11:17, Andrew Rybchenko: > On 1/18/23 19:18, Thomas Monjalon wrote: > > 18/01/2023 08:28, Andrew Rybchenko: >

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Jerin Jacob
On Wed, Feb 1, 2023 at 5:06 PM Ferruh Yigit wrote: > > On 2/1/2023 11:15 AM, Jerin Jacob wrote: > > On Wed, Feb 1, 2023 at 4:35 PM Thomas Monjalon wrote: > >> > >> 01/02/2023 11:58, Andrew Rybchenko: > >>> On 2/1/23 13:48, Jerin Jacob wrote: > On Wed, Feb 1, 2023 at 2:59 PM Andrew Rybchenko

Re: [PATCH v5 1/3] ethdev: add IPv6 routing extension header definition

2023-02-01 Thread Thomas Monjalon
01/02/2023 12:35, Rongwei Liu: > +/** > + * IPv6 Routing Extension Header > + */ > +struct rte_ipv6_routing_ext { > + uint8_t next_hdr; /**< Protocol, next header. */ > + uint8_t hdr_len;/**< Header length. */ > + uint8_t type;

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Thomas Monjalon
01/02/2023 12:50, Ivan Malov: > On Wed, 1 Feb 2023, Thomas Monjalon wrote: > > 31/01/2023 06:30, Ivan Malov: > >> I still hope community will comment on the possibility to > >> provide a hint mechanism for always-the-same match items, > >> with the perspective of becoming more versatile. > > > > An

RE: [EXT] [PATCH] compressdev: fix end of comp PMD list macro conflict

2023-02-01 Thread Michael Baum
Hi, > > > Hi, > > > > > > > > After this change, I'm not sure about the purpose of > > > > "RTE_COMP_ALGO_LIST_END". > > > > There is no any other use of it in DPDK code, and it isn't > > > > represent the number of algorithms supported by the API since the > > > > "RTE_COMP_ALGO_UNSPECIFIED" i

RE: [EXT] [PATCH] compressdev: fix end of comp PMD list macro conflict

2023-02-01 Thread Akhil Goyal
Hi, > > > > > > After this change, I'm not sure about the purpose of > > > "RTE_COMP_ALGO_LIST_END". > > > There is no any other use of it in DPDK code, and it isn't represent the > > > number of algorithms supported by the API since the > > > "RTE_COMP_ALGO_UNSPECIFIED" is part of the enum. > > >

[PATCH v7 4/4] eal: add PMU support to tracing library

2023-02-01 Thread Tomasz Duszynski
In order to profile app one needs to store significant amount of samples somewhere for an analysis latern on. Since trace library supports storing data in a CTF format lets take adventage of that and add a dedicated PMU tracepoint. Signed-off-by: Tomasz Duszynski --- app/test/test_trace_perf.c

[PATCH v7 3/4] pmu: support reading Intel x86_64 PMU events in runtime

2023-02-01 Thread Tomasz Duszynski
Add support for reading Intel x86_64 PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 2 ++ lib/pmu/meson.build | 1 + lib/pmu/rte_pmu.h| 2 ++ lib/pmu/rte_pmu_pmc_x86_64.h | 24 4 files changed, 29 inserti

[PATCH v7 2/4] pmu: support reading ARM PMU events in runtime

2023-02-01 Thread Tomasz Duszynski
Add support for reading ARM PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 4 ++ lib/pmu/meson.build | 7 +++ lib/pmu/pmu_arm64.c | 94 + lib/pmu/rte_pmu.h | 4 ++ lib/pmu/rte_pmu_pmc_arm64

[PATCH v7 1/4] lib: add generic support for reading PMU events

2023-02-01 Thread Tomasz Duszynski
Add support for programming PMU counters and reading their values in runtime bypassing kernel completely. This is especially useful in cases where CPU cores are isolated (nohz_full) i.e run dedicated tasks. In such cases one cannot use standard perf utility without sacrificing latency and performa

[PATCH v7 0/4] add support for self monitoring

2023-02-01 Thread Tomasz Duszynski
This series adds self monitoring support i.e allows to configure and read performance measurement unit (PMU) counters in runtime without using perf utility. This has certain adventages when application runs on isolated cores with nohz_full kernel parameter. Events can be read directly using rte_pm

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-02-01 Thread Thomas Monjalon
01/02/2023 13:50, Morten Brørup: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 31/01/2023 19:26, Tyler Retzlaff: > > > On Tue, Jan 31, 2023 at 01:23:34PM +0100, Morten Brørup wrote: > > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > > > On Wed, Jan 18, 2023 at 9:31 A

[PATCH V7] ethdev: fix one address occupies two entries in MAC addrs

2023-02-01 Thread Huisong Li
The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by .mac_addr_set(). However, if the new default one has been added as a non-default MAC address by .mac_addr_add(), the .mac_addr_set() doesn't remove it from the mac_addrs list. As a r

RE: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-02-01 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, 31 January 2023 23.52 > > 31/01/2023 19:26, Tyler Retzlaff: > > On Tue, Jan 31, 2023 at 01:23:34PM +0100, Morten Brørup wrote: > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > > Sent: Tuesday, 31 January 202

RE: [PATCH v3 1/6] common/idpf: add hw statistics

2023-02-01 Thread Liu, Mingxia
> -Original Message- > From: Wu, Jingjing > Sent: Wednesday, February 1, 2023 4:49 PM > To: Liu, Mingxia ; dev@dpdk.org > Cc: Xing, Beilei > Subject: RE: [PATCH v3 1/6] common/idpf: add hw statistics > > > @@ -327,6 +407,11 @@ idpf_dev_start(struct rte_eth_dev *dev) > > go

Re: [PATCH v5 1/9] eal: annotate spinlock, rwlock and seqlock

2023-02-01 Thread David Marchand
Hello Intel CI team, On Wed, Feb 1, 2023 at 12:16 PM David Marchand wrote: [snip] > Note: > Doxygen preprocessor does not understand trailing function attributes > (this can be observed with the rte_seqlock.h header). > One would think that expanding the annotation macros to a noop in > rte_loc

Re: [PATCH V6] ethdev: fix one address occupies two entries in MAC addrs

2023-02-01 Thread lihuisong (C)
在 2023/2/1 18:42, Thomas Monjalon 写道: 31/01/2023 07:41, Huisong Li: The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by .mac_addr_set(). However, if the new default one has been added as a non-default MAC address by .mac_addr_add

Re: [PATCH] vhost: fix vdpa driver multi-queue initialization failure

2023-02-01 Thread Maxime Coquelin
On 1/28/23 04:06, Hao Chen wrote: When 'virtio_is_Ready' returns 1, 'vdpa_dev->ops->dev_conf' will be called, and the vdpa driver called 'rte_vhost_get_vhost_vring' to get the vring addr info from 'vhost_devices->virtqueue[]'. virtio_is_ready's nr_vring is VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY(2)

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Ivan Malov
Hi Thomas, On Wed, 1 Feb 2023, Thomas Monjalon wrote: 31/01/2023 06:30, Ivan Malov: Hi Rongwei, OK, I hear ya. Thanks for persevering. I still hope community will comment on the possibility to provide a hint mechanism for always-the-same match items, with the perspective of becoming more ver

  1   2   3   >