RE: [PATCH v2 0/4] add rte_thread_set_name API for rte_thread_t

2023-01-10 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Tuesday, 10 January 2023 21.53 > > anymore feedback here folks? > > would like to clear this so i can rebase the rte_control_thread_create > series. > > thanks! > > On Wed, Dec 14, 2022 at 08:47:17AM -0800, Tyler Retzlaff wrot

RE: RFC abstracting atomics

2023-01-10 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Tuesday, 10 January 2023 21.31 > > On Tue, Jan 10, 2023 at 12:45:05PM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Tuesday, 10 January 2023 10.17 > > > > > > On Mon, Jan

Re: TODO - remove dependency on ifconfig

2023-01-10 Thread David Marchand
On Tue, Jan 10, 2023 at 9:19 PM Stephen Hemminger wrote: > > It would be good if DTS and DPDK docs and test did not use the ifconfig > command. > Ifconfig is not maintained and is deprecated. Some distros have stopped > shipping it. > Ifconfig only used ioctl's and was never updated to handle th

RE: [PATCH] net/mlx5: support ESP item in Verbs interface

2023-01-10 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Maayan Kashani > Sent: Wednesday, January 4, 2023 1:59 PM > To: dev@dpdk.org > Cc: Maayan Kashani ; Matan Azrad > ; Raslan Darawsheh ; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: support ESP item in Verbs interface > > ESP item is not currently suppor

RE: [PATCH v3 1/1] common/idpf: add AVX512 data path for split queue model

2023-01-10 Thread Liu, Mingxia
According to beilei's v2 patchset, struct idpf_rx_stats { rte_atomic64_t mbuf_alloc_failed; }; rx_bufq->rx_stats.mbuf_alloc_failed += IDPF_RXQ_REARM_THRESH; should be changed to rte_atomic64_add(&rx_bufq->rx_stats.mbuf_alloc_failed, IDPF_RXQ_REARM_THRESH); > -Original Message-

[dpdk-dev] [PATCH v2 4/4] common/cnxk: fix dual VLAN parsing issue

2023-01-10 Thread psatheesh
From: Satheesh Paul Flow parsing was not handling pattern matching on the fields of inner VLAN even though MKEX profile could be extracting inner VLAN fields. Code has been modified to handle matching fields on two VLAN tags. Fixes: c34ea71b878 ("common/cnxk: add NPC parsing API") Cc: sta...@dpd

[dpdk-dev] [PATCH v2 3/4] drivers: add IPsec rule reservation scheme for cnxk

2023-01-10 Thread psatheesh
From: Kiran Kumar K For inline IPsec device, reserve number of rules specified by ``max_ipsec_rules`` and use them while installing rules with action as security. Rule priority should be 0. If specified number of rules not available, then only available number of rules will be allocated and used.

[dpdk-dev] [PATCH v2 2/4] net/cnxk: introduce flag for flow validate

2023-01-10 Thread psatheesh
From: Kiran Kumar K Add a flag to check flow validate. In case of MSNS don't need to configure the API to SA translation while validating the flow. Skip this with a check. Signed-off-by: Kiran Kumar K Reviewed-by: Satheesh Paul --- drivers/net/cnxk/cnxk_flow.c | 9 + 1 file changed, 5

[dpdk-dev] [PATCH v2 1/4] common/cnxk: support SPI to SA index

2023-01-10 Thread psatheesh
From: Satheesh Paul In case of IPsec, the inbound SPI can be random. HW supports mapping SPI to an arbitrary SA index. SPI to SA index is done using a lookup in NPC cam entry with key as SPI, MATCH_ID, LFID. Adding mailbox API changes to configure the match table and adding rte flow driver change

Re: [PATCH V4 0/5] app/testpmd: support mulitple process attach and detach port

2023-01-10 Thread lihuisong (C)
在 2023/1/11 0:51, Ferruh Yigit 写道: On 12/6/2022 9:26 AM, Huisong Li wrote: This patchset fix some bugs and support attaching and detaching port in primary and secondary. --- -v4: fix a misspelling. -v3: 1) merge patch 1/6 and patch 2/6 into patch 1/5, and add modification for o

Re: [PATCH v5 0/4] add support for self monitoring

2023-01-10 Thread Tyler Retzlaff
hi, don't interpret this as an objection to the functionality but this looks like a clear example of something that doesn't belong in the EAL. has there been a discussion as to whether or not this should be in a separate library? a basic test is whether or not an implementation exists or can be r

[PATCH v5 4/4] eal: add PMU support to tracing library

2023-01-10 Thread Tomasz Duszynski
In order to profile app one needs to store significant amount of samples somewhere for an analysis latern on. Since trace library supports storing data in a CTF format lets take adventage of that and add a dedicated PMU tracepoint. Signed-off-by: Tomasz Duszynski --- app/test/test_trace_perf.c

[PATCH v5 3/4] eal/x86: support reading Intel PMU events in runtime

2023-01-10 Thread Tomasz Duszynski
Add support for reading Intel PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 2 ++ lib/eal/include/rte_pmu.h | 2 +- lib/eal/x86/include/meson.build | 1 + lib/eal/x86/include/rte_pmu_pmc.h | 33 +++ 4 files

[PATCH v5 2/4] eal/arm: support reading ARM PMU events in runtime

2023-01-10 Thread Tomasz Duszynski
Add support for reading ARM PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 4 ++ lib/eal/arm/include/meson.build | 1 + lib/eal/arm/include/rte_pmu_pmc.h | 39 +++ lib/eal/arm/meson.build | 4 ++ lib/eal/arm/rte_pmu.c

[PATCH v5 1/4] eal: add generic support for reading PMU events

2023-01-10 Thread Tomasz Duszynski
Add support for programming PMU counters and reading their values in runtime bypassing kernel completely. This is especially useful in cases where CPU cores are isolated (nohz_full) i.e run dedicated tasks. In such cases one cannot use standard perf utility without sacrificing latency and performa

[PATCH v5 0/4] add support for self monitoring

2023-01-10 Thread Tomasz Duszynski
This series adds self monitoring support i.e allows to configure and read performance measurement unit (PMU) counters in runtime without using perf utility. This has certain adventages when application runs on isolated cores with nohz_full kernel parameter. Events can be read directly using rte_pm

Reminder - DPDK DTS Working Group - Tomorrow 1/11/22 at 9am ET/6am PT/1400h UTC

2023-01-10 Thread Nathan Southern
Good evening, This is a reminder that tomorrow January 11, 2022, at 9am ET/6am PT/1400h UTC, we will hold our DPDK DTS Working Group. Zoom information to follow. Hope to see you there Thanks, Nathan Description:DPDK Project is inviting you to a scheduled Zoom meeting. Topic: DTS Working Group

Re: [PATCH] devtools: fix escaped space in grep pattern

2023-01-10 Thread Tyler Retzlaff
On Tue, Jan 10, 2023 at 10:33:17PM +0100, Thomas Monjalon wrote: > Since grep 3.8, a warning is printed if a space is escaped in a pattern: > grep: warning: stray \ before white space > > There was an occurence of such extra backslash in check-git-log.sh. > > Fixes: d448efa259e9 ("devtools:

[PATCH] devtools: fix escaped space in grep pattern

2023-01-10 Thread Thomas Monjalon
Since grep 3.8, a warning is printed if a space is escaped in a pattern: grep: warning: stray \ before white space There was an occurence of such extra backslash in check-git-log.sh. Fixes: d448efa259e9 ("devtools: export dictionary for commit title check") Cc: sta...@dpdk.org Signed-off

Re: [PATCH v2 0/4] add rte_thread_set_name API for rte_thread_t

2023-01-10 Thread Tyler Retzlaff
anymore feedback here folks? would like to clear this so i can rebase the rte_control_thread_create series. thanks! On Wed, Dec 14, 2022 at 08:47:17AM -0800, Tyler Retzlaff wrote: > Replace the rte_thread_setname API which operates on pthread_t with > rte_thread_set_name that operates on rte_thr

Re: RFC abstracting atomics

2023-01-10 Thread Tyler Retzlaff
On Tue, Jan 10, 2023 at 12:45:05PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Tuesday, 10 January 2023 10.17 > > > > On Mon, Jan 09, 2023 at 02:56:04PM -0800, Tyler Retzlaff wrote: > > > hi folks, > > > > > > i would like to introduce a lay

TODO - remove dependency on ifconfig

2023-01-10 Thread Stephen Hemminger
It would be good if DTS and DPDK docs and test did not use the ifconfig command. Ifconfig is not maintained and is deprecated. Some distros have stopped shipping it. Ifconfig only used ioctl's and was never updated to handle the many kinds of interfaces and devices in Linux. The documentation pa

Re: RFC abstracting atomics

2023-01-10 Thread Tyler Retzlaff
On Tue, Jan 10, 2023 at 09:16:48AM +, Bruce Richardson wrote: > On Mon, Jan 09, 2023 at 02:56:04PM -0800, Tyler Retzlaff wrote: > > hi folks, > > > > i would like to introduce a layer of abstraction that would allow > > optional use of standard C11 atomics when the platform / toolchain > > com

[PATCH v6 2/2] eal: provide leading and trailing zero bit count abstraction

2023-01-10 Thread Tyler Retzlaff
Provide an abstraction for leading and trailing zero bit counting functions to hide compiler specific intrinsics and builtins. Include basic unit test of following functions added. rte_clz32 rte_clz64 rte_ctz32 rte_ctz64 Signed-off-by: Tyler Retzlaff --- app/test/meson.build

[PATCH v6 1/2] eal: move bit operation common to bitops header

2023-01-10 Thread Tyler Retzlaff
Move the following inline functions from rte_common.h to rte_bitops.h rte_combine32ms1b rte_combine64ms1b rte_bsf32 rte_bsf32_safe rte_bsf64 rte_bsf64_safe rte_fls_u32 rte_fls_u64 rte_is_power_of_2 rte_align32pow2 rte_align32prevpow2 rte_align64pow2 rte_align64prevpow2

[PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction

2023-01-10 Thread Tyler Retzlaff
v6: * remove stray #include v5: * fix implementation of msvc versions of rte_clz{32,64} incorrect use of _BitscanReverse{,64} index. * fix and expand unit test to exercise full range of counting over uint{32,64}_t input values. (which would have caught above mistake). * reduce

[PATCH v5 1/2] eal: move bit operation common to bitops header

2023-01-10 Thread Tyler Retzlaff
Move the following inline functions from rte_common.h to rte_bitops.h rte_combine32ms1b rte_combine64ms1b rte_bsf32 rte_bsf32_safe rte_bsf64 rte_bsf64_safe rte_fls_u32 rte_fls_u64 rte_is_power_of_2 rte_align32pow2 rte_align32prevpow2 rte_align64pow2 rte_align64prevpow2

[PATCH v5 2/2] eal: provide leading and trailing zero bit count abstraction

2023-01-10 Thread Tyler Retzlaff
Provide an abstraction for leading and trailing zero bit counting functions to hide compiler specific intrinsics and builtins. Include basic unit test of following functions added. rte_clz32 rte_clz64 rte_ctz32 rte_ctz64 Signed-off-by: Tyler Retzlaff --- app/test/meson.build

[PATCH v5 0/2] eal: provide leading and trailing zero bit count abstraction

2023-01-10 Thread Tyler Retzlaff
Move existing bit manipulation, log and npow functions from rte_common.h to rte_bitops.h Provide leading and trailing zero bit count functions to abstract away compiler specific implementations. Include basic unit test for new leading/trailing zero bit count functions. v5: * fix implementation

Re: [PATCH v4 2/2] eal: provide leading and trailing zero bit count abstraction

2023-01-10 Thread Tyler Retzlaff
On Tue, Jan 10, 2023 at 01:55:59PM +, Ferruh Yigit wrote: > On 1/9/2023 5:36 PM, Tyler Retzlaff wrote: > > From: Tyler Retzlaff > > > > Provide an abstraction for leading and trailing zero bit counting > > functions to hide compiler specific intrinsics and builtins. > > > > Include basic uni

Re: [PATCH v4 2/2] eal: provide leading and trailing zero bit count abstraction

2023-01-10 Thread Tyler Retzlaff
On Tue, Jan 10, 2023 at 01:55:59PM +, Ferruh Yigit wrote: > On 1/9/2023 5:36 PM, Tyler Retzlaff wrote: > > From: Tyler Retzlaff > > > > Provide an abstraction for leading and trailing zero bit counting > > functions to hide compiler specific intrinsics and builtins. > > > > Include basic uni

Re: [PATCH v1 1/3] pcapng: comment option support for epb

2023-01-10 Thread Stephen Hemminger
On Tue, 10 Jan 2023 17:28:45 +0530 Amit Prakash Shukla wrote: > @@ -548,6 +552,11 @@ rte_pcapng_copy(uint16_t port_id, uint32_t queue, > &hash_opt, sizeof(hash_opt)); > } > > + if (comment) { > + opt = pcapng_add_option(opt, PCAPNG_OPT

Re: [PATCH V4 0/5] app/testpmd: support mulitple process attach and detach port

2023-01-10 Thread Ferruh Yigit
On 12/6/2022 9:26 AM, Huisong Li wrote: > This patchset fix some bugs and support attaching and detaching port > in primary and secondary. > > --- > -v4: fix a misspelling. > -v3: >1) merge patch 1/6 and patch 2/6 into patch 1/5, and add modification > for other bus type. >2) add

Re: [dpdk-dev] [PATCH] common/cnxk: mask LA ltype for second pass for cnxk

2023-01-10 Thread Jerin Jacob
On Thu, Dec 1, 2022 at 9:37 AM wrote: > > From: Kiran Kumar K > > While installing flow rule, if user provide item type > as RTE_FLOW_ITEM_TYPE_ETH, it should be applied to both > first and second pass. Adding changes to mask the ltype > to match both. > > Signed-off-by: Kiran Kumar K > Reviewed

Re: [PATCH v4 0/2] eal: provide leading and trailing zero bit count abstraction

2023-01-10 Thread Ferruh Yigit
On 1/9/2023 5:36 PM, Tyler Retzlaff wrote: > Move existing bit manipulation, log and npow functions from > rte_common.h to rte_bitops.h > > Provide leading and trailing zero bit count functions to abstract away > compiler specific implementations. > > Include basic unit test for new leading/trail

Re: [PATCH v4 1/2] eal: move bit operation functions from common to bitops header

2023-01-10 Thread Ferruh Yigit
On 1/9/2023 5:36 PM, Tyler Retzlaff wrote: > Move the following inline functions from rte_common.h to rte_bitops.h > > rte_combine32ms1b > rte_combine64ms1b > rte_bsf32 > rte_bsf32_safe > rte_bsf64 > rte_bsf64_safe > rte_fls_u32 > rte_fls_u64 > rte_is_power_of_2 > rte_align32po

Re: [PATCH v4 2/2] eal: provide leading and trailing zero bit count abstraction

2023-01-10 Thread Ferruh Yigit
On 1/9/2023 5:36 PM, Tyler Retzlaff wrote: > From: Tyler Retzlaff > > Provide an abstraction for leading and trailing zero bit counting > functions to hide compiler specific intrinsics and builtins. > > Include basic unit test of following functions added. > > rte_clz32 > rte_clz64 >

[PATCH v1 3/3] l3fwd-graph: changes to configure pcap capture

2023-01-10 Thread Amit Prakash Shukla
Added support to configure pcap capture. Signed-off-by: Amit Prakash Shukla --- doc/guides/sample_app_ug/l3_forward_graph.rst | 9 +++ examples/l3fwd-graph/main.c | 56 ++- 2 files changed, 63 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug

[PATCH v1 2/3] graph: pcap capture for graph nodes

2023-01-10 Thread Amit Prakash Shukla
Implementation adds support to capture packets at each node with packet metadata and node name. Signed-off-by: Amit Prakash Shukla --- lib/graph/graph_pcap_trace.c | 166 +++ lib/graph/graph_populate.c | 6 +- lib/graph/graph_private.h| 21 l

[PATCH v1 1/3] pcapng: comment option support for epb

2023-01-10 Thread Amit Prakash Shukla
This change enhances rte_pcapng_copy to have comment in enhanced packet block. Signed-off-by: Amit Prakash Shukla --- app/test/test_pcapng.c | 4 ++-- lib/pcapng/rte_pcapng.c | 11 ++- lib/pcapng/rte_pcapng.h | 4 +++- lib/pdump/rte_pdump.c | 2 +- 4 files changed, 16 insertions(+)

RE: RFC abstracting atomics

2023-01-10 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, 10 January 2023 10.17 > > On Mon, Jan 09, 2023 at 02:56:04PM -0800, Tyler Retzlaff wrote: > > hi folks, > > > > i would like to introduce a layer of abstraction that would allow > > optional use of standard C11 atomics w

Re: [PATCH] sched: fix for tc_ov_enable flag position in subport structure.

2023-01-10 Thread David Marchand
On Mon, Jan 9, 2023 at 3:59 PM Megha Ajmera wrote: > > Current position of "tv_ov_enable" variable in tc_ov_enabled* > rte_sched_subport structure makes the "memory" variable unused. I did not enter the beast... but my understanding is that some object internal to rte_sched_subport currently s

Re: [PATCH] crypto/qat: fix build for generic x86 with GCC 12

2023-01-10 Thread Bruce Richardson
On Mon, Jan 09, 2023 at 11:34:36AM +0100, David Marchand wrote: > Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12"). > The issue appears when building with the "generic" target we have in > devtools/test-meson-builds.sh. > > Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb f

RE: [EXT] Re: [RFC PATCH] graph: add support for pcap trace for graph

2023-01-10 Thread Amit Prakash Shukla
Thanks Stephen for the pointers. I will post next version of the patch with the change. > -Original Message- > From: Stephen Hemminger > Sent: Saturday, January 7, 2023 12:27 AM > To: Amit Prakash Shukla > Cc: Jerin Jacob Kollanukkaran ; Kiran Kumar > Kokkilagadda ; Nithin Kumar Dabilp

RE: [PATCH] sched: fix for tc_ov_enable flag position in subport structure.

2023-01-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Monday, January 9, 2023 2:55 PM > To: dev@dpdk.org; Singh, Jasvinder ; Dumitrescu, > Cristian > Cc: sta...@dpdk.org; marcinx.danilew...@intel.com > Subject: [PATCH] sched: fix for tc_ov_enable flag position in subport > structure. >

Re: [PATCH v2] devtools: parallelize ABI check

2023-01-10 Thread Ferruh Yigit
On 1/9/2023 9:34 AM, Thomas Monjalon wrote: > Generation and comparison of ABI dumps are done on multiple cores > thanks to xargs -P0. > It can accelerate this long step by 5 in my tests. > > xargs reports a global error if one of the process has an error. > > Running a shell function with xargs

RE: [2nd Try]:Re: Traffic Management API Questions

2023-01-10 Thread Singh, Jasvinder
Hi Venky, Please see inline. Thanks, Jasvinder From: Venky Venkatesh Sent: Tuesday, January 10, 2023 8:52 AM To: dev@dpdk.org Subject: [2nd Try]:Re: Traffic Management API Questions Hi, Can someone pls get back on these Thanks -Venky On Thu, Jan 5, 2023 at 4:07 AM Venky Venkatesh mailto:vve

Re: [PATCH] net/iavf:fix slow memory allocation

2023-01-10 Thread David Marchand
Hello, On Tue, Dec 27, 2022 at 7:06 AM You, KaisenX wrote: > > > > > > > I tried to play a bit with a E810 nic on a dual numa and I > > > > > > > can't see anything wrong for now. > > > > > > > Can you provide a simple and small reproducer of your issue? > > > > > > > > > > > > > > Thanks. > > >

RE: [EXT] Re: [PATCH] test/crypto: fix and improve ZUC cipher and auth tests

2023-01-10 Thread Akhil Goyal
> On 1/6/2023 4:15 PM, Ciara Power wrote: > > The incorrect value was used for the reference plaintext offset > > in ZUC cipher function. This is now fixed to convert to byte length, > > rather than bits. > > > > Also, to cleanup the ZUC test code, some small improvements are made. > > The authenti

Re: [PATCH v2 1/2] eal: provide leading and trailing zero bit count abstraction

2023-01-10 Thread Ferruh Yigit
On 1/6/2023 8:51 PM, Thomas Monjalon wrote: > 06/01/2023 19:58, Tyler Retzlaff: >> On Fri, Jan 06, 2023 at 02:40:59PM +0100, Thomas Monjalon wrote: >>> 06/01/2023 13:41, Morten Brørup: > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 6 January 2023 12.48 > >>

Re: RFC abstracting atomics

2023-01-10 Thread Bruce Richardson
On Mon, Jan 09, 2023 at 02:56:04PM -0800, Tyler Retzlaff wrote: > hi folks, > > i would like to introduce a layer of abstraction that would allow > optional use of standard C11 atomics when the platform / toolchain > combination has them available. > > making the option usable would be a phased a

Re: [PATCH v2 1/2] usertools: use argparse module to get input parameter

2023-01-10 Thread Bruce Richardson
On Tue, Jan 10, 2023 at 03:31:45PM +0800, Huisong Li wrote: > The telemetry client script uses argparse module to get input parameter. > argparse uses an optional positional arguments for local socket path to > keep backward compatibility. > > Signed-off-by: Huisong Li > --- Acked-by: Bruce Richa

Re: [RFC PATCH 4/7] telemetry: make array initialization more robust

2023-01-10 Thread Ferruh Yigit
On 1/9/2023 5:49 PM, Tyler Retzlaff wrote: > On Mon, Jan 09, 2023 at 12:16:15PM +, Bruce Richardson wrote: >> On Wed, Dec 14, 2022 at 09:50:33AM -0800, Tyler Retzlaff wrote: >>> On Tue, Dec 13, 2022 at 06:27:27PM +, Bruce Richardson wrote: Rather than relying on a specific ordering of

RE: [PATCH v2 00/10] Support resource sharing among ibv_devices

2023-01-10 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Erez Shitrit > Sent: Thursday, January 5, 2023 3:03 PM > To: dev@dpdk.org > Cc: Alex Vesker ; Raslan Darawsheh > > Subject: [PATCH v2 00/10] Support resource sharing among ibv_devices > > Add the option to use resources (Tables, Matchers, Actions, etc.)

[2nd Try]:Re: Traffic Management API Questions

2023-01-10 Thread Venky Venkatesh
Hi, Can someone pls get back on these Thanks -Venky On Thu, Jan 5, 2023 at 4:07 AM Venky Venkatesh < vvenkat...@paloaltonetworks.com> wrote: > Hi, > I was looking at the DPDK Traffic Management API. I wanted to clarify some > things that I understand from the code (for software based TM > impleme

Re: [PATCH v1 0/3] bbdev: remove offload cost

2023-01-10 Thread Maxime Coquelin
On 12/15/22 00:33, Nicolas Chautru wrote: Removing the optional build flag RTE_BBDEV_OFFLOAD_COST from Intel baseband PMDs and bbdev-test application. This helps to simplify build variants complexity causing compilation issues to be missed. Maxime, the first commit is actually a miss related

Re: [PATCH v1 1/3] test/bbdev: explicit check for allocation failure

2023-01-10 Thread Maxime Coquelin
Hi Thomas & David, Below patch is a fix for a patch you didn't pulled yet. I will squash it to the faulty commit. Regards, Maxime On 12/15/22 00:33, Nicolas Chautru wrote: Adding check for error on return of the rte_bbdev_*_op_alloc_bulk calls in bbdev-test. Fixes: f714a18885a6 ("app/testbbde