[PATCH v2 2/2] usertools: add an argument for file prefix

2023-01-09 Thread Huisong Li
Currently, the file prefix for DPDK runtime directory is 'rte' which was fixed in the telemetry client script. The user had to modify the prefix each time to run this script if the file prefix of application isn't 'rte'. So this patch adds an optional argument for the file prefix, like, "./dpdk-tel

[PATCH v2 1/2] usertools: use argparse module to get input parameter

2023-01-09 Thread Huisong Li
The telemetry client script uses argparse module to get input parameter. argparse uses an optional positional arguments for local socket path to keep backward compatibility. Signed-off-by: Huisong Li --- usertools/dpdk-telemetry-client.py | 14 +++--- 1 file changed, 7 insertions(+), 7 d

[PATCH v2 0/2] usertools: usertools: use argparse to get input and add an argument

2023-01-09 Thread Huisong Li
The telemetry client script uses argparse to get local socket file path and file prefix path. --- v2: use an optional positional arguments for local socket path to keep backward compatibility. Huisong Li (2): usertools: use argparse module to get input parameter usertools: add an argume

RE: [PATCH] cryptodev: increase default max nb queue pairs

2023-01-09 Thread Anoob Joseph
Hi Ruifeng, > Crypto device has devargs "max_nb_queue_pairs" which can be used to change > queue pairs limit at init time. > Then no need to increase the default value? Yes. Thanks for the pointer. This field would suffice for the issue that I'm trying to fix. Thanks, Anoob > -Original Mes

RE: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer

2023-01-09 Thread Rakesh Kudurumalla
> -Original Message- > From: Ori Kam > Sent: Monday, December 26, 2022 10:30 PM > To: Jerin Jacob ; Stephen Hemminger > > Cc: Rakesh Kudurumalla ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Ferruh Yigit > ; Andrew Rybchenko > ; dev@dpdk.org; NBU-Contact-Adrien > Mazarguil (EXTERNAL) >

RE: [PATCH] cryptodev: increase default max nb queue pairs

2023-01-09 Thread Ruifeng Wang
> -Original Message- > From: Anoob Joseph > Sent: Wednesday, January 4, 2023 3:30 PM > To: Akhil Goyal ; Ruifeng Wang ; > Gagandeep Singh > ; hemant.agra...@nxp.com; Kai Ji ; Pablo > de Lara > ; Matan Azrad ; Zhangfei Gao > ; Fan Zhang > Cc: Ashwin Sekhar T K ; jer...@marvell.com; dev@d

Re: [PATCH 1/2] usertools: use argparse module to get input parameter

2023-01-09 Thread lihuisong (C)
在 2023/1/9 22:32, Bruce Richardson 写道: On Mon, Jan 09, 2023 at 08:26:37PM +0800, lihuisong (C) wrote: 在 2023/1/9 17:14, Bruce Richardson 写道: On Mon, Jan 09, 2023 at 02:55:46PM +0800, Huisong Li wrote: The telemetry client script uses argparse module to get input parameter. Signed-off-by: Hu

Re: [PATCH v11 0/6] introduce memarea library

2023-01-09 Thread Dongdong Liu
Hi Chengwen Except for a minor comments, this patchset looks good to me. Reviewed-by: Dongdong Liu Thanks, Dongdong On 2022/12/13 17:13, Chengwen Feng wrote: The memarea library is an allocator of variable-size object which based on a memory region. The main features are as follows: - The mem

Re: [PATCH v11 3/6] memarea: support alloc/free/refcnt-update API

2023-01-09 Thread Dongdong Liu
On 2022/12/13 17:13, Chengwen Feng wrote: This patch supports rte_memarea_alloc()/rte_memarea_free()/ rte_memarea_refcnt_update() API. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/memarea_lib.rst | 10 ++ lib/memarea/memarea_private.h | 3 + lib/memarea/rte_memarea.c

Re: [PATCH V5] ethdev: fix one address occupies two indexes in MAC addrs

2023-01-09 Thread fengchengwen
LGTM Acked-by: Chengwen Feng On 2022/10/20 17:31, Huisong Li wrote: > The dev->data->mac_addrs[0] will be changed to a new MAC address when > applications modify the default MAC address by .mac_addr_set(). However, > if the new default one has been added as a non-default MAC address by > .mac_add

RFC abstracting atomics

2023-01-09 Thread Tyler Retzlaff
hi folks, i would like to introduce a layer of abstraction that would allow optional use of standard C11 atomics when the platform / toolchain combination has them available. making the option usable would be a phased approach intended to focus review and minimize dealing with churn on such a bro

Re: [RFC PATCH 4/7] telemetry: make array initialization more robust

2023-01-09 Thread Tyler Retzlaff
On Mon, Jan 09, 2023 at 12:16:15PM +, Bruce Richardson wrote: > On Wed, Dec 14, 2022 at 09:50:33AM -0800, Tyler Retzlaff wrote: > > On Tue, Dec 13, 2022 at 06:27:27PM +, Bruce Richardson wrote: > > > Rather than relying on a specific ordering of elements in the array > > > matching that of

Re: [PATCH] hash: fix GFNI implementation build with GCC 12

2023-01-09 Thread David Marchand
On Mon, Jan 9, 2023 at 11:24 AM Bruce Richardson wrote: > On Mon, Jan 09, 2023 at 11:03:37AM +0100, David Marchand wrote: > > On a system that has AVX512F and GFNI, compiling fails with: > > > > In file included from > > /usr/lib/gcc/x86_64-redhat-linux/12/include/immintrin.h:71, > >

Re: [PATCH] kni: fix build on RHEL 9.1

2023-01-09 Thread David Marchand
On Mon, Jan 9, 2023 at 10:07 AM David Marchand wrote: > > Hi Ferruh, > > On Fri, Jan 6, 2023 at 9:13 PM Ferruh Yigit wrote: > > > > Linux kernel in the RHEL9.1 seems backported Linux commit [1] that drops > > netif_rx_ni(). > > > > This was fixed in DPDK [2] for vanilla Linux kernel. > > > > Addi

[PATCH v4 2/2] eal: provide leading and trailing zero bit count abstraction

2023-01-09 Thread Tyler Retzlaff
From: Tyler Retzlaff Provide an abstraction for leading and trailing zero bit counting functions to hide compiler specific intrinsics and builtins. Include basic unit test of following functions added. rte_clz32 rte_clz64 rte_ctz32 rte_ctz64 Signed-off-by: Tyler Retzlaff ---

[PATCH v4 1/2] eal: move bit operation functions from common to bitops header

2023-01-09 Thread Tyler Retzlaff
Move the following inline functions from rte_common.h to rte_bitops.h rte_combine32ms1b rte_combine64ms1b rte_bsf32 rte_bsf32_safe rte_bsf64 rte_bsf64_safe rte_fls_u32 rte_fls_u64 rte_is_power_of_2 rte_align32pow2 rte_align32prevpow2 rte_align64pow2 rte_align64prevpow2

[PATCH v4 0/2] eal: provide leading and trailing zero bit count abstraction

2023-01-09 Thread Tyler Retzlaff
Move existing bit manipulation, log and npow functions from rte_common.h to rte_bitops.h Provide leading and trailing zero bit count functions to abstract away compiler specific implementations. Include basic unit test for new leading/trailing zero bit count functions. v4: * combine unit test

Re: [PATCH v3 3/3] test/bitcount: add bitcount tests

2023-01-09 Thread Tyler Retzlaff
On Mon, Jan 09, 2023 at 08:57:32AM -0800, Tyler Retzlaff wrote: > On Sat, Jan 07, 2023 at 09:15:27AM +0100, Thomas Monjalon wrote: > > 06/01/2023 23:01, Tyler Retzlaff: > > > basic unit test of following functions > > > > > > rte_clz32 > > > rte_clz64 > > > rte_ctz32 > > > rte_ctz6

[PATCH] usertools: fix python warnings

2023-01-09 Thread Stephen Hemminger
This fixes most of the flake8 style warnings on the telemetry script. Signed-off-by: Stephen Hemminger --- usertools/dpdk-telemetry-client.py | 37 +++--- 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-

Re: [PATCH v3 3/3] test/bitcount: add bitcount tests

2023-01-09 Thread Tyler Retzlaff
On Sat, Jan 07, 2023 at 09:15:27AM +0100, Thomas Monjalon wrote: > 06/01/2023 23:01, Tyler Retzlaff: > > basic unit test of following functions > > > > rte_clz32 > > rte_clz64 > > rte_ctz32 > > rte_ctz64 > > This can be squashed with implementation in previous patch. > > if you

RE: [PATCH v4 1/4] eal: add generic support for reading PMU events

2023-01-09 Thread Tomasz Duszynski
Hi Ruifeng, >-Original Message- >From: Ruifeng Wang >Sent: Monday, January 9, 2023 8:37 AM >To: Tomasz Duszynski ; dev@dpdk.org >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; >m...@smartsharesystems.com; >zhou...@loongson.cn; nd >Subject: [EXT] RE: [PATCH v4 1/4] eal: add generi

Re: [dpdk-dev] [PATCH] common/cnxk: move ICMP ltype to end of enum

2023-01-09 Thread Jerin Jacob
On Thu, Dec 1, 2022 at 9:33 AM wrote: > > From: Kiran Kumar K > > While configuring the RSS key, mask has been created to match multiple > ltypes for L4. Since ICMP is placed in between, it is also being > considered for RSS. So, moving the ICMP to end of enum. > > Signed-off-by: Kiran Kumar K >

[PATCH] sched: fix for tc_ov_enable flag position in subport structure.

2023-01-09 Thread Megha Ajmera
Current position of "tv_ov_enable" variable in rte_sched_subport structure makes the "memory" variable unused. Fixes: f5e60154ade ("sched: enable traffic class oversubscription conditionally") CC: marcinx.danilew...@intel.com Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 5 +++-- 1 fi

[RFC] net/i40e: replace get and put functions

2023-01-09 Thread Kamalakshitha Aligeri
Integrated zero-copy get and put API's in mempool cache in i40e PMD Signed-off-by: Kamalakshitha Aligeri --- 1. I have replaced the rte_mempool_get_bulk and rte_mempool_put_bulk in net/i40e with the zero-copy get and put API's drivers/net/i40e/i40e_rxtx_vec_avx512.c | 10 +- drivers/net

Re: [PATCH 1/2] usertools: use argparse module to get input parameter

2023-01-09 Thread Bruce Richardson
On Mon, Jan 09, 2023 at 08:26:37PM +0800, lihuisong (C) wrote: > > 在 2023/1/9 17:14, Bruce Richardson 写道: > > On Mon, Jan 09, 2023 at 02:55:46PM +0800, Huisong Li wrote: > > > The telemetry client script uses argparse module to get input parameter. > > > > > > Signed-off-by: Huisong Li > > > ---

RE: [PATCH] sched: fix for demo failure in debug mode

2023-01-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Thursday, January 5, 2023 12:29 PM > To: dev@dpdk.org; Singh, Jasvinder ; Dumitrescu, > Cristian > Cc: sta...@dpdk.org > Subject: [PATCH] sched: fix for demo failure in debug mode > > This issue is happening due to non-initialization o

Re: [PATCH V4 0/5] app/testpmd: support mulitple process attach and detach port

2023-01-09 Thread lihuisong (C)
Hi Thomas and Ferruh, Could you take a look at this patch series? I have modified it according to our last discussion. Best, Huisong 在 2022/12/6 17:26, Huisong Li 写道: This patchset fix some bugs and support attaching and detaching port in primary and secondary. --- -v4: fix a misspelling.

RE: [PATCH v5 1/4] eal: add nonnull and access function attributes

2023-01-09 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Monday, 9 January 2023 12.22 > attributes > > On Wed, Dec 28, 2022 at 4:10 PM Morten Brørup > wrote: > > > > Add "nonnull" function attribute to help the compiler detect a NULL > > pointer being passed to a function not accepting N

Re: [PATCH 1/2] usertools: use argparse module to get input parameter

2023-01-09 Thread lihuisong (C)
在 2023/1/9 17:14, Bruce Richardson 写道: On Mon, Jan 09, 2023 at 02:55:46PM +0800, Huisong Li wrote: The telemetry client script uses argparse module to get input parameter. Signed-off-by: Huisong Li --- usertools/dpdk-telemetry-client.py | 14 +++--- 1 file changed, 7 insertions(+)

RE: [PATCH v5 1/4] eal: add nonnull and access function attributes

2023-01-09 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, 9 January 2023 12.09 > > 28/12/2022 16:10, Morten Brørup: > > Add "nonnull" function attribute to help the compiler detect a NULL > > pointer being passed to a function not accepting NULL pointers as an > > argument at build time

Re: [RFC PATCH 4/7] telemetry: make array initialization more robust

2023-01-09 Thread Bruce Richardson
On Wed, Dec 14, 2022 at 09:50:33AM -0800, Tyler Retzlaff wrote: > On Tue, Dec 13, 2022 at 06:27:27PM +, Bruce Richardson wrote: > > Rather than relying on a specific ordering of elements in the array > > matching that of elements in the enum definition, we can explicitly mark > > each array ent

Re: [PATCH v5 1/4] eal: add nonnull and access function attributes

2023-01-09 Thread David Marchand
On Wed, Dec 28, 2022 at 4:10 PM Morten Brørup wrote: > > Add "nonnull" function attribute to help the compiler detect a NULL > pointer being passed to a function not accepting NULL pointers as an > argument at build time. > > Add "access" function attribute to tell the compiler how a function > a

Re: [PATCH v5 1/4] eal: add nonnull and access function attributes

2023-01-09 Thread Thomas Monjalon
28/12/2022 16:10, Morten Brørup: > Add "nonnull" function attribute to help the compiler detect a NULL > pointer being passed to a function not accepting NULL pointers as an > argument at build time. > > Add "access" function attribute to tell the compiler how a function > accesses its pointer arg

Re: [PATCH v5 2/4] net/bnx2x: fix warnings about rte_memcpy lengths

2023-01-09 Thread David Marchand
Hello bnx2x maintainers, On Wed, Dec 28, 2022 at 6:37 PM Morten Brørup wrote: > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, 28 December 2022 18.03 > > > > On Wed, 28 Dec 2022 17:38:56 +0100 > > Morten Brørup wrote: > > > > > From: Stanisław Kardach [mail

[PATCH] crypto/qat: fix build for generic x86 with GCC 12

2023-01-09 Thread David Marchand
Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12"). The issue appears when building with the "generic" target we have in devtools/test-meson-builds.sh. Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and AES") Cc: sta...@dpdk.org Signed-off-by: David Marcha

Re: [PATCH] hash: fix GFNI implementation build with GCC 12

2023-01-09 Thread Bruce Richardson
On Mon, Jan 09, 2023 at 11:03:37AM +0100, David Marchand wrote: > On a system that has AVX512F and GFNI, compiling fails with: > > In file included from > /usr/lib/gcc/x86_64-redhat-linux/12/include/immintrin.h:71, > from > /usr/lib/gcc/x86_64-redhat-linux/12/include/x86intrin.h

[PATCH] hash: fix GFNI implementation build with GCC 12

2023-01-09 Thread David Marchand
On a system that has AVX512F and GFNI, compiling fails with: In file included from /usr/lib/gcc/x86_64-redhat-linux/12/include/immintrin.h:71, from /usr/lib/gcc/x86_64-redhat-linux/12/include/x86intrin.h:32, from ../../../git/pub/dpdk.org/main/lib/eal/x86/inclu

[PATCH v2] devtools: parallelize ABI check

2023-01-09 Thread Thomas Monjalon
Generation and comparison of ABI dumps are done on multiple cores thanks to xargs -P0. It can accelerate this long step by 5 in my tests. xargs reports a global error if one of the process has an error. Running a shell function with xargs requires to export it with -f, and that is a specific capa

[PATCH] lpm: use SVE for bulk lookup

2023-01-09 Thread Ruifeng Wang
SVE was used for lookupx4 where four entries are looked up at a time. It is not an ideal case for SVE implementation which does not bound to vector length. Changed to use SVE implementation in bulk lookup when the feature is available. And optimized the SVE implementation. The lookupx4 sticks to NE

Re: [PATCH v2] net/i40e: don't check link status on device start

2023-01-09 Thread David Marchand
On Tue, Jan 3, 2023 at 3:02 PM David Marchand wrote: > > Hi i40e maintainers, > > On Tue, Dec 13, 2022 at 10:19 AM David Marchand > wrote: > > > > The mentioned changes broke existing applications when the link status > > of i40e ports is down at the time the port is started. > > Revert those cha

Re: [PATCH] net/iavf: protect insertion in flow list

2023-01-09 Thread David Marchand
On Thu, Jan 5, 2023 at 2:58 PM David Marchand wrote: > > Add missing lock acquire. > > Fixes: ff2d0c345c3b ("net/iavf: support generic flow API") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Please review. -- David Marchand

Re: [PATCH 2/2] usertools: add an argment for file prefix

2023-01-09 Thread Bruce Richardson
On Mon, Jan 09, 2023 at 02:55:47PM +0800, Huisong Li wrote: > Currently, the file prefix for DPDK runtime directory is 'rte' which was > fixed in the telemetry client script. The user had to modify the prefix > each time to run this script if the file prefix of application isn't 'rte'. > So this pa

Re: [PATCH 1/2] usertools: use argparse module to get input parameter

2023-01-09 Thread Bruce Richardson
On Mon, Jan 09, 2023 at 02:55:46PM +0800, Huisong Li wrote: > The telemetry client script uses argparse module to get input parameter. > > Signed-off-by: Huisong Li > --- > usertools/dpdk-telemetry-client.py | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > This is an ol

Re: [PATCH] build: detect backtrace availability

2023-01-09 Thread Bruce Richardson
On Sun, Jan 08, 2023 at 10:59:20AM +0100, Thomas Monjalon wrote: > Backtrace dump is available: > - always on Windows > - on Linux/BSD if execinfo.h is available (not anymore on Alpine) > > The flag RTE_BACKTRACE was set unconditionnaly in rte_config.h. > It is now set only if the feat

Re: [PATCH] kni: fix build on RHEL 9.1

2023-01-09 Thread David Marchand
Hi Ferruh, On Fri, Jan 6, 2023 at 9:13 PM Ferruh Yigit wrote: > > Linux kernel in the RHEL9.1 seems backported Linux commit [1] that drops > netif_rx_ni(). > > This was fixed in DPDK [2] for vanilla Linux kernel. > > Adding RHEL9.1 check for the netif_rx_ni() usage to fix build error. > > [1] > 2

Re: [PATCH v3 0/3] eal: provide leading and trailing zero bit count

2023-01-09 Thread Bruce Richardson
On Fri, Jan 06, 2023 at 02:01:42PM -0800, Tyler Retzlaff wrote: > Move existing bit manipulation, log and npow functions from > rte_common.h to rte_bitops.h > > Provide leading and trailing zero bit count functions to abstract away > compiler specific implementations. > > Include basic unit test

Re: [PATCH v2 1/2] eal: provide leading and trailing zero bit count abstraction

2023-01-09 Thread Bruce Richardson
On Fri, Jan 06, 2023 at 10:47:06AM -0800, Tyler Retzlaff wrote: > On Fri, Jan 06, 2023 at 11:48:17AM +, Bruce Richardson wrote: > > On Thu, Jan 05, 2023 at 04:32:40PM -0800, Stephen Hemminger wrote: > > > On Thu, 5 Jan 2023 09:21:18 -0800 > > > Tyler Retzlaff wrote: > > > > > > > On Thu, Jan

[PATCH] net/hns3: fix inaccurate RTC time to read

2023-01-09 Thread Huisong Li
The sequence of reading current RTC time register doesn't meet the hardware requirements, which causes this time obtained is the one before modifying RTC time. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- drivers/net/hns3/hns3_ptp.c |

[PATCH 7/7] compress/mlx5: add support for LZ4 algorithm

2023-01-09 Thread Michael Baum
Add support for decompress LZ4 algorithm for mlx5 PMD. Signed-off-by: Michael Baum --- doc/guides/compressdevs/features/mlx5.ini | 18 +-- doc/guides/compressdevs/mlx5.rst | 49 +++- doc/guides/rel_notes/release_23_03.rst| 4 + drivers/compress/mlx5/mlx5_compress.c | 145