[PATCH 15/15] common/idpf: add avx512 for single queue model

2022-12-07 Thread beilei . xing
From: Beilei Xing Add avx512 vector path for single queue model. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_rxtx.h| 20 + .../idpf/idpf_common_rxtx_avx512.c} | 4 +-- drivers/common/idpf/meson.build | 30 +++ driv

[PATCH 14/15] common/idpf: add vec queue setup

2022-12-07 Thread beilei . xing
From: Beilei Xing Add vector queue setup for single queue model. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_rxtx.c | 57 ++ drivers/common/idpf/idpf_common_rxtx.h | 2 + drivers/common/idpf/version.map| 1 + drivers/net/idpf/idpf_rxtx.c

[PATCH 13/15] common/idpf: add scalar data path

2022-12-07 Thread beilei . xing
From: Beilei Xing Add timestamp filed to idpf_adapter structure. Add scalar data path for single queue model and split queue model. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.h | 5 + drivers/common/idpf/idpf_common_logs.h | 24 + drivers/common/idpf/idpf_common

[PATCH 12/15] common/idpf: add help functions for queue setup and release

2022-12-07 Thread beilei . xing
From: Beilei Xing Refine rxq setup and txq setup. Move some help functions of queue setup and queue release to common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_rxtx.c | 414 + drivers/common/idpf/idpf_common_rxtx.h | 57 ++ drivers/common/idpf/meson.bu

[PATCH 11/15] common/idpf: add rxq and txq struct

2022-12-07 Thread beilei . xing
From: Beilei Xing Add idpf_rxq and idpf_txq structure in common module. Move configure rxq and txq to common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.h | 2 + drivers/common/idpf/idpf_common_rxtx.h | 112 + drivers/common/idpf/idpf_commo

[PATCH 10/15] common/idpf: add vector flags in vport

2022-12-07 Thread beilei . xing
From: Beilei Xing Add vector flags in idpf_vport structure. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.h | 5 + drivers/net/idpf/idpf_ethdev.h | 5 - drivers/net/idpf/idpf_rxtx.c | 22 ++ 3 files changed, 15 inserti

[PATCH 09/15] common/idpf: init create vport info

2022-12-07 Thread beilei . xing
From: Beilei Xing Initialize create vport info in common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 35 + drivers/common/idpf/idpf_common_device.h | 11 ++ drivers/common/idpf/version.map | 1 + drivers/net/idpf/idpf_ethdev.c

[PATCH 08/15] common/idpf: move ptype table to adapter structure

2022-12-07 Thread beilei . xing
From: Beilei Xing Move ptype_tbl field to idpf_adapter structure. Move get_pkt_type to common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 216 + drivers/common/idpf/idpf_common_device.h | 7 + drivers/common/idpf/idpf_common_virtc

[PATCH 07/15] common/idpf: add irq map/unmap

2022-12-07 Thread beilei . xing
From: Beilei Xing Add irq map/unmap functions in common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 110 + drivers/common/idpf/idpf_common_device.h | 6 ++ drivers/common/idpf/idpf_common_virtchnl.c | 8 -- drivers/common/idpf/i

[PATCH 06/15] common/idpf: add config RSS

2022-12-07 Thread beilei . xing
From: Beilei Xing Move configure RSS to common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 25 + drivers/common/idpf/idpf_common_device.h | 2 ++ drivers/common/idpf/idpf_common_virtchnl.h | 3 --- drivers/common/idpf/version.map

[PATCH 05/15] common/idpf: add vport init/deinit

2022-12-07 Thread beilei . xing
From: Beilei Xing Add vport init/deinit in common module. Signed-off-by: Wenjun Wu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 128 +++ drivers/common/idpf/idpf_common_device.h | 8 ++ drivers/common/idpf/idpf_common_virtchnl.c | 16 +-- dr

[PATCH 03/15] common/idpf: move vc functions to common module

2022-12-07 Thread beilei . xing
From: Beilei Xing Move most of virtual channel functions to idpf common module. Signed-off-by: Wenjun Wu Signed-off-by: Beilei Xing --- drivers/common/idpf/base/meson.build | 2 +- drivers/common/idpf/idpf_common_device.c | 8 + drivers/common/idpf/idpf_common_device.h | 61 ++

[PATCH 04/15] common/idpf: introduce adapter init and deinit

2022-12-07 Thread beilei . xing
From: Beilei Xing Introduce base init and deinit in common module. Signed-off-by: Wenjun Wu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 153 drivers/common/idpf/idpf_common_device.h | 6 + drivers/common/idpf/idpf_common_virtchnl.h |

[PATCH 02/15] common/idpf: add vport structure

2022-12-07 Thread beilei . xing
From: Beilei Xing Move idpf_vport structure to common module, remove ethdev dependency. Also remove unused functions. Signed-off-by: Wenjun Wu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.h | 59 ++ drivers/net/idpf/idpf_ethdev.c | 10 +- drivers/net/i

[PATCH 01/15] common/idpf: add adapter structure

2022-12-07 Thread beilei . xing
From: Beilei Xing Add structure idpf_adapter in common module, the structure includes some basic fields. Introduce structure idpf_adapter_ext in PMD, this structure includes extra fileds except idpf_adapter. Signed-off-by: Wenjun Wu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_comm

[PATCH 00/15] net/idpf: refactor idpf pmd

2022-12-07 Thread beilei . xing
From: Beilei Xing Refactor idpf pmd by introducing idpf common module, which will be also consumed by a new PMD - CPFL (Control Plane Function Library) PMD. The patchset depends on this following patchset: https://patches.dpdk.org/project/dpdk/cover/20221208072725.32434-1-beilei.x...@intel.com/

RE: [PATCH] net/idpf: fix build option check

2022-12-07 Thread Morten Brørup
> From: Jingjing Wu [mailto:jingjing...@intel.com] > Sent: Thursday, 8 December 2022 04.31 > > When enable_iova_as_pa option is disabled, idpf driver should avoid > the building in its build file. > > Fixes: 5bf87b45b2c8 (net/idpf: add AVX512 data path for single queue > model) > Cc: sta...@dpdk.

[PATCH 3/3] net/idpf: fix splitq xmit free

2022-12-07 Thread beilei . xing
From: Jingjing Wu When context descriptor is used during sending packets, mbuf is not freed correctly, it will cause mempool be exhausted. This patch refines the free function. Fixes: 770f4dfe0f79 ("net/idpf: support basic Tx data path") Cc: sta...@dpdk.org Signed-off-by: Jingjing Wu Signed-of

[PATCH 2/3] net/idpf: remove req vports from adapter

2022-12-07 Thread beilei . xing
From: Jingjing Wu This patch refines idpf_adapter structure by removing req_vports. Signed-off-by: Jingjing Wu Signed-off-by: Beilei Xing --- drivers/net/idpf/idpf_ethdev.c | 79 ++ drivers/net/idpf/idpf_ethdev.h | 9 +++- 2 files changed, 49 insertions(+), 39

[PATCH 1/3] net/idpf: remove vport req and recv info from adapter

2022-12-07 Thread beilei . xing
From: Jingjing Wu This patch refines idpf_adapter structure by removing vport request and receive info. Signed-off-by: Jingjing Wu Signed-off-by: Beilei Xing --- drivers/net/idpf/idpf_ethdev.c | 185 +++-- drivers/net/idpf/idpf_ethdev.h | 19 ++-- drivers/net/idpf

[PATCH 0/3] net/idpf: code refine

2022-12-07 Thread beilei . xing
From: Beilei Xing 1. Remove some unnecessary fields from idpf_adapter structure. 2. Fix xmit free for split queue model. Jingjing Wu (3): net/idpf: remove vport req and recv info from adapter net/idpf: remove req vports from adapter net/idpf: fix splitq xmit free drivers/net/idpf/idpf_et

RE: [EXT] [PATCH v1 04/13] graph: add get/set graph worker model APIs

2022-12-07 Thread Yan, Zhirun
> -Original Message- > From: Kiran Kumar Kokkilagadda > Sent: Tuesday, December 6, 2022 11:35 AM > To: Yan, Zhirun ; dev@dpdk.org; Jerin Jacob > Kollanukkaran ; Nithin Kumar Dabilpuram > > Cc: Liang, Cunming ; Wang, Haiyue > > Subject: RE: [EXT] [PATCH v1 04/13] graph: add get/set gra

Re: [PATCH 1/5] eal: add lcore set name and get name API

2022-12-07 Thread Stephen Hemminger
On Wed, 7 Dec 2022 14:33:31 -0800 Tyler Retzlaff wrote: > On Wed, Dec 07, 2022 at 01:03:41PM -0800, Stephen Hemminger wrote: > > On Wed, 7 Dec 2022 11:00:13 -0800 > > Tyler Retzlaff wrote: > > > > > +static char lcore_names[RTE_MAX_LCORE][RTE_LCORE_NAME_MAX_LEN]; > > > > This copy would r

[PATCH] net/idpf: fix build option check

2022-12-07 Thread Jingjing Wu
When enable_iova_as_pa option is disabled, idpf driver should avoid the building in its build file. Fixes: 5bf87b45b2c8 (net/idpf: add AVX512 data path for single queue model) Cc: sta...@dpdk.org Signed-off-by: Jingjing Wu --- drivers/net/idpf/meson.build | 6 ++ 1 file changed, 6 insertion

[PATCH v2] net/nfp: using the correct PCI name to look for the firmware

2022-12-07 Thread Chaoyong He
From: Peng Zhang In the description of nfp document, DPDK PMD supports that the PF looks for a firmware file by the PCI name. After this commit, it will looks for the PCI name format such as pci-:04:00.0.nffw rather than pci-04:00.0.nffw, which will keep consistent with what is written in th

Re: [PATCH 1/5] eal: add lcore set name and get name API

2022-12-07 Thread Tyler Retzlaff
On Wed, Dec 07, 2022 at 01:03:41PM -0800, Stephen Hemminger wrote: > On Wed, 7 Dec 2022 11:00:13 -0800 > Tyler Retzlaff wrote: > > > +static char lcore_names[RTE_MAX_LCORE][RTE_LCORE_NAME_MAX_LEN]; > > This copy would redundant on Linux. > > > + > > +int > > +rte_lcore_set_name(unsigned int lc

Re: [PATCH 1/5] eal: add lcore set name and get name API

2022-12-07 Thread Stephen Hemminger
On Wed, 7 Dec 2022 11:00:13 -0800 Tyler Retzlaff wrote: > +static char lcore_names[RTE_MAX_LCORE][RTE_LCORE_NAME_MAX_LEN]; This copy would redundant on Linux. > + > +int > +rte_lcore_set_name(unsigned int lcore_id, const char *name) > +{ > + if (unlikely(lcore_id >= RTE_MAX_LCORE)) > +

Re: [PATCH v2] net/memif: default to physical socket

2022-12-07 Thread Stephen Hemminger
On Wed, 7 Dec 2022 17:15:06 + Ferruh Yigit wrote: > On 12/7/2022 3:56 PM, Nathan Skrzypczak wrote: > > Hi Ferruh, > > > > Hi Nathan, > > > Thank you for your reply,  > > > > On the potential confusion for users of the DPDK memif PMD : when > > defaulting to abstract sockets was added in

Re: [PATCH v2 1/3] eal: add rte control thread create API

2022-12-07 Thread Tyler Retzlaff
just following up. On Wed, Dec 07, 2022 at 08:38:39AM -0800, Tyler Retzlaff wrote: > On Wed, Dec 07, 2022 at 10:13:39AM +0100, Mattias Rönnblom wrote: > > > > To be consistent with function naming scheme, where "ctrl" is the > > old API, and "control" the new, you could call the start functions >

[PATCH v3 2/3] test: add rte control thread create API test

2022-12-07 Thread Tyler Retzlaff
Duplicate the rte_ctrl_thread_create test adapted to use rte_control_thread create to keep both apis under test until rte_ctrl_thread_create is removed. Signed-off-by: Tyler Retzlaff --- app/test/test_lcores.c | 42 ++ 1 file changed, 42 insertions(+) dif

[PATCH v3 1/3] eal: add rte control thread create API

2022-12-07 Thread Tyler Retzlaff
Add rte_control_thread_create API as a replacement for rte_ctrl_thread_create to allow deprecation of the use of platform specific types in DPDK public API. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_thread.c | 93 ++ lib/eal/include/rte_threa

[PATCH v3 3/3] eal: deprecate pthread control thread create API

2022-12-07 Thread Tyler Retzlaff
Give notice of rte_ctrl_thread_create deprecation. Signed-off-by: Tyler Retzlaff --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index b9b02dc..cb74e08 100644 --- a/doc/g

[PATCH v3 0/3] eal: rte_ctrl_thread_create API replacement

2022-12-07 Thread Tyler Retzlaff
Remove rte_ctrl_thread_create API which exposes pthread_t and provide new rte_control_thread_create API based on EALs rte_thread_t. To limit compatibility regression risk and ease of removal of the existing rte_ctrl_thread_create in the future duplicate most of the existing implementation. The dup

[PATCH 5/5] eal: deprecate rte thread setname API

2022-12-07 Thread Tyler Retzlaff
Notify deprecation of rte_thread_setname API, it is being removed as it exposes platform-specific thread details. The functionality it provided is now implicitly provided via the rte_lcore_set_name API if the underlying platform supports it. Signed-off-by: Tyler Retzlaff --- doc/guides/rel_notes

[PATCH 1/5] eal: add lcore set name and get name API

2022-12-07 Thread Tyler Retzlaff
Add two new APIs that allow set and get of a name for an lcore that do not explose platform thread details via the public interface. If the underlying platform thread API does allow set of a name for the lcore thread id it is called as a side-effect of set but lack of support or failure from the p

[PATCH 4/5] eal: remove thread getname API

2022-12-07 Thread Tyler Retzlaff
Remove the rte_thread_getname API. The API is __rte_experimental and requires no deprecation notice. Signed-off-by: Tyler Retzlaff --- lib/eal/freebsd/eal_thread.c | 9 - lib/eal/include/rte_lcore.h | 17 - lib/eal/linux/eal_thread.c | 15 --- lib/eal/ver

[PATCH 3/5] test: add a unit test for set and get lcore name APIs

2022-12-07 Thread Tyler Retzlaff
Signed-off-by: Tyler Retzlaff --- app/test/test_lcores.c | 52 ++ 1 file changed, 52 insertions(+) diff --git a/app/test/test_lcores.c b/app/test/test_lcores.c index a6bb412..153b6f4 100644 --- a/app/test/test_lcores.c +++ b/app/test/test_lcores.c

[PATCH 2/5] eal: set lcore config thread for lcore main

2022-12-07 Thread Tyler Retzlaff
Set the lcore_config[].thread_id for lcore_main during initialization. This allows the new rte_lcore_{set,get}_name() APIs to work with lcore_main consistent with other worker lcores. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_thread.c | 3 +++ 1 file changed, 3 insertions(+) d

[PATCH 0/5] add lcore set name and get name API

2022-12-07 Thread Tyler Retzlaff
Set the lcore_config[].thread_id for the main lcore. Introduce 2 new public APIs rte_lcore_set_name and rte_lcore_get_name that allow set and get of the lcore name and if the underlying platform supports it sets the platform-specific thread name. Remove rte_thread_getname API Deprecate rte_threa

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-07 Thread Patrick Robb
Hello, Community Lab team members are wondering whether it is possible to bump v22.11 to include at least this patch. We have an existing codebase which relies on a vXX.XX scheme for producing ABI references. We parse that out at different places in our code, so fixing this to handle vXX.XX.X will

Re: [PATCH v2] net/memif: change socket listener owner uid/gid

2022-12-07 Thread Junxiao Shi
Hi Ferruh > On 12/7/2022 2:41 PM, Junxiao Shi wrote: > > This allows a DPDK application running with root privilege to create a > > memif socket listener with non-root owner uid and gid, which can be > > connected from client applications running without root privilege. > > > > Do you have an easy

[PATCH v3] net/memif: change socket listener owner uid/gid

2022-12-07 Thread Junxiao Shi
This allows a DPDK application running with root privilege to create a memif socket listener with non-root owner uid and gid, which can be connected from client applications running without root privilege. Signed-off-by: Junxiao Shi --- doc/guides/nics/memif.rst | 2 ++ drivers/net/memi

Re: [PATCH] net/failsafe: Fix crash due to in-valid sub-device port id

2022-12-07 Thread Ferruh Yigit
On 11/16/2022 12:11 PM, madhuker.myt...@oracle.com wrote: > From: Madhuker Mythri > > Crash occurring while the DPDK secondary processes trying to probe the > tap-device, where tap-device is a sub-device of Fail-safe device. > Some-times we get in-valid sub-devices(with the in-valid port-id's), >

Re: [PATCH v2] net/memif: default to physical socket

2022-12-07 Thread Ferruh Yigit
On 12/7/2022 3:56 PM, Nathan Skrzypczak wrote: > Hi Ferruh, > Hi Nathan, > Thank you for your reply,  > > On the potential confusion for users of the DPDK memif PMD : when > defaulting to abstract sockets was added in [0] (v20.10 release) > it did change the existing behavior, so reverting it w

Re: [PATCH v2] net/memif: change socket listener owner uid/gid

2022-12-07 Thread Ferruh Yigit
On 12/7/2022 3:43 PM, Ferruh Yigit wrote: > On 12/7/2022 2:41 PM, Junxiao Shi wrote: >> This allows a DPDK application running with root privilege to create a >> memif socket listener with non-root owner uid and gid, which can be >> connected from client applications running without root privilege.

[PATCH v3] vhost: exclude VM hugepages from coredumps

2022-12-07 Thread Mike Pattrick
Currently if an application wants to include shared hugepages in coredumps in conjunction with the vhost library, the coredump will be larger than expected and include unneeded virtual machine memory. This patch will mark all vhost huge pages as DONTDUMP, except for some select pages used by DPDK.

Re: [PATCH] net/gve: add support for basic stats

2022-12-07 Thread Stephen Hemminger
On Wed, 7 Dec 2022 15:09:08 + Ferruh Yigit wrote: > On 11/24/2022 7:33 AM, Junfeng Guo wrote: > > Add support for dev_ops of stats_get and stats_reset. > > > > Queue stats update will be moved into xstat [1], but the basic stats > > items may still be required. So we just keep the remaining

Re: [PATCH v2 1/3] eal: add rte control thread create API

2022-12-07 Thread Tyler Retzlaff
On Wed, Dec 07, 2022 at 10:13:39AM +0100, Mattias Rönnblom wrote: > On 2022-12-06 18:28, Tyler Retzlaff wrote: > >Add rte_control_thread_create API as a replacement for > >rte_ctrl_thread_create to allow deprecation of the use of platform > >specific types in DPDK public API. > > > >Signed-off-by:

[PATCH 4/4] testpmd: report lcore usage

2022-12-07 Thread Robin Jarry
Reuse the --record-core-cycles option to account for busy cycles. One turn of packet_fwd_t is considered "busy" if there was at least one received or transmitted packet. Add a new busy_cycles field in struct fwd_stream. Update get_end_cycles to accept an additional argument for the number of proce

[PATCH 3/4] testpmd: add dump_lcores command

2022-12-07 Thread Robin Jarry
Add a simple command that calls rte_lcore_dump(). Signed-off-by: Robin Jarry Acked-by: Morten Brørup --- v3 -> v4: no change app/test-pmd/cmdline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index b32dc8bfd445..96474d2ae458 100644 ---

[PATCH 2/4] eal: allow applications to report their cpu usage

2022-12-07 Thread Robin Jarry
Allow applications to register a callback that will be invoked in rte_lcore_dump() and when requesting lcore info in the telemetry API. The callback is expected to return the number of TSC cycles that have passed since application start and the number of these cycles that were spent doing busy wor

[PATCH 1/4] eal: add lcore info in telemetry

2022-12-07 Thread Robin Jarry
Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cpuset": [ 3 ] } } Signed-off-

[PATCH 0/4] lcore telemetry improvements

2022-12-07 Thread Robin Jarry
This is a follow up on previous work by Kevin Laatz: http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* This series is aimed at allowing DPDK applications to expose their CPU usage stats in the DPDK telemetry under /eal/lcore/info. This is a much more basic and naive approach which l

Re: [PATCH v2] net/memif: change socket listener owner uid/gid

2022-12-07 Thread Ferruh Yigit
On 12/7/2022 2:41 PM, Junxiao Shi wrote: > This allows a DPDK application running with root privilege to create a > memif socket listener with non-root owner uid and gid, which can be > connected from client applications running without root privilege. > Do you have an easy way to test unprivileg

RE: [PATCH v2 3/3] test/bbdev: explicit check for allocation failure

2022-12-07 Thread Chautru, Nicolas
Hi Maxime, I don’t believe this constitutes a fix, just adding more error check to be more comprehensive. Not required for stable branch really. Let me know if you disagree. Can this be applied? Thanks Nic > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, December 7, 2

Re: Mysterious CI/IOL failures in Patchwork

2022-12-07 Thread Owen Hilyard
Hello Morten, It looks like our Fedora 35 and 36 environments were erroneously hidden from public view. This has been fixed and you should now be able to see the issues on the dashboard at the link you provided. Also, please CC dpdk...@iol.unh.edu when you want to contact the community lab. That a

[PATCH v2] net/memif: change socket listener owner uid/gid

2022-12-07 Thread Junxiao Shi
This allows a DPDK application running with root privilege to create a memif socket listener with non-root owner uid and gid, which can be connected from client applications running without root privilege. Signed-off-by: Junxiao Shi --- doc/guides/nics/memif.rst | 2 + drivers/net/memi

Re: [PATCH v2] net/memif: default to physical socket

2022-12-07 Thread Ferruh Yigit
On 10/17/2022 1:12 PM, Nathan Skrzypczak wrote: > This patch changes the default value of the memif abstract > socket flag to false. The implementation of memif with > abstract sockets made abstract-socket=yes the > default in [0] which might confuse users. > Hi Nathan, OK to update logs to clar

Re: [PATCH] net/gve: add support for basic stats

2022-12-07 Thread Ferruh Yigit
On 11/24/2022 7:33 AM, Junfeng Guo wrote: > Add support for dev_ops of stats_get and stats_reset. > > Queue stats update will be moved into xstat [1], but the basic stats > items may still be required. So we just keep the remaining ones and > will implement the queue stats via xstats in the coming

Re: [PATCH] net/nfp: using the correct PCI name to look for the firmware

2022-12-07 Thread Ferruh Yigit
On 11/28/2022 2:37 AM, Chaoyong He wrote: > From: Peng Zhang > > In the description of nfp document, DPDK PMD supports that the PF > looks for a firmware file by the PCI name. > > After this commit, it will looks for the PCI name format such as > pci-:04:00.0.nffw rather than pci-04:00.0.nff

Re: [PATCH] net/memif: change socket listener owner uid/gid

2022-12-07 Thread Ferruh Yigit
On 11/16/2022 5:14 PM, Junxiao Shi wrote: > This allows a DPDK application running with root privilege to create a > memif socket listener with non-root owner uid and gid, which can be > connected from client applications running without root privilege. > > Signed-off-by: Junxiao Shi Hi Junxiao,

Re: [PATCH v4 1/1] app/testpmd: support congestion management CLIs

2022-12-07 Thread Ferruh Yigit
On 12/2/2022 7:56 AM, sk...@marvell.com wrote: > From: Sunil Kumar Kori > > Support congestion management CLIs. > > Signed-off-by: Sunil Kumar Kori > Acked-by: Aman Singh Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [PATCH] devtools: update Meson setup command

2022-12-07 Thread Aaron Conole
Thomas Monjalon writes: > The command "meson build" causes a deprecation warning with meson 0.64: > > WARNING: Running the setup command as `meson [options]` instead of > `meson setup [options]` is ambiguous and deprecated. > > Signed-off-by: Thomas Monjalon > --- Acked-by: Aaron Conole

Re: [PATCH v2] net/nfp: fix issue of data len exceeds descriptor limitation

2022-12-07 Thread Ferruh Yigit
On 11/29/2022 1:21 AM, Chaoyong He wrote: > From: Long Wu > > If dma_len is larger than NFDK_DESC_TX_DMA_LEN_HEAD, the value of > dma_len bitwise and NFDK_DESC_TX_DMA_LEN_HEAD maybe less than packet > head length and the packet will be dropped. Fill maximum dma_len in > first tx descriptor to mak

Re: [RFC PATCH v3] net/memif: change socket listener owner uid/gid

2022-12-07 Thread Ferruh Yigit
On 11/16/2022 5:14 PM, Junxiao Shi wrote: > This allows a DPDK application running with root privilege to create a > memif socket listener with non-root owner uid and gid, which can be > connected from client applications running without root privilege. > +1 to idea As Stephen mentioned, how thi

RE: [PATCH] common/mlx5: improve AES-XTS tweek capability check

2022-12-07 Thread Matan Azrad
> Bluefield-3 and above devices use aes_xts_multi_block_be_tweak bit to indicate > AES-XTS capability. The devices below use aes_xts_single_block_le_tweak bit. > > This commit adds the AES-XTS attribute set while one of the bits is set to > make > the attribute compatible with all the devices.

RE: [PATCH v3 2/4] eal: allow applications to report their cpu cycles usage

2022-12-07 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Wednesday, 7 December 2022 12.01 > > Hi Mattias, > > Mattias Rönnblom, Nov 29, 2022 at 17:10: > > > + * @param [out] busy_cycles > > > + * The number of busy CPU cycles since the application start. > > > > Wouldn't it be more appropriate to

Re: [PATCH v3 2/4] eal: allow applications to report their cpu cycles usage

2022-12-07 Thread Robin Jarry
Hi Mattias, Mattias Rönnblom, Nov 29, 2022 at 17:10: > > + * @param [out] busy_cycles > > + * The number of busy CPU cycles since the application start. > > Wouldn't it be more appropriate to describe it as "TSC cycles", instead > of "CPU cycles"? Or technically "The amount of busy time since

RE: 19.11.14 patches review and test

2022-12-07 Thread Jiang, YuX
Hi All, Update the test status for Intel part. DPDK19.11.14-rc1 validation test is almost finished, no critical issue is found, but find some new bugs for build and power management. New defects for build: No fix yet. https://bugs.dpdk.org/show_bug.cgi?id=1140 https://bugs.dpdk.

RE: 20.11.7 patches review and test

2022-12-07 Thread Jiang, YuX
Hi All, Update the test status for Intel part. Till now dpdk20.11.7-rc1 validation test rate is 95%. No critical issue is found. 2 new bugs are found, 1 new issue is under confirming by Intel Dev. New bugs: 1, Compilation error compiling dpdk with vm_power_manager sample app -- Intel dev is un

Re: [PATCH v2 1/3] eal: add rte control thread create API

2022-12-07 Thread Mattias Rönnblom
On 2022-12-06 18:28, Tyler Retzlaff wrote: Add rte_control_thread_create API as a replacement for rte_ctrl_thread_create to allow deprecation of the use of platform specific types in DPDK public API. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_thread.c | 93 +++

RE: [PATCH] net/iavf:fix slow memory allocation

2022-12-07 Thread You, KaisenX
Can you please help to review? thanks. > -Original Message- > From: You, KaisenX > Sent: 2022年11月17日 14:57 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; You, KaisenX ; Wu, > Jingjing ; Xing, Beilei ; Zhang, > Qi Z > Subject: [PATCH] net/iavf:fix slow memory a

NVIDIA mlx5 PMD roadmap question

2022-12-07 Thread Morten Brørup
NVIDIA mlx5 PMD maintainers, Are there any plans for NVIDIA to support build time IOVA_AS_VA mode (i.e. building with -Denable_iova_as_pa=false) in the mlx5 PMD? I expect it to provide higher performance under certain conditions. Med venlig hilsen / Kind regards, -Morten Brørup

Re: [PATCH v2 3/3] test/bbdev: explicit check for allocation failure

2022-12-07 Thread Maxime Coquelin
On 12/6/22 20:14, Nicolas Chautru wrote: Adding check for error on return of the rte_bbdev_*_op_alloc_bulk calls in bbdev-test. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/app/test-bbdev/t

Re: [PATCH v2 2/3] test/bbdev: fix build issue with optional build flag

2022-12-07 Thread Maxime Coquelin
On 12/6/22 20:14, Nicolas Chautru wrote: Missing implementation for offload test with FFT. Only build when the optional build flag RTE_BBDEV_OFFLOAD_COST is set. Fixes: 0acdb9866756 ("test/bbdev: add FFT operations cases") Same here, adding sta...@dpdk.org. Signed-off-by: Nicolas Chautru

Re: [PATCH v2 1/3] test/bbdev: fix build issue with optional build flag

2022-12-07 Thread Maxime Coquelin
On 12/6/22 20:14, Nicolas Chautru wrote: Incorrect bbdev member name used in test code under RTE_BBDEV_OFFLOAD_COST build flag. Fixes: 4f08028c5e24 ("bbdev: expose queue related warning and status") You missed to cc sta...@dpdk.org. Added it now. Signed-off-by: Nicolas Chautru --- app

virtio PMD roadmap question

2022-12-07 Thread Morten Brørup
virtio PMD maintainers, Are there any plans to support build time IOVA_AS_VA mode (i.e. building with -Denable_iova_as_pa=false) in the virtio PMDs? I expect it to provide higher performance under certain conditions. Med venlig hilsen / Kind regards, -Morten Brørup

VMware vmxnet3 PMD roadmap question

2022-12-07 Thread Morten Brørup
VMware vmxnet3 PMD maintainer, Are there any plans for VMware to support build time IOVA_AS_VA mode (i.e. building with -Denable_iova_as_pa=false) in the vmxnet3 PMD? I expect it to provide higher performance under certain conditions. Med venlig hilsen / Kind regards, -Morten Brørup

Intel i40e and ice PMD roadmap question

2022-12-07 Thread Morten Brørup
Intel i40e and ice PMD maintainers, Are there any plans for Intel to support build time IOVA_AS_VA mode (i.e. building with -Denable_iova_as_pa=false) in the i40e and/or ice PMDs? I expect it to provide higher performance under certain conditions. Med venlig hilsen / Kind regards, -Morten Brør

NIC support for IOVA as VA

2022-12-07 Thread Morten Brørup
Should support for IOVA as VA be listed under NIC features [1]? [1]: http://doc.dpdk.org/guides/nics/ Med venlig hilsen / Kind regards, -Morten Brørup

iavf missing in Supported Hardware list

2022-12-07 Thread Morten Brørup
The iavf hardware is not mentioned here: http://core.dpdk.org/supported/ http://core.dpdk.org/supported/nics/intel/ Med venlig hilsen / Kind regards, -Morten Brørup