[PATCH] doc: update broadcom documentation

2022-11-04 Thread Ajit Khaparde
Update Broadcom NIC documentation. Change-Id: Ife9e7604355cc48233b4fb1cc48df82653d6fada Signed-off-by: Ajit Khaparde --- doc/guides/nics/bnxt.rst | 478 +++ 1 file changed, 284 insertions(+), 194 deletions(-) diff --git a/doc/guides/nics/bnxt.rst b/doc/guides

RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-04 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, November 4, 2022 1:52 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead c

Re: [PATCH v1 2/2] doc: increase python max line to 88

2022-11-04 Thread Stephen Hemminger
On Fri, 4 Nov 2022 09:16:13 + Juraj Linkeš wrote: > > +max_line_length = 88 # > > +https://black.readthedocs.io/en/stable/the_black_code_style/current_sty > > +le.html#li Skip the comment, it caused your line break!

[PATCH] power: fix double free of opened files

2022-11-04 Thread Tadhg Kearney
Fix double free of f_min and f_max by reverting the flcose() for f_min and f_max. As f_min and f_max are stored for further use and closed in uncore deinitialization. Fixes: b127e74 ("power: fix open file descriptors leak") Signed-off-by: Tadhg Kearney --- lib/power/rte_power_intel_uncore.c | 3

RE: [EXT] Re: [PATCH v11 1/1] app/testpmd: support multiple mbuf pools per Rx queue

2022-11-04 Thread Hanumanth Reddy Pothula
> -Original Message- > From: Singh, Aman Deep > Sent: Thursday, November 3, 2022 8:50 PM > To: Hanumanth Reddy Pothula ; Yuying Zhang > > Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; > tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > Nithin Kumar Dabilpuram > Subject: Re: [EXT] R

RE: [PATCH] doc: update sample action description for mlx5

2022-11-04 Thread Jiawei(Jonny) Wang
Hi, Sorry for the late reply. > -Original Message- > From: Thomas Monjalon > Sent: Friday, October 14, 2022 9:11 PM > To: Jiawei(Jonny) Wang > Cc: Raslan Darawsheh ; Asaf Penso ; > Matan Azrad ; Slava Ovsiienko > ; dev@dpdk.org > Subject: Re: [PATCH] doc: update sample action descriptio

[PATCH v2 3/3] app/testeventdev: fix timestamp with crypto producer

2022-11-04 Thread Volodymyr Fialko
With symmetric crypto producer and enabled `--fwd_latency` we will treat rte_mbuf as perf_elt which will lead to rte_mbuf header corruption. Use rte_mbuf data to store time stamp information. For asymmetric add space in result data for time stamp. Fixes: de2bc16e1bd1 ("app/eventdev: add crypto pro

[PATCH v2 2/3] app/testeventdev: fix asymmetric last stage handling

2022-11-04 Thread Volodymyr Fialko
For asymmetric crypto producer check for event type in `process_crypto_request` will not pass in case of multiple stages, due to overwrite of event type during event forward. Use producer type to dispatch. Fixes: 8f5b549502d1 ("app/eventdev: support asym ops for crypto adapter") Cc: sta...@dpdk.or

[PATCH v2 1/3] app/testeventdev: setup crypto adapter before sessions

2022-11-04 Thread Volodymyr Fialko
Setup crypto adapter and add queue pairs before assigning them in session metadata. Session metadata may use queue pair configuration parameters, so queue pair should be added before meta assignment. Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_common.c | 16 ++--

[PATCH v2 0/3] app/testseventdev: crypto producer fixes

2022-11-04 Thread Volodymyr Fialko
This patch series address issues with crypto producer - correct setup sequence and multi stage handling with time stamp attached. v2: - Split fixes into individual patches Volodymyr Fialko (3): app/testeventdev: setup crypto adapter before sessions app/testeventdev: fix asymmetric last stage

Re: [PATCH v3] mailmap: add file to DPDK

2022-11-04 Thread Bruce Richardson
On Fri, Nov 04, 2022 at 12:13:34PM +, Bruce Richardson wrote: > Since a number of contributors to DPDK have submitted patches to DPDK > under more than one email address, we should maintain a mailmap file to > properly track their commits using "shortlog". It also helps fix up any > mangled nam

[PATCH v3] mailmap: add file to DPDK

2022-11-04 Thread Bruce Richardson
Since a number of contributors to DPDK have submitted patches to DPDK under more than one email address, we should maintain a mailmap file to properly track their commits using "shortlog". It also helps fix up any mangled names, for example, with surname/firstname reversed, or with incorrect capita

Help with macro

2022-11-04 Thread Morten Brørup
With this macro: #define RTE_MEMPOOL_CACHE_STAT_ADD(cache, name, n) do { \ (cache)->stats.name += n; \ } while (0) checkpatch complained: WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop So I reluctantl

[PATCH v4 3/3] mempool: use cache for frequently updated stats

2022-11-04 Thread Morten Brørup
When built with stats enabled (RTE_LIBRTE_MEMPOOL_STATS defined), the performance of mempools with caches is improved as follows. When accessing objects in the mempool, either the put_bulk and put_objs or the get_success_bulk and get_success_objs statistics counters are likely to be incremented.

[PATCH v4 2/3] mempool: add stats for unregistered non-EAL threads

2022-11-04 Thread Morten Brørup
This patch adds statistics for unregistered non-EAL threads, which was previously not included in the statistics. Add one more entry to the stats array, and use the last index for unregistered non-EAL threads. The unregistered non-EAL thread statistics are incremented atomically. In theory, the

[PATCH v4 1/3] mempool: split stats from debug

2022-11-04 Thread Morten Brørup
Split stats from debug, to make mempool statistics available without the performance cost of continuously validating the debug cookies in the mempool elements. mempool_perf_autotest shows the following improvements in rate_persec. The cost of enabling mempool debug without this patch: -28.1 % and

[PATCH] net/mlx5: fix Windows flow table and queue routine

2022-11-04 Thread Suanming Mou
The macro HAVE_MLX5_HWS_SUPPORT was introduced for HWS only. And HWS was not supported on Windows. So macro HAVE_MLX5_HWS_SUPPORT should only around the code which HWS uses, but avoid including the code block shared by Linux and Windows. Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering

Re: [PATCH 11/14] baseband/ark: introduce ark baseband driver custom functions

2022-11-04 Thread John Miller
Hi Nicolas, I spoke with the code author and this file was not intended to be upstreamed. It will be removed in V2. -John > On Oct 26, 2022, at 7:22 PM, Chautru, Nicolas > wrote: > > Hi John, > >> -Original Message- >> From: John Miller > > >> S

RE: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq

2022-11-04 Thread Ye, MingjinX
> -Original Message- > From: lihuisong (C) > Sent: 2022年11月4日 18:18 > To: Ye, MingjinX ; dev@dpdk.org > Cc: sta...@dpdk.org; Zhou, YidingX ; Singh, Aman > Deep ; Zhang, Yuying > > Subject: Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq > > > 在 2022/11/4 16:21, Ye, MingjinX 写道

[PATCH] usertools/hugepages: show usage if no action specified

2022-11-04 Thread Thomas Monjalon
Previously, the script was doing nothing if no argument was provided. If neither show, mount/unmount, clear/reserve are specified, it is assumed that the user does not know how to use the script. So the usage is printed and an error code is used in exit. The user will understand something is wrong

[PATCH v3 3/3] mempool: use cache for frequently updated stats

2022-11-04 Thread Morten Brørup
When built with stats enabled (RTE_LIBRTE_MEMPOOL_STATS defined), the performance of mempools with caches is improved as follows. When accessing objects in the mempool, either the put_bulk and put_objs or the get_success_bulk and get_success_objs statistics counters are likely to be incremented.

[PATCH v3 2/3] mempool: add stats for unregistered non-EAL threads

2022-11-04 Thread Morten Brørup
This patch adds statistics for unregistered non-EAL threads, which was previously not included in the statistics. Add one more entry to the stats array, and use the last index for unregistered non-EAL threads. The unregistered non-EAL thread statistics are incremented atomically. In theory, the

[PATCH v3 1/3] mempool: split stats from debug

2022-11-04 Thread Morten Brørup
Split stats from debug, to make mempool statistics available without the performance cost of continuously validating the debug cookies in the mempool elements. mempool_perf_autotest shows the following improvements in rate_persec. The cost of enabling mempool debug without this patch: -28.1 % and

[PATCH v8 8/9] dts: add dts workflow module

2022-11-04 Thread Juraj Linkeš
The module implements methods needed to run DTS. It handles the creation of objects and eventually the whole DTS workflow, such as running node setups, test gathering, setup and execution and various cleanups. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- dts/framework/dts.py |

[PATCH v8 9/9] dts: add dts executable script

2022-11-04 Thread Juraj Linkeš
The script is an interface to run DTS. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- dts/main.py | 23 +++ 1 file changed, 23 insertions(+) create mode 100755 dts/main.py diff --git a/dts/main.py b/dts/main.py new file mode 100755 index 00..43311fa847

[PATCH v8 7/9] dts: add node base class

2022-11-04 Thread Juraj Linkeš
The base class implements basic node management methods - connect and execute commands. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/__init__.py | 7 +++ dts/framework/testbed_model/node.py | 62 + 2 files changed, 69 inser

[PATCH v8 6/9] dts: add ssh session module

2022-11-04 Thread Juraj Linkeš
The module uses the pexpect python library and implements connection to a node and two ways to interact with the node: 1. Send a string with specified prompt which will be matched after the string has been sent to the node. 2. Send a command to be executed. No prompt is specified here. Signed-o

[PATCH v8 4/9] dts: add basic logging facility

2022-11-04 Thread Juraj Linkeš
The logging module provides loggers distinguished by two attributes, a custom format and a verbosity switch. The loggers log to both console and more verbosely to files. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- .gitignore| 3 + dts/framework/logger.py | 11

[PATCH v8 5/9] dts: add remote session abstraction

2022-11-04 Thread Juraj Linkeš
The abstraction allows for easy switching of implementations of remote connections (ssh, telnet, etc.). It implements some common features, such as logging of commands and their outputs and history bookkeeping and defines methods that must be implemented by derived classes. Signed-off-by: Owen Hil

[PATCH v8 2/9] dts: add developer tools

2022-11-04 Thread Juraj Linkeš
The devtools that check Python code are Black and Isort to format the code and Pylama to do static analysis. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- devtools/dts-check-format.sh | 87 doc/guides/tools/dts.rst | 67

[PATCH v8 3/9] dts: add config parser module

2022-11-04 Thread Juraj Linkeš
From: Owen Hilyard The configuration is split into two parts, one defining the parameters of the test run and the other defining the topology to be used. The format of the configuration is YAML. It is validated according to a json schema which also server as detailed documentation of the various

[PATCH v8 1/9] dts: add project tools config

2022-11-04 Thread Juraj Linkeš
Add configuration for Python tools used in DTS: Poetry, dependency and package manager Black, formatter Pylama, static analysis Isort, import sorting Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- MAINTAINERS| 5 + doc/guides/tools/dts.rst | 56 ++ doc/guid

[PATCH v8 0/9] dts: ssh connection to a node

2022-11-04 Thread Juraj Linkeš
All the necessary code needed to connect to a node in a topology with a bit more, such as basic logging and some extra useful methods. To run the code, modify the config file, conf.yaml and execute ./main.py from the root dts folder. Here's an example config: executions: - system_under_test: "SU

Re: [PATCH] event/dlb2: fix meson build

2022-11-04 Thread Jerin Jacob
On Thu, Nov 3, 2022 at 9:52 PM Ferruh Yigit wrote: > > On 11/3/2022 3:35 PM, Thomas Monjalon wrote: > > 03/11/2022 16:22, Ferruh Yigit: > >> "meson setup" fails when '-Werror' compiler flag is enabled [1]. > >> This is not a build error in the driver but a build error in meson > >> during "meson s

Re: [PATCH v3] doc: fix minor issues in the event timer adapter guide

2022-11-04 Thread Jerin Jacob
On Fri, Nov 4, 2022 at 12:26 PM Mattias Rönnblom wrote: > > In the example: > * Properly initialize the socket id field. > * Remove comments redundant and/or not consistent with the code. 180 > seconds is not 2 minutes. > * Remove redundant pointer initialization. > > In both the example and tex

RE: [PATCH] crypto/ipsec-mb: fix qp setup for secondary process

2022-11-04 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Friday, November 4, 2022 9:43 AM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; pablo.de.lara.gua...@intel.con; Power, Ciara > > Subject: [PATCH] crypto/ipsec-mb: fix qp setup for secondary process > > If

[PATCH v4] ethdev: add special flags when creating async transfer table

2022-11-04 Thread Rongwei Liu
The transfer domain rule is able to match traffic wire/vport origin which are corresponding to two kinds of underlayer resources. Wire means traffic arrives from the uplink port while vport means traffic initiated from VF/SF. In customer deployments, they usually match only one kind of traffic in

[PATCH v4] ethdev: add special flags when creating async transfer table

2022-11-04 Thread Rongwei Liu
The transfer domain rule is able to match traffic wire/vport origin which are corresponding to two kinds of underlayer resources. Wire means traffic arrives from the uplink port while vport means traffic initiated from VF/SF. In customer deployments, they usually match only one kind of traffic in

Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq

2022-11-04 Thread lihuisong (C)
在 2022/11/4 16:21, Ye, MingjinX 写道: -Original Message- From: lihuisong (C) Sent: 2022年11月3日 15:01 To: Ye, MingjinX ; dev@dpdk.org Cc: sta...@dpdk.org; Zhou, YidingX ; Singh, Aman Deep ; Zhang, Yuying Subject: Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq 在 2022/11/3 9:28

RE: [PATCH v2 2/3] mempool: include non-DPDK threads in statistics

2022-11-04 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Friday, 4 November 2022 09.59 > > On 2022-11-03 09:59, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > >> Sent: Wednesday, 2 November 2022 18.53 > >> > >> On 2022-11-02 10:09, Morten Brørup wrote: > >

[PATCH] hash: fix memory leak of hash_rcu_cfg

2022-11-04 Thread Jun Qiu
The memory of h->hash_rcu_cfg which is allocated in rte_hash_rcu_qsbr_add was leaked. Fixes: 769b2de ("hash: implement RCU resources reclamation") Cc: sta...@dpdk.org Signed-off-by: Jun Qiu --- lib/hash/rte_cuckoo_hash.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/hash/rte_cuckoo_ha

[PATCH] crypto/ipsec-mb: fix qp setup for secondary process

2022-11-04 Thread Ciara Power
If a secondary process is using a queue pair that has been setup by the primary process, we need to reset mb_mgr pointers. This commit removes an error return in this case, allowing secondary to do the remaining setup for the existing qp. Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IP

Re: [PATCH v1 2/2] doc: increase python max line to 88

2022-11-04 Thread Bruce Richardson
On Fri, Nov 04, 2022 at 09:16:13AM +, Juraj Linkeš wrote: > Adding folks I forgot to add. > > > -Original Message- > > From: Juraj Linkeš > > Sent: Thursday, November 3, 2022 2:29 PM > > Cc: dev@dpdk.org; Juraj Linkeš > > Subject: [PATCH v1 2/2] doc: increase python max line to 88 >

Re: [PATCH v1 1/2] git: ignore standard python files

2022-11-04 Thread Bruce Richardson
On Thu, Nov 03, 2022 at 01:29:25PM +, Juraj Linkeš wrote: > These are python byte-compiled/optimized/dll files and IDE files. > > Signed-off-by: Juraj Linkeš > --- > .gitignore | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/.gitignore b/.gitignore > index 212

RE: [PATCH v5] vdpa/ifc/base: wait for queue disable before saving q-state

2022-11-04 Thread Mandal, Purna Chandra
-Original Message- From: Maheshwari, Abhishek Sent: Thursday, November 3, 2022 3:05 PM To: maxime.coque...@redhat.com; Wang, Xiao W Cc: dev@dpdk.org; sta...@dpdk.org; Xia, Chenbo ; Mandal, Purna Chandra ; Maheshwari, Abhishek Subject: [PATCH v5] vdpa/ifc/base: wait for queue disabl

Re: [PATCH v10 0/8] app/procinfo: add some extended features

2022-11-04 Thread Dongdong Liu
Hi Thomas Kindly ping. Can this patchset be applied? Thanks, Dongdong On 2022/10/11 19:18, Dongdong Liu wrote: This patchset is to add some extended features for dpdk-proc-info. Thanks to Reshma and Stephen help to review the patchset. v9->v10: - Fix some comments for Rx/Tx descriptor dump.

RE: [PATCH v1] dts: add Dockerfile

2022-11-04 Thread Juraj Linkeš
Adding folks I forgot to add. > -Original Message- > From: Juraj Linkeš > Sent: Thursday, November 3, 2022 2:47 PM > Cc: dev@dpdk.org; Juraj Linkeš > Subject: [PATCH v1] dts: add Dockerfile > > The Dockerfile defines development and CI runner images. > > Signed-off-by: Juraj Linkeš >

RE: [PATCH v1 2/2] doc: increase python max line to 88

2022-11-04 Thread Juraj Linkeš
Adding folks I forgot to add. > -Original Message- > From: Juraj Linkeš > Sent: Thursday, November 3, 2022 2:29 PM > Cc: dev@dpdk.org; Juraj Linkeš > Subject: [PATCH v1 2/2] doc: increase python max line to 88 > > 88 is a good compromise between shorter files, readability and other > co

RE: [PATCH v1 1/2] git: ignore standard python files

2022-11-04 Thread Juraj Linkeš
Adding folks I forgot to add > -Original Message- > From: Juraj Linkeš > Sent: Thursday, November 3, 2022 2:29 PM > Cc: dev@dpdk.org; Juraj Linkeš > Subject: [PATCH v1 1/2] git: ignore standard python files > > These are python byte-compiled/optimized/dll files and IDE files. > > Signe

RE: [PATCH v1 0/2] python gitignore and line length

2022-11-04 Thread Juraj Linkeš
Adding folks I forgot to add. > -Original Message- > From: Juraj Linkeš > Sent: Thursday, November 3, 2022 2:29 PM > Cc: dev@dpdk.org; Juraj Linkeš > Subject: [PATCH v1 0/2] python gitignore and line length > > These two config options/preferences are relevant to DTS, but not only to >

Re: [PATCH v2 2/3] mempool: include non-DPDK threads in statistics

2022-11-04 Thread Mattias Rönnblom
On 2022-11-03 09:59, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Wednesday, 2 November 2022 18.53 On 2022-11-02 10:09, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Wednesday, 2 November 2022 08.53 On 2022-10-31 12:26, Mor

Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-04 Thread Maxime Coquelin
On 11/4/22 04:52, Hernan Vargas wrote: Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null. Coverity issue: 381646, 381631 Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") Signed-off-by: Hernan Vargas ---

Re: [PATCH 2/2] app/testeventdev: resolve issues with crypto producer

2022-11-04 Thread Jerin Jacob
On Thu, Nov 3, 2022 at 11:24 PM Volodymyr Fialko wrote: > > Resolve issues with crypto producer in configuration with multiple stages. > > 1) With symmetric crypto producer and enabled `--fwd_latency` we will > treat rte_mbuf as perf_elt which will lead to rte_mbuf header > corruption. Use rte_mbu

RE: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq

2022-11-04 Thread Ye, MingjinX
> -Original Message- > From: lihuisong (C) > Sent: 2022年11月3日 15:01 > To: Ye, MingjinX ; dev@dpdk.org > Cc: sta...@dpdk.org; Zhou, YidingX ; Singh, Aman > Deep ; Zhang, Yuying > > Subject: Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq > > > 在 2022/11/3 9:28, Ye, MingjinX 写道:

[PATCH] hash: fix memory leak of hash_rcu_cfg

2022-11-04 Thread Jun Qiu
The memory of h->hash_rcu_cfg which allocated in rte_hash_rcu_qsbr_add was leaked. Signed-off-by: Jun Qiu --- lib/hash/rte_cuckoo_hash.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c index 62c762439a..829b79c89a 100644 --- a/lib/hash/