Re: [PATCH v1 3/6] baseband/acc: fix to acc200 access corner case

2022-11-01 Thread Maxime Coquelin
On 11/2/22 00:04, Nicolas Chautru wrote: To enforce safe access to the ACC200 device, the PMD requires to explicitly check that the device is in configured and enabled state prior to accessing queue resources. This is done by checking the Qmgr ingress queue status. Fixes: 40e3adbdd3 ("baseban

Re: [PATCH v1 2/6] baseband/acc: fix to possible overflow

2022-11-01 Thread Maxime Coquelin
On 11/2/22 00:04, Nicolas Chautru wrote: Potential overflow issue when casting to 64bits, notably relevant when extending number of queues. Coverity issue: 381665 Fixes: 32e8b7ea35 ("baseband/acc100: refactor to segregate common code") Fixes: 40e3adbdd3 ("baseband/acc200: add queue configurat

Re: [PATCH v1 1/6] baseband/acc: fix LTE half iteration flag

2022-11-01 Thread Maxime Coquelin
On 11/2/22 00:04, Nicolas Chautru wrote: The logic for that flag was inverted. Specific to ACC200. When starting with even iteration it actually runs for an additional half iteration. Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") Signed-off-by: Nicolas Chautru --- drivers/bas

RE: [PATCH v2] net/bonding: make bonded device configure method re-entrant

2022-11-01 Thread Jiang, YuX
Hi Ivan, https://bugs.dpdk.org/show_bug.cgi?id=1119 https://bugs.dpdk.org/show_bug.cgi?id=1118 Can be fixed by patches: https://patches.dpdk.org/project/dpdk/patch/20221101161853.2702425-1-ivan.ma...@oktetlabs.ru/ https://patches.dpdk.org/project/dpdk/patch/20221031131744.234015

RE: [PATCH v3 0/2] devtools: add tracepoint check in checkpatch

2022-11-01 Thread Ankur Dwivedi
Hi Thomas, Please let me know if this series can be included in 22.11 rc3. Regards, Ankur >-Original Message- >From: Ankur Dwivedi >Sent: Saturday, October 15, 2022 6:28 PM >To: dev@dpdk.org >Cc: tho...@monjalon.net; david.march...@redhat.com; Akhil Goyal >; royzhang1...@gmail.com; Amit

[PATCH v2] vdpa/ifc/base: wait for queue disable before saving q-state

2022-11-01 Thread Abhishek Maheshwari
Some ifc hardware require synchronization between disabling a queue and saving queue-state from LM registers. When queue is disabled from vDPA driver, ifc device stops executing new virtio-cmds and then updates LM registers with used/avail index. Before saving the queue-state, vDPA driver should wa

RE: [PATCH] net/bonding: fix device configure reentrancy

2022-11-01 Thread Yuan, DukaiX
-Original Message- From: Ivan Malov Sent: 2022年11月2日 0:19 To: dev@dpdk.org Cc: Jiang, YuX ; Chas Williams ; Min Hu (Connor) ; Burakov, Anatoly ; sta...@dpdk.org; Andrew Rybchenko Subject: [PATCH] net/bonding: fix device configure reentrancy As per report [1], the previous patch for de

[PATCH v2] vdpa/ifc/base: wait for queue disable before saving q-state

2022-11-01 Thread Abhishek Maheshwari
Some ifc hardware require synchronization between disabling a queue and saving queue-state from LM registers. When queue is disabled from vDPA driver, ifc device stops executing new virtio-cmds and then updates LM registers with used/avail index. Before saving the queue-state, vDPA driver should wa

RE: meson test link bonding failed//RE: [PATCH] net/bonding: fix descriptor limit reporting

2022-11-01 Thread Li, WeiyuanX
Hi, The following patches apply to successfully resolve this issue. https://patches.dpdk.org/project/dpdk/patch/20221031131744.2340150-1-ivan.ma...@oktetlabs.ru/ https://patches.dpdk.org/project/dpdk/patch/20221101161853.2702425-1-ivan.ma...@oktetlabs.ru/ Regards, Li, Weiyuan > -Original Me

[PATCH] net/nfp: fix an out of bounds write problem

2022-11-01 Thread Chaoyong He
Fix the check logic of the index of the array, which caused the out of bounds write problem. Coverity issue: 381616 Fixes: 0666af498761 ("net/nfp: support RSS based on VXLAN inner layer") Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_common.c | 2 +- 1 file c

[PATCH] net/iavf: fix vlan offload issue

2022-11-01 Thread Wenzhuo Lu
HW VLAN offload cannot be enabled because the HW capability flags are not set correctly. Fixes: eff56a7b9f97 ("net/iavf: add offload path for Rx AVX512") Cc: sta...@dpdk.org Signed-off-by: Wenzhuo Lu --- drivers/net/iavf/iavf_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/

[PATCH v1 6/6] baseband/acc: fix redundant function definition

2022-11-01 Thread Nicolas Chautru
From: Hernan Vargas Remove acc100_dma_fill_blk_type_in which already exists in acc_common.h Fixes: 32e8b7ea35d ("baseband/acc100: refactor to segregate common code") Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 93 +-- 1 file changed, 3 inse

[PATCH v1 5/6] baseband/acc: fix double MSI intr in TB mode

2022-11-01 Thread Nicolas Chautru
From: Hernan Vargas Fix logical bug in SW causing MSI to be issued twice when running in transport block mode. Fixes: f404dfe35cc ("baseband/acc100: support 4G processing") Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/

[PATCH v1 4/6] baseband/acc: fix PMON register values

2022-11-01 Thread Nicolas Chautru
From: Hernan Vargas Enable properly the PMon for ACC100. Previous commit was missing actual implementation and using incorrect register values. Fixes: b4bd57b74c8 ("baseband/acc100: configure PMON control registers") Signed-off-by: Hernan Vargas --- drivers/baseband/acc/acc100_pmd.h | 6 +

[PATCH v1 3/6] baseband/acc: fix to acc200 access corner case

2022-11-01 Thread Nicolas Chautru
To enforce safe access to the ACC200 device, the PMD requires to explicitly check that the device is in configured and enabled state prior to accessing queue resources. This is done by checking the Qmgr ingress queue status. Fixes: 40e3adbdd3 ("baseband/acc200: add queue configuration") Signed-of

[PATCH v1 2/6] baseband/acc: fix to possible overflow

2022-11-01 Thread Nicolas Chautru
Potential overflow issue when casting to 64bits, notably relevant when extending number of queues. Coverity issue: 381665 Fixes: 32e8b7ea35 ("baseband/acc100: refactor to segregate common code") Fixes: 40e3adbdd3 ("baseband/acc200: add queue configuration") Signed-off-by: Nicolas Chautru --- dr

[PATCH v1 1/6] baseband/acc: fix LTE half iteration flag

2022-11-01 Thread Nicolas Chautru
The logic for that flag was inverted. Specific to ACC200. When starting with even iteration it actually runs for an additional half iteration. Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 3 +-- 1 file chan

[PATCH v1 0/6] baseband/acc: fixes on top of RC2

2022-11-01 Thread Nicolas Chautru
A few fixes still required for the baseband acc PMDs for ACC100 and ACC200 on top of RC2. Most of them introduced recently including one covery warning. All changes pushed in same serie for ease of review/apply. Hernan Vargas (3): baseband/acc: fix PMON register values baseband/acc: fix double

RE: [PATCH v2] doc: fix minor issues in the event timer adapter guide

2022-11-01 Thread Carrillo, Erik G
> -Original Message- > From: Mattias Rönnblom > Sent: Tuesday, November 1, 2022 4:34 AM > To: Carrillo, Erik G > Cc: Jerin Jacob ; dev@dpdk.org; sta...@dpdk.org; > mattias.ronnblom > Subject: [PATCH v2] doc: fix minor issues in the event timer adapter guide > > In the example: > * Prope

Re: [PATCH] net/bonding: fix device configure reentrancy

2022-11-01 Thread Stephen Hemminger
On Tue, 1 Nov 2022 19:18:53 +0300 Ivan Malov wrote: > diff --git a/drivers/net/bonding/eth_bond_private.h > b/drivers/net/bonding/eth_bond_private.h > index d067ea8c9a..7171516d0d 100644 > --- a/drivers/net/bonding/eth_bond_private.h > +++ b/drivers/net/bonding/eth_bond_private.h > @@ -184,6 +1

RE: [PATCH v1] crypto/qat: fix reallocate OpenSSL version check

2022-11-01 Thread Ji, Kai
Please see my comments below, In addition, in qat_sym_session.c l.2642 return qat_sym_gen_dev_ops[qat_dev_gen].set_session((void *)cdev, session); the session pointer should cast to (void *) or we can pass session_private directly. Regards Kai > -Original Message- > From: Dooley, B

[PATCH] crypto/scheduler: fix session retrieval for ops

2022-11-01 Thread Ciara Power
In cases where some ops failed to enqueue, the op session was never being reset. This resulted in a segmentation fault when processing ops the next time. To fix this, only set the op session after the failure condition is checked. Also, the incorrect ops index was being used for session retrieval

RE: [PATCH v2] net/bonding: make bonded device configure method re-entrant

2022-11-01 Thread Ivan Malov
Hi, Thanks for noticing the bug. A fix has been proposed already: https://patches.dpdk.org/project/dpdk/patch/20221101161853.2702425-1-ivan.ma...@oktetlabs.ru/ With the fix applied, does the problem still manifest itself? Please let me know. Thank you. On Tue, 1 Nov 2022, Jiang, YuX wrote: H

[PATCH] net/bonding: fix device configure reentrancy

2022-11-01 Thread Ivan Malov
As per report [1], the previous patch for device configure code apparently overlooks the corner case of manually adding back-end devices to the bond using testpmd CLI. The problem is in removing back-end ports on re-configure instead of just stopping them. Fix that. Fixes: 339f1ba51353 ("net/bondi

RE: [PATCH] doc: support flow matching on representor ID

2022-11-01 Thread Sean Zhang (Networking SW)
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 1, 2022 5:37 PM > To: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko ; Sean > Zhang (Networking SW) > Cc: dev@dpdk.org > Subject: Re: [PATCH] doc: support flow matching on representor ID > > External email: Use

[v2] doc: support flow matching on representor ID

2022-11-01 Thread Sean Zhang
Add note for support of matching on port representor ID. Fixes: 707d5e7d79e0 ("net/mlx5: support flow matching on representor ID") Signed-off-by: Sean Zhang --- v2 - add fixes line --- doc/guides/nics/mlx5.rst | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + 2 files changed, 2

RE: [PATCH v11 1/1] app/testpmd: support multiple mbuf pools per Rx queue

2022-11-01 Thread Hanumanth Reddy Pothula
Ping > -Original Message- > From: Hanumanth Pothula > Sent: Tuesday, October 25, 2022 7:10 AM > To: Aman Singh ; Yuying Zhang > > Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; tho...@monjalon.net; > Jerin Jacob Kollanukkaran ; Nithin Kumar Dabilpuram > ; Hanumanth Reddy Pothula > > S

[dpdk-dev v1] crypto/ipsec_mb: fix of qp NULL check

2022-11-01 Thread Kai Ji
This patch fix the NULL pointer check when dereference qp and ring lookup. Coverity issue: 381625 Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework") Cc: roy.fan.zh...@intel.com Signed-off-by: Kai Ji --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +++-- 1 file changed, 3 inser

RE: [PATCH v2] net/bonding: make bonded device configure method re-entrant

2022-11-01 Thread Jiang, YuX
Hi Ivan, This patch introduces a bug https://bugs.dpdk.org/show_bug.cgi?id=1119, can you pls have a look quickly? Best regards, Yu Jiang > -Original Message- > From: Ivan Malov > Sent: Wednesday, October 19, 2022 3:46 AM > To: dev@dpdk.org > Cc: Chas Williams <3ch...@gmail.com>; Min Hu

[PATCH v1] net/mlx5: fix action flag data type

2022-11-01 Thread Shun Hao
MLX5_FLOW_ACTION flags are used as uint64_t now, but some old flags are not defined as 64 bits. So if they are type casted to uint64 after bitwise operations, the high 32-bit data might be incorrect. E.g. Currently MLX5_FLOW_ACTION_DROP is defined as 0x1u, when it is used like: (action_fla

[Bug 1119] [dpdk-22.11]pvp_virtio_bonding/vhost_virtio_bonding_mode_from_0_to_6: start bonding device failed and core dumped when quit testpmd

2022-11-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1119 Bug ID: 1119 Summary: [dpdk-22.11]pvp_virtio_bonding/vhost_virtio_bonding_mo de_from_0_to_6: start bonding device failed and core dumped when quit testpmd Product: DPDK V

[PATCH 1/1] test/bbdev: use helper function to set IOVA addr

2022-11-01 Thread Srikanth Yalavarthi
Use helper function rte_mbuf_iova_set to set IOVA address to fix compilation failures. Below error was observed: dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’: dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error: ‘struct rte_mbuf’ has no member named ‘buf_iova’ 1145 |

[PATCH v2 1/1] test/bbdev: use helper function to set IOVA addr

2022-11-01 Thread Srikanth Yalavarthi
Use helper function rte_mbuf_iova_set to set IOVA address to fix compilation failures. Below error was observed: dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’: dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error: ‘struct rte_mbuf’ has no member named ‘buf_iova’ 1145 |

[PATCH v2] doc: fix minor issues in the event timer adapter guide

2022-11-01 Thread Mattias Rönnblom
In the example: * Properly initialize the socket id field. * Remove comments redundant and/or not consistent with the code. 180 seconds is not 2 minutes. * Remove redundant pointer initialization. * Access max_tmo_ns with the appropriate name. In both the example and in one instance in the body

Re: [PATCH] doc: support flow matching on representor ID

2022-11-01 Thread Thomas Monjalon
01/11/2022 04:25, Sean Zhang: > Add note for support of matching on port representor ID. > > Signed-off-by: Sean Zhang When was it added? Please can you add a Fixes line to reference the commit?

[PATCH] doc: fix various minor issues in the event timer adapter guide

2022-11-01 Thread Mattias Rönnblom
In the example: * Properly initialize the socket id field. * Remove comments redundant and/or not consistent with the code. 180 seconds is not 2 minutes. * Remove redundant pointer initialization. In both the example and in one instance in the body text, the flags field of the conf struct was er

[PATCH 1/1] test/bbdev: use helper function to set IOVA addr

2022-11-01 Thread Srikanth Yalavarthi
Use helper function rte_mbuf_iova_set to set IOVA address to fix compilation failures. Fixes: 0acdb98667 ("test/bbdev: add FFT operations cases") Signed-off-by: Srikanth Yalavarthi --- app/test-bbdev/test_bbdev_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-

RE: [PATCH v2] net/idpf: fix compiling error in CentOS 7

2022-11-01 Thread Ali Alnubani
> -Original Message- > From: beilei.x...@intel.com > Sent: Tuesday, November 1, 2022 4:44 AM > To: jingjing...@intel.com > Cc: dev@dpdk.org; Beilei Xing > Subject: [PATCH v2] net/idpf: fix compiling error in CentOS 7 > > From: Beilei Xing > > There's build error with clang 3.4.2 in Cen

[PATCH v5] gro : fix reordering of packets in GRO library

2022-11-01 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a TCP packet contains flags like PSH it is returned immediately to the application though there might be packets of the same flow in the GRO table. If PSH flag is set on a segment packets up to the segment should be delivered immediately. But the current implementa

[PATCH v5] gro : fix reordering of packets in GRO library

2022-11-01 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a TCP packet contains flags like PSH it is returned immediately to the application though there might be packets of the same flow in the GRO table. If PSH flag is set on a segment packets up to the segment should be delivered immediately. But the current implementa