RE: [PATCH v8 07/12] vdpa/ifc: change internal function name

2022-10-18 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Tuesday, October 18, 2022 8:08 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v8 07/12] vdpa/ifc: change internal function name > > Change internal function name

Re: crypto/uadk: introduce uadk crypto driver

2022-10-18 Thread Thomas Monjalon
18/10/2022 12:52, Zhangfei Gao: > > On 2022/10/18 下午6:07, Zhangfei Gao wrote: > > Hi, Akhil > > > >> > >> On 2022/10/17 下午3:02, Akhil Goyal wrote: > >>> > >>> Hi everyone, > >>> > >>> We have a new crypto PMD submitted on ML > >>> (http://patches.dpdk.org/project/dpdk/cover/20221008083747.6559-1-

Re: Invalid Ip length packets with DPDK21.11 on OCI

2022-10-18 Thread Nageswara Rao
Firmware version: h-5.1# ethtool -i eth0 driver: bnxt_en version: 5.10.110-yocto-standard firmware-version: 20.8.187.0/pkg 20.8.29.0 expansion-rom-version: bus-info: :00:03.0 supports-statistics: yes supports-test: no supports-eeprom-access: no supports-register-dump: no supports-priv-flags: no

Re: Invalid Ip length packets with DPDK21.11 on OCI

2022-10-18 Thread Ajit Khaparde
On Tue, Oct 18, 2022 at 11:24 PM Nageswara Rao wrote: > > Hi, > > Recently we upgraded from DPDK-19.11 to DPDK-21.11. Post upgrade, on OCI > VM.Standard2.8, we are observing packet drop due invalid IP length/truncated > packets for the TCP & UDP traffic. However ping packets are going through

RE: [PATCH v4] vhost: add new `rte_vhost_vring_call_nonblock` API

2022-10-18 Thread Xia, Chenbo
> -Original Message- > From: Liu, Changpeng > Sent: Monday, October 17, 2022 3:48 PM > To: dev@dpdk.org > Cc: Liu, Changpeng ; Maxime Coquelin > ; Xia, Chenbo ; David > Marchand > Subject: [PATCH v4] vhost: add new `rte_vhost_vring_call_nonblock` API > > Vhost-user library locks all VQ's

[PATCH] net/bonding: fix bond4 drop valid MAC packets

2022-10-18 Thread Huisong Li
Currently, by default, bond4 will first try to enable allmulti and then enable promiscuous if fail to enable allmulti. On reception, whether unicast and multicast packets should be dropped depends on which mode has been enabled on the bonding interface. In fact, if MAC address of packets in mac_ad

RE: [PATCH v2 03/24] net/nfp: add the flow APIs of nfp PMD

2022-10-18 Thread Chaoyong He
> On 10/10/2022 7:08 AM, Chaoyong He wrote: > > Add the flow validate/create/query/destroy/flush API of nfp PMD. > > > > The flow create API construct a control cmsg and send it to firmware, > > then add this flow to the hash table. > > > > The flow query API get flow stats from the flow_priv stru

RE: [PATCH v6 2/2] examples/vhost: unconfigure DMA vchannel

2022-10-18 Thread Ling, WeiX
> -Original Message- > From: xuan.d...@intel.com > Sent: Tuesday, October 18, 2022 11:22 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > ; Yang, YvonneX ; Jiang, > Cheng1 ; Wang, YuanX ; > Ma, WenwuX ; Ding, Xuan > Subject: [PATCH v6 2/2]

RE: [PATCH v2 02/24] net/nfp: add the structures and functions for flow offload

2022-10-18 Thread Chaoyong He
> On 10/10/2022 7:08 AM, Chaoyong He wrote: > > Add the structures and functions to process mask table, flow table, > > and flow stats id, which are used in the rte_flow offload logics. > > > > Signed-off-by: Chaoyong He > > Reviewed-by: Niklas Söderlund > > <...> > > > +__rte_unused static int

RE: [PATCH V2] doc: add ice in-tree driver version for Intel NICs

2022-10-18 Thread Lin, Xueqin
> -Original Message- > From: Yu Jiang > Sent: Friday, October 14, 2022 3:12 PM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Jiang, YuX > Subject: [PATCH V2] doc: add ice in-tree driver version for Intel NICs > > doc: add ice in-tree driver version for Intel NICs ice in-tree driver test > star

RE: [PATCH v6] lib/eal: fix segfaults in exiting

2022-10-18 Thread Zeng, ZhichaoX
Hi Stephen, thanks for your comments. The original goal of this patch is to close the 'eal-intr-thread' to fix segfaults caught by Asan. But it breaks the debug_autotest unit test. So the flag is added to fix the unit test. Hi @David Marchand, what's your suggestions? BR Zhichao > -Origi

Re: [PATCH v2 00/36] net/ionic: updates for 22.11 release

2022-10-18 Thread Ferruh Yigit
On 10/18/2022 8:40 PM, Andrew Boyer wrote: This patch series provides features and performance improvements relevant for the upstream release of DPDK 22.11. There are some bits (like struct ionic_dev_intf) only useful for drivers and device types which have not yet been upstreamed. All of the ch

[PATCH v2 36/36] net/ionic: add watchdogs to protect each queue type

2022-10-18 Thread Andrew Boyer
Ring the doorbell again for the following scenarios: * No receives posted but Rx queue not empty after deadline * No transmits posted but Tx work still pending after deadline * Admin queue work still pending after deadline This will help the queues recover in the extremely rare case that a door

[PATCH v2 35/36] net/ionic: retry init commands up to five times

2022-10-18 Thread Andrew Boyer
In some configurations, the FW may return EAGAIN if it is not able to respond to commands immediately. Retry the init commands in this case to prevent errors from reaching the client. Fix up some return-code stuff while here, for clarity. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_

[PATCH v2 34/36] net/ionic: use a helper variable for page size

2022-10-18 Thread Andrew Boyer
This improves readability. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index 383fff9ffd..1b5932db12 100644 --- a/driver

[PATCH v2 33/36] net/ionic: add optimized handlers for non-scattered Rx/Tx

2022-10-18 Thread Andrew Boyer
The code is very similar, but the simple case can skip a few branches in the hot path. This improves PPS when 10KB mbufs are used. S/G is enabled on the Rx side by offload DEV_RX_OFFLOAD_SCATTER. S/G is enabled on the Tx side by offload DEV_TX_OFFLOAD_MULTI_SEGS. S/G is automatically enabled on t

[PATCH v2 32/36] net/ionic: allow client to specify Tx free threshold

2022-10-18 Thread Andrew Boyer
Some clients have opinions about how often to flush the transmit ring. The default value is the number of Tx descriptors minus the default Tx burst size. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.h| 1 + drivers/net/ionic/ionic_ethdev.c | 4 ++-- drivers/net/ionic/ionic_

[PATCH v2 31/36] net/ionic: add alignment and socket info in allocations

2022-10-18 Thread Andrew Boyer
This will avoid memory access penalties on NUMA systems. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c| 5 +++-- drivers/net/ionic/ionic_lif.c | 13 - drivers/net/ionic/ionic_rx_filter.c | 3 +-- 3 files changed, 12 insertions(+), 9 deletions(-) diff -

[PATCH v2 30/36] net/ionic: update array allocations to use calloc

2022-10-18 Thread Andrew Boyer
Use rte_calloc() where appropriate. This makes the code clearer. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 6 +++--- drivers/net/ionic/ionic_lif.c| 12 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/ionic/ionic_ethdev.c b/dri

[PATCH v2 29/36] net/ionic: add Q-in-CMB option controlled by devarg

2022-10-18 Thread Andrew Boyer
When 'ionic_cmb' is set to '1', queue memory will be allocated from the device's onboard memory (Controller Memory Buffer). In some configurations, this will dramatically reduce packet latency and increase PPS. Add the WC_ACTIVATE flag to the PCI driver flags. Write combining must be enabled to ac

[PATCH v2 28/36] net/ionic: add Tx descriptor status function

2022-10-18 Thread Andrew Boyer
This may be useful for clients. Signed-off-by: Andrew Boyer Signed-off-by: Allen Hubbe --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic_ethdev.c | 1 + drivers/net/ionic/ionic_rxtx.c | 51 ++ drivers/net/ionic/ionic_rxtx.h | 1 + 4 f

[PATCH v2 27/36] net/ionic: add Rx descriptor status functions

2022-10-18 Thread Andrew Boyer
These may be useful for clients. Signed-off-by: Andrew Boyer Signed-off-by: Allen Hubbe --- doc/guides/nics/features/ionic.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/ionic/ionic_ethdev.c | 2 ++ drivers/net/ionic/ionic_rxtx.c | 39 +

[PATCH v2 26/36] net/ionic: advertise supported packet types

2022-10-18 Thread Andrew Boyer
This improves performance, since clients may be able to skip SW packet classification. Signed-off-by: Andrew Boyer --- doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/ionic/ionic_ethdev.c | 1 + drivers/net/ionic/ionic_rxtx.c | 19 +++ drivers/net/ionic/

[PATCH v2 25/36] net/ionic: add a lookup table for checksum flags

2022-10-18 Thread Andrew Boyer
This improves performance by reducing branching. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 47 -- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 8a544c03d

[PATCH v2 24/36] net/ionic: add a lookup table for packet type

2022-10-18 Thread Andrew Boyer
This improves performance by reducing branching. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 63 -- 1 file changed, 29 insertions(+), 34 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index cb5ae7671

[PATCH v2 23/36] net/ionic: do bulk allocations of receive mbufs

2022-10-18 Thread Andrew Boyer
Do bulk allocations to improve performance. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.h | 6 ++ drivers/net/ionic/ionic_rxtx.c | 35 ++ 2 files changed, 33 insertions(+), 8 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.h b/drivers/

[PATCH v2 22/36] net/ionic: add support for mbuf fast free

2022-10-18 Thread Andrew Boyer
Use a put() rather than a free() in the optimized case. Signed-off-by: Andrew Boyer --- doc/guides/nics/features/ionic.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/ionic/ionic_ethdev.c | 2 +- drivers/net/ionic/ionic_lif.h | 1 + drivers/net/ionic/ionic

[PATCH v2 21/36] net/ionic: overhaul transmit side for performance

2022-10-18 Thread Andrew Boyer
Linearize Tx mbuf chains in the info array. This avoids walking the mbuf chain during flush. Move a few branches out of the hot path. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 2 +- drivers/net/ionic/ionic_rxtx.c | 143 - 2 files changed,

[PATCH v2 20/36] net/ionic: overhaul receive side for performance

2022-10-18 Thread Andrew Boyer
Linearize RX mbuf chains in the expanded info array. Clean one and fill one per CQE (completions are not coalesced). Touch the mbufs as little as possible in the fill stage. When touching the mbuf in the clean stage, use the rearm_data unions. Ring the doorbell once at the end of the bulk clean/fil

[PATCH v2] net/bonding: make bonded device configure method re-entrant

2022-10-18 Thread Ivan Malov
According to the documentation, rte_eth_dev_configure() can be invoked repeatedly while in stopped state. The current implementation in the bonding driver allows for that (technically), but the user sees warnings which say that back-end devices have already been harnessed. Re-factor the code to hav

[PATCH v2 19/36] net/ionic: do one-time init of receive descriptors

2022-10-18 Thread Andrew Boyer
These fields don't need to be set in the hot path. This improves performance. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/

[PATCH v2 18/36] net/ionic: use a helper variable in packet Tx function

2022-10-18 Thread Andrew Boyer
This improves readability. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 27678ccb6e..93a29a0326 100644 --- a/drivers/net/ionic/io

[PATCH v2 17/36] net/ionic: precalculate segment lengths on receive side

2022-10-18 Thread Andrew Boyer
The first (header) segment includes the standard headroom. Subsequent segments do not. Store the fragment counts in the queue structure. Precalculating improves performance by reducing how much work must be done in the hot path. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.h |

[PATCH v2 16/36] net/ionic: free all buffers during Rx queue stop

2022-10-18 Thread Andrew Boyer
Free all of the mbufs in the receive queue when the queue is stopped. This will allow them to be resized when the MTU is changed. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.c | 16 + drivers/net/ionic/ionic_dev.h | 2 + drivers/net/ionic/ionic_lif.c | 32 - dr

[PATCH v2 15/36] net/ionic: replace void pointer with actual type

2022-10-18 Thread Andrew Boyer
This makes the code safer by helping the compiler catch errors. Rename the variables, too; they're not callbacks anymore. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/net/

[PATCH v2 14/36] net/ionic: only request notifyq interrupt if supported

2022-10-18 Thread Andrew Boyer
Enable the interrupt if the platform & device support it. This prevents spurious interrupts on virtual platforms. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers

[PATCH v2 12/36] net/ionic: only allocate interrupts if required

2022-10-18 Thread Andrew Boyer
There is no need to allocate the interrupt vector list if datapath packet interrupts are not enabled. This conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ionic/ioni

[PATCH v2 13/36] net/ionic: move PCI-specific code to a separate file

2022-10-18 Thread Andrew Boyer
For future support of virtual devices, move the PCI code to its own file. Create a new device interface, struct ionic_dev_intf, to plug in to common code. Signed-off-by: Andrew Boyer Signed-off-by: Neel Patel Signed-off-by: R Mohamed Shah --- drivers/net/ionic/ionic.h | 13 +- drivers

[PATCH v2 11/36] net/ionic: remove unused identifiers

2022-10-18 Thread Andrew Boyer
These bits are not used. Remove them to simplify the code. Fix the spacing on the IONIC_ALIGN #define. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic.h| 1 - drivers/net/ionic/ionic_dev.h| 4 +--- drivers/net/ionic/ionic_ethdev.h | 2 -- 3 files changed, 1 insertion(+), 6 de

[PATCH v2 10/36] net/ionic: simplify code by removing doorbell map helper

2022-10-18 Thread Andrew Boyer
There is only one doorbell page in DPDK configurations, so no helper function is needed. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c i

[PATCH v2 09/36] net/ionic: update MTU calculations

2022-10-18 Thread Andrew Boyer
Test min and max MTU against values read from firmware, for correctness. Update the firmware field name, for clarity. The device must be stopped before changing MTU, for correctness. Store the calculated frame size in the queue, for performance. Signed-off-by: Andrew Boyer Signed-off-by: R Mohame

[PATCH v2 07/36] net/ionic: update supported devices list

2022-10-18 Thread Andrew Boyer
Add listed support for the DSC-200. Signed-off-by: Andrew Boyer --- doc/guides/nics/ionic.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/ionic.rst b/doc/guides/nics/ionic.rst index 82fb0eff9f..f2cdd2b571 100644 --- a/doc/guides/nics/ionic.rst +++ b/doc/guides/nics/ionic.

[PATCH v2 08/36] net/ionic: update license terms to remove GPL

2022-10-18 Thread Andrew Boyer
Remove GPL2 and leave only BSD-3-Clause. This is more in line with the norms of the DPDK community. Signed-off-by: Andrew Boyer --- doc/guides/nics/ionic.rst | 2 +- drivers/net/ionic/ionic.h | 2 +- drivers/net/ionic/ionic_dev.c | 2 +- drivers/net/ionic/ionic_dev.h

[PATCH v2 06/36] net/ionic: update documentation and copyrights

2022-10-18 Thread Andrew Boyer
Pensando Systems has been acquired by AMD. Update all copyright strings and email addresses. Signed-off-by: Andrew Boyer --- MAINTAINERS| 12 ++-- doc/guides/nics/ionic.rst | 15 +++ doc/guides/rel_notes/release_22_11.rst | 6 ++

[PATCH v2 05/36] net/ionic: fix up reported error stats

2022-10-18 Thread Andrew Boyer
Report descriptor errors in ierrors instead of imissed. Don't report rx_queue_empty or rx_queue_disabled in imissed, since those packet errors are already included in the rx_*_drop_packets counters. This makes the reported stats correct. Fixes: 3cdfd90579e7 ("net/ionic: add stats") Cc: cardigli...

[PATCH v2 04/36] net/ionic: fix up the Rx filter save API

2022-10-18 Thread Andrew Boyer
Check the match variable after copying cmd info, or else there can be unexpected results. Fixes: a27e0e96ab77 ("net/ionic: observe endianness in Rx filter") Cc: andrew.bo...@amd.com Cc: sta...@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rx_filter.c | 2 +- 1 file changed, 1

[PATCH v2 03/36] net/ionic: fix to set the adapter name for logging

2022-10-18 Thread Andrew Boyer
Otherwise the log messages will be garbled. Fixes: 4ae96cb88fa0 ("net/ionic: do minor logging fixups") Cc: sta...@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ionic/ionic_dev.c b/driver

[PATCH v2 02/36] net/ionic: fix up endianness for RSS

2022-10-18 Thread Andrew Boyer
This field needs to be LE when talking to the FW. Fixes: 22e7171bc63b ("net/ionic: support RSS") Cc: cardigli...@ntop.org Cc: sta...@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ionic/ioni

[PATCH v2 01/36] net/ionic: fix up endianness for Rx and Tx handling

2022-10-18 Thread Andrew Boyer
These fields all need to be LE when talking to the FW. Fixes: a27d901331da ("net/ionic: add Rx and Tx handling") Cc: cardigli...@ntop.org Cc: sta...@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 27 +++ 1 file changed, 15 insertions(+), 12 del

[PATCH v2 00/36] net/ionic: updates for 22.11 release

2022-10-18 Thread Andrew Boyer
This patch series provides features and performance improvements relevant for the upstream release of DPDK 22.11. There are some bits (like struct ionic_dev_intf) only useful for drivers and device types which have not yet been upstreamed. All of the changes are confined to the ionic PMD. Signed-

Re: [PATCH v1 00/35] net/ionic: updates for 22.11 release

2022-10-18 Thread Ferruh Yigit
On 10/11/2022 1:49 AM, Andrew Boyer wrote: This patch series provides features and performance improvements relevant for the upstream release of DPDK 22.11. There are some bits (like struct ionic_dev_intf) only useful for drivers and device types which have not yet been upstreamed. All of the ch

Re: [PATCH 06/35] net/ionic: update documentation and copyrights

2022-10-18 Thread Ferruh Yigit
On 10/7/2022 6:43 PM, Andrew Boyer wrote: Pensando Systems has been acquired by AMD. Update all copyright strings and email addresses. Signed-off-by: Andrew Boyer --- MAINTAINERS| 4 ++-- doc/guides/nics/ionic.rst | 16 doc/guides/r

Re: [PATCH 07/35] net/ionic: update license terms to remove GPL

2022-10-18 Thread Ferruh Yigit
On 10/7/2022 6:43 PM, Andrew Boyer wrote: Remove GPL2 and leave only BSD-3-Clause. This is more in line with the norms of the DPDK community. Signed-off-by: Andrew Boyer ack. Thanks for the cleanup.

[PATCH v4 30/30] baseband/acc100: update guide docs

2022-10-18 Thread Hernan Vargas
Add new flags ACC100_EXT_MEM and RTE_LIBRTE_BBDEV_SKIP_VALIDATE to the documentation. Signed-off-by: Hernan Vargas --- doc/guides/bbdevs/acc100.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/bbdevs/acc100.rst b/doc/guides/bbdevs/acc100.rst index 8b29b92a9d..b0ac2526d

[PATCH v4 29/30] baseband/acc100: configure PMON control registers

2022-10-18 Thread Hernan Vargas
Enable performance monitor control registers. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc100_pmd.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/baseband/acc/acc100_pmd.h b/drivers/baseband/acc/acc100_pmd.h index eb6349c85a..8c0aec5e

[PATCH v4 27/30] baseband/acc100: add ring companion address

2022-10-18 Thread Hernan Vargas
Store the virtual address of companion ring as part of queue information. Use this address to calculate the op address. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 179 +- 1 file changed, 116 insertions(+), 63 deletions(-) diff --git a/driver

[PATCH v4 28/30] baseband/acc100: add workaround for deRM corner cases

2022-10-18 Thread Hernan Vargas
Add function to support de-ratematch pre-processing for SW corner cases. Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases potential stability issue on the ACC100. To be able to avoid completly such potential issue, the PMD can preempt such code block configur

[PATCH v4 26/30] baseband/acc100: update device info

2022-10-18 Thread Hernan Vargas
Remove unused capabilities, use dummy operation as start count for number of queues. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c

[PATCH v4 25/30] baseband/acc100: store FCW from first CB descriptor

2022-10-18 Thread Hernan Vargas
Store the descriptor from the first code block from a transport block. Copy the LDPC FCW from the first descriptor into the rest of the CBs in that TB. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 3 +++ 1 file changed, 3 insertions(+) d

[PATCH v4 24/30] baseband/acc100: update log messages

2022-10-18 Thread Hernan Vargas
Add extra values for some log messages. No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseban

[PATCH v4 23/30] baseband/acc100: update uplink CB input length

2022-10-18 Thread Hernan Vargas
Use the FCW E parameter for rate matching as the code block input length. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/base

[PATCH v4 22/30] baseband/acc100: add queue stop operation

2022-10-18 Thread Hernan Vargas
Implement new feature to stop queue operation. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_a

[PATCH v4 21/30] baseband/acc100: implement configurable queue depth

2022-10-18 Thread Hernan Vargas
Implement new feature to make queue depth configurable based on decode or encode mode. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/rte_ac

[PATCH v4 20/30] baseband/acc100: update validate LDPC enc/dec

2022-10-18 Thread Hernan Vargas
Update validate functions to check for valid LDPC parameters to avoid any HW issues. Adding protection for null corner case and for HARQ inbound size out of range. HARQ input size from application may be invalid and causing HW issue. Add checks to ensure that if HARQ is invalid, set to some valid s

[PATCH v4 19/30] baseband/acc100: added LDPC transport block support

2022-10-18 Thread Hernan Vargas
Added LDPC enqueue functions to handle transport blocks. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 164 +- 1 file changed, 163 insertions(+), 1 deletion(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/

[PATCH v4 18/30] baseband/acc100: enable input validation by default

2022-10-18 Thread Hernan Vargas
Enable validation functions by default and provide a new flag RTE_LIBRTE_SKIP_VALIDATE if the user wants to run without validating input to save cycles. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 36 +-- 1 file c

[PATCH v4 17/30] baseband/acc100: add HARQ index helper function

2022-10-18 Thread Hernan Vargas
Refactor code to use the HARQ index helper function and make harq_idx uint32. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 36 +-- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/drivers/baseband/ac

[PATCH v4 16/30] baseband/acc100: add scatter-gather support

2022-10-18 Thread Hernan Vargas
Add flag to support scatter-gather for the mbuf Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 38 ++- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/

[PATCH v4 15/30] baseband/acc100: add enqueue status

2022-10-18 Thread Hernan Vargas
Add enqueue status as part of rte_bbdev_queue_data. This is a new feature to update queue status and indicate the reason why a previous enqueue may or may not have consumed all requested operations. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pm

[PATCH v4 14/30] baseband/acc100: fix debug print for LDPC FCW

2022-10-18 Thread Hernan Vargas
Print full size of FCW LDPC structure on debug messages. This is just a cosmetic fix, no need to fix on previous code base. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH v4 13/30] baseband/acc100: reset pointer after rte_free

2022-10-18 Thread Hernan Vargas
Set local pointer to NULL after rte_free. This needs to be set explicitly since logic may check for null pointers. Fixes: 060e7672930 ("baseband/acc100: add queue configuration") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_p

[PATCH v4 12/30] baseband/acc100: add protection for NULL HARQ input

2022-10-18 Thread Hernan Vargas
It is possible to cause an invalid HW operation in case the user provides the BBDEV API and HARQ operation with input enabled and zero input. Adding protection for that case. Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Re

[PATCH v4 11/30] baseband/acc100: set device min alignment to 1

2022-10-18 Thread Hernan Vargas
Historical mistakes, there should be no 64B alignment requirement for the buffer being processed. Any 1B alignment is sufficient. Fixes: 9200ffa5cd5 ("baseband/acc100: add info get function") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc

[PATCH v4 10/30] baseband/acc100: fix clearing PF IR outside handler

2022-10-18 Thread Hernan Vargas
Clearing of PF info ring outside of handler may cause interrupt to be missed. A condition in the ACC100 PMD implementation may cause an interrupt functional handler call to be missed due to related bit being cleared when checking PF info ring status. Fixes: 06531464151 ("baseband/acc100: support i

[PATCH v4 09/30] baseband/acc100: reduce input length for CRC24B

2022-10-18 Thread Hernan Vargas
Input length should be reduced only for CRC24B. Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH v4 08/30] baseband/acc100: allocate ring/queue mem when NULL

2022-10-18 Thread Hernan Vargas
Allocate info ring, tail pointers and HARQ layout memory for a device only if it hasn't already been allocated. Fixes: 06531464151 ("baseband/acc100: support interrupt") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 30 ++-

[PATCH v4 07/30] baseband/acc100: enforce additional check on FCW

2022-10-18 Thread Hernan Vargas
Enforce additional check on Frame Control Word validity and add stronger alignment for decompression mode. Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/acc100_pmd.h | 1 + drivers/baseband/ac

[PATCH v4 06/30] baseband/acc100: check for unlikely operation vals

2022-10-18 Thread Hernan Vargas
Add unlikely checks for NULL operation values. Fixes: f404dfe35cc ("baseband/acc100: support 4G processing") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/d

[PATCH v4 05/30] baseband/acc100: check turbo dec/enc input

2022-10-18 Thread Hernan Vargas
Add NULL check for the turbo decoder and encoder input length. Fixes: 3bfc5f60403 ("baseband/acc100: add debug function to validate input") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 23 ++- 1 fi

[PATCH v4 04/30] baseband/acc100: add LDPC encoder padding function

2022-10-18 Thread Hernan Vargas
LDPC Encoder input may need to be padded to avoid small beat for ACC100. Padding 5GDL input buffer length (BLEN) to avoid case (BLEN % 64) <= 8. Adding protection for corner case to avoid for 5GDL occurrence of last beat within the ACC100 fabric with <= 8B which might trigger a fabric corner case h

[PATCH v4 03/30] baseband/acc100: memory leak fix

2022-10-18 Thread Hernan Vargas
Move check for undefined device before allocating queue data structure. Coverity issue: 375803, 375813, 375819, 375827, 375831 Fixes: 060e7672930 ("baseband/acc100: add queue configuration") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/

[PATCH v4 01/30] baseband/acc100: fix ring availability calculation

2022-10-18 Thread Hernan Vargas
Refactor of the queue availability computation to prevent the application to dequeue more than what may have been enqueued. Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 25 +

[PATCH v4 02/30] baseband/acc100: add function to check AQ availability

2022-10-18 Thread Hernan Vargas
It is possible for some corner case to run more batch enqueue than supported. A protection is required to avoid that corner case. Enhance all ACC100 enqueue operations with check to see if there is room in the atomic queue for enqueueing batches into the queue manager Check room in AQ for the enque

[PATCH v4 00/30] baseband/acc100: changes for 22.11

2022-10-18 Thread Hernan Vargas
v4: Rebased code to use the latest ACC common API and implemented review comment changes. v3: Code refactor based on comments and grouping fixes at beginning of series. v2: Rebased code to use ACC common API. v1: Upstreaming ACC100 changes for 22.11. This patch series is dependant on series: https

Re: [PATCH v6 3/4] mempool: fix cache flushing algorithm

2022-10-18 Thread Jerin Jacob
On Sat, Oct 15, 2022 at 12:27 PM Morten Brørup wrote: > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Friday, 14 October 2022 21.51 > > > > On Fri, Oct 14, 2022 at 05:57:39PM +0200, Morten Brørup wrote: > > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > > Sent: Fr

Re: [PATCH v3 18/30] baseband/acc100: enable input validation by default

2022-10-18 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Enable validation functions by default and provide a new flag RTE_LIBRTE_SKIP_VALIDATE if the user wants to run without validating input to save cycles. I would prefer a devarg, so that it can be enabled/disabled at runtime, instead of build time. The

Re: [PATCH] trace: take live traces via telemetry

2022-10-18 Thread Bruce Richardson
On Tue, Oct 18, 2022 at 04:33:49PM +0200, Morten Brørup wrote: > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Thursday, 13 October 2022 09.49 > > > > Register telemetry commands to list and configure trace points and > > later > > save traces for a running DPDK application.

Minutes of Technical Board Meeting, 2022-Oct-5

2022-10-18 Thread Konstantin Ananyev
Members Attending -- -Aaron -Bruce -Konstantin (chair) -Kevin -Maxime -Stephen -Thomas NOTE: The technical board meetings are on every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK community members are welcome to attend. NOTE: Nex

Re: [PATCH] examples/ipsec-secgw: fix Tx checksum offload flag

2022-10-18 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 30/09/2022 13:40, Radu Nicolau wrote: Fix a typo in computing port mask for Tx checksum offload capability. Fixes: 4edcee19fc20 ("examples/ipsec-secgw: use Tx checksum offload conditionally") Cc: ndabilpu...@marvell.com Signed-off-by: Radu Nicolau --- examp

[Bug 1106] ipsec-secgw inline test fail

2022-10-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1106 Vladimir (vladimir.medved...@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolu

[PATCH v6 2/2] examples/vhost: unconfigure DMA vchannel

2022-10-18 Thread xuan . ding
From: Xuan Ding This patch applies rte_vhost_async_dma_unconfigure() to manually free DMA vchannels. Before unconfiguration, make sure the specified DMA device is no longer used by any vhost ports. Signed-off-by: Xuan Ding --- examples/vhost/main.c | 8 1 file changed, 8 insertions(+)

[PATCH v6 1/2] vhost: introduce DMA vchannel unconfiguration

2022-10-18 Thread xuan . ding
From: Xuan Ding Add a new API rte_vhost_async_dma_unconfigure() to unconfigure DMA vchannels in vhost async data path. Lock protection are also added to protect DMA vchannels configuration and unconfiguration from concurrent calls. Signed-off-by: Xuan Ding --- doc/guides/prog_guide/vhost_lib.r

[PATCH v6 0/2] vhost: introduce DMA vchannel unconfiguration

2022-10-18 Thread xuan . ding
From: Xuan Ding This patchset introduces a new API rte_vhost_async_dma_unconfigure() to help user to manually free DMA vchannels finished to use. v6: * Move DMA unconfiguration to the end due to DMA devices maybe reused after destroy_device(). * Refine the doc to claim the DMA device should no

[PATCH v3 2/2] crypto/qat: read hw slice configuration

2022-10-18 Thread Arek Kusztal
Read slice configuration of QAT capabilities. This will allow to recognize if specific hw function is available on particular device. Signed-off-by: Arek Kusztal --- v2: - added generation specific functions v3: - split into two patches - fixed checkpatch issues drivers/crypto/qat/dev/qat_asym_

[PATCH v3 1/2] common/qat: read hw slice configuration

2022-10-18 Thread Arek Kusztal
Read slice configuration of QAT capabilities. This will allow to recognize if specific hw function is available on particular device. Signed-off-by: Arek Kusztal --- v2: - added generation specific functions v3: - split into two patches - fixed checkpatch issues drivers/common/qat/dev/qat_dev_g

[PATCH v2 3/3] crypto/qat: fix not set rsa lengths

2022-10-18 Thread Arek Kusztal
Fixed not set output length in asym pmd when doing RSA. Fixes: 002486db239e ("crypto/qat: refactor asymmetric session") Signed-off-by: Arek Kusztal --- v2: - fixed compilation issues - split into 3 patches drivers/crypto/qat/qat_asym.c | 24 ++-- 1 file changed, 10 insertio

[PATCH v2 2/3] crypto/qat: fix unnecessary session check

2022-10-18 Thread Arek Kusztal
Removed unncessary session check which could lead to segfault, in case api was changed. Fixes: 002486db239e ("crypto/qat: refactor asymmetric session") Signed-off-by: Arek Kusztal --- v2: - fixed compilation issues - split into 3 patches drivers/crypto/qat/qat_asym.c | 12 ++-- 1 file

[PATCH v2 1/3] crypto/qat: fix uncleared cookies in asym

2022-10-18 Thread Arek Kusztal
Fixed incorrectly placed clean function in asym response. Fixes: 002486db239e ("crypto/qat: refactor asymmetric session") Signed-off-by: Arek Kusztal --- v2: - fixed compilation issues - split into 3 patches drivers/crypto/qat/qat_asym.c | 33 + 1 file changed,

RE: [PATCH] trace: take live traces via telemetry

2022-10-18 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, 13 October 2022 09.49 > > Register telemetry commands to list and configure trace points and > later > save traces for a running DPDK application. > > Note: trace point names contain a '.', so the list of valid characters

Re: [PATCH v5] net/bonding: call Tx prepare before Tx burst

2022-10-18 Thread fengchengwen
Hi Thomas, Ferruh and Andrew   This patch already reviewed by Humin and Chas, Could it accepted in 22.11 ? Thanks On 2022/10/15 23:26, Chas Williams wrote: This looks fine. Thanks for making the changes! Signed-off-by: Chas Williams <3ch...@gmail.com> On 10/11/22 09:20, Chengwen Feng wrote

  1   2   3   >