Re: [PATCH 13/13] net/cnxk: remove duplicate mempool debug checks

2022-10-11 Thread Jerin Jacob
On Tue, Oct 11, 2022 at 5:33 PM Nithin Dabilpuram wrote: > > Remove duplicate mempool debug checks for mbufs received. > Fixes: 592642c494b1 ("net/cnxk: align prefetches to CN10K cache model") > > Signed-off-by: Nithin Dabilpuram # Please fix the following # Also, update git comments and add fix

[PATCH] net/mlx5: fix thread termination check on Windows

2022-10-11 Thread Tal Shnaiderman
The mlx5_is_thread_alive function always returns false (terminated) regardless to the actual thread state. Fixed to return the correct thread state. Bugzilla ID: 1089 Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman

Re: [PATCH v2 3/3] net/cnxk: support congestion management ops

2022-10-11 Thread Jerin Jacob
On Tue, Oct 11, 2022 at 11:59 AM Sunil Kumar Kori wrote: > > Please look into these changes and provide feedback. > > Regards > Sunil Kumar Kori > > > -Original Message- > > From: sk...@marvell.com > > Sent: Thursday, September 29, 2022 3:25 PM > > To: Nithin Kumar Dabilpuram ; Kiran Kuma

[PATCH] app/testpmd: remove useless check

2022-10-11 Thread Yuan Wang
Protocol header sequence checking is supported in the ethdev library, the application does not need to do it again. Coverity issue: 381396 Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split") Signed-off-by: Yuan Wang --- app/test-pmd/cmdline.c| 6 ++ app/test-pmd/paramet

[PATCH v2] vhost: add new `rte_vhost_vring_call_nonblock` API

2022-10-11 Thread Changpeng Liu
Vhost-user library locks all VQ's access lock when processing vring based messages, such as SET_VRING_KICK and SET_VRING_CALL, and the data processing thread may already be started, e.g: SPDK vhost-blk and vhost-scsi will start the data processing thread when one vring is ready, then deadlock may h

[Bug 1102] i40e: enabling Rx/Tx queue deferred start has no effect

2022-10-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1102 Bug ID: 1102 Summary: i40e: enabling Rx/Tx queue deferred start has no effect Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRM

RE: [v3] crypto/cnxk: support exponent type private key

2022-10-11 Thread Anoob Joseph
> > This patch adds support for RTE_RSA_KEY_TYPE_EXP in cnxk crypto driver. > > Signed-off-by: Gowrishankar Muthukrishnan > -- > v3: > - .ini updates. > v2: > - new function to handle exp type priv key. > --- > doc/guides/cryptodevs/features/cn10k.ini | 2 + > doc/guides/cryptodevs/features

RE: [PATCH v3 1/8] vdpa/ifc: add new device ID for legacy network device

2022-10-11 Thread Pei, Andy
Hi Chenbo, Thanks for your effort. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 11:00 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 1/8] vdpa/ifc: add new device ID for le

RE: [PATCH v3 1/8] vdpa/ifc: add new device ID for legacy network device

2022-10-11 Thread Pei, Andy
Hi Maxime, Thanks for your effort. > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, October 12, 2022 12:49 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang > Subject: Re: [PATCH v3 1/8] vdpa/ifc: add new device ID for legacy netwo

[Bug 1100] [dpdk-22.11.0rc1][meson test] driver-tests/eventdev_selftest_sw test failed

2022-10-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1100 jiang,yu (yux.ji...@intel.com) changed: What|Removed |Added Resolution|--- |DUPLICATE CC|

[Bug 1099] [dpdk-22.11.0rc1][meson test] driver-tests/eventdev_selftest_sw test failed

2022-10-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1099 jiang,yu (yux.ji...@intel.com) changed: What|Removed |Added CC||yux.ji...@intel.com

[v7 3/3] examples/fips_validation: randomize message for conformance test

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion(-)

[v7 2/3] examples/fips_validation: encode digest with hash OID

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash ddigest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples/f

[v7 1/3] examples/fips_validation: add asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v7: - fix test to return error if not relevant

[v7 0/3] FIPS asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
This patch series adds support in fips_validation app to perform asymmetric validation. To start with, RSA algorithm is used in the evaluation. For the key value pairs which is multiprecision in arithmetic, openssl library is used. Changes: v7: - fix test to handle app parameter correctly. v6:

RE: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec

2022-10-11 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:16 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec > > Set max_queues according

[PATCH 2/2] crypto/cnxk: fix failure from session rework

2022-10-11 Thread Anoob Joseph
Post security session rework, CPTR got changed affecting cn9k IPsec functionality. Address the same. Also, move all s/w accessible fastpath fields to rte_security_session cacheline for better perf. Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") Signed-off-by: Anoob Joseph --- dr

[PATCH 1/2] crypto/cnxk: align HW accessible field to ROC align

2022-10-11 Thread Anoob Joseph
Hardware accessible memory need to be aligned to ROC. Enforce the same. Move software specific fields to padding space. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 33 -- drivers/crypto/cnxk/cn10k_ipsec.c | 77 +++ drivers/crypt

rte_lcore_count() semantics

2022-10-11 Thread Mattias Rönnblom
Hi. According to the API documentation, rte_lcore_count() sets out to "Return the number of execution units (lcores) on the system" The EAL documentation states that "the term 'lcore' refers to an EAL thread", and also refers to regular pthreads having called rte_thread_register() as "regist

DPDK22.11RC1 meson test eventdev_selftest_sw failed//RE: [PATCH v4] mempool: fix get objects from mempool with cache

2022-10-11 Thread Li, WeiyuanX
Hi Andrew Rybchenko, This patch is merged into dpdk22.11.0-rc1 we execute meson test driver/eventdev_selftest_sw failed. Could you please have a look at it, also submitted a Bugzilla ticket: https://bugs.dpdk.org/show_bug.cgi?id=1101 Regards, Li, Weiyuan > -Original Message- > From: A

[Bug 1101] [dpdk-22.11.0rc1][meson test] driver-tests/eventdev_selftest_sw test failed

2022-10-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1101 Bug ID: 1101 Summary: [dpdk-22.11.0rc1][meson test] driver-tests/eventdev_selftest_sw test failed Product: DPDK Version: 22.11 Hardware: All OS: All Sta

[Bug 1100] [dpdk-22.11.0rc1][meson test] driver-tests/eventdev_selftest_sw test failed

2022-10-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1100 Bug ID: 1100 Summary: [dpdk-22.11.0rc1][meson test] driver-tests/eventdev_selftest_sw test failed Product: DPDK Version: 22.11 Hardware: All OS: All Sta

[Bug 1099] [dpdk-22.11.0rc1][meson test] driver-tests/eventdev_selftest_sw test failed

2022-10-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1099 Bug ID: 1099 Summary: [dpdk-22.11.0rc1][meson test] driver-tests/eventdev_selftest_sw test failed Product: DPDK Version: 22.11 Hardware: All OS: All Sta

[v3] crypto/cnxk: support exponent type private key

2022-10-11 Thread Gowrishankar Muthukrishnan
This patch adds support for RTE_RSA_KEY_TYPE_EXP in cnxk crypto driver. Signed-off-by: Gowrishankar Muthukrishnan -- v3: - .ini updates. v2: - new function to handle exp type priv key. --- doc/guides/cryptodevs/features/cn10k.ini | 2 + doc/guides/cryptodevs/features/cn9k.ini | 2 + drive

Re: [PATCH v8 1/9] memarea: introduce memarea library

2022-10-11 Thread fengchengwen
Hi Dmitry, On 2022/10/11 23:58, Dmitry Kozlyuk wrote: > 2022-10-11 12:17 (UTC+), Chengwen Feng: > [...] >> diff --git a/doc/guides/prog_guide/memarea_lib.rst >> b/doc/guides/prog_guide/memarea_lib.rst >> new file mode 100644 >> index 00..85ad57145f >> --- /dev/null >> +++ b/doc/guides

[v6 2/3] examples/fips_validation: encode digest with hash OID

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash ddigest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples/f

[v6 3/3] examples/fips_validation: randomize message for conformance test

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion(-)

[v6 1/3] examples/fips_validation: add asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v6: - checpatch related fix. v5: - release no

[v6 0/3] FIPS asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
This patch series adds support in fips_validation app to perform asymmetric validation. To start with, RSA algorithm is used in the evaluation. For the key value pairs which is multiprecision in arithmetic, openssl library is used. Changes: v6: - checkpatch related fix. v5: - Release notes.

[v5 3/3] examples/fips_validation: randomize message for conformance test

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion(-)

[v5 2/3] examples/fips_validation: encode digest with hash OID

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash ddigest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples/f

[v5 1/3] examples/fips_validation: add asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v5: - release notes. v4: - AES GMAC callback

[v5 0/3] FIPS asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
This patch series adds support in fips_validation app to perform asymmetric validation. To start with, RSA algorithm is used in the evaluation. For the key value pairs which is multiprecision in arithmetic, openssl library is used. Changes: v5: - Release notes. v4: - AES GMAC callback fixes.

[PATCH v12 2/5] ethdev: support proactive error handling mode

2022-10-11 Thread Chengwen Feng
From: Kalesh AP Some PMDs (e.g. hns3) could detect hardware or firmware errors, one error recovery mode is to report RTE_ETH_EVENT_INTR_RESET event, and wait for application invoke rte_eth_dev_reset() to recover the port, however, this mode has the following weaknesses: 1) Due to different hardw

[PATCH v12 1/5] ethdev: add error handling mode to device info

2022-10-11 Thread Chengwen Feng
This patch adds error handling mode to device info, currently, the defined error handling modes include: 1) NONE: it means no error handling modes are supported by this port. 2) PASSIVE: passive error handling, after the PMD detect that a reset is required, the PMD reports RTE_ETH_EVENT_INTR_RESE

[PATCH v12 3/5] app/testpmd: support error handling mode event

2022-10-11 Thread Chengwen Feng
From: Kalesh AP This patch supports error handling mode event process. Signed-off-by: Kalesh AP Signed-off-by: Somnath Kotur Signed-off-by: Chengwen Feng Reviewed-by: Ajit Khaparde --- app/test-pmd/parameters.c | 10 -- app/test-pmd/testpmd.c| 8 +++- 2 files changed, 15 in

[PATCH v12 0/5] support error handling mode

2022-10-11 Thread Chengwen Feng
This patchset introduce error handling mode concept, the supported modes are as follows: 1) PASSIVE: passive error handling, after the PMD detect that a reset is required, the PMD reports RTE_ETH_EVENT_INTR_RESET event, and application invoke rte_eth_dev_reset to recover the port. 2) PROACTIVE: p

[PATCH v12 4/5] net/hns3: support proactive error handling mode

2022-10-11 Thread Chengwen Feng
This patch supports proactive error handling mode. Signed-off-by: Chengwen Feng Acked-by: Dongdong Liu --- drivers/net/hns3/hns3_common.c | 2 ++ drivers/net/hns3/hns3_intr.c | 24 2 files changed, 26 insertions(+) diff --git a/drivers/net/hns3/hns3_common.c b/drive

[PATCH v12 5/5] net/bnxt: support proactive error handling mode

2022-10-11 Thread Chengwen Feng
From: Kalesh AP This patch supports proactive error handling mode. Signed-off-by: Kalesh AP Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde Reviewed-by: Chengwen Feng --- drivers/net/bnxt/bnxt_cpr.c| 4 drivers/net/bnxt/bnxt_ethdev.c | 13 - 2 files changed, 16

[PATCH] net/iavf: fix default state for Rx timestamp enabling

2022-10-11 Thread Simei Su
When starting testpmd without "--enable-rx-timestamp", found the issue that Rx timestamp on Flex descriptor is still enabled. This patch adds per queue offload check to disable Rx timestamp support in default state. Fixes: b5cd735132f6 ("net/iavf: enable Rx timestamp on flex descriptor") Cc: sta.

RE: [PATCH v3 2/8] vdpa/ifc: add multi-queue support

2022-10-11 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:16 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v3 2/8] vdpa/ifc: add multi-queue support > > Enable VHOST_USER_PROTOCOL_F_MQ feat

RE: [PATCH v3 1/8] vdpa/ifc: add new device ID for legacy network device

2022-10-11 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:16 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v3 1/8] vdpa/ifc: add new device ID for legacy network > device > > From: Huang We

RE: CRC offload from application's POV

2022-10-11 Thread Wu, Wenjun1
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, October 11, 2022 9:46 PM > To: Viacheslav Galaktionov ; Su, > Simei ; Wu, Wenjun1 > Cc: Denis Pryazhennikov ; > dev@dpdk.org > Subject: Re: CRC offload from application's POV > > On 10/11/2022 12:54 PM, Viacheslav Galaktionov w

RE: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame

2022-10-11 Thread Jun Qiu
Yes, It's better to do it before the tcp_dl check. 1. /* trim the tail padding bytes */ 2. ip_tlen = rte_be_to_cpu_16(ipv4_hdr->total_length); 3. if (pkt->pkt_len > (uint32_t)(ip_tlen + pkt->l2_len)) 4. rte_pktmbuf_trim(pkt, pkt->pkt_len - ip_tlen - pkt->l2_len); 5. 6. /*

Re: 回复: [PATCH v2 1/3] ethdev: add API for direct rearm mode

2022-10-11 Thread Konstantin Ananyev
Add API for enabling direct rearm mode and for mapping RX and TX queues. Currently, the API supports 1:1(txq : rxq) mapping. Furthermore, to avoid Rx load Tx data directly, add API called 'rte_eth_txq_data_get' to get Tx sw_ring and its information. Suggested-by: Honnappa Nagarahalli Sugges

Re: [PATCH v3] pci: read amd iommu virtual address width

2022-10-11 Thread Ferruh Yigit
On 10/10/2022 10:47 PM, Michael Piszczek wrote: Add code to read the virtual address width for AMD processors. Signed-off-by: Michael Piszczek --- drivers/bus/pci/linux/pci.c | 47 +++-- 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/drivers/b

[PATCH] doc: fix nic order in index.rst

2022-10-11 Thread Stephen Hemminger
The list was not quite in alpha order, and it looked like it should be. Signed-off-by: Stephen Hemminger --- doc/guides/nics/index.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst index 32c754496827..8df4fef4

RE: Copy-pasted code should be updated

2022-10-11 Thread Honnappa Nagarahalli
> > Dear Intel PMD maintainers (CC: techboard), > > I strongly recommend that you update the code you copy-pasted from the > mempool library to your PMDs, so they reflect the new and improved > mempool cache behavior [1]. When choosing to copy-paste code from a core > library, you should feel o

[PATCH v11 16/16] test-bbdev: unit test capability extension

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added support for bbdev level unit test for the FFT operations and for Soft-Output options. Also added 2 small test vectors for the FFT operation. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c| 540 +++- app/test-bbdev/test_bbdev_

[PATCH v11 15/16] baseband/acc: add helper function for descriptor index

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added set of helper functions used through the code to track descriptor indexes in a queue ring. Signed-off-by: Nic Chautru --- drivers/baseband/acc/acc_common.h | 41 - drivers/baseband/acc/rte_acc100_pmd.c | 124 ++ drivers/baseband/acc/

[PATCH v11 13/16] baseband/acc: add PF configure companion function

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added configure function notably to configure the device from the PF within DPDK and bbdev-test (without external dependency). That function is kept common to all ACC devices. Signed-off-by: Nic Chautru Acked-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c

[PATCH v11 14/16] baseband/acc: simplify meson dependency

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Removed some of libraries from the external dependency captured in meson build file which are not required. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH v11 12/16] baseband/acc: add device status and vf2pf comms

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added support to expose the device status seen from the host through v2pf mailbox communication. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 30 +++ 1 file changed, 30 insertions(+) diff --git a

[PATCH v11 11/16] baseband/acc: support interrupt

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added support for capability and functions for MSI/MSI-X interrupt and underlying information ring. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 302 +- 1 file changed, 299 insertions(+), 3 deleti

[PATCH v11 10/16] baseband/acc: add support for FFT operations

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added functions and capability for FFT processing Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 235 +- 1 file changed, 233 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/rte_acc2

[PATCH v11 09/16] baseband/acc: add LTE processing functions

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added functions and capability for 4G FEC Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 767 +- 1 file changed, 762 insertions(+), 5 deletions(-) diff --git a/drivers/baseband/acc/rte_acc200_pmd.c

[PATCH v11 08/16] baseband/acc: add LDPC processing functions

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added LDPC encode and decode processing functions. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 84 ++ drivers/baseband/acc/rte_acc200_pmd.c | 1320 - 2 files changed, 1399 insertions(+), 5 dele

[PATCH v11 07/16] baseband/acc: add queue configuration for ACC200

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added function to create and configure queues for the device. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 1 + drivers/baseband/acc/rte_acc200_pmd.c | 391 +- 2 files changed, 391 insertions(+)

[PATCH v11 06/16] baseband/acc: add info get function for ACC200

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added support for info_get to allow to query the device. Null capability exposed. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc200_pmd.h | 1 + drivers/baseband/acc/rte_acc200_pmd.c | 231 ++ 2 files change

[PATCH v11 05/16] baseband/acc: add HW register definitions for ACC200

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added registers list and structure to access the device. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc200_pf_enum.h | 108 + drivers/baseband/acc/acc200_pmd.h | 163 ++ drivers/baseband/acc/ac

[PATCH v11 04/16] baseband/acc: introduce PMD for ACC200

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Introduced stubs for device driver for the ACC200 integrated VRAN accelerator on SPR-EEC Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- MAINTAINERS| 3 + doc/guides/bbdevs/acc200.rst | 257 + doc/gu

[PATCH v11 03/16] baseband/acc: rename directory from acc100 to acc

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Used a common directory for the ACC PMDs Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- MAINTAINERS | 2 +- app/test-bbdev/meson.build| 4 ++-- app/test-bbdev/test_bbdev_perf.c

[PATCH v11 01/16] baseband/acc100: remove unused registers

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Cleanep up the enum files to remove un-used registers definitions. No functionality change. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc100/acc100_pf_enum.h | 939 --- 1 file changed, 939 deletions(-) diff --git a/driv

[PATCH v11 00/16] bbdev ACC200 PMD

2022-10-11 Thread Nicolas Chautru
v11: Fixed clang compilation error introduced in v10 16/16. Thanks v10: Update of patch 13 to expose a single configuration API for the ACC devices. New commit 15 to refactor PMD code using helper functions for the descriptor index management and improve readability. New commit 16

RE: [PATCH v9 09/14] baseband/acc: add LTE processing functions

2022-10-11 Thread Chautru, Nicolas
Hi Akhil, Maxime, > -Original Message- > From: Akhil Goyal > Subject: RE: [PATCH v9 09/14] baseband/acc: add LTE processing functions > > > > > +/* Enqueue one encode operations for ACC200 device in TB mode. */ > > > > +static inline int enqueue_enc_one_op_tb(struct acc_queue *q, > > >

RE: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF configure companion function

2022-10-11 Thread Chautru, Nicolas
Hi Akhil, Maxime, > -Original Message- > From: Akhil Goyal > Sent: Monday, October 10, 2022 11:12 AM > To: Chautru, Nicolas ; Maxime Coquelin > ; dev@dpdk.org > Cc: t...@redhat.com; m...@ashroe.eu; Richardson, Bruce > ; hemant.agra...@nxp.com; > david.march...@redhat.com; step...@network

[PATCH v10 16/16] test-bbdev: unit test capability extension

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added support for bbdev level unit test for the FFT operations and for Soft-Output options. Also added 2 small test vectors for the FFT operation. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c| 542 +++- app/test-bbdev/test_bbdev_

[PATCH v10 15/16] baseband/acc: add helper function for descriptor index

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added set of helper functions used through the code to track descriptor indexes in a queue ring. Signed-off-by: Nic Chautru --- drivers/baseband/acc/acc_common.h | 41 - drivers/baseband/acc/rte_acc100_pmd.c | 124 ++ drivers/baseband/acc/

[PATCH v10 11/16] baseband/acc: support interrupt

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added support for capability and functions for MSI/MSI-X interrupt and underlying information ring. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 302 +- 1 file changed, 299 insertions(+), 3 deleti

[PATCH v10 14/16] baseband/acc: simplify meson dependency

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Removed some of libraries from the external dependency captured in meson build file which are not required. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH v10 13/16] baseband/acc: add PF configure companion function

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added configure function notably to configure the device from the PF within DPDK and bbdev-test (without external dependency). That function is kept common to all ACC devices. Signed-off-by: Nic Chautru Acked-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c

[PATCH v10 10/16] baseband/acc: add support for FFT operations

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added functions and capability for FFT processing Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 235 +- 1 file changed, 233 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/rte_acc2

[PATCH v10 09/16] baseband/acc: add LTE processing functions

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added functions and capability for 4G FEC Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 767 +- 1 file changed, 762 insertions(+), 5 deletions(-) diff --git a/drivers/baseband/acc/rte_acc200_pmd.c

[PATCH v10 08/16] baseband/acc: add LDPC processing functions

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added LDPC encode and decode processing functions. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 84 ++ drivers/baseband/acc/rte_acc200_pmd.c | 1320 - 2 files changed, 1399 insertions(+), 5 dele

[PATCH v10 12/16] baseband/acc: add device status and vf2pf comms

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added support to expose the device status seen from the host through v2pf mailbox communication. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 30 +++ 1 file changed, 30 insertions(+) diff --git a

[PATCH v10 07/16] baseband/acc: add queue configuration for ACC200

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added function to create and configure queues for the device. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 1 + drivers/baseband/acc/rte_acc200_pmd.c | 391 +- 2 files changed, 391 insertions(+)

[PATCH v10 06/16] baseband/acc: add info get function for ACC200

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added support for info_get to allow to query the device. Null capability exposed. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc200_pmd.h | 1 + drivers/baseband/acc/rte_acc200_pmd.c | 231 ++ 2 files change

[PATCH v10 04/16] baseband/acc: introduce PMD for ACC200

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Introduced stubs for device driver for the ACC200 integrated VRAN accelerator on SPR-EEC Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- MAINTAINERS| 3 + doc/guides/bbdevs/acc200.rst | 257 + doc/gu

[PATCH v10 05/16] baseband/acc: add HW register definitions for ACC200

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Added registers list and structure to access the device. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc200_pf_enum.h | 108 + drivers/baseband/acc/acc200_pmd.h | 163 ++ drivers/baseband/acc/ac

[PATCH v10 03/16] baseband/acc: rename directory from acc100 to acc

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Used a common directory for the ACC PMDs Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- MAINTAINERS | 2 +- app/test-bbdev/meson.build| 4 ++-- app/test-bbdev/test_bbdev_perf.c

[PATCH v10 01/16] baseband/acc100: remove unused registers

2022-10-11 Thread Nicolas Chautru
From: Nic Chautru Cleanep up the enum files to remove un-used registers definitions. No functionality change. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc100/acc100_pf_enum.h | 939 --- 1 file changed, 939 deletions(-) diff --git a/driv

[PATCH v10 00/16] bbdev ACC200 PMD

2022-10-11 Thread Nicolas Chautru
v10: Update of patch 13 to expose a single configuration API for the ACC devices. New commit 15 to refactor PMD code using helper functions for the descriptor index management and improve readability. New commit 16 to extend bbdev-test capability to support new operations and

Copy-pasted code should be updated

2022-10-11 Thread Morten Brørup
Dear Intel PMD maintainers (CC: techboard), I strongly recommend that you update the code you copy-pasted from the mempool library to your PMDs, so they reflect the new and improved mempool cache behavior [1]. When choosing to copy-paste code from a core library, you should feel obliged to keep

Re: [PATCH v8 7/9] memarea: support backup memory mechanism

2022-10-11 Thread Mattias Rönnblom
On 2022-10-11 17:58, Dmitry Kozlyuk wrote: 2022-10-11 12:17 (UTC+), Chengwen Feng: This patch adds a memarea backup mechanism, where an allocation request which cannot be met by the current memarea is deferred to its backup memarea. This is a controversial feature. 1. It violates memarea

RE: [PATCH v6 0/4] mempool: fix mempool cache flushing algorithm

2022-10-11 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, 10 October 2022 17.21 > > > Andrew Rybchenko (3): > > mempool: check driver enqueue result in one place > > mempool: avoid usage of term ring on put > > mempool: flush cache completely on overflow > > > > Morten Brørup (1):

Re: [PATCH v2 2/2] drivers: remove the unnecessary version.map

2022-10-11 Thread Omer Yamac
On 11.10.2022 16:10, David Marchand wrote: On Tue, Oct 11, 2022 at 1:09 PM Abdullah Ömer Yamaç wrote: With the previous patch, some version.map files are not necessary. In this patch, we removed them. Signed-off-by: Abdullah Ömer Yamaç Suggested-by: Ferruh Yigit I'd like some check add

[PATCH v3 30/30] baseband/acc100: configure PMON control registers

2022-10-11 Thread Hernan Vargas
Enable performance monitor control registers. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc100_pmd.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/baseband/acc/acc100_pmd.h b/drivers/baseband/acc/acc100_pmd.h index 28063b3db0..ca84ee7

[PATCH v3 28/30] baseband/acc100: add ring companion address

2022-10-11 Thread Hernan Vargas
Store the virtual address of companion ring as part of queue information. Use this address to calculate the op address. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 175 +- 1 file changed, 113 insertions(+), 62 deletions(-) diff --git a/driver

[PATCH v3 29/30] baseband/acc100: add workaround for deRM corner cases

2022-10-11 Thread Hernan Vargas
Add function to support de-ratematch pre-processing for SW corner cases. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/acc_common.h | 8 ++ drivers/baseband/acc/meson.build | 21 + drivers/baseband/acc/rte_acc100_pmd.c | 108 +- 3 files changed, 13

[PATCH v3 26/30] baseband/acc100: store FCW from first CB descriptor

2022-10-11 Thread Hernan Vargas
Store the descriptor from the first code block from a transport block. Copy the LDPC FCW from the first descriptor into the rest of the CBs in that TB. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 3 +++ 1 file changed, 3 insertions(+)

[PATCH v3 27/30] baseband/acc100: update device info

2022-10-11 Thread Hernan Vargas
Remove unused capabilities, use dummy operation as start count for number of queues. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.

[PATCH v3 24/30] baseband/acc100: rename ldpc encode function arg

2022-10-11 Thread Hernan Vargas
Rename total_enqueued_cbs to total_enqueued_descs in the enqueue_ldpc_enc_n_op_cb function. No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git

[PATCH v3 25/30] baseband/acc100: update log messages

2022-10-11 Thread Hernan Vargas
Add extra values for some log messages. No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseba

[PATCH v3 23/30] baseband/acc100: update uplink CB input length

2022-10-11 Thread Hernan Vargas
Use the FCW E parameter for rate matching as the code block input length. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/bas

[PATCH v3 22/30] baseband/acc100: add queue stop operation

2022-10-11 Thread Hernan Vargas
Implement new feature to stop queue operation. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_

[PATCH v3 21/30] baseband/acc100: implement configurable queue depth

2022-10-11 Thread Hernan Vargas
Implement new feature to make queue depth configurable based on decode or encode mode. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/rte_a

[PATCH v3 20/30] baseband/acc100: update validate LDPC enc/dec

2022-10-11 Thread Hernan Vargas
Update validate functions to check for valid LDPC parameters to avoid any HW issues. Adding protection for null corner case and for HARQ inbound size out of range. HARQ input size from application may be invalid and causing HW issue. Add checks to ensure that if HARQ is invalid, set to some valid s

[PATCH v3 19/30] baseband/acc100: added LDPC transport block support

2022-10-11 Thread Hernan Vargas
Added LDPC enqueue functions to handle transport blocks. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 167 +- 1 file changed, 164 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c

[PATCH v3 18/30] baseband/acc100: enable input validation by default

2022-10-11 Thread Hernan Vargas
Enable validation functions by default and provide a new flag RTE_LIBRTE_SKIP_VALIDATE if the user wants to run without validating input to save cycles. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 36 +-- 1 file

[PATCH v3 16/30] baseband/acc100: add scatter-gather support

2022-10-11 Thread Hernan Vargas
Add flag to support scatter-gather for the mbuf Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 37 ++- 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers

  1   2   3   >