[PATCH] examples/pipeline: fix file close

2022-09-26 Thread Harshad Narayane
Coverity issue: 380860 Fixes: 9043f66a ("examples/pipeline: add command for code generation") Fix file close at pipeline code generation. Signed-off-by: Harshad Narayane Signed-off-by: Kamalakannan R Acked-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 1 + 1 file changed, 1 insertion(

[PATCH] examples/pipeline: fix file close

2022-09-26 Thread Harshad Narayane
Coverity issue: 380860 Fixes: 9043f66a ("examples/pipeline: add command for code generation") Fix file close at pipeline code generation. Signed-off-by: Harshad Narayane Signed-off-by: Kamalakannan R Acked-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 1 + 1 file changed, 1 insertion(

RE: [PATCH v2] net/mlx5: use just sufficient barrier for Arm platforms

2022-09-26 Thread Slava Ovsiienko
Hi, Honnappa We discussed the barrier here: http://patches.dpdk.org/project/dpdk/patch/20210606164948.35997-1-honnappa.nagaraha...@arm.com/ (BTW, it is good practice to keep the reference to previous patch versions below Commit Message of the next ones). This barrier is not about compiler order

[v2 7/7] examples/fips_validation: randomize message for conformance test

2022-09-26 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion(-)

[v2 6/7] examples/fips_validation: encode digest with hash OID

2022-09-26 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash ddigest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples/f

[v2 5/7] examples/fips_validation: add asymmetric validation

2022-09-26 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v2: - improved handling priv key type. --- co

[v2 4/7] examples/fips_validation: fix buffer size to parse JSON string

2022-09-26 Thread Gowrishankar Muthukrishnan
In asym op, while parsing test interim info, existing buffer of size 256 bytes is not sufficient, hence setting it to maximum that a test would need. Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- examples/

[v2 3/7] examples/fips_validation: add function to calculate SHA hash size

2022-09-26 Thread Gowrishankar Muthukrishnan
Add function to calculate hash size for a given SHA hash algorithm. Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- v2: - fixed include file --- examples/fips_validation/fips_validation.h| 1 + ...

[v2 2/7] examples/fips_validation: add interim parse writeback

2022-09-26 Thread Gowrishankar Muthukrishnan
Asym tests need a callback to write interim info in expected output. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- examples/fips_validation/fips_validation.c | 6 ++ examples/fips_validation/fips_validation.h | 1 + 2 files changed, 7 insertions(+) diff --git a/examp

[v2 1/7] examples/fips_validation: fix parsing test group info

2022-09-26 Thread Gowrishankar Muthukrishnan
If a test group does not have expected key, it should not crash. This patch fixes parsing test group info to continue further when a key does not exist (as in asym tests). Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian

RE: [PATCH v4 0/6] crypto/security session framework rework

2022-09-26 Thread Ruifeng Wang
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, September 27, 2022 3:14 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; hemant.agra...@nxp.com; > vattun...@marvell.com; ferruh.yi...@xilinx.com; andrew.rybche...@oktetlabs.ru; > konstantin.v.anan...@yand

Re: [EXT] Re: [PATCH] event/cnxk: fix stale data in workslots

2022-09-26 Thread Jerin Jacob
On Wed, Sep 21, 2022 at 1:31 PM Pavan Nikhilesh Bhagavatula wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, September 13, 2022 8:06 PM > > To: Pavan Nikhilesh Bhagavatula > > Cc: Jerin Jacob Kollanukkaran ; Shijith Thotton > > ; dev@dpdk.org; sta...@dpdk.org

[PATCH v2 3/3] examples/l3fwd: enable direct rearm mode

2022-09-26 Thread Feifei Wang
Enable direct rearm mode in l3fwd. Users can use parameters: '--direct-rearm=(rx_portid,rx_queueid,tx_portid,tx_queueid)' to enable direct rearm. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- examples/l3fwd/l3fwd.

[PATCH v2 2/3] net/i40e: enable direct rearm mode

2022-09-26 Thread Feifei Wang
For i40e driver, enable direct re-arm mode. This patch supports the case of mapping Rx/Tx queues from the same single lcore. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- drivers/net/i40e/i40e_ethdev.c| 1

[PATCH v2 1/3] ethdev: add API for direct rearm mode

2022-09-26 Thread Feifei Wang
Add API for enabling direct rearm mode and for mapping RX and TX queues. Currently, the API supports 1:1(txq : rxq) mapping. Furthermore, to avoid Rx load Tx data directly, add API called 'rte_eth_txq_data_get' to get Tx sw_ring and its information. Suggested-by: Honnappa Nagarahalli Suggested-b

[PATCH v2 0/3] Direct re-arming of buffers on receive side

2022-09-26 Thread Feifei Wang
Currently, the transmit side frees the buffers into the lcore cache and the receive side allocates buffers from the lcore cache. The transmit side typically frees 32 buffers resulting in 32*8=256B of stores to lcore cache. The receive side allocates 32 buffers and stores them in the receive side so

RE: [PATCH v2] net/iavf: fix TSO offload for tunnel case

2022-09-26 Thread Zhang, Qi Z
> -Original Message- > From: Zeng, ZhichaoX > Sent: Monday, September 26, 2022 1:17 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Zhang, Qi Z ; Zeng, > ZhichaoX ; Wu, Jingjing ; > Xing, Beilei ; Sinha, Abhijit > ; > Doherty, Declan ; Nicolau, Radu > > Subject: [PATCH v2

RE: [PATCH] net/ice: check process type in reset operation

2022-09-26 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Monday, September 26, 2022 9:44 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > > Subject: [PATCH] net/ice: check process type in reset operation > > The secondary processes are not allowed to release shared resources. > so th

[PATCH v4 3/3] event/dlb2: optimize credit allocations

2022-09-26 Thread Abdullah Sevincer
This commit implements the changes required for using suggested port type hint feature. Each port uses different credit quanta based on port type specified using port configuration flags. Each port has separate quanta defined in dlb2_priv.h Producer and consumer ports will need larger quanta value

[PATCH v4 2/3] event/dlb2: add fence bypass option for producer ports

2022-09-26 Thread Abdullah Sevincer
If producer thread is only acting as a bridge between NIC and DLB, then performance can be greatly improved by bypassing the fence instruction. DLB enqueue API calls memory fence once per enqueue burst. If prodcuer thread is just reading from NIC and sending to DLB without updating the read buffer

[PATCH v4 1/3] event/dlb2: add producer port probing optimization

2022-09-26 Thread Abdullah Sevincer
For best performance, applications running on certain cores should use the DLB device locally available on the same tile along with other resources. To allocate optimal resources, probing is done for each producer port (PP) for a given CPU and the best performing ports are allocated to producers. T

[PATCH v3] doc: update DLB2 documentation

2022-09-26 Thread Abdullah Sevincer
This commit updates the dlb2.rst eventdev guide to document a new devarg. A new devarg: "default_port_allocation" added to allow default ldb port allocation scheme. Signed-off-by: Abdullah Sevincer --- doc/guides/eventdevs/dlb2.rst | 19 +++ 1 file changed, 19 insertions(+) diff

[PATCH v2] doc: update DLB2 documentation

2022-09-26 Thread Abdullah Sevincer
This commit updates the dlb2.rst eventdev guide to document a new devarg. A new devarg: "default_port_allocation" added to allow default ldb port allocation scheme. Signed-off-by: Abdullah Sevincer --- doc/guides/eventdevs/dlb2.rst | 19 +++ 1 file changed, 19 insertions(+) diff

[PATCH v1] doc: update DLB2 documentation

2022-09-26 Thread Abdullah Sevincer
This commit updates the dlb2.rst eventdev guide to document a new devarg. A new devarg: "default_port_allocation" added to allow default ldb port allocation scheme. Signed-off-by: Abdullah Sevincer --- doc/guides/eventdevs/dlb2.rst | 19 +++ 1 file changed, 19 insertions(+) diff

[PATCH v3 3/3] event/dlb2: optimize credit allocations

2022-09-26 Thread Abdullah Sevincer
This commit implements the changes required for using suggested port type hint feature. Each port uses different credit quanta based on port type specified using port configuration flags. Each port has separate quanta defined in dlb2_priv.h Producer and consumer ports will need larger quanta value

[PATCH v3 2/3] event/dlb2: add fence bypass option for producer ports

2022-09-26 Thread Abdullah Sevincer
If producer thread is only acting as a bridge between NIC and DLB, then performance can be greatly improved by bypassing the fence instruction. DLB enqueue API calls memory fence once per enqueue burst. If prodcuer thread is just reading from NIC and sending to DLB without updating the read buffer

[PATCH v3 1/3] event/dlb2: add producer port probing optimization

2022-09-26 Thread Abdullah Sevincer
For best performance, applications running on certain cores should use the DLB device locally available on the same tile along with other resources. To allocate optimal resources, probing is done for each producer port (PP) for a given CPU and the best performing ports are allocated to producers. T

[PATCH v2 3/3] event/dlb2: optimize credit allocations

2022-09-26 Thread Abdullah Sevincer
This commit implements the changes required for using suggested port type hint feature. Each port uses different credit quanta based on port type specified using port configuration flags. Each port has separate quanta defined in dlb2_priv.h Producer and consumer ports will need larger quanta value

[PATCH v2 2/3] event/dlb2: add fence bypass option for producer ports

2022-09-26 Thread Abdullah Sevincer
If producer thread is only acting as a bridge between NIC and DLB, then performance can be greatly improved by bypassing the fence instruction. DLB enqueue API calls memory fence once per enqueue burst. If prodcuer thread is just reading from NIC and sending to DLB without updating the read buffer

[PATCH v2 1/3] event/dlb2: add producer port probing optimization

2022-09-26 Thread Abdullah Sevincer
For best performance, applications running on certain cores should use the DLB device locally available on the same tile along with other resources. To allocate optimal resources, probing is done for each producer port (PP) for a given CPU and the best performing ports are allocated to producers. T

RE: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix resource leak when releasing a drop action

2022-09-26 Thread Slava Ovsiienko
Hi, Yunjian We have drop action in mlx5. To create/destroy drop action we have mlx5_drop_action_create/ mlx5_drop_action_destroy common routines. As PMD supports operation either over FW (Verbs in rdma_core) or SW/HW steering with DevX objects the "virtual" methods are used for objects: priv->o

RE: [PATCH v4 0/6] crypto/security session framework rework

2022-09-26 Thread Akhil Goyal
++ Liron for mvsam. > Subject: [PATCH v4 0/6] crypto/security session framework rework > > This patchset reworks the symmetric crypto and security session > data structure to use a single virtual/physical contiguous buffer > for symmetric crypto/security session and driver private data. > In addi

[PATCH v4 6/6] security: hide session structure

2022-09-26 Thread Akhil Goyal
Structure rte_security_session is moved to internal headers which are not visible to applications. The only field which should be used by app is opaque_data. This field can now be accessed via set/get APIs added in this patch. Subsequent changes in app and lib are made to compile the code. Signed-

[PATCH v4 5/6] drivers/crypto: support security session get size op

2022-09-26 Thread Akhil Goyal
Added the support for rte_security_op.session_get_size() in all the PMDs which support rte_security sessions and the op was not supported. Signed-off-by: Akhil Goyal Acked-by: Kai Ji Tested-by: Gagandeep Singh Tested-by: David Coyle Tested-by: Kevin O'Sullivan --- drivers/crypto/caam_jr/caam

[PATCH v4 3/6] cryptodev: hide sym session structure

2022-09-26 Thread Akhil Goyal
Structure rte_cryptodev_sym_session is moved to internal headers which are not visible to applications. The only field which should be used by app is opaque_data. This field can now be accessed via set/get APIs added in this patch. Subsequent changes in app and lib are made to compile the code. Si

[PATCH v4 4/6] security: remove priv mempool usage

2022-09-26 Thread Akhil Goyal
As per current design, rte_security_session_create() unnecessarily use 2 mempool objects for a single session. To address this, the API will now take only 1 mempool object instead of 2. With this change, the library layer will get the object from mempool and session priv data is stored contiguousl

[PATCH v4 2/6] crypto/scheduler: use unified session

2022-09-26 Thread Akhil Goyal
From: Fan Zhang This patch updates the scheduler PMD to use unified session data structure. Previously thanks to the private session array in cryptodev sym session there are no necessary change needed for scheduler PMD other than the way ops are enqueued/dequeued. The patch inherits the same desi

[PATCH v4 0/6] crypto/security session framework rework

2022-09-26 Thread Akhil Goyal
This patchset reworks the symmetric crypto and security session data structure to use a single virtual/physical contiguous buffer for symmetric crypto/security session and driver private data. In addition the session data structure is now private. The session is represented as an opaque pointer in

RE: [PATCH v5 0/7] ethdev: separate metering and marking from policing

2022-09-26 Thread Alexander Kozyrev
> Hi Alexander, > > Thanks very much for your pseudo-code detailing the updated meter & flow > operation! > > Should we setup another call sometime next week to go through it? I still see > a few fuzzy things where we need to level set. > > Regards, > Cristian Hi Christian, do you still have qu

[PATCH v6 3/3] test/security: add inline IPsec SA hard expiry cases

2022-09-26 Thread Akhil Goyal
From: Vamsi Attunuru Patch adds hard expiry unit tests for both packet and byte limits. Signed-off-by: Vamsi Attunuru Acked-by: Akhil Goyal --- app/test/test_security_inline_proto.c | 71 +++ 1 file changed, 61 insertions(+), 10 deletions(-) diff --git a/app/test/test

[PATCH v6 2/3] test/security: add inline IPsec SA soft expiry cases

2022-09-26 Thread Akhil Goyal
From: Vamsi Attunuru Patch adds unit tests for packet & byte soft expiry events. Signed-off-by: Vamsi Attunuru Acked-by: Akhil Goyal --- app/test/test_cryptodev_security_ipsec.h | 2 + app/test/test_security_inline_proto.c | 105 +- app/test/test_security_inline

[PATCH v6 1/3] ethdev: add IPsec SA expiry event subtypes

2022-09-26 Thread Akhil Goyal
From: Vamsi Attunuru Patch adds new event subtypes for notifying expiry events upon reaching IPsec SA soft packet expiry and hard packet/byte expiry limits. Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal Acked-by: Thomas Monjalon --- lib/ethdev/rte_ethdev.h | 23 +++

[PATCH v6 0/3] Add and test IPsec SA expiry events

2022-09-26 Thread Akhil Goyal
This patchset is carried forward from last release patches [1] which added test application changes to test inline IPsec. These patches were not merged due to the ABI compatibility issues due to the extension of enum. Changes in v6: fix doc build in 1/3 Changes in v5: added reference to struct wh

Re: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-26 Thread Chas Williams
On 9/26/22 06:18, Konstantin Ananyev wrote: Hi everyone, Sorry for late reply. The main problem is hard to design a tx_prepare for bonding device: 1. as Chas Williams said, there maybe twice hash calc to get target slave     devices. 2. also more important, if the slave devices have cha

Re: [PATCH v6] usertools: rewrite pmdinfo

2022-09-26 Thread Bruce Richardson
On Mon, Sep 26, 2022 at 03:44:38PM +0200, Robin Jarry wrote: > dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag > merely prints multiple independent JSON lines which cannot be fed > directly to any JSON parser. Moreover, the script complexity is rather > high for such a simp

[PATCH] app/eventdev: fix incorrect cleanup check

2022-09-26 Thread pbhagavatula
From: Pavan Nikhilesh During cleanup `rte_event_port_quiesce` should be called irrespective of whether an event has been dequeued or not to flush any prefetched events. Fixes: 7da008df0c8d ("app/eventdev: use port quiescing") Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_

Re: [EXT] Re: [PATCH 1/6] ethdev: add trace points

2022-09-26 Thread Andrew Rybchenko
@Jerin, I'd like to know what do you think about my question/thoughts below. On 9/13/22 10:18, Andrew Rybchenko wrote: On 9/13/22 09:48, Ankur Dwivedi wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Monday, September 12, 2022 4:30 PM To: Ankur Dwivedi ; dev@dpdk.org

[PATCH v5 7/7] app/testpmd: add meter color mark flow action

2022-09-26 Thread Alexander Kozyrev
Add testpmd command line to match for METER_MARK action: flow create ... actions meter_mark mtr_profile 20 / end Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 153 app/test-pmd/config.c | 45 +- app/test

[PATCH v5 5/7] app/testpmd: add meter color flow matching item

2022-09-26 Thread Alexander Kozyrev
Add testpmd command line to match on a meter color: flow create 0 ingress group 0 pattern meter color is green / end Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 83 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 + 2 files ch

[PATCH v5 6/7] app/testpmd: allow meter color marker modification

2022-09-26 Thread Alexander Kozyrev
Extend the list of available modify_field IDs to include recently added meter color marker item in testpmd CLI. Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_

[PATCH v5 3/7] ethdev: get meter profile/policy objects

2022-09-26 Thread Alexander Kozyrev
Introduce a new Meter API to retrieve a Meter profile and policy objects using the profile/policy ID previously created with meter_profile_add() and meter_policy_create() functions. That allows to save the pointer and avoid any lookups in the corresponding lists for quick access during a flow rule

[PATCH v5 4/7] ethdev: add meter color mark flow action

2022-09-26 Thread Alexander Kozyrev
Create a new Flow API action: METER_MARK. It Meters a packet stream and marks its packets with colors. The marking is done on a metadata, not on a packet field. Unlike the METER action, it performs no policing at all. A user has the flexibility to create any policies with the help of the METER_COLO

[PATCH v5 2/7] ethdev: allow meter color marker modification

2022-09-26 Thread Alexander Kozyrev
Extend modify_field Flow API with support of Meter Color Marker modifications. It allows setting the packet's metadata to any color marker: green, yellow or red. A user is able to specify an initial packet color for Meter API or create simple Metering and Marking flow rules based on his own colorin

[PATCH v5 1/7] ethdev: add meter color flow matching item

2022-09-26 Thread Alexander Kozyrev
Provide an ability to use a Color Marker set by a Meter as a matching item in Flow API. The Color Marker reflects the metering result by setting the metadata for a packet to a particular codepoint: green, yellow or red. Signed-off-by: Alexander Kozyrev --- doc/guides/prog_guide/rte_flow.rst

[PATCH v5 0/7] ethdev: separate metering and marking from policing

2022-09-26 Thread Alexander Kozyrev
Extend Metering and Marking support in the Flow API: 1. Add METER_COLOR item to match Color Marker set by a Meter. 2. Add the ability to set Color Marker via modify_field Flow API. 3. Add Meter API to get profile/policy objects. 4. Add METER_MARK action to perform Meter color metering and marking.

Re: [PATCH v2] ethdev: add GTP PSC QFI field

2022-09-26 Thread Andrew Rybchenko
On 9/21/22 17:32, Dariusz Sosnowski wrote: This patch introduces the GTP PSC QFI modify field support and adds the testpmd CLI command support. An example for copying GTP QFI field using modify_field action: modify_field op set dst_type meta src

Re: [dpdk-dev] [PATCH 1/2] lib/ethdev: introduce RTE_ETH_DEV_CAPA_FLOW_CREATE_BEFORE_START

2022-09-26 Thread Thomas Monjalon
There was no follow up to this patch. Ori, could you give your opinion please? 12/10/2021 14:02, Andrew Rybchenko: > Summary prefix should be just "ethdev: " and summary should > be human readable. It should not refer to defines etc. > > On 10/5/21 8:19 PM, Martin Havlik wrote: > > Not all PMDs

Re: [dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback

2022-09-26 Thread Thomas Monjalon
This patch is abandoned. Current behaviour is kept. 15/07/2021 11:06, Ferruh Yigit: > On 7/14/2021 4:42 PM, Thomas Monjalon wrote: > > 14/07/2021 16:16, Matan Azrad: > >> From: Thomas Monjalon > >>> 13/07/2021 15:42, Matan Azrad: > From: Thomas Monjalon > > When registering a new event c

[PATCH v5 10/10] maintainers: add dts maintainers

2022-09-26 Thread Juraj Linkeš
Signed-off-by: Juraj Linkeš --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 32ffdd1a61..32a6493502 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -114,6 +114,11 @@ F: buildtools/symlink-drivers-solibs.py F: devtools/test-meson-builds.sh F:

[PATCH v5 09/10] dts: add dts executable script

2022-09-26 Thread Juraj Linkeš
The script is an interface to run DTS. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- dts/main.py | 24 1 file changed, 24 insertions(+) create mode 100755 dts/main.py diff --git a/dts/main.py b/dts/main.py new file mode 100755 index 00..a70070765

[PATCH v5 08/10] dts: add dts workflow module

2022-09-26 Thread Juraj Linkeš
The module implements methods needed to run DTS. It handles the creation of objects and eventually the whole DTS workflow, such as running node setups, test gathering, setup and execution and various cleanups. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- dts/framework/dts.py |

[PATCH v5 07/10] dts: add node base class

2022-09-26 Thread Juraj Linkeš
The base class implements basic node management methods - connect and execute commands. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/__init__.py | 8 +++ dts/framework/testbed_model/node.py | 83 + 2 files changed, 91 inser

[PATCH v5 06/10] dts: add ssh connection module

2022-09-26 Thread Juraj Linkeš
The module uses the pexpect python library and implements connection to a node and two ways to interact with the node: 1. Send a string with specified prompt which will be matched after the string has been sent to the node. 2. Send a command to be executed. No prompt is specified here. Signed-o

[PATCH v5 05/10] dts: add remote session abstraction

2022-09-26 Thread Juraj Linkeš
The abstraction allows for easy switching of implementations of remote connections (ssh, telnet, etc.). It implements some common features, such as logging of commands and their outputs and history bookkeeping and defines methods that must be implemented by derived classes. Signed-off-by: Owen Hil

[PATCH v5 02/10] dts: add developer tools

2022-09-26 Thread Juraj Linkeš
The Dockerfile contains basic image for CI and developers. There's also an integration of the Dockerfile with Visual Studio. The devtools that check Python code are Black and Isort to format the code and Pylama to do static analysis. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš ---

[PATCH v5 04/10] dts: add basic logging facility

2022-09-26 Thread Juraj Linkeš
The logging module provides loggers distinguished by two attributes, a custom format and a verbosity switch. The loggers log to both console and more verbosely to files. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- dts/framework/__init__.py | 4 ++ dts/framework/logger.py | 1

[PATCH v5 03/10] dts: add config parser module

2022-09-26 Thread Juraj Linkeš
From: Owen Hilyard The configuration is split into two parts, one defining the parameters of the test run and the other defining the topology to be used. The format of the configuration is YAML. It is validated according to a json schema which also server as detailed documentation of the various

[PATCH v5 01/10] dts: add project tools config

2022-09-26 Thread Juraj Linkeš
Add configuration for Python tools used in DTS: Poetry, dependency and package manager Black, formatter Pylama, static analysis Isort, import sorting Add Python and DTS specifics to .gitignore and .editorconfig. Of note is the change of maximum line length of Python code to 88, which is a good com

[PATCH v5 00/10] dts: ssh connection to a node

2022-09-26 Thread Juraj Linkeš
All the necessary code needed to connect to a node in a topology with a bit more, such as basic logging and some extra useful methods. To run the code, modify the config file, conf.yaml and execute ./main.py from the root dts folder. Here's an example config: executions: - system_under_test: "SU

RE: [PATCH] eventdev: fix name of Rx conf type

2022-09-26 Thread Jayatheerthan, Jay
Looks good to me. Thanks for catching this one! Acked-by: Jay Jayatheerthan > -Original Message- > From: Volodymyr Fialko > Sent: Monday, September 26, 2022 5:28 PM > To: dev@dpdk.org; Jayatheerthan, Jay ; Jerin > Jacob ; Rao, Nikhil > > Cc: gak...@marvell.com; ano...@marvell.com; Gu

Re: [PATCH v5 1/3] ethdev: add IPsec SA expiry event subtypes

2022-09-26 Thread Thomas Monjalon
24/09/2022 15:57, Akhil Goyal: > From: Vamsi Attunuru > > Patch adds new event subtypes for notifying expiry > events upon reaching IPsec SA soft packet expiry and > hard packet/byte expiry limits. > > Signed-off-by: Vamsi Attunuru > Signed-off-by: Akhil Goyal > --- > --- a/lib/ethdev/rte_ethd

[PATCH] net/ice: check process type in reset operation

2022-09-26 Thread Qiming Yang
The secondary processes are not allowed to release shared resources. so the stop and reset operation are forbidden in a secondary process. Signed-off-by: Qiming Yang --- drivers/net/ice/ice_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/

Re: [PATCH V3 2/7] table: add entry ID for learner tables

2022-09-26 Thread Thomas Monjalon
26/09/2022 11:19, Dumitrescu, Cristian: > > > -Original Message- > > From: Thomas Monjalon > > Sent: Saturday, September 24, 2022 9:25 AM > > To: Dumitrescu, Cristian > > Cc: dev@dpdk.org > > Subject: Re: [PATCH V3 2/7] table: add entry ID for learner tables > > > > 30/08/2022 20:58, Cr

[PATCH v6] usertools: rewrite pmdinfo

2022-09-26 Thread Robin Jarry
dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag merely prints multiple independent JSON lines which cannot be fed directly to any JSON parser. Moreover, the script complexity is rather high for such a simple task: extracting PMD_INFO_STRING from .rodata ELF sections. Rewrit

RE: [EXT] Re: [PATCH 1/3] net: add MACsec header

2022-09-26 Thread Akhil Goyal
Hi Olivier, Thanks for your review. I will fix the issues in next version. > Hi Akhil, > > Few comments below. > > On Mon, Aug 15, 2022 at 12:16:18AM +0530, Akhil Goyal wrote: > > Added MACsec protocol header to be used for supporting > > MACsec protocol offload in hardware or directly in the a

Re: [PATCH v2] ethdev: queue rate parameter changed from 16b to 32b

2022-09-26 Thread Andrew Rybchenko
On 9/23/22 16:45, skotesh...@marvell.com wrote: From: Satha Rao The rate parameter modified to uint32_t, so that it can work for more than 64 Gbps. Signed-off-by: Satha Rao Overall LGTM, but please update release notes and cleanup deprecation in the next version. However, the patch require

Re: DPDK 19.11.5 Legacy Memory Design Query

2022-09-26 Thread Umakiran Godavarthi (ugodavar)
Hi Dimitry We know If the application does unmap, DPDK native heaps are not getting cleaned up in “native: use regular DPDK memory” memory type. Can we get an API from DPDK community please to clean up the heaps given the VA and length to be freed ? Like below https://doc.dpdk.org/api/rte__m

Re: [PATCH v3] ethdev: add send to kernel action

2022-09-26 Thread Andrew Rybchenko
On 9/19/22 18:50, Michael Savisko wrote: In some cases application may receive a packet that should have been received by the kernel. In this case application uses KNI or other means to transfer the packet to the kernel. With bifurcated driver we can have a rule to route packets matching a patte

Re: DPDK 19.11.5 Legacy Memory Design Query

2022-09-26 Thread Umakiran Godavarthi (ugodavar)
Thanks @Dmitry Kozlyuk for your suggestions I will try the following for DPDK pool creation My logic of calculating MBUF’s remains same Saw this code in DPDK testpmd where External heap memory is used case MP_ALLOC_XMEM_HUGE: {

Re: [PATCH v5] usertools: rewrite pmdinfo

2022-09-26 Thread Robin Jarry
Robin Jarry, Sep 22, 2022 at 13:58: > +# > > +def ld_so_path() -> Iterator[str]: > +""" > +Return the list of directories where dynamic libraries are loaded based > +on the contents of /etc/ld.so.conf/*.conf.

Re: [PATCH 1/3] net: add MACsec header

2022-09-26 Thread Olivier Matz
Hi Akhil, Few comments below. On Mon, Aug 15, 2022 at 12:16:18AM +0530, Akhil Goyal wrote: > Added MACsec protocol header to be used for supporting > MACsec protocol offload in hardware or directly in the application. > > Signed-off-by: Akhil Goyal > --- > doc/api/doxy-api-index.md | 3 ++- >

RE: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix use after free when releasing tx queues

2022-09-26 Thread Slava Ovsiienko
Hi, Yunjian Could you, please, tell more details about problematic scenario? In bonding slave? It is not fully clean for me how mlx5_txq_release frees priv->txqs[idx] (BTW NULL is OK to free, it is safe). We have check for NULL here: > > - if (priv->txqs == NULL || (*priv->txqs)[idx] == NULL) p

Re: [PATCH] mbuf: remove deprecated offload flags

2022-09-26 Thread David Marchand
On Mon, Sep 26, 2022 at 1:52 PM Olivier Matz wrote: > > On Mon, Aug 22, 2022 at 05:26:34PM +0200, David Marchand wrote: > > On Fri, Aug 5, 2022 at 10:03 AM Andrew Rybchenko > > wrote: > > > > > > Remove deprecated ``PKT_*`` flags. Use corresponding flags with > > > ``RTE_MBUF_F_`` prefix instead.

Re: [PATCH 0/3] mempool: apply deprecations

2022-09-26 Thread David Marchand
On Mon, Sep 26, 2022 at 1:43 PM Olivier Matz wrote: > > On Thu, Jul 28, 2022 at 01:38:04PM +0200, David Marchand wrote: > > On Thu, Jul 28, 2022 at 11:36 AM Andrew Rybchenko > > wrote: > > > > > > Remove deprecated macros. > > > > > > Andrew Rybchenko (3): > > > mempool: remove deprecated macro

RE: [PATCH v7 6/7] app/procinfo: fix some wrong doxygen syntax

2022-09-26 Thread Pattan, Reshma
> -Original Message- > From: Dongdong Liu > Signed-off-by: Dongdong Liu If no need to follow style of API comments I am fine with the changes. Acked-by: Reshma Pattan

[PATCH] eventdev: fix name of Rx conf type

2022-09-26 Thread Volodymyr Fialko
Rename configuration structure type to correspond definition. Fixes: dcc806c2638 ("eventdev: add eth Rx adapter API") Signed-off-by: Volodymyr Fialko --- lib/eventdev/rte_event_eth_rx_adapter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_eth_rx_ada

Re: [PATCH v5] usertools: rewrite pmdinfo

2022-09-26 Thread Olivier Matz
On Thu, Sep 22, 2022 at 01:58:02PM +0200, Robin Jarry wrote: > dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag > merely prints multiple independent JSON lines which cannot be fed > directly to any JSON parser. Moreover, the script complexity is rather > high for such a simp

RE: [PATCH v7 4/7] app/procinfo: add module eeprom info dump

2022-09-26 Thread Pattan, Reshma
> -Original Message- > From: Dongdong Liu > Subject: [PATCH v7 4/7] app/procinfo: add module eeprom info dump > > From: "Min Hu (Connor)" > > This patch add support for module eeprom info dump. > > The command is like: > dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-mod

Re: [PATCH v3 00/13] telemetry JSON escaping and other enhancements

2022-09-26 Thread David Marchand
On Fri, Sep 9, 2022 at 11:36 AM Bruce Richardson wrote: > > This patchset contains fixes for the problem of handling characters returned > by > telemetry callbacks which require escaping when encoded in JSON format. It > also > includes unit tests to validate the correct encoding in such scenari

Re: [PATCH] mbuf: remove deprecated offload flags

2022-09-26 Thread Olivier Matz
On Mon, Aug 22, 2022 at 05:26:34PM +0200, David Marchand wrote: > On Fri, Aug 5, 2022 at 10:03 AM Andrew Rybchenko > wrote: > > > > Remove deprecated ``PKT_*`` flags. Use corresponding flags with > > ``RTE_MBUF_F_`` prefix instead. > > > > Signed-off-by: Andrew Rybchenko Acked-by: Olivier Matz

Re: [PATCH 0/3] mempool: apply deprecations

2022-09-26 Thread Olivier Matz
On Thu, Jul 28, 2022 at 01:38:04PM +0200, David Marchand wrote: > On Thu, Jul 28, 2022 at 11:36 AM Andrew Rybchenko > wrote: > > > > Remove deprecated macros. > > > > Andrew Rybchenko (3): > > mempool: remove deprecated macro to calculate header size > > mempool: remove deprecated macro to reg

[PATCH v2 3/3] crypto/cnxk: add vectorization for event crypto

2022-09-26 Thread Volodymyr Fialko
Add support for vector aggregation of crypto operations for cn10k. Crypto operations will be grouped by sub event type, flow id, scheduler type and queue id fields from rte_event_crypto_metadata::response_info. Signed-off-by: Volodymyr Fialko --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 403

[PATCH v2 2/3] crypto/cnxk: add burst enqueue for event crypto

2022-09-26 Thread Volodymyr Fialko
Added support for burst enqueue for cn10k event crypto adapter. Instruction will be grouped based on the queue pair and sent in a burst. Signed-off-by: Volodymyr Fialko --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 147 -- drivers/crypto/cnxk/cn10k_cryptodev_ops.h | 7 +-

[PATCH v2 1/3] eventdev: introduce event cryptodev vector type

2022-09-26 Thread Volodymyr Fialko
Introduce ability to aggregate crypto operations processed by event crypto adapter into single event containing rte_event_vector whose event type is RTE_EVENT_TYPE_CRYPTODEV_VECTOR. Application should set RTE_EVENT_CRYPTO_ADAPTER_EVENT_VECTOR in rte_event_crypto_adapter_queue_conf::flag and provid

[PATCH v2 0/3] Vector support for event crypto adapter

2022-09-26 Thread Volodymyr Fialko
Introduce ability to aggregate crypto operations processed by event crypto adapter into single event containing rte_event_vector whose event type is RTE_EVENT_TYPE_CRYPTODEV_VECTOR. * Changes since v1 - Add missing newline/space issues - Add missing error messages - Remove double check of conf inp

RE: [PATCH 1/3] eventdev: introduce event cryptodev vector type

2022-09-26 Thread Volodymyr Fialko
> -Original Message- > From: Gujjar, Abhinandan S > Sent: Saturday, September 24, 2022 10:44 AM > To: Volodymyr Fialko ; dev@dpdk.org; Jerin Jacob > Kollanukkaran > ; Pavan Nikhilesh Bhagavatula ; > Shijith Thotton > ; Hemant Agrawal ; Sachin Saxena > ; Jayatheerthan, Jay > Cc: Akhil

[PATCH v3] examples/ipsec-secgw: free event vector mbufs

2022-09-26 Thread Rahul Bhansali
Free mbufs from event vector list when enqueue operation fails and during event port flush for cleanup. Signed-off-by: Rahul Bhansali --- v3: updated args of rte_pktmbuf_free_bulk as per v2 dependent series. v2: Added dependent series info. Depends-on: series-24761 ("[v2,1/3] eventdev: add elem

Re: [PATCH v3] eal: update lcore-worker name due to high number of cores

2022-09-26 Thread Kevin Traynor
On 26/09/2022 10:39, David Marchand wrote: Hello, On Fri, Sep 23, 2022 at 9:06 AM Abdullah Ömer Yamaç wrote: In this patch we suggest a new name for lcore-worker. In case of more than 99 logical cores, name is truncated (length is restricted to 16 characters, including the terminating null by

RE: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-26 Thread Konstantin Ananyev
Hi everyone, Sorry for late reply. > > The main problem is hard to design a tx_prepare for bonding device: > > 1. as Chas Williams said, there maybe twice hash calc to get target > > slave > >     devices. > > 2. also more important, if the slave devices have changes(e.g.

RE: [PATCH v3 0/6] crypto/security session framework rework

2022-09-26 Thread Akhil Goyal
> > Subject: [PATCH v3 0/6] crypto/security session framework rework > > > > This patchset reworks the symmetric crypto and security session data > > structure > to use a > > single virtual/physical contiguous buffer for symmetric crypto/security > > session > and driver > > private data. > > In

  1   2   >