RE: [PATCH v2] app/testpmd: add throughput stats for forward streams

2022-08-10 Thread Guo, Junfeng
> -Original Message- > From: Singh, Aman Deep > Sent: Friday, June 17, 2022 00:40 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; Wang, Xiao W > Subject: Re: [PATCH v2] app/testpmd: add throughput stats for > forward streams > > Hi Junfeng, > >

RE: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-10 Thread Chaoyong He
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, August 11, 2022 12:25 PM > To: Chaoyong He > Cc: Andrew Rybchenko ; Niklas > Soderlund ; dev@dpdk.org > Subject: Re: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics > > On Thu, 11 Aug 2022 01:26:49 + >

[PATCH] net/mlx5: fix single not inline packet elts storing

2022-08-10 Thread Viacheslav Ovsiienko
The mlx5 PMD can inline packet data into transmitting descriptor (WQE) and free mbuf immediately as data no longer needed, for non-inline packets the mbuf pointer should be stored in elts array for coming freeing on send completion. There was an optimization on storing pointers in batch and there w

[PATCH] net/mlx5: fix check for orphan wait descriptor

2022-08-10 Thread Viacheslav Ovsiienko
The mlx5 PMD supports send scheduling feature, it allows to send packets at specified moment of time, to do that PMD pushes special wait descriptor (WQE) to the hardware queue and then pushes descriptor for packet data as usual. If queue is close to be full or there is no enough elts buffers to sto

Re: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-10 Thread Stephen Hemminger
On Thu, 11 Aug 2022 01:26:49 + Chaoyong He wrote: > > > The 'port_id' is the 'Device [external] port identifier', which > > > related with the 'rte_ethdev_devices[]' I think. > > > Here the ethdev we created is not exposed to the user and is not in the > > 'rte_ethdev_devices[]' > > > arr

[PATCH 1/1] app/test-security-perf: add security perf app

2022-08-10 Thread Anoob Joseph
Add app to test rte_security session create/destroy rates. Signed-off-by: Anoob Joseph Signed-off-by: Aakash Sasidharan --- MAINTAINERS | 6 + app/meson.build | 1 + app/test-security-perf/meson.build | 14 + app/test-sec

[PATCH 0/1] Add security perf application

2022-08-10 Thread Anoob Joseph
Add performance application to test security session create & destroy rates supported by the security enabled cryptodev PMD. The application would create specified number of sessions and captures the time taken for the same before proceeding to destroy of the same. When operating on multi-core, the

Re: [PATCH] docs: change the doc to highlight the allowed multicast addresses

2022-08-10 Thread Huzaifa Rahman
Hi, Is there any other work/changes required for this patch to be submitted? Thanks On Fri, Jul 1, 2022 at 3:37 PM huzaifa.rahman wrote: > Bugzilla ID: 802 > > The ipv4_multicast example does not work with any multicast IPs. > Only a selected few IPs are allowed to send pakcets. These IPs >

RE: [PATCH 2/2] test/member: add functional and perf tests for sketch

2022-08-10 Thread Suanming Mou
Hi, > -Original Message- > From: Leyi Rong > Sent: Wednesday, August 10, 2022 3:45 PM > To: yipeng1.w...@intel.com; zaoxing...@gmail.com; sameh.gobr...@intel.com > Cc: dev@dpdk.org; Leyi Rong > Subject: [PATCH 2/2] test/member: add functional and perf tests for sketch > > This patch add

RE: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-10 Thread Chaoyong He
> On Wed, 10 Aug 2022 01:51:55 + > Chaoyong He wrote: > > > > On Mon, 8 Aug 2022 11:32:30 + > > > Chaoyong He wrote: > > > > > > > > > + goto done; > > > > > > + > > > > > > + /* Allocate memory for the eth_dev of the vNIC */ > > > > > > + hw->eth_dev = rte_zmalloc("ctrl_vn

RE: [RFC v2] non-temporal memcpy

2022-08-10 Thread Honnappa Nagarahalli
> > > From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > > Sent: Wednesday, 10 August 2022 13.56 > > > > On 2022-08-09 17:26, Stephen Hemminger wrote: > > [...] > > > > > Alignment seems like a non-issue to me. A NT-store memcpy() can be > > made free of alignment requirements, incurring

RE: [RFC v2] non-temporal memcpy

2022-08-10 Thread Honnappa Nagarahalli
> > +TO: @Honnappa, we need input from ARM > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Friday, 29 July 2022 21.49 > > > > > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > > > Sent: Friday, 29 July 2022 14.14 > > > > > > > > > > > > So

RE: [PATCH v2 2/4] event/sw: report periodic event timer capability

2022-08-10 Thread Carrillo, Erik G
Hi Harish, > -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, August 10, 2022 2:10 AM > To: Carrillo, Erik G ; jer...@marvell.com; Van > Haaren, Harry > Cc: dev@dpdk.org > Subject: [PATCH v2 2/4] event/sw: report periodic event timer capability > > update the software ev

RE: [PATCH v2 1/4] eventdev/timer: add periodic event timer support

2022-08-10 Thread Carrillo, Erik G
Hi Harish, > -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, August 10, 2022 2:07 AM > To: Carrillo, Erik G ; jer...@marvell.com > Cc: pbhagavat...@marvell.com; sthot...@marvell.com; dev@dpdk.org > Subject: [PATCH v2 1/4] eventdev/timer: add periodic event timer support >

Re: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-10 Thread Stephen Hemminger
On Wed, 10 Aug 2022 01:51:55 + Chaoyong He wrote: > > On Mon, 8 Aug 2022 11:32:30 + > > Chaoyong He wrote: > > > > > > > + goto done; > > > > > + > > > > > + /* Allocate memory for the eth_dev of the vNIC */ > > > > > + hw->eth_dev = rte_zmalloc("ctrl_vnic_eth_dev"

Re: [PATCH v2 3/4] timer: fix function to stop all timers

2022-08-10 Thread Stephen Hemminger
On Wed, 10 Aug 2022 19:29:36 + "Carrillo, Erik G" wrote: > Hi Harish, > > > -Original Message- > > From: Naga Harish K, S V > > Sent: Wednesday, August 10, 2022 2:10 AM > > To: Carrillo, Erik G > > Cc: dev@dpdk.org; sta...@dpdk.org > > Subject: [PATCH v2 3/4] timer: fix function to

RE: [PATCH v2 3/4] timer: fix function to stop all timers

2022-08-10 Thread Carrillo, Erik G
Hi Harish, > -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, August 10, 2022 2:10 AM > To: Carrillo, Erik G > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2 3/4] timer: fix function to stop all timers > > There is a possibility of deadlock in this API, as same s

Re: [PATCH] build: enable developer mode for all working trees

2022-08-10 Thread Stephen Hemminger
On Wed, 10 Aug 2022 20:40:58 +0300 Dmitry Kozlyuk wrote: > Developer mode was detected if `.git` was a directory. > Linked git working trees created by `git worktree add` > contain `.git` file instead of `.git` directory. > Developer mode was not detected for such directories. > Detect developer

[PATCH] build: enable developer mode for all working trees

2022-08-10 Thread Dmitry Kozlyuk
Developer mode was detected if `.git` was a directory. Linked git working trees created by `git worktree add` contain `.git` file instead of `.git` directory. Developer mode was not detected for such directories. Detect developer mode by the presence of `.git` path. Fixes: bc4617433845 ("build: en

Re: [PATCH] usertools: fix bind failure from dpdk to kernel

2022-08-10 Thread Stephen Hemminger
On Wed, 10 Aug 2022 09:02:57 +0300 Krzysztof Kozlowski wrote: > On 09/08/2022 20:58, Stephen Hemminger wrote: > >> > >> However, due to the patch[1] merged into 5.19 kernel, 'driver_override' > >> in the pci_dev is no longer NULL by writing '\00' to driver_override file. > >> This causes PCI matc

Re: [PATCH] usertools: fix bind failure from dpdk to kernel

2022-08-10 Thread Stephen Hemminger
On Wed, 10 Aug 2022 08:59:15 +0300 Krzysztof Kozlowski wrote: > On 09/08/2022 14:44, lihuisong (C) wrote: > > > > 在 2022/8/5 23:35, Stephen Hemminger 写道: > >> On Fri, 5 Aug 2022 11:10:22 +0800 > >> Huisong Li wrote: > >> > >>> Currently, the steps for binding device from dpdk driver to kern

RE: [RFC v2] non-temporal memcpy

2022-08-10 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Wednesday, 10 August 2022 13.56 > > On 2022-08-09 17:26, Stephen Hemminger wrote: [...] > > Alignment seems like a non-issue to me. A NT-store memcpy() can be made > free of alignment requirements, incurring only a very slight cost

RE: [RFC v2] non-temporal memcpy

2022-08-10 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Wednesday, 10 August 2022 14.00 > > On 2022-08-09 19:24, Morten Brørup wrote: > >> From: Stephen Hemminger [mailto:step...@networkplumber.org] > >> Sent: Tuesday, 9 August 2022 17.26 > >> > >> On Tue, 9 Aug 2022 11:46:19 +0200 > >> Mo

Re: [RFC v2] non-temporal memcpy

2022-08-10 Thread Mattias Rönnblom
On 2022-08-09 19:24, Morten Brørup wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Tuesday, 9 August 2022 17.26 On Tue, 9 Aug 2022 11:46:19 +0200 Morten Brørup wrote: I don't think memcpy() functions should have alignment requirements. That's not very practical, an

Re: [RFC v2] non-temporal memcpy

2022-08-10 Thread Mattias Rönnblom
On 2022-08-09 17:26, Stephen Hemminger wrote: On Tue, 9 Aug 2022 11:46:19 +0200 Morten Brørup wrote: I don't think memcpy() functions should have alignment requirements. That's not very practical, and violates the principle of least surprise. I didn't make the CPUs with these alignment requ

Re: [RFC v2] non-temporal memcpy

2022-08-10 Thread Mattias Rönnblom
On 2022-08-09 17:00, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Tuesday, 9 August 2022 14.05 On 2022-08-09 11:46, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Sunday, 7 August 2022 22.25 On 2022-07-19 17:26, Morten Brøru

RE: [PATCH 2/4] event/sw: report periodic event timer capability

2022-08-10 Thread Naga Harish K, S V
Hi, > -Original Message- > From: Van Haaren, Harry > Sent: Friday, August 5, 2022 5:31 PM > To: Naga Harish K, S V ; Carrillo, Erik G > ; jer...@marvell.com > Cc: dev@dpdk.org > Subject: RE: [PATCH 2/4] event/sw: report periodic event timer capability > > > -Original Message- >

[PATCH v2] net/iavf: fix Tx L3 checksum offload flag

2022-08-10 Thread Ke Zhang
When ol_flag is only RTE_MBUF_F_TX_IPV4, the Tx L3 checksum offload is still configured to IIPT in the command field of Tx data descriptor. This patch is to fix the issue to make the Tx L3 checksum offload flags and Tx data descriptor consistent. Fixes: 1e728b01120c ("net/iavf: rework Tx path") C

[PATCH 2/2] test/member: add functional and perf tests for sketch

2022-08-10 Thread Leyi Rong
This patch adds functional and performance tests for sketch mode of membership library. Signed-off-by: Yipeng Wang Signed-off-by: Leyi Rong --- app/test/test_member.c | 258 app/test/test_member_perf.c | 153 - 2 files changed, 407 i

[PATCH 1/2] member: implement NitroSketch mode

2022-08-10 Thread Leyi Rong
Sketching algorithm provide high-fidelity approximate measurements and appears as a promising alternative to traditional approches such as packet sampling. NitroSketch [1] is a software sketching framework that optimizes performance, provides accuracy guarantees, and supports a variety of sketches

[PATCH 0/2] introduce NitroSketch Mode into membership library

2022-08-10 Thread Leyi Rong
This patchset introduce a brand new NitroSketch Mode into membership library. This algorithm provides high-fidelity approximate measurements and appears as a promissing alternative to triditional approches such as packet sampling. Leyi Rong (2): member: implement NitroSketch mode test/member:

[PATCH] eventdev: add weight and affinity attributes to queue conf

2022-08-10 Thread Shijith Thotton
Added new fields to represent event queue weight and affinity in rte_event_queue_conf structure. Internal op to get queue attribute is removed as it is no longer needed. Updated driver to use the new field. Signed-off-by: Shijith Thotton --- doc/guides/rel_notes/deprecation.rst | 3 -- doc/gu

RE: [PATCH 3/4] timer: fix rte_timer_stop_all

2022-08-10 Thread Naga Harish K, S V
Hi, V2 of the patch is submitted with suggested changes in __rte_timer_stop() function. -Harish > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, August 3, 2022 11:19 PM > To: Naga Harish K, S V > Cc: Carrillo, Erik G ; dev@dpdk.org > Subject: Re: [PATCH 3/4] timer: f

[PATCH v2 3/4] timer: fix function to stop all timers

2022-08-10 Thread Naga Harish K S V
There is a possibility of deadlock in this API, as same spinlock is tried to be acquired in nested manner. In timer_del function, if the previous owner and current owner lcore are different, the lock is tried to be acquired even though the same lock is already acquired by the caller of timer_del f

[PATCH v2 2/4] event/sw: report periodic event timer capability

2022-08-10 Thread Naga Harish K S V
update the software eventdev pmd timer_adapter_caps_get callback function to report the support of periodic event timer capability Signed-off-by: Naga Harish K S V --- drivers/event/sw/sw_evdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/sw/sw_evdev.c b/dr

[PATCH v2 4/4] test/event: update periodic event timer tests

2022-08-10 Thread Naga Harish K S V
This patch updates the software timer adapter tests to configure and use periodic event timers. Signed-off-by: Naga Harish K S V --- app/test/test_event_timer_adapter.c | 41 ++--- 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/app/test/test_event_timer_ad

[PATCH v2 1/4] eventdev/timer: add periodic event timer support

2022-08-10 Thread Naga Harish K S V
This patch adds support to configure and use periodic event timers in software timer adapter. The structure ``rte_event_timer_adapter_stats`` is extended by adding a new field, ``evtim_drop_count``. This stat represents the number of times an event_timer expiry event is dropped by the event timer

[PATCH v2 3/4] timer: fix function to stop all timers

2022-08-10 Thread Naga Harish K S V
There is a possibility of deadlock in this API, as same spinlock is tried to be acquired in nested manner. In timer_del function, if the previous owner and current owner lcore are different, the lock is tried to be acquired even though the same lock is already acquired by the caller of timer_del f

[PATCH v2 2/4] event/sw: report periodic event timer capability

2022-08-10 Thread Naga Harish K S V
update the software eventdev pmd timer_adapter_caps_get callback function to report the support of periodic event timer capability Signed-off-by: Naga Harish K S V --- drivers/event/sw/sw_evdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/sw/sw_evdev.c b/dr

[PATCH v2 4/4] test/event: update periodic event timer tests

2022-08-10 Thread Naga Harish K S V
This patch updates the software timer adapter tests to configure and use periodic event timers. Signed-off-by: Naga Harish K S V --- app/test/test_event_timer_adapter.c | 41 ++--- 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/app/test/test_event_timer_ad

[PATCH v2 1/4] eventdev/timer: add periodic event timer support

2022-08-10 Thread Naga Harish K S V
This patch adds support to configure and use periodic event timers in software timer adapter. The structure ``rte_event_timer_adapter_stats`` is extended by adding a new field, ``evtim_drop_count``. This stat represents the number of times an event_timer expiry event is dropped by the event timer