[Bug 1013] [dpdk-22.07] unit_tests_eal/link_bonding_rssconf: link_bonding_rssconf_autotest test failed

2022-06-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1013 jiang,yu (yux.ji...@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

RE: af_xdp + libbpf 0.8

2022-06-23 Thread Loftus, Ciara
> > 24/06/2022 00:18, Ferruh Yigit: > > On 6/23/2022 10:58 PM, Thomas Monjalon wrote: > > > Hi, > > > > > > It seems DPDK is not compatible with libbpf 0.8: > > > > > > drivers/net/af_xdp/rte_eth_af_xdp.c:871:6: error: 'bpf_get_link_xdp_id' > is deprecated: libbpf v0.8+: use bpf_xdp_query_id() ins

[PATCH] net/af_xdp: limit libbpf version to <= v0.7.0

2022-06-23 Thread Ciara Loftus
Linking with libbpf v0.8.0 causes deprication warnings. As a temporary measure, prevent linking with libbpf versions v0.8.0 and greater. This limitation should be removed in the future when appropriate compatibility measures are introduced. Signed-off-by: Ciara Loftus --- doc/guides/nics/af_xdp.

[PATCH] vhost: fix sync dequeue offload

2022-06-23 Thread xuan . ding
From: Xuan Ding This patch fixes the missing virtio net header copy in sync dequeue path caused by refactoring, which affects dequeue offloading. Fixes: 6d823bb302c7("vhost: prepare sync for descriptor to mbuf refactoring") Signed-off-by: Xuan Ding --- lib/vhost/virtio_net.c | 14 +++-

[PATCH v3 12/12] net/nfp: add flower PF rxtx logic

2022-06-23 Thread Chaoyong He
This commit implements the flower Rx logic. Fallback packets are multiplexed to the correct representor port based on the prepended metadata. The Rx poll is set to run on the existing service infrastructure. For Tx the existing NFP Tx logic is duplicated to keep the Tx two paths distinct. Flower f

[PATCH v3 11/12] net/nfp: move rxtx function to header file

2022-06-23 Thread Chaoyong He
Flower makes use of the same Rx and Tx checksum logic as the normal PMD. Expose it so that flower can make use of it. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_common.c| 2 +- drivers/net/nfp/nfp_ethdev.c| 2 +- driv

[PATCH v3 10/12] net/nfp: add flower representor framework

2022-06-23 Thread Chaoyong He
This commit adds the framework to support flower representors. The number of VF representors are parsed from the command line. For physical port representors the current logic aims to create a representor for each physical port present on the hardware. A eth_dev is created for each phyport and VF,

[PATCH v3 09/12] net/nfp: add flower ctrl VNIC rxtx logic

2022-06-23 Thread Chaoyong He
Add a Rx and Tx function for the control vNIC. The logic is mostly identical to the normal Rx and Tx functionality of the NFP PMD. This commit also makes use of the ctrl vNIC service logic to service the ctrl vNIC Rx path. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Nik

[PATCH v3 08/12] net/nfp: move common rxtx function for flower use

2022-06-23 Thread Chaoyong He
This commit move some common Rx and Tx logic to the rxtx header file so that they can be re-used by flower tx and rx logic. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_rxtx.c | 32 +--- drivers/net/nf

[PATCH v3 07/12] net/nfp: add flower ctrl VNIC related logics

2022-06-23 Thread Chaoyong He
This commit adds the setup/start logic for the ctrl vNIC. This vNIC is used by the PMD and flower firmware as a communication channel between driver and firmware. In the case of OVS it is also used to communicate flow statistics from hardware to the driver. A rte_eth device is not exposed to DPDK

[PATCH v3 06/12] net/nfp: add flower PF related routines

2022-06-23 Thread Chaoyong He
This commit adds the start/stop/close routine of the flower PF vNIC. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 193 1 file changed, 193 insertions(+) diff --git a/drivers/net/nfp/flower/nfp_flower.c

[PATCH v3 05/12] net/nfp: add flower PF setup and mempool init logic

2022-06-23 Thread Chaoyong He
This commit adds the vNIC initialization logic for the flower PF vNIC. The flower firmware exposes this vNIC for the purposes of fallback traffic in the switchdev use-case. The logic of setting up this vNIC is similar to the logic seen in nfp_net_init() and nfp_net_start(). This commit also adds m

[PATCH v3 04/12] net/nfp: add initial flower firmware support

2022-06-23 Thread Chaoyong He
This commits adds the basic probing infrastructure to support the flower firmware. This firmware is geared towards offloading OVS and can generally be found in /lib/firmware/netronome/flower. It is also used by the NFP kernel driver when OVS offload with TC is desired. This commit also adds the ba

[PATCH v3 03/12] net/nfp: move app specific init logic to own function

2022-06-23 Thread Chaoyong He
The NFP card can load different firmware applications. This commit move the init logic of corenic app of the secondary process into its own function. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c | 93 +--- 1 fi

[PATCH v3 02/12] net/nfp: simplify initialization and remove dead code

2022-06-23 Thread Chaoyong He
Calling nfp_net_init() is only done for the corenic firmware flavor and it is guaranteed to always be called from the primary process, so the explicit check for RTE_PROC_PRIMARY can be dropped. The calling graph of nfp_net_init() already guaranteed the free of resources when it fail, so remove the

[PATCH v3 01/12] net/nfp: move app specific attributes to own struct

2022-06-23 Thread Chaoyong He
The NFP Card can load different firmware applications. Currently only the CoreNIC application is supported. This commit makes needed infrastructure changes in order to support other firmware applications too. Clearer separation is made between the PF device and any application specific concepts. T

[PATCH v3 00/12] preparation for the rte_flow offload of nfp PMD

2022-06-23 Thread Chaoyong He
This is the first patch series to add the support of rte_flow offload for nfp PMD, includes: Add the support of flower firmware Add the support of representor port Add the flower service infrastructure Add the cmsg interactive channels between pmd and fw * Changes since v2 - Remove the use of rte_

RE: [PATCH v4] lib/eal: fix segfaults due to thread exit order

2022-06-23 Thread Zeng, ZhichaoX
Hi David, Harman Please review this patch at your convenience, it's been about a month since the v1 version. Thanks! Best regards Zhichao > -Original Message- > From: Zeng, ZhichaoX > Sent: Wednesday, June 15, 2022 2:02 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming

Re: af_xdp + libbpf 0.8

2022-06-23 Thread Thomas Monjalon
24/06/2022 00:18, Ferruh Yigit: > On 6/23/2022 10:58 PM, Thomas Monjalon wrote: > > Hi, > > > > It seems DPDK is not compatible with libbpf 0.8: > > > > drivers/net/af_xdp/rte_eth_af_xdp.c:871:6: error: 'bpf_get_link_xdp_id' is > > deprecated: libbpf v0.8+: use bpf_xdp_query_id() instead > > /us

Re: af_xdp + libbpf 0.8

2022-06-23 Thread Ferruh Yigit
On 6/23/2022 10:58 PM, Thomas Monjalon wrote: Hi, It seems DPDK is not compatible with libbpf 0.8: drivers/net/af_xdp/rte_eth_af_xdp.c:871:6: error: 'bpf_get_link_xdp_id' is deprecated: libbpf v0.8+: use bpf_xdp_query_id() instead /usr/include/bpf/libbpf.h:1168:1: note: 'bpf_get_link_xdp_id' h

af_xdp + libbpf 0.8

2022-06-23 Thread Thomas Monjalon
Hi, It seems DPDK is not compatible with libbpf 0.8: drivers/net/af_xdp/rte_eth_af_xdp.c:871:6: error: 'bpf_get_link_xdp_id' is deprecated: libbpf v0.8+: use bpf_xdp_query_id() instead /usr/include/bpf/libbpf.h:1168:1: note: 'bpf_get_link_xdp_id' has been explicitly marked deprecated here LIBBP

Re: [PATCH v7] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-06-23 Thread David Marchand
On Thu, Jun 23, 2022 at 1:21 PM Don Wallwork wrote: > > Add support for using hugepages for worker lcore stack memory. The > intent is to improve performance by reducing stack memory related TLB > misses and also by using memory local to the NUMA node of each lcore. > > EAL option '--huge-worker-

RE: [RFC PATCH 0/6] add json string escaping to telemetry

2022-06-23 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 23 June 2022 18.43 > > This RFC shows one possible approach for escaping strings for the json > output of telemetry library. For now this RFC supports escaping strings > for the cases of returning a single string, or re

RE: [RFC PATCH 2/6] telemetry: fix escaping of invalid json characters

2022-06-23 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 23 June 2022 20.40 > > On Thu, 23 Jun 2022 20:34:07 +0200 > Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Thursday, 23 June 2022 18.43 > > > > > > For string valu

Re: [RFC PATCH 2/6] telemetry: fix escaping of invalid json characters

2022-06-23 Thread Stephen Hemminger
On Thu, 23 Jun 2022 20:34:07 +0200 Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Thursday, 23 June 2022 18.43 > > > > For string values returned from telemetry, escape any values that > > cannot > > normally appear in a json string. According to th

RE: [RFC PATCH 2/6] telemetry: fix escaping of invalid json characters

2022-06-23 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 23 June 2022 18.43 > > For string values returned from telemetry, escape any values that > cannot > normally appear in a json string. According to the json spec[1], the > characters than need to be handled are control c

[PATCH v4] app/test: add additional stream cipher tests

2022-06-23 Thread Tejasree Kondoj
Adding zuc, snow3g and aes-ctr-cmac auth-cipher test vectors with same auth and cipher offsets and total digest data encrypted. Existing tests have different cipher and auth offsets and partial or no digest encrypted. Signed-off-by: Tejasree Kondoj --- v4: * Set last 3 bytes of IV to zero in each

Re: [PATCH v2 1/5] telemetry: escape special char when tel string

2022-06-23 Thread Bruce Richardson
On Wed, Jun 22, 2022 at 10:19:48AM +0100, Bruce Richardson wrote: > On Wed, Jun 22, 2022 at 08:57:43AM +0100, Power, Ciara wrote: > > Hi folks, > > > > > -Original Message- > > > From: Morten Brørup > > > Sent: Saturday 18 June 2022 10:59 > > > To: fengchengwen ; Stephen Hemminger > > > ;

[RFC PATCH 6/6] test/telemetry-json: add test case for escaping strings in arrays

2022-06-23 Thread Bruce Richardson
Add test-case to validate that when adding strings to arrays, the strings are properly escaped to remove any invalid characters. Signed-off-by: Bruce Richardson --- app/test/test_telemetry_json.c | 24 1 file changed, 24 insertions(+) diff --git a/app/test/test_telemetr

[RFC PATCH 5/6] telemetry: add escaping of strings in arrays

2022-06-23 Thread Bruce Richardson
When strings are added to an array variable, we need to properly escape the invalid json characters in the strings. Signed-off-by: Bruce Richardson --- lib/telemetry/telemetry_json.h | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/lib/telemetry/t

[RFC PATCH 4/6] test/telemetry_json: add test for string character escaping

2022-06-23 Thread Bruce Richardson
Add unit test to validate that when creating a string response in json, that characters such as \n or quotes are properly escaped. Signed-off-by: Bruce Richardson --- app/test/test_telemetry_json.c | 17 + 1 file changed, 17 insertions(+) diff --git a/app/test/test_telemetry_jso

[RFC PATCH 3/6] telemetry: use json string function for string outputs

2022-06-23 Thread Bruce Richardson
When returning just a string in response to a query, use the proper json string printing function to escape characters rather than just snprintf. Signed-off-by: Bruce Richardson --- lib/telemetry/telemetry.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/tele

[RFC PATCH 2/6] telemetry: fix escaping of invalid json characters

2022-06-23 Thread Bruce Richardson
For string values returned from telemetry, escape any values that cannot normally appear in a json string. According to the json spec[1], the characters than need to be handled are control chars (char value < 0x20) and '"' and '\' characters. To handle this, we replace the snprintf call with a sep

[RFC PATCH 1/6] test/telemetry_json: print success or failure per subtest

2022-06-23 Thread Bruce Richardson
rather than just printing out success or failure at the end of the test only, print out "OK" or "ERROR" for each individual test case within the overall test. As part of this, ensure each case returns 0 on success and any other value on failure. Signed-off-by: Bruce Richardson --- app/test/test_

[RFC PATCH 0/6] add json string escaping to telemetry

2022-06-23 Thread Bruce Richardson
This RFC shows one possible approach for escaping strings for the json output of telemetry library. For now this RFC supports escaping strings for the cases of returning a single string, or returning an array of strings. Not done is escaping of strings in objs/dicts [see more below on TODO] As wel

Re: [PATCH v1] bbdev: allow operation type enum for growth

2022-06-23 Thread Ray Kinsella
Thomas Monjalon writes: > This solution is what I proposed to the techboard some years ago, > but the preference was to completely remove the MAX values. I am mindful we don't have an explicit guidance in the documentation. I am including to add something to the abi_versioning document, that

Re: [PATCH v10 2/6] common/mlx5: share interrupt management

2022-06-23 Thread Ray Kinsella
Spike Du writes: > There are many duplicate code of creating and initializing rte_intr_handle. > Add a new mlx5_os API to do this, replace all PMD related code with this > API. > > Signed-off-by: Spike Du > Acked-by: Matan Azard > --- > drivers/common/mlx5/linux/mlx5_common_os.c | 131

Re: [PATCH 03/12] common/cnxk: add PFC support for VFs

2022-06-23 Thread Ray Kinsella
Nithin Dabilpuram writes: > From: Sunil Kumar Kori > > Current PFC implementation does not support VFs. > Patch enables PFC on VFs too. > > Also fix the config of aura.bp to be based on number > of buffers(aura.limit) and corresponding shift > value(aura.shift). > Fixes: cb4bfd6e7bdf ("event/c

Re: [PATCH v8 1/4] ethdev: support device error recovery notification

2022-06-23 Thread Ray Kinsella
Chengwen Feng writes: > From: Kalesh AP > > Some PMDs (e.g. hns3) could detect hardware or firmware errors, and try > to recover from the errors. In this process, the PMD sets the data path > pointers to dummy functions (which will prevent the crash), and also > make sure the control path oper

RE: [PATCH] eventdev/eth_tx: fix queue delete

2022-06-23 Thread Jayatheerthan, Jay
Looks good to me. Acked-by: Jay Jayatheerthan -Jay > -Original Message- > From: Naga Harish K, S V > Sent: Thursday, June 23, 2022 3:35 PM > To: Jayatheerthan, Jay ; jer...@marvell.com > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] eventdev/eth_tx: fix queue delete > > Add s

[PATCH 2/2] test/crypto: fix snow3g test vector IV format

2022-06-23 Thread Ciara Power
Some of the cipher and authentication IVs did not follow the spec for SNOW3G algorithm [1]. Cipher IVs must have the last 3 bytes of each 8 byte block as 0x0. IV[4] and IV[12] must have the last 2 bits set to 0. Each 8 byte block is repeated. Auth IVs must also have a repeated 8 byte block. IV[8]

[PATCH 1/2] test/crypto: fix zuc test vector IV format

2022-06-23 Thread Ciara Power
Some authentication and cipher IV formats were not following the spec [1]. For ZUC128 cipher IV, an 8 byte block is repeated, with the last 3 bytes of each being 0x0. IV[4] and IV[12] must have the last 2 bits set to 0. Auth IVs must also have repeated bytes with the last 3 bytes containing 0x0 i

[PATCH 0/2] fix wireless algorithm IVs

2022-06-23 Thread Ciara Power
Some of the ZUC and Snow3G test vectors did not follow the specification for the cipher and authentication IVs. These are now updated to follow the spec documents: ZUC 128 spec: https://www.gsma.com/security/wp-content/uploads/2019/05/EEA3_EIA3_specification_v1_8.pdf Snow3G spec: https://www.gsm

[PATCH] test/crypto: fix authentication IV for zuc SGL

2022-06-23 Thread Ciara Power
The wireless operation for ZUC SGL tests was being passed NULL instead of a pointer to the test data authentication IV, and IV length 0. This is now corrected to use the IV from the test data. Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP") Cc: sta...@dpdk.org Signed-

Re: [PATCH] ip_frag: replace the rte memcpy with memcpy

2022-06-23 Thread David Marchand
On Sat, Jun 18, 2022 at 4:10 PM Huichao Cai wrote: > > To resolve the compilation warning,replace the rte_memcpy with memcpy. > Modify in file test_ipfrag.c and rte_ipv4_fragmentation.c. > These warnings appeared with: Fixes: b50a14a853aa ("ip_frag: add IPv4 options fragment") > Signed-off-by: H

Re: [PATCH] ip_frag: replace the rte memcpy with memcpy

2022-06-23 Thread David Marchand
On Thu, Jun 23, 2022 at 4:35 AM Stephen Hemminger wrote: > On Wed, 22 Jun 2022 23:49:39 +0100 > Konstantin Ananyev wrote: > > > > @@ -26,7 +25,7 @@ static inline void __fill_ipv4hdr_frag(struct > > > rte_ipv4_hdr *dst, > > > const struct rte_ipv4_hdr *src, uint16_t header_len, > > >

Re: [RFC 2/8] net/qede: fix gcc-12 rte_memcpy warnings

2022-06-23 Thread David Marchand
On Tue, Jun 7, 2022 at 7:18 PM Stephen Hemminger wrote: > > The x86 version of rte_memcpy can cause warnings. The driver does > not need to use rte_memcpy for everything. Standard memcpy is > just as fast and safer; the compiler and static analysis tools > treat memcpy specially. Cc: sta...@dpdk.

[PATCH v2] doc/prog_guide: fix readability in lib vhost prog guide

2022-06-23 Thread Herakliusz Lipiec
fix grammar issues and readbility in vhost library programmer guide Fixes: 768274ebbd5e ("vhost: avoid populate guest memory") Cc: sta...@dpdk.org Signed-off-by: Herakliusz Lipiec --- doc/guides/prog_guide/vhost_lib.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) d

[PATCH 3/3] dma/idxd: fix non-AVX builds with older compilers

2022-06-23 Thread Bruce Richardson
When building without AVX2 support using an older compiler e.g. gcc 4.8 on Centos/RHEL 7, we get build errors due to the use of AVX2 intrinsics. This is because the compiler does not support "__attribute__((target(AVX2)))" function attribute. Disable build of this driver such edge cases. Generic b

[PATCH 2/3] raw/ioat: fix build when ioat dmadev enabled

2022-06-23 Thread Bruce Richardson
The build of the raw/ioat driver only occurs when the equivalent dmadev drivers are disabled. Complications occur when the ioat dmadev is being built but not the idxd. In this case, only the idxd part of raw/ioat gets built, but the definition of the logtype is in the ioat part, causing build error

[PATCH 1/3] raw/ioat: fix build error for missing errno

2022-06-23 Thread Bruce Richardson
The inline functions in rte_idxd_rawdev_fns.h make use of rte_errno, but the header with its definition is not included by that file leading to build errors. Fixes: f82c87eb14a4 ("raw/ioat: move idxd functions to separate file") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- drivers/ra

[PATCH 0/3] fix misc dma driver build errors

2022-06-23 Thread Bruce Richardson
The use of function attributes to enable AVX2 on idxd builds is not supported by older compilers, so we need additional checks in the dma/idxd driver to disable that in cases where it is not buildable. This fix revealed further issues with the older rawdev driver, which only gets build when the dm

[PATCH v3] app/test: add additional stream cipher tests

2022-06-23 Thread Tejasree Kondoj
Adding zuc, snow3g and aes-ctr-cmac auth-cipher test vectors with same auth and cipher offsets and total digest data encrypted. Existing tests have different cipher and auth offsets and partial or no digest encrypted. Signed-off-by: Tejasree Kondoj --- v3: * Modified IV of test vectors as per spe

RE: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch

2022-06-23 Thread Ashwin Sekhar Thalakalath Kottilveetil
Hi Fan, I will make the changes as you suggested. Regards, Ashwin Sekhar T K > -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, June 23, 2022 2:23 PM > To: Ashwin Sekhar Thalakalath Kottilveetil ; > dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori > ; Satha Ko

Re: [PATCH v5] net/ice: support dump DDP runtime configure

2022-06-23 Thread Thomas Monjalon
23/06/2022 15:10, Thomas Monjalon: > > > Signed-off-by: Steve Yang > > > > Acked-by: Qi Zhang > > > > Applied to dpdk-next-net-intel. > > Please run devtools/check-meson.py > These are the misses: > Error: Missing trailing "," in list at drivers/net/ice/meson.build:16 > and in another patch: >

Re: [PATCH v5] net/ice: support dump DDP runtime configure

2022-06-23 Thread Thomas Monjalon
> > Signed-off-by: Steve Yang > > Acked-by: Qi Zhang > > Applied to dpdk-next-net-intel. Please run devtools/check-meson.py These are the misses: Error: Missing trailing "," in list at drivers/net/ice/meson.build:16 and in another patch: Error parsing drivers/net/iavf/meson.build:68, got some

RE: [PATCH v5 1/1] app/testpmd: support different input color method

2022-06-23 Thread Sunil Kumar Kori
@Andrew Rybchenko Please look into it. Updated user guide as suggested. Regards Sunil Kumar Kori > -Original Message- > From: sk...@marvell.com > Sent: Thursday, June 23, 2022 6:27 PM > To: Xiaoyun Li ; Aman Singh > ; Yuying Zhang ; > Cristian Dumitrescu > Cc: dev@dpdk.org; Sunil Kumar

[PATCH v5 1/1] app/testpmd: support different input color method

2022-06-23 Thread skori
From: Sunil Kumar Kori To enable input coloring, based on VLAN or DSCP, patch adds command line interface to configure the following: - configuring input coloring using VLAN or DSCP while creating meter i.e. during rte_mtr_create() - Update VLAN input coloring table at runtime. - configu

RE: [EXT] Re: [PATCH v4 1/1] app/testpmd: support different input color method

2022-06-23 Thread Sunil Kumar Kori
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, June 23, 2022 4:36 PM > To: Sunil Kumar Kori ; Xiaoyun Li > ; Aman Singh ; Yuying > Zhang ; Cristian Dumitrescu > > Cc: dev@dpdk.org > Subject: [EXT] Re: [PATCH v4 1/1] app/testpmd: support different input color > method > >

RE: [PATCH v4] net: fix checksum with unaligned buffer

2022-06-23 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Thursday, 23 June 2022 14.39 > > With this patch, the checksum can be calculated on an unaligned buffer. > I.e. the buf parameter is no longer required to be 16 bit aligned. > > The checksum is still calculated using a 16 bit align

[PATCH v4] net: fix checksum with unaligned buffer

2022-06-23 Thread Morten Brørup
With this patch, the checksum can be calculated on an unaligned buffer. I.e. the buf parameter is no longer required to be 16 bit aligned. The checksum is still calculated using a 16 bit aligned pointer, so the compiler can auto-vectorize the function's inner loop. When the buffer is unaligned, t

Re: [PATCH v2 12/12] net/nfp: add flower PF rxtx logic

2022-06-23 Thread Andrew Rybchenko
On 6/21/22 13:33, Chaoyong He wrote: This commit implements the flower Rx logic. Fallback packets are multiplexed to the correct representor port based on the prepended metadata. The Rx poll is set to run on the existing service infrastructure. For Tx the existing NFP Tx logic is duplicated to k

Re: [PATCH v2 09/12] net/nfp: add flower ctrl VNIC rxtx logic

2022-06-23 Thread Andrew Rybchenko
On 6/21/22 13:33, Chaoyong He wrote: Add a Rx and Tx function for the control vNIC. The logic is mostly identical to the normal Rx and Tx functionality of the NFP PMD. This commit also makes use of the ctrl vNIC service logic to service the ctrl vNIC Rx path. Signed-off-by: Chaoyong He Signed-

RE: [PATCH v2 3/3] net/ixgbe: move bypass init in a testpmd command

2022-06-23 Thread Zhang, Qi Z
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, June 21, 2022 3:04 AM > To: Yang, Qiming ; Wu, Wenjun1 > ; Jiang, YuX > Cc: Li, Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying ; > dev@dpdk.org; David Marchand ; Zhang, Qi Z > > Subject: Re: [PATCH v2 3/3] net/ixgbe: move bypass

RE: [PATCH] net: fix checksum with unaligned buffer

2022-06-23 Thread Morten Brørup
> From: Emil Berg [mailto:emil.b...@ericsson.com] > Sent: Thursday, 23 June 2022 13.39 > > > From: Morten Brørup > > Sent: den 23 juni 2022 09:01 > > > > > From: Emil Berg [mailto:emil.b...@ericsson.com] > > > Sent: Thursday, 23 June 2022 07.22 > > > > > > > From: Morten Brørup > > > > Sent: den

Re: [PATCH] app/testpmd: fix secondary process cannot dump packet

2022-06-23 Thread Andrew Rybchenko
On 6/23/22 21:15, peng1x.zh...@intel.com wrote: From: Peng Zhang The origin design is whether testpmd is primary or not, if state of receive queue is stop, then packets will not be dumped for show. While to secondary process, receive queue will not be set up, and state will still be stop even i

Re: [PATCH v2 1/2] net: fix GTP PSC headers

2022-06-23 Thread Andrew Rybchenko
On 6/23/22 14:38, Andrew Rybchenko wrote: On 6/21/22 16:45, Singh, Aman Deep wrote: On 6/16/2022 11:31 PM, Gregory Etelson wrote: Fix bitmap fields order in little endian section of GTP PSC headers. Fixes: e8ca1479cdc4 ("net: add extension header for GTP PSC") cc: sta...@dpdk.org Signed-off-b

Re: [PATCH] vdpa/mlx5: add ConnectX-6 LX device ID

2022-06-23 Thread Maxime Coquelin
On 6/23/22 11:00, Wisam Jaddo wrote: This adds ConnectX-6 LX to the list of supported Mellanox devices that run the MLX5 vdpa PMD. Signed-off-by: Wisam Jaddo --- drivers/vdpa/mlx5/mlx5_vdpa.c | 4 1 file changed, 4 insertions(+) Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH v2 1/2] net: fix GTP PSC headers

2022-06-23 Thread Andrew Rybchenko
On 6/21/22 16:45, Singh, Aman Deep wrote: On 6/16/2022 11:31 PM, Gregory Etelson wrote: Fix bitmap fields order in little endian section of GTP PSC headers. Fixes: e8ca1479cdc4 ("net: add extension header for GTP PSC") cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Reviewed-by: Viacheslav

Re: [PATCH v2] app/testpmd: fix flex parser destroy command

2022-06-23 Thread Andrew Rybchenko
On 6/16/22 12:15, Gregory Etelson wrote: The patch separates flex item destruction function implementation. Setups with installed JSON development library can use any value in range [0, FLEX_MAX_PARSERS_NUM - 1] as input flex item ID. In setups without JSON development library flex item destructi

[PATCH v7] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-06-23 Thread Don Wallwork
Add support for using hugepages for worker lcore stack memory. The intent is to improve performance by reducing stack memory related TLB misses and also by using memory local to the NUMA node of each lcore. EAL option '--huge-worker-stack [stack-size-in-kbytes]' is added to allow the feature to b

RE: [PATCH v2] test/ipsec: fix performance test failure

2022-06-23 Thread Jiang, YuX
> -Original Message- > From: Vladimir Medvedkin > Sent: Tuesday, June 21, 2022 9:31 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; sta...@dpdk.org; Konstantin Ananyev > ; Iremonger, Bernard > > Subject: [PATCH v2] test/ipsec: fix performance test failure > > This patch initializes with

Re: [PATCH] app/testpmd: cleanup port resources after implicit close

2022-06-23 Thread Andrew Rybchenko
On 6/16/22 02:12, Dmitry Kozlyuk wrote: When a port was closed implicitly closed by the PMD, for example, if it was a representor port and its master port was detached, flow indirect actions could remain with their handles no longer valid. If a newly attached device was assigned the same ID as th

RE: [EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets count

2022-06-23 Thread Rahul Bhansali
Ping. > -Original Message- > From: Jerin Jacob > Sent: Thursday, June 2, 2022 1:19 PM > To: Rahul Bhansali > Cc: dpdk-dev ; Bruce Richardson > ; Thomas Monjalon ; > Ferruh Yigit ; Ajit Khaparde > ; Andrew Boyer ; > Andrew Rybchenko ; Beilei Xing > ; Chas Williams ; Xia, Chenbo > ; Ciara

Re: [PATCH v4 1/1] app/testpmd: support different input color method

2022-06-23 Thread Andrew Rybchenko
On 6/14/22 13:05, sk...@marvell.com wrote: From: Sunil Kumar Kori To enable input coloring, based on VLAN or DSCP, patch adds command line interface to configure the following: - configuring input coloring using VLAN or DSCP while creating meter i.e. during rte_mtr_create() - Update V

Re: [PATCH v2] net/af_xdp: allow using copy mode in XSK

2022-06-23 Thread Andrew Rybchenko
On 6/14/22 12:10, Xiaoyun Li wrote: DPDK assumes that users only want AF_XDP socket (XSK) into zero copy mode when the kernel supports it. However, sometimes kernel driver doesn't support it well and copy mode is more stable and preferred. This patch allows using devarg "-a xx:xx.x,force_copy=1"

[PATCH] eventdev/eth_tx: fix queue delete

2022-06-23 Thread Naga Harish K S V
Add spinlock protection in queue delete function. This protects the data path while the queue delete operation is in progress. Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") Cc: sta...@dpdk.org Signed-off-by: Naga Harish K S V --- lib/eventdev/rte_event_eth_tx_adapter.c | 6

[PATCH] app/testpmd: fix secondary process cannot dump packet

2022-06-23 Thread peng1x . zhang
From: Peng Zhang The origin design is whether testpmd is primary or not, if state of receive queue is stop, then packets will not be dumped for show. While to secondary process, receive queue will not be set up, and state will still be stop even if testpmd is started. So packets of stated seconda

[PATCH v3 2/2] examples/ipsec-secgw: add support of NEON with poll mode

2022-06-23 Thread Rahul Bhansali
This adds the support of NEON based lpm lookup along with multi packet processing for burst send in packets routing. Performance impact: On cn10k, with poll mode inline protocol, outbound performance increased by ~8% and inbound performance increased by ~6%. Signed-off-by: Rahul Bhansali Acked-b

[PATCH v3 1/2] examples/l3fwd: common packet group functionality

2022-06-23 Thread Rahul Bhansali
This will make the packet grouping function common, so that other examples can utilize as per need. For each architecture sse/neon/altivec, port group headers will be created under examples/common/. Signed-off-by: Rahul Bhansali --- Changes in v3: Created common port-group headers for architectu

RE: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON with poll mode

2022-06-23 Thread Rahul Bhansali
> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, June 23, 2022 2:17 PM > To: Rahul Bhansali ; dev@dpdk.org; Nicolau, Radu > ; Akhil Goyal ; Ruifeng Wang > > Cc: Jerin Jacob Kollanukkaran > Subject: [EXT] RE: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON > with

[PATCH v10 7/7] doc/eth_tx: update instance get API

2022-06-23 Thread Ganapati Kundapura
Added rte_event_eth_tx_adapter_instance_get() details. Signed-off-by: Ganapati Kundapura Reviewed-by: Naga Harish K S V Acked-by: Jay Jayatheerthan --- doc/guides/prog_guide/event_ethernet_tx_adapter.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/prog_guide/event_eth

[PATCH v10 6/7] doc/eth_rx: update instance get API

2022-06-23 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() details Signed-off-by: Ganapati Kundapura Reviewed-by: Naga Harish K S V Acked-by: Jay Jayatheerthan --- doc/guides/prog_guide/event_ethernet_rx_adapter.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/prog_guide/event_ethe

[PATCH v10 5/7] test/eth_tx: add testcase for instance get API

2022-06-23 Thread Ganapati Kundapura
Added testcase for rte_event_eth_tx_adapter_instance_get() Signed-off-by: Ganapati Kundapura Reviewed-by: Naga Harish K S V Acked-by: Jay Jayatheerthan --- app/test/test_event_eth_tx_adapter.c | 75 1 file changed, 75 insertions(+) diff --git a/app/test/t

[PATCH v10 4/7] eventdev/eth_tx: add instance get API

2022-06-23 Thread Ganapati Kundapura
Added rte_event_eth_tx_adapter_instance_get() to get the adapter instance id for specified ethernet device id and tx queue index. Signed-off-by: Ganapati Kundapura Reviewed-by: Naga Harish K S V Acked-by: Jay Jayatheerthan --- lib/eventdev/eventdev_pmd.h | 23 +++ lib/eventde

[PATCH v10 3/7] test/eth_rx: add test case for instance get API

2022-06-23 Thread Ganapati Kundapura
Added test case for rte_event_eth_rx_adapter_instance_get() Signed-off-by: Ganapati Kundapura Reviewed-by: Naga Harish K S V Acked-by: Jay Jayatheerthan --- app/test/test_event_eth_rx_adapter.c | 203 ++- 1 file changed, 202 insertions(+), 1 deletion(-) diff -

[PATCH v10 2/7] eventdev/eth_rx: add telemetry callback for instance get

2022-06-23 Thread Ganapati Kundapura
Added telemetry handler for rte_event_eth_rx_adapter_instance_get() to retrieve adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura Reviewed-by: Naga Harish K S V Acked-by: Jay Jayatheerthan --- lib/eventdev/rte_event_eth_rx_adapter.c | 6

[PATCH v10 1/7] eventdev/eth_rx: add adapter instance get API

2022-06-23 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() to get adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura Reviewed-by: Naga Harish K S V Acked-by: Jay Jayatheerthan --- v10: * Add Review and Ack to series v9: * Corrected rte_event_eth_tx_a

DPDK Release Status Meeting 2022-06-23

2022-06-23 Thread Mcnamara, John
Release status meeting minutes 2022-06-23 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Intel * Marvell * Nvidia * Red Hat * Xilinx/AMD Release Dates - The following are the proposed current dat

RE: [PATCH v2] net/ice/base: fix gcc 12 warning stringop-overflow

2022-06-23 Thread Zhang, Qi Z
> -Original Message- > From: Wu, WenxuanX > Sent: Thursday, June 23, 2022 5:01 PM > To: dev@dpdk.org; tho...@monjalon.net; Yang, Qiming > ; Zhang, Qi Z > Cc: step...@networkplumber.org; Wu, WenxuanX > ; Zhou, YidingX ; > sta...@dpdk.org > Subject: [PATCH v2] net/ice/base: fix gcc 12 wa

RE: [PATCH 1/3] vdpa/mlx5: remove unnecessary null check

2022-06-23 Thread Matan Azrad
From: Stephen Hemminger > Found by nullfree.cocci. > > Signed-off-by: Stephen Hemminger Acked-by: Matan Azrad

Re: [PATCH v4 00/13] Add support of NFP3800 chip and firmware with NFDk

2022-06-23 Thread Ferruh Yigit
On 6/23/2022 3:26 AM, Jin Liu wrote: NFD is part of NFP firmware, and there only exist a NFD3 version before this patch series. This patch series mainly add the support of the new NFP3800 chip use firmware with NFD3/NFDk. * Changes since v1 - Added updated documentation for NFP to cover NFD

[PATCH v2] net/ice/base: fix gcc 12 warning stringop-overflow

2022-06-23 Thread wenxuanx . wu
From: Wenxuan Wu gcc 12 with -O2 flag would raise the following warning: ../drivers/net/ice/base/ice_switch.c:7220:61: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=] 7220 | buf[recps].content.lkup_indx[i + 1] = entry->fv_idx[i]; | ~~~

[PATCH] vdpa/mlx5: add ConnectX-6 LX device ID

2022-06-23 Thread Wisam Jaddo
This adds ConnectX-6 LX to the list of supported Mellanox devices that run the MLX5 vdpa PMD. Signed-off-by: Wisam Jaddo --- drivers/vdpa/mlx5/mlx5_vdpa.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c index 76fa5d4299..c28d6

RE: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch

2022-06-23 Thread Zhang, Roy Fan
Hi, Yes you are right - Maybe with this way? #if defined(RTE_ARCH_ARM64) vector_mode = IPSEC_MB_ARM64; #elif defined(RTE_ARCH_X86_64) if (vector_mode == IPSEC_MB_NOT_SUPPORTED) { /* Check CPU for supported vector instruction set */ if (rte

RE: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON with poll mode

2022-06-23 Thread Zhang, Roy Fan
Hi Rahul > -Original Message- > From: Rahul Bhansali > Sent: Friday, June 17, 2022 8:43 AM > To: dev@dpdk.org; Nicolau, Radu ; Akhil Goyal > ; Ruifeng Wang > Cc: jer...@marvell.com; Rahul Bhansali > Subject: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON with poll > mode > >

RE: [PATCH 1/2] rawdev, dmadev: remove passive voice in function doc

2022-06-23 Thread Walsh, Conor
> Remove extraneous phrase "This API is used to" and use > active instead of passive voice when describing a function. > > Signed-off-by: Stephen Hemminger > --- > drivers/raw/ioat/rte_ioat_rawdev.h | 2 +- > lib/dmadev/rte_dmadev.h| 2 +- > 2 files changed, 2 insertions(+), 2 deleti

RE: [dpdk-dev] [PATCH v5] examples/ipsec-secgw: support more flow patterns and actions

2022-06-23 Thread Zhang, Roy Fan
> -Original Message- > From: psathe...@marvell.com > Sent: Wednesday, June 22, 2022 2:22 AM > To: Nicolau, Radu ; Akhil Goyal > Cc: dev@dpdk.org; Satheesh Paul > Subject: [dpdk-dev] [PATCH v5] examples/ipsec-secgw: support more flow > patterns and actions > > From: Satheesh Paul > > A

Re: [PATCH 0/2] fix C++ include checks in cross-compilation

2022-06-23 Thread David Marchand
On Tue, Jun 21, 2022 at 2:28 PM Stanislaw Kardach wrote: > > Meson detects the C++ cross-compiler during configuration and based on > that reports whether C++ language is available or not. > The C++ include check target (buildtools/chkincs/chkincs-cpp) is only > built when C++ language is availabl

Re: [PATCH 2/2] ci: use crossbuild-essential packages

2022-06-23 Thread David Marchand
On Tue, Jun 21, 2022 at 2:28 PM Stanislaw Kardach wrote: > > The crossbuild-essential- packages contain all necessary > dependencies to cross-compile binaries for a given architecture > including C and C++ compilers. Therefore use those instead of listing > packages directly. This way C++ compiler

  1   2   >