RE: [PATCH v4] raw/afu_mf: introduce AFU MF device driver

2022-05-25 Thread Xu, Rosen
Hi Wei, A huge patch, can you split it into several patches? Thanks, Rosen > -Original Message- > From: Huang, Wei > Sent: Thursday, May 19, 2022 13:53 > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfe

RE: [PATCH v3 5/5] guides/rawdevs: add description of ofs in ifpga doc

2022-05-25 Thread Xu, Rosen
Hi Wei, > -Original Message- > From: Huang, Wei > Sent: Thursday, May 26, 2022 11:33 > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 5/5] guides/ra

RE: [PATCH v3 4/5] raw/ifpga: support ofs card probe

2022-05-25 Thread Xu, Rosen
Hi Wei, Pls close compile warnings. Thanks a lot. Thanks, Rosen > -Original Message- > From: Huang, Wei > Sent: Thursday, May 26, 2022 11:33 > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang

RE: [EXT] [v6, 00/11] Add JSON vector set support to fips validation

2022-05-25 Thread Akhil Goyal
> Adds a very basic introduction to JSON vector sets in > the fips validation example application. This patch set > will only introduce the AES-GCM test using a JSON request > file because the other algorithms need more information > than what is given in the new JSON format. > > v6: > * CI centos

RE: [PATCH v3 3/5] raw/ifpga: unregister interrupt in ifpga close function

2022-05-25 Thread Xu, Rosen
Hi Wei, It's a little bit hard to find the connections between functions you changed and raw API. Could you add more explanations about the Function Call in the functions you mentioned below? Thanks, Rosen > -Original Message- > From: Huang, Wei > Sent: Thursday, May 26, 2022 11:33 >

RE: [PATCH v3 2/5] raw/ifpga: remove vdev when ifpga is closed

2022-05-25 Thread Xu, Rosen
Hi Wei, My comments. Thanks, Rosen > -Original Message- > From: Huang, Wei > Sent: Thursday, May 26, 2022 11:33 > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subje

Re: [PATCH v3 1/2] eal: get/set thread priority per thread identifier

2022-05-25 Thread Tyler Retzlaff
On Tue, May 24, 2022 at 07:51:05AM -0700, Stephen Hemminger wrote: > On Tue, 24 May 2022 04:08:36 -0700 > Tyler Retzlaff wrote: > > > +static int > > +thread_map_priority_to_os_value(enum rte_thread_priority eal_pri, > > + int *os_pri, int *pol) > > +{ > > + /* Clear the output parame

RE: [PATCH v3 1/5] raw/ifpga: remove experimental tag from ifpga APIs

2022-05-25 Thread Xu, Rosen
Hi Wei, > -Original Message- > From: Huang, Wei > Sent: Thursday, May 26, 2022 11:33 > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 1/5] raw/ifpga

Re: [PATCH v1] bbdev: add new operation for FFT processing

2022-05-25 Thread Hemant Agrawal
On 5/26/2022 3:37 AM, Chautru, Nicolas wrote: Hi Hernant, Gentle reminder in case you can find the time. Could please have a look this patch for bbdev api extension. This is targeting 22.11. New operation type for FFT processing (On top of 4 existing operations types). There is no impact to t

Re: [PATCH v3 0/6] move DPAA2 QDMA driver freom raw to dma

2022-05-25 Thread Hemant Agrawal
Acked-by:  Hemant Agrawal On 5/5/2022 2:35 PM, nipun.gu...@nxp.com wrote: From: Nipun Gupta This change removes the DPAA2 QDMA raw driver and adds the QDMA driver in dma set of drivers. The underlying I/O framework remains intact, whereas the configuration part is done as per the DMA API supp

[PATCH v3 5/5] guides/rawdevs: add description of ofs in ifpga doc

2022-05-25 Thread Wei Huang
OFS (Open FPGA Stack) specification is introduced briefly. Signed-off-by: Wei Huang --- doc/guides/rawdevs/ifpga.rst | 114 ++- 1 file changed, 113 insertions(+), 1 deletion(-) diff --git a/doc/guides/rawdevs/ifpga.rst b/doc/guides/rawdevs/ifpga.rst index

[PATCH v3 4/5] raw/ifpga: support ofs card probe

2022-05-25 Thread Wei Huang
PAC N6000 is the first OFS platform, its device id is added to ifpga device support list. Previous FPGA platform like Intel PAC N3000 and N5000, FME DFL (Device Feature List) starts from BAR0 by default, port DFL location is indicated in PORTn_OFFSET register in FME. In OFS implementation, FME DFL

[PATCH v3 3/5] raw/ifpga: unregister interrupt in ifpga close function

2022-05-25 Thread Wei Huang
In original implementation, interrupts are unregistered in ifpga_rawdev_destroy function. If application want to release the ifpga driver resource by calling rte_rawdev_pmd_release, interrupt resource will not be released. Now interrupt unregistration is moved from ifpga destroy function to ifpga c

[PATCH v3 2/5] raw/ifpga: remove vdev when ifpga is closed

2022-05-25 Thread Wei Huang
Virtual devices created on ifpga raw device will not be removed when ifpga device has closed. To avoid resource leak problem, this patch introduces an ifpga virtual device remove function, virtual devices will be destroyed after the ifpga raw device closed. Fixes: ef1e8ede3da5 ("raw/ifpga: add Int

[PATCH v3 1/5] raw/ifpga: remove experimental tag from ifpga APIs

2022-05-25 Thread Wei Huang
These APIs are introduced in DPDK 21.05 and have been tested in several release, experimental tag can be formally removed. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang --- drivers/raw/ifpga/rte_pmd_ifpga.h | 48 --- drivers/raw/ifpga/version.map | 7

[PATCH v3 0/5] Support OFS card

2022-05-25 Thread Wei Huang
Changes from v2: 1. update commit log with Tianfei's comment. 2. use macro to define immediate value. 3. treat 7 as special PCI BAR index. 4. update ifpga documentation with OFS introduction. Wei Huang (5): raw/ifpga: remove experimental tag from ifpga APIs raw/ifpga: remove vdev when ifpga is

[PATCH v1] net/mlx5: add Rx drop counters to xstats

2022-05-25 Thread Rongwei Liu
Add two kinds of Rx drop counters to DPDK xstats which are physical port scope. 1. rx_prio[0-7]_buf_discard The number of unicast packets dropped due to lack of shared buffer resources. 2. rx_prio[0-7]_cong_discard The number of packets that is dropped by the Weighted Random Early Dete

[PATCH v6 5/5] baseband/acc100: configuration of ACC101 from PF

2022-05-25 Thread Nicolas Chautru
Adding companion function common to ACC100/ACC101 which can be called from bbdev-test when running from PF. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 6 +- drivers/baseband/acc100/rte_acc100_cfg.h | 4 +- drivers/baseband/acc100/rte_acc100_pmd.c | 323

[PATCH v6 4/5] baseband/acc100: modify validation code for ACC101

2022-05-25 Thread Nicolas Chautru
The validation requirement is different for the two devices. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 47 1 file changed, 35 insertions(+), 12 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/base

[PATCH v6 3/5] baseband/acc100: introduce PMD for ACC101

2022-05-25 Thread Nicolas Chautru
Support for ACC101 as a derivative of ACC100. Integrated in unified driver and reusing existing code when possible. Signed-off-by: Nicolas Chautru --- MAINTAINERS | 1 + doc/guides/bbdevs/acc100.rst | 37 +--- doc/guides/bbdevs/features/acc101.ini

[PATCH v6 2/5] baseband/acc100: add protection for some negative scenario

2022-05-25 Thread Nicolas Chautru
Catch exception in PMD in case of invalid input parameter. Fixes: 5ad5060f8f7a ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/bas

[PATCH v6 1/5] baseband/acc100: update companion PF configure function

2022-05-25 Thread Nicolas Chautru
Update of the device configuration function from PF used for bbdev-test to latest sequence for ACC199 PRQ device and matching version in pf_bb_config 22.03. Fixes: b17d70922d5d ("baseband/acc100: add configure function") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/ac

[PATCH v6 0/5] drivers/baseband: PMD to support ACC100/ACC101 devices

2022-05-25 Thread Nicolas Chautru
v6: use formally an unified driver for AC100 and AC101. Exposing single unified function for the PF device configuration used by bbdev-test. v5: minor fix to doc and intermediate commit caught in CI v4: incremental updates based on reviews Changed order of patchset to include two ACC100 specifi

[PATCH v6 0/5] drivers/baseband: PMD to support ACC100/ACC101 devices

2022-05-25 Thread Nicolas Chautru
v6: use formally an unified driver for AC100 and AC101. Exposing single unified function for the PF device configuration used by bbdev-test. v5: minor fix to doc and intermediate commit caught in CI v4: incremental updates based on reviews Changed order of patchset to include two ACC100 specifi

RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-05-25 Thread Zhang, Qi Z
> -Original Message- > From: Jeff Daly > Sent: Wednesday, May 25, 2022 11:23 PM > To: Zhang, Qi Z ; Thomas Monjalon > ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices > > > > > -O

RE: [PATCH v5 4/5] baseband/acc100: modify validation code for ACC101

2022-05-25 Thread Chautru, Nicolas
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, May 25, 2022 7:33 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: tho...@monjalon.net; Kinsella, Ray ; > Richardson, Bruce ; > hemant.agra...@nxp.com; Vargas, Hernan ; > david.march...@r

RE: [PATCH v5 5/5] baseband/acc100: configuration of ACC101 from PF

2022-05-25 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, May 25, 2022 6:25 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: tho...@monjalon.net; Kinsella, Ray ; > Richardson, Bruce ; > hemant.agra...@nxp.com; Vargas, Hernan ; > david

RE: [PATCH v1] bbdev: add new operation for FFT processing

2022-05-25 Thread Chautru, Nicolas
Hi Hernant, Gentle reminder in case you can find the time. Could please have a look this patch for bbdev api extension. This is targeting 22.11. New operation type for FFT processing (On top of 4 existing operations types). There is no impact to the la12xx PMD but would be good to get review/fee

Re: [PATCH] net/memif: fix overwriting of head segment

2022-05-25 Thread Ferruh Yigit
On 5/25/2022 6:56 AM, Joyce Kong wrote: The 'dst_off' was reset in multi segment case. This caused memif buffer segment to write to beginning of mbuf, overwriting previous data. Fix it with this patch. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Cc:sta...@dpdk.org Reported

[PATCH v4 3/3] rte_pie: fix incorrect floating point math

2022-05-25 Thread Stephen Hemminger
The function rte_pie_drop was attempting to do a random probability drop, but because of incorrect usage of fixed point divide it would always return 1. Change to use new rte_drand() instead. Fixes: 44c730b0e379 ("sched: add PIE based congestion management") Signed-off-by: Stephen Hemminger ---

[PATCH v4 2/3] rte_pie: remove unnecessary floating point

2022-05-25 Thread Stephen Hemminger
The qdelay variable is derived from and compared to 64 bit value so it doesn't have to be floating point. Fixes: 44c730b0e379 ("sched: add PIE based congestion management") Signed-off-by: Stephen Hemminger --- lib/sched/rte_pie.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 1/3] random: add rte_drand() function

2022-05-25 Thread Stephen Hemminger
The PIE code and other applications can benefit from having a fast way to get a random floating point value. This new function is equivalent to drand() in the standard library. Signed-off-by: Stephen Hemminger --- app/test/test_rand_perf.c | 7 + doc/guides/rel_notes/release_22

[PATCH v4 0/3] introduce random floating point function

2022-05-25 Thread Stephen Hemminger
Introduce a new random number function to get a floating point value. Then use it to fix PIE scheduler. v4 - use slower divide method in rte_drand() if library does not have ieee754 (FreeBSD and Windows?) - fix some typos v3 - rename to rte_drand() and other review feedback - fix

[PATCH v2 1/1] net/iavf: add vector PMD for Arm for basic Rx path

2022-05-25 Thread Kathleen Capella
This patch adds the basic NEON Rx path to the iavf driver. It does not include scatter or flex varieties. Tested on N1SDP platform with testpmd mac forwarding and saw Rx-pps = 20M. Signed-off-by: Kathleen Capella Reviewed-by: Ruifeng Wang --- drivers/net/iavf/iavf_rxtx.c | 18 +- dri

[PATCH v2 0/1] net/iavf: add vector PMD for Arm for basic Rx path

2022-05-25 Thread Kathleen Capella
This patch adds the basic NEON Rx path to iavf driver, including the main Rx function (_recv_raw_pkts_vec) and the functions it depends on. Also, NEON vector path has been added to iavf_set_rx_function. Functional testing with testpmd (rxonly and mac forwarding) and l3fwd have been done on N1SDP pl

Re: [PATCH] eal/ppc: undefine AltiVec keyword vector

2022-05-25 Thread Tyler Retzlaff
On Wed, May 25, 2022 at 07:02:52PM +0100, Ray Kinsella wrote: > > Thomas Monjalon writes: > > > 25/05/2022 13:48, Ray Kinsella: > >> > >> Thomas Monjalon writes: > >> > >> > The AltiVec header file is defining "vector", except in C++ build. > >> > The keyword "vector" may conflict easily. > >

Re: [PATCH] eal/ppc: undefine AltiVec keyword vector

2022-05-25 Thread Ray Kinsella
Thomas Monjalon writes: > 25/05/2022 13:48, Ray Kinsella: >> >> Thomas Monjalon writes: >> >> > The AltiVec header file is defining "vector", except in C++ build. >> > The keyword "vector" may conflict easily. >> > As a rule, it is better to use the alternative keyword "__vector". >> > >> >

Re: [PATCH v2] net/bonding: fix mbuf fast free usage

2022-05-25 Thread Ferruh Yigit
On 5/25/2022 2:08 AM, Min Hu (Connor) wrote: Usage of 'RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE' offload has two constraints: per-queue all mbufs comes from the same mempool and has refcnt = 1. Bonding mode Broadcast, Tx mbuf has more than one refcnt. Bonding mode 8023AD, It contains two mempools sepa

Re: [PATCH v3 5/5] ethdev: fix dev state when stop

2022-05-25 Thread Ferruh Yigit
On 5/3/2022 11:02 AM, Min Hu (Connor) wrote: Currently, 'dev_started' is always set to be 0 when dev stop, whether it succeeded or failed. This is unreasonable and this patch fixed it. Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int") Cc: sta...@dpdk.org Signed-off-by

[PATCH 3/3] app/testpmd: compact RSS flow type output in port info

2022-05-25 Thread Ferruh Yigit
In port info command output, 'show port info all', supported RSS flow types printed one type per line, and although this information is not most important part of the command it takes big part of the command output. Compacting the supported RSS flow type output by printing 6 (hardcoded value) item

[PATCH 2/3] app/testpmd: remove duplicated flow type to string table

2022-05-25 Thread Ferruh Yigit
Flow type table has two instance, one is used for flow type to string conversion, and other is used for string to flow type conversion. And tables are diverged by time. Unifying tables to prevent maintaining two different tables. Note: made 'flowtype_to_str()' non-static to prevent build error fo

[PATCH 1/3] app/testpmd: fix displaying RSS info

2022-05-25 Thread Ferruh Yigit
When supported RSS offload flow types are printed via 'show port info #' command, flow names are get from flow type array which is wrong and causing some RSS flow types not being displayed. Instead RSS flow type array should be used. Also helper functions added and existing code updated to use hel

[v6, 09/11] examples/fips_validation: cleanup bypass tests in response file

2022-05-25 Thread Gowrishankar Muthukrishnan
Remove garbage entries for bypassed tests in response file. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 74 - 1 file changed, 35 insertions(+), 39 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_valida

[v6, 11/11] examples/fips_validation: add parsing for aes_cbc

2022-05-25 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for AES_CBC test. Signed-off-by: Gowrishankar Muthukrishnan -- v6: * fixed local variable initialization in fips_mct_aes_test. --- examples/fips_validation/fips_validation.c| 8 +- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/

[v6, 10/11] examples/fips_validation: reset IV generation in every test group

2022-05-25 Thread Gowrishankar Muthukrishnan
Reset IV generation in every test group. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_gcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c index 3604b21

[v6, 08/11] examples/fips_validation: add parsing for cmac

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added function to parse algorithm for CMAC test. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan -- v5: * parser_read_cmac_direction_str implementation moved to static. --- examples/fips_validation/fips_validation.c | 19 --- examples/fips_

[v6, 07/11] examples/fips_validation: implement json cmac test

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Implemented JSON support for the CMAC test. Signed-off-by: Brandon Lo -- v5: * parser_read_cmac_direction_str is static. --- examples/fips_validation/fips_validation.h| 3 + .../fips_validation/fips_validation_cmac.c| 80 +++ 2 files changed, 83 insert

[v6, 06/11] examples/fips_validation: add json to hmac

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Adds JSON support for the HMAC algorithm. Signed-off-by: Brandon Lo --- examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 6 ++ .../fips_validation/fips_validation_hmac.c| 93 +++ examples/fips_validation

[v6, 05/11] examples/fips_validation: add json to gcm test

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Adds json-specific testing and writeback function. Allows the user to test AES-GCM vector sets. Signed-off-by: Brandon Lo --- v3: * fix checkpatch warnings --- examples/fips_validation/fips_validation.h| 3 + .../fips_validation/fips_validation_gcm.c | 151 ++

[v6, 04/11] examples/fips_validation: allow json file as input

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added the ability to use the json format as the input and output of the example application. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan -- v5: * fix to check info.file_type in json file type as well. v3: * fix checkpatch warnings v2: * remove use_jso

[v6, 03/11] examples/fips_validation: add json parsing

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added functions to parse the required information from a vector set given in the new json format. Signed-off-by: Brandon Lo --- v3: * fix checkpatch warnings v2: * fix for loop initialization --- examples/fips_validation/fips_validation.c | 92 ++ 1 file c

[v6, 02/11] examples/fips_validation: add json info to header

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added json-specific functions and other information needed to test the new FIPS test vectors. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan --- v5: * fix typo in macro name for prefixes. v2: * fix type of prefix to suffix --- examples/fips_validation/fi

[v6, 01/11] examples/fips_validation: add jansson dependency

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added a check for RTE_HAS_JANSSON into the meson configuration file for JSON support. Signed-off-by: Brandon Lo --- examples/fips_validation/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_validation/meson.build b/examples/fips_validation/mes

[v6, 00/11] Add JSON vector set support to fips validation

2022-05-25 Thread Gowrishankar Muthukrishnan
Adds a very basic introduction to JSON vector sets in the fips validation example application. This patch set will only introduce the AES-GCM test using a JSON request file because the other algorithms need more information than what is given in the new JSON format. v6: * CI centos platform fix.

Re: [PATCH v6 6/9] net/vmxnet3: add version 6 support

2022-05-25 Thread Pankaj Gupta
Hi Andrew, >> Extended interrupt structures, required implementation for additional number >> of queues It is about Vmxnet3_IntrConfExt. Vmxnet3_IntrConfExt is a control data structure shared with ESX. ESX introduced it for this version to increase the number of queues that can be used. Vmxnet3

[PATCH v3 3/3] rte_pie: fix incorrect floating point math

2022-05-25 Thread Stephen Hemminger
The function rte_pie_drop was attempting to do a random probability drop, but because of incorrect usage of fixed point divide it would always return 1. Change to use new rte_drand() instead. Fixes: 44c730b0e379 ("sched: add PIE based congestion management") Cc: wojciechx.liguzin...@intel.com Sig

[PATCH v3 2/3] rte_pie: remove unnecessary floating point

2022-05-25 Thread Stephen Hemminger
The qdelay variable is derived from and compared to 64 bit value so it doesn't have to be floating point. Fixes: 44c730b0e379 ("sched: add PIE based congestion management") Cc: wojciechx.liguzin...@intel.com Signed-off-by: Stephen Hemminger --- lib/sched/rte_pie.h | 2 +- 1 file changed, 1 inser

[PATCH v3 1/3] random: add rte_drand() funciton

2022-05-25 Thread Stephen Hemminger
The PIE code and other applications can benefit from having a fast way to get a random floating point value. This new function is equivalent to drand() in the standard library. Signed-off-by: Stephen Hemminger --- app/test/test_rand_perf.c | 7 +++ doc/guides/rel_notes/release_

[PATCH v3 0/3] introduce random floating point function

2022-05-25 Thread Stephen Hemminger
Introduce a new random number function to get a floating point value. Then use it to fix PIE scheduler. v3 - rename to rte_drand() and other review feedback - fix warnings with some compilers in test code Stephen Hemminger (3): random: add rte_drand() funciton rte_pie: remove unnecessar

Additional reviewers

2022-05-25 Thread Ben Magistro
Hello, I recently wrapped up the conversion from makefiles to meson on another project and while everything seems functional, if there is anyone that has experience with meson/time/interest, I would appreciate some more eyes on this change. For the change, most things were modeled off of how DPDK

[v5,11/11] examples/fips_validation: add parsing for aes_cbc

2022-05-25 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for AES_CBC test. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c| 8 +- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_aes.c | 223 ++ examples/fips_v

[PATCH v2 14/14] cryptodev: add asym algorithms capabilities

2022-05-25 Thread Arek Kusztal
- Added asymmetric crypto algorithm specific capability struct. Included fields like random number capability, padding flags etc. Signed-off-by: Arek Kusztal --- app/test-crypto-perf/main.c | 12 +- app/test-eventdev/test_perf_common.c | 2 +- app/test/test_cryptodev_

[PATCH v2 13/14] cryptodev: add salt length and optional label

2022-05-25 Thread Arek Kusztal
- Added salt length and optional label. Common parameters to PSS and OAEP padding for RSA. - Fixed hash API in RSA padding. Now it is specified how hash should be used with particular RSA padding modes. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 19 +-- 1 f

[PATCH v2 12/14] cryptodev: clarify rsa verify with none padding

2022-05-25 Thread Arek Kusztal
- Clarified where should output be stored of signature decryption with padding none. PMD is not able to know what padding algorithm was used, therefore decrypted signature should be returned to the user. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 7 ++- 1 file changed,

[PATCH v2 11/14] cryptodev: move RSA padding into separate struct

2022-05-25 Thread Arek Kusztal
- move RSA padding into separate struct. More padding members should be added into padding, therefore having separate struct for padding parameters will make this more readable. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 10 ++-- drivers/common/cpt/cpt_ucode_as

[PATCH v2 10/14] cryptodev: clarify usage of rsa padding hash

2022-05-25 Thread Arek Kusztal
- Clarified usage of RSA padding hash. It was not specified how to use hash for PKCS1_5 padding. This could lead to incorrect implementation. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --g

[PATCH v2 09/14] cryptodev: add asym op flags

2022-05-25 Thread Arek Kusztal
- Added flags to rte_crypto_asym_op struct. It may be shared between different algorithms. - Added Diffie-Hellman padding flags. Diffie-Hellman padding is used in certain protocols, in others, leading zero bytes need to be stripped. Even same protocol may use a different approach - most glaring exa

[PATCH v2 08/14] cryptodev: add public key verify option

2022-05-25 Thread Arek Kusztal
- Added key exchange public key verify option. For some elliptic curves public point in DH exchange needs to be checked, if it lays on the curve. Modular exponentiation needs certain checks as well, though mathematically much easier. This commit adds verify option to asym_op operations. Signed-off

[PATCH v2 07/14] cryptodev: add elliptic curve diffie hellman

2022-05-25 Thread Arek Kusztal
- Added elliptic curve Diffie-Hellman parameters. Point multiplication allows the user to process every phase of ECDH, but for phase 1, user should not really care about the generator. The user does not even need to know what the generator looks like, therefore setting ec xform would make this work

[PATCH v2 06/14] cryptodev: move dh type from xform to dh op

2022-05-25 Thread Arek Kusztal
- Moved dh operation type to dh operation struct. Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should be free to choose for any operation. One xform/session should be enough to perform both DH operations, if op_type would be xform member, session would have to be to be created twice for th

[PATCH v2 05/14] cryptodev: clarify usage of private key in dh

2022-05-25 Thread Arek Kusztal
- Clarified usage of private key in Diffie-Hellman. CSRNG capable device should generate private key and then use it for public key generation. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/cryptodev/rte_crypto_asym.h

[PATCH v2 04/14] cryptodev: remove comment about using ephemeral key in dsa

2022-05-25 Thread Arek Kusztal
- Removed comment that stated dsa can be used with Diffie Hellman ephemeral key. DH and DSA integration allowed to use ephemeral keys for random integer but not for private keys. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 8 +--- 1 file changed, 1 insertion(+), 7 delet

[PATCH v2 03/14] cryptodev: separate key exchange operation enum

2022-05-25 Thread Arek Kusztal
- Separated key exchange enum from asym op type. Key exchange and asymmetric crypto operations like signatures, encryption/decryption should not share same operation enum as its use cases are unrelated and mutually exclusive. Therefore op_type was separate into: 1) operation type 2) key exchange op

[PATCH v2 02/14] cryptodev: reduce number of comments in asym xform

2022-05-25 Thread Arek Kusztal
- Reduced number of comments in asymmetric xform. Information describing basic functionality of well known algorithms are unnecessary. - Removed NONE asymetric xform. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 2 - lib/cryptodev/rte_crypto_asym.h | 114 --

[PATCH v2 01/14] cryptodev: redefine ec group enum

2022-05-25 Thread Arek Kusztal
- EC enum was renamed to rte_crypto_curve_id. Elliptic curve enum name was incorrectly associated with group (it comes from current tls registry name). - Clarified comments about TLS deprecation. Some curves included are deprecated with TLS 1.3. Comments to address it were added. - Clarified FFDH g

[PATCH v2 00/14] cryptodev: rsa, dh, ecdh changes

2022-05-25 Thread Arek Kusztal
This patchset introduces some of changes discussed on mailing list for 22.07 release in cryptodev asym. Key changes: - It fixes API for RSA (expescially signature paddings) - Adds Elliptic-Curve Diffie-Hellman - Adds Eliiptic-Curve point verification - Adds RSA missing padding fields - Adds asym

RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug

2022-05-25 Thread Jeff Daly
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, May 11, 2022 9:27 PM > To: Jeff Daly ; dev@dpdk.org > Cc: sta...@dpdk.org; Stephen Douthit > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on > hotplug > > Caution: This is an external email. Please tak

[dpdk-dev v3] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-05-25 Thread Kai Ji
Since openssl 3.0 now deprecates the low level API QAT required to perform partial hash & aes operation when creating the session. This patch add in qat_ipsec_mb_lib driver parameter to allow QAT PMD to switch APIs between openssl and intel ipsec-mb library. Signed-off-by: Kai Ji Signed-off-by: F

Re: [RFT v2 1/3] random: add rte_rand_float()

2022-05-25 Thread Stephen Hemminger
On Wed, 25 May 2022 14:45:37 + Mattias Rönnblom wrote: > I would call it something else than "float", in particular since it > doesn't return "float" but a "double" type floating point value. > > rte_drand() maybe? Short, but might be confused with rte_rand(), given > the visual similarity

[v5, 11/11] examples/fips_validation: add parsing for aes_cbc

2022-05-25 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for AES_CBC test. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c| 8 +- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_aes.c | 223 ++ examples/fips_v

[v5, 10/11] examples/fips_validation: reset IV generation in every test group

2022-05-25 Thread Gowrishankar Muthukrishnan
Reset IV generation in every test group. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_gcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c index 3604b21

[v5, 09/11] examples/fips_validation: cleanup bypass tests in response file

2022-05-25 Thread Gowrishankar Muthukrishnan
Remove garbage entries for bypassed tests in response file. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 74 - 1 file changed, 35 insertions(+), 39 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_valida

[v5, 08/11] examples/fips_validation: add parsing for cmac

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added function to parse algorithm for CMAC test. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan -- v5: * parser_read_cmac_direction_str implementation moved to static. --- examples/fips_validation/fips_validation.c | 19 --- examples/fips_

Re: [PATCH v3 1/2] app/testpmd: do not poll stopped queues

2022-05-25 Thread Thomas Monjalon
07/03/2022 13:53, Dmitry Kozlyuk: > Calling Rx/Tx functions on a stopped queue is not supported. > Do not run packet forwarding for streams that use stopped queues. > > Each stream has a read-only "disabled" field, > so that lcore function can skip such streams. > Forwarding engines can set this f

[v5, 07/11] examples/fips_validation: implement json cmac test

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Implemented JSON support for the CMAC test. Signed-off-by: Brandon Lo -- v5: * parser_read_cmac_direction_str is static. --- examples/fips_validation/fips_validation.h| 3 + .../fips_validation/fips_validation_cmac.c| 80 +++ 2 files changed, 83 insert

[v5, 06/11] examples/fips_validation: add json to hmac

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Adds JSON support for the HMAC algorithm. Signed-off-by: Brandon Lo --- examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 6 ++ .../fips_validation/fips_validation_hmac.c| 93 +++ examples/fips_validation

[v5, 05/11] examples/fips_validation: add json to gcm test

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Adds json-specific testing and writeback function. Allows the user to test AES-GCM vector sets. Signed-off-by: Brandon Lo --- v3: * fix checkpatch warnings --- examples/fips_validation/fips_validation.h| 3 + .../fips_validation/fips_validation_gcm.c | 151 ++

[v5, 04/11] examples/fips_validation: allow json file as input

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added the ability to use the json format as the input and output of the example application. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan -- v5: * fix to check info.file_type in json file type as well. v3: * fix checkpatch warnings v2: * remove use_jso

[v5, 03/11] examples/fips_validation: add json parsing

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added functions to parse the required information from a vector set given in the new json format. Signed-off-by: Brandon Lo --- v3: * fix checkpatch warnings v2: * fix for loop initialization --- examples/fips_validation/fips_validation.c | 92 ++ 1 file c

[v5, 02/11] examples/fips_validation: add json info to header

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added json-specific functions and other information needed to test the new FIPS test vectors. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan --- v5: * fix typo in macro name for prefixes. v2: * fix type of prefix to suffix --- examples/fips_validation/fi

[v5, 01/11] examples/fips_validation: add jansson dependency

2022-05-25 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added a check for RTE_HAS_JANSSON into the meson configuration file for JSON support. Signed-off-by: Brandon Lo --- examples/fips_validation/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_validation/meson.build b/examples/fips_validation/mes

[v5, 00/11] Add JSON vector set support to fips validation

2022-05-25 Thread Gowrishankar Muthukrishnan
Adds a very basic introduction to JSON vector sets in the fips validation example application. This patch set will only introduce the AES-GCM test using a JSON request file because the other algorithms need more information than what is given in the new JSON format. v5: * AES_CBC support appended

Re: [RFT v2 1/3] random: add rte_rand_float()

2022-05-25 Thread Stephen Hemminger
On Wed, 25 May 2022 14:45:37 + Mattias Rönnblom wrote: > On 2022-05-25 00:18, Stephen Hemminger wrote: > > The PIE code and other applications can benefit from having a > > fast way to get a random floating point value. This new function > > is equivalent to erand48_r in the standard library.

Re: [PATCH] eal/ppc: undefine AltiVec keyword vector

2022-05-25 Thread Thomas Monjalon
25/05/2022 13:48, Ray Kinsella: > > Thomas Monjalon writes: > > > The AltiVec header file is defining "vector", except in C++ build. > > The keyword "vector" may conflict easily. > > As a rule, it is better to use the alternative keyword "__vector". > > > > The DPDK header file rte_altivec.h tak

RE: [RFT v2 1/3] random: add rte_rand_float()

2022-05-25 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Wednesday, 25 May 2022 16.46 > > On 2022-05-25 00:18, Stephen Hemminger wrote: > > The PIE code and other applications can benefit from having a > > fast way to get a random floating point value. This new function > > is equiv

RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-05-25 Thread Jeff Daly
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, May 23, 2022 7:22 PM > To: Jeff Daly ; Thomas Monjalon > ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices > > Caution: This is

Re: [RFT v2 1/3] random: add rte_rand_float()

2022-05-25 Thread Mattias Rönnblom
On 2022-05-25 00:18, Stephen Hemminger wrote: > The PIE code and other applications can benefit from having a > fast way to get a random floating point value. This new function > is equivalent to erand48_r in the standard library. > Seems like a good addition to the API. > Signed-off-by: Stephen

RE: [PATCH v2 1/1] app/testpmd: support different input color method

2022-05-25 Thread Dumitrescu, Cristian
> -Original Message- > From: sk...@marvell.com > Sent: Wednesday, May 25, 2022 3:37 PM > To: Li, Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying ; > Dumitrescu, Cristian > Cc: dev@dpdk.org; Sunil Kumar Kori > Subject: [PATCH v2 1/1] app/testpmd: support different input color method > >

[PATCH v2 1/1] app/testpmd: support different input color method

2022-05-25 Thread skori
From: Sunil Kumar Kori To enable input coloring, based on VLAN or DSCP, patch adds command line interface to configure the following: - configuring input coloring using VLAN or DSCP while creating meter i.e. during rte_mtr_create() - Update VLAN input coloring table at runtime. - configu

RE: [PATCH v2] app/procinfo: add devcie private info dump

2022-05-25 Thread Pattan, Reshma
> -Original Message- > From: Min Hu (Connor) > Subject: [PATCH v2] app/procinfo: add devcie private info dump Typo: device* > +static void > +show_port_private_info(void) > +{ > + int i; > + > + snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private "); Better to have h

  1   2   >