[PATCH v2] app/testpmd: change a magic number to macro

2022-03-30 Thread Mingxia Liu
From: mingxial Add macro MIN_TOTAL_NUM_MBUFS (1024) to indicate what the value of total-num-mbufs should bigger than. Fixes: c87988187fdb ("app/testpmd: add --total-num-mbufs option") Cc: sta...@dpdk.org Signed-off-by: mingxial --- app/test-pmd/parameters.c | 5 +++-- app/test-pmd/testpmd.h

RE: [PATCH] app/testpmd: fix use of indirect action after port close

2022-03-30 Thread Dmitry Kozlyuk
Hi Aman, > From: Singh, Aman Deep > Sent: Wednesday, March 30, 2022 5:24 PM > [...] > On 3/7/2022 10:18 PM, Dmitry Kozlyuk wrote: > > When a port was closed, indirect actions could remain > > with their handles no longer valid. > > If a newly attached device was assigned the same ID as the closed

Re: [PATCH] eal/windows: fix data race when creating threads

2022-03-30 Thread Thomas Monjalon
10/03/2022 17:19, Dmitry Kozlyuk: > Hi Tyler, > > 2022-03-09 23:35 (UTC-0800), Tyler Retzlaff: > > create lcore worker threads suspended and then subsequently resume to > > allow &lcore_config[i].thread_id be stored before eal_thread_loop > > execution. > > > > Fixes: 53ffd9f080fc ("eal/windows:

[Bug 988] Flow Management features in Windows

2022-03-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=988 Thomas Monjalon (ad...@dpdk.org) changed: What|Removed |Added Resolution|--- |INVALID CC|

[PATCH] dma/idxd: add generic option for queue config

2022-03-30 Thread Kevin Laatz
The device config script currently uses some defaults to configure devices in a generic way. With the addition of this option, users have more control over how queues are configured. Signed-off-by: Kevin Laatz --- drivers/dma/idxd/dpdk_idxd_cfg.py | 29 ++--- 1 file chan

RE: DPDK tech board meeting

2022-03-30 Thread Honnappa Nagarahalli
The meeting ended early as there were not many topics to discuss. Thanks, Honnappa > -Original Message- > From: Morten Brørup > Sent: Wednesday, March 30, 2022 8:51 AM > To: dev@dpdk.org > Subject: DPDK tech board meeting > > Anyone in the DPDK Tech Board, > > I was online last Wednesda

RE: [RFC PATCH v2 0/9] vhost lock annotations

2022-03-30 Thread Ali Alnubani
[..] > It looks like mimecast shot the first patch (which I sent in place of > Maxime, because this series should go through the main repo). > > Looking at the mail source, I see: > > X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation > Protection Definition;Similar Internal Domain=fals

RE: OVS DPDK DMA-Dev library/Design Discussion

2022-03-30 Thread Hu, Jiayu
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, March 30, 2022 5:25 PM > To: Hu, Jiayu ; Ilya Maximets ; > Morten Brørup ; Richardson, Bruce > > Cc: Van Haaren, Harry ; Pai G, Sunil > ; Stokes, Ian ; Ferriter, Cian > ; ovs-...@openvswitch.org; dev@dpdk.org; > Mcnamara, J

[PATCH v2] eal: add seqlock

2022-03-30 Thread Mattias Rönnblom
A sequence lock (seqlock) is synchronization primitive which allows for data-race free, low-overhead, high-frequency reads, especially for data structures shared across many cores and which are updated with relatively infrequently. A seqlock permits multiple parallel readers. The variant of seqloc

Re: [PATCH] app/testpmd: fix use of indirect action after port close

2022-03-30 Thread Singh, Aman Deep
Hi Dmitry, On 3/7/2022 10:18 PM, Dmitry Kozlyuk wrote: When a port was closed, indirect actions could remain with their handles no longer valid. If a newly attached device was assigned the same ID as the closed port, those indirect actions became accessible again. Any attempt to use them resulte

[Bug 989] DPDK support for Symmetric RSS Hash & Inner IP

2022-03-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=989 Bug ID: 989 Summary: DPDK support for Symmetric RSS Hash & Inner IP Product: DPDK Version: 22.03 Hardware: Other OS: Windows Status: UNCONFIRMED Severity: normal

[Bug 988] Flow Management features in Windows

2022-03-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=988 Bug ID: 988 Summary: Flow Management features in Windows Product: DPDK Version: 22.03 Hardware: Other OS: Windows Status: UNCONFIRMED Severity: normal Pr

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-03-30 Thread Bruce Richardson
On Wed, Mar 30, 2022 at 01:41:34PM +0200, Ilya Maximets wrote: > On 3/30/22 13:12, Bruce Richardson wrote: > > On Wed, Mar 30, 2022 at 12:52:15PM +0200, Ilya Maximets wrote: > >> On 3/30/22 12:41, Ilya Maximets wrote: > >>> Forking the thread to discuss a memory consistency/ordering model. > >>> >

[PATCH v2] examples/l3fwd: merge l3fwd-acl into l3fwd

2022-03-30 Thread Sean Morrissey
l3fwd-acl contains duplicate functions to l3fwd. For this reason we merge l3fwd-acl code into l3fwd with '--lookup acl' cmdline option to run ACL. Signed-off-by: Sean Morrissey --- V2: * add doc changes * minor code cleanup --- doc/guides/rel_notes/release_22_07.rst|4 + doc/guides/s

Re: [RFC PATCH v2 0/9] vhost lock annotations

2022-03-30 Thread David Marchand
On Wed, Mar 30, 2022 at 3:50 PM David Marchand wrote: > > vhost internals involves multiple locks to protect data access by > multiple threads. > > This series is a try at using clang thread safety checks [1] to catch > issues during compilation: EAL spinlock and rwlock are annotated and > vhost c

DPDK tech board meeting

2022-03-30 Thread Morten Brørup
Anyone in the DPDK Tech Board, I was online last Wednesday for the DPDK tech board meeting, but no one else were there, so I guess it was cancelled. Is the next tech board meeting still scheduled for Wednesday April 4th at 3 PM UTC (17:00 CEST), or is it today? And is it still on https://meet.

[RFC PATCH v2 9/9] vhost: enable lock check

2022-03-30 Thread David Marchand
Now that all locks in this library are annotated, we can enable the check. Signed-off-by: David Marchand --- lib/vhost/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/vhost/meson.build b/lib/vhost/meson.build index bc7272053b..197a51d936 100644 --- a/lib/vhost/meson.build +

[RFC PATCH v2 8/9] vhost: annotate IOTLB locks

2022-03-30 Thread David Marchand
This change simply annotates existing paths of the code leading to manipulations of the IOTLB r/w locks. clang does not support conditionally held locks, so always take iotlb locks regardless of VIRTIO_F_IOMMU_PLATFORM feature. vdpa and vhost_crypto code are annotated though they end up not takin

[RFC PATCH v2 7/9] vhost: annotate VDPA device list accesses

2022-03-30 Thread David Marchand
vdpa_device_list access must be protected with vdpa_device_list_lock spinlock. Signed-off-by: David Marchand --- lib/vhost/vdpa.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/vhost/vdpa.c b/lib/vhost/vdpa.c index 8fa2153023..e2caa2bf28 100644 --- a/l

[RFC PATCH v2 6/9] vhost: annotate need reply handling

2022-03-30 Thread David Marchand
When a reply from the slave is required (VHOST_USER_NEED_REPLY flag), a spinlock is taken before sending the message. This spinlock is released if an error occurs when sending the message, and once a reply is received. A problem is that this lock is taken under a branch and annotating conditionall

[RFC PATCH v2 5/9] vhost: annotate async acesses

2022-03-30 Thread David Marchand
vq->async is initialised and must be accessed under vq->access_lock. Top level "_thread_unsafe" functions could be checked at runtime (clang provides a lock aware assert()-like check), but they are simply skipped because those functions are not called in-tree, and as a result, their annotations wo

[RFC PATCH v2 4/9] vhost: fix async access

2022-03-30 Thread David Marchand
vq->async accesses must be protected with vq->access_lock. Fixes: eb666d24085f ("vhost: fix async unregister deadlock") Fixes: 0c0935c5f794 ("vhost: allow to check in-flight packets for async vhost") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/vhost/vhost.c | 25 ++

[RFC PATCH v2 2/9] eal: annotate spinlock and rwlock

2022-03-30 Thread David Marchand
clang offers some thread safety checks, statically verifying that locks are taken and released in the code. To use those checks, the full code leading to taking or releasing locks must be annotated with some attributes. Wrap those attributes into our own set of macros. Only rwlock and the "normal

[RFC PATCH v2 3/9] vhost: annotate virtqueue access lock

2022-03-30 Thread David Marchand
This change simply annotates existing paths of the code leading to manipulations of the vq->access_lock. One small change is required: vhost_poll_enqueue_completed was getting a queue_id to get hold of the vq, while its callers already knew of the vq. For the annotation sake, vq is now directly pa

[RFC PATCH v2 1/9] vhost: fix missing virtqueue lock protection

2022-03-30 Thread David Marchand
binKG6ElGS6GT.bin Description: Binary data

[RFC PATCH v2 0/9] vhost lock annotations

2022-03-30 Thread David Marchand
vhost internals involves multiple locks to protect data access by multiple threads. This series is a try at using clang thread safety checks [1] to catch issues during compilation: EAL spinlock and rwlock are annotated and vhost code is instrumented so that clang can statically check correctness.

Re: [PATCH 1/6] eventdev: support to set queue attributes at runtime

2022-03-30 Thread Mattias Rönnblom
On 2022-03-29 15:11, Shijith Thotton wrote: > Added a new eventdev API rte_event_queue_attr_set(), to set event queue > attributes at runtime from the values set during initialization using > rte_event_queue_setup(). PMD's supporting this feature should expose the > capability RTE_EVENT_DEV_CAP_RUN

Re: [PATCH 2/6] eventdev: add weight and affinity to queue attributes

2022-03-30 Thread Mattias Rönnblom
On 2022-03-29 15:11, Shijith Thotton wrote: > Extended eventdev queue QoS attributes to support weight and affinity. > If queues are of same priority, events from the queue with highest > weight will be scheduled first. Affinity indicates the number of times, > the subsequent schedule calls from an

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-03-30 Thread Ilya Maximets
On 3/30/22 13:12, Bruce Richardson wrote: > On Wed, Mar 30, 2022 at 12:52:15PM +0200, Ilya Maximets wrote: >> On 3/30/22 12:41, Ilya Maximets wrote: >>> Forking the thread to discuss a memory consistency/ordering model. >>> >>> AFAICT, dmadev can be anything from part of a CPU to a completely >>> s

[Bug 987] dead lock in rte_acl_creat and rte_ring_free by list circled

2022-03-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=987 Bug ID: 987 Summary: dead lock in rte_acl_creat and rte_ring_free by list circled Product: DPDK Version: 20.02 Hardware: x86 OS: Linux Status: UNCONFIRME

Re: [PATCH] eal: add seqlock

2022-03-30 Thread Mattias Rönnblom
On 2022-03-30 12:50, Morten Brørup wrote: >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] >> Sent: Wednesday, 30 March 2022 12.07 >> + >> +/** >> + * The RTE seqlock type. >> + */ >> +typedef struct { >> +uint32_t sn; /**< A generation number for the protected data. */ >> +

Re: [PATCH] eal: add seqlock

2022-03-30 Thread Tyler Retzlaff
On Wed, Mar 30, 2022 at 12:50:42PM +0200, Morten Brørup wrote: > > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > Sent: Wednesday, 30 March 2022 12.07 > > > + > > +/** > > + * The RTE seqlock type. > > + */ > > +typedef struct { > > + uint32_t sn; /**< A generation number for

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-03-30 Thread Bruce Richardson
On Wed, Mar 30, 2022 at 12:52:15PM +0200, Ilya Maximets wrote: > On 3/30/22 12:41, Ilya Maximets wrote: > > Forking the thread to discuss a memory consistency/ordering model. > > > > AFAICT, dmadev can be anything from part of a CPU to a completely > > separate PCI device. However, I don't see an

RE: [PATCH 5/6] event/cnxk: support to set runtime queue attributes

2022-03-30 Thread Van Haaren, Harry
> -Original Message- > From: Shijith Thotton > Sent: Tuesday, March 29, 2022 2:11 PM > To: dev@dpdk.org; jer...@marvell.com > Cc: Shijith Thotton ; pbhagavat...@marvell.com > Subject: [PATCH 5/6] event/cnxk: support to set runtime queue attributes > +int > +cnxk_sso_queue_attribute_get(

RE: 19.11.12 patches review and test

2022-03-30 Thread Jiang, YuX
> -Original Message- > From: christian.ehrha...@canonical.com > Sent: Monday, March 21, 2022 7:55 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; Walker, Benjamin > ; David Christensen > ; hariprasad.govindhara...@intel.com; Hemant > Agrawal ; Stokes, Ian ;

RE: [PATCH 1/6] eventdev: support to set queue attributes at runtime

2022-03-30 Thread Van Haaren, Harry
> -Original Message- > From: Shijith Thotton > Sent: Tuesday, March 29, 2022 2:11 PM > To: dev@dpdk.org; jer...@marvell.com > Cc: Shijith Thotton ; pbhagavat...@marvell.com; Ray > Kinsella > Subject: [PATCH 1/6] eventdev: support to set queue attributes at runtime > +/** > + * Set an e

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-03-30 Thread Ilya Maximets
On 3/30/22 12:41, Ilya Maximets wrote: > Forking the thread to discuss a memory consistency/ordering model. > > AFAICT, dmadev can be anything from part of a CPU to a completely > separate PCI device. However, I don't see any memory ordering being > enforced or even described in the dmadev API or

RE: [PATCH 0/6] Extend and set event queue attributes at runtime

2022-03-30 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, March 29, 2022 7:50 PM > To: Shijith Thotton ; Van Haaren, Harry > ; Jayatheerthan, Jay > ; Carrillo, Erik G ; > Gujjar, Abhinandan S ; McDaniel, Timothy > ; Hemant Agrawal ; > Nipun Gupta ; mattias.ronnblom > ; Ray Kinsella > Cc:

RE: [PATCH] eal: add seqlock

2022-03-30 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Wednesday, 30 March 2022 12.07 > + > +/** > + * The RTE seqlock type. > + */ > +typedef struct { > + uint32_t sn; /**< A generation number for the protected data. */ > + rte_spinlock_t lock; /**< Spinlock used to seria

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-03-30 Thread Ilya Maximets
Forking the thread to discuss a memory consistency/ordering model. AFAICT, dmadev can be anything from part of a CPU to a completely separate PCI device. However, I don't see any memory ordering being enforced or even described in the dmadev API or documentation. Please, point me to the correct d

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-03-30 Thread Bruce Richardson
On Wed, Mar 30, 2022 at 11:25:05AM +0200, Maxime Coquelin wrote: > > > On 3/30/22 04:02, Hu, Jiayu wrote: > > > > > > > -Original Message- > > > From: Ilya Maximets > > > Sent: Wednesday, March 30, 2022 1:45 AM > > > To: Morten Brørup ; Richardson, Bruce > > > > > > Cc: i.maxim...@ovn

[PATCH] eal: add seqlock

2022-03-30 Thread Mattias Rönnblom
A sequence lock (seqlock) is synchronization primitive which allows for data-race free, low-overhead, high-frequency reads, especially for data structures shared across many cores and which are updated with relatively infrequently. A seqlock permits multiple parallel readers. The variant of seqloc

RE: 20.11.5 patches review and test

2022-03-30 Thread Jiang, YuX
> -Original Message- > From: Jiang, YuX > Sent: Tuesday, March 29, 2022 7:48 PM > To: luca.bocca...@gmail.com; sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; Walker, Benjamin > ; David Christensen > ; Hemant Agrawal ; > Stokes, Ian ; Jerin Jacob ; > Mcnamara, John ;

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-03-30 Thread Maxime Coquelin
On 3/30/22 04:02, Hu, Jiayu wrote: -Original Message- From: Ilya Maximets Sent: Wednesday, March 30, 2022 1:45 AM To: Morten Brørup ; Richardson, Bruce Cc: i.maxim...@ovn.org; Maxime Coquelin ; Van Haaren, Harry ; Pai G, Sunil ; Stokes, Ian ; Hu, Jiayu ; Ferriter, Cian ; ovs- d...

RE: OVS DPDK DMA-Dev library/Design Discussion

2022-03-30 Thread Van Haaren, Harry
> -Original Message- > From: Morten Brørup > Sent: Tuesday, March 29, 2022 8:59 PM > To: Van Haaren, Harry ; Richardson, Bruce > > Cc: Maxime Coquelin ; Pai G, Sunil > ; Stokes, Ian ; Hu, Jiayu > ; Ferriter, Cian ; Ilya Maximets > ; ovs-...@openvswitch.org; dev@dpdk.org; Mcnamara, John >

[PATCH] eal/windows: set Windows main lcore affinitization

2022-03-30 Thread Tyler Retzlaff
add missing code to affinitize main_lcore from lcore configuration. Signed-off-by: Tyler Retzlaff --- lib/eal/windows/eal.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c index ca3c41a..9c61780 100644 --- a/lib/eal/windows/eal.c +++ b/lib/

[PATCH 2/2] net/cnxk: use ROC errata API

2022-03-30 Thread Rahul Bhansali
Used errata APIs roc_errata_nix_has_no_drop_re() and roc_errata_nix_has_cq_min_size_4k() instead of direct ROC model check. Signed-off-by: Rahul Bhansali --- drivers/net/cnxk/cn10k_ethdev.c | 4 +--- drivers/net/cnxk/cn9k_ethdev.c | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff -

[PATCH 1/2] common/cnxk: add ROC errata list

2022-03-30 Thread Rahul Bhansali
Created roc_errata.h to list the errata handled in userspace drivers. Added no_drop_re, cq_min_size_4k, no_fc_stype_ststp, no_drop_aging, no_vwqe_flush_op etc erratas. Signed-off-by: Rahul Bhansali --- drivers/common/cnxk/roc_api.h | 3 + drivers/common/cnxk/roc_errata.h | 80 +

RE: 20.11.5 patches review and test

2022-03-30 Thread Ali Alnubani
> -Original Message- > From: luca.bocca...@gmail.com > Sent: Friday, March 18, 2022 5:21 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; benjamin.wal...@intel.com; David > Christensen ; > hariprasad.govindhara...@intel.com; Hemant Agrawal > ; Ian Stokes ; J