[RFC,v3 3/3] net/ice: support header split in Rx data path

From: Xuan Ding This patch adds support for header split in normal Rx data paths. When the Rx queue is configured with header split for specific protocol type, packets received will be directly splited into header and payload parts. And the two parts will be put into different mempools. Currentl

[RFC,v3 2/3] app/testpmd: add header split configuration

From: Xuan Ding This patch adds header split configuration in testpmd. The header split feature is off by default. To enable header split, you need: 1. Configure Rx queue with rx_offload header split on. 2. Set the protocol type of header split. Command for set header split protocol type: testpm

[RFC,v3 1/3] ethdev: introduce protocol type based header split

From: Xuan Ding Header split consists of splitting a received packet into two separate regions based on the packet content. The split happens after the packet header and before the packet payload. Splitting is usually between the packet header that can be posted to a dedicated buffer and the pack

[RFC,v3 0/3] ethdev: introduce protocol type based header split

From: Xuan Ding Header split consists of splitting a received packet into two separate regions based on the packet content. It is useful in some scenarios, such as GPU acceleration. The spliting will help to enable true zero copy and hence improve the performance significantly. This patchset ext

rte_memzone_reserve and invalid socket id

hi, there is a repeatable test failure in test_memzone when running dpdk-test.exe --no-huge for memzone_autotest it's clear why the test fails but what isn't clear if what rte_memzone_reserve is doing when provided an invalid socket id is sensible or not. as a matter of luck the system i'm using

RE: [PATCH] meson: update doc logic for Windows

[AMD Official Use Only] > -Original Message- > From: Dmitry Kozlyuk > Sent: Tuesday, March 29, 2022 4:21 AM > To: Varghese, Vipin > Cc: Thomas Monjalon ; > david.march...@redhat.com; Tummala, Sivaprasad > ; dev@dpdk.org > Subject: Re: [PATCH] meson: update doc logic for Windows > > [C

[PATCH v4 9/9] net/ice: add warning log for unsupported configuration

Priority configuration is enabled in level 3 and level 4. Weight configuration is enabled in level 4. This patch adds warning log for unsupported priority and weight configuration. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/

[PATCH v4 8/9] net/ice: support queue group priority configuration

This patch adds queue group priority configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 070cb7db41..8a71bfa599 100644 --- a/drivers/net/ice/ice_tm.c +++

[PATCH v4 7/9] net/ice: support queue weight configuration

This patch adds queue weight configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 5ebf9abeb9..070cb7db41 100644 --- a/drivers/net/i

[PATCH v4 6/9] net/ice: support queue priority configuration

This patch adds queue priority configuration support. The highest priority is 0, and the lowest priority is 7. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_

[PATCH v4 5/9] net/ice: support queue group bandwidth limit

To set up the exact queue group, we need to reconfigure topology by delete and then recreate queue nodes. This patch adds queue group configuration support and queue group bandwidth limit support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_ethdev.h | 9 +- drivers/net/ice/ice_tm.c |

[PATCH v4 4/9] net/ice: support queue bandwidth limit

From: Ting Xu Enable basic TM API for PF only. Support for adding profiles and queue nodes. Only max bandwidth is supported in profiles. Profiles can be assigned to target queues. Only TC0 is valid. Signed-off-by: Wenjun Wu Signed-off-by: Ting Xu --- drivers/net/ice/ice_ethdev.c | 19 ++ dri

[PATCH v4 3/9] net/ice/base: support queue BW allocation configuration

This patch adds BW allocation support of queue scheduling node to support WFQ in queue level. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 64 drivers/net/ice/base/ice_sched.h | 3 ++ 2 files changed, 67 insertions(+) diff --git a/drivers/net

[PATCH v4 2/9] net/base/ice: support priority configuration of the exact node

This patch adds priority configuration support of the exact node in the scheduler tree. This function does not need additional calls to the scheduler lock. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 21 + drivers/net/ice/base/ice_sched.h | 3 +++ 2 files

[PATCH v4 1/9] net/ice/base: fix dead lock issue when getting node from ID type

The function ice_sched_get_node_by_id_type needs to be called with the scheduler lock held. However, the function ice_sched_get_node also requests the scheduler lock. It will cause the dead lock issue. This patch replaces function ice_sched_get_node with function ice_sched_find_node_by_teid to sol

[PATCH v4 0/9] Enable ETS-based TX QoS on PF

This patch set enables ETS-based TX QoS on PF. It is supported to configure bandwidth and priority in both queue and queue group level, and weight only in queue level. v2: fix code style issue. v3: fix uninitialization issue v4: fix logical issue Ting Xu (1): net/ice: support queue bandwidth li

[PATCH v3 9/9] net/ice: add warning log for unsupported configuration

Priority configuration is enabled in level 3 and level 4. Weight configuration is enabled in level 4. This patch adds warning log for unsupported priority and weight configuration. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/

[PATCH v3 8/9] net/ice: support queue group priority configuration

This patch adds queue group priority configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 070cb7db41..8a71bfa599 100644 --- a/drivers/net/ice/ice_tm.c +++

[PATCH v3 7/9] net/ice: support queue weight configuration

This patch adds queue weight configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 5ebf9abeb9..070cb7db41 100644 --- a/drivers/net/i

[PATCH v3 6/9] net/ice: support queue priority configuration

This patch adds queue priority configuration support. The highest priority is 0, and the lowest priority is 7. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_

[PATCH v3 5/9] net/ice: support queue group bandwidth limit

To set up the exact queue group, we need to reconfigure topology by delete and then recreate queue nodes. This patch adds queue group configuration support and queue group bandwidth limit support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_ethdev.h | 9 +- drivers/net/ice/ice_tm.c |

[PATCH v3 4/9] net/ice: support queue bandwidth limit

From: Ting Xu Enable basic TM API for PF only. Support for adding profiles and queue nodes. Only max bandwidth is supported in profiles. Profiles can be assigned to target queues. Only TC0 is valid. Signed-off-by: Wenjun Wu Signed-off-by: Ting Xu --- drivers/net/ice/ice_ethdev.c | 19 ++ dri

[PATCH v3 3/9] net/ice/base: support queue BW allocation configuration

This patch adds BW allocation support of queue scheduling node to support WFQ in queue level. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 64 drivers/net/ice/base/ice_sched.h | 3 ++ 2 files changed, 67 insertions(+) diff --git a/drivers/net

[PATCH v3 2/9] net/base/ice: support priority configuration of the exact node

This patch adds priority configuration support of the exact node in the scheduler tree. This function does not need additional calls to the scheduler lock. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 21 + drivers/net/ice/base/ice_sched.h | 3 +++ 2 files

[PATCH v3 1/9] net/ice/base: fix dead lock issue when getting node from ID type

The function ice_sched_get_node_by_id_type needs to be called with the scheduler lock held. However, the function ice_sched_get_node also requests the scheduler lock. It will cause the dead lock issue. This patch replaces function ice_sched_get_node with function ice_sched_find_node_by_teid to sol

[PATCH v3 0/9] Enable ETS-based TX QoS on PF

This patch set enables ETS-based TX QoS on PF. It is supported to configure bandwidth and priority in both queue and queue group level, and weight only in queue level. v2: fix code style issue. v3: fix uninitialization issue Ting Xu (1): net/ice: support queue bandwidth limit Wenjun Wu (8):

[PATCH v1 3/3] net/iavf: support quanta size configuration

This patch adds quanta size configuration support. Quanta size should between 256 and 4096, and be a product of 64. Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf.h| 3 +++ drivers/net/iavf/iavf_ethdev.c | 37 ++ drivers/net/iavf/iavf_vchnl.c | 28 ++

[PATCH v1 2/3] net/iavf: support queue rate limit configuration

This patch adds queue rate limit configuration support. Only max bandwidth is supported. Signed-off-by: Ting Xu Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf.h | 13 +++ drivers/net/iavf/iavf_tm.c| 189 -- drivers/net/iavf/iavf_vchnl.c | 23 +

[PATCH v1 1/3] common/iavf: support queue rate limit and quanta size configuration

This patch adds new virtchnl opcodes and structures for rate limit and quanta size configuration, which include: 1. VIRTCHNL_OP_CONFIG_QUEUE_BW, to configure max bandwidth for each VF per queue. 2. VIRTCHNL_OP_CONFIG_QUANTA, to configure quanta size per queue. Signed-off-by: Ting Xu Signed-off-by

[PATCH v1 0/3] Enable queue rate limit and quanta size configuration

This patch set adds queue rate limit and quanta size configuration. Quanta size can be changed by driver devarg quanta_size=xxx. Quanta size should be set to the value between 256 and 4096 and be the product of 64. Wenjun Wu (3): common/iavf: support queue rate limit and quanta size configuratio

[PATCH v2 9/9] net/ice: add warning log for unsupported configuration

Priority configuration is enabled in level 3 and level 4. Weight configuration is enabled in level 4. This patch adds warning log for unsupported priority and weight configuration. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/

[PATCH v2 8/9] net/ice: support queue group priority configuration

This patch adds queue group priority configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 070cb7db41..8a71bfa599 100644 --- a/drivers/net/ice/ice_tm.c +++

[PATCH v2 7/9] net/ice: support queue weight configuration

This patch adds queue weight configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 5ebf9abeb9..070cb7db41 100644 --- a/drivers/net/i

[PATCH v2 6/9] net/ice: support queue priority configuration

This patch adds queue priority configuration support. The highest priority is 0, and the lowest priority is 7. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_

[PATCH v2 5/9] net/ice: support queue group bandwidth limit

To set up the exact queue group, we need to reconfigure topology by delete and then recreate queue nodes. This patch adds queue group configuration support and queue group bandwidth limit support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_ethdev.h | 9 +- drivers/net/ice/ice_tm.c |

[PATCH v2 4/9] net/ice: support queue bandwidth limit

From: Ting Xu Enable basic TM API for PF only. Support for adding profiles and queue nodes. Only max bandwidth is supported in profiles. Profiles can be assigned to target queues. Only TC0 is valid. Signed-off-by: Wenjun Wu Signed-off-by: Ting Xu --- drivers/net/ice/ice_ethdev.c | 19 ++ dri

[PATCH v2 3/9] net/ice/base: support queue BW allocation configuration

This patch adds BW allocation support of queue scheduling node to support WFQ in queue level. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 64 drivers/net/ice/base/ice_sched.h | 3 ++ 2 files changed, 67 insertions(+) diff --git a/drivers/net

[PATCH v2 2/9] net/base/ice: support priority configuration of the exact node

This patch adds priority configuration support of the exact node in the scheduler tree. This function does not need additional calls to the scheduler lock. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 21 + drivers/net/ice/base/ice_sched.h | 3 +++ 2 files

[PATCH v2 1/9] net/ice/base: fix dead lock issue when getting node from ID type

The function ice_sched_get_node_by_id_type needs to be called with the scheduler lock held. However, the function ice_sched_get_node also requests the scheduler lock. It will cause the dead lock issue. This patch replaces function ice_sched_get_node with function ice_sched_find_node_by_teid to sol

[PATCH v2 0/9] Enable ETS-based TX QoS on PF

This patch set enables ETS-based TX QoS on PF. It is supported to configure bandwidth and priority in both queue and queue group level, and weight only in queue level. v2: fix code style issue. Ting Xu (1): net/ice: support queue bandwidth limit Wenjun Wu (8): net/ice/base: fix dead lock iss

RE: [RFC 1/2] vhost: add unsafe API to check inflight packets

Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, March 28, 2022 11:05 PM > To: Ding, Xuan ; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Pai G, Sunil > > Subject: Re: [RFC 1/2] vhost: add unsafe API to check inflight packets > > Hi Xuan, > > On 2/16/22 08:04, xua

RE: [PATCH v3] raw/ifpga: remove vdev when ifpga is closed

Got it, thanks. > -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, March 29, 2022 10:15 > To: Huang, Wei ; dev@dpdk.org; > tho...@monjalon.net; Xu, Rosen ; > nipun.gu...@nxp.com; hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > > Subject: RE: [PATCH v

RE: [PATCH v3] raw/ifpga: remove vdev when ifpga is closed

> -Original Message- > From: Huang, Wei > Sent: Tuesday, March 29, 2022 9:56 AM > To: dev@dpdk.org; tho...@monjalon.net; Xu, Rosen > ; nipun.gu...@nxp.com; hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Zhang, Tianfei ; Zhang, Qi Z > ; Yigit, Ferruh > Subject: RE: [PATCH v3] raw/ifpga: re

[PATCH v1 9/9] net/ice: add warning log for unsupported configuration

Priority configuration is enabled in level 3 and level 4. Weight configuration is enabled in level 4. This patch adds warning log for unsupported priority and weight configuration. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/

[PATCH v1 8/9] net/ice: support queue group priority configuration

This patch adds queue group priority configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 36981f78dd..fdbb415eda 100644 --- a/drivers/net/ice/ice_tm.c +++

[PATCH v1 7/9] net/ice: support queue weight configuration

This patch adds queue weight configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 9552158b53..36981f78dd 100644 --- a/drivers/net/i

[PATCH v1 6/9] net/ice: support queue priority configuration

This patch adds queue priority configuration support. The highest priority is 0, and the lowest priority is 7. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_

[PATCH v1 5/9] net/ice: support queue group bandwidth limit

To set up the exact queue group, we need to reconfigure topology by delete and then recreate queue nodes. This patch adds queue group configuration support and queue group bandwidth limit support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_ethdev.h | 9 +- drivers/net/ice/ice_tm.c |

[PATCH v1 4/9] net/ice: support queue bandwidth limit

From: Ting Xu Enable basic TM API for PF only. Support for adding profiles and queue nodes. Only max bandwidth is supported in profiles. Profiles can be assigned to target queues. Only TC0 is valid. Signed-off-by: Wenjun Wu Signed-off-by: Ting Xu --- drivers/net/ice/ice_ethdev.c | 19 ++ dri

[PATCH v1 3/9] net/ice/base: support queue BW allocation configuration

This patch adds BW allocation support of queue scheduling node to support WFQ in queue level. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 64 drivers/net/ice/base/ice_sched.h | 3 ++ 2 files changed, 67 insertions(+) diff --git a/drivers/net

[PATCH v1 2/9] net/base/ice: support priority configuration of the exact node

This patch adds priority configuration support of the exact node in the scheduler tree. This function does not need additional calls to the scheduler lock. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 21 + drivers/net/ice/base/ice_sched.h | 3 +++ 2 files

[PATCH v1 1/9] net/ice/base: fix dead lock issue when getting node from ID type

The function ice_sched_get_node_by_id_type needs to be called with the scheduler lock held. However, the function ice_sched_get_node also requests the scheduler lock. It will cause the dead lock issue. This patch replaces function ice_sched_get_node with function ice_sched_find_node_by_teid to sol

[PATCH v1 0/9] Enable ETS-based TX QoS on PF

This patch set enables ETS-based TX QoS on PF. It is supported to configure bandwidth and priority in both queue and queue group level, and weight only in queue level. Ting Xu (1): net/ice: support queue bandwidth limit Wenjun Wu (8): net/ice/base: fix dead lock issue when getting node from I

RE: [PATCH v3] raw/ifpga: remove vdev when ifpga is closed

Hi Thomas, Would you please check this patch is acceptable ? > -Original Message- > From: Huang, Wei > Sent: Friday, March 18, 2022 16:58 > To: dev@dpdk.org; tho...@monjalon.net; Xu, Rosen > ; nipun.gu...@nxp.com; hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Zhang, Tianfei ; Zhang, Qi Z

Re: [PATCH] meson: update doc logic for Windows

2022-03-28 12:29 (UTC+), Varghese, Vipin: [...] > > We did get error from `doc/meson` stating ` echo command not available > > on windows` for both cmd and powershell for the line ``` > > run_target('doc', command: [echo, message, doc_target_names], > > depends: doc_targets) > > ``` >

RE: OVS DPDK DMA-Dev library/Design Discussion

Hi All, Please see below PDF which will be presented in the call. https://github.com/Sunil-Pai-G/OVS-DPDK-presentation-share/blob/main/OVS%20vhost%20async%20datapath%20design%202022%20session%202.pdf Thanks and Regards, Sunil -Original Appointment- From: Stokes, Ian S

RE: [PATCH] net/iavf: remove extra copy step in Rx bulk path

The failure in ci/iol-broadcom-Functional on this patch seems to be unrelated to the patch. > -Original Message- > From: Kathleen Capella > Sent: Thursday, March 24, 2022 5:12 PM > To: Jingjing Wu ; Beilei Xing > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Dharmik Thakkar > ; Kathle

Re: 20.11.5 patches review and test

On Mon, 2022-03-28 at 14:55 +0200, Christian Ehrhardt wrote: > > > On Mon, Mar 28, 2022 at 1:50 PM Luca Boccassi > wrote: > > On Mon, 2022-03-28 at 09:40 +0200, Christian Ehrhardt wrote: > > > On Fri, Mar 18, 2022 at 4:21 PM wrote: > > > > > > > > Hi all, > > > > > > > > Here is a list of pat

Re: [RFC 2/2] examples/vhost: use API to check inflight packets

Hi Xuan, On 2/16/22 08:04, xuan.d...@intel.com wrote: From: Xuan Ding In async data path, call rte_vhost_async_get_inflight_thread_unsafe() API to directly return the number of inflight packets instead of maintaining a local variable. Signed-off-by: Xuan Ding --- examples/vhost/main.c | 28

[PATCH v7] net/bonding: another fix to LACP mempool size

The following log message may appear after a slave is idle(or nearly idle) for a few minutes:"PMD: Failed to allocate LACP packet from pool". And bond mode 4 negotiation may fail. Problem:When bond mode 4 has been chosed and delicated queue has not been enable, all mbufs from a slave' private pool

Re: [RFC 1/2] vhost: add unsafe API to check inflight packets

Hi Xuan, On 2/16/22 08:04, xuan.d...@intel.com wrote: From: Xuan Ding In async data path, when vring state changes or device is destroyed, it is necessary to know the number of inflight packets in DMA engine. This patch provides a thread unsafe API to return the number of inflight packets for

Re: [PATCH v2 1/5] vhost: fix missing virtqueue lock protection

On 3/28/22 10:07, David Marchand wrote: On Thu, Mar 24, 2022 at 1:46 PM Maxime Coquelin wrote: This patch ensures virtqueue metadata are not being modified while rte_vhost_vring_call() is executed. Fixes: 6c299bb7322f ("vhost: introduce vring call API") Cc: sta...@dpdk.org Signed-off-by:

RE: [PATCH] dma/skeleton: support multiple instances

[AMD Official Use Only] Verified on ` AMD EPYC 7713 64-Core Processor` platform with argument ` --vdev=dma_skeleton0,lcore=4 --vdev=dma_skeleton1,lcore=5`. Tested-by: Vipin Varghese -Original Message- From: Sivaprasad Tummala Sent: Monday, March 28, 2022 7:53 PM To: fengcheng...@hua

RE: [PATCH] meson: update doc logic for Windows

[AMD Official Use Only] > > 26/03/2022 03:59, Vipin Varghese: > > Support for shell scripts doxy-html-custom, generate_doxygen and > > generate_examples are absent. The current patch address the same by > > disabling document build notifying the user. > > It should not prevent generating guides

[PATCH] dma/skeleton: support multiple instances

dpdk app can support multiple hardware dma instances. with dma skeleton, only a single instance can be configured. This patch supports multiple driver instances per device. Signed-off-by: Sivaprasad Tummala --- drivers/dma/skeleton/skeleton_dmadev.c | 37 +++--- 1 file chang

[Bug 984] [20.11] pmdinfogen build failure with gcc 4.8.5

https://bugs.dpdk.org/show_bug.cgi?id=984 Bug ID: 984 Summary: [20.11] pmdinfogen build failure with gcc 4.8.5 Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[PATCH] dma/skeleton: support multiple instances

dpdk app can support multiple hardware dma instances. with dma skeleton, only a single instance can be configured. This patch supports multiple driver instances per device. Signed-off-by: Sivaprasad Tummala --- drivers/dma/skeleton/skeleton_dmadev.c | 41 +++--- 1 file chang

Re: 20.11.5 patches review and test

On Mon, Mar 28, 2022 at 1:50 PM Luca Boccassi wrote: > On Mon, 2022-03-28 at 09:40 +0200, Christian Ehrhardt wrote: > > On Fri, Mar 18, 2022 at 4:21 PM wrote: > > > > > > Hi all, > > > > > > Here is a list of patches targeted for stable release 20.11.5. > > > > Hi Luca, > > this backport > > > h

RE: [PATCH] meson: update doc logic for Windows

[AMD Official Use Only] Hi Dmitry, Thanks for inputs, please find my question below 2022-03-28 03:02 (UTC+), Varghese, Vipin: > [AMD Official Use Only] > > Hi Thomas, > > > > Thank you for looking at this problem. > > 26/03/2022 03:59, Vipin Varghese: > > Support for shell scripts doxy-ht

[RFC PATCH 5/5] vhost: annotate IOTLB locks

The IOTLB code uses r/w locks. Introduce a wrapper around this type of locks and annotate iotlb_lock and iotlb_pending_lock. clang does not support conditionally held locks, so always take iotlb locks regardless of VIRTIO_F_IOMMU_PLATFORM feature. vdpa and vhost_crypto code are annotated though

[RFC PATCH 4/5] vhost: annotate async locking requirement

Instrument that the async field of a virtqueue must be protected by a lock. Signed-off-by: David Marchand --- lib/vhost/vhost.c | 14 +- lib/vhost/vhost.h | 5 - lib/vhost/vhost_user.c | 2 ++ lib/vhost/virtio_net.c | 14 ++ 4 files changed, 29 insertions(

[RFC PATCH 3/5] vhost: fix async access

vq->async is protected with vq->access_lock. Fixes: eb666d24085f ("vhost: fix async unregister deadlock") Fixes: 0c0935c5f794 ("vhost: allow to check in-flight packets for async vhost") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- This has been reported by Jiayu too: https://patchwork.d

[RFC PATCH 2/5] vhost: annotate virtqueue access lock

Introduce a wrapper around spinlocks and annotate the access_lock lock protecting vq. One small change is required in the code: vhost_poll_enqueue_completed was getting a queue_id to get hold of the vq, while its callers already knew of the vq. vq is now directly passed. Signed-off-by: David Marc

[RFC PATCH 1/5] vhost: fix missing virtqueue lock protection

From: Maxime Coquelin This patch ensures virtqueue metadata are not being modified while rte_vhost_vring_call() is executed. Fixes: 6c299bb7322f ("vhost: introduce vring call API") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --- This is the same as: https:/

[RFC PATCH 0/5] vhost lock annotations

vhost internals involves multiple locks to protect data access by multiple threads. This series is a try at using clang thread safety checks [1] to catch issues during compilation: spinlock and rwlock are wrapped into vhost types and annotations are put all over the code. Patch 1 is a fix from M

[dpdk-dev] examples/ethtool: issue in rte_ethtool_net_open()

Hi, I have a question from dpdk-ethtool. *file: examples/ethtool/lib/rte_ethtool.c* *intrte_ethtool_net_open(uint16_t port_id){ int ret; ret = rte_eth_dev_stop(port_id); if (ret != 0) return ret; return rte_eth_dev_start(port_id);}* Does anyone know the purpose of calling rte_eth_dev_

Re: 20.11.5 patches review and test

On Mon, 2022-03-28 at 09:40 +0200, Christian Ehrhardt wrote: > On Fri, Mar 18, 2022 at 4:21 PM wrote: > > > > Hi all, > > > > Here is a list of patches targeted for stable release 20.11.5. > > Hi Luca, > this backport > https://git.dpdk.org/dpdk-stable/commit/?h=20.11&id=64452c878f225c147dfb715

RE: [RFC] eal: add seqlock

> >> diff --git a/lib/eal/include/meson.build b/lib/eal/include/meson.build > >> index 9700494816..48df5f1a21 100644 > >> --- a/lib/eal/include/meson.build > >> +++ b/lib/eal/include/meson.build > >> @@ -36,6 +36,7 @@ headers += files( > >> 'rte_per_lcore.h', > >> 'rte_random.h

[PATCH] examples/ipsec-secgw: destroy lookaside sessions

Lookaside mode also creates security and crypto sessions that needs to be destroyed after they are no longer used. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec-secgw.c | 48 +- examples/ipsec-secgw/ipsec.c | 12 2 files changed, 40 ins

[PATCH] common/cnxk: fix missing null check for inline device

Inline device could be null in cases when it was not bound or missing. Added check to prevent null pointer access. Fixes: fe5846bcc07 ("net/cnxk: add devargs for min-max SPI") Cc: sta...@dpdk.org Signed-off-by: Volodymyr Fialko --- drivers/common/cnxk/roc_nix_inl.c | 2 ++ 1 file changed, 2 in

Re: [PATCH] app/testpmd: fix quit testpmd with vfs and pf

On 3/22/2022 12:48 PM, Ke Zhang wrote: When testpmd startups with pf and vfs,this error occurs when quitting, results in pf is released before vfs ,so the vf would access an freed heap memory. The solution is two steps: 1. Fetch the valid port value from RTE_ETH_FOREACH_DEV. 2. free the port

Re: [PATCH] meson: update doc logic for Windows

2022-03-28 03:02 (UTC+), Varghese, Vipin: > [AMD Official Use Only] > > Hi Thomas, > > > > Thank you for looking at this problem. > > 26/03/2022 03:59, Vipin Varghese: > > Support for shell scripts doxy-html-custom, generate_doxygen and > > generate_examples are absent. The current patch

[RFC] net/i40e: backport i40e fixes and share code to 21.11

Backport all the i40e share code to 21.11 based on cid-i40e.2022.03.08. Backport all the iavf share code to 21.11 based on cid-avf.2022.03.08. Backport all DPDK bug fixes of i40e and iavf to 21.11 from 22.03. Signed-off-by: Steve Yang --- drivers/common/iavf/README | 2 +- dri

[RFC] net/i40e: backport i40e fixes and share code to 19.11.11

Backport all the i40e share code to 19.11.11 based on cid-i40e.2022.03.08. Backport all DPDK bug fixes of i40e & i40evf to 19.11.11 from 22.03. Signed-off-by: Steve Yang --- drivers/net/i40e/base/README| 2 +- drivers/net/i40e/base/i40e_adminq.c | 217 -- drivers/net/i40e/

Re: [PATCH v2 1/5] vhost: fix missing virtqueue lock protection

On Thu, Mar 24, 2022 at 1:46 PM Maxime Coquelin wrote: > > This patch ensures virtqueue metadata are not being > modified while rte_vhost_vring_call() is executed. > > Fixes: 6c299bb7322f ("vhost: introduce vring call API") > Cc: sta...@dpdk.org > > Signed-off-by: Maxime Coquelin > --- > lib/vho

[PATCH v5 16/16] vhost: make sure each queue callfd is configured

During the vhost data path building process, qemu will create a call fd at first, and create another call fd in the end. The final call fd will be used to relay notify. In the original code, after kick fd is set, dev_conf will set the first call fd. Even though the actual call fd will set, the data

[PATCH v5 15/16] vdpa/ifc: make sure hardware last_avail_idx and last_used_idx is the same when blk device pause

When virtio blk device is pause, make sure hardware last_avail_idx and last_used_idx are the same. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 2 +- drivers/vdpa/ifc/base/ifcvf.h | 3 +++ drivers/vdpa/ifc/ifcvf_vdpa.c | 32 +++- 3 files changed, 27 i

[PATCH v5 14/16] vdpa/ifc/base: for blk device, live migration register is different from net device

1.last_avail_idx is lower 16 bit of the register. 2.address of ring_state register is different between net and blk device. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 36 +--- drivers/vdpa/ifc/base/ifcvf.h | 1 + 2 files changed, 30 insertions(+)

[PATCH v5 13/16] vdpa/ifc: add is_blk flag to ifcvf_hw, and init is_blk during probe

Add is_blk flag to ifcvf_hw, and init is_blk during probe. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 1 + drivers/vdpa/ifc/ifcvf_vdpa.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h index 6dd7925..8e602af 10

[PATCH v5 12/16] vdpa: add config space change interrupt register and handle for virtio_blk

Create a thread to poll and relay config space change interrupt. Use VHOST_USER_SLAVE_CONFIG_CHANGE_MSG to info qemu. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 112 ++ 1 file changed, 112 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf

[PATCH v5 11/16] vdpa/ifc: read virtio max_queues from hardware

Original code max_queues is set to IFCVF_MAX_QUEUES. New code max_queues is the min of IFCVF_MAX_QUEUES and hardware num_queues. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcv

[PATCH v5 10/16] vdpa/ifc: add some log at VDPA launch before qemu connect

Add some log of virtio blk device config space information at VDPA launch before qemu connects. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.

[PATCH v5 09/16] vdpa/ifc: set_vring_state op is mandatory, add set_vring_state for blk device

Set_vring_state op is mandatory, add set_vring_state for blk device. Currently set_vring_state for blk device is not implemented. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa

[PATCH v5 08/16] usertools: add support for virtio blk device

Add virtio blk device support to devbind. Signed-off-by: Andy Pei --- usertools/dpdk-devbind.py | 8 1 file changed, 8 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index ace4627..cbe336f 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-dev

[PATCH v5 07/16] example/vdpa:add vdpa blk support in example

Add virtio blk device support to vdpa example. Signed-off-by: Andy Pei --- examples/vdpa/main.c | 61 +- examples/vdpa/vdpa_blk_compact.h | 72 + examples/vdpa/vhost_user.h | 169 +++ 3 files changed, 301 inserti

[PATCH v5 06/16] vdpa/ifc: add block device SW live-migration

Add SW live-migration support to block device. Add dirty page logging to block device. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 4 +- drivers/vdpa/ifc/base/ifcvf.h | 6 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 128 +++--- 3 files changed, 115

[PATCH v5 05/16] vdpa/ifc: add vdpa interrupt for blk device

For the block device type, we have to relay the commands on all queues. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 46 --- 1 file changed, 35 insertions(+), 11 deletions(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifc

[PATCH v5 04/16] vdpa/ifc: add blk ops for ifc device

For virtio blk device, re-use part of ifc driver ops. Implement ifcvf_blk_get_config for virtio blk device. Support VHOST_USER_PROTOCOL_F_CONFIG feature for virtio blk device. Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/base/ifcvf.h | 4 ++ drivers/vdpa/ifc/ifcvf_

[PATCH v5 03/16] vhost: add support for VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG

Add support for VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG. VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG message is only supported by virtio blk VDPA device. Signed-off-by: Andy Pei --- lib/vhost/vhost_user.c | 50 ++ lib/vhost/vhost_user.h

[PATCH v5 02/16] vhost: add vdpa ops for blk device

Get_config and set_config are necessary ops for blk device. Add get_config and set_config ops to vdpa ops. Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- lib/vhost/vdpa_driver.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vdpa_driver.h b/lib/v

  1   2   >