RE: [PATCH] net/iavf: fix segmentation offload buffer size

2022-02-14 Thread Zhang, Qi Z
> -Original Message- > From: Huang, ZhiminX > Sent: Tuesday, February 15, 2022 2:17 PM > To: Nicolau, Radu ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; Jiang, YuX ; Nicolau, Radu > > Subject: RE: [PATCH] net/iavf: fix segmentation offload buffer size > > > -Original Messag

[PATCH v1] ethdev: beautify the Rx desc number check indent

2022-02-14 Thread Haiyue Wang
Align to Tx desc number check indent, which may help to understand Rx descriptor limits member in the alignment comparison view. And remove the extra empty line. Signed-off-by: Haiyue Wang --- lib/ethdev/rte_ethdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/et

[PATCH v3 2/2] vhost: fix physical address mapping

2022-02-14 Thread xuan . ding
From: Xuan Ding When choosing IOVA as PA mode, IOVA is likely to be discontinuous, which requires page by page mapping for DMA devices. To be consistent, this patch implements page by page mapping instead of mapping at the region granularity for both IOVA as VA and PA mode. Fixes: 7c61fa08b716 (

[PATCH v3 1/2] vhost: fix field naming in guest page struct

2022-02-14 Thread xuan . ding
From: Xuan Ding This patch renames the host_phys_addr to host_iova in guest_page struct. The host_phys_addr is iova, it depends on the DPDK IOVA mode. Fixes: e246896178e6 ("vhost: get guest/host physical address mappings") Cc: sta...@dpdk.org Signed-off-by: Xuan Ding Reviewed-by: Maxime Coquel

[PATCH v3 0/2] vhost: fix async address mapping

2022-02-14 Thread xuan . ding
From: Xuan Ding This patchset fixes the issue of incorrect DMA mapping in PA mode. Due to the ambiguity of host_phys_addr naming in the guest page struct, rename it to host_iova. v3: * Fix some format issues. v2: * Change the order of patch. Xuan Ding (2): vhost: fix field naming in guest pa

RE: [PATCH] net/iavf: fix segmentation offload buffer size

2022-02-14 Thread Huang, ZhiminX
> -Original Message- > From: Radu Nicolau > Sent: Thursday, February 10, 2022 9:09 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Jiang, YuX ; Nicolau, Radu > > Subject: [PATCH] net/iavf: fix segmentation offload buffer size > > This reverts commit ff8b8bcd2ebe, which resulted

Re: out of tree driver builds broken with C++

2022-02-14 Thread Tyler Retzlaff
On Mon, Feb 14, 2022 at 10:22:08AM +0100, Thomas Monjalon wrote: > 14/02/2022 10:13, Tyler Retzlaff: > > while the driver api is "internal" we agreed some time ago that drivers > > could be built external to the dpdk tree. by enabling the meson setup > > option -Denable_driver_sdk=true. > > > > it

RE: [PATCH v4] app/eventdev: add crypto producer mode

2022-02-14 Thread Gujjar, Abhinandan S
Hi Shijith, > -Original Message- > From: Shijith Thotton > Sent: Tuesday, February 8, 2022 10:03 PM > To: dev@dpdk.org; jer...@marvell.com; Gujjar, Abhinandan S > > Cc: Shijith Thotton > Subject: [PATCH v4] app/eventdev: add crypto producer mode > > In crypto producer mode, producer co

RE: [PATCH v3 1/2] net/iavf: support L2TPv2 for AVF RSS

2022-02-14 Thread Xing, Beilei
> -Original Message- > From: Wang, Jie1X > Sent: Friday, February 11, 2022 4:09 PM > To: dev@dpdk.org > Cc: Yang, SteveX ; Wu, Jingjing > ; Xing, Beilei ; Zhang, Qi Z > ; Wang, Jie1X > Subject: [PATCH v3 1/2] net/iavf: support L2TPv2 for AVF RSS > > Add support for L2TPv2(include PPP

[PATCH] net/enic: fix dereference before null check

2022-02-14 Thread John Daley
This patch fixes an issue found by coverity. It checks for a possible null value of "error" before dereferencing it. CID: 375064: Dereference after null check Either the check against null is unnecessary, or there may be a null pointer dereference. Coverity issue: 375064 Fixes: ee806eea59fe ("net

Re: [PATCH v2] kni: fix use-after-free when kni release

2022-02-14 Thread Ferruh Yigit
On 2/9/2022 7:35 AM, Min Hu (Connor) wrote: From: Huisong Li The "kni_dev" is the private data of the "net_device" in kni, and allocated with the "net_device" by calling "alloc_netdev()". The "net_device" is freed by calling "free_netdev()" when kni release. The freed memory includes the "kni_d

Re: out of tree driver builds broken with C++

2022-02-14 Thread Tyler Retzlaff
On Mon, Feb 14, 2022 at 10:32:24AM -0800, Tyler Retzlaff wrote: > On Mon, Feb 14, 2022 at 10:21:20AM -0800, Stephen Hemminger wrote: > > On Mon, 14 Feb 2022 18:49:48 +0100 > > Thomas Monjalon wrote: > > > > > 14/02/2022 18:t24, Stephen Hemminger: > > > > On Mon, 14 Feb 2022 15:03:43 + > > > >

Re: out of tree driver builds broken with C++

2022-02-14 Thread Tyler Retzlaff
On Mon, Feb 14, 2022 at 10:21:20AM -0800, Stephen Hemminger wrote: > On Mon, 14 Feb 2022 18:49:48 +0100 > Thomas Monjalon wrote: > > > 14/02/2022 18:t24, Stephen Hemminger: > > > On Mon, 14 Feb 2022 15:03:43 + > > > Bruce Richardson wrote: > > > > > > > On Mon, Feb 14, 2022 at 11:43:35AM

Re: [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events

2022-02-14 Thread Ray Kinsella
Thomas Monjalon writes: > 14/02/2022 17:06, Ray Kinsella: >> Thomas Monjalon writes: >> > 14/02/2022 11:16, Ray Kinsella: >> >> Ray Kinsella writes: >> >> > Thomas Monjalon writes: >> >> >> 02/02/2022 12:44, Ray Kinsella: >> >> >>> Ferruh Yigit writes: >> >> >>> > On 1/28/2022 12:48 PM, Kal

Re: out of tree driver builds broken with C++

2022-02-14 Thread Stephen Hemminger
On Mon, 14 Feb 2022 18:49:48 +0100 Thomas Monjalon wrote: > 14/02/2022 18:t24, Stephen Hemminger: > > On Mon, 14 Feb 2022 15:03:43 + > > Bruce Richardson wrote: > > > > > On Mon, Feb 14, 2022 at 11:43:35AM +, Bruce Richardson wrote: > > > > On Mon, Feb 14, 2022 at 12:19:24PM +0100,

Re: out of tree driver builds broken with C++

2022-02-14 Thread Bruce Richardson
On Mon, Feb 14, 2022 at 09:24:35AM -0800, Stephen Hemminger wrote: > On Mon, 14 Feb 2022 15:03:43 + > Bruce Richardson wrote: > > > On Mon, Feb 14, 2022 at 11:43:35AM +, Bruce Richardson wrote: > > > On Mon, Feb 14, 2022 at 12:19:24PM +0100, Thomas Monjalon wrote: > > > > 14/02/2022 11:

Re: [PATCH 6/6] drivers/nfb: add support for more MAC addresses

2022-02-14 Thread Ferruh Yigit
On 2/14/2022 4:53 PM, Martin Spinler wrote: On Mon, 2022-02-14 at 13:37 +, Ferruh Yigit wrote: On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: From: Martin Spinler Extend the eth_dev_ops by add/remove MAC address functions. Signed-off-by: Martin Spinler --- drivers/net/nfb/nfb_ethdev

Re: out of tree driver builds broken with C++

2022-02-14 Thread Thomas Monjalon
14/02/2022 18:t24, Stephen Hemminger: > On Mon, 14 Feb 2022 15:03:43 + > Bruce Richardson wrote: > > > On Mon, Feb 14, 2022 at 11:43:35AM +, Bruce Richardson wrote: > > > On Mon, Feb 14, 2022 at 12:19:24PM +0100, Thomas Monjalon wrote: > > > > 14/02/2022 11:45, Bruce Richardson: > > >

Re: [PATCH 3/6] drivers/nfb: do not report zero-sized TX burst

2022-02-14 Thread Ferruh Yigit
On 2/14/2022 4:53 PM, Martin Spinler wrote: On Mon, 2022-02-14 at 13:35 +, Ferruh Yigit wrote: On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: From: Martin Spinler Zero-sized TX burst floods the log no more. If you want this patch to be backported, you can update commit log as fix and

Re: [PATCH] devargs: Fix crash due to global devargs uninitailization from secondary process

2022-02-14 Thread Ferruh Yigit
On 2/14/2022 5:08 PM, madhuker.myt...@oracle.com wrote: From: Madhuker Mythri Failsafe pmd started crashing with global devargs syntax as devargs is not memset to zero. Access it to in rte_devargs_parse() resulted in a crash when called from secondary process. Bugzilla Id: 933 Signed-off-by:

Re: out of tree driver builds broken with C++

2022-02-14 Thread Stephen Hemminger
On Mon, 14 Feb 2022 15:03:43 + Bruce Richardson wrote: > On Mon, Feb 14, 2022 at 11:43:35AM +, Bruce Richardson wrote: > > On Mon, Feb 14, 2022 at 12:19:24PM +0100, Thomas Monjalon wrote: > > > 14/02/2022 11:45, Bruce Richardson: > > > > On Mon, Feb 14, 2022 at 10:22:08AM +0100, Thoma

RE: [PATCH] eventdev/eth_rx: fix queue config get API

2022-02-14 Thread Naga Harish K, S V
Hi Jay, > -Original Message- > From: Jayatheerthan, Jay > Sent: Monday, February 14, 2022 10:39 PM > To: Jerin Jacob ; Naga Harish K, S V > > Cc: Jerin Jacob ; dpdk-dev > Subject: RE: [PATCH] eventdev/eth_rx: fix queue config get API > > Hi Harish, > > > -Original Message- > >

[PATCH v2] eventdev/eth_rx: fix queue config get logic

2022-02-14 Thread Naga Harish K S V
remove the memcpy usage in queue config get function for `event` variable which is 8 byte size and use direct copy. Also provide vector information and event buffer size in the queue config info. Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") Signed-off-by: Naga Harish K S V

RE: [PATCH] eventdev/eth_rx: fix queue config get API

2022-02-14 Thread Jayatheerthan, Jay
Hi Harish, > -Original Message- > From: Jerin Jacob > Sent: Monday, February 14, 2022 8:59 PM > To: Naga Harish K, S V > Cc: Jayatheerthan, Jay ; Jerin Jacob > ; dpdk-dev > Subject: Re: [PATCH] eventdev/eth_rx: fix queue config get API > > On Wed, Feb 9, 2022 at 10:40 AM Naga Harish K

[PATCH] devargs: Fix crash due to global devargs uninitailization from secondary process

2022-02-14 Thread madhuker . mythri
From: Madhuker Mythri Failsafe pmd started crashing with global devargs syntax as devargs is not memset to zero. Access it to in rte_devargs_parse() resulted in a crash when called from secondary process. Bugzilla Id: 933 Signed-off-by: Madhuker Mythri --- lib/eal/common/eal_common_devargs.c

Re: [PATCH v2] net/failsafe: link_update request crashing at boot

2022-02-14 Thread Stephen Hemminger
On Mon, 14 Feb 2022 13:09:19 + Vipul Ashri wrote: > PORT 0 supports 16 rx queues and 16 tx queues (driver_name = net_failsafe, > driver_type = 16) > > PORT 0 is polling for link-change, interrupts disabled > > [DPDK] tap_flow_create(): Kernel refused TC filter rule creation (17): File > e

Re: [PATCH 6/6] drivers/nfb: add support for more MAC addresses

2022-02-14 Thread Martin Spinler
On Mon, 2022-02-14 at 13:37 +, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > Extend the eth_dev_ops by add/remove MAC address functions. > > > > Signed-off-by: Martin Spinler > > --- > > drivers/net/nfb/nfb_ethdev.c | 69 +++

Re: [PATCH 5/6] drivers/nfb: fix multicast/promiscuous mode switching

2022-02-14 Thread Martin Spinler
On Mon, 2022-02-14 at 13:36 +, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > In the firmware, the promisc mode overrides the multicast mode. > > So when the promisc mode is turned off, driver must check if the > > multicast mode was act

Re: [PATCH 1/6] net/nfb: add missing libfdt dependency for build

2022-02-14 Thread Martin Spinler
On Mon, 2022-02-14 at 13:36 +, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > The driver uses some FDT manipulation functions from libfdt. > > Let the build system check for libfdt package. > > > > I don't see 'libfdt.h' included by th

Re: [PATCH 3/6] drivers/nfb: do not report zero-sized TX burst

2022-02-14 Thread Martin Spinler
On Mon, 2022-02-14 at 13:35 +, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > Zero-sized TX burst floods the log no more. > > > > If you want this patch to be backported, you can update > commit log as fix and add fixes & stable tags.

Re: [PATCH 2/6] drivers/nfb: fix array indexes in deinit functions

2022-02-14 Thread Martin Spinler
Hi Ferruh, thanks for all comments in this series. On Mon, 2022-02-14 at 13:34 +, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > The indexes in the for cycle were wrongly used and > > the code accessed outside of the rxmac/txmac array.

Re: [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events

2022-02-14 Thread Thomas Monjalon
14/02/2022 17:06, Ray Kinsella: > Thomas Monjalon writes: > > 14/02/2022 11:16, Ray Kinsella: > >> Ray Kinsella writes: > >> > Thomas Monjalon writes: > >> >> 02/02/2022 12:44, Ray Kinsella: > >> >>> Ferruh Yigit writes: > >> >>> > On 1/28/2022 12:48 PM, Kalesh A P wrote: > >> >>> >> --- a/lib/

Re: [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events

2022-02-14 Thread Ray Kinsella
Thomas Monjalon writes: > 14/02/2022 11:16, Ray Kinsella: >> Ray Kinsella writes: >> > Thomas Monjalon writes: >> >> 02/02/2022 12:44, Ray Kinsella: >> >>> Ferruh Yigit writes: >> >>> > On 1/28/2022 12:48 PM, Kalesh A P wrote: >> >>> >> --- a/lib/ethdev/rte_ethdev.h >> >>> >> +++ b/lib/ethde

RE: [PATCH v3] app/eventdev: add crypto producer mode

2022-02-14 Thread Gujjar, Abhinandan S
Hi Jerin, I have some issues with my sandbox after the recent upgrade. I am trying to get it working to test the patches. Hopefully, by 1-2 days I will give you update. Regards Abhinandan > -Original Message- > From: Jerin Jacob > Sent: Monday, February 14, 2022 8:57 PM > To: Shijith Th

[PATCH] build: make ring mempool driver mandatory

2022-02-14 Thread Bruce Richardson
The default mempool driver is one based on the rte_ring, and as such it needs to be present to have just about any app (which doesn't override the mempool) run. Given this state of affairs it is probably best to add this default mempool driver to the always-enabled list to ensure we get a runnable

Re: [PATCH] eventdev/eth_rx: fix queue config get API

2022-02-14 Thread Jerin Jacob
On Wed, Feb 9, 2022 at 10:40 AM Naga Harish K S V wrote: > > the memcpy size used in queue config get function is more than > the source size. Use correct size to avoid copy of unnecessary > data. > > Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") > > Signed-off-by: Naga Harish

Re: [PATCH v3] app/eventdev: add crypto producer mode

2022-02-14 Thread Jerin Jacob
On Tue, Feb 8, 2022 at 10:31 PM Shijith Thotton wrote: > > Please ack v4 if there are no more comments. Hi @Gujjar, Abhinandan S Any objection to merging the test application patch? > I tried adding support for software adapter implementation, but is getting a > crash in sw_event PMD after s

Re: [PATCH v2] eventdev/eth_tx: fix queue add logic

2022-02-14 Thread Jerin Jacob
On Fri, Feb 11, 2022 at 10:03 PM Jayatheerthan, Jay wrote: > > Looks good. Thanks. > > Acked-by: Jay Jayatheerthan Applied to dpdk-next-net-eventdev/for-main. Thanks > > -Jay > > > > > -Original Message- > > From: Naga Harish K, S V > > Sent: Wednesday, February 9, 2022 11:02 AM > > T

Re: out of tree driver builds broken with C++

2022-02-14 Thread Bruce Richardson
On Mon, Feb 14, 2022 at 11:43:35AM +, Bruce Richardson wrote: > On Mon, Feb 14, 2022 at 12:19:24PM +0100, Thomas Monjalon wrote: > > 14/02/2022 11:45, Bruce Richardson: > > > On Mon, Feb 14, 2022 at 10:22:08AM +0100, Thomas Monjalon wrote: > > > > 14/02/2022 10:13, Tyler Retzlaff: > > > > > whi

[PATCH v8 50/50] acl: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/acl/rte_acl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/acl/rte_acl.c b/lib/acl/rte_acl.c index 4e693b2488..a61c3ba188 100644 --- a/lib/acl/rte_acl.c +++ b/lib/acl/rte_acl.c @

[PATCH v8 49/50] cryptodev: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cryptodev/cryptodev_pmd.h | 4 lib/cryptodev/rte_cryptodev.c | 11 --- lib/cryptodev/rte_cryptodev.h | 2 -- 3 files changed, 17 deletions(-) diff --git a/lib/cryptodev/cry

[PATCH v8 48/50] bbdev: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/bbdev/rte_bbdev.c | 4 lib/bbdev/rte_bbdev.h | 4 2 files changed, 8 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index 7f353d4f7e..aaee7b7872 100644

[PATCH v8 47/50] bpf: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/bpf/bpf.c | 4 lib/bpf/bpf_exec.c | 6 -- lib/bpf/bpf_jit_x86.c | 5 - lib/bpf/bpf_load.c | 8 lib/bpf/bpf_pkt.c | 12 lib/bpf

[PATCH v8 46/50] cmdline: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cmdline/cmdline.c| 2 -- lib/cmdline/cmdline_parse.c | 3 --- lib/cmdline/cmdline_parse_portlist.c | 3 --- lib/cmdline/cmdline_parse_string.c | 4 lib/cmdl

[PATCH v8 45/50] compressdev: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/compressdev/rte_comp.c| 1 - lib/compressdev/rte_comp.h| 1 - lib/compressdev/rte_compressdev.c | 1 - lib/compressdev/rte_compressdev.h | 1 - lib/compress

[PATCH v8 44/50] distributor: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: David Hunt --- lib/distributor/rte_distributor.c | 2 -- lib/distributor/rte_distributor_match_sse.c | 2 -- lib/distributor/rte_distributor_single.c| 2 -- 3 files change

[PATCH v8 43/50] dmadev: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/dmadev/rte_dmadev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h index 4abe79c536..ad9e7a0975 100644 --- a/lib/dmadev/rte_dmadev.h +

[PATCH v8 42/50] efd: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/efd/rte_efd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index 86ef46863c..560cd78961 100644 --- a/lib/efd/rte_efd.c +++ b/lib/efd/rte_efd.

[PATCH v8 41/50] eventdev: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/eventdev/rte_event_ring.c | 6 -- lib/eventdev/rte_event_ring.h | 2 -- lib/eventdev/rte_event_timer_adapter.c | 5 - lib/eventdev/rte_event_timer_adapter.h |

[PATCH v8 40/50] fib: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/fib/dir24_8.c | 4 lib/fib/rte_fib.c | 2 -- lib/fib/rte_fib.h | 1 - lib/fib/rte_fib6.c | 2 -- lib/fib/rte_fib6.h | 1 - lib/fib/trie.c | 5 - lib/fib/trie.h | 2 --

[PATCH v8 39/50] flow_classify: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/flow_classify/rte_flow_classify.c | 3 --- lib/flow_classify/rte_flow_classify.h | 4 lib/flow_classify/rte_flow_classify_parse.c | 1 - lib/flow_classify/rte_flow_classif

[PATCH v8 38/50] gpudev: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gpudev/gpudev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c index ce92d63257..55a087bfb6 100644 --- a/lib/gpudev/gpudev.c +++ b/lib/gpudev/

[PATCH v8 37/50] graph: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/graph/graph_debug.c| 2 -- lib/graph/graph_ops.c | 1 - lib/graph/graph_populate.c | 2 -- lib/graph/node.c | 1 - 4 files changed, 6 deletions(-) diff --git a/lib/grap

[PATCH v8 36/50] gro: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gro/gro_tcp4.c | 1 - lib/gro/gro_tcp4.h | 2 -- lib/gro/gro_udp4.c | 1 - lib/gro/gro_udp4.h | 2 -- lib/gro/gro_vxlan_tcp4.c | 1 - lib/gro/gro_vxlan_udp4.c | 1 -

[PATCH v8 35/50] hash: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/hash/rte_cuckoo_hash.c | 4 lib/hash/rte_fbk_hash.c| 6 -- lib/hash/rte_fbk_hash.h| 1 - lib/hash/rte_thash.c | 1 - lib/hash/rte_thash.h | 1 - 5 files change

[PATCH v8 34/50] ip_frag: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ip_frag/rte_ip_frag_common.c | 1 - lib/ip_frag/rte_ipv4_fragmentation.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/ip_frag/rte_ip_frag_common.c b/lib/ip_frag/rte_ip_fra

[PATCH v8 33/50] ipsec: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ipsec/esp_inb.c | 1 - lib/ipsec/esp_outb.c | 1 - lib/ipsec/ipsec_sad.c | 1 - lib/ipsec/sa.c| 3 --- lib/ipsec/sa.h| 1 - 5 files changed, 7 deletions(-) diff --git a

[PATCH v8 32/50] jobstats: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/jobstats/rte_jobstats.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/jobstats/rte_jobstats.c b/lib/jobstats/rte_jobstats.c index 9b8fde5d55..af565a14ea 100644 --- a/lib/jobsta

[PATCH v8 31/50] kni: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kni/rte_kni.c | 2 -- lib/kni/rte_kni.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c index fc8f0e7b5a..7971c56bb4 100644 --- a/lib/kni/rte_kn

[PATCH v8 30/50] latencystats: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/latencystats/rte_latencystats.c | 4 1 file changed, 4 deletions(-) diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c index ab8db7a139..8985a377

[PATCH v8 29/50] lpm: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/lpm/rte_lpm.c | 7 --- lib/lpm/rte_lpm.h | 4 lib/lpm/rte_lpm6.c | 7 --- lib/lpm/rte_lpm6.h | 1 - 4 files changed, 19 deletions(-) diff --git a/lib/lpm/rte_lpm.c b/lib/lp

[PATCH v8 28/50] mbuf: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/mbuf/rte_mbuf.c | 11 --- lib/mbuf/rte_mbuf.h | 2 -- lib/mbuf/rte_mbuf_dyn.h | 2 -- lib/mbuf/rte_mbuf_pool_ops.c | 1 - lib/mbuf/rte_mbuf_pool_ops.h |

[PATCH v8 27/50] member: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/member/rte_member.c | 2 -- lib/member/rte_member.h | 1 - lib/member/rte_member_vbf.c | 1 - 3 files changed, 4 deletions(-) diff --git a/lib/member/rte_member.c b/lib/member/rte

[PATCH v8 26/50] mempool: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/mempool/rte_mempool.c | 7 --- lib/mempool/rte_mempool.h | 4 2 files changed, 11 deletions(-) diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index c5a699b1d6

[PATCH v8 25/50] metrics: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/metrics/rte_metrics.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/metrics/rte_metrics.c b/lib/metrics/rte_metrics.c index e2a0fbeda8..0c7878e65f 100644 --- a/lib/metrics/rte_

[PATCH v8 24/50] net: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/net/net_crc_avx512.c | 3 --- lib/net/net_crc_sse.c| 1 - lib/net/rte_arp.c| 1 - lib/net/rte_ether.h | 1 - lib/net/rte_net.h| 1 - lib/net/rte_net_crc.c| 2 -

[PATCH v8 23/50] node: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/node/ethdev_ctrl.c | 2 -- lib/node/ethdev_rx.c | 1 - lib/node/ethdev_tx.c | 1 - lib/node/ip4_lookup.c | 5 - lib/node/ip4_rewrite.c | 4 lib/node/pkt_cls.c | 4 l

[PATCH v8 22/50] pcapng: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 1 - lib/pcapng/rte_pcapng.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c inde

[PATCH v8 21/50] pci: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pci/rte_pci.c | 15 +-- lib/pci/rte_pci.h | 1 - 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/lib/pci/rte_pci.c b/lib/pci/rte_pci.c index c91be8b167..355772f

[PATCH v8 19/50] pipeline: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pipeline/rte_pipeline.c | 4 lib/pipeline/rte_port_in_action.c| 2 -- lib/pipeline/rte_swx_ctl.h | 2 -- lib/pipeline/rte_swx_pipeline.c | 1 - lib/pipelin

[PATCH v8 20/50] pdump: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pdump/rte_pdump.c | 1 - lib/pdump/rte_pdump.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index af450695ec..b3a62df591 100644 --- a

[PATCH v8 18/50] port: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/port/rte_port_fd.h | 1 - lib/port/rte_port_frag.c| 2 -- lib/port/rte_port_frag.h| 1 - lib/port/rte_port_kni.c | 1 - lib/port/rte_port_kni.h | 1

[PATCH v8 17/50] power: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Also added rte_string_fns.h to example app vm_power_manager for users without libbsd. Signed-off-by: Sean Morrissey Acked-by: David Hunt --- examples/vm_power_manager/guest_cli/main.c | 1 + lib/power/guest_channel.c

[PATCH v8 16/50] rawdev: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Hemant Agrawal --- lib/rawdev/rte_rawdev.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/lib/rawdev/rte_rawdev.c b/lib/rawdev/rte_rawdev.c index a6134e76ea..2f0a4f1

[PATCH v8 15/50] rcu: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rcu/rte_rcu_qsbr.c | 4 lib/rcu/rte_rcu_qsbr.h | 4 2 files changed, 8 deletions(-) diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c index 7510db2f81..17be93e830 100

[PATCH v8 14/50] regexdev: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Ori Kam --- lib/regexdev/rte_regexdev.c | 2 -- lib/regexdev/rte_regexdev.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/lib/regexdev/rte_regexdev.c b/lib/regexdev/rte_regexde

[PATCH v8 13/50] reorder: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/reorder/rte_reorder.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index bc0241bfb3..385ee479da 100644 --- a/lib/reorder/rte_reo

[PATCH v8 12/50] rib: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rib/rte_rib.c | 2 -- lib/rib/rte_rib.h | 1 - lib/rib/rte_rib6.c | 2 -- lib/rib/rte_rib6.h | 1 - 4 files changed, 6 deletions(-) diff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c in

[PATCH v8 11/50] sched: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/sched/rte_pie.c | 2 -- lib/sched/rte_red.h | 1 - lib/sched/rte_sched.c | 1 - lib/sched/rte_sched.h | 1 - 4 files changed, 5 deletions(-) diff --git a/lib/sched/rte_pie.c b/lib/sch

[PATCH v8 10/50] security: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/security/rte_security.c | 2 -- lib/security/rte_security.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c index 6e45a03fa

[PATCH v8 09/50] stack: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/stack/rte_stack.c | 2 -- lib/stack/rte_stack.h | 1 - 2 files changed, 3 deletions(-) diff --git a/lib/stack/rte_stack.c b/lib/stack/rte_stack.c index 56bf2c8d6d..1fabec2bfe 100644 --- a

[PATCH v8 08/50] table: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/table/rte_swx_table_em.c | 1 - lib/table/rte_swx_table_em.h | 1 - lib/table/rte_swx_table_learner.c | 1 - lib/table/rte_swx_table_learner.h | 1 - lib/table/rte_swx_table_

[PATCH v8 07/50] timer: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Erik Gabriel Carrillo --- lib/timer/rte_timer.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index 6d19ce469b..c51a393e5c 10064

[PATCH v8 06/50] vhost: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/vhost/fd_man.c | 6 -- lib/vhost/fd_man.h | 1 - lib/vhost/socket.c | 1 - lib/vhost/vdpa.c | 1 - lib/vhost/vhost.c | 4 lib/vhost/vhost.h | 2 -- lib

[PATCH v8 05/50] eal: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Reviewed-by: Harry van Haaren Reviewed-by: Mattias Rönnblom Reviewed-by: David Christensen --- lib/eal/common/eal_common_dev.c| 5 - lib/eal/common/eal_common_devargs.c| 1 -

[PATCH v8 04/50] kvargs: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kvargs/rte_kvargs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c index 11f624ef14..c77bb82feb 100644 --- a/lib/kvargs/rte_kvargs.c +

[PATCH v8 03/50] ring: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ring/rte_ring.c | 9 - 1 file changed, 9 deletions(-) diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c index 6a94a038c4..cddaf6b287 100644 --- a/lib/ring/rte_ring.c +++ b/li

[PATCH v8 02/50] telemetry: remove unneeded header includes

2022-02-14 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Ciara Power --- lib/telemetry/telemetry.c | 1 - lib/telemetry/telemetry_data.h | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telem

[PATCH v8 01/50] devtools: script to remove unused headers includes

2022-02-14 Thread Sean Morrissey
This script can be used for removing headers flagged for removal by the include-what-you-use (IWYU) tool. The script has the ability to remove headers from specified sub-directories or dpdk as a whole and tests the build after each removal by calling meson compile. example usages: Remove headers

[PATCH v8 00/50] introduce IWYU

2022-02-14 Thread Sean Morrissey
This patchset introduces the include-what-you-use script which removes unused header includes. IWYU GitHub: https://github.com/include-what-you-use/include-what-you-use Along with the script there are some patches which make a start on removing unneeded headers. V4: * Re-added removed headers th

Re: [PATCH v2 1/3] net/ark: add device capabilities record

2022-02-14 Thread Ferruh Yigit
On 2/11/2022 11:39 AM, John Miller wrote: Add a device capabilities record for supported features. Certain variants require that PCIe read-requests be correctly throttled. This is called "rqpacing" in Arkville, and has to do with credit and flow control on certain Arkville implementations. Signe

Re: [PATCH v2 3/3] net/ark: support chunk DMA transfers

2022-02-14 Thread Ferruh Yigit
On 2/11/2022 11:39 AM, John Miller wrote: Add support for chunk DMA transfers. Various performance optimizations and behavior fixes. Chunk mpu transfer use 64 objects (512 byte) to maintain memory read alignment. Align mpu memory allocation to be at 512 byte boundaries. Reduce force-close allocat

Re: [PATCH] build: fix build on FreeBSD with Meson 0.61.1

2022-02-14 Thread Bruce Richardson
On Mon, Feb 14, 2022 at 12:43:13PM +0100, Karl Bonde Torp wrote: > When building with Meson 0.61.1 on FreeBSD some archives become > corrupted. This can be avoided by using 'llvm-ar' instead of 'ar'. > > Signed-off-by: Karl Bonde Torp > --- Hi, thanks for the patch. Can you perhaps provide some

Minutes of Technical Board Meeting, 2022-02-09

2022-02-14 Thread Ferruh Yigit
Tech Board Attendees: Aaron, Bruce, Ferruh (Chair), Hemant, Honnappa, Jerin, Kevin, Konstantin, Maxime, Olivier, Stephen, Thomas Agenda Items -- * Userspace event  * Venue and date discussion is going on with e-mail, will be decided there. * Traffic generator * Approved to

RE: [PATCH v5] eal: fix unaligned loads/stores in rte_memcpy_generic

2022-02-14 Thread Ananyev, Konstantin
Hi Luc, > > Indeed it looks like a problem. > > Thanks for pointing it out. > > Was able to reproduce it with gcc 11 (clang 13 seems fine). > > Actually, adding ' __attribute__ ((__may_alias__))' for both dst and src > > didn't quire the problem. > > __may_alias__ works if it's applied to a typ

Re: [PATCH 6/6] drivers/nfb: add support for more MAC addresses

2022-02-14 Thread Ferruh Yigit
On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: From: Martin Spinler Extend the eth_dev_ops by add/remove MAC address functions. Signed-off-by: Martin Spinler --- drivers/net/nfb/nfb_ethdev.c | 69 ++-- 1 file changed, 58 insertions(+), 11 deletions(-) diff

Re: [PATCH 1/6] net/nfb: add missing libfdt dependency for build

2022-02-14 Thread Ferruh Yigit
On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: From: Martin Spinler The driver uses some FDT manipulation functions from libfdt. Let the build system check for libfdt package. I don't see 'libfdt.h' included by the driver, where/how libfdt is used? Also what do you think to document this e

Re: [PATCH 5/6] drivers/nfb: fix multicast/promiscuous mode switching

2022-02-14 Thread Ferruh Yigit
On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: From: Martin Spinler In the firmware, the promisc mode overrides the multicast mode. So when the promisc mode is turned off, driver must check if the multicast mode was active before and conditionally reactivate it. Can you please add fixes & s

Re: [PATCH 3/6] drivers/nfb: do not report zero-sized TX burst

2022-02-14 Thread Ferruh Yigit
On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: From: Martin Spinler Zero-sized TX burst floods the log no more. If you want this patch to be backported, you can update commit log as fix and add fixes & stable tags. Signed-off-by: Martin Spinler --- drivers/net/nfb/nfb_tx.h | 5 -

Re: [PATCH 2/6] drivers/nfb: fix array indexes in deinit functions

2022-02-14 Thread Ferruh Yigit
On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: From: Martin Spinler The indexes in the for cycle were wrongly used and the code accessed outside of the rxmac/txmac array. can you please add fixes tag, to help backport. Also please add stable tag to request backport. Signed-off-by: Martin

  1   2   3   >