[PATCH v2 2/2] eal: common rte_dump_stack for both Linux and FreeBSD

2022-02-12 Thread Stephen Hemminger
The core functions used by rte_dump_stack() are backtrace_symbols and dladdr. Both of those functions are the same in Linux and FreeBSD so the code for decoding stack should be common. Also, the filenames unix/meson.build are now resorted. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/ea

[PATCH v2 1/2] eal_debug: do not use malloc in rte_dump_stack

2022-02-12 Thread Stephen Hemminger
The glibc backtrace_symbols() calls malloc which makes it dangerous to use rte_dump_stack() in a signal handler that is handling errors that maybe due to memory corruption. Instead, use dladdr() to lookup up symbols incrementally. The format of the messages is based on what X org server has been

[PATCH v2 0/2] rte_dump_stack: improvements

2022-02-12 Thread Stephen Hemminger
This is update to earlier RFC. Add some more comments and changes to have common code for Linux and FreeBSD Stephen Hemminger (2): eal_debug: do not use malloc in rte_dump_stack eal: common rte_dump_stack for both Linux and FreeBSD lib/eal/freebsd/eal_debug.c | 43 l

Re: [PATCH] config/cn10k: align mempool elements to 128 bytes

2022-02-12 Thread Thomas Monjalon
21/01/2022 10:37, Jerin Jacob: > On Thu, Jan 20, 2022 at 3:21 PM Jerin Jacob wrote: > > > > On Tue, Dec 14, 2021 at 2:53 PM Ruifeng Wang wrote: > > > > > > > -Original Message- > > > > From: pbhagavat...@marvell.com > > > > Sent: Monday, December 13, 2021 7:06 PM > > > > To: jer...@marve

Re: [PATCH v6 00/26] Net/SPNIC: support SPNIC into DPDK 22.03

2022-02-12 Thread Yanling Song
On Fri, 21 Jan 2022 10:22:10 + Ferruh Yigit wrote: > On 1/21/2022 9:27 AM, Yanling Song wrote: > > On Wed, 19 Jan 2022 16:56:52 + > > Ferruh Yigit wrote: > > > >> On 12/30/2021 6:08 AM, Yanling Song wrote: > >>> The patchsets introduce SPNIC driver for Ramaxel's SPNxx serial > >>> N

Re: [PATCH v5] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if.

2022-02-12 Thread Thomas Monjalon
31/01/2022 01:05, Michael Barker: > When compiling with clang using -Wpedantic (or -Wgcc-compat) the use of > diagnose_if kicks up a warning: > > .../include/rte_interrupts.h:623:1: error: 'diagnose_if' is a clang > extension [-Werror,-Wgcc-compat] > __rte_internal > ^ > .../include/rte_compat.h:3

Re: [PATCH v5 0/2] Verify C++ compatibility of public headers

2022-02-12 Thread Thomas Monjalon
11/02/2022 12:36, Bruce Richardson: > NOTE: despite significant differences in patchset, submitting this as v5 > to keep history and threading rather than as new v1 > > This patchset expands upon the exiting chkincs infrastructure to build a > C++ test application as well as the existing C test ap

[PATCH] net/cnxk: fix uninitialized local variable

2022-02-12 Thread Gowrishankar Muthukrishnan
Fix uninitialized local variable as reported by coverity scan. Fixes: 6af19a9d89b ("net/cnxk: support meter action to flow destroy") Coverity issue: 373630 Signed-off-by: Gowrishankar Muthukrishnan --- drivers/net/cnxk/cnxk_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH 3/3] event/cnxk: fix uninitialized local variable

2022-02-12 Thread Gowrishankar Muthukrishnan
Fix uninitialized local variable as reported in coverity scan. Fixes: 300b796262a ("event/cnxk: add timer arm routine") Fixes: 300b796262a ("event/cnxk: add timer arm routine" Coverity issue: 370578, 370579, 370587 Signed-off-by: Gowrishankar Muthukrishnan --- drivers/event/cnxk/cnxk_tim_worker

[PATCH 2/3] event/cnxk: fix memory leak

2022-02-12 Thread Gowrishankar Muthukrishnan
Fix memory leaks reported in coverity scan. Fixes: 8a3d58c189f ("event/cnxk: add option to control timer adapters") Coverity issue: 374990 374991 Signed-off-by: Gowrishankar Muthukrishnan --- drivers/event/cnxk/cnxk_tim_evdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff -

[PATCH 1/3] event/cnxk: fix incompatible casting of variables

2022-02-12 Thread Gowrishankar Muthukrishnan
Fix incompatible casting on variables reported by coverity scan. Fixes: 6223ede2036 ("event/cnxk: add event port link and unlink") Coverity issue: 370582 370584 Signed-off-by: Gowrishankar Muthukrishnan --- drivers/event/cnxk/cn10k_eventdev.c | 4 ++-- drivers/event/cnxk/cn9k_eventdev.c | 11

[PATCH 3/3] common/cnxk: fix uninitialized pointer read

2022-02-12 Thread Gowrishankar Muthukrishnan
Fix uninitialized pointer read reported in coverity scan. Fixes: c34ea71b878 ("common/cnxk: add NPC parsing API") Coverity issue: 370214, 370217, 370219, 370220, 370221, 370223, 370224, 370225, 372065 Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/roc_npc_pars

[PATCH 2/3] common/cnx: fix unintended sign extension

2022-02-12 Thread Gowrishankar Muthukrishnan
This patch fixes unintended sign extensions reported in coverity scan. Fixes: 8ca851cdc59 ("common/cnxk: support dual VLAN insert and strip actions") Coverity issue: 373258 Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/roc_npc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 d

[PATCH 1/3] common/cnxk: check return value for error

2022-02-12 Thread Gowrishankar Muthukrishnan
This patch fixes coverity issue by adding checks on return values. Coverity issue: 373628, 374858, 370213, 370215 Fixes: af75aac78978 ("common/cnxk: support telemetry for NIX") Fixes: d61138d4f0e ("drivers: remove direct access to interrupt handle") Fixes: fcdef46b669 ("common/cnxk: support NIX TM

[PATCH] ethdev: remove dead code in telemetry handler

2022-02-12 Thread Gowrishankar Muthukrishnan
In telemetry handler for port info, there is no need to check if eth_dev object of a port id is not null, as it had already been evaluated once in rte_eth_dev_is_valid_port function. Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Coverity issue: 373635 Signed-off-by: Gowri

RE: [EXT] [PATCH] crypto: fix misspelled key in qt format

2022-02-12 Thread Akhil Goyal
> This patch fixes misspelled RTE_RSA_KEY_TYPE_QT, > this will prevent checkpach from complaining wherever > change to RSA is being made. > > Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions") > > Signed-off-by: Arek Kusztal > --- Fix ABI warning. Add libabigail.abiignore

RE: [dpdk-dev v7 00/10] drivers/qat: QAT symmetric crypto datapatch rework

2022-02-12 Thread Akhil Goyal
> > -Original Message- > > From: Kai Ji > > Sent: Tuesday, February 8, 2022 6:15 PM > > To: dev@dpdk.org > > Cc: gak...@marvell.com; Ji, Kai > > Subject: [dpdk-dev v7 00/10] drivers/qat: QAT symmetric crypto datapatch > > rework > > > > This patch reworks QAT symmetric crypto datapatch im

RE: [EXT] [PATCH v4 0/7] NXP crypto drivers changes

2022-02-12 Thread Akhil Goyal
> v4-change-log > * fix i386 compilation > > v3-change-log > * fix checkpatch issues > * use devargs for strict ordering > * fix AES_CMAC capabilities > * remove GMAC patch from this series. I will send > it as separate patch. > > v2-change-log > * using dev args for both DPAA1 and DPAA2 drivers

Re: [PATCH v3 00/36] remove unnecessary null checks

2022-02-12 Thread Thomas Monjalon
09/02/2022 20:17, Stephen Hemminger: > While working on a new driver, noticed that some drivers always call > free routines (correct) and others conditionally call free routines > if not null (redundant check). The extra if(e != NULL) type check > is unneeded and adds extra code. Better to have a

RE: [EXT] [PATCH v3 0/4] Clarify asymmetric random, add 'k' and crypto uint

2022-02-12 Thread Akhil Goyal
> This patchset introduces following changes: > > 1) DSA 'k' was added that devices without random support can work. > 2) Clarified usage of random numbers in asym, as per discussion from December. > 3) Added typedef for crypto_uint to remove some repeating comments making > code more readable. Ad

Re: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-12 Thread Thomas Monjalon
12/02/2022 03:19, Alexander Kozyrev: > On Fri, Feb 11, 2022 7:42 Andrew Rybchenko : > > On 2/11/22 05:26, Alexander Kozyrev wrote: > > > +__rte_experimental > > > +struct rte_flow * > > > +rte_flow_q_flow_create(uint16_t port_id, > > > > flow_q_flow does not sound like a good nameing, consider: >