[PATCH v6 06/10] app/testpmd: add flow table management

2022-02-11 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_table API. Provide the command line interface for the flow table creation/destruction. Usage example: testpmd> flow template_table 0 create table_id 6 group 9 priority 4 ingress mode 1 rules_number 64 pattern_template 2 actions_template 4 testpmd> fl

[PATCH v6 10/10] app/testpmd: add async indirect actions creation/destruction

2022-02-11 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_action_handle API. Provide the command line interface for operations dequeue. Usage example: flow queue 0 indirect_action 0 create action_id 9 ingress postpone yes action rss / end flow queue 0 indirect_action 0 update action_id 9 action queue inde

[PATCH v6 07/10] app/testpmd: add async flow create/destroy operations

2022-02-11 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_create/rte_flow_q_destroy API. Provide the command line interface for enqueueing flow creation/destruction operations. Usage example: testpmd> flow queue 0 create 0 postpone no template_table 6 pattern_template 0 actions_template 0 patt

[PATCH v6 09/10] app/testpmd: add flow queue pull operation

2022-02-11 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_pull API. Provide the command line interface for pulling operations results. Usage example: flow pull 0 queue 0 Signed-off-by: Alexander Kozyrev Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 56 +++- app/test-pmd/config.c

[PATCH v6 08/10] app/testpmd: add flow queue push operation

2022-02-11 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_push API. Provide the command line interface for pushing operations. Usage example: flow queue 0 push 0 Signed-off-by: Alexander Kozyrev Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 56 - app/test-pmd/config.c

[PATCH v6 05/10] app/testpmd: add flow template management

2022-02-11 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_pattern_template and rte_flow_actions_template APIs. Provide the command line interface for the template creation/destruction. Usage example: testpmd> flow pattern_template 0 create pattern_template_id 2 template eth dst is 00:16:3e:31:15:c3 / end

[PATCH v6 04/10] app/testpmd: add flow engine configuration

2022-02-11 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_configure API. Provide the command line interface for the Flow management. Usage example: flow configure 0 queues_number 8 queues_size 256 Implement rte_flow_info_get API to get available resources: Usage example: flow info 0 Signed-off-by: Alexander Kozyrev

[PATCH v6 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-11 Thread Alexander Kozyrev
A new, faster, queue-based flow rules management mechanism is needed for applications offloading rules inside the datapath. This asynchronous and lockless mechanism frees the CPU for further packet processing and reduces the performance impact of the flow rules creation/destruction on the datapath.

[PATCH v6 02/10] ethdev: add flow item/action templates

2022-02-11 Thread Alexander Kozyrev
Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in an application, many flow rules share a common structure (the same item mask and/or action list) so they can be grouped and classified together. This knowl

[PATCH v6 01/10] ethdev: introduce flow pre-configuration hints

2022-02-11 Thread Alexander Kozyrev
The flow rules creation/destruction at a large scale incurs a performance penalty and may negatively impact the packet processing when used as part of the datapath logic. This is mainly because software/hardware resources are allocated and prepared during the flow rule creation. In order to optimi

[PATCH v6 00/10] ethdev: datapath-focused flow rules management

2022-02-11 Thread Alexander Kozyrev
Three major changes to a generic RTE Flow API were implemented in order to speed up flow rule insertion/destruction and adapt the API to the needs of a datapath-focused flow rules management applications: 1. Pre-configuration hints. Application may give us some hints on what type of resources are

RE: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-11 Thread Alexander Kozyrev
On Fri, Feb 11, 2022 7:42 Andrew Rybchenko : > On 2/11/22 05:26, Alexander Kozyrev wrote: > > A new, faster, queue-based flow rules management mechanism is needed > for > > applications offloading rules inside the datapath. This asynchronous > > and lockless mechanism frees the CPU for further pack

RE: [PATCH v5 02/10] ethdev: add flow item/action templates

2022-02-11 Thread Alexander Kozyrev
On Fri, Feb 11, 2022 6:27 Andrew Rybchenko wrote: > On 2/11/22 05:26, Alexander Kozyrev wrote: > > Treating every single flow rule as a completely independent and separate > > entity negatively impacts the flow rules insertion rate. Oftentimes in an > > application, many flow rules share a common

Re: [PATCH v5 1/2] ethdev: introduce generic dummy packet burst function

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 7:11 PM, Ferruh Yigit wrote: Multiple PMDs have dummy/noop Rx/Tx packet burst functions. These dummy functions are very simple, introduce a common function in the ethdev and update drivers to use it instead of each driver having its own functions. Signed-off-by: Ferruh Yigit Acked-

Re: [PATCH v6 0/5] cleanup more resources on eal_cleanup

2022-02-11 Thread Thomas Monjalon
13/11/2021 18:22, Stephen Hemminger: > Stephen Hemminger (5): > eal: close log in eal_cleanup > eal: mp: end the multiprocess thread during cleanup > eal: vfio: cleanup the mp sync handle > eal: hotplug: cleanup multiprocess resources > eal: malloc: cleanup mp resources Applied, thanks.

Re: [PATCH v2 7/8] net/ring: add promisc and all-MC stubs

2022-02-11 Thread Ferruh Yigit
On 2/4/2022 2:49 PM, Bruce Richardson wrote: On Fri, Feb 04, 2022 at 02:36:47PM +, Ferruh Yigit wrote: On 12/21/2021 7:57 PM, Robert Sanford wrote: Add promiscuous_enable, promiscuous_disable, allmulticast_enable, and allmulticast_disable API stubs. This helps clean up errors in dpdk-test l

[PATCH v5 2/2] ethdev: move driver interface functions to its own file

2022-02-11 Thread Ferruh Yigit
ethdev has two interfaces, one interface between applications and library, these APIs are declared in the rte_ethdev.h public header. Other interface is between drivers and library, these functions are declared in ethdev_driver.h and marked as internal. But all functions are defined in rte_ethdev.

[PATCH v5 1/2] ethdev: introduce generic dummy packet burst function

2022-02-11 Thread Ferruh Yigit
Multiple PMDs have dummy/noop Rx/Tx packet burst functions. These dummy functions are very simple, introduce a common function in the ethdev and update drivers to use it instead of each driver having its own functions. Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Acked-by: Viacheslav Ovs

Re: [PATCH v4 2/2] ethdev: move driver interface functions to its own file

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 6:55 PM, Thomas Monjalon wrote: 11/02/2022 19:38, Ferruh Yigit: ethdev has two interfaces, one interface between applications and library, these APIs are declared in the ethdev.h public header. will update file name as 'rte_ethdev.h' Other interface is between drivers and librar

Re: [PATCH v4 2/2] ethdev: move driver interface functions to its own file

2022-02-11 Thread Thomas Monjalon
11/02/2022 19:38, Ferruh Yigit: > ethdev has two interfaces, one interface between applications and > library, these APIs are declared in the ethdev.h public header. > Other interface is between drivers and library, these functions are > declared in ethdev_driver.h and marked as internal. > > But

RE: [PATCH v5 01/10] ethdev: introduce flow pre-configuration hints

2022-02-11 Thread Alexander Kozyrev
On Friday, February 11, 2022 5:17 Andrew Rybchenko wrote: > Sent: Friday, February 11, 2022 5:17 > To: Alexander Kozyrev ; dev@dpdk.org > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; ivan.ma...@oktetlabs.ru; ferruh.yi...@intel.com; > mohammad.abdul.a...@intel.com; qi.z.zh...@intel.com

Re: [PATCH v3 2/2] ethdev: move driver interface functions to its own file

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 6:09 PM, Thomas Monjalon wrote: 11/02/2022 18:14, Ferruh Yigit: Relevant functions moved to ethdev_driver.c. No functional change. Signed-off-by: Ferruh Yigit --- lib/ethdev/ethdev_driver.c | 758 ++ lib/ethdev/ethdev_private.c | 131 ++ lib/et

[PATCH v4 2/2] ethdev: move driver interface functions to its own file

2022-02-11 Thread Ferruh Yigit
ethdev has two interfaces, one interface between applications and library, these APIs are declared in the ethdev.h public header. Other interface is between drivers and library, these functions are declared in ethdev_driver.h and marked as internal. But all functions are defined in rte_ethdev.c fi

[PATCH v4 1/2] ethdev: introduce generic dummy packet burst function

2022-02-11 Thread Ferruh Yigit
Multiple PMDs have dummy/noop Rx/Tx packet burst functions. These dummy functions are very simple, introduce a common function in the ethdev and update drivers to use it instead of each driver having its own functions. Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Acked-by: Viacheslav Ovs

Re: [PATCH v3 2/2] ethdev: move driver interface functions to its own file

2022-02-11 Thread Thomas Monjalon
11/02/2022 18:14, Ferruh Yigit: > Relevant functions moved to ethdev_driver.c. > No functional change. > > Signed-off-by: Ferruh Yigit > --- > lib/ethdev/ethdev_driver.c | 758 ++ > lib/ethdev/ethdev_private.c | 131 ++ > lib/ethdev/ethdev_private.h | 36 ++ > l

Re: [PATCH 0/9] dump device info

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 4:49 AM, Min Hu (Connor) wrote: This patch set contains introduce dump API and a set of patches for hns3 dump implementation. Min Hu (Connor) (9): ethdev: introduce dump API net/hns3: dump device basic info net/hns3: dump device feature capability net/hns3: dump device M

Re: [PATCH v3 1/2] ethdev: introduce generic dummy packet burst function

2022-02-11 Thread Thomas Monjalon
11/02/2022 18:14, Ferruh Yigit: > Multiple PMDs have dummy/noop Rx/Tx packet burst functions. > > These dummy functions are very simple, introduce a common function in > the ethdev and update drivers to use it instead of each driver having > its own functions. > > Signed-off-by: Ferruh Yigit > A

Re: [PATCH] net/af_xdp: update docs with libxdp requirements and info

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 3:03 PM, Ciara Loftus wrote: When libxdp is used, the LIBXDP_OBJECT_PATH environment variable must be set to the location of where libxdp placed its bpf object files. This is usually in /usr/local/lib/bpf or /usr/local/lib64/bpf. Failure to do so will result in the PMD not initialisi

Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace

2022-02-11 Thread Thomas Monjalon
11/02/2022 09:07, Singh, Aman Deep: > On 2/10/2022 9:00 PM, Thomas Monjalon wrote: > > 10/02/2022 14:26, Singh, Aman Deep: > >> On 2/4/2022 1:17 PM, Thomas Monjalon wrote: > >>> 04/02/2022 07:13, Singh, Aman Deep: > Hi Thomas > > On 2/3/2022 2:31 AM, Thomas Monjalon wrote: > > 23

RE: [**EXTERNAL**] Re: e1000 forced 1G support?

2022-02-11 Thread Bly, Mike
Morten, Thank you for the reminder. Need to dust off my IEEE stds once in a while I guess. Stephen, cabling is good. We are able to run 1G with aneg enabled. Thanks to both for the speedy response. -Mike -Original Message- From: Stephen Hemminger Sent: Friday, February 11, 2022 6:45

Re: [PATCH v4 7/7] buildtools/chkincs: test headers for C++ compatibility

2022-02-11 Thread Thomas Monjalon
11/02/2022 11:57, Bruce Richardson: > On Fri, Feb 11, 2022 at 10:31:38AM +, Bruce Richardson wrote: > > On Thu, Feb 10, 2022 at 10:58:37PM +0100, Thomas Monjalon wrote: > > > 10/02/2022 16:42, Bruce Richardson: > > > > +executable('chkincs-cpp', cpp_sources, +cpp_args: ['-include', > >

[PATCH v3 1/2] ethdev: introduce generic dummy packet burst function

2022-02-11 Thread Ferruh Yigit
Multiple PMDs have dummy/noop Rx/Tx packet burst functions. These dummy functions are very simple, introduce a common function in the ethdev and update drivers to use it instead of each driver having its own functions. Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Acked-by: Viacheslav Ovs

[PATCH v3 2/2] ethdev: move driver interface functions to its own file

2022-02-11 Thread Ferruh Yigit
Relevant functions moved to ethdev_driver.c. No functional change. Signed-off-by: Ferruh Yigit --- lib/ethdev/ethdev_driver.c | 758 ++ lib/ethdev/ethdev_private.c | 131 ++ lib/ethdev/ethdev_private.h | 36 ++ lib/ethdev/rte_ethdev.c | 901 -

[PATCH v3 4/4] crypto: reorganize endianness comments, add crypto uint

2022-02-11 Thread Arek Kusztal
This patch adds crypto uint typedef so adding comment about byte-order becomes unnecessary. It makes API comments more tidy, and more consistent with other asymmetric crypto APIs. Additionally it reorganizes code that enums, externs and forward declarations are moved to the top of the header file

[PATCH v3 3/4] crypto: use rte macro instead of direct attribute

2022-02-11 Thread Arek Kusztal
This commit replaces __extension__ attribute with RTE_STD_C11 in anonymous unions. It makes API consistent in terms of usage of C11 feature macro. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/crypto

[PATCH v3 2/4] crypto: clarify usage of random numbers in asym

2022-02-11 Thread Arek Kusztal
This commit clarifies usage of random numbers in asymmetric crypto API. The user is now allowed to provide information to the PMD if random number should be generated or should be read from user input. If PMD does not support random number generation user should always provide it, if PMD does not

[PATCH v3 1/4] crypto: add dsa random number k

2022-02-11 Thread Arek Kusztal
This commit adds random number 'k' to dsa op param struct. This parameter is crucial in stiuations where: - PMD cannot generate random number - User would like to provide random source Additionally, it makes DSA consistent with ECDSA in terms of 'k' which includes this parameter. Signed-off-by:

[PATCH v3 0/4] Clarify asymmetric random, add 'k' and crypto uint

2022-02-11 Thread Arek Kusztal
This patchset introduces following changes: 1) DSA 'k' was added that devices without random support can work. 2) Clarified usage of random numbers in asym, as per discussion from December. 3) Added typedef for crypto_uint to remove some repeating comments making code more readable. Additionally,

RE: [PATCH v2] eventdev/eth_tx: fix queue add logic

2022-02-11 Thread Jayatheerthan, Jay
Looks good. Thanks. Acked-by: Jay Jayatheerthan -Jay > -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, February 9, 2022 11:02 AM > To: Jayatheerthan, Jay ; jer...@marvell.com > Cc: dev@dpdk.org > Subject: [PATCH v2] eventdev/eth_tx: fix queue add logic > > The inter

Re: [v2 0/4] Add support for GRE optional fields matching

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 1:45 AM, Sean Zhang wrote: This patch set adds support for matching optional fields of GRE header. The optional fields are checksum, key and sequence number. Currently, key field is supported with pattern gre_key item '.. / gre / gre_key value is xx / ..' with field gre_key in misc,

RE: [PATCH v5] eal: fix unaligned loads/stores in rte_memcpy_generic

2022-02-11 Thread Ananyev, Konstantin
> > Not sure I understand the problem you are referring to. > > Are you saying that original rte_memcpy() code breaks strict aliasing? > > If so, could you point where exactly? > > As far as I understand, yes, it does break strict aliasing. For > example, in the following line: > > *(uint64_t *)d

RE: [PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-11 Thread Loftus, Ciara
> > On 2/11/2022 1:01 PM, Loftus, Ciara wrote: > >> > >> On 2/11/2022 9:26 AM, Loftus, Ciara wrote: > > > > On 2/10/2022 5:47 PM, Loftus, Ciara wrote: > >>> Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process > support > >>> > >>> On 2/10/2022 3:40 PM, Loftus,

[PATCH V3] pipeline: support checksum for variable size headers

2022-02-11 Thread Cristian Dumitrescu
Added checksum support for variable size headers such as IPv4 headers with options. Signed-off-by: Cristian Dumitrescu Signed-off-by: Yogesh Jangra Signed-off-by: Harshad Suresh Narayane --- Change log: V2: Fix the checksum accumulation over initial destination value. V3: Fix strange git am iss

[PATCH] net/af_xdp: update docs with libxdp requirements and info

2022-02-11 Thread Ciara Loftus
When libxdp is used, the LIBXDP_OBJECT_PATH environment variable must be set to the location of where libxdp placed its bpf object files. This is usually in /usr/local/lib/bpf or /usr/local/lib64/bpf. Failure to do so will result in the PMD not initialising correctly as the bpf program is not found

Re: e1000 forced 1G support?

2022-02-11 Thread Stephen Hemminger
On Fri, 11 Feb 2022 09:57:31 +0100 Morten Brørup wrote: > > From: Bly, Mike [mailto:m...@ciena.com] > > Sent: Friday, 11 February 2022 02.30 > > > > Hello, > > > > This is in regards to the DPDK E1000 driver used for the i350 [8086:1521] > > NIC. > > > > I am looking to see if we can get force

RE: [EXT] [PATCH v7 0/5] crypto: improve asym session usage

2022-02-11 Thread Akhil Goyal
> This patchset includes improvements for the asymmetric session. > The main change is to the session structure, which is now a single > mempool object, rather than having pointers to private data elsewhere. > This session structure is now hidden in an internal header, > so the app will never use i

Re: [PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-11 Thread Ferruh Yigit
On 2/9/2022 3:29 PM, Stephen Hemminger wrote: On Wed, 9 Feb 2022 09:48:08 + Ciara Loftus wrote: Secondary process support had been disabled for the AF_XDP PMD because there was no logic in place to share the AF_XDP socket file descriptors between the processes. This commit introduces this

Re: [PATCH v2 00/12] Wangxun fixes and supports

2022-02-11 Thread Ferruh Yigit
On 2/9/2022 10:42 AM, Jiawen Wu wrote: Fixed some bugs for txgbe and ngbe, and support more custom functions. v2: - Add more detail describe in commit logs and release notes. - Fix build error. - Fix debug logs. Jiawen Wu (12): net/ngbe: fix failed to receive packets net/ngbe: fix link in

Re: [PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 1:01 PM, Loftus, Ciara wrote: On 2/11/2022 9:26 AM, Loftus, Ciara wrote: On 2/10/2022 5:47 PM, Loftus, Ciara wrote: Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support On 2/10/2022 3:40 PM, Loftus, Ciara wrote: Subject: Re: [PATCH v4] net/af_xdp: re-enable

RE: [PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-11 Thread Loftus, Ciara
> > On 2/11/2022 9:26 AM, Loftus, Ciara wrote: > >>> > >>> On 2/10/2022 5:47 PM, Loftus, Ciara wrote: > > Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process > >> support > > > > On 2/10/2022 3:40 PM, Loftus, Ciara wrote: > >>> Subject: Re: [PATCH v4] net/af_xdp: re-ena

Re: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-11 Thread Andrew Rybchenko
On 2/11/22 05:26, Alexander Kozyrev wrote: A new, faster, queue-based flow rules management mechanism is needed for applications offloading rules inside the datapath. This asynchronous and lockless mechanism frees the CPU for further packet processing and reduces the performance impact of the flo

Re: [PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 9:26 AM, Loftus, Ciara wrote: On 2/10/2022 5:47 PM, Loftus, Ciara wrote: Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support On 2/10/2022 3:40 PM, Loftus, Ciara wrote: Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support On 2/9/2022 9:4

[PATCH v2 3/3] net/ark: support chunk DMA transfers

2022-02-11 Thread John Miller
Add support for chunk DMA transfers. Various performance optimizations and behavior fixes. Chunk mpu transfer use 64 objects (512 byte) to maintain memory read alignment. Align mpu memory allocation to be at 512 byte boundaries. Reduce force-close allocation from 1 objects to 64 objects. Add me

[PATCH v2 2/3] net/ark: support arbitrary mbuf size

2022-02-11 Thread John Miller
Added arbitrary mbuf size per queue capability. Updated ARK_UDM_CONST3 value to reflect the version number read from the HW that is required to support this change. Signed-off-by: John Miller --- v2: - Added more details to the git log. --- drivers/net/ark/ark_ethdev.c| 8 drivers

[PATCH v2 1/3] net/ark: add device capabilities record

2022-02-11 Thread John Miller
Add a device capabilities record for supported features. Certain variants require that PCIe read-requests be correctly throttled. This is called "rqpacing" in Arkville, and has to do with credit and flow control on certain Arkville implementations. Signed-off-by: John Miller --- v2: - Improved c

[PATCH v5 2/2] buildtools/chkincs: test headers for C++ compatibility

2022-02-11 Thread Bruce Richardson
Add support for checking each of our headers for issues when included in a C++ file. Signed-off-by: Bruce Richardson --- .ci/linux-build.sh | 1 + .github/workflows/build.yml| 2 +- buildtools/chkincs/main.cpp| 4 buildtools/chkincs/meson.build | 18 ++

[PATCH v5 1/2] buildtools/chkincs: remove unnecesary linkage

2022-02-11 Thread Bruce Richardson
The chkincs binary does not actually call any functions in either libs or drivers, so we can simplify the linkage of it to just using shared linkage of the libraries (via meson dependencies). This means a slightly faster link time as well as making the chkincs binary much, much smaller. Signed-off

[PATCH v5 0/2] Verify C++ compatibility of public headers

2022-02-11 Thread Bruce Richardson
NOTE: despite significant differences in patchset, submitting this as v5 to keep history and threading rather than as new v1 This patchset expands upon the exiting chkincs infrastructure to build a C++ test application as well as the existing C test app, which helps catch any build errors when the

Re: [PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 7:28 AM, Loftus, Ciara wrote: On 2/10/2022 5:47 PM, Loftus, Ciara wrote: Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support On 2/10/2022 3:40 PM, Loftus, Ciara wrote: Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support On 2/9/2022 9:48

Re: [PATCH v5 02/10] ethdev: add flow item/action templates

2022-02-11 Thread Andrew Rybchenko
On 2/11/22 05:26, Alexander Kozyrev wrote: Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in an application, many flow rules share a common structure (the same item mask and/or action list) so they can b

RE: [PATCH 2/3] app/test_bpf: don't print eBPF program if NULL

2022-02-11 Thread Ananyev, Konstantin
> If conversion of cBPF to eBPF fails (in rte_bpf_convert) > then the test should not try and print the result. > > Coverity issue: 373661 > Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF") > Signed-off-by: Stephen Hemminger > --- > app/test/test_bpf.c | 6 -- >

Re: [PATCH v4 7/7] buildtools/chkincs: test headers for C++ compatibility

2022-02-11 Thread Bruce Richardson
On Fri, Feb 11, 2022 at 10:31:38AM +, Bruce Richardson wrote: > On Thu, Feb 10, 2022 at 10:58:37PM +0100, Thomas Monjalon wrote: > > 10/02/2022 16:42, Bruce Richardson: > > > +executable('chkincs-cpp', cpp_sources, +cpp_args: ['-include', > > > 'rte_config.h', cflags], +link_arg

Re: [PATCH v2 1/4] crypto: add dsa random number k

2022-02-11 Thread Ray Kinsella
Arek Kusztal writes: > This commit adds random number 'k' to dsa > op param struct. > > This parameter is crucial in stituation where: situation > - PMD cannot generate random number > - user would like to provide random source > > Addtionally it makes DSA consistent with ECDSA additionally

Re: [EXT] [PATCH v2 4/4] crypto: reorganize endianness comments, add crypto uint

2022-02-11 Thread Ray Kinsella
Hi Akhil, Akhil Goyal writes: > Hi Fan, >> Hi Akhil, >> >> I assume everything in asym crypto is under experimental tag at the moment >> right? >> The goal is to have them updated and fixed before DPDK 22.11 so the >> experimental tag can be removed. >> > Asymmetric crypto APIs are marked as

Re: [PATCH v4 00/10] ethdev: datapath-focused flow rules management

2022-02-11 Thread Jerin Jacob
On Thu, Feb 10, 2022 at 9:30 PM Ferruh Yigit wrote: > > On 2/9/2022 9:37 PM, Alexander Kozyrev wrote: > > Three major changes to a generic RTE Flow API were implemented in order > > to speed up flow rule insertion/destruction and adapt the API to the > > needs of a datapath-focused flow rules mana

RE: [PATCH] app/testpmd: skip stopped queues when forwarding

2022-02-11 Thread Dmitry Kozlyuk
- jing.d.c...@intel.com (invalid address?), +ethdev maintainers > From: Li, Xiaoyun > [...] > Sorry to be direct, but I don't think this patch makes sense. > I need the code to clarify the problems so I'll use this thread not > the one you're answering. Thank you for explaining the issues in gr

Re: [PATCH v4 1/9] ethdev: introduce dump API

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 4:49 AM, Min Hu (Connor) wrote: Added the ethdev dump API which provides querying private info from device. There exists many private properties in different PMD drivers, such as adapter state, Rx/Tx func algorithm in hns3 PMD. The information of these properties is important for deb

Re: [v2 0/4] Add support for GRE optional fields matching

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 10:33 AM, Sean Zhang (Networking SW) wrote: -Original Message- From: Ferruh Yigit Sent: Friday, February 11, 2022 5:37 PM To: Sean Zhang (Networking SW) ; NBU-Contact- Thomas Monjalon (EXTERNAL) Cc: dev@dpdk.org; Andrew Rybchenko ; Ori Kam ; Qi Zhang Subject: Re: [v2 0/

Re: [v2 1/4] lib: add optional fields in GRE header

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 10:23 AM, Sean Zhang (Networking SW) wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Sent: Friday, February 11, 2022 5:38 PM To: Sean Zhang (Networking SW) ; NBU-Contact- Thomas Monjalon (EXTERNAL) ; Olivier Matz Cc: dev@dpdk.org; Andrew Rybchenko ; Ori Kam Subje

RE: [v2 0/4] Add support for GRE optional fields matching

2022-02-11 Thread Sean Zhang (Networking SW)
> -Original Message- > From: Ferruh Yigit > Sent: Friday, February 11, 2022 5:37 PM > To: Sean Zhang (Networking SW) ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Cc: dev@dpdk.org; Andrew Rybchenko ; > Ori Kam ; Qi Zhang > Subject: Re: [v2 0/4] Add support for GRE optional fields match

Re: [PATCH v4 7/7] buildtools/chkincs: test headers for C++ compatibility

2022-02-11 Thread Bruce Richardson
On Thu, Feb 10, 2022 at 10:58:37PM +0100, Thomas Monjalon wrote: > 10/02/2022 16:42, Bruce Richardson: > > +executable('chkincs-cpp', cpp_sources, +cpp_args: ['-include', > > 'rte_config.h', cflags], +link_args: dpdk_extra_ldflags, + > > include_directories: includes, +depen

Re: [PATCH v4] net/cnxk: avoid command copy from Tx queue

2022-02-11 Thread Jerin Jacob
On Thu, Feb 10, 2022 at 6:46 PM wrote: > > From: Pavan Nikhilesh > > Tx command is prepared based on offloads enabled and stored in > Tx queue structure at tx_queue_setup phase. > In fastpath the command is copied from Tx queue to LMT line for > all the packets. > Since, the command contents are

RE: [v2 1/4] lib: add optional fields in GRE header

2022-02-11 Thread Sean Zhang (Networking SW)
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Friday, February 11, 2022 5:38 PM > To: Sean Zhang (Networking SW) ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Olivier Matz > > Cc: dev@dpdk.org; Andrew Rybchenko ; > Ori Kam > Subject: Re: [v2 1/4] lib: add optional fields

[Bug 920] [19.11.11] drivers/event/skeleton meson build failure with gcc 10.3.0 + debug on FreeBSD13.0/64

2022-02-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=920 gaodaxue (daxuex@intel.com) changed: What|Removed |Added Resolution|--- |WONTFIX Status|UNCON

Re: [PATCH v4 00/10] ethdev: datapath-focused flow rules management

2022-02-11 Thread Ivan Malov
Hi Ferruh, On Thu, 10 Feb 2022, Ferruh Yigit wrote: On 2/9/2022 9:37 PM, Alexander Kozyrev wrote: Three major changes to a generic RTE Flow API were implemented in order to speed up flow rule insertion/destruction and adapt the API to the needs of a datapath-focused flow rules management appli

Re: [PATCH v5 01/10] ethdev: introduce flow pre-configuration hints

2022-02-11 Thread Andrew Rybchenko
On 2/11/22 05:26, Alexander Kozyrev wrote: The flow rules creation/destruction at a large scale incurs a performance penalty and may negatively impact the packet processing when used as part of the datapath logic. This is mainly because software/hardware resources are allocated and prepared durin

RE: [v2 1/4] lib: add optional fields in GRE header

2022-02-11 Thread Ori Kam
Hi Sean, > -Original Message- > From: Sean Zhang > Subject: [v2 1/4] lib: add optional fields in GRE header > > There are optional fields in GRE header(checksum/key/sequence), this > patch adds definition of structures of the optional fields. > > Signed-off-by: Sean Zhang > --- > lib/

Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 2:20 AM, Huichao Cai wrote: A small problem.Why is the content of the email just sent to you not visible at Patchwork (this patch). Hi Huichao, The discussion is not in the same email thread, it looks like it spread into multiple threads. This is because some email headers (Ref

RE: [v2 2/4] ethdev: support GRE optional fields

2022-02-11 Thread Ori Kam
Hi Sean, > -Original Message- > From: Sean Zhang (Networking SW) > Subject: [v2 2/4] ethdev: support GRE optional fields > > Add flow pattern items and header format for matching optional fields > (checksum/key/sequence) in GRE header. And the flags in gre item should > be correspondingl

RE: [v2 3/4] app/testpmd: add gre_option item command

2022-02-11 Thread Ori Kam
Hi Sean, > -Original Message- > From: Sean Zhang (Networking SW) > Subject: [v2 3/4] app/testpmd: add gre_option item command > > Add gre_option command for matching optional fields(checksum/key/sequence) > in GRE header. The item must follow gre item, and the item does not > change the

Re: [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events

2022-02-11 Thread Ray Kinsella
Thomas Monjalon writes: > 02/02/2022 12:44, Ray Kinsella: >> Ferruh Yigit writes: >> > On 1/28/2022 12:48 PM, Kalesh A P wrote: >> >> --- a/lib/ethdev/rte_ethdev.h >> >> +++ b/lib/ethdev/rte_ethdev.h >> >> @@ -3818,6 +3818,24 @@ enum rte_eth_event_type { >> >> RTE_ETH_EVENT_DESTROY,

Re:RE: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2022-02-11 Thread Huichao Cai
>AFAIK, we can't copy-paste code from Linux kernel. >As you noted it is under GPL, while DPDK is under BSD-3 license. Well, I'll rewrite the code. >Library routine has no idea would original IP packet will be used later or not. >In your particular case it might be not needed, but there might be

Re: [External] : Re:

2022-02-11 Thread Gaëtan Rivet
On Fri, Feb 11, 2022, at 10:37, Madhuker Mythri wrote: > Hi Gaetan and Ferruh, > >> >>-Original Message- >>From: Gaëtan Rivet >>Sent: 10 फरवरी 2022 21:39 >>To: Ferruh Yigit ; Madhuker Mythri >> >>Cc: dev@dpdk.org >>Subject: [External] : Re: >> >>On Thu, Feb 10, 2022, at 16:00, Ferruh Y

Re: [External] : Re: [PATCH] net/failsafe: Fix crash due to global devargs syntax parsing from secondary process

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 9:37 AM, Madhuker Mythri wrote: Hi Gaetan and Ferruh, -Original Message- From: Gaëtan Rivet Sent: 10 फरवरी 2022 21:39 To: Ferruh Yigit ; Madhuker Mythri Cc: dev@dpdk.org Subject: [External] : Re: On Thu, Feb 10, 2022, at 16:00, Ferruh Yigit wrote: On 2/10/2022 7:10 A

[PATCH v2] ethdev: introduce generic dummy packet burst function

2022-02-11 Thread Ferruh Yigit
Multiple PMDs have dummy/noop Rx/Tx packet burst functions. These dummy functions are very simple, introduce a common function in the ethdev and update drivers to use it instead of each driver having its own functions. Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Acked-by: Viacheslav Ovs

RE: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2022-02-11 Thread Ananyev, Konstantin
Hi Huichao >>As a nit, why not 'uint8_t *', to keep style the same through all file? >Yes,I can use 'uint8_t *.Thank you for your correction. > >>We already done such calculation in rte_ipv4_fragment_packet(), >>so can re-use header_len value here. >Yes,I can re-use header_len.Thank you for your

Re: [v2 1/4] lib: add optional fields in GRE header

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 1:45 AM, Sean Zhang wrote: There are optional fields in GRE header(checksum/key/sequence), this patch adds definition of structures of the optional fields. Signed-off-by: Sean Zhang --- lib/net/rte_gre.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a

RE: [External] : Re:

2022-02-11 Thread Madhuker Mythri
Hi Gaetan and Ferruh, > >-Original Message- >From: Gaëtan Rivet >Sent: 10 फरवरी 2022 21:39 >To: Ferruh Yigit ; Madhuker Mythri > >Cc: dev@dpdk.org >Subject: [External] : Re: > >On Thu, Feb 10, 2022, at 16:00, Ferruh Yigit wrote: >> On 2/10/2022 7:10 AM, madhuker.myt...@oracle.com wrot

Re: [v2 0/4] Add support for GRE optional fields matching

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 1:45 AM, Sean Zhang wrote: This patch set adds support for matching optional fields of GRE header. The optional fields are checksum, key and sequence number. Currently, key field is supported with pattern gre_key item '.. / gre / gre_key value is xx / ..' with field gre_key in misc,

[PATCH v7 5/5] crypto: modify return value for asym session create

2022-02-11 Thread Ciara Power
Rather than the asym session create function returning a session on success, and a NULL value on error, it is modified to now return int values - 0 on success or -EINVAL/-ENOTSUP/-ENOMEM on failure. The session to be used is passed as input. This adds clarity on the failure of the create function,

[PATCH v7 4/5] crypto: add asym session user data API

2022-02-11 Thread Ciara Power
A user data field is added to the asymmetric session structure. Relevant API added to get/set the field. Signed-off-by: Ciara Power Acked-by: Fan Zhang Acked-by: Anoob Joseph --- v4: - Reworded release notes. - Added possible error return values in function comment. - Removed docs code a

[PATCH v7 3/5] crypto: hide asym session structure

2022-02-11 Thread Ciara Power
The rte_cryptodev_asym_session structure is now moved to an internal header. This will no longer be used directly by apps, private session data can be accessed via get API. Signed-off-by: Ciara Power Acked-by: Fan Zhang Acked-by: Anoob Joseph --- v4: - Initialised session variables as NULL.

[PATCH v7 2/5] crypto: use single buffer for asymmetric session

2022-02-11 Thread Ciara Power
Rather than using a session buffer that contains pointers to private session data elsewhere, have a single session buffer. This session is created for a driver ID, and the mempool element contains space for the max session private data needed for any driver. Signed-off-by: Ciara Power Acked-by: F

[PATCH v7 1/5] doc: replace asym crypto code with literal includes

2022-02-11 Thread Ciara Power
The programmer's guide for cryptodev included sample code for using Asymmetric crypto. This is now replaced with direct code from the test application, using literal includes. It is broken into snippets as the test application didn't have all of the required code in one function. Signed-off-by: Ci

[PATCH v7 0/5] crypto: improve asym session usage

2022-02-11 Thread Ciara Power
This patchset includes improvements for the asymmetric session. The main change is to the session structure, which is now a single mempool object, rather than having pointers to private data elsewhere. This session structure is now hidden in an internal header, so the app will never use it directly

RE: [PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-11 Thread Loftus, Ciara
> > > > On 2/10/2022 5:47 PM, Loftus, Ciara wrote: > > >> Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process > support > > >> > > >> On 2/10/2022 3:40 PM, Loftus, Ciara wrote: > > Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process > > support > > > > On 2/9/

[DPDK] /lib/eal: fix failed to stop device monitor error

2022-02-11 Thread wenxuanx . wu
From: Wenxuan Wu The ret value in rte_dev_event_monitor_stop stands for whether the monitor has been successfully closed ,and should not bind with rte_intr_callback_unregister,so once it goes to the right exit point of rte_dev_event_monitor, the ret value should be set to 0. Also ,the refmonitor

RE: e1000 forced 1G support?

2022-02-11 Thread Morten Brørup
> From: Bly, Mike [mailto:m...@ciena.com] > Sent: Friday, 11 February 2022 02.30 > > Hello, > > This is in regards to the DPDK E1000 driver used for the i350 [8086:1521] NIC. > > I am looking to see if we can get forced speed == 1000Mb (1Gb) support > working on this NIC. The current DPDK driver

RE: Open Coverity defects in DPDK

2022-02-11 Thread Mcnamara, John
P.S., In Coverity there are a number of "Out-of-bounds access (OVERRUN)" defects that relate to rte_memcpy() or one of the wrappers around it. They look like this: CID 362728 (#1 of 1): Out-of-bounds access (OVERRUN) 11. overrun-buffer-val: Overrunning array tdata->auth_tag.data of 16 b

[PATCH] common/cnxk: add CNF950_A0 support

2022-02-11 Thread Tomasz Duszynski
Add PCI IDs which match CNF95O_A0 SoC. Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_constants.h | 1 + drivers/event/cnxk/cn9k_eventdev.c | 2 ++ drivers/mempool/cnxk/cnxk_mempool.c | 2 ++ drivers/net/cnxk/cn9k_ethdev.c | 4 4 fi

  1   2   >