RE: Questions on i40e TX path

2022-02-08 Thread Xing, Beilei
Hi Honnappa, > -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, February 9, 2022 12:36 PM > To: Xing, Beilei ; dev@dpdk.org > Cc: Feifei Wang ; Ruifeng Wang > ; Yigit, Ferruh ; Richardson, > Bruce ; nd ; nd > Subject: Questions on i40e TX path > > Hi Beilei, > I

RE: [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR

2022-02-08 Thread Wang, Jie1X
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, February 9, 2022 3:31 PM > To: Wang, Jie1X ; dev@dpdk.org > Cc: Yang, SteveX ; or...@nvidia.com; Singh, Aman > Deep ; Yigit, Ferruh ; > tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Wu, Jingjing > ; Zhang, Qi Z ; > olivi

RE: [PATCH v4 5/6] net/iavf: support L2TPv2 for AVF HASH

2022-02-08 Thread Wang, Jie1X
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, February 9, 2022 3:02 PM > To: Wang, Jie1X ; dev@dpdk.org > Cc: Yang, SteveX ; or...@nvidia.com; Singh, Aman > Deep ; Yigit, Ferruh ; > tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Wu, Jingjing > ; Zhang, Qi Z ; > olivi

RE: [PATCH v3] net/af_xdp: re-enable secondary process support

2022-02-08 Thread Loftus, Ciara
> > On 2/8/2022 6:42 PM, Stephen Hemminger wrote: > > On Tue, 8 Feb 2022 18:00:27 + > > Ferruh Yigit wrote: > > > >> On 2/8/2022 5:45 PM, Stephen Hemminger wrote: > >>> On Tue, 8 Feb 2022 13:48:00 + > >>> Ciara Loftus wrote: > >>> > +- **Secondary Processes** > + > + Rx

[PATCH v2] net/memif: remove pointer deference before null check

2022-02-08 Thread Weiguo Li
There are duplicates of assignment here, the one before null check may cause a null pointer deference, so remove the previous one. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Signed-off-by: Weiguo Li --- v2: * fix typo --- drivers/net/memif/memif_socket.c | 3 +-- 1 file c

RE: [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR

2022-02-08 Thread Xing, Beilei
> -Original Message- > From: Wang, Jie1X > Sent: Tuesday, February 8, 2022 4:39 PM > To: dev@dpdk.org > Cc: Yang, SteveX ; or...@nvidia.com; Singh, Aman > Deep ; Yigit, Ferruh ; > tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Wu, Jingjing > ; Xing, Beilei ; Zhang, Qi Z > ; olivier

[PATCH] net/memif: remove pointer deference before null check

2022-02-08 Thread Weiguo Li
There are duplicates of asignment here, the one before null check may cause a null pointer deference, so remove the previous one. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Signed-off-by: Weiguo Li --- drivers/net/memif/memif_socket.c | 3 +-- 1 file changed, 1 insertion(

[PATCH v3 1/4] kni: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- lib/kni/rte_kni_fifo.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/kni/rte_kni_fifo.h b/lib/kni/rte_kni_fifo.h index d2ec82fe87..2ff71554c0 100644 --- a/lib/kni/rte_kni_fifo.h +++

[PATCH v3 3/4] efd: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- lib/efd/rte_efd_x86.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/efd/rte_efd_x86.h b/lib/efd/rte_efd_x86.h index e2f9dcca88..6e377765f9 100644 --- a/lib/efd/rte_efd_x86.h +++ b/lib/efd/rte_efd_

[PATCH v3 4/4] hash: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- lib/hash/rte_cmp_arm64.h | 5 + lib/hash/rte_cmp_x86.h | 5 + 2 files changed, 10 insertions(+) diff --git a/lib/hash/rte_cmp_arm64.h b/lib/hash/rte_cmp_arm64.h index e9e26f9abd..ecf0ea3e6f 100644 ---

[PATCH v3 2/4] eal: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li Acked-by: Dmitry Kozlyuk --- lib/eal/include/rte_eal_paging.h| 5 + lib/eal/windows/include/rte_virt2phys.h | 5 + 2 files changed, 10 insertions(+) diff --git a/lib/eal/include/rte_eal_paging.h b/

[PATCH v3 0/4] add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. --- v3: * limit changes to "rte_xxx.h" headers v2: * update to a simple style Weiguo Li (4): kni: add define guards to avoid multi-inclusion eal: add define guards to avoid multi-inclusion efd: add define guards to avoid multi-inclusio

RE: [PATCH v4 5/6] net/iavf: support L2TPv2 for AVF HASH

2022-02-08 Thread Xing, Beilei
> -Original Message- > From: Wang, Jie1X > Sent: Tuesday, February 8, 2022 4:39 PM > To: dev@dpdk.org > Cc: Yang, SteveX ; or...@nvidia.com; Singh, Aman > Deep ; Yigit, Ferruh ; > tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Wu, Jingjing > ; Xing, Beilei ; Zhang, Qi Z > ; olivier

[PATCH v1] maintainers: update for testpmd

2022-02-08 Thread Yuying Zhang
Add Cristian as maintainer of test-pmd/cmdline_tm.* files. Signed-off-by: Yuying Zhang --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c65b753c6b..cab1821b11 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -406,6 +406,7 @@ F: lib/ethdev/rte_flow*

[PATCH v3 3/3] eal: move common filesystem setup code into one file

2022-02-08 Thread Stephen Hemminger
Both Linux and FreeBSD have same code for creating runtime directory and reading sysfs files. Put them in the new lib/eal/unix subdirectory. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 88 --- lib/eal/linux/eal.c | 90 -

[PATCH v3 2/3] eal: support systemd service convention for runtime directory

2022-02-08 Thread Stephen Hemminger
Systemd.exec supports configuring the runtime directory of a service via RuntimeDirectory=. This creates the directory with the necessary permissions which actual service may not have if running in container. The change to DPDK is to look for the environment RUNTIME_DIRECTORY first and use that in

[PATCH v3 1/3] eal: remove size for eal_set_runtime_dir

2022-02-08 Thread Stephen Hemminger
The size argument to eal_set_runtime_dir is useless and was being used incorrectly in strlcpy. It worked only because all callers passed PATH_MAX which is same as sizeof the destination runtime_dir. Note: this is an internal API so no user exposed change. Signed-off-by: Stephen Hemminger Reviewe

[PATCH v3 0/3] eal: support configuring runtime directory

2022-02-08 Thread Stephen Hemminger
Systemd defines a standard way for setting the runtime directory for services by setting RUNTIME_DIRECTORY in the environment, and this is a useful way to interact with DPDK internals. DPDK was already following the relevant standards but there can be time when running as a non-root user that the d

Re: [PATCH v2 00/16] add define guards to avoid multi-inclusion

2022-02-08 Thread Stephen Hemminger
On Wed, 9 Feb 2022 11:02:08 +0800 Weiguo Li wrote: > Supplement define guards to prevent multiple inclusion. > > Notice that there are couples of guard styles used in this project, > like "XX_H", "XX_H_" or "XXX_H__". > Adhere to Thomas's advice, this patch set use the first style to > make it

Re: [PATCH v2 08/16] net/tap: add define guards to avoid multi-inclusion

2022-02-08 Thread Stephen Hemminger
On Wed, 9 Feb 2022 11:02:16 +0800 Weiguo Li wrote: > Supplement define guards to prevent multiple inclusion. > > Signed-off-by: Weiguo Li This is a driver specific include, not required

Re: [PATCH v2 06/16] net/netvsc: add define guards to avoid multi-inclusion

2022-02-08 Thread Stephen Hemminger
On Wed, 9 Feb 2022 11:02:14 +0800 Weiguo Li wrote: > Supplement define guards to prevent multiple inclusion. > > Signed-off-by: Weiguo Li Why bother these are just driver specific includes, not a public API

RE: [PATCH 6/9] net/ngbe: add support to custom PHY interfaces

2022-02-08 Thread Jiawen Wu
On February 9, 2022 1:41 AM, Ferruh Yigit wrote: > On 2/8/2022 10:11 AM, Jiawen Wu wrote: > > Support sub_device ID 61/62/64 for YT8521S SFP, and 51/52 for M88E1512 > > PHY. > > > > Signed-off-by: Jiawen Wu > > <...> > > > @@ -69,6 +69,10 @@ New Features > > * Added AES-XCBC support in looka

[PATCH] net/bnxt: fix ring calculation for representors

2022-02-08 Thread Ajit Khaparde
Currently the Tx and Rx ring count for representors is fixed. It does not consider the number of rings created for the parent function. And that can cause issues not only during initialization but while running traffic. Instead check the number of rings created for the parent function while configu

[PATCH] net/bnxt: set HW coalescing parameters

2022-02-08 Thread Ajit Khaparde
Set coalescing parameters correctly for Rx completion rings. This is not being done for the Rx completion rings currently. Fixes: 657c2a7f1dd4 ("net/bnxt: create aggregation rings when needed") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Signed-off-by: Somnath Kotur Reviewed-by: Kalesh AP

Re: [PATCH v3 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-08 Thread Jerin Jacob
On Tue, Feb 8, 2022 at 7:42 PM Alexander Kozyrev wrote: > > > On Tuesday, February 8, 2022 5:57 Jerin Jacob wrote: > > On Sun, Feb 6, 2022 at 8:57 AM Alexander Kozyrev > > wrote: > > > > > +The asynchronous flow rule insertion logic can be broken into two phases. > > > + > > > +1. Initialization

Re:Re:RE: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2022-02-08 Thread Huichao Cai
Hi everyone, This patch hasn't changed status for a long time, I want to know what the current situation of this patch is? Huichao Cai

RE: [PATCH v3 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-08 Thread Alexander Kozyrev
On Tuesday, February 8, 2022 10:24 Ivan Malov wrote: > On Tue, 8 Feb 2022, Alexander Kozyrev wrote: > >> > >>> + > >>> +Enqueue creation operation > >>> +~~ > >>> + > >>> +Enqueueing a flow rule creation operation is similar to simple creation. > >> > >> If it is enqueue op

[PATCH v2] eventdev/eth_tx: fix queue add logic

2022-02-08 Thread Naga Harish K S V
The internal function txa_service_queue_add is returning 0 in case of error. correct this logic to return a negative value to indicate failure. Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") Signed-off-by: Naga Harish K S V --- v2: * adjust commit message line size --- lib

[PATCH] eventdev/eth_tx: fix queue add logic

2022-02-08 Thread Naga Harish K S V
The internal function txa_service_queue_add is returning 0 in case of error. correct this logic to return negative value to indicate failure. Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") Signed-off-by: Naga Harish K S V --- lib/eventdev/rte_event_eth_tx_adapter.c | 13 +++

Re: [PATCH] net/bnxt: dmac field optional for f2 match

2022-02-08 Thread Ajit Khaparde
On Tue, Feb 8, 2022 at 9:00 AM Ajit Khaparde wrote: > > From: Shahaji Bhosle > > OvS is adding DMAC sometimes and skips sometimes for F2 flows, > to get around not offloading flow make the dmac field optional > in OvS template. > > Signed-off-by: Shahaji Bhosle > Reviewed-by: Kishore Padmanabha

[PATCH] eventdev/eth_rx: fix queue config get API

2022-02-08 Thread Naga Harish K S V
the memcpy size used in queue config get function is more than the source size. Use correct size to avoid copy of unnecessary data. Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") Signed-off-by: Naga Harish K S V --- lib/eventdev/rte_event_eth_rx_adapter.c | 2 +- 1 file chan

[PATCH v4 0/1] integrate dmadev in vhost

2022-02-08 Thread Jiayu Hu
Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA abstraction layer and simplify application logics, this patch integrates dmadev in vhost. To enable the flexibility of using DMA devices in different function modules, not limited in vhost, vhost doesn't manage DMA devices. Ap

[PATCH v4 1/1] vhost: integrate dmadev in asynchronous data-path

2022-02-08 Thread Jiayu Hu
Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA abstraction layer and simplify application logics, this patch integrates dmadev in asynchronous data path. Signed-off-by: Jiayu Hu Signed-off-by: Sunil Pai G --- doc/guides/prog_guide/vhost_lib.rst | 100 +- example

[PATCH v3] raw/ntb: clear all valid DB bits when DB init

2022-02-08 Thread Junfeng Guo
Before registering the doorbell interrupt handler callback function, all the valid doorbell bits within the NTB private data struct should be cleared to avoid the confusion of the handshake timing sequence diagram when setting up the NTB connection in back-to-back mode. Fixes: 62012a76811e ("raw/n

[PATCH v2] raw/ntb: clear all valid DB bits when DB init

2022-02-08 Thread Junfeng Guo
Before registering the doorbell interrupt handler callback function, all the valid doorbell bits within the NTB private data struct should be cleared to avoid the confusion of the handshake timing sequence diagram when setting up the NTB connection in back-to-back mode. Fixes: 62012a76811e ("raw/n

Questions on i40e TX path

2022-02-08 Thread Honnappa Nagarahalli
Hi Beilei, I want to make sure my understanding of the TX path is correct. Following is my understanding. 1) The RS bit must be set in the TX descriptors to ask the NIC to report back the send status. 2) The NIC reports the send completion by setting the DTYPE field to 0xf. This also in

[PATCH] raw/ntb: clear all valid DB bits when DB init

2022-02-08 Thread Junfeng Guo
Before registering the doorbell interrupt handler callback function, all the valid doorbell bits within the NTB private data struct should be cleared to aviod the confusion of the handshake timing sequence diagram when setting up the NTB connection in back-to-back mode. Fixes: 62012a76811e ("raw/n

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-02-08 Thread Wang, Haiyue
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, February 8, 2022 22:52 > To: Daly, Jeff ; Wang, Haiyue ; > Stephen Douthit > ; Morten Brørup ; Lu, > Wenzhuo > ; Zhang, Helin ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wang, Wen ; sta...@dpdk.org > Subject: Re: [PATCH v2 3/7] net/ix

[PATCH v2 16/16] pcapng: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- lib/pcapng/pcapng_proto.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/pcapng/pcapng_proto.h b/lib/pcapng/pcapng_proto.h index 47161d8a12..6dc100632a 100644 --- a/lib/pcapng/pcapng_proto.h +++ b/

[PATCH v2 13/16] eal: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li Acked-by: Dmitry Kozlyuk --- lib/eal/include/rte_eal_paging.h| 5 + lib/eal/windows/include/rte_virt2phys.h | 5 + 2 files changed, 10 insertions(+) diff --git a/lib/eal/include/rte_eal_paging.h b/

[PATCH v2 15/16] hash: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- lib/hash/rte_cmp_arm64.h | 5 + lib/hash/rte_cmp_x86.h | 5 + 2 files changed, 10 insertions(+) diff --git a/lib/hash/rte_cmp_arm64.h b/lib/hash/rte_cmp_arm64.h index e9e26f9abd..ecf0ea3e6f 100644 ---

[PATCH v2 14/16] efd: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- lib/efd/rte_efd_x86.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/efd/rte_efd_x86.h b/lib/efd/rte_efd_x86.h index e2f9dcca88..6e377765f9 100644 --- a/lib/efd/rte_efd_x86.h +++ b/lib/efd/rte_efd_

Re: [PATCH v18 8/8] eal: implement functions for mutex management

2022-02-08 Thread Narcisa Ana Maria Vasile
On Mon, Feb 07, 2022 at 04:02:54PM +, Ananyev, Konstantin wrote: > > Add functions for mutex init, destroy, lock, unlock, trylock. > > > > Windows does not have a static initializer. Initialization > > is only done through InitializeCriticalSection(). To overcome this, > > RTE_INIT_MUTEX macro

[PATCH v2 12/16] acl: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. It should noted that there is an exceptional case: lib/acl/acl_run_avx512_common.h is designed to be included several times. Signed-off-by: Weiguo Li --- lib/acl/acl_run_altivec.h | 5 + lib/acl/acl_run_avx2.h | 5 + lib/acl/

[PATCH v2 11/16] kni: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- kernel/linux/kni/compat.h | 5 + lib/kni/rte_kni_fifo.h| 5 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h index 664785674f..f15

[PATCH v2 10/16] raw/ifpga/base: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- drivers/raw/ifpga/base/opae_at24_eeprom.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/raw/ifpga/base/opae_at24_eeprom.h b/drivers/raw/ifpga/base/opae_at24_eeprom.h index caae9a3ec1..9d40b84

[PATCH v2 09/16] net/virtio: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- drivers/net/virtio/virtio_rxtx_packed_avx.h | 5 + drivers/net/virtio/virtio_rxtx_packed_neon.h | 5 + 2 files changed, 10 insertions(+) diff --git a/drivers/net/virtio/virtio_rxtx_packed_avx.h b/driv

[PATCH v2 06/16] net/netvsc: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- drivers/net/netvsc/hn_nvs.h | 5 + drivers/net/netvsc/hn_rndis.h | 5 + drivers/net/netvsc/hn_var.h | 5 + 3 files changed, 15 insertions(+) diff --git a/drivers/net/netvsc/hn_nvs.h b/drivers/ne

[PATCH v2 08/16] net/tap: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- drivers/net/tap/tap_bpf_insns.h | 5 + drivers/net/tap/tap_log.h | 5 + 2 files changed, 10 insertions(+) diff --git a/drivers/net/tap/tap_bpf_insns.h b/drivers/net/tap/tap_bpf_insns.h index 1a91b

[PATCH v2 07/16] net/qede: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- drivers/net/qede/base/reg_addr.h | 5 + drivers/net/qede/qede_sriov.h| 5 + 2 files changed, 10 insertions(+) diff --git a/drivers/net/qede/base/reg_addr.h b/drivers/net/qede/base/reg_addr.h index c

[PATCH v2 05/16] net/i40e: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- v2: * update to a simple guard style --- drivers/net/i40e/i40e_regs.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/i40e/i40e_regs.h b/drivers/net/i40e/i40e_regs.h index b19bb1d5a5..0f4db4

[PATCH v2 04/16] net/enetfec: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- v2: * update to a simple guard style --- drivers/net/enetfec/enet_uio.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/enetfec/enet_uio.h b/drivers/net/enetfec/enet_uio.h index fec8ba6f95..

[PATCH v2 00/16] add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Notice that there are couples of guard styles used in this project, like "XX_H", "XX_H_" or "XXX_H__". Adhere to Thomas's advice, this patch set use the first style to make it simple. Weiguo Li (16): bus/dpaa: add define guards to avoid mu

[PATCH v2 02/16] event/octeontx: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- v2: * update to a simple guard style --- drivers/event/octeontx/timvf_worker.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/event/octeontx/timvf_worker.h b/drivers/event/octeontx/timvf_worke

[PATCH v2 03/16] net/cxgbe: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- v2: * update to a simple guard style --- drivers/net/cxgbe/base/t4_regs.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/cxgbe/base/t4_regs.h b/drivers/net/cxgbe/base/t4_regs.h index 8a14d0

[PATCH v2 01/16] bus/dpaa: add define guards to avoid multi-inclusion

2022-02-08 Thread Weiguo Li
Supplement define guards to prevent multiple inclusion. Signed-off-by: Weiguo Li --- v2: * update to a simple guard style --- drivers/bus/dpaa/base/qbman/qman.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/bus/dpaa/base/qbman/qman.h b/drivers/bus/dpaa/base/qbman/qman.h inde

Re: [PATCH v18 8/8] eal: implement functions for mutex management

2022-02-08 Thread Narcisa Ana Maria Vasile
On Tue, Feb 08, 2022 at 02:21:49AM +, Ananyev, Konstantin wrote: > > > > > + > > > +/** > > > + * Thread mutex representation. > > > > Actually, please scrap that comment. > Obviously it wouldn't work for static variables, > and doesn't make much sense. > Though few thoughts remain: > for

RE: [PATCH] net/iavf: initialize large VF setting at startup

2022-02-08 Thread Xu, Ting
> -Original Message- > From: Ghalem Boudour > Sent: Thursday, February 3, 2022 5:04 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Ghalem Boudour ; > Thibaut Collet ; Olivier Matz > > Subject: [PATCH] net/iavf: initialize large VF setting at startup > > lv_enabled is used to r

RE: [PATCH 5/9] net/ngbe: optimize the PHY initialization process

2022-02-08 Thread Jiawen Wu
On February 9, 2022 1:40 AM, Ferruh Yigit wrote: > On 2/8/2022 10:11 AM, Jiawen Wu wrote: > > Reduce the probability of PHY init failure, And add its error return. > > > > Patch is missing stable tag, is it intentional? > Or do you want patch not to be backported? > Because PHY init failed never

RE: [PATCH v3 2/2] net/ice: support drop any and steer all to queue

2022-02-08 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Wednesday, January 26, 2022 11:57 PM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Zhang, Yuying > Subject: [PATCH v3 2/2] net/ice: support drop any and steer all to queue > > This patch supports drop any and steer all to queue in switch fil

RE: [PATCH v3 1/2] net/ice/base: add profile validation on switch filter

2022-02-08 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Wednesday, January 26, 2022 11:57 PM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Zhang, Yuying > Subject: [PATCH v3 1/2] net/ice/base: add profile validation on switch filter > > Profile type was determined without validation when getting

RE: [PATCH 0/2] Add logic to IAVF to count continuous DD bits for Arm

2022-02-08 Thread Zhang, Qi Z
> -Original Message- > From: Kathleen Capella > Sent: Saturday, February 5, 2022 8:26 AM > Cc: dev@dpdk.org; n...@arm.com; dharmik.thak...@arm.com; > honnappa.nagaraha...@arm.com; Kathleen Capella > > Subject: [PATCH 0/2] Add logic to IAVF to count continuous DD bits for Arm > > This

RE: [PATCH v1] net/ice: fix dereference before null check

2022-02-08 Thread Zhang, Qi Z
> -Original Message- > From: Yang, SteveX > Sent: Monday, February 7, 2022 4:26 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; > sta...@dpdk.org > Subject: [PATCH v1] net/ice: fix dereference before null check > > This patch fixes coverity issue by assigning

RE: [PATCH v2] net/iavf: fix null pointer dereference

2022-02-08 Thread Zhang, Qi Z
> -Original Message- > From: Weiguo Li > Sent: Friday, January 28, 2022 5:43 PM > To: Wu, Jingjing > Cc: Nicolau, Radu ; dev@dpdk.org > Subject: [PATCH v2] net/iavf: fix null pointer dereference > > Check for memory allocation failure is added to avoid null pointer > dereference. > >

[PATCH 1/2] net/sfc: do not push fast free offload to default TxQ config

2022-02-08 Thread Ivan Malov
Doing so is wrong since fast free is an adapter-wide offload. Technically, the offending commit (see "Fixes" tag) does not induce failures, however, such started to occur after commit a4996bd89c42 ("ethdev: new Rx/Tx offloads API") had shown up, because of the strict offload validation in the gene

[PATCH 2/2] net/sfc: demand Tx fast free offload on ef10 simple datapath

2022-02-08 Thread Ivan Malov
Enforce this offload as it is immutable on the said datapath. Fixes: c78d280e88ef ("net/sfc: convert to new Tx offload API") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_tx.c | 8 1 file changed, 8 inser

Re: [PATCH v5 1/1] eal: add internal function to get base address

2022-02-08 Thread Thomas Monjalon
08/02/2022 18:15, Burakov, Anatoly: > On 18-Jan-22 1:33 PM, Srikanth Yalavarthi wrote: > > Added an internal helper to get OS-specific EAL mapping base address > > > > This helper can be used by the drivers to program offload / accelerator > > devices, where the base address can be used as a refer

RE: [PATCH 0/5] Adding new features and improvements in cnxk crypto PMD

2022-02-08 Thread Akhil Goyal
> > This series adds ESN, antireplay support and improvements > to cnxk crypto PMDs. > > Anoob Joseph (4): > common/cnxk: add err ctl > common/cnxk: add ROC cache line size constant > crypto/cnxk: use unique cache line per inst > crypto/cnxk: fix updation of number of descriptors > > Tej

[PATCH v6 3/3] security: add IPsec option for IP reassembly

2022-02-08 Thread Akhil Goyal
A new option is added in IPsec to enable and attempt reassembly of inbound IP packets. Signed-off-by: Akhil Goyal --- devtools/libabigail.abignore | 5 + lib/security/rte_security.h | 15 ++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/devtools/libabigail.abi

[PATCH v6 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-08 Thread Akhil Goyal
Hardware IP reassembly may be incomplete for multiple reasons like reassembly timeout reached, duplicate fragments, etc. To save application cycles to process these packets again, a new mbuf dynflag is added to show that the mbuf received is not reassembled properly. Now if this dynflag is set, ap

[PATCH v6 1/3] ethdev: introduce IP reassembly offload

2022-02-08 Thread Akhil Goyal
IP Reassembly is a costly operation if it is done in software. The operation becomes even more costlier if IP fragments are encrypted. However, if it is offloaded to HW, it can considerably save application cycles. Hence, a new offload feature is exposed in eth_dev ops for devices which can attemp

[PATCH v6 0/3] ethdev: introduce IP reassembly offload

2022-02-08 Thread Akhil Goyal
As discussed in the RFC[1] sent in 21.11, a new offload is introduced in ethdev for IP reassembly. This patchset add the IP reassembly RX offload. Currently, the offload is tested along with inline IPsec processing. It can also be updated as a standalone offload without IPsec, if there are some ha

Re: [PATCH] ci: remove outdated default reference tag for ABI

2022-02-08 Thread Brandon Lo
On Tue, Feb 8, 2022 at 10:09 AM Aaron Conole wrote: > I think the default was there for labs that run the build script > manually. Maybe there are no such users, though. I believe the lab has > its own script for doing such ABI checks (but can't remember off the top > of my head). Just confirmi

[PATCH V2] pipeline: support checksum for variable size headers

2022-02-08 Thread Cristian Dumitrescu
Added checksum support for variable size headers such as IPv4 headers with options. Signed-off-by: Cristian Dumitrescu Signed-off-by: Yogesh Jangra Signed-off-by: Harshad Suresh Narayane --- lib/pipeline/rte_swx_pipeline.c | 13 +++--- lib/pipeline/rte_swx_pipeline_internal.h | 59 +++

RE: [EXT] [PATCH v3 0/5] Add JSON vector set support to fips validation

2022-02-08 Thread Akhil Goyal
Hi Marko/Fan, Please review this series. > Adds a very basic introduction to JSON vector sets in > the fips validation example application. This patch set > will only introduce the AES-GCM test using a JSON request > file because the other algorithms need more information > than what is given in

RE: [EXT] [PATCH] crypto/ipsec_mb: fix null pointer dereference

2022-02-08 Thread Akhil Goyal
> Adjust memory check and use in a proper order to avoid > null pointer dereference. > > Fixes: 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD") > > Signed-off-by: Weiguo Li > --- This patch is a duplicate of a patch already submitted. http://patches.dpdk.org/project/dpdk/patch/20220116194043

RE: [EXT] [PATCH v1] doc: update FIPS docs

2022-02-08 Thread Akhil Goyal
> Added missing step for converting SHA request files to correct > format. Replaced AES_GCM with GCM to follow the correct > naming format. > > Signed-off-by: Jakub Poczatek > --- Please add Fixes tag where SHA and AES were supported. Also cc sta...@dpdk.org

RE: [EXT] [PATCH] compress/octeontx: fix null pointer dereference

2022-02-08 Thread Akhil Goyal
> Check for memory allocation failure is added to avoid null > pointer dereference. > > Signed-off-by: Weiguo Li > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Added Fixes tag Cc: sta...@dpdk.org

[RFC] Testpmd Maintenance affecting DTS

2022-02-08 Thread Owen Hilyard
Currently, DTS tests DPDK via the example applications (/examples) and the apps (/app) included with DPDK. The DTS Working group has been trying to move to primarily using Testpmd, since it is the most complete and only using one application causes less maintenance work. Since Testpmd provides a te

RE: [dpdk-dev v1] crypto/qat: fix QAT GEN4 AEAD job in raw data path

2022-02-08 Thread Akhil Goyal
> > This patch fix the cipher params configuration in AEAD job if > > QAT GEN4 unified cipher slice(UCS) enabled. > > > > Fixes: 328d690d2f60 ("crypto/qat: update raw data path") > > Cc: roy.fan.zh...@intel.com > > > > Signed-off-by: Kai Ji > > --- > Nice catch, thanks! > Acked-by: Fan Zhang A

RE: [PATCH] crypto/ipsec_mb: fix buffer overrun

2022-02-08 Thread Akhil Goyal
> >Memory for ZUC cipher/auth key in session had to be expanded to 32 bytes, > >instead of 16 bytes, when adding ZUC-256 support. > >However, impact is low as this memory is part of a union with bigger size > >than > >32 bytes. > > > >Coverity issue: 374374 > >Coverity issue: 374379 > >Fixes: 8c83

RE: [EXT] [PATCH] crypto/ipsec_mb: fix premature dereference

2022-02-08 Thread Akhil Goyal
> This patch removes coverity defect CID 374380: > Null pointer dereferences (REVERSE_INULL) > > Coverity issue: CID 374380 > Fixes: 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD") > Cc: roy.fan.zh...@intel.com > > Signed-off-by: Piotr Bronowski > --- Applied to dpdk-next-crypto

RE: [EXT] [dpdk-dev v2] test/cryptodev: Fix sgl oop in raw dp unit test

2022-02-08 Thread Akhil Goyal
> Fix SGL OOP support in sym raw dp unit test > > Fixes: cd8166c28cd1 ("test/crypto: add raw API test for dpaax") > Cc: hemant.agra...@nxp.com > > Signed-off-by: Kai Ji Acked-by: Akhil Goyal Applied to dpdk-next-crypto

RE: [PATCH] doc: simplify baseband features matrix

2022-02-08 Thread Akhil Goyal
> > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, 5 January 2022 18.40 > > > > The "feature" BBDEV API is useless as all baseband drivers > > must implement it by definition. > > > > The non-implemented features should not be marked with "N". > > Keeping them blank is clea

RE: [PATCH] common/qat: enable gen4 b devices

2022-02-08 Thread Akhil Goyal
> > Subject: [PATCH] common/qat: enable gen4 b devices > > > > This commit enables CPM2.0b devices in Intel QuickAssist > > Technology PMD. > > > > Signed-off-by: Arek Kusztal > > --- > Acked-by: Fan Zhang Applied to dpdk-next-crypto

RE: [EXT] [PATCH] examples/ipsec-secgw: wrong offload flag used for TSO IPv6

2022-02-08 Thread Akhil Goyal
> RTE_MBUF_F_TX_OUTER_IP_CKSUM should not be set for IPv6 packets. > > Fixes: a7f32947a316 ("examples/ipsec-secgw: support TCP TSO") Cc: sta...@dpdk.org > Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [PATCH v3 0/6] Fast restart with many hugepages

2022-02-08 Thread David Marchand
On Thu, Feb 3, 2022 at 7:13 PM Dmitry Kozlyuk wrote: > > This patchset is a new design and implementation of [1]. > > # Problem Statement > > Large allocations that involve mapping new hugepages are slow. > This is problematic, for example, in the following use case. > A single-process application

RE: [EXT] [PATCH v3 4/4] crypto: modify return value for asym session create

2022-02-08 Thread Akhil Goyal
> >> diff --git a/lib/cryptodev/rte_cryptodev.c > >> b/lib/cryptodev/rte_cryptodev.c index 0d816ed4a9..005f0e7952 100644 > >> --- a/lib/cryptodev/rte_cryptodev.c > >> +++ b/lib/cryptodev/rte_cryptodev.c > >> @@ -1912,9 +1912,9 @@ rte_cryptodev_sym_session_create(struct > >> rte_mempool *mp) > >>

[PATCH v5 3/3] security: add IPsec option for IP reassembly

2022-02-08 Thread Akhil Goyal
A new option is added in IPsec to enable and attempt reassembly of inbound IP packets. Signed-off-by: Akhil Goyal --- devtools/libabigail.abignore | 5 + lib/security/rte_security.h | 15 ++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/devtools/libabigail.abi

[PATCH v5 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-08 Thread Akhil Goyal
Hardware IP reassembly may be incomplete for multiple reasons like reassembly timeout reached, duplicate fragments, etc. To save application cycles to process these packets again, a new mbuf dynflag is added to show that the mbuf received is not reassembled properly. Now if this dynflag is set, ap

[PATCH v5 1/3] ethdev: introduce IP reassembly offload

2022-02-08 Thread Akhil Goyal
IP Reassembly is a costly operation if it is done in software. The operation becomes even more costlier if IP fragments are encrypted. However, if it is offloaded to HW, it can considerably save application cycles. Hence, a new offload feature is exposed in eth_dev ops for devices which can attemp

[PATCH v5 0/3] ethdev: introduce IP reassembly offload

2022-02-08 Thread Akhil Goyal
As discussed in the RFC[1] sent in 21.11, a new offload is introduced in ethdev for IP reassembly. This patchset add the IP reassembly RX offload. Currently, the offload is tested along with inline IPsec processing. It can also be updated as a standalone offload without IPsec, if there are some ha

RE: [EXT] Re: [PATCH v4 3/3] security: add IPsec option for IP reassembly

2022-02-08 Thread Akhil Goyal
Hi David, > On Tue, Feb 8, 2022 at 2:19 PM Akhil Goyal wrote: > > > > > I tried this in the first place but abi check was complaining in other > structures > > > > which included > > > > > rte_security_ipsec_sa_options. So I had to add suppression for those > > > > > as > well. > > > > > Can you

Re: [PATCH] vhost: fix guest physical address to host physical address mapping

2022-02-08 Thread Ferruh Yigit
On 2/8/2022 11:11 AM, Maxime Coquelin wrote: On 1/17/22 17:20, Yuan Wang wrote: Async copy fails when looking up hpa in the gpa to hpa mapping table. This happens because the gpa is matched exactly in the merged mapping table, and the merge loses the mapping entries. A new range comparison met

Re: [EXT] Re: [PATCH v4 3/3] security: add IPsec option for IP reassembly

2022-02-08 Thread David Marchand
On Tue, Feb 8, 2022 at 2:19 PM Akhil Goyal wrote: > > > > I tried this in the first place but abi check was complaining in other > > > > structures > > > which included > > > > rte_security_ipsec_sa_options. So I had to add suppression for those as > > > > well. > > > > Can you try at your end?

[PATCH] ethdev: introduce generic dummy packet burst function

2022-02-08 Thread Ferruh Yigit
Multiple PMDs have dummy/noop Rx/Tx packet burst functions. These dummy functions are very simple, introduce a common function in the ethdev and update drivers to use it instead of each driver having its own functions. Signed-off-by: Ferruh Yigit --- Cc: Ciara Loftus --- drivers/net/ark/ark_et

Re: [PATCH v3] net/af_xdp: re-enable secondary process support

2022-02-08 Thread Ferruh Yigit
On 2/8/2022 6:42 PM, Stephen Hemminger wrote: On Tue, 8 Feb 2022 18:00:27 + Ferruh Yigit wrote: On 2/8/2022 5:45 PM, Stephen Hemminger wrote: On Tue, 8 Feb 2022 13:48:00 + Ciara Loftus wrote: +- **Secondary Processes** + + Rx and Tx are not supported for secondary processes du

Re: [PATCH v3] net/af_xdp: re-enable secondary process support

2022-02-08 Thread Stephen Hemminger
On Tue, 8 Feb 2022 18:00:27 + Ferruh Yigit wrote: > On 2/8/2022 5:45 PM, Stephen Hemminger wrote: > > On Tue, 8 Feb 2022 13:48:00 + > > Ciara Loftus wrote: > > > >> +- **Secondary Processes** > >> + > >> + Rx and Tx are not supported for secondary processes due to the > >> single-p

[dpdk-dev v7 10/10] crypto/qat: support out of place SG list

2022-02-08 Thread Kai Ji
This patch adds the SGL out of place support to QAT PMD Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 28 -- drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 14 - drivers/crypto/qat/dev/qat_sym_pmd_gen1.c| 55 +--- 3 files changed, 83 ins

[dpdk-dev v7 08/10] crypto/qat: op burst data path rework

2022-02-08 Thread Kai Ji
This patch enable op_build_request function in qat_enqueue_op_burst, and qat_dequeue_process_response function in qat_dequeue_op_burst. The op_build_request invoked in crypto build request op is based on crypto operations setup during session init. Signed-off-by: Kai Ji --- drivers/common/qat/qa

  1   2   >