RE: [PATCH v2] eal: fix unaligned loads/stores in rte_memcpy_generic

2022-01-24 Thread Morten Brørup
> From: Georg Sauthoff [mailto:m...@gms.tf] > Sent: Tuesday, 25 January 2022 00.22 > > Hello, > > Stephen Hemminger wrote (Sun, 16 Jan 2022 08:32:20 -0800): > > > I would propose that DPDK have same kind of define as the kernel > > for SAFE_UNALIGNED_ACCESS. The C standard has to apply to all >

[PATCH] examples/l3fwd-acl:memset the acl matching result array

2022-01-24 Thread Zhiheng Chen
If we don't memset acl result array before matching, we can get arbitrary dirty data from memory. Signed-off-by: Zhiheng Chen --- examples/l3fwd-acl/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index 1fb1807235..7b9539b3ca 10

[PATCH v2] net/af_xdp: use libxdp if available

2022-01-24 Thread Ciara Loftus
AF_XDP support is deprecated in libbpf since v0.7.0 [1]. The libxdp library now provides the functionality which once was in libbpf and which the AF_XDP PMD relies on. This commit updates the AF_XDP meson build to use the libxdp library if a version >= v1.2.2 is available. If it is not available, o

[PATCH 15/15] vhost: make sure each queue callfd is configured

2022-01-24 Thread Andy Pei
During the vhost data path building process, qemu will create a call fd at first, and create another call fd in the end. The final call fd will be used to relay notify. In the original code, after kick fd is set, dev_conf will set the first call fd. Even though the actual call fd will set, the da

[PATCH 14/15] vdpa/ifc: make sure hardware last_avail_idx and last_used_idx is the same when blk device pause

2022-01-24 Thread Andy Pei
Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 2 +- drivers/vdpa/ifc/base/ifcvf.h | 3 +++ drivers/vdpa/ifc/ifcvf_vdpa.c | 32 +++- 3 files changed, 27 insertions(+), 10 deletions(-) diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/if

[PATCH 13/15] vdpa/ifc/base: for blk device, live migration register is different from net device

2022-01-24 Thread Andy Pei
1.last_avail_idx is lower 16 bit of the register. 2.address of ring_state register is different between net and blk device. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 36 +--- drivers/vdpa/ifc/base/ifcvf.h | 1 + 2 files changed, 30 insertions(+)

[PATCH 12/15] vdpa/ifc: add is_blk flag to ifcvf_hw, and init is_blk during probe

2022-01-24 Thread Andy Pei
Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 1 + drivers/vdpa/ifc/ifcvf_vdpa.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h index 6dd7925..8e602af 100644 --- a/drivers/vdpa/ifc/base/ifcvf.h +++ b/drivers/vdpa/

[PATCH 11/15] vdpa: add config space change interrupt register and handle for virtio_blk

2022-01-24 Thread Andy Pei
Create a thread to poll and relay config space change interrupt. Use VHOST_USER_SLAVE_CONFIG_CHANGE_MSG to info qemu. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 113 ++ 1 file changed, 113 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf

[PATCH 10/15] vdpa/ifc: read virtio max_queues from hardware

2022-01-24 Thread Andy Pei
original code max_queues is set to IFCVF_MAX_QUEUES. New code max_queues is the min of IFCVF_MAX_QUEUES and hardware num_queues. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcv

[PATCH 09/15] vdpa/ifc: add some log at VDPA lauch before qemu connect

2022-01-24 Thread Andy Pei
Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index eff6ff3..0b4b77f 100644 --- a/drivers/vdpa/ifc/ifcvf_vdpa.c +++ b/drivers/vdpa/ifc/ifcvf

[PATCH 08/15] vdpa/ifc: set_vring_state op is mandatory, add set_vring_state for blk device

2022-01-24 Thread Andy Pei
Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index 1f832a3..eff6ff3 100644 --- a/drivers/vdpa/ifc/ifcvf_vdpa.c +++ b/drivers/vdpa/ifc/ifcvf_v

[PATCH 07/15] usertools: add support for virtio blk device

2022-01-24 Thread Andy Pei
Signed-off-by: Andy Pei --- usertools/dpdk-devbind.py | 8 1 file changed, 8 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index ace4627..cbe336f 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -14,6 +14,8 @@ from os.path imp

[PATCH 06/15] example/vdpa:add vdpa blk support in example

2022-01-24 Thread Andy Pei
Signed-off-by: Andy Pei --- examples/vdpa/Makefile | 2 +- examples/vdpa/main.c | 8 ++ examples/vdpa/meson.build| 1 + examples/vdpa/vdpa_blk_compact.c | 152 +++ examples/vdpa/vdpa_blk_compact.h | 118 exam

[PATCH 05/15] vdpa/ifc: add blk dev sw live migration

2022-01-24 Thread Andy Pei
Enable virtio blk sw live migration relay callfd and log the dirty page. In this version we ignore the write cmd and still mark it dirty. Maybe we can improve it later. Signed-off-by: Jin Yu Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 4 +- drivers/vdpa/ifc/base/ifcvf.h | 6

[PATCH 04/15] vdpa/ifc: add vdpa interrupt for blk device

2022-01-24 Thread Andy Pei
For the blk we need to relay all the cmd of each queue. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 48 +-- 1 file changed, 37 insertions(+), 11 deletions(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index

[PATCH 03/15] vdpa/ifc: add blk ops for ifc device

2022-01-24 Thread Andy Pei
For virtio blk device, re-use part of ifc driver ops. Implement ifcvf_blk_get_config for virtio blk device. Support VHOST_USER_PROTOCOL_F_CONFIG feature for virtio blk device. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 4 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 88 ++

[PATCH 02/15] vhost: add vdpa ops for blk device

2022-01-24 Thread Andy Pei
Get_config and set_config are necessary ops for blk device. Add get_config and set_config ops to vdpa ops. Signed-off-by: Andy Pei --- lib/vhost/vdpa_driver.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vdpa_driver.h b/lib/vhost/vdpa_driver.h index fc2d6

[PATCH 01/15] vdpa/ifc: add support for virtio blk device

2022-01-24 Thread Andy Pei
Re-use the vdpa/ifc code, distinguish blk and net device by pci_device_id. Blk and net device are implemeted with proper feature and ops. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 16 +++- drivers/vdpa/ifc/ifcvf_vdpa.c | 96 +++ 2 fil

[PATCH 00/15] add virtio_blk device support to vdpa/ifc

2022-01-24 Thread Andy Pei
This patch set add virtio_blk device support to vdpa/ifc driver. With a lot of similarities, I re-use part of vdpa/ifc driver. Distinguish the virtio net and blk device by device id, and implement specific features and ops. Add example to vdpa to support virtio_blk device. To support blk device li

RE: [PATCH v1] raw/ifpga/base: fix port feature ID

2022-01-24 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Tuesday, January 25, 2022 10:31 AM > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > ; Huang, Wei > Subject: [PATCH v1] raw/ifpga/base: fix port feature ID > > Fix ID value of port fea

Re: [dpdk-dev] [PATCH 0/4] bnxt fixes

2022-01-24 Thread Ajit Khaparde
On Thu, Jan 20, 2022 at 12:53 AM Kalesh A P wrote: > > From: Kalesh AP > > Please apply. > > Ajit Khaparde (1): > net/bnxt: fix VF resource allocation strategy > > Kalesh AP (3): > net/bnxt: fix check for autoneg enablement > net/bnxt: handle ring cleanup in case of error > net/bnxt: fix

RE: [PATCH v8] raw/ifpga: fix pthread cannot join

2022-01-24 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Rosen > Sent: Tuesday, January 25, 2022 9:43 AM > To: Huang, Wei ; dev@dpdk.org; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > ; step...@networkplumber.org; > david.march...@redhat.com > Subject: RE: [PATCH v8] raw/ifpga: fix pth

[dpdk-dev] [PATCH] drivers: enable keep flow rule device capability for cnxk

2022-01-24 Thread psatheesh
From: Kiran Kumar K Adding changes to enable keep flow rule device capability. With this change, flow rules will be kept across device restart. Signed-off-by: Kiran Kumar K Reviewed-by: Satheesh Paul --- drivers/common/cnxk/roc_npc.c | 8 drivers/common/cnxk/roc_npc.h | 2

[dpdk-dev] [PATCH] common/cnxk: fix base rule merging only for ingress

2022-01-24 Thread psatheesh
From: Satheesh Paul When creating flow rule, merge base steering rule only for ingress rules. Fixes: f9af9080746 ("common/cnxk: add mcam utility API") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar Kokkilagadda --- drivers/common/cnxk/roc_npc_mcam.c | 2 +- 1 file

[dpdk-dev] [PATCH] common/cnxk: fix log level during MCAM allocation

2022-01-24 Thread psatheesh
From: Satheesh Paul Changed log level from info to debug for a couple of log messages printed during MCAM allocation. Fixes: 1f66919817 ("common/cnxk: improve MCAM entries management") Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar Kokkilagadda --- drivers/common/cnxk/roc_npc_utils.c

[dpdk-dev] [PATCH] common/cnxk: fix missing RTE Flow counter deletion

2022-01-24 Thread psatheesh
From: Satheesh Paul Added code to clear and delete counters upon flow deletion. Fixes: a07f7ced43 ("common/cnxk: add NPC init and fini") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_npc.c | 10 ++ 1 file changed,

[dpdk-dev] [PATCH] common/cnxk: fix missing null check in IPv6 flow parsing

2022-01-24 Thread psatheesh
From: Satheesh Paul Added null check in IPv6 flow pattern parsing. Fixes: a55dc02af5 ("common/cnxk: support extensions attributes in IPv6 item") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_npc_parse.c | 8 +--- 1 fil

RE: [PATCH v2 02/10] ethdev: add flow item/action templates

2022-01-24 Thread Alexander Kozyrev
On Wednesday, January 19, 2022 10:16 Ivan Malov wrote: > > +Oftentimes in an application, many flow rules share a common structure > > +(the same pattern and/or action list) so they can be grouped and > classified > > +together. This knowledge may be used as a source of optimization by a > PMD/HW

RE: [EXT] [PATCH v2 63/83] net/qede: remove unnecessary NULL checks

2022-01-24 Thread Devendra Singh Rawat
> -Original Message- > From: Stephen Hemminger > Sent: Monday, January 24, 2022 11:17 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Rasesh Mody > ; Devendra Singh Rawat > Subject: [EXT] [PATCH v2 63/83] net/qede: remove unnecessary NULL checks > > External Email > > ---

[PATCH] app/dumpcap: allow help/version without primary process

2022-01-24 Thread Ben Magistro
Currently dumpcap tries to initialize dpdk before parsing command line arguments, this makes it impossible to check version or help without having the primary process running already. Signed-off-by: Ben Magistro --- app/dumpcap/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH v1] raw/ifpga/base: fix port feature ID

2022-01-24 Thread Wei Huang
Fix ID value of port features to match the definition from hardware. Fixes: 473c88f9 ("drivers/raw: remove rawdev from directory names") Signed-off-by: Wei Huang --- drivers/raw/ifpga/base/ifpga_defines.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/raw/ifpg

RE: [PATCH 1/6] ethdev: add L2TPv2 RSS offload type

2022-01-24 Thread Wang, Jie1X
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Tuesday, January 25, 2022 12:35 AM > To: Wang, Jie1X ; dev@dpdk.org > Cc: Yang, SteveX ; Singh, Aman Deep > ; Yigit, Ferruh ; NBU- > Contact-Thomas Monjalon (EXTERNAL) ; > andrew.rybche...@oktetlabs.ru; Wu, Jingjing ; Xing, > Beilei ; Z

RE: [PATCH v8] raw/ifpga: fix pthread cannot join

2022-01-24 Thread Xu, Rosen
Hi, > -Original Message- > From: Huang, Wei > Sent: Monday, January 24, 2022 11:50 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > ; step...@networkplumber.org; > david.march...@redhat.com > Subject: [PATCH v8] raw/ifpga: fix pthread

RE: [dpdk-dev] [PATCH v2] net/ice: fix link up when starting the device

2022-01-24 Thread Zhang, Qi Z
> -Original Message- > From: Yunjian Wang > Sent: Monday, January 10, 2022 7:53 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; dingxiaoxi...@huawei.com; > xudin...@huawei.com; Yunjian Wang ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/ice: fix link up when startin

RE: [PATCH] net/ice/base: support E824S and E825 devices

2022-01-24 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, RobinX > Sent: Wednesday, December 29, 2021 5:26 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Guo, Junfeng ; Yang, > SteveX ; Zhang, RobinX > Subject: [PATCH] net/ice/base: support E824S and E825 devices > > Add support for E824S and E

RE: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-24 Thread Alexander Kozyrev
On Monday, January 24, 2022 12:41 Ajit Khaparde wrote: > On Mon, Jan 24, 2022 at 6:37 AM Jerin Jacob > wrote: > > > > On Tue, Jan 18, 2022 at 9:01 PM Alexander Kozyrev > wrote: > > > > > > The flow rules creation/destruction at a large scale incurs a performance > > > penalty and may negatively

[PATCH v2] doc: update matching versions in ice guide

2022-01-24 Thread Qi Zhang
Add recommended matching list for ice PMD in DPDK 21.08 and DPDK 21.11. Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- v2: - cc stable as backport is required. doc/guides/nics/ice.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst ind

RE: [PATCH] doc: update matching versions in ice guide

2022-01-24 Thread Zhang, Qi Z
> -Original Message- > From: David Marchand > Sent: Thursday, January 13, 2022 2:40 PM > To: Zhang, Qi Z > Cc: Yang, Qiming ; Guo, Junfeng > ; Lin, Xueqin ; dev > ; Yigit, Ferruh ; Kevin Traynor > > Subject: Re: [PATCH] doc: update matching versions in ice guide > > On Thu, Jan 13, 20

RE: [PATCH 1/2] net/ice: add module EEPROM ops for ice

2022-01-24 Thread Zhang, Qi Z
> -Original Message- > From: Yang, SteveX > Sent: Thursday, January 20, 2022 11:00 AM > To: dev@dpdk.org > Cc: Zhang, Yuying ; Singh, Aman Deep > ; Yang, Qiming ; > Zhang, Qi Z ; Yang, SteveX > Subject: [PATCH 1/2] net/ice: add module EEPROM ops for ice > > Add new callbacks for eth_d

RE: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-24 Thread Alexander Kozyrev
On Monday, January 24, 2022 13:09 Bruce Richardson wrote: > On Mon, Jan 24, 2022 at 11:16:15PM +0530, Jerin Jacob wrote: > > On Mon, Jan 24, 2022 at 11:05 PM Thomas Monjalon > wrote: > > > > > > 24/01/2022 15:36, Jerin Jacob: > > > > On Tue, Jan 18, 2022 at 9:01 PM Alexander Kozyrev > wrote: >

RE: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-24 Thread Alexander Kozyrev
Sorry, Ivan, missed your email last week since I wasn't in To list. Adding all the people back. On Wednesday, January 19, 2022 8:07 Ivan Malov wrote: > > +Rules management configuration > > +-- > > + > > +Configure flow rules management. > > It is either "managemen

RE: [PATCH] net/ice: fix ieee1588fwd not show PTP timestamp

2022-01-24 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Thursday, January 20, 2022 6:22 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; Wu, Wenjun1 ; Su, Simei > ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix ieee1588fwd not show PTP timestamp Renamed to fix missing mbuf offload

RE: [PATCH v2 54/83] net/igc: remove unnecessary NULL checks

2022-01-24 Thread Wang, Haiyue
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, January 25, 2022 01:47 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Wang, Haiyue > > Subject: [PATCH v2 54/83] net/igc: remove unnecessary NULL checks > > Remove redundant NULL pointer checks before free functions > found b

RE: [PATCH v2 55/83] net/ixgbe: remove unnecessary NULL checks

2022-01-24 Thread Wang, Haiyue
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, January 25, 2022 01:47 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Wang, Haiyue > > Subject: [PATCH v2 55/83] net/ixgbe: remove unnecessary NULL checks > > Remove redundant NULL pointer checks before free functions > found

RE: [PATCH v1] raw/ifpga/base: fix SPI transaction

2022-01-24 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Rosen > Sent: Wednesday, January 19, 2022 6:51 PM > To: Huang, Wei ; dev@dpdk.org; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > > Subject: RE: [PATCH v1] raw/ifpga/base: fix SPI transaction > > Hi, > > > -Original Message

Re: [PATCH v2 03/10] ethdev: bring in async queue-based flow rules

2022-01-24 Thread Ivan Malov
Hi Alexander, This series is very helpful as it draws attention to the problem of making flow API efficient. That said, there is much room for improvement, especially in what comes to keeping things clear and concise. In example, the following APIs - rte_flow_q_flow_create() - rte_flow_q_flow_d

Re: [PATCH v2] eal: fix unaligned loads/stores in rte_memcpy_generic

2022-01-24 Thread Georg Sauthoff
Hello, Stephen Hemminger wrote (Sun, 16 Jan 2022 08:32:20 -0800): > I would propose that DPDK have same kind of define as the kernel > for SAFE_UNALIGNED_ACCESS. The C standard has to apply to all architectures > but DPDK will make the choice to be fast rather than standards conformant. perhaps

[PATCH] pipeline: support checksum for variable size headers

2022-01-24 Thread Cristian Dumitrescu
Added checksum support for variable size headers such as IPv4 headers with options. Signed-off-by: Cristian Dumitrescu Signed-off-by: Yogesh Jangra --- lib/pipeline/rte_swx_pipeline.c | 3 +-- lib/pipeline/rte_swx_pipeline_internal.h | 21 +++-- 2 files changed, 12 ins

RE: [PATCH v2 60/83] net/netvsc: remove unnecessary NULL checks

2022-01-24 Thread Long Li
> Subject: [PATCH v2 60/83] net/netvsc: remove unnecessary NULL checks > > Remove redundant NULL pointer checks before free functions found by > nullfree.cocci > > Signed-off-by: Stephen Hemminger Acked-by: Long Li > --- > drivers/net/netvsc/hn_rxtx.c | 6 ++ > 1 file changed, 2 insertions

RE: [PATCH 59/82] net/netvsc: remove unnecessary NULL checks

2022-01-24 Thread Long Li
> Subject: [PATCH 59/82] net/netvsc: remove unnecessary NULL checks > > Remove redundant NULL pointer checks before free functions found by > nullfree.cocci > > Signed-off-by: Stephen Hemminger Acked-by: Long Li > --- > drivers/net/netvsc/hn_rxtx.c | 6 ++ > 1 file changed, 2 insertions(

Re: [PATCH] build: remove deprecated meson functions

2022-01-24 Thread Jerin Jacob
On Mon, Jan 24, 2022 at 11:20 PM Bruce Richardson wrote: > > Starting in meson 0.56, the functions meson.source_root() and > meson.build_root() are deprecated and to be replaced by the [more > descriptive] functions: project_source_root()/global_source_root() and > project_build_root()/global_buil

RE: [PATCH v2 70/83] raw/dpaa2_qdma: remove unnecessary NULL checks

2022-01-24 Thread Nipun Gupta
Acked-by: Nipun Gupta > -Original Message- > From: Stephen Hemminger > Sent: 24 January 2022 23:17 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Nipun Gupta > > Subject: [PATCH v2 70/83] raw/dpaa2_qdma: remove unnecessary NULL checks > > Remove redundant NULL pointer checks before free

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-24 Thread Bruce Richardson
On Mon, Jan 24, 2022 at 11:16:15PM +0530, Jerin Jacob wrote: > On Mon, Jan 24, 2022 at 11:05 PM Thomas Monjalon wrote: > > > > 24/01/2022 15:36, Jerin Jacob: > > > On Tue, Jan 18, 2022 at 9:01 PM Alexander Kozyrev > > > wrote: > > > > +struct rte_flow_port_attr { > > > > + /** > > > > +

[PATCH] build: remove deprecated meson functions

2022-01-24 Thread Bruce Richardson
Starting in meson 0.56, the functions meson.source_root() and meson.build_root() are deprecated and to be replaced by the [more descriptive] functions: project_source_root()/global_source_root() and project_build_root()/global_build_root(). Unfortunately, these new replacement functions were only a

[PATCH v2 83/83] reorder: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/reorder/rte_reorder.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index 9445853b79cc..bc

[PATCH v2 82/83] power: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/power/rte_power_empty_poll.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/power/rte_power_empty_poll.c b/lib/power/rte_power_empty_poll.c index

[PATCH v2 81/83] port: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/port/rte_port_source_sink.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/lib/port/rte_port_source_sink.c b/lib/port/rte_port_s

[PATCH v2 80/83] ipsec: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/ipsec/ipsec_sad.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ipsec/ipsec_sad.c b/lib/ipsec/ipsec_sad.c index 531e1e323cdc..af4b1ce757d2 10064

[PATCH v2 79/83] graph: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/graph/graph_stats.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c index aa70929dc32e..65e12d46a313

[PATCH v2 78/83] ethdev: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index a1d475a29295..98312fa157f6

[PATCH v2 77/83] compressdev: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/compressdev/rte_compressdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/compressdev/rte_compressdev.c b/lib/compressdev/rte_compressdev.c i

[PATCH v2 76/83] vdpa/mlx5: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/vdpa/mlx5/mlx5_vdpa_mem.c | 3 +-- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_

[PATCH v2 75/83] vdpa/ifc: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/vdpa/ifc/ifcvf_vdpa.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index 3

[PATCH v2 74/83] regex/mlx5: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/regex/mlx5/mlx5_regex.c | 3 +-- drivers/regex/mlx5/mlx5_rxp.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regex/mlx5/mlx5_regex.c

[PATCH v2 73/83] regex/cn9k: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Liron Himi --- drivers/regex/cn9k/cn9k_regexdev.c | 6 ++ drivers/regex/cn9k/cn9k_regexdev_compiler.c | 3 +-- 2 files changed, 3 insertions(+), 6 deleti

[PATCH v2 72/83] raw/skeleton: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/raw/skeleton/skeleton_rawdev_test.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/raw/skeleton/skeleton_r

[PATCH v2 71/83] raw/ifpga: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/ifpga_rawdev.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.

[PATCH v2 70/83] raw/dpaa2_qdma: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa

[PATCH v2 69/83] raw/cnxk_bphy: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c b/drivers/raw/cnxk_bphy/cnxk_

[PATCH v2 68/83] net/virtio: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_user_ethdev.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/

[PATCH v2 67/83] net/vdev_netvsc: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/vdev_netvsc/vdev_netvsc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vde

[PATCH v2 66/83] net/txgbe: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ethdev.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_eth

[PATCH v2 65/83] net/tap: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_flow.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index 7673823945

[PATCH v2 64/83] net/softnic: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/softnic/rte_eth_softnic_cli.c | 12 drivers/net/softnic/rte_eth_softnic_cryptodev.c | 6 ++ drivers/net/softnic/rte_eth_softnic_thread.c

[PATCH v2 63/83] net/qede: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_main.c | 3 +-- drivers/net/qede/qede_rxtx.c | 6 ++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/qede/qede_main.c b/dri

[PATCH v2 62/83] net/octeontx: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 3 +-- drivers/net/octeontx/octeontx_ethdev_ops.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/n

[PATCH v2 61/83] net/null: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/null/rte_eth_null.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index ca

[PATCH v2 60/83] net/netvsc: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 50ca171

[PATCH v2 59/83] net/mvpp2: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_qos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrv

[PATCH v2 58/83] net/mlx5: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/mlx5_flow.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index b7cf4143d5a

[PATCH v2 57/83] net/mlx4: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/mlx4/mlx4_mr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c index 2274b5df1950..e95

[PATCH v2 56/83] net/memif: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/memif/rte_eth_memif.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif

[PATCH v2 55/83] net/ixgbe: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 12 drivers/net/ixgbe/ixgbe_rxtx.c | 3 +-- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/net/ixgbe

[PATCH v2 54/83] net/igc: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/igc/igc_flow.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/igc/igc_flow.c b/drivers/net/igc/igc_flow.c index 66053060af5a..5

[PATCH v2 53/83] net/ice: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ice/ice_fdir_filter.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter

[PATCH v2 52/83] net/iavf: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/iavf/iavf_rxtx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 59623ac8209

[PATCH v2 51/83] net/i40e: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c | 27 +-- drivers/net/i40e/i40e_rxtx.c | 3 +-- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/drive

[PATCH v2 50/83] net/hns3: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hns3/hns3_rxtx.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index d240

[PATCH v2 49/83] net/hinic: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hinic/hinic_pmd_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_e

[PATCH v2 48/83] net/ena: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ena/ena_ethdev.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c

[PATCH v2 47/83] net/dpaa2: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 3 +-- drivers/net/dpaa2/dpaa2_mux.c| 3 +-- drivers/net/dpaa2/dpaa2_ptp.c| 3 +-- 3 files changed, 3 inse

[PATCH v2 46/83] net/dpaa: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 3 +-- drivers/net/dpaa/fmlib/fm_lib.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c

[PATCH v2 45/83] net/cxgbe: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c index f1ac3

[PATCH v2 44/83] net/cnxk: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cnxk/cnxk_ethdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index 7

[PATCH v2 43/83] net/bonding: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_pmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_e

[PATCH v2 42/83] net/bnxt: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index f79f3

[PATCH v2 41/83] net/bnx2x: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x_rxtx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c index 6

[PATCH v2 40/83] net/axgbe: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/axgbe/axgbe_rxtx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c index 6

[PATCH v2 39/83] event/sw: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/event/sw/sw_evdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 6ae613e0f2e7..

[PATCH v2 38/83] crypto/virtio: remove unnecessary NULL checks

2022-01-24 Thread Stephen Hemminger
Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/virtio/virtqueue.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/virtio/virtqueue.c b/drivers/crypto/virtio/virtqueue

  1   2   3   >