Re: 19.11.11 patches review and test

On Fri, Dec 17, 2021 at 8:06 AM Jiang, YuX wrote: > > > -Original Message- > > From: Jiang, YuX > > Sent: Wednesday, December 15, 2021 7:04 PM > > To: Jiang, YuX ; christian.ehrha...@canonical.com; > > sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; > > Akhil Goyal ; Ali Alnubani

[Bug 911] [19.11.11-rc1] linux/igb_uio/igb_uiobuild failure with make and clang 13

https://bugs.dpdk.org/show_bug.cgi?id=911 Christian Ehrhardt (christian.ehrha...@canonical.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

RE: 19.11.11 patches review and test

> -Original Message- > From: Jiang, YuX > Sent: Wednesday, December 15, 2021 7:04 PM > To: Jiang, YuX ; christian.ehrha...@canonical.com; > sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > Walker, Benjamin ; David Christensen > ; Govindharajan, Haripra

[Bug 912] [19.11.11-rc1] net/qede build failure with make and clang 13

https://bugs.dpdk.org/show_bug.cgi?id=912 Bug ID: 912 Summary: [19.11.11-rc1] net/qede build failure with make and clang 13 Product: DPDK Version: 19.11 Hardware: All OS: All Status: UNCONFIRMED

[Bug 911] [19.11.11-rc1] linux/igb_uio/igb_uiobuild failure with make and clang 13

https://bugs.dpdk.org/show_bug.cgi?id=911 Bug ID: 911 Summary: [19.11.11-rc1] linux/igb_uio/igb_uiobuild failure with make and clang 13 Product: DPDK Version: 19.11 Hardware: All OS: All Status:

[PATCH v1] net/i40e: add flow mark capability to NEON vector routine

This commit adds a flow director support to i40e NEON vector RX path. I40e can have 16 and 32 byte descriptors, and the Flow Director ID data and indication-bit are in different locations for each size descriptor. The support is implemented in two separate functions as they require vastly differen

When tap PMD is used, memory loss occurs in secondary block

Hello. Thanks a lot in advance for your help and nice support. We use tap PMD to send exception packet to kernel by DPDK primary block. If the secondary block is driven in this state, vdev probe is performed inside rte_eal_init func and memory is allocated using the rte_zmalloc_socket function if

Re: Using IOAT PMD

On Thu, Dec 16, 2021 at 12:33 PM Bruce Richardson wrote: > > On Thu, Dec 16, 2021 at 11:34:25AM -0500, Lance Richardson wrote: > > On Thu, Dec 16, 2021 at 11:20 AM Bruce Richardson > > wrote: > > > > > > On Thu, Dec 16, 2021 at 11:04:54AM -0500, Lance Richardson wrote: > > > > Hi Bruce, > > > > >

[PATCH] common/mlx5: fix missing validation in devargs parsing

From: Michael Baum The rte_kvargs_parse function parses the arguments "key=value,key=value,..." string and return an allocated structure that contains a key/value list. It enables also to send a key without value and updates the values in the following ways: - "key=value,key,..." - value is upda

[PATCH v2 22/29] crypto/cnxk: support lookaside IPsec AES-CTR

From: Tejasree Kondoj Adding AES-CTR support to cnxk CPT in lookaside IPsec mode. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 2 ++ doc/guides/rel_notes/release_22_03.rst| 1 + drivers/common/cnxk/cnxk_security.c | 6 +

[PATCH v2 29/29] crypto/cnxk: update microcode completion handling

Update microcode completion code handling to update the required mbuf & crypto op flags. IP checksum good case is now reported by specific microcode completion code. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 59 ++- drivers/crypto/cnx

[PATCH v2 28/29] crypto/cnxk: enable copy dscp

Copy DSCP is supported. Enable it in capabilities. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c index f7

[PATCH v2 27/29] crypto/cnxk: add per pkt IV in lookaside IPsec debug mode

From: Archana Muniganti For cn9k, use HW GEN IV as default and add per pkt IV in lookaside IPsec debug mode. Debug mode helps to verify lookaside PMD using known outbound vectors in lookaside autotest. Signed-off-by: Archana Muniganti --- drivers/common/cnxk/roc_ie_on.h | 7

[PATCH v2 26/29] crypto/cnxk: add aes cmac

Add support for AES CMAC auth algorithm. Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/cnxk.rst| 1 + doc/guides/cryptodevs/features/cn10k.ini | 37 +++--- doc/guides/cryptodevs/features/cn9k.ini | 37 +++--- doc/guides/rel_notes/re

[PATCH v2 25/29] crypto/cnxk: add copy and set DF

Add support for copy and set DF bit. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_ipsec.c | 7 ++- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cn9k_ipsec.c b/drivers/cr

[PATCH v2 24/29] crypto/cnxk: add aes xcbc and null cipher

Add support for AES XCBC and NULL cipher. Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/cnxk.rst| 4 + doc/guides/rel_notes/release_22_03.rst| 2 + drivers/common/cnxk/cnxk_security.c | 48 drivers/common/cnxk/roc_ie_on.h

[PATCH v2 23/29] crypto/cnxk: fix extend tail calculation

If the packet size to be incremented after IPsec processing is less than size of hdr (size incremented before submitting), then extend_tail can become negative. Allow negative values for the variable. Fixes: 67a87e89561c ("crypto/cnxk: add cn9k lookaside IPsec datapath") Cc: march...@marvell.com

[PATCH v2 21/29] crypto/cnxk: add more info on command timeout

Print more info when command timeout happens. Print software and hardware queue information. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/hw/cpt.h | 11 drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 1 + drivers/crypto/cnxk/cn9k_cryptod

[PATCH v2 20/29] crypto/cnxk: use atomics to access CPT res

The memory would be updated by hardware. Use atomics to read the same. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/hw/cpt.h | 2 ++ drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 24 drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 28 +++---

[PATCH v2 19/29] crypto/cnxk: fix inflight cnt calculation

Inflight count calculation is updated to cover wrap around cases where head can become smaller than tail. Reported-by: Kiran Kumar K Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/

[PATCH v2 18/29] crypto/cnxk: handle null chained ops

Verification doesn't cover cases when NULL auth/cipher is provided as a chain. Removed the separate function for verification and added a replacement function which calls the appropriate downstream functions. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 189

[PATCH v2 17/29] crypto/cnxk: add context reload for IV

From: Tejasree Kondoj Adding context reload in datapath for IV in debug mode. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 7 --- drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 10 -- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/dr

[PATCH v2 16/29] crypto/cnxk: add skip for unsupported cases

Add skip for transport mode tests that are not supported. Also, updated the transport mode path to configure IP version as v4. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_ipsec.c | 53 +++- 1 file changed, 47 insertions(+), 6 deletions(-) diff --

[PATCH v2 15/29] crypto/cnxk: add security session stats get

From: Ankur Dwivedi Adds the security session stats get op for cn10k. Signed-off-by: Ankur Dwivedi --- drivers/crypto/cnxk/cn10k_ipsec.c | 55 +++ drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + drivers/crypto/cnxk/cnxk_cryptodev_sec.c |

[PATCH v2 14/29] crypto/cnxk: use struct sizes for ctx writes

CTX writes only require the lengths are 8B aligned. Use the struct size directly. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_ipsec.c b/drivers/crypto/cnxk/cn10k_ipse

[PATCH v2 13/29] crypto/cnxk: account for CPT CTX updates and flush delays

CPT CTX write with microcode would require CPT flush to complete to have DRAM updated with the SA. Since datapath requires SA direction field, introduce a new flag for the same. Session destroy path is also updated to clear sa.valid bit using CTX reload operation. Session is updated with marker t

[PATCH v2 12/29] crypto/cnxk: support cnxk lookaside IPsec HMAC-SHA384/512

From: Tejasree Kondoj Adding HMAC-SHA384/512 support to cnxk lookaside IPsec. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 4 ++ doc/guides/rel_notes/release_22_03.rst| 2 + drivers/common/cnxk/cnxk_security.c | 36 +

[PATCH v2 11/29] crypto/cnxk: write CPT CTX through microcode op

From: Tejasree Kondoj Adding support to write CPT CTX through microcode op(SET_CTX) for cn10k lookaside PMD. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_ipsec.c | 121 -- 1 file changed, 89 insertions(+), 32 deletions(-) diff --git a/driver

[PATCH v2 10/29] crypto/cnxk: update max sec crypto caps

Update the macro to include newly added ciphers. Updated the functions populating caps to throw error when max is exceeded. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev.h | 2 +- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 8 ++-- 2 files changed, 7

[PATCH v2 09/29] crypto/cnxk: clear session data before populating

Clear session data before populating fields to not have garbage data. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/cnxk/cn10k_ipsec.c b/drivers/crypto/cnxk/cn10k_ipsec.c index 93eab1b..1bd127e 100644 --- a

[PATCH v2 08/29] crypto/cnxk: add lookaside IPsec AES-CBC-HMAC-SHA256 support

From: Tejasree Kondoj Adding AES-CBC-HMAC-SHA256 support to lookaside IPsec PMD. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 39 +++ doc/guides/rel_notes/release_22_03.rst| 4 +++ drivers/common/cnxk/cnxk_security.c

[PATCH v2 07/29] crypto/cnxk: only enable queues that are allocated

From: Shijith Thotton Only enable/disable queue pairs that are allocated during cryptodev start/stop. Fixes: 6a95dbc1a291 ("crypto/cnxk: add dev start and dev stop") Signed-off-by: Shijith Thotton --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 13 +++-- 1 file changed, 11 insertions(+

[PATCH v2 06/29] common/cnxk: update completion code

Update completion code to match v1.19 microcode release. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_ie_ot.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_ie_ot.h b/drivers/common/cnxk/roc_ie_ot.h index 5b61902..923656f 100644 --- a/d

[PATCH v2 05/29] common/cnxk: verify input args

Add input arg verification. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/hw/cpt.h | 2 ++ drivers/common/cnxk/roc_cpt.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/common/cnxk/hw/cpt.h b/drivers/common/cnxk/hw/cpt.h index 919f842..ccc7af4 100644 --- a/

[PATCH v2 04/29] common/cnxk: fix reset of fields

Copy DF/DSCP fields would get set based on ipsec_xform in the code preceding this. Setting it again would cause the options to be reset. Fixes: 78d03027f2cc ("common/cnxk: add IPsec common code") Cc: scha...@marvell.com Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_security.c | 4 ---

[PATCH v2 03/29] common/cnxk: add bit fields for params

From: Archana Muniganti Added new structure with bit fields for params. Signed-off-by: Archana Muniganti --- drivers/common/cnxk/roc_ie_on.h | 30 +- drivers/crypto/cnxk/cn9k_ipsec.c | 16 +--- 2 files changed, 42 insertions(+), 4 deletions(-) diff --g

[PATCH v2 02/29] common/cnxk: add aes-xcbc key derive

Add support for AES-XCBC key derivation. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_aes.c | 208 drivers/common/cnxk/roc_aes.h | 14 +++ drivers/common/cnxk/roc_api.h | 3 + drivers/common/cnx

[PATCH v2 01/29] common/cnxk: define minor opcodes for MISC opcode

MISC CPT instruction behaves differently based on minor opcode. Define the missing minor opcodes for MISC major opcode. Signed-off-by: Aakash Sasidharan Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_se.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH v2 00/29] New features and improvements in cnxk crypto PMD

New features and fixes to cnxk crypto PMDs - Support for more algorithms in lookaside crypto & protocol - Support for copy & set DF bit - Support for CPT CTX update - Support for security session stats in cn10k Changes in v2 - Support for copy & set DSCP - Support for per packet IV in cn9k - Suppo

Re: Using IOAT PMD

On Thu, Dec 16, 2021 at 11:34:25AM -0500, Lance Richardson wrote: > On Thu, Dec 16, 2021 at 11:20 AM Bruce Richardson > wrote: > > > > On Thu, Dec 16, 2021 at 11:04:54AM -0500, Lance Richardson wrote: > > > Hi Bruce, > > > > > > I've been looking into using the IOAT PMD, initially with dma_autotes

RE: NVIDIA roadmap for 22.03

Added one item below for mlx5 PMD. From: Lior Margalit Sent: Thursday, December 16, 2021 9:22 AM To: dev@dpdk.org Subject: NVIDIA roadmap for 22.03 Please find below NVIDIA roadmap for 22.03 release: rte_flow new APIs: [1] Support for template API (item and action) to optim

Re: Using IOAT PMD

On Thu, Dec 16, 2021 at 11:20 AM Bruce Richardson wrote: > > On Thu, Dec 16, 2021 at 11:04:54AM -0500, Lance Richardson wrote: > > Hi Bruce, > > > > I've been looking into using the IOAT PMD, initially with dma_autotest > > and the dpdk-dma example application. These seem to work fine on > > SKX w

Re: Using IOAT PMD

On Thu, Dec 16, 2021 at 11:04:54AM -0500, Lance Richardson wrote: > Hi Bruce, > > I've been looking into using the IOAT PMD, initially with dma_autotest > and the dpdk-dma example application. These seem to work fine on > SKX with the current main branch, but when I try the same procedure > on ICX

Using IOAT PMD

Hi Bruce, I've been looking into using the IOAT PMD, initially with dma_autotest and the dpdk-dma example application. These seem to work fine on SKX with the current main branch, but when I try the same procedure on ICX (binding all 8 devices to vfio-pci in both cases), I get the following output

[PATCH v1] net/mlx5: adding extern C to rte_pmd_mlx5.h

From: Elena Agostini The support for linking rte_pmd_mlx5.h functions with C++ applications was missing. Signed-off-by: Elena Agostini --- drivers/net/mlx5/rte_pmd_mlx5.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/mlx5/rte_pmd_mlx5.h b/drivers/net/mlx5/rte_pmd_mlx5

[PATCH v2] build/eal: add OS defines for C conditional checks

Define a set of macros in the build configuration to allow C runtime code to check the current OS environment. This saves the user having to use ifdefs for e.g. disabling particular tests on Windows. See included documentation changes for usage examples. Signed-off-by: Bruce Richardson Acked-by:

RE: [RFC] Cryptodev: use rte_crypto_vec, group big-endian constraints

Hi, From: Akhil Goyal Sent: Monday, December 13, 2021 9:36 AM To: Kusztal, ArkadiuszX ; Anoob Joseph ; Zhang, Roy Fan Cc: dev@dpdk.org; Ramkumar Balu Subject: RE: [RFC] Cryptodev: use rte_crypto_vec, group big-endian constraints Hi, since DPDK 21.11 is out, we should start discussion to make

RE: [PATCH 3/3] crypto/ipsec_mb: fix tainted data for session

> -Original Message- > From: Power, Ciara > Sent: Friday, December 10, 2021 2:10 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Mcnamara, John ; Zhang, > Roy Fan ; Power, Ciara ; > Bronowski, PiotrX ; De Lara Guarch, Pablo > > Subject: [PATCH 3/3] crypto/ipsec_mb: fix tainted data for sessi

RE: [PATCH 2/3] crypto/ipsec_mb: fix qp cleanup null pointer dereference

> -Original Message- > From: Power, Ciara > Sent: Friday, December 10, 2021 2:10 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Mcnamara, John ; Zhang, > Roy Fan ; Power, Ciara ; > De Lara Guarch, Pablo > Subject: [PATCH 2/3] crypto/ipsec_mb: fix qp cleanup null pointer > dereference > > T

RE: [PATCH 1/3] crypto/ipsec_mb: fix qp setup null pointer dereference

> -Original Message- > From: Power, Ciara > Sent: Friday, December 10, 2021 2:10 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Mcnamara, John ; Zhang, > Roy Fan ; Power, Ciara ; > De Lara Guarch, Pablo > Subject: [PATCH 1/3] crypto/ipsec_mb: fix qp setup null pointer dereference > > When

[PATCH v1 2/2] examples/l3fwd: add config file support for EM

Add support to define ipv4 and ipv6 forwarding tables from reading from a config file for EM with a format similar to l3fwd-acl one. With the removal of the hardcoded route tables for IPv4 and IPv6 from 'l3fwd_em', these routes have been moved to a separate default config file for use with EM. Re

[PATCH v1 1/2] examples/l3fwd: add config file support for LPM/FIB

Add support to define ipv4 and ipv6 forwarding tables from reading from a config file for LPM and FIB, with format similar to l3fwd-acl one. With the removal of the hardcoded route tables for IPv4 and IPv6, these routes have been moved to a separate default config file for use with LPM and FIB. S

[PATCH v1 0/2] Add config file support for l3fwd

This patchset introduces config file support for l3fwd and its lookup methods LPM, FIB, and EM, similar to that of l3fwd-acl. This allows for route rules to be defined in configuration files and edited there instead of in each of the lookup methods hardcoded route tables. Sean Morrissey (2): exa

[dpdk-kmods v2] linux/igb_uio: fix build for switch fall through

Linux is using '-Wimplicit-fallthrough=5' compiler option, which doesn't take any fall through comments into account but only uses compiler 'fallthrough' attribute to document fall through action is intended. "falls through" comment was used in the code which is causing a build error now, this pat

[PATCH] config: remove explicit undef of unset values

Rather than explicitly clearing any setting of undefined values in our rte_config.h file, it's better to instead just add a comment that the value is not set. Using a comment allows the user to set the value using CFLAGS or similar mechanism without the config file clearing the value again. The te

Re: [PATCH v1] net/iavf: remove the extra symbol '+'

On 12/16/2021 4:43 AM, Haiyue Wang wrote: This extra symbol '+' should be added when patch was reapplied, and the compiler treats it as unsigned type, so the code still runs well. Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message") Cc:sta...@dpdk.org Signed-off-by: H

RE: [PATCH] net/mlx5: fix metadata endianness in modify field action

Hi, Ferruh > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, December 7, 2021 15:45 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; sta...@dpdk.org > Subject: Re: [PATCH] net/mlx5: fix metadata endianness in modify field action > > On 11/29/2021 12:

Re: [dpdk-kmods] linux/igb_uio: fix build for switch fall through

On 12/15/2021 11:15 PM, Stephen Hemminger wrote: On Wed, 15 Dec 2021 21:04:30 + Ferruh Yigit wrote: On 12/15/2021 7:20 PM, Stephen Hemminger wrote: On Wed, 15 Dec 2021 18:48:59 + Ferruh Yigit wrote: Linux is using '-Wimplicit-fallthrough=5' compiler option, which doesn't take an