RE: [PATCH 02/12] net: add function to pretty print IPv4

2021-12-14 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 15 December 2021 04.21 > > On Wed, 15 Dec 2021 01:06:14 + > "Ananyev, Konstantin" wrote: > > > > -Original Message- > > > From: Morten Brørup > > > Sent: Tuesday, December 14, 2021 5:31 PM > > > To: Ran

Re: [PATCH 02/12] net: add function to pretty print IPv4

2021-12-14 Thread Stephen Hemminger
On Wed, 15 Dec 2021 01:06:14 + "Ananyev, Konstantin" wrote: > > -Original Message- > > From: Morten Brørup > > Sent: Tuesday, December 14, 2021 5:31 PM > > To: Randles, Ronan ; dev@dpdk.org > > Cc: Van Haaren, Harry > > Subject: RE: [PATCH 02/12] net: add function to pretty print IP

RE: [PATCH 02/12] net: add function to pretty print IPv4

2021-12-14 Thread Ananyev, Konstantin
> -Original Message- > From: Morten Brørup > Sent: Tuesday, December 14, 2021 5:31 PM > To: Randles, Ronan ; dev@dpdk.org > Cc: Van Haaren, Harry > Subject: RE: [PATCH 02/12] net: add function to pretty print IPv4 > > > From: Ronan Randles [mailto:ronan.rand...@intel.com] > > Sent: Tu

RE: [PATCH 02/12] net: add function to pretty print IPv4

2021-12-14 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 14 December 2021 17.09 > > On Tue, 14 Dec 2021 14:12:32 + > Ronan Randles wrote: > > > This function accepts an uint32_t representation of an IP address and > > produces a string representation stored in a char *

[Bug 909] Build error on CentOS 8.4.2105 with gcc 8.5.0 or clang 11.0

2021-12-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=909 Bug ID: 909 Summary: Build error on CentOS 8.4.2105 with gcc 8.5.0 or clang 11.0 Product: DPDK Version: 21.11 Hardware: x86 OS: Linux Status: UNCONFIRMED

RE: [PATCH 02/12] net: add function to pretty print IPv4

2021-12-14 Thread Morten Brørup
> From: Ronan Randles [mailto:ronan.rand...@intel.com] > Sent: Tuesday, 14 December 2021 15.13 > > This function accepts an uint32_t representation of an IP address and > produces a string representation stored in a char * buffer. Realavent > unit tests also included. > > Signed-off-by: Ronan Ran

RE: [PATCH 01/12] net: add string to IPv4 parse function

2021-12-14 Thread Morten Brørup
> From: Ronan Randles [mailto:ronan.rand...@intel.com] > Sent: Tuesday, 14 December 2021 15.13 > > Added function that accepts ip string as a parameter and returns an ip > address represented by a uint32_t. Relevant unit test for this function > is also included. > > Signed-off-by: Harry van Haar

RE: Call for help - fixes for 19.11.x in regard to new toolchains, kernels ...

2021-12-14 Thread Wang, Haiyue
> -Original Message- > From: Christian Ehrhardt > Sent: Tuesday, December 14, 2021 21:23 > To: Wang, Haiyue > Cc: dev ; aron Conole ; Gujjar, Abhinandan S > ; Ajit Khaparde ; > Akhil Goyal > ; Burakov, Anatoly ; Andrew > Boyer ; > Andrew Rybchenko ; Ankur Dwivedi > ; Anoob Joseph > ; A

RE: [PATCH v2] doc/dlb2: update dlb2 documentation

2021-12-14 Thread McDaniel, Timothy
> -Original Message- > From: Shetty, Rashmi > Sent: Tuesday, December 7, 2021 5:02 PM > To: dev@dpdk.org > Cc: jer...@marvell.com; Van Haaren, Harry ; > Pathak, Pravin ; Chen, Mike Ximing > ; McDaniel, Timothy > ; Shetty, Rashmi > Subject: [PATCH v2] doc/dlb2: update dlb2 documentation >

Re: [PATCH 12/12] examples/generator: line rate limiting

2021-12-14 Thread Stephen Hemminger
On Tue, 14 Dec 2021 14:12:42 + Ronan Randles wrote: > + /* Track time since last token add and calculate number > + * of tokens to give per second to implement line rate limiting > + */ > + uint64_t now = rte_rdtsc(); > + uint64_t

Re: [PATCH 02/12] net: add function to pretty print IPv4

2021-12-14 Thread Stephen Hemminger
On Tue, 14 Dec 2021 14:12:32 + Ronan Randles wrote: > This function accepts an uint32_t representation of an IP address and > produces a string representation stored in a char * buffer. Realavent > unit tests also included. > > Signed-off-by: Ronan Randles Do we really have to reinvent get

RE: [PATCH 00/12] add packet generator library and example app

2021-12-14 Thread Randles, Ronan
I'd be inclined to agree with you on the move to the app dir. The example app could be turned into more of a fully-fledged app than just an example app. I think the final decision on that would fall to @Van Haaren, Harry on that -Original Message- From: Richardson, Bruce Sent: Tuesday,

[PATCH v3] eal: allow to exclude memseg from core dump

2021-12-14 Thread Gaoxiang Liu
Some DPDK application is allocated storage partition of 8G(or smaller) If coredump happens, the application doesn't work because of insufficient storage space. The patch provides a config that means whether the memseg memory is allowed to exclude from core dump. The DPDK application can choose to o

Re: [PATCH 00/12] add packet generator library and example app

2021-12-14 Thread Bruce Richardson
On Tue, Dec 14, 2021 at 02:12:30PM +, Ronan Randles wrote: > This patchset introduces a Gen library for DPDK. This library provides an easy > way to generate traffic in order to test software based network components. > > This library enables the basic functionality required in the traffic >

Re: 19.11.11 patches review and test

2021-12-14 Thread Ferruh Yigit
On 12/14/2021 2:46 PM, Christian Ehrhardt wrote: On Tue, Dec 14, 2021 at 2:58 PM Christian Ehrhardt wrote: On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit wrote: On 12/14/2021 11:39 AM, Christian Ehrhardt wrote: On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit wrote: On 12/14/2021 7:44 AM, Ch

RE: [PATCH] doc/dlb2: update dlb2 documentation

2021-12-14 Thread McDaniel, Timothy
> -Original Message- > From: Shetty, Rashmi > Sent: Monday, December 6, 2021 10:37 AM > To: dev@dpdk.org > Cc: jer...@marvell.com; Van Haaren, Harry ; > Pathak, Pravin ; Chen, Mike Ximing > ; McDaniel, Timothy > ; Shetty, Rashmi > Subject: [PATCH] doc/dlb2: update dlb2 documentation >

Re: 19.11.11 patches review and test

2021-12-14 Thread Christian Ehrhardt
On Tue, Dec 14, 2021 at 2:58 PM Christian Ehrhardt wrote: > > On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit wrote: > > > > On 12/14/2021 11:39 AM, Christian Ehrhardt wrote: > > > On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit > > > wrote: > > >> > > >> On 12/14/2021 7:44 AM, Christian Ehrhardt wr

[PATCH 09/12] examples/generator: enable gen library for traffic gen

2021-12-14 Thread Ronan Randles
This commit shows the steps necessary to enable traffic generation using the gen library Signed-off-by: Ronan Randles --- examples/generator/main.c | 175 ++--- examples/generator/meson.build | 1 + examples/meson.build | 1 + 3 files changed, 120 i

[PATCH 12/12] examples/generator: line rate limiting

2021-12-14 Thread Ronan Randles
This commit introduces line rate limiting using a token passing method. The target traffic rate default is currently hard coded, this can be set using telemetry. Signed-off-by: Ronan Randles --- examples/generator/main.c | 77 +-- 1 file changed, 49 insertions

[PATCH 11/12] examples/generator: link status check added

2021-12-14 Thread Ronan Randles
This commit brings in a link status check so that the generator will only start sending packets once there is something on the other end of the link. Signed-off-by: Ronan Randles --- examples/generator/main.c | 70 +-- 1 file changed, 67 insertions(+), 3 delet

[PATCH 10/12] examples/generator: telemetry support

2021-12-14 Thread Ronan Randles
This commit adds telemetry introducing the callback functions and returning measured values Signed-off-by: Ronan Randles --- examples/generator/main.c | 159 -- 1 file changed, 135 insertions(+), 24 deletions(-) diff --git a/examples/generator/main.c b/exampl

[PATCH 08/12] examples/generator: import code from basicfwd.c

2021-12-14 Thread Ronan Randles
From: Harry van Haaren Import files from basicfwd.c to act as starting point for gen library sample app Signed-off-by: Harry van Haaren Signed-off-by: Ronan Randles --- examples/generator/main.c | 226 + examples/generator/meson.build | 12 ++ 2 files cha

[PATCH 07/12] gen: add gen IP parsing

2021-12-14 Thread Ronan Randles
From: Harry van Haaren This commit adds support for the parsing of "IP(src=...,dst=...)" strings. Parse string API improvement for app RCU. Appropriate unit tests also added. Signed-off-by: Harry van Haaren Signed-off-by: Ronan Randles --- app/test/test_gen.c | 29 +++-- lib/gen/rte_gen.

[PATCH 06/12] gen: add parsing infrastructure and Ether protocol

2021-12-14 Thread Ronan Randles
From: Harry van Haaren This commit adds parsing infrastructure and support for Ether parsing. Appropriate unit tests are also added Signed-off-by: Harry van Haaren --- app/test/test_gen.c | 29 + lib/gen/meson.build | 2 +- lib/gen/rte_gen.c | 281 +

[PATCH 05/12] gen: add raw packet data API and tests

2021-12-14 Thread Ronan Randles
From: Harry van Haaren This commit adds a new API to gen, allowing the caller to set raw packet data with a size. Tests are added to test the new API with randomized packet data. Signed-off-by: Harry van Haaren --- app/test/test_gen.c | 33 lib/gen/rte_gen.c | 62 +++

[PATCH 04/12] gen: add basic Rx and Tx routines and tests

2021-12-14 Thread Ronan Randles
From: Harry van Haaren This commit introduces functions for basic mbuf rx and tx. This commit also contains a unit test that calls rte_gen_rx_burst and rte_gen_tx_burst to send bursts of 32 packets repeatedly in order to verify their functionality Signed-off-by: Harry van Haaren Signed-off-by:

[PATCH 03/12] gen: add files for initial traffic generation library

2021-12-14 Thread Ronan Randles
From: Harry van Haaren This commit adds empty files to the DPDK build for a traffic generation library, including the bare create and destroy functions. Unit testing infrastructure is added for the create function. Signed-off-by: Harry van Haaren --- app/test/meson.build | 2 ++ app/test

[PATCH 02/12] net: add function to pretty print IPv4

2021-12-14 Thread Ronan Randles
This function accepts an uint32_t representation of an IP address and produces a string representation stored in a char * buffer. Realavent unit tests also included. Signed-off-by: Ronan Randles --- app/test/test_net.c | 26 ++ lib/net/rte_ip.c| 15 +++ li

[PATCH 01/12] net: add string to IPv4 parse function

2021-12-14 Thread Ronan Randles
Added function that accepts ip string as a parameter and returns an ip address represented by a uint32_t. Relevant unit test for this function is also included. Signed-off-by: Harry van Haaren Signed-off-by: Ronan Randles --- app/test/meson.build | 2 ++ app/test/test_net.c | 61 +

[PATCH 00/12] add packet generator library and example app

2021-12-14 Thread Ronan Randles
This patchset introduces a Gen library for DPDK. This library provides an easy way to generate traffic in order to test software based network components. This library enables the basic functionality required in the traffic generator. This includes: raw data setting, packet Tx and Rx, creation and

[Bug 908] [19.11] build failure -Werror=stringop-overflow in Ubuntu 21.04

2021-12-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=908 Bug ID: 908 Summary: [19.11] build failure -Werror=stringop-overflow in Ubuntu 21.04 Product: DPDK Version: 19.11 Hardware: x86 OS: Linux Status: UNCONFI

[Bug 907] [19.11] build failure Werror=implicit-fallthrough in opensuse tumbleweed

2021-12-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=907 Bug ID: 907 Summary: [19.11] build failure Werror=implicit-fallthrough in opensuse tumbleweed Product: DPDK Version: 19.11 Hardware: All OS: All Status:

Re: 19.11.11 patches review and test

2021-12-14 Thread Christian Ehrhardt
On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit wrote: > > On 12/14/2021 11:39 AM, Christian Ehrhardt wrote: > > On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit > > wrote: > >> > >> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote: > >>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil > >>> wr

Re: 19.11.11 patches review and test

2021-12-14 Thread Christian Ehrhardt
On Tue, Dec 14, 2021 at 1:08 PM Ferruh Yigit wrote: > > On 12/14/2021 11:39 AM, Christian Ehrhardt wrote: > > On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit > > wrote: > >> > >> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote: > >>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil > >>> wr

Re: 19.11.11 patches review and test

2021-12-14 Thread Christian Ehrhardt
On Tue, Dec 14, 2021 at 2:51 PM Pei Zhang wrote: > Hello Christian, > > The testing with dpdk 19.11.11-rc1 from Red Hat looks good. We tested > below 17 scenarios and all got PASS on RHEL8: > Thank you! > (1)Guest with device assignment(PF) throughput testing(1G hugepage size): > PASS > (2)Gue

Re: 19.11.11 patches review and test

2021-12-14 Thread Pei Zhang
Hello Christian, The testing with dpdk 19.11.11-rc1 from Red Hat looks good. We tested below 17 scenarios and all got PASS on RHEL8: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Gu

Re: Call for help - fixes for 19.11.x in regard to new toolchains, kernels ...

2021-12-14 Thread Christian Ehrhardt
On Tue, Dec 14, 2021 at 1:11 PM Wang, Haiyue wrote: > > Hi Christian, > > > -Original Message- > > From: Christian Ehrhardt > > Sent: Tuesday, December 14, 2021 16:12 > > To: dev > > Cc: aron Conole ; Gujjar, Abhinandan S > > ; Ajit > > Khaparde ; Akhil Goyal ; > > Burakov, Anatoly > >

Re: 19.11.11 patches review and test

2021-12-14 Thread Ferruh Yigit
On 12/14/2021 11:39 AM, Christian Ehrhardt wrote: On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit wrote: On 12/14/2021 7:44 AM, Christian Ehrhardt wrote: On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil wrote: [snip] [Kalesh] Yes, i am seeing the same error. I used make command to bui

Re: [PATCH] mem: exclude used memory from core dump by config

2021-12-14 Thread Gaoxiang Liu
Hi Jerin, I will fix the issues. Thanks. Gaoxiang. 回复的原邮件 | 发件人 | Jerin Jacob | | 日期 | 2021年12月14日 20:08 | | 收件人 | Gaoxiang Liu | | 抄送至 | dpdk-dev、Anatoly Burakov、liugaoxi...@huawei.com、dpdk stable | | 主题 | Re: [PATCH] mem: exclude used memory from core dump by config | On Tue, Dec

RE: Call for help - fixes for 19.11.x in regard to new toolchains, kernels ...

2021-12-14 Thread Wang, Haiyue
Hi Christian, > -Original Message- > From: Christian Ehrhardt > Sent: Tuesday, December 14, 2021 16:12 > To: dev > Cc: aron Conole ; Gujjar, Abhinandan S > ; Ajit > Khaparde ; Akhil Goyal ; > Burakov, Anatoly > ; Andrew Boyer ; Andrew > Rybchenko > ; Ankur Dwivedi ; Anoob > Joseph >

Re: [PATCH] mem: exclude used memory from core dump by config

2021-12-14 Thread Jerin Jacob
On Tue, Dec 14, 2021 at 5:12 PM Gaoxiang Liu wrote: > > Some DPDK application is allolcateed storage partition of 8G(or smaller) allocated > If coredump happens, the application doesn't work because of > insufficient storage space. > The patch provides a config that means whether the huge used m

[PATCH v2] mem: exclude used memory from core dump by config

2021-12-14 Thread Gaoxiang Liu
Some DPDK application is allolcateed storage partition of 8G(or smaller) If coredump happens, the application doesn't work because of insufficient storage space. The patch provides a config that means whether the huge used memory needs to be not dumped in core dump. The DPDK application can choose

Re: 19.11.11 patches review and test

2021-12-14 Thread Ferruh Yigit
On 12/14/2021 11:39 AM, Christian Ehrhardt wrote: On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit wrote: On 12/14/2021 7:44 AM, Christian Ehrhardt wrote: On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil wrote: [snip] [Kalesh] Yes, i am seeing the same error. I used make command to bui

Re: [PATCH] build/eal: add OS defines for C conditional checks

2021-12-14 Thread Bruce Richardson
On Tue, Dec 14, 2021 at 01:58:03AM +0300, Dmitry Kozlyuk wrote: > 2021-12-10 14:53 (UTC+), Bruce Richardson: > [...] > > Acked-by: Dmitry Kozlyuk > with one typo below and some considerations for the future in the bottom. > > > +Defines to Avoid Conditional Compilation > > +~

RE: [PATCH] eventdev: fix missing internal port checks

2021-12-14 Thread Jayatheerthan, Jay
Acked-by: Jay Jayatheerthan > -Original Message- > From: Naga Harish K, S V > Sent: Tuesday, December 14, 2021 4:23 PM > To: Jayatheerthan, Jay ; > pbhagavat...@marvell.com; jer...@marvell.com > Cc: dev@dpdk.org > Subject: RE: [PATCH] eventdev: fix missing internal port checks > > T

[PATCH] mem: exclude used memory from core dump by config

2021-12-14 Thread Gaoxiang Liu
Some DPDK application is allolcateed storage partition of 8G(or smaller) If coredump happens, the application doesn't work because of insufficient storage space. The patch provides a config that means whether the huge used memory needs to be not dumped in core dump. The DPDK application can choose

Re: 19.11.11 patches review and test

2021-12-14 Thread Christian Ehrhardt
On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit wrote: > > On 12/14/2021 7:44 AM, Christian Ehrhardt wrote: > > On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil > > wrote: > > > > [snip] > > > [Kalesh] Yes, i am seeing the same error. I used make command to build > dpdk, not meson.

RE: [PATCH] eventdev: fix missing internal port checks

2021-12-14 Thread Naga Harish K, S V
The patch looks good to me. > -Original Message- > From: Jayatheerthan, Jay > Sent: Tuesday, December 14, 2021 11:23 AM > To: pbhagavat...@marvell.com; jer...@marvell.com; Naga Harish K, S V > > Cc: dev@dpdk.org > Subject: RE: [PATCH] eventdev: fix missing internal port checks > > @Hari

Re: [PATCH] config/cn10k: align mempool elements to 128 bytes

2021-12-14 Thread Kevin Traynor
On 13/12/2021 11:06, pbhagavat...@marvell.com wrote: From: Pavan Nikhilesh Mempool elements are by default aligned to CACHELINE_SIZE. In CN10K cacheline size is 64B but the RoC requires buffers to be aligned to 128B. It would be good to say what the implication is in the commit message. Set

Re: 19.11.11 patches review and test

2021-12-14 Thread Ferruh Yigit
On 12/14/2021 7:44 AM, Christian Ehrhardt wrote: On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil wrote: [snip] [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson. The back ported commit you mentioned takes care of meson build only I think. I see,

RE: [PATCH] config/cn10k: align mempool elements to 128 bytes

2021-12-14 Thread Ruifeng Wang
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, December 13, 2021 7:06 PM > To: jer...@marvell.com; Jan Viktorin ; Ruifeng > Wang ; Bruce Richardson > > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [PATCH] config/cn10k: align mempool elements to 128 bytes > > From:

RE: [dpdk-dev] [PATCH v5 5/5] drivers: remove octeontx2 drivers

2021-12-14 Thread Ruifeng Wang
> -Original Message- > From: jer...@marvell.com > Sent: Saturday, December 11, 2021 5:05 PM > To: dev@dpdk.org; tho...@monjalon.net; Akhil Goyal > ; Declan Doherty ; > jer...@marvell.com; Ruifeng Wang ; Jan Viktorin > ; Bruce Richardson > ; Ray Kinsella ; Ankur > Dwivedi ; Anoob Joseph ; >

RE: Call for help - fixes for 19.11.x in regard to new toolchains, kernels ...

2021-12-14 Thread Jiang, YuX
> -Original Message- > From: Christian Ehrhardt > Sent: Tuesday, December 14, 2021 4:12 PM > To: dev > Cc: aron Conole ; Gujjar, Abhinandan S > ; Ajit Khaparde > ; Akhil Goyal ; > Burakov, Anatoly ; Andrew Boyer > ; Andrew Rybchenko > ; Ankur Dwivedi > ; Anoob Joseph ; Artem V. > Andreev

Re: Call for help - fixes for 19.11.x in regard to new toolchains, kernels ...

2021-12-14 Thread Christian Ehrhardt
On Mon, Jul 19, 2021 at 9:38 AM Christian Ehrhardt wrote: > > Hello everyone and maintainers in particular, > > I wanted to use this chance for an extra call for help before we later > on this year call 19.11 > EOL and done. There have been a bunch of issues found in the 19.11 testing. > > We have

Re: 19.11.11 patches review and test

2021-12-14 Thread Christian Ehrhardt
On Tue, Dec 14, 2021 at 8:45 AM Christian Ehrhardt wrote: > > On Tue, Dec 14, 2021 at 8:14 AM Jiang, YuX wrote: > > > > > -Original Message- > > > From: christian.ehrha...@canonical.com > > > Sent: Thursday, December 9, 2021 10:43 PM > > > To: sta...@dpdk.org > > > Cc: dev@dpdk.org; Abhi