[PATCH] drivers/crypto: no support for SA lifetime

2021-11-17 Thread Gagandeep Singh
dpaa, dpaa2 and caam_jr drivers do not support SA expiry. Signed-off-by: Gagandeep Singh --- drivers/crypto/caam_jr/caam_jr.c| 6 ++ drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 6 ++ drivers/crypto/dpaa_sec/dpaa_sec.c | 6 ++ 3 files changed, 18 insertions(+)

RE: [EXT] [PATCH -v1] bbdev: update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk

2021-11-17 Thread Akhil Goyal
> From: Mingshan Zhang Title is too big. Please run ./devtools/check-git-log.sh. > > update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk Explain the need for this change. We only take critical fixes in the APIs for RC4. Bbdev APIs are not experimental anymore. Please rebase on TOT

RE: [EXT] [PATCH] drivers/crypto: fix ipsec inner ip header ttl decrement option

2021-11-17 Thread Akhil Goyal
> dpaa, dpaa2 and caam_jr drivers decrement the inner IP header > TTL for all packets and ignoring the dec_ttl option of SA. > > In this patch, using the dec_ttl to decide to decrement the > packets inner IP header TTL or not. > > Fixes: 0a23d4b6f4c2 ("crypto/dpaa2_sec: support protocol offload I

[PATCH] drivers/crypto: fix ipsec inner ip header ttl decrement option

2021-11-17 Thread Gagandeep Singh
dpaa, dpaa2 and caam_jr drivers decrement the inner IP header TTL for all packets and ignoring the dec_ttl option of SA. In this patch, using the dec_ttl to decide to decrement the packets inner IP header TTL or not. Fixes: 0a23d4b6f4c2 ("crypto/dpaa2_sec: support protocol offload IPsec") Fixes:

Re: [PATCH v1 1/1] app/test-gpudev: introduce ethdev to rx/tx packets using GPU memory

2021-11-17 Thread Jerin Jacob
On Thu, Nov 18, 2021 at 12:28 AM wrote: > > From: Elena Agostini > > This patch introduces ethdev in test-gpudev app to provide: > - an example to show how GPU memory can be used to send and receive packets > - an useful tool to measure network metrics when using GPU memory with > io forwarding >

RE: query regarding IPsec inner IP header TTL

2021-11-17 Thread Gagandeep Singh
Thanks Anoob. > -Original Message- > From: Anoob Joseph > Sent: Thursday, November 18, 2021 11:15 AM > To: Gagandeep Singh > Cc: Akhil Goyal ; dev@dpdk.org > Subject: RE: query regarding IPsec inner IP header TTL > > Hi Gagandeep, > > There is an option(dec_ttl) in 'struct rte_security

RE: query regarding IPsec inner IP header TTL

2021-11-17 Thread Anoob Joseph
Hi Gagandeep, There is an option(dec_ttl) in 'struct rte_security_ipsec_sa_options' to control this. Wouldn't that work? http://code.dpdk.org/dpdk/latest/source/lib/security/rte_security.h#L166 Thanks, Anoob From: Gagandeep Singh Sent: Thursday, November 18, 2021 9:41 AM To: Akhil Goyal ; de

Re: [PATCH] net/bnxt: fix autoneg on PAM4 links

2021-11-17 Thread Ajit Khaparde
On Wed, Nov 17, 2021 at 8:11 PM Somnath Kotur wrote: > > If autonegotiation was enabled, driver was not passing the > 'auto_pam4_link_speeds' obtained during init and stored in bp->link_info > to bnxt_hwrm_port_phy_cfg(). This would result in an incorrect setting > being passed to the HW during PH

[PATCH] net/bnxt: fix autoneg on PAM4 links

2021-11-17 Thread Somnath Kotur
If autonegotiation was enabled, driver was not passing the 'auto_pam4_link_speeds' obtained during init and stored in bp->link_info to bnxt_hwrm_port_phy_cfg(). This would result in an incorrect setting being passed to the HW during PHY configuration. This in turn, would result in invalid settings

query regarding IPsec inner IP header TTL

2021-11-17 Thread Gagandeep Singh
Hi, Is there any option available in IPsec mode to decrement the inner IP header TTL field by security engine? I believe in case of forwarding, inner IP header TTL should be decrement but not in case of packet termination. So looking for an option that application can pass to driver to perform

Re: release schedule change proposal

2021-11-17 Thread Ajit Khaparde
On Mon, Nov 15, 2021 at 6:58 AM Thomas Monjalon wrote: > > For the last 5 years, DPDK was doing 4 releases per year, > in February, May, August and November (the LTS one): > .02 .05 .08 .11 (LTS) > > This schedule has multiple issues: > - clash with China's Spring Festival >

Re: [dpdk-dev] [PATCH V1 2/2] examples/ethtool: support the query of MTU

2021-11-17 Thread lihuisong (C)
在 2021/11/18 1:51, David Marchand 写道: On Thu, Apr 29, 2021 at 12:53 PM Min Hu (Connor) wrote: From: Huisong Li This patch supports the query of MTU. Signed-off-by: Huisong Li --- examples/ethtool/ethtool-app/ethapp.c | 48 +-- examples/ethtool/lib/rte_et

Re: [dpdk-dev] [PATCH V1 1/2] examples/ethtool: fix data type of MTU

2021-11-17 Thread lihuisong (C)
在 2021/11/18 1:49, David Marchand 写道: On Thu, Apr 29, 2021 at 12:53 PM Min Hu (Connor) wrote: From: Huisong Li This patch changes the data type of 'mtu' in rte_ethtool_net_change_mtu() from 'int' to 'uint16_t'. You did not describe why this change is needed. Ensure that the input paramet

Re: ethdev: hide internal structures

2021-11-17 Thread Tyler Retzlaff
On Tue, Nov 16, 2021 at 03:22:01PM -0800, Stephen Hemminger wrote: > On Tue, 16 Nov 2021 14:58:08 -0800 > Tyler Retzlaff wrote: > > > > > > > Keep a array in application? Portid is universally > > > available. > > > > > > struct my_portdata *my_ports[RTE_ETH_MAXPORTS]; > > > > i guess by th

Re: [dpdk-dev] [dpdk-announce] release candidate 21.11-rc2

2021-11-17 Thread Thinh Tran
Hi IBM - Power Systems DPDK v21.11-rc2-101-g329f73eb35 * Basic PF on Mellanox: No new issues or regressions were seen. * Performance: not tested. Systems tested: - IBM Power9 PowerNV 9006-22P OS: RHEL 8.4 GCC: version 8.3.1 20191121 (Red Hat 8.3.1-5) NICs: - Mellanox Technolog

release candidate 21.11-rc3

2021-11-17 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v21.11-rc3 There are 178 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_21_11.html Highlights of 21.11-rc3: - NXP DPAA DMA driver - NXP

[Bug 887] mlx5: cannot probe ConnectX-6 Dx if socket-limit is too small on NUMA socket 0

2021-11-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=887 Bug ID: 887 Summary: mlx5: cannot probe ConnectX-6 Dx if socket-limit is too small on NUMA socket 0 Product: DPDK Version: 21.08 Hardware: x86 OS: Linux

Re: [dpdk-dev] [PATCH v1 1/6] build: increase default of max lcores to 512

2021-11-17 Thread David Hunt
On 17/11/2021 3:55 PM, Morten Brørup wrote: My microphone was not working during the Techboard meeting, so here goes instead: Please consider if the default of max 128 assigned lcores suffices for the expected lifetime of the 21.11 LTS, or if the default should be bumped to 512 as suggested

Re: [PATCH v3] net: add macro for VLAN header length

2021-11-17 Thread Thomas Monjalon
17/11/2021 19:24, Ferruh Yigit: > Multiple drivers are defining macros for VLAN header length, to remove > the redundancy defining macro in the ether header. > And updated drivers to use the new macro. > > Signed-off-by: Ferruh Yigit > Acked-by: Haiyue Wang > Acked-by: Rosen Xu > Acked-by: Jiaw

[PATCH] common/mlx5: fix mempool registration

2021-11-17 Thread Dmitry Kozlyuk
Mempool registration was not correctly processing mempools with RTE_PKTMBUF_F_PINEND_EXT_BUF flag set ("pinned mempools" for short), because it is not known at registration time whether the mempool is a pktmbuf one, and its elements may not yet be initialized to analyze them. Attempts had been made

[PATCH v3] net: add macro for VLAN header length

2021-11-17 Thread Ferruh Yigit
Multiple drivers are defining macros for VLAN header length, to remove the redundancy defining macro in the ether header. And updated drivers to use the new macro. Signed-off-by: Ferruh Yigit Acked-by: Haiyue Wang Acked-by: Rosen Xu Acked-by: Jiawen Wu --- v2: * update new enetfec driver too

[PATCH v2] net: add macro for VLAN header length

2021-11-17 Thread Ferruh Yigit
Multiple drivers are defining macros for VLAN header length, to remove the redundancy defining macro in the ether header. And updated drivers to use the new macro. Signed-off-by: Ferruh Yigit Acked-by: Haiyue Wang Acked-by: Rosen Xu Acked-by: Jiawen Wu --- v2: * update new enetfec driver too

Re: [dpdk-dev] [PATCH V1 2/2] examples/ethtool: support the query of MTU

2021-11-17 Thread David Marchand
On Thu, Apr 29, 2021 at 12:53 PM Min Hu (Connor) wrote: > > From: Huisong Li > > This patch supports the query of MTU. > > Signed-off-by: Huisong Li > --- > examples/ethtool/ethtool-app/ethapp.c | 48 > +-- > examples/ethtool/lib/rte_ethtool.c| 7 + > e

Re: [dpdk-dev] [PATCH V1 1/2] examples/ethtool: fix data type of MTU

2021-11-17 Thread David Marchand
On Thu, Apr 29, 2021 at 12:53 PM Min Hu (Connor) wrote: > > From: Huisong Li > > This patch changes the data type of 'mtu' in rte_ethtool_net_change_mtu() > from 'int' to 'uint16_t'. You did not describe why this change is needed. > > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space etht

Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Elena Agostini
> > On Wed, Nov 17, 2021 at 7:20 PM Elena Agostini wrote: > > > > > > > On Wed, Nov 17, 2021 at 6:09 PM Elena Agostini > > > > wrote: > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > O

[PATCH v1 1/1] app/test-gpudev: introduce ethdev to rx/tx packets using GPU memory

2021-11-17 Thread eagostini
From: Elena Agostini This patch introduces ethdev in test-gpudev app to provide: - an example to show how GPU memory can be used to send and receive packets - an useful tool to measure network metrics when using GPU memory with io forwarding With this feature test-gpudev can: - RX packets in CPU

[PATCH v1 0/1] app/test-gpudev: introduce ethdev to rx/tx packets using GPU memory

2021-11-17 Thread eagostini
From: Elena Agostini This patch introduces ethdev in test-gpudev app to provide: - an example to show how GPU memory can be used to send and receive packets - an useful tool to measure network metrics when using GPU memory with io forwarding With this feature test-gpudev can: - RX packets in CPU

Re: [PATCH v2] hash: clarify comments for RTE_HASH_BUCKET_ENTRIES

2021-11-17 Thread Thomas Monjalon
> > This patch adds a comment for RTE_HASH_BUCKET_ENTRIES explaining why a > > particular value was chosen. > > > > Signed-off-by: Vladimir Medvedkin > Looks good > Reviewed-by: Honnappa Nagarahalli Applied, thanks.

Re: [PATCH] ci: add Fedora 35 container in GHA

2021-11-17 Thread David Marchand
On Tue, Nov 16, 2021 at 3:44 PM Aaron Conole wrote: > > Build DPDK with Fedora 35 containers. > > Differences with the Ubuntu GHA vm images: > > - tasks are run as root in containers, no need for sudo, > > - compiler must be explicitly installed: clang is not in container images, > > - GHA artifac

Re: [PATCH v2] build: make gpudev optional

2021-11-17 Thread Thomas Monjalon
17/11/2021 22:39, eagost...@nvidia.com: > From: Elena Agostini > > This library can be made optional. > drivers/gpu and app/test-gpudev depend on this library, > so there is a check for dependencies. Changed to so they are automatically disabled if the lib is disabled. > Signed-off-by: Elena Ag

Re: [dpdk-dev] [PATCH v2 2/2] examples/ethtool: add closing port operation

2021-11-17 Thread David Marchand
On Thu, May 6, 2021 at 5:46 AM Min Hu (Connor) wrote: > > From: Huisong Li > > Currently, ethtool directly ends the process after 'quit' cmd. In this > case, software resources are not released and hardware resources of the > device are not uninstalled. > > This patch adds closing port operation

[PATCH v2] app/test-gpudev: remove memory leaks in case of errors

2021-11-17 Thread eagostini
From: Elena Agostini Signed-off-by: Elena Agostini --- app/test-gpudev/main.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/app/test-gpudev/main.c b/app/test-gpudev/main.c index c647e30de4..250fba6427 100644 --- a/app/test-gpudev/main.c +++ b/app/test-gpudev/

Re: [PATCH] kni: restrict bifurcated device support

2021-11-17 Thread Igor Ryzhov
Acked-by: Igor Ryzhov On Sat, Oct 9, 2021 at 2:58 AM Ferruh Yigit wrote: > To enable bifurcated device support, rtnl_lock is released before calling > userspace callbacks and asynchronous requests are enabled. > > But these changes caused more issues, like bug #809, #816. To reduce the > scope

Re: [PATCH v1] app/test-gpudev: remove memory leaks in case of errors

2021-11-17 Thread David Marchand
On Wed, Nov 17, 2021 at 1:34 PM wrote: Commitlog. + Fixes: tag. > > From: Elena Agostini > > Signed-off-by: Elena Agostini > --- > app/test-gpudev/main.c | 41 - > 1 file changed, 28 insertions(+), 13 deletions(-) > > diff --git a/app/test-gpudev/main.

[Bug 886] mlx5 packet does not match rte_flow VXLAN if destination port is non-standard

2021-11-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=886 Bug ID: 886 Summary: mlx5 packet does not match rte_flow VXLAN if destination port is non-standard Product: DPDK Version: 21.08 Hardware: x86 OS: Linux S

RE: [dpdk-dev] [PATCH v1 1/6] build: increase default of max lcores to 512

2021-11-17 Thread Morten Brørup
My microphone was not working during the Techboard meeting, so here goes instead: Please consider if the default of max 128 assigned lcores suffices for the expected lifetime of the 21.11 LTS, or if the default should be bumped to 512 as suggested. @David Hunt, do you have idea about the memor

[PATCH] net/mlx5: fix refcount on detached indirect action

2021-11-17 Thread Dariusz Sosnowski
This patch fixes segfault which was triggered when port, with indirect actions created, was closed. Segfault was occurring only when RTE_LIBRTE_MLX5_DEBUG was defined. It was caused by redundant decrement of RX queues refcount: - refcount was decremented when port was stopped and indirect actions

[PATCH -v1] bbdev: update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk

2021-11-17 Thread Zhang, Mingshan
From: Mingshan Zhang update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk   Signed-off-by: Mingshan Zhang --- doc/guides/prog_guide/bbdev.rst | 4 ++-- lib/bbdev/rte_bbdev_op.h| 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/prog_guide/bbd

[PATCH -v1] Update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk

2021-11-17 Thread Zhang, Mingshan
From: "Zhang, Mingshan" Update num_ops type from uint16_t to uint32_t in rte_bbdev_enc_op_alloc_bulk to enlarge the input range. Mingshan Zhang (1): bbdev: update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk doc/guides/prog_guide/bbdev.rst | 4 ++-- lib/bbdev/rte_bbdev_op.

Re: [dpdk-dev] [ovs-dev] ovs-vswitchd with DPDK crashed when guest VM restarts network service

2021-11-17 Thread Bendror, Eran (Nokia - US)
Hello, I am wondering if there was any progress in this topic, we are seeing a very similar issue, where a VM level application restart triggers segmentation fault and failed to allocate MBuf on the host level CentOS Linux release 7.8.2003 (Core) dpdk-18.11.5-1.el7_8.x86_64 openvswitch-2.11.0-4

Re: [PATCH] common/mlx5: decrease log level for hlist creation

2021-11-17 Thread David Marchand
On Wed, Nov 17, 2021 at 2:28 PM Slava Ovsiienko wrote: > > I've re-checked the mlx5_hlist_create() call tree. > > And it seems all the calls are done with hardcoded const values for "size" > argument, > and all these values are powers-of-2. > > We had an issue in the past, but then I was not see

RE: [PATCH] net/mlx5: fix modify field destination bit offset

2021-11-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, November 17, 2021 1:15 PM > To: dev@dpdk.org > Cc: ferruh.yi...@intel.com; Raslan Darawsheh ; Matan > Azrad > Subject: [PATCH] net/mlx5: fix modify field destination bit offset > > If the modify field action requests th

RE: [PATCH] common/mlx5: fix memory leak in Windows dereg MR function

2021-11-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Wednesday, November 17, 2021 1:03 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; Michael > Baum ; sta...@dpdk.org > Subject: [PATCH] common/mlx5: fix memory leak in Windows dereg MR > function > > Fro

RE: [PATCH] common/mlx5: fix user mode register access attribute

2021-11-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Wednesday, November 17, 2021 12:57 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; Michael > Baum ; sta...@dpdk.org > Subject: [PATCH] common/mlx5: fix user mode register access attribute > > From: Mic

RE: [PATCH v4] vhost: fix physical address mapping

2021-11-17 Thread Ding, Xuan
Hi Maxime, >-Original Message- >From: Ding, Xuan >Sent: Tuesday, November 16, 2021 4:24 PM >To: Xia, Chenbo ; maxime.coque...@redhat.com >Cc: dev@dpdk.org; Hu, Jiayu ; Wang, YuanX >; He, Xingguang >Subject: RE: [PATCH v4] vhost: fix physical address mapping > >Hi Chenbo, > >> -Origin

Re: [PATCH v2] build: make gpudev optional

2021-11-17 Thread Bruce Richardson
On Wed, Nov 17, 2021 at 09:39:01PM +, eagost...@nvidia.com wrote: > From: Elena Agostini > > This library can be made optional. > drivers/gpu and app/test-gpudev depend on this library, > so there is a check for dependencies. > > Signed-off-by: Elena Agostini > --- > app/test-gpudev/meson.

Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Elena Agostini
> On Wed, Nov 17, 2021 at 7:20 PM Elena Agostini wrote: > > > > > On Wed, Nov 17, 2021 at 6:09 PM Elena Agostini > > > wrote: > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > On Wed, 17 Nov 2021 03:04:59 + > > >

Re: [PATCH v4 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Bruce Richardson
On Wed, Nov 17, 2021 at 09:49:23PM +, eagost...@nvidia.com wrote: > From: Elena Agostini > > This patch introduces GPU memory in testpmd through the gpudev library. > Testpmd can be used for network benchmarks when using GPU memory > instead of regular CPU memory to send and receive packets.

RE: [PATCH v2] net/mlx5: fix NULL err msg in mlx5_flow_tunnel_validate

2021-11-17 Thread Slava Ovsiienko
Hi, Wenxu I'm sorry, we unintentionally provided the very similar fix there: http://patches.dpdk.org/project/dpdk/patch/20211103085556.25214-1-getel...@nvidia.com/ It’s my personal mistake - I did not recall about your patch while reviewing ours ☹ My sincere apologizes, I'm sorry indeed. With b

Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Jerin Jacob
te On Wed, Nov 17, 2021 at 7:20 PM Elena Agostini wrote: > > > On Wed, Nov 17, 2021 at 6:09 PM Elena Agostini wrote: > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > On Wed, 17 Nov 2021 03:04:59 + > > > > > > > > > > >> > > > > > > > > > > >>>

Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Elena Agostini
> On Wed, Nov 17, 2021 at 6:09 PM Elena Agostini wrote: > > > > > > >> > > > > > > > > > > > > >> > > > > > > > On Wed, 17 Nov 2021 03:04:59 + > > > > > > >> > > > > > > > > > > > > >> This patch introduces GPU memory in testpmd through the gpudev > > > > >> library. > >

Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Jerin Jacob
On Wed, Nov 17, 2021 at 6:09 PM Elena Agostini wrote: > > > > >> > > > > > > > > >> > > > > > On Wed, 17 Nov 2021 03:04:59 + > > > > >> > > > > > > > > >> This patch introduces GPU memory in testpmd through the gpudev > > > >> library. > > > > >> > > > > > > > > >>

[PATCH v4 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread eagostini
From: Elena Agostini This patch introduces GPU memory in testpmd through the gpudev library. Testpmd can be used for network benchmarks when using GPU memory instead of regular CPU memory to send and receive packets. This option is currently limited to iofwd engine to ensure no workload is applie

[PATCH v4 0/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread eagostini
From: Elena Agostini This patch introduces GPU memory in testpmd through the gpudev library. Testpmd can be used for network benchmarks when using GPU memory instead of regular CPU memory to send and receive packets. This option is currently limited to iofwd engine to ensure no workload is applie

Re: [PATCH v2 1/5] ci: test minimum configuration

2021-11-17 Thread Aaron Conole
David Marchand writes: > Disabling drivers and optional libraries was not tested. > Add a new target in test-meson-builds.sh and GHA with just the minimum > to run test-null.sh and any other optional component disabled. > > Signed-off-by: David Marchand > --- > Changes since v1: > - dropped targ

Re: [PATCH] doc: add explanation when feature "=P" for ice

2021-11-17 Thread Ferruh Yigit
On 11/14/2021 3:40 AM, Qi Zhang wrote: Users are confused with a feature with "P", added necessary explanation for this. Signed-off-by: Qi Zhang Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

[PATCH v2] build: make gpudev optional

2021-11-17 Thread eagostini
From: Elena Agostini This library can be made optional. drivers/gpu and app/test-gpudev depend on this library, so there is a check for dependencies. Signed-off-by: Elena Agostini --- app/test-gpudev/meson.build | 1 + doc/guides/prog_guide/gpudev.rst | 1 + drivers/gpu/meson.build

RE: [PATCH] common/mlx5: decrease log level for hlist creation

2021-11-17 Thread Slava Ovsiienko
Hi, David I've re-checked the mlx5_hlist_create() call tree. And it seems all the calls are done with hardcoded const values for "size" argument, and all these values are powers-of-2. We had an issue in the past, but then I was not seeing this warning for a long time on my setup. With best

Re: [PATCH 0/4] net/sfc: support MAC address edits in transfer flows

2021-11-17 Thread Ferruh Yigit
On 11/17/2021 11:44 AM, Ivan Malov wrote: Ivan Malov (4): net/sfc: refine the order of checks on MAE action set attach net/sfc: organise MAE flow action parsing function arguments common/sfc_efx/base: support MAC address edit actions in MAE net/sfc: support MAC address edits in transf

Re: [PATCH] common/mlx5: decrease log level for hlist creation

2021-11-17 Thread David Marchand
On Wed, Nov 17, 2021 at 1:14 PM Slava Ovsiienko wrote: > > Hi, David > > In general, I'm OK with lowering the log level. > But we do not expect the warning " is not power of 2". > What mlx5_hlist_create() call caused this? That's something Maxime can see on RHEL8 with CX6 devices. I remember seei

Re: [PATCH v1] build: make gpudev optional

2021-11-17 Thread Thomas Monjalon
17/11/2021 13:36, Thomas Monjalon: > 17/11/2021 21:33, eagost...@nvidia.com: > > --- a/app/test-gpudev/meson.build > > +++ b/app/test-gpudev/meson.build > > @@ -1,5 +1,12 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright (c) 2021 NVIDIA Corporation & Affiliates > > > > -sources = f

Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Elena Agostini
> > >> > > > > >> > > > On Wed, 17 Nov 2021 03:04:59 + > > >> > > > > >> This patch introduces GPU memory in testpmd through the gpudev > > >> library. > > >> > > > > >> > > >> Testpmd can be used for network benchmarks when using GPU memory > > >> > > > > >

Re: [PATCH v1] build: make gpudev optional

2021-11-17 Thread Thomas Monjalon
17/11/2021 21:33, eagost...@nvidia.com: > --- a/app/test-gpudev/meson.build > +++ b/app/test-gpudev/meson.build > @@ -1,5 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright (c) 2021 NVIDIA Corporation & Affiliates > > -sources = files('main.c') > -deps = ['gpudev', 'ethdev'] > +if

RE: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Ananyev, Konstantin
> >> > > >> > > On Wed, 17 Nov 2021 03:04:59 + > >> > > >> This patch introduces GPU memory in testpmd through the gpudev library. > >> > > >> > >> Testpmd can be used for network benchmarks when using GPU memory > >> > > >> > >> instead of regular CPU memor

[PATCH v1] app/test-gpudev: remove memory leaks in case of errors

2021-11-17 Thread eagostini
From: Elena Agostini Signed-off-by: Elena Agostini --- app/test-gpudev/main.c | 41 - 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/app/test-gpudev/main.c b/app/test-gpudev/main.c index c647e30de4..fe5c1e5b15 100644 --- a/app/test-gpudev

Re: [PATCH] app/testpmd: fix tunnel offload validation

2021-11-17 Thread Ferruh Yigit
On 11/17/2021 10:27 AM, Slava Ovsiienko wrote: -Original Message- From: Ferruh Yigit Sent: Wednesday, November 17, 2021 12:10 To: Gregory Etelson ; dev@dpdk.org; Ori Kam ; Slava Ovsiienko Cc: Matan Azrad ; Raslan Darawsheh ; NBU-Contact-Thomas Monjalon Subject: Re: [PATCH] app/testpmd:

[PATCH v1] build: make gpudev optional

2021-11-17 Thread eagostini
From: Elena Agostini This library can be made optional. drivers/gpu and app/test-gpudev depend on this library, so there is a check for dependencies. Signed-off-by: Elena Agostini --- app/test-gpudev/meson.build | 11 +-- doc/guides/prog_guide/gpudev.rst | 1 + drivers/gpu/meson.

RE: [PATCH] common/mlx5: decrease log level for hlist creation

2021-11-17 Thread Slava Ovsiienko
Hi, David In general, I'm OK with lowering the log level. But we do not expect the warning " is not power of 2". What mlx5_hlist_create() call caused this? > -Original Message- > From: David Marchand > Sent: Tuesday, November 16, 2021 22:34 > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Mo

Re: [PATCH] failsafe: Bug fix for the secondary process RX-TX support

2021-11-17 Thread Ferruh Yigit
On 11/11/2021 12:44 PM, Kumara Parameshwaran wrote: Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This check was removed for other vdevs but was missed for failsafe. Fixes: 4852

Re: [dpdk-dev] [RFC PATCH] ethdev: mtr: enhance input color table features

2021-11-17 Thread Jerin Jacob
On Mon, Oct 11, 2021 at 8:53 PM Dumitrescu, Cristian wrote: > > Hi Jerin, Hi Cristian, > > > -Original Message- > > From: jer...@marvell.com > > Sent: Friday, August 20, 2021 9:24 AM > > To: Dumitrescu, Cristian ; Thomas Monjalon > > ; Yigit, Ferruh ; Andrew > > Rybchenko > > Cc: dev@

RE: [PATCH] net/mlx5: fix MPLS tunnel outer layer overwrite

2021-11-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, November 17, 2021 12:00 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix MPLS tunnel outer layer overwrite > > mlx5 PMD incorrectly overwrote outer layer fi

RE: [PATCH] net/mlx5: fix partial inline of fine grain packets

2021-11-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, November 17, 2021 11:51 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix partial inline of fine grain packets > > Assuming a user tried to send multi-segmen

Re: [PATCH v2 0/5] Extend optional libraries list

2021-11-17 Thread Thomas Monjalon
17/11/2021 12:28, David Marchand: > This series extends the optional libraries list adding to them testpmd > non essential dependencies. > > We were not testing the disable_libs option, so let's add a minimum target > in the the public CI script (mainly for GHA) and in test-meson-builds.sh > scrip

Re: [PATCH v2 1/5] ci: test minimum configuration

2021-11-17 Thread Thomas Monjalon
17/11/2021 12:28, David Marchand: > Disabling drivers and optional libraries was not tested. > Add a new target in test-meson-builds.sh and GHA with just the minimum > to run test-null.sh and any other optional component disabled. > > Signed-off-by: David Marchand > --- > Changes since v1: > - dr

Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Ferruh Yigit
On 11/17/2021 11:31 AM, Jerin Jacob wrote: On Wed, Nov 17, 2021 at 4:56 PM Elena Agostini wrote: On Wed, Nov 17, 2021 at 4:38 PM Elena Agostini wrote: External email: Use caution opening links or attachments On Wed, 17 Nov 2021 03:04:59 + wrote:

Re: [PATCH v2 0/2] net/sfc: support SN1022 SoC

2021-11-17 Thread Ferruh Yigit
On 11/17/2021 7:05 AM, Andrew Rybchenko wrote: I apologize for very late patch series. Of course, I'd be happy if the series is included in 21.11 since it is a final step to support SN1022 SoC. Now it is really late. A tiny excuse is that net/sfc part was 90% rewritten to use [1]. Many thanks to

[PATCH 4/4] net/sfc: support MAC address edits in transfer flows

2021-11-17 Thread Ivan Malov
These edits affect the outermost header in the current processing state of the packet, which might have been decapsulated by prior action DECAP. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/features/sfc.ini | 2 + doc/guides/nics/sfc_e

[PATCH 3/4] common/sfc_efx/base: support MAC address edit actions in MAE

2021-11-17 Thread Ivan Malov
In a tunnel packet, these actions affect the inner header if action DECAP is set; otherwise, they affect the outer header. Adding these actions is done in two steps: add the action to the action mask and indicate the MAC address entry ID to use. This allows the user to check the order of actions f

[PATCH 2/4] net/sfc: organise MAE flow action parsing function arguments

2021-11-17 Thread Ivan Malov
Add a context structure to simplify handling of action sets. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mae.c | 103 +++--- 1 file changed, 52 insertions(+), 51 deletions(-) diff --git a/drivers/net

[PATCH 1/4] net/sfc: refine the order of checks on MAE action set attach

2021-11-17 Thread Ivan Malov
The number of counters being non-zero can be detected before the action set registry traversal, so move the check outside. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mae.c | 12 +++- 1 file changed, 7 insertions(+), 5 delet

[PATCH 0/4] net/sfc: support MAC address edits in transfer flows

2021-11-17 Thread Ivan Malov
Ivan Malov (4): net/sfc: refine the order of checks on MAE action set attach net/sfc: organise MAE flow action parsing function arguments common/sfc_efx/base: support MAC address edit actions in MAE net/sfc: support MAC address edits in transfer flows doc/guides/nics/features/sfc.ini

Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Jerin Jacob
On Wed, Nov 17, 2021 at 4:56 PM Elena Agostini wrote: > > > On Wed, Nov 17, 2021 at 4:38 PM Elena Agostini wrote: > > > > > > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, 17 Nov 2021 03:04:59 + > > > > > > > > >

[PATCH v2 5/5] build: select optional libraries

2021-11-17 Thread David Marchand
There is currently no way to know which libraries are optional. Introduce a enable_libs option (close to what we have for drivers) so that packagers or projects consuming DPDK can more easily select the optional libraries that matter to them and disable other optional libraries. Note: the enabled_

[PATCH v2 4/5] build: make pdump optional

2021-11-17 Thread David Marchand
This library can be made optional. dumpcap and pdump applications depend on this library, check for dependencies like what we have for examples. Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by: Thomas Monjalon --- app/meson.build | 18 +- app/test/meson.b

[PATCH v2 3/5] build: make metrics libraries optional

2021-11-17 Thread David Marchand
metrics, bitratestats, jobstats and latencystats libraries can be made optional as they provide standalone features. Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by: Thomas Monjalon --- app/proc-info/main.c | 16 app/proc-info/meson.build | 5 - app

[PATCH v2 2/5] build: make GRO/GSO optional

2021-11-17 Thread David Marchand
GRO and GSO integration in testpmd is relatively self contained and easy to extract. Those libraries can be made optional as they provide standalone features. Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by: Thomas Monjalon --- app/test-pmd/cmdline.c | 14 ++ ap

[PATCH v2 1/5] ci: test minimum configuration

2021-11-17 Thread David Marchand
Disabling drivers and optional libraries was not tested. Add a new target in test-meson-builds.sh and GHA with just the minimum to run test-null.sh and any other optional component disabled. Signed-off-by: David Marchand --- Changes since v1: - dropped target cleanup in test-meson-builds.sh, this

[PATCH v2 0/5] Extend optional libraries list

2021-11-17 Thread David Marchand
This series extends the optional libraries list adding to them testpmd non essential dependencies. We were not testing the disable_libs option, so let's add a minimum target in the the public CI script (mainly for GHA) and in test-meson-builds.sh script. The last patch is an idea for enhancing th

Re: [PATCH 1/2] net/sfc: add missing printout label for count action

2021-11-17 Thread Ferruh Yigit
On 11/16/2021 9:41 PM, Ivan Malov wrote: Fixes: 96fd2bd69b58 ("net/sfc: support flow action count in transfer rules") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton Series applied to dpdk-next-net/main, thanks.

Re: [PATCH 5/5] build: select optional libraries

2021-11-17 Thread David Marchand
On Wed, Nov 17, 2021 at 11:47 AM Bruce Richardson wrote: > > On Tue, Nov 16, 2021 at 06:25:28PM +0100, Thomas Monjalon wrote: > > 10/11/2021 18:34, Bruce Richardson: > > > On Wed, Nov 10, 2021 at 05:48:14PM +0100, David Marchand wrote: > > > > There is currently no way to know which libraries are

Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Elena Agostini
> On Wed, Nov 17, 2021 at 4:38 PM Elena Agostini wrote: > > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > > > > On Wed, 17 Nov 2021 03:04:59 + > > > > > wrote: > > > > > > > > > > > From: Elena Agostini > > > > > > > > > > > > This patch introduces GP

Re: [PATCH] failsafe: Bug fix for the secondary process RX-TX support

2021-11-17 Thread Ferruh Yigit
On 11/11/2021 10:59 AM, Gaëtan Rivet wrote: On Thu, Nov 11, 2021, at 11:06, Kumara Parameshwaran wrote: Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This check was removed for

Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Jerin Jacob
On Wed, Nov 17, 2021 at 4:38 PM Elena Agostini wrote: > > > External email: Use caution opening links or attachments > > > > > > > > > On Wed, 17 Nov 2021 03:04:59 + > > > wrote: > > > > > > > From: Elena Agostini > > > > > > > > This patch introduces GPU memory in testpmd through the gpudev

[PATCH] net/mlx5: fix modify field destination bit offset

2021-11-17 Thread Viacheslav Ovsiienko
If the modify field action requests the field copy/set transaction from other field, the destination field hardware bit offset was assigned incorrectly with non-zero byte offset, causing wrong translations for the fields with sizes larger than 32 bits. Fixes: 40c8fb1fd3b3 ("net/mlx5: update modify

Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

2021-11-17 Thread Elena Agostini
> External email: Use caution opening links or attachments > > > On Wed, 17 Nov 2021 03:04:59 + > wrote: > > > From: Elena Agostini > > > > This patch introduces GPU memory in testpmd through the gpudev library. > > Testpmd can be used for network benchmarks when using GPU memory > > instead

[PATCH] common/mlx5: fix memory leak in Windows dereg MR function

2021-11-17 Thread michaelba
From: Michael Baum The "mlx5_devx_cmd_mkey_create" DevX cmd allocates DevX object using mlx5_malloc and then creates MKey using glue function. Compatibly, "mlx5_devx_cmd_destroy" cmd releases first the MKey using glue function, and then free the DevX object using mlx5_free. On Windows OS, the re

Re: [dpdk-dev] [PATCH 2/2] examples: move vendor specific apps to drivers sub directory

2021-11-17 Thread Thomas Monjalon
05/07/2021 10:53, Jerin Jacob: > On Thu, Jun 17, 2021 at 12:47 PM Thomas Monjalon wrote: > > > > 26/05/2021 09:47, Hemant Agrawal: > > > As approved by DPDK technical board on 2021-03-24 NTB and IOAT > > > raw driver's example application will be moved to > > > example/drivers/raw/ to avoid PMD sp

Re: [dpdk-dev] [PATCH 2/2] examples: move vendor specific apps to drivers sub directory

2021-11-17 Thread Thomas Monjalon
26/05/2021 09:47, Hemant Agrawal: > As approved by DPDK technical board on 2021-03-24 NTB and IOAT > raw driver's example application will be moved to > example/drivers/raw/ to avoid PMD specific example application > to show up in examples directory. > > Signed-off-by: Hemant Agrawal > --- > do

[PATCH] common/mlx5: fix user mode register access attribute

2021-11-17 Thread michaelba
From: Michael Baum To detect the timestamp mode configured on the NIC the mlx5 PMD uses the firmware command ACCESS_REGISTER_USER. The HCA capability command has an attribute flag checking whether firmware supports the command. However, the HCA capability query command read the flag from wrong p

Re: [dpdk-dev] [PATCH 1/2] doc: add policy for adding vendor PMD specific examples

2021-11-17 Thread Thomas Monjalon
26/05/2021 09:47, Hemant Agrawal: > This patch update the dpdk sample app policy to support > vendor PMD specific test examples in the respective drivers > sub-directory in examples. Please could you add a link to the decision in techboard minutes? > Signed-off-by: Hemant Agrawal > --- > doc/gu

  1   2   >