[dpdk-dev] [PATCH v3 9/9] net/hns3: remove PF/VF duplicate code

2021-11-05 Thread Min Hu (Connor)
From: Chengwen Feng This patch remove PF/VF duplicate code of: 1. get firmware version. 2. get device info. 3. rx interrupt related functions. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_common.c| 339 +- drivers/net/hn

[dpdk-dev] [PATCH v3 5/9] net/hns3: extract a common file

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li This patch extracts a common file to store the common code for PF and VF driver. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_cmd.c | 2 +- drivers/net/hns3/hns3_common.c| 426 + drivers/net/hns3/hn

[dpdk-dev] [PATCH v3 3/9] net/hns3: modifying code alignment

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li This patch modifies some code alignment issues to make the code style more consistent. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/

[dpdk-dev] [PATCH v3 6/9] net/hns3: add hns3 flow header file

2021-11-05 Thread Min Hu (Connor)
This patch adds a hns3_flow.h to make the code easier to maintain. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 1 + drivers/net/hns3/hns3_ethdev.h| 3 +-- drivers/net/hns3/hns3_ethdev_vf.c | 1 + drivers/net/hns3/hns3_fdir.h | 31

[dpdk-dev] [PATCH v3 8/9] net/hns3: fix the return value of the function

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li Fixing the return value of the function to clear static warning. Fixes: 1181500b2fc5 ("net/hns3: adjust MAC address logging") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_common.c | 8 1 file changed, 4 inser

[dpdk-dev] [PATCH v3 4/9] net/hns3: use unsigned integer for bitwise operations

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li Bitwise operations should be used only with unsigned integer. This patch modifies some code that does not meet this rule. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

[dpdk-dev] [PATCH v3 0/9] code optimization for hns3 PMD

2021-11-05 Thread Min Hu (Connor)
This patch set contains refactor patches and code check patches. Chengwen Feng (1): net/hns3: remove PF/VF duplicate code Huisong Li (7): net/hns3: fix the shift of DMA address in Rx/Tx queue net/hns3: remove a redundant function declaration net/hns3: modifying code alignment net/hns3:

[dpdk-dev] [PATCH v3 2/9] net/hns3: remove a redundant function declaration

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li This patch removes a redundant function declaration for hns3_rx_check_vec_support(). Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rxtx.h b/drivers/net/hns3/hn

[dpdk-dev] [PATCH v3 1/9] net/hns3: fix the shift of DMA address in Rx/Tx queue

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li The patch obtains the upper 32 bits of the Rx/Tx queue DMA address in one step instead of two steps. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_

[dpdk-dev] [PATCH v3 7/9] net/hns3: remove magic numbers

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li Removing magic numbers with macros. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_common.c | 4 ++-- drivers/net/hns3/hns3_common.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_common.c b/dr

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: remove double dependency on bitrate

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 1:30 PM, David Marchand wrote: No need for double dependency, once is enough. While at it, sort alphabetically. Signed-off-by: David Marchand Fixes: fac83b3ef8ac ("app: fix missing dependencies") Cc: sta...@dpdk.org Acked-by: Ferruh Yigit Applied to dpdk-next-net/main,

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: remove unneeded dependency on meter

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 1:40 PM, Bruce Richardson wrote: On Fri, Nov 05, 2021 at 02:30:17PM +0100, David Marchand wrote: testpmd depends on ethdev, which itself depends on meter. No need for an explicit dependency, since no testpmd code directly calls in the meter library. Signed-off-by: David Marchand -

[dpdk-dev] [PATCH 5/5] net/sfc: support decrement IP TTL actions in transfer flows

2021-11-05 Thread Ivan Malov
These actions map to MAE action DECR_IP_TTL. It affects the outermost header in the current processing state of the packet, which might have been decapsulated by prior action DECAP. It also updates IPv4 checksum accordingly. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: An

[dpdk-dev] [PATCH 4/5] common/sfc_efx/base: support adding dec. TTL action to a set

2021-11-05 Thread Ivan Malov
Affects the outermost header, taking prior action DECAP into account. Takes care to also update IPv4 checksum accordingly. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef10_nic.c | 9 +++ drivers/common/sfc_efx/base/efx.

[dpdk-dev] [PATCH 3/5] common/sfc_efx/base: factor out no-op helper functions

2021-11-05 Thread Ivan Malov
When an action gets added to an action set, a special helper is used to handle its arguments. There are actions which have no arguments, and the corresponding helpers are duplicates in fact. Use a unified no-op helper instead of them. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Revie

[dpdk-dev] [PATCH 2/5] common/sfc_efx/base: refine adding count action to a set

2021-11-05 Thread Ivan Malov
1) Invalid counter ID is always set by default. Do not set it again when adding the action. 2) Counter ID validity check is missing in the action set allocation helper. Introduce it. Fixes: 238306cf9aff ("common/sfc_efx/base: support counter in action set") Cc: sta...@dpdk.org Signed-off-b

[dpdk-dev] [PATCH 1/5] common/sfc_efx/base: refine adding encap action to a set

2021-11-05 Thread Ivan Malov
1) Invalid encap. header ID is always set by default. Do not set it again when adding the action. 2) Encap. header ID validity check is missing in the action set allocation helper. Introduce it. Fixes: 3907defa5bf0 ("common/sfc_efx/base: support adding encap action to a set") Cc: sta...@dp

[dpdk-dev] [PATCH 0/5] net/sfc: support IP TTL decrement actions in transfer flows

2021-11-05 Thread Ivan Malov
Ivan Malov (5): common/sfc_efx/base: refine adding encap action to a set common/sfc_efx/base: refine adding count action to a set common/sfc_efx/base: factor out no-op helper functions common/sfc_efx/base: support adding dec. TTL action to a set net/sfc: support decrement IP TTL actions i

Re: [dpdk-dev] [dpdk-announce] release candidate 21.11-rc1

2021-11-05 Thread Thinh Tran
Hi IBM - Power Systems DPDK v21.11-rc1-63-gbb0bd346d5 * Basic PF on Mellanox: No new issues or regressions were seen. * Performance: not tested. Systems tested: - IBM Power9 PowerNV 9006-22P OS: RHEL 8.4 GCC: version 8.3.1 20191121 (Red Hat 8.3.1-5) NICs: - Mellanox Technologi

Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 4:26 PM, Stephen Hemminger wrote: On Fri, 05 Nov 2021 16:05:14 +0100 Thomas Monjalon wrote: What do you think about marking old macros as deprecated? This will cause warning in application code that is using old macros, but shouldn't fail their build (unless -Werror is issued).

Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 5:03 PM, Slava Ovsiienko wrote: -Original Message- From: Ferruh Yigit Sent: Friday, November 5, 2021 17:57 To: Gregory Etelson ; Slava Ovsiienko ; Ori Kam Cc: Matan Azrad ; Raslan Darawsheh ; Xiaoyun Li ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flex it

Re: [dpdk-dev] [PATCH] doc: remove repeated repeated words

2021-11-05 Thread Thomas Monjalon
05/11/2021 22:10, Thomas Monjalon: > The script devtools/check-dup-words.sh can detect some words > which are duplicated. After double check, it seems this script is not in the repository, probably because of the false positives. I will change this sentence in the v2.

[dpdk-dev] [PATCH] doc: remove repeated repeated words

2021-11-05 Thread Thomas Monjalon
The script devtools/check-dup-words.sh can detect some words which are duplicated. Fixes: fdec9301f52d ("doc: add flow classify guides") Cc: bernard.iremon...@intel.com Fixes: 4dc6d8e63c16 ("doc: add graph library guide") Cc: jer...@marvell.com Fixes: 30d3aa861db5 ("doc: rework VM power manager us

Re: [dpdk-dev] [PATCH 1/4] common/sfc_efx: use correct define to control debug

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 8:33 AM, Andrew Rybchenko wrote: efsys.h belongs to common/sfc_efx and common driver debug toggle should be used instead of net/sfc toggle. Fixes: 5e111ed87999 ("net/sfc: introduce common driver library") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko Not the set, only for

Re: [dpdk-dev] [dpdk-dev v8 9/9] crypto/qat: add gen specific implementation

2021-11-05 Thread Thomas Monjalon
05/11/2021 21:39, Thomas Monjalon: > 04/11/2021 11:34, Kai Ji: > > From: Fan Zhang > > > > This patch replaces the mixed QAT symmetric and asymmetric > > support implementation by separate files with shared or > > individual implementation for specific QAT generation. > > > > Signed-off-by: Arek

[dpdk-dev] [PATCH] ci: enable ppc64le cross compilation in GHA

2021-11-05 Thread David Christensen
Enable Github Actions to cross-compile code for POWER systems. Signed-off-by: David Christensen --- .ci/linux-build.sh | 6 +- .github/workflows/build.yml | 15 ++- config/ppc/ppc64le-power8-linux-gcc-GHA | 11 +++ 3 files changed, 30 ins

Re: [dpdk-dev] [dpdk-dev v8 9/9] crypto/qat: add gen specific implementation

2021-11-05 Thread Thomas Monjalon
04/11/2021 11:34, Kai Ji: > From: Fan Zhang > > This patch replaces the mixed QAT symmetric and asymmetric > support implementation by separate files with shared or > individual implementation for specific QAT generation. > > Signed-off-by: Arek Kusztal > Signed-off-by: Fan Zhang > Signed-off-

Re: [dpdk-dev] [PATCH 4/4] net/sfc: support regioned NIC DMA memory mapping type

2021-11-05 Thread Thomas Monjalon
05/11/2021 20:05, Ferruh Yigit: > On 11/5/2021 8:33 AM, Andrew Rybchenko wrote: > > From: Viacheslav Galaktionov > > > > DMA on SN1022 SoC requires extra mapping of the memory via MCDI. > > The mapping is expensive on datapath, so make it a build-time option. > > Usage of build-time option is acc

Re: [dpdk-dev] [PATCH 4/4] net/sfc: support regioned NIC DMA memory mapping type

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 8:33 AM, Andrew Rybchenko wrote: From: Viacheslav Galaktionov DMA on SN1022 SoC requires extra mapping of the memory via MCDI. The mapping is expensive on datapath, so make it a build-time option. Usage of build-time option is acceptable since it is required in very specific case o

Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 5:03 PM, Slava Ovsiienko wrote: -Original Message- From: Ferruh Yigit Sent: Friday, November 5, 2021 17:57 To: Gregory Etelson ; Slava Ovsiienko ; Ori Kam Cc: Matan Azrad ; Raslan Darawsheh ; Xiaoyun Li ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flex it

Re: [dpdk-dev] [PATCH] doc: update release notes for bnxt PMD

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 6:41 PM, Ajit Khaparde wrote: On Fri, Nov 5, 2021 at 11:38 AM Ferruh Yigit wrote: On 11/5/2021 6:22 PM, Ajit Khaparde wrote: On Fri, Nov 5, 2021 at 11:14 AM Ferruh Yigit wrote: On 11/5/2021 4:55 PM, Ajit Khaparde wrote: Update release notes for new functionality added to the

Re: [dpdk-dev] [PATCH] doc: update release notes for bnxt PMD

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 6:22 PM, Ajit Khaparde wrote: On Fri, Nov 5, 2021 at 11:14 AM Ferruh Yigit wrote: On 11/5/2021 4:55 PM, Ajit Khaparde wrote: Update release notes for new functionality added to the bnxt PMD. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_21_11.rst | 9

Re: [dpdk-dev] [PATCH] doc: update release notes for bnxt PMD

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 4:55 PM, Ajit Khaparde wrote: Update release notes for new functionality added to the bnxt PMD. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_21_11.rst | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_21_11.

Re: [dpdk-dev] [PATCH v2] build: add definitions for use as meson subproject

2021-11-05 Thread Bruce Richardson
On Fri, Nov 05, 2021 at 10:22:13AM -0700, Stephen Hemminger wrote: > Some other projects using meson may not be able to use DPDK > using the standard distribution pkg-config mechanism. > Meson supports a way to handle this via the subproject > https://mesonbuild.com/Subprojects.html > > This pat

Re: [dpdk-dev] [PATCH v5 00/22] fixes and enhancements to Truflow

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 4:57 PM, Ajit Khaparde wrote: On Fri, Nov 5, 2021 at 4:10 AM Ferruh Yigit wrote: On 11/4/2021 9:58 PM, Ajit Khaparde wrote: Enhancements include: * Scaling numbers on Thor * Inner IP header support for GRE tunnel flows * Enable wildcard match for ingress flows * Add clear on read

[dpdk-dev] [PATCH v2] build: add definitions for use as meson subproject

2021-11-05 Thread Stephen Hemminger
Some other projects using meson may not be able to use DPDK using the standard distribution pkg-config mechanism. Meson supports a way to handle this via the subproject https://mesonbuild.com/Subprojects.html This patch adds the necessary dependency to follow the "Naming convention for dependenc

Re: [dpdk-dev] [PATCH] doc: remove deprecation notice for interrupt

2021-11-05 Thread David Marchand
On Wed, Nov 3, 2021 at 6:51 PM Harman Kalra wrote: > > Deprecation notice targeted for 21.11 has been committed with > following as the first commit of the series. > > Fixes: b7c984291611 ("interrupts: add allocator and accessors") > > Signed-off-by: Harman Kalra Acked-by: David Marchand Applie

Re: [dpdk-dev] [PATCH v2 5/9] net/hns3: extract a common file

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 2:46 AM, Min Hu (Connor) wrote: @@ -1047,28 +1031,20 @@ hns3_test_and_clear_bit(unsigned int nr, volatile uint64_t *addr) return __atomic_fetch_and(addr, ~mask, __ATOMIC_RELAXED) & mask; } +uint32_t hns3_get_speed_capa(struct hns3_hw *hw); + This looks git rebase err

Re: [dpdk-dev] [PATCH v2 8/9] net/hns3: fix the return value of the function

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 2:46 AM, Min Hu (Connor) wrote: From: Huisong Li Fixing the return value of the function to clear static warning. Missing fixes tag. (And stable based on what is fixed) Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor)

Re: [dpdk-dev] [PATCH v2 1/9] net/hns3: fix the shift of DMA address in Rx/Tx queue

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 2:46 AM, Min Hu (Connor) wrote: From: Huisong Li The patch obtains the upper 32 bits of the Rx/Tx queue DMA address in one step instead of two steps. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Missing 'stable' tag. Signed-off-by: Huisong Li

Re: [dpdk-dev] [PATCH v2 1/9] net/hns3: fix the shift of DMA address in Rx/Tx queue

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 2:46 AM, Min Hu (Connor) wrote: From: Huisong Li The patch obtains the upper 32 bits of the Rx/Tx queue DMA address in one step instead of two steps. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Signed-off-by: Huisong Li Hi Connor, This patch requires

Re: [dpdk-dev] [PATCH v2 9/9] net/hns3: remove PF/VF duplicate code

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 2:46 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch remove PF/VF duplicate code of: 1. get firmware version. 2. get device info. 3. rx interrupt related functions. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3.tar.gz | Bin 0

Re: [dpdk-dev] [PATCH v5 00/22] fixes and enhancements to Truflow

2021-11-05 Thread Ajit Khaparde
On Fri, Nov 5, 2021 at 4:10 AM Ferruh Yigit wrote: > > On 11/4/2021 9:58 PM, Ajit Khaparde wrote: > > Enhancements include: > > * Scaling numbers on Thor > > * Inner IP header support for GRE tunnel flows > > * Enable wildcard match for ingress flows > > * Add clear on read for flow stats on Thor

Re: [dpdk-dev] [dpdk-dev v1] test/cryptodev: fix incomplete data length

2021-11-05 Thread Zhang, Roy Fan
> -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Friday, November 5, 2021 3:42 PM > To: dev@dpdk.org > Cc: Ji, Kai ; De Lara Guarch, Pablo > ; adamx.dybkow...@intel.com > Subject: [dpdk-dev] [dpdk-dev v1] test/cryptodev: fix incomplete data > length > > This patch fixes incorr

Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-05 Thread Stephen Hemminger
On Fri, 05 Nov 2021 16:05:14 +0100 Thomas Monjalon wrote: > > >> > > >> What do you think about marking old macros as deprecated? > > >> > > >> This will cause warning in application code that is using > > >> old macros, but shouldn't fail their build (unless -Werror > > >> is issued). > > > >

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix set Rx offloads RSS hash off

2021-11-05 Thread Ferruh Yigit
On 11/4/2021 9:29 AM, Jie Wang wrote: When we set Rx offloads RSS hash off in cmdline, then we start port, if dev->data->dev_conf.rxmode.mq_mode RSS enable(multiple queues mode), it will load RSS hash in driver and sync to port. After setting Rx offloads RSS hash off, this patch removes RTE_ETH_

[dpdk-dev] [dpdk-dev v1] test/cryptodev: add sgl oop in raw dp unit test

2021-11-05 Thread Kai Ji
Add-in support of SGL OOP in sym raw dp unit test Signed-off-by: Kai Ji --- app/test/test_cryptodev.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index b926412742..68ecd152c3 100644 --- a/app/test/test_cryp

Re: [dpdk-dev] [PATCH] build: allow build DPDK as a meson submodule

2021-11-05 Thread Stephen Hemminger
On Fri, 5 Nov 2021 14:58:24 + Bruce Richardson wrote: > On Thu, Nov 04, 2021 at 05:01:24PM -0700, Stephen Hemminger wrote: > > Some other projects using meson may not be able to use DPDK > > using the standard distribution pkg-config mechanism. > > Meson supports a way to handle this via the

Re: [dpdk-dev] [PATCH v7 0/2] Add delay drop support for Rx queue

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 3:30 PM, Bing Zhao wrote: --- v2: - change hairpin queue delay drop to disable by default - combine the commits - fix Windows building - change the log print v3: fix conflict and building v4: code style update and commit log polishing v5: - split and fix the document d

Re: [dpdk-dev] [PATCH] doc: cleanup flow mark Rx offload deprecation notice

2021-11-05 Thread Ferruh Yigit
On 11/2/2021 12:50 PM, Andrew Rybchenko wrote: The problem is solved using Rx metadata delivery negotiation API [1]. [1] commit f6d8a6d3fad7 ("ethdev: negotiate delivery of packet metadata from HW to PMD") Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst | 8

Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush

2021-11-05 Thread Ferruh Yigit
On 10/26/2021 4:20 PM, Gregory Etelson wrote: Testpmd provides 2 sets of flex item create and destroy functions One for hosts with JSON library. These functions parse flex item configuration stored in JSON file and create or destroy flex item object. The second functions set is for hosts without

[dpdk-dev] [PATCH v2] power: fix unused-but-set variable error

2021-11-05 Thread Jim Harris
clang-13 rightfully complains that the tot_ppi variable in update_stats is set but not used, since the final accumulated tot_ppi results isn't used anywhere. Original idea was to just remove the tot_ppi variable, but feedback from David Marchand on mailing list was that the related ppi_av array in

[dpdk-dev] [dpdk-dev v1] test/cryptodev: fix incomplete data length

2021-11-05 Thread Kai Ji
This patch fixes incorrect data lengths computation in cryptodev unit test. Previously some data lengths were incorrectly set, which was insensitive for crypto op unit tets but is critical for raw data path API unit tests. The patch addressed the issue by setting the correct data lengths for some t

Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-05 Thread Thomas Monjalon
05/11/2021 14:40, Andrew Rybchenko: > On 11/4/21 3:59 PM, Thomas Monjalon wrote: > > 04/11/2021 12:03, Ferruh Yigit: > >> On 11/3/2021 10:48 PM, Ferruh Yigit wrote: > >>> Old macros kept for backward compatibility, but this cause old macro > >>> usage to sneak in silently. > >>> > >>> Marking old m

Re: [dpdk-dev] [PATCH] build: allow build DPDK as a meson submodule

2021-11-05 Thread Bruce Richardson
On Thu, Nov 04, 2021 at 05:01:24PM -0700, Stephen Hemminger wrote: > Some other projects using meson may not be able to use DPDK > using the standard distribution pkg-config mechanism. > Meson supports a way to handle this via the subproject > https://mesonbuild.com/Subprojects.html > > This pat

Re: [dpdk-dev] [PATCH v4 0/2] enable protocol agnostic flow offloading in RSS

2021-11-05 Thread Xu, Ting
> -Original Message- > From: Thomas Monjalon > Sent: Friday, November 5, 2021 9:23 PM > To: Zhang, Qi Z ; Xu, Ting > Cc: dev@dpdk.org; Yang, Qiming ; Guo, Junfeng > ; or...@nvidia.com; viachesl...@nvidia.com; Yigit, > Ferruh ; andrew.rybche...@oktetlabs.ru > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v7 1/6] ethdev: fix max Rx packet length

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 2:19 PM, Xueming(Steven) Li wrote: On Mon, 2021-10-18 at 18:31 +0100, Ferruh Yigit wrote: On 10/18/2021 2:48 PM, Ferruh Yigit wrote: There is a confusion on setting max Rx packet length, this patch aims to clarify it. 'rte_eth_dev_configure()' API accepts max Rx packet size via 'u

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix crash on owner delete

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 1:36 PM, Andrew Rybchenko wrote: On 11/5/21 4:16 PM, Thomas Monjalon wrote: 05/11/2021 04:03, Xia, Chenbo: From: stable On Behalf Of Ferruh Yigit 'eth_dev->data' can be null before ethdev allocated. The API walks through all eth devices, at least for some data can be null. Addi

Re: [dpdk-dev] [PATCH] eal/memory: fix unused SIGBUS handler

2021-11-05 Thread David Marchand
On Fri, Oct 29, 2021 at 11:53 AM Olivier Matz wrote: > > Since its introduction in 2018, the SIGBUS handler was never registered, > and all related functions were unused. > > A SIGBUS can be received by the application when accessing to hugepages > even if mmap() was successful, This happens espec

Re: [dpdk-dev] [PATCH] eal: fix mem alloc from control thread if socket 0 is unused

2021-11-05 Thread David Marchand
On Thu, Nov 4, 2021 at 9:54 AM Olivier Matz wrote: > > > From: Ilyes Ben Hamouda > > > > > > When using rte_malloc() from a control thread, the used heap is the one > > > from numa socket 0, which may not have available memory. > > > > > > Fix this by selecting the first socket which has availabl

Re: [dpdk-dev] [PATCH v7 1/6] ethdev: fix max Rx packet length

2021-11-05 Thread Xueming(Steven) Li
On Mon, 2021-10-18 at 18:31 +0100, Ferruh Yigit wrote: > On 10/18/2021 2:48 PM, Ferruh Yigit wrote: > > There is a confusion on setting max Rx packet length, this patch aims to > > clarify it. > > > > 'rte_eth_dev_configure()' API accepts max Rx packet size via > > 'uint32_t max_rx_pkt_len' field

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/txgbe: fix link process in KR mode

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 2:01 AM, Jiawen Wu wrote: Set the 'present' parameter to 0 by default. It is configured by hardware, users can set it to 1 for manual configuration. Fixes: f611dada1af8 ("net/txgbe: update link setup process of backplane NICs") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu Applie

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: remove unneeded dependency on meter

2021-11-05 Thread Bruce Richardson
On Fri, Nov 05, 2021 at 02:30:17PM +0100, David Marchand wrote: > testpmd depends on ethdev, which itself depends on meter. > No need for an explicit dependency, since no testpmd code directly calls > in the meter library. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-05 Thread Andrew Rybchenko
On 11/4/21 3:59 PM, Thomas Monjalon wrote: > 04/11/2021 12:03, Ferruh Yigit: >> On 11/3/2021 10:48 PM, Ferruh Yigit wrote: >>> Old macros kept for backward compatibility, but this cause old macro >>> usage to sneak in silently. >>> >>> Marking old macros as deprecated. Downside is this will cause s

Re: [dpdk-dev] [PATCH] examples: skip example when missing dependencies

2021-11-05 Thread Bruce Richardson
On Fri, Nov 05, 2021 at 02:30:55PM +0100, David Marchand wrote: > Trying to disable the vhost library, meson will complain it can't build > the vhost* and vdpa examples when passing -Dexamples=all. > > -Dexamples=all skips examples if the example itself announces it can't > be built (for external

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix crash on owner delete

2021-11-05 Thread Andrew Rybchenko
On 11/5/21 4:16 PM, Thomas Monjalon wrote: > 05/11/2021 04:03, Xia, Chenbo: >> From: stable On Behalf Of Ferruh Yigit >> >>> 'eth_dev->data' can be null before ethdev allocated. The API walks >>> through all eth devices, at least for some data can be null. >>> >>> Adding 'eth_dev->data' null check

[dpdk-dev] [PATCH] examples: skip example when missing dependencies

2021-11-05 Thread David Marchand
Trying to disable the vhost library, meson will complain it can't build the vhost* and vdpa examples when passing -Dexamples=all. -Dexamples=all skips examples if the example itself announces it can't be built (for external dependencies, internal dependencies and other reasons). Since examples/mes

[dpdk-dev] [PATCH 2/2] app/testpmd: remove double dependency on bitrate

2021-11-05 Thread David Marchand
No need for double dependency, once is enough. While at it, sort alphabetically. Signed-off-by: David Marchand --- app/test-pmd/meson.build | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build index 21d50e92d

[dpdk-dev] [PATCH 1/2] app/testpmd: remove unneeded dependency on meter

2021-11-05 Thread David Marchand
testpmd depends on ethdev, which itself depends on meter. No need for an explicit dependency, since no testpmd code directly calls in the meter library. Signed-off-by: David Marchand --- app/test-pmd/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/mes

[dpdk-dev] [PATCH] app: fix testpmd dependency on jansson

2021-11-05 Thread David Marchand
ext_deps is not used in app/meson.build. testpmd currently can be linked because metrics library is pulling the dependency on libjansson. Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands") Signed-off-by: David Marchand --- app/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [dpdk-dev] [PATCH v4 0/2] enable protocol agnostic flow offloading in RSS

2021-11-05 Thread Thomas Monjalon
05/11/2021 14:18, Xu, Ting: > From: Thomas Monjalon > > 04/11/2021 03:22, Ting Xu: > > > Enable protocol agnostic flow offloading to support raw pattern input > > > for RSS hash flow rule creation. It is based on Parser Library feature. > > > Current rte_flow raw API is utilized. > > > > I rememb

Re: [dpdk-dev] [PATCH v4 0/2] enable protocol agnostic flow offloading in RSS

2021-11-05 Thread Xu, Ting
> -Original Message- > From: Thomas Monjalon > Sent: Friday, November 5, 2021 9:10 PM > To: Zhang, Qi Z ; Xu, Ting > Cc: dev@dpdk.org; Yang, Qiming ; Guo, Junfeng > ; or...@nvidia.com; viachesl...@nvidia.com; Yigit, > Ferruh ; andrew.rybche...@oktetlabs.ru > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix crash on owner delete

2021-11-05 Thread Thomas Monjalon
05/11/2021 04:03, Xia, Chenbo: > From: stable On Behalf Of Ferruh Yigit > > > 'eth_dev->data' can be null before ethdev allocated. The API walks > > through all eth devices, at least for some data can be null. > > > > Adding 'eth_dev->data' null check before accessing it. > > > > Fixes: 33c73aae3

Re: [dpdk-dev] [PATCH v4 0/2] enable protocol agnostic flow offloading in RSS

2021-11-05 Thread Thomas Monjalon
04/11/2021 03:22, Ting Xu: > Enable protocol agnostic flow offloading to support raw pattern input > for RSS hash flow rule creation. It is based on Parser Library feature. > Current rte_flow raw API is utilized. I remember raw item was especially targetting encapsulation action. Which action do y

[dpdk-dev] [PATCH v1] config/arm: split aarch32 march

2021-11-05 Thread Juraj Linkeš
Aarch32 config got overlooked when splitting march in a previous parch. Fixes: 95e0f23022a3 ("config/arm: split -march into arch and features") Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/config/arm/meson.build b/co

Re: [dpdk-dev] [PATCH v13 6/7] net/iavf: add watchdog for VFLR

2021-11-05 Thread Ferruh Yigit
On 10/28/2021 5:04 PM, Radu Nicolau wrote: diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 783a10060c..ae0f8f17f4 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -25,6 +25,7 @@ #include #include #include +#include

Re: [dpdk-dev] [PATCH v5 00/22] fixes and enhancements to Truflow

2021-11-05 Thread Thomas Monjalon
05/11/2021 12:10, Ferruh Yigit: > On 11/4/2021 9:58 PM, Ajit Khaparde wrote: > > Enhancements include: > > * Scaling numbers on Thor > > * Inner IP header support for GRE tunnel flows > > * Enable wildcard match for ingress flows > > * Add clear on read for flow stats on Thor > > * Add nat support

Re: [dpdk-dev] [PATCH v5 00/22] fixes and enhancements to Truflow

2021-11-05 Thread Ferruh Yigit
On 11/4/2021 9:58 PM, Ajit Khaparde wrote: Enhancements include: * Scaling numbers on Thor * Inner IP header support for GRE tunnel flows * Enable wildcard match for ingress flows * Add clear on read for flow stats on Thor * Add nat support for dest IP and port combination * Remove 2-slice WC sup

Re: [dpdk-dev] [PATCH v6 2/2] eal: add additional info if core mask too long

2021-11-05 Thread David Marchand
On Wed, Nov 3, 2021 at 3:33 PM David Hunt wrote: > > If the user requests to use an lcore above 128 using -c, > the eal will exit with "EAL: invalid coremask syntax" and > very little else useful information. > > This patch adds some extra information suggesting to use --lcores > so that physical

Re: [dpdk-dev] [PATCH v3 1/3] app/flow-perf: support meter policy API

2021-11-05 Thread Thomas Monjalon
05/11/2021 11:24, Rongwei Liu: > HI Tomas: > Flow-perf application run-time options are growing quickly and some of > them are a little complex. > Under current architecture, I don't find a valid way to reduce the > indention level unless maintainer agree to simply the logic. Trust c

[dpdk-dev] [PATCH v5 2/2] hash: unify crc32 selection for x86 and Arm

2021-11-05 Thread pbhagavatula
From: Pavan Nikhilesh Merge crc32 hash calculation public API implementation for x86 and Arm. Select the best available CRC32 algorithm when unsupported algorithm on a given CPU architecture is requested by an application. Previously, if an application directly includes `rte_crc_arm64.h` without

[dpdk-dev] [PATCH v5 1/2] hash: split x86 and SW hash CRC intrinsics

2021-11-05 Thread pbhagavatula
From: Pavan Nikhilesh Split x86 and SW hash crc intrinsics into a separate files. Signed-off-by: Pavan Nikhilesh --- v5 Changes: - Move CRC functions to implementation specific files to remove ifdef clutter. (Ruifeng) lib/hash/hash_crc_sw.h | 419

Re: [dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-05 Thread Ferruh Yigit
On 11/3/2021 1:57 PM, Vijay Srivastava wrote: diff --git a/drivers/vdpa/sfc/meson.build b/drivers/vdpa/sfc/meson.build new file mode 100644 index 000..4255d65 --- /dev/null +++ b/drivers/vdpa/sfc/meson.build @@ -0,0 +1,22 @@ +# SPDX-License-Identifier: BSD-3-Clause +# +# Copyright(c) 2020-202

Re: [dpdk-dev] [PATCH v3 1/3] app/flow-perf: support meter policy API

2021-11-05 Thread Thomas Monjalon
28/10/2021 05:25, Rongwei Liu: > @@ -854,6 +862,46 @@ args_parse(int argc, char **argv) > RTE_MAX_LCORE); > } > } > + if (strcmp(lgopts[opt_idx].name, "policy-mtr") == 0) { > +

Re: [dpdk-dev] [V3] app/flow-perf: add destination ports parameter

2021-11-05 Thread Thomas Monjalon
> > Add optional destination ports parameter for port-id action. > > The parameter is not must, and the value is 1 by default as before if the > > parameter not provided. > > > > For example: > > > > $ dpdk-test-flow-perf -w 08:00.0,representor=[0,1] -- --transfer \ > > > --ingress --transfer --e

Re: [dpdk-dev] [PATCH] eal: promote non-EAL lcore API as stable

2021-11-05 Thread David Marchand
On Wed, Nov 3, 2021 at 6:41 PM Thomas Monjalon wrote: > 22/10/2021 12:22, Kevin Traynor: > > On 22/10/2021 07:55, David Marchand wrote: > > > This API has been around for more than a year (and is in LTS 20.11). > > > It did not receive negative feedback and will be used in a next OVS > > > release

Re: [dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-05 Thread Ferruh Yigit
On 11/3/2021 1:57 PM, Vijay Srivastava wrote: diff --git a/drivers/vdpa/sfc/meson.build b/drivers/vdpa/sfc/meson.build new file mode 100644 index 000..4255d65 --- /dev/null +++ b/drivers/vdpa/sfc/meson.build @@ -0,0 +1,22 @@ +# SPDX-License-Identifier: BSD-3-Clause +# +# Copyright(c) 2020-202

Re: [dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 9:28 AM, Andrew Rybchenko wrote: On 11/5/21 12:13 PM, Ferruh Yigit wrote: On 11/3/2021 1:57 PM, Vijay Srivastava wrote: diff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c new file mode 100644 index 000..f087944 --- /dev/null +++ b/drivers/vdpa/sfc/sfc_vdpa.c

Re: [dpdk-dev] [PATCH v5 2/3] examples/l3fwd: print port bdf when adding routes

2021-11-05 Thread Walsh, Conor
> From: pbhagavat...@marvell.com > Sent: Friday 5 November 2021 08:39 > To: Walsh, Conor ; david.march...@redhat.com; > jer...@marvell.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v5 2/3] examples/l3fwd: print port bdf when > adding routes > > From: Pavan Nikhilesh > >

Re: [dpdk-dev] [PATCH v5 1/3] examples/l3fwd: increase number of routes

2021-11-05 Thread Walsh, Conor
> From: pbhagavat...@marvell.com > Sent: Friday 5 November 2021 08:39 > To: Walsh, Conor ; david.march...@redhat.com; > jer...@marvell.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v5 1/3] examples/l3fwd: increase number of > routes > > From: Pavan Nikhilesh > > Increase

Re: [dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-05 Thread Andrew Rybchenko
On 11/5/21 12:13 PM, Ferruh Yigit wrote: > On 11/3/2021 1:57 PM, Vijay Srivastava wrote: >> diff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c >> new file mode 100644 >> index 000..f087944 >> --- /dev/null >> +++ b/drivers/vdpa/sfc/sfc_vdpa.c >> @@ -0,0 +1,282 @@ >> +/* SPDX

Re: [dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-05 Thread Ferruh Yigit
On 11/3/2021 1:57 PM, Vijay Srivastava wrote: diff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c new file mode 100644 index 000..f087944 --- /dev/null +++ b/drivers/vdpa/sfc/sfc_vdpa.c @@ -0,0 +1,282 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * + * Copyright(c) 2020-20

Re: [dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 9:03 AM, Maxime Coquelin wrote: On 11/5/21 10:01, Ferruh Yigit wrote: On 11/3/2021 1:57 PM, Vijay Srivastava wrote: diff --git a/drivers/vdpa/sfc/version.map b/drivers/vdpa/sfc/version.map new file mode 100644 index 000..4a76d1d --- /dev/null +++ b/drivers/vdpa/sfc/version.ma

Re: [dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-05 Thread Maxime Coquelin
On 11/5/21 10:01, Ferruh Yigit wrote: On 11/3/2021 1:57 PM, Vijay Srivastava wrote: diff --git a/drivers/vdpa/sfc/version.map b/drivers/vdpa/sfc/version.map new file mode 100644 index 000..4a76d1d --- /dev/null +++ b/drivers/vdpa/sfc/version.map @@ -0,0 +1,3 @@ +DPDK_21 { +    local: *; +

Re: [dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-05 Thread Ferruh Yigit
On 11/3/2021 1:57 PM, Vijay Srivastava wrote: diff --git a/drivers/vdpa/sfc/version.map b/drivers/vdpa/sfc/version.map new file mode 100644 index 000..4a76d1d --- /dev/null +++ b/drivers/vdpa/sfc/version.map @@ -0,0 +1,3 @@ +DPDK_21 { + local: *; +}; It is DPDK_22 now

Re: [dpdk-dev] [PATCH] examples/vhost: fix port init failure in mergeable mode

2021-11-05 Thread Maxime Coquelin
On 11/5/21 08:32, Xia, Chenbo wrote: Hi Maxime, -Original Message- From: dev On Behalf Of Chenbo Xia Sent: Thursday, November 4, 2021 1:11 PM To: dev@dpdk.org Cc: maxime.coque...@redhat.com Subject: [dpdk-dev] [PATCH] examples/vhost: fix port init failure in mergeable mode When the

[dpdk-dev] [PATCH v2] eal/arm: remove CASP constraints for GCC

2021-11-05 Thread pbhagavatula
From: Pavan Nikhilesh GCC now assigns even register pairs for CASP, the fix has also been backported to all stable releases of older GCC versions. Removing the manual register allocation allows GCC to inline the functions and pick optimal registers for performing CASP. Signed-off-by: Pavan Nikhi

[dpdk-dev] [PATCH v5 3/3] examples/l3fwd: use reserved addresses for EM mode

2021-11-05 Thread pbhagavatula
From: Pavan Nikhilesh The l3fwd example should use the reserved IPv4/v6 reserved address ranges defined in RFC5735, RFC5180 and RFC863 discard protocol for the port number in the exact match mode of L3 forwarding. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd.h| 2 +- examples/

[dpdk-dev] [PATCH v5 2/3] examples/l3fwd: print port bdf when adding routes

2021-11-05 Thread pbhagavatula
From: Pavan Nikhilesh Since the number of Ethernet ports have gone up, print the pci bdf along with the routes. This is also helpful for cases where allow listing order is not honored. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd_fib.c | 31 +++ examples/

[dpdk-dev] [PATCH v5 1/3] examples/l3fwd: increase number of routes

2021-11-05 Thread pbhagavatula
From: Pavan Nikhilesh Increase the number of routes from 8 to 16 that are statically added for lpm and em mode as most of the SoCs support more than 8 interfaces. The number of routes added is equal to the number of ethernet devices ports enabled through port mask. Signed-off-by: Pavan Nikhilesh

  1   2   >