[dpdk-dev] [PATCH] dma/idxd: fix build on Windows

2021-10-22 Thread David Marchand
Windows compilation gives us a splat: In file included from ../drivers/dma/idxd/idxd_pci.c:10: In file included from ..\drivers\dma\idxd/idxd_internal.h:11: ..\drivers\dma\idxd/idxd_hw_defs.h:46:21: error: expected member name or ';' after declaration specifiers uint16_t __reserved[13];

Re: [dpdk-dev] [PATCH v11 00/16] add dmadev driver for idxd devices

2021-10-22 Thread David Marchand
On Fri, Oct 22, 2021 at 8:08 PM Thomas Monjalon wrote: > > 20/10/2021 18:29, Kevin Laatz: > > This patchset adds a dmadev driver and associated documentation to support > > Intel Data Streaming Accelerator devices. This driver is intended to > > ultimately replace the current IDXD part of the IOAT

Re: [dpdk-dev] [PATCH v5 3/3] test/devargs: add devargs test cases

2021-10-22 Thread David Marchand
On Wed, Oct 20, 2021 at 5:48 PM Xueming Li wrote: > + kvlist = rte_kvargs_parse(args, NULL); > + if (kvlist == NULL) { > + printf("rte_devargs_parse(%s) %s_str: %s not parsed\n", > + devargs, layer, args); > + return -1; > + } > +

[dpdk-dev] [PATCH 2/2] ethdev: fix the race condition for fp ops reset

2021-10-22 Thread Bing Zhao
In the function "eth_dev_fp_ops_reset", a structure assignment operation is used to reset one queue's callback functions, etc., but it is not thread safe. The structure assignment is not atomic, a lot of instructions will be generated. Right now, since not all the fields are needed, the fields in

[dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-22 Thread Bing Zhao
When stopping a port, the data path Tx and Rx burst functions should be stopped firstly conventionally. Then the dummy functions are used to replace the callback functions provided by the PMD. When the application stops a port without or before stopping the data path handling. The dummy functions

Re: [dpdk-dev] [PATCH v5 6/6] eal/alarm: introduce alarm fini routine

2021-10-22 Thread Dmitry Kozlyuk
2021-10-23 02:33 (UTC+0300), Dmitry Kozlyuk: > 2021-10-23 02:19 (UTC+0530), Harman Kalra: > [...] > > /** > > * Function is to check if the kernel module(like, vfio, vfio_iommu_type1, > > * etc.) loaded. > > diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c > > index 56a60f13e9..535ea

Re: [dpdk-dev] [PATCH v5 6/6] eal/alarm: introduce alarm fini routine

2021-10-22 Thread Dmitry Kozlyuk
2021-10-23 02:19 (UTC+0530), Harman Kalra: > Implementing alarm cleanup routine, where the memory allocated > for interrupt instance can be freed. > > Signed-off-by: Harman Kalra > --- > lib/eal/common/eal_private.h | 11 +++ > lib/eal/freebsd/eal.c| 1 + > lib/eal/freebsd/eal_a

Re: [dpdk-dev] [PATCH v5 5/6] eal/interrupts: make interrupt handle structure opaque

2021-10-22 Thread Dmitry Kozlyuk
2021-10-23 02:19 (UTC+0530), Harman Kalra: > Moving interrupt handle structure definition inside the c file > to make its fields totally opaque to the outside world. > > Dynamically allocating the efds and elist array os intr_handle > structure, based on size provided by user. Eg size can be > MSI

Re: [dpdk-dev] [PATCH v5 2/6] eal/interrupts: avoid direct access to interrupt handle

2021-10-22 Thread Dmitry Kozlyuk
2021-10-23 02:19 (UTC+0530), Harman Kalra: > Making changes to the interrupt framework to use interrupt handle > APIs to get/set any field. > > Signed-off-by: Harman Kalra > --- > lib/eal/freebsd/eal_interrupts.c | 112 > lib/eal/linux/eal_interrupts.c | 303 +++---

Re: [dpdk-dev] [PATCH v5 1/6] eal/interrupts: implement get set APIs

2021-10-22 Thread Dmitry Kozlyuk
2021-10-23 02:19 (UTC+0530), Harman Kalra: > Prototype/Implement get set APIs for interrupt handle fields. > User wont be able to access any of the interrupt handle fields > directly while should use these get/set APIs to access/manipulate > them. > > Internal interrupt header i.e. rte_eal_interru

Re: [dpdk-dev] [PATCH v5] lib/cmdline: release cl when cmdline exit

2021-10-22 Thread Thomas Monjalon
20/10/2021 09:03, Olivier Matz: > On Mon, Oct 18, 2021 at 05:29:35PM +0300, Dmitry Kozlyuk wrote: > > 2021-10-18 21:58 (UTC+0800), zhihongx.p...@intel.com: > > > From: Zhihong Peng > > > > > > Malloc cl in the cmdline_stdin_new function, so release in the > > > cmdline_stdin_exit function is logi

Re: [dpdk-dev] [PATCH v5 0/2] cmdline: reduce ABI

2021-10-22 Thread Thomas Monjalon
> Dmitry Kozlyuk (2): > cmdline: make struct cmdline opaque > cmdline: make struct rdline opaque Applied, thanks.

[dpdk-dev] [PATCH v2] mempool: fix non-IO flag inference

2021-10-22 Thread Dmitry Kozlyuk
When mempool had been created with RTE_MEMPOOL_F_NO_IOVA_CONTIG flag but later populated with valid IOVA, RTE_MEMPOOL_F_NON_IO was unset, while it should be kept. The unit test did not catch this because rte_mempool_populate_default() it used was populating with RTE_BAD_IOVA. Keep setting RTE_MEMP

[dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-10-22 Thread David Marchand
The rule for indentation in Meson in DPDK is 4 spaces. Any tab should be flagged as an issue, let's extend the check and fix existing offenders. Fixes: 4ad4b20a7905 ("drivers: change indentation in build files") Fixes: 2457705e6474 ("crypto/cnxk: add driver skeleton") Fixes: 634b73104482 ("app/te

[dpdk-dev] [PATCH v5 6/6] eal/alarm: introduce alarm fini routine

2021-10-22 Thread Harman Kalra
Implementing alarm cleanup routine, where the memory allocated for interrupt instance can be freed. Signed-off-by: Harman Kalra --- lib/eal/common/eal_private.h | 11 +++ lib/eal/freebsd/eal.c| 1 + lib/eal/freebsd/eal_alarm.c | 7 +++ lib/eal/linux/eal.c | 1 +

[dpdk-dev] [PATCH v5 5/6] eal/interrupts: make interrupt handle structure opaque

2021-10-22 Thread Harman Kalra
Moving interrupt handle structure definition inside the c file to make its fields totally opaque to the outside world. Dynamically allocating the efds and elist array os intr_handle structure, based on size provided by user. Eg size can be MSIX interrupts supported by a PCI device. Signed-off-by:

[dpdk-dev] [PATCH v5 3/6] test/interrupt: apply get set interrupt handle APIs

2021-10-22 Thread Harman Kalra
Updating the interrupt testsuite to make use of interrupt handle get set APIs. Signed-off-by: Harman Kalra --- app/test/test_interrupts.c | 163 ++--- 1 file changed, 98 insertions(+), 65 deletions(-) diff --git a/app/test/test_interrupts.c b/app/test/test_interr

[dpdk-dev] [PATCH v5 2/6] eal/interrupts: avoid direct access to interrupt handle

2021-10-22 Thread Harman Kalra
Making changes to the interrupt framework to use interrupt handle APIs to get/set any field. Signed-off-by: Harman Kalra --- lib/eal/freebsd/eal_interrupts.c | 112 lib/eal/linux/eal_interrupts.c | 303 +++ 2 files changed, 268 insertions(+), 147 deleti

[dpdk-dev] [PATCH v5 1/6] eal/interrupts: implement get set APIs

2021-10-22 Thread Harman Kalra
Prototype/Implement get set APIs for interrupt handle fields. User wont be able to access any of the interrupt handle fields directly while should use these get/set APIs to access/manipulate them. Internal interrupt header i.e. rte_eal_interrupt.h is rearranged, as APIs defined are moved to rte_in

[dpdk-dev] [PATCH v5 0/6] make rte_intr_handle internal

2021-10-22 Thread Harman Kalra
Moving struct rte_intr_handle as an internal structure to avoid any ABI breakages in future. Since this structure defines some static arrays and changing respective macros breaks the ABI. Eg: Currently RTE_MAX_RXTX_INTR_VEC_ID imposes a limit of maximum 512 MSI-X interrupts that can be defined for

Re: [dpdk-dev] [v3] mempool: add telemetry endpoint for mempool info

2021-10-22 Thread Thomas Monjalon
22/10/2021 18:11, Gowrishankar Muthukrishnan: > Add telemetry endpoint for mempool info. > > Signed-off-by: Gowrishankar Muthukrishnan > Reviewed-by: Bruce Richardson Applied, thanks.

Re: [dpdk-dev] [PATCH v2 0/3] Predictable RSS feature

2021-10-22 Thread Thomas Monjalon
11/04/2021 20:51, Medvedkin, Vladimir: > On 08/04/2021 18:56, Stephen Hemminger wrote: > >> app/test/test_thash.c | 468 +++- > >> lib/librte_hash/meson.build | 3 +- > >> lib/librte_hash/rte_thash.c | 637 > >> >

Re: [dpdk-dev] [PATCH v2 0/3] library build improvements on windows

2021-10-22 Thread Thomas Monjalon
20/10/2021 13:25, Bruce Richardson: > This set enables dmadev library to be built on windows, and then does some > cleanup of the lib/meson.build file to remove the separate listing of > libraries > for windows builds - instead having library disabling done via the normal > method > of each libra

Re: [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature

2021-10-22 Thread Ajit Khaparde
On Fri, Oct 22, 2021 at 5:57 AM Ferruh Yigit wrote: > > Jumbo offload is no more announced as capability, and > 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag is removed. > > This patch is also removing 'Jumbo frame' feature from documentation. > > Fixes: b563c1421282 ("ethdev: remove jumbo offload fla

[dpdk-dev] [PATCH 10/10] doc: updated release notes and mlx5 file

2021-10-22 Thread Francis Kelly
Provided further description within documentation regarding the RXP to CRSpace changes. Signed-off-by: Francis Kelly --- doc/guides/regexdevs/mlx5.rst | 2 +- doc/guides/rel_notes/release_21_11.rst | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/guides/regexde

[dpdk-dev] [PATCH 09/10] regex/mlx5: prevent QP double setup

2021-10-22 Thread Francis Kelly
From: Ady Agbarih When mlx5_regex_qp_setup() is called make sure the provided QP is not already setup. Signed-off-by: Ady Agbarih --- drivers/regex/mlx5/mlx5_regex_control.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/regex/mlx5/mlx5_regex_control.c b/drivers/regex/mlx5

[dpdk-dev] [PATCH 07/10] regex/mlx5: removed redundant rxp csr file

2021-10-22 Thread Francis Kelly
The mlx5_rxp_csrs.h file has been deprecated as its contents has now been moved to FW. Signed-off-by: Francis Kelly --- drivers/regex/mlx5/mlx5_regex.c | 1 - drivers/regex/mlx5/mlx5_regex_control.c | 1 - drivers/regex/mlx5/mlx5_rxp.c | 1 - drivers/regex/mlx5/mlx5_rxp.h

[dpdk-dev] [PATCH 08/10] regex/mlx5: fix uninitialized QP destroy

2021-10-22 Thread Francis Kelly
From: Ady Agbarih The number of QPs for a device are setup during the configuration phase, when the user calls rte_regexdev_configure(). The mlx5 regex driver then pre-allocates QPs, however those QPs are not setup/ready for sending jobs. The user has to configure each QP using rte_regexdev_

[dpdk-dev] [PATCH 04/10] regex/mlx5: remove regexp register read/write

2021-10-22 Thread Francis Kelly
From: Ady Agbarih Remove the set/query regexp register commands from devx. Remove functions that used these commands. Remove manual rules programming. Signed-off-by: Ady Agbarih --- drivers/regex/mlx5/mlx5_regex.c | 28 -- drivers/regex/mlx5/mlx5_regex.h | 4 - drivers/regex/mlx5/

Re: [dpdk-dev] [PATCH v4 0/8] port ioatfwd app to dmadev

2021-10-22 Thread Thomas Monjalon
14/10/2021 11:53, Kevin Laatz: > This patchset first adds some additional command line options to the > existing ioatfwd application to enhance usability. Please could you rebase? I see some errors about max_rx_pkt_len and DEV_RX_OFFLOAD_JUMBO_FRAME. Cc Ferruh for help if needed.

[dpdk-dev] [PATCH 02/10] regex/mlx5: add cleanup code

2021-10-22 Thread Francis Kelly
From: Ori Kam When stopping the device we should release all data allocated. This commit add this cleanup logic. Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 14 ++ drivers/regex/mlx5/mlx5_regex.h | 1 + drivers/regex/mlx5/mlx5_regex_control.c | 20

[dpdk-dev] [PATCH 06/10] regex/mlx5: remove start/stop engine API

2021-10-22 Thread Francis Kelly
From: Ady Agbarih Remove the engine start/stop DevX commands, as they have been deprecated and moved to FW. Signed-off-by: Ady Agbarih --- drivers/regex/mlx5/mlx5_regex.c | 5 drivers/regex/mlx5/mlx5_regex.h | 2 -- drivers/regex/mlx5/mlx5_regex_devx.c | 42 ---

[dpdk-dev] [PATCH 05/10] regex/mlx5: move RXP to CrSpace

2021-10-22 Thread Francis Kelly
From: Ady Agbarih Add patch for programming the regex database through rof file, using the firmware instead of manually through the software. No need to setup the DB anymore, the regex-daemon is responsible for that always. In the new flow the regex driver only has to program rof rules by using s

[dpdk-dev] [PATCH 03/10] common/mlx5: update regex DevX commands

2021-10-22 Thread Francis Kelly
From: Ady Agbarih This patch modifies the SET_REGEXP_PARAMS devx command as follows: Remove DB setup devx command. The command is no longer needed in DPDK, it will always be invoked by the regex-daemon. Add new devx command, for programming rof rules for a specific engine. The command

[dpdk-dev] [PATCH 01/10] common/mlx5: update PRM definitions for regex availability

2021-10-22 Thread Francis Kelly
From: Ady Agbarih Update PRM hca capabilities definitions as follows: regexp_version field added - specifies whether BF2 or BF3 regexp field removed regexp_params field moved regexp_log_crspace_size field removed regexp_mmo added - specifies if using regex mmo wqe is supported Allow regex only i

Re: [dpdk-dev] [PATCH v8 00/12] dma: add dmadev driver for ioat devices

2021-10-22 Thread Thomas Monjalon
18/10/2021 14:38, Conor Walsh: > This patchset adds a dmadev driver and associated documentation to support > Intel QuickData Technology devices, part of the Intel I/O Acceleration > Technology (Intel I/OAT). This driver is intended to ultimately replace > the current IOAT part of the IOAT rawdev d

Re: [dpdk-dev] [PATCH v11 00/16] add dmadev driver for idxd devices

2021-10-22 Thread Thomas Monjalon
20/10/2021 18:29, Kevin Laatz: > This patchset adds a dmadev driver and associated documentation to support > Intel Data Streaming Accelerator devices. This driver is intended to > ultimately replace the current IDXD part of the IOAT rawdev driver. Applied (with notified fix), thanks.

Re: [dpdk-dev] [PATCH] devtools: fix letter case check in commit title

2021-10-22 Thread Thomas Monjalon
18/10/2021 11:55, Thomas Monjalon: > The prefix (before the colon) of the title is lowercase. > The check of uppercase/lowercase in the commit title > was supposed to apply after the colon, > but some greps were not limited to the exact word. > So in the case of "test/dma: add basic dmadev instance

Re: [dpdk-dev] [PATCH] ethdev: avoid usage of ULL for 64-bit unsigned constants

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 12:20 PM, Andrew Rybchenko wrote: Use UINT64_C() macro instead. Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

[dpdk-dev] [dpdk-dev v4 9/9] crypto/qat: add gen specific implementation

2021-10-22 Thread Fan Zhang
This patch replaces the mixed QAT symmetric and asymmetric support implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/meson.build

[dpdk-dev] [dpdk-dev v4 8/9] crypto/qat: add gen specific data and function

2021-10-22 Thread Fan Zhang
This patch adds the symmetric and asymmetric crypto data structure and function prototypes for different QAT generations. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/crypto/qat/README |7 - drivers/crypto/qat/meson.build

[dpdk-dev] [dpdk-dev v4 7/9] crypto/qat: unified device private data structure

2021-10-22 Thread Fan Zhang
This patch unifies the QAT symmetric and asymmetric device private data structures and functions. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 2 +- drivers/common/qat/qat_common.c | 15 ++ drivers/common/qat/qat_

[dpdk-dev] [dpdk-dev v4 6/9] compress/qat: add gen specific implementation

2021-10-22 Thread Fan Zhang
This patch replaces the mixed QAT compression support implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Adam Dybkowski Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/meson.bu

[dpdk-dev] [dpdk-dev v4 5/9] compress/qat: add gen specific data and function

2021-10-22 Thread Fan Zhang
This patch adds the compression data structure and function prototypes for different QAT generations. Signed-off-by: Adam Dybkowski Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/dev/qat_dev_gen1.c | 2 - .../common/qat/qat_adf/icp_

[dpdk-dev] [dpdk-dev v4 4/9] common/qat: add gen specific queue implementation

2021-10-22 Thread Fan Zhang
This patch replaces the mixed QAT queue pair configuration implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/dev/qat_dev_gen1.c | 190 +

[dpdk-dev] [dpdk-dev v4 3/9] common/qat: add gen specific queue pair function

2021-10-22 Thread Fan Zhang
This patch adds the queue pair data structure and function prototypes for different QAT generations. Signed-off-by: Fan Zhang --- drivers/common/qat/qat_qp.c | 3 ++ drivers/common/qat/qat_qp.h | 103 2 files changed, 71 insertions(+), 35 deletions(-) diff

[dpdk-dev] [dpdk-dev v4 2/9] common/qat: add gen specific device implementation

2021-10-22 Thread Fan Zhang
This patch replaces the mixed QAT device configuration implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/dev/qat_dev_gen1.c | 66 + dr

[dpdk-dev] [dpdk-dev v4 1/9] common/qat: add gen specific data and function

2021-10-22 Thread Fan Zhang
This patch adds the data structure and function prototypes for different QAT generations. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/qat_common.h | 14 -- drivers/common/qat/qat_device.c | 4 drivers/common/qat/qat_device

[dpdk-dev] [dpdk-dev v4 0/9] drivers/qat: isolate implementations of qat generations

2021-10-22 Thread Fan Zhang
This patchset introduces new qat driver structure and updates existing symmetric crypto qat PMD. The purpose of the change is to isolate QAT generation specific implementations from one to another. It is expected the changes to the specific generation driver code does minimum impact to other gene

Re: [dpdk-dev] [PATCH v2] ethdev: replace single bit masks with macros

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 8:30 AM, Andrew Rybchenko wrote: The macros RTE_BIT32 and RTE_BIT64 are used to replace single bit masks. Do not switch VLAN offload flags since type is not fixed size. Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v7] ethdev: add namespace

2021-10-22 Thread Somnath Kotur
On Fri, 22 Oct 2021, 16:58 Andrew Rybchenko, wrote: > On 10/22/21 2:03 PM, Ferruh Yigit wrote: > > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > > LGTM except two lines duplicated above. > > > wa

Re: [dpdk-dev] [PATCH v7] ethdev: add namespace

2021-10-22 Thread Ferruh Yigit
On Fri, 22 Oct 2021, 16:58 Andrew Rybchenko, mailto:andrew.rybche...@oktetlabs.ru>> wrote: On 10/22/21 2:03 PM, Ferruh Yigit wrote: > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible

[dpdk-dev] [v3] mempool: add telemetry endpoint for mempool info

2021-10-22 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint for mempool info. Signed-off-by: Gowrishankar Muthukrishnan Reviewed-by: Bruce Richardson --- v3: - added explicit telemetry dependency in meson --- lib/mempool/meson.build | 2 +- lib/mempool/rte_mempool.c | 84 +++ 2 files changed

Re: [dpdk-dev] [PATCH] test/bonding: fix failures after hiding ethdev internal structures

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 2:47 PM, Ferruh Yigit wrote: On 10/22/2021 2:26 PM, Konstantin Ananyev wrote: link bounding auto-test internally creates emulated ethdev. Some tests change Rx/Tx functions of this emulated device on the fly: by directly modifying rte_eth_dev fields and without doing stop/start for

[dpdk-dev] [v7] crypto/cnxk: add telemetry endpoints to cryptodev

2021-10-22 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to cryptodev. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-19601 ("cryptodev: add telemetry callbacks") Depends-on: patch-19915 ("cryptodev: add telemetry endpoint for cryptodev capabilities") v7: - compilation issue in CI fixed --- .../crypto/cnxk/c

Re: [dpdk-dev] [RFC PATCH 0/1] Dataplane Workload Accelerator library

2021-10-22 Thread Elena Agostini
On Tue, Oct 19, 2021 at 21:36 Jerin Jacob wrote: > On Wed, Oct 20, 2021 at 12:38 AM Thomas Monjalon wrote: > > > > 19/10/2021 20:14, jer...@marvell.com: > > > Definition of Dataplane Workload Accelerator > > > > > > Dataplane Workload Accelerator(DWA)

Re: [dpdk-dev] [PATCH v11 02/16] dma/idxd: add skeleton for VFIO based DSA device

2021-10-22 Thread Thomas Monjalon
20/10/2021 18:29, Kevin Laatz: > --- /dev/null > +++ b/drivers/dma/idxd/version.map > @@ -0,0 +1,3 @@ > +DPDK_21 { > + local: *; > +}; Should be DPDK_22 Will fix while merging.

Re: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 4:20 PM, Ferruh Yigit wrote: On 10/22/2021 3:10 PM, Jiang, YuX wrote: -Original Message- From: dev On Behalf Of Ferruh Yigit Sent: 2021年10月22日 20:57 To: Wang, Haiyue ; Xing, Beilei ; Wu, Jingjing ; Yang, Qiming ; Zhang, Qi Z ; Hyong Youb Kim ; Michal Krawczyk ; Andrew Rybc

Re: [dpdk-dev] [PATCH] net/af_xdp: set the max Rx pktlen value correctly

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 3:07 PM, Ciara Loftus wrote: Commit 1bb4a528c41f ("ethdev: fix max Rx packet length") clarified the expected usage of the max_rx_pktlen and max_mtu values and implemented some extra checks on these values to ensure they are sane. After this, the AF_XDP PMD fails to initialise. The v

Re: [dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files

2021-10-22 Thread Thomas Monjalon
22/10/2021 17:07, Stephen Hemminger: > On Fri, 22 Oct 2021 15:43:58 +0200 > Thomas Monjalon wrote: > > > 20/10/2021 23:42, Stephen Hemminger: > > > +++ b/lib/pcapng/meson.build > > > +version = 1 > > > > What is the meaning of this version in meson? Is it used somewhere? > > No just copy/past

Re: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 3:10 PM, Jiang, YuX wrote: -Original Message- From: dev On Behalf Of Ferruh Yigit Sent: 2021年10月22日 20:57 To: Wang, Haiyue ; Xing, Beilei ; Wu, Jingjing ; Yang, Qiming ; Zhang, Qi Z ; Hyong Youb Kim ; Michal Krawczyk ; Andrew Rybchenko ; Somnath Kotur Cc: Yigit, Ferruh ; d

Re: [dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files

2021-10-22 Thread Stephen Hemminger
On Fri, 22 Oct 2021 15:43:58 +0200 Thomas Monjalon wrote: > 20/10/2021 23:42, Stephen Hemminger: > > +++ b/lib/pcapng/meson.build > > +version = 1 > > What is the meaning of this version in meson? Is it used somewhere? > > > No just copy/paste from some other meson file.

Re: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag

2021-10-22 Thread Jiang, YuX
> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: 2021年10月22日 20:57 > To: Wang, Haiyue ; Xing, Beilei > ; Wu, Jingjing ; Yang, Qiming > ; Zhang, Qi Z ; Hyong Youb > Kim ; Michal Krawczyk ; Andrew > Rybchenko ; Somnath Kotur > > Cc: Yigit, Ferruh ; dev@dpdk.org > Subject:

[dpdk-dev] [PATCH] net/af_xdp: set the max Rx pktlen value correctly

2021-10-22 Thread Ciara Loftus
Commit 1bb4a528c41f ("ethdev: fix max Rx packet length") clarified the expected usage of the max_rx_pktlen and max_mtu values and implemented some extra checks on these values to ensure they are sane. After this, the AF_XDP PMD fails to initialise. The value for max_rx_pktlen which represents the m

Re: [dpdk-dev] [PATCH] test/bonding: fix failures after hiding ethdev internal structures

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 2:47 PM, Ferruh Yigit wrote: On 10/22/2021 2:26 PM, Konstantin Ananyev wrote: link bounding auto-test internally creates emulated ethdev. Some tests change Rx/Tx functions of this emulated device on the fly: by directly modifying rte_eth_dev fields and without doing stop/start for

Re: [dpdk-dev] [PATCH v15 00/12] Packet capture framework update

2021-10-22 Thread Thomas Monjalon
20/10/2021 23:42, Stephen Hemminger: > This patch set is a more complete version of the the enhanced > packet capture support described last year. > > The new capture library and utility are: > - faster avoids lots of extra I/O, does bursting, etc. > - gives more information (multiple ports, q

Re: [dpdk-dev] [PATCH] test/bonding: fix failures after hiding ethdev internal structures

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 2:26 PM, Konstantin Ananyev wrote: link bounding auto-test internally creates emulated ethdev. Some tests change Rx/Tx functions of this emulated device on the fly: by directly modifying rte_eth_dev fields and without doing stop/start for these devices. As now ethdev uses rte_eth_fp

Re: [dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files

2021-10-22 Thread Thomas Monjalon
20/10/2021 23:42, Stephen Hemminger: > +++ b/lib/pcapng/meson.build > +version = 1 What is the meaning of this version in meson? Is it used somewhere?

Re: [dpdk-dev] [PATCH v7 1/5] net/virtio: implement rte_power_monitor API

2021-10-22 Thread David Hunt
On 18/10/2021 3:16 PM, Miao Li wrote: This patch implements rte_power_monitor API in virtio PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value

Re: [dpdk-dev] [RFC PATCH 0/1] Dataplane Workload Accelerator library

2021-10-22 Thread Jerin Jacob
On Fri, Oct 22, 2021 at 5:30 PM Elena Agostini wrote: > > On Tue, Oct 19, 2021 at 21:36 Jerin Jacob wrote: > > > > > On Wed, Oct 20, 2021 at 12:38 AM Thomas Monjalon > > wrote: > > > > > > > > 19/10/2021 20:14, jer...@marvell.com: > > > > > Definition of Dataplane Workload Accelerator > > > > >

[dpdk-dev] [Bug 833] link_bonding_autotest fails on subsequent runs

2021-10-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=833 Bug ID: 833 Summary: link_bonding_autotest fails on subsequent runs Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: minor

Re: [dpdk-dev] [PATCH] ethdev: forbid MTU set before device configure

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 2:21 PM, Ferruh Yigit wrote: On 10/22/2021 11:18 AM, Andrew Rybchenko wrote: From: Ivan Ilchenko rte_eth_dev_configure() always sets MTU to either dev_conf.rxmode.mtu or RTE_ETHER_MTU if application doesn't provide the value. So, there is no point to allow rte_eth_dev_set_mtu() b

[dpdk-dev] [PATCH] test/bonding: fix failures after hiding ethdev internal structures

2021-10-22 Thread Konstantin Ananyev
link bounding auto-test internally creates emulated ethdev. Some tests change Rx/Tx functions of this emulated device on the fly: by directly modifying rte_eth_dev fields and without doing stop/start for these devices. As now ethdev uses rte_eth_fp_ops[] for fast-path functions, these direct change

Re: [dpdk-dev] [PATCH] ethdev: forbid MTU set before device configure

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 11:18 AM, Andrew Rybchenko wrote: From: Ivan Ilchenko rte_eth_dev_configure() always sets MTU to either dev_conf.rxmode.mtu or RTE_ETHER_MTU if application doesn't provide the value. So, there is no point to allow rte_eth_dev_set_mtu() before since set value will be overwritten on

[dpdk-dev] [PATCH] net/virtio: fix link update in speed feature case

2021-10-22 Thread Andrew Rybchenko
From: Ivan Ilchenko Link update callback reports speed/duplex based on data filled on device initialization. This is wrong in case of VIRTIO_NET_F_SPEED_DUPLEX is negotiated since link could be down at this time. Fix this function to actually update the HW data in this case with respect to the fa

[dpdk-dev] [PATCH v4 6/8] net/mlx5: fix internal root table flow priroity

2021-10-22 Thread Xueming Li
When creating internal transfer flow on root table with lowerest priority, the flow was created with max UINT32_MAX priority. It is wrong since the flow is created in kernel and max priority supported is 16. This patch fixes this by adding internal flow check. Fixes: 5f8ae44dd454 ("net/mlx5: enl

[dpdk-dev] [PATCH v4 7/8] net/mlx5: enable DevX Tx queue creation

2021-10-22 Thread Xueming Li
Verbs API does not support Infiniband device port number larger 255 by design. To support more representors on a single Infiniband device DevX API should be engaged. While creating Send Queue (SQ) object with Verbs API, the PMD assigned IB device port attribute and kernel created the default miss

[dpdk-dev] [PATCH v4 8/8] net/mlx5: check DevX to support more Verbs ports

2021-10-22 Thread Xueming Li
Verbs API doesn't support device port number larger than 255 by design. To support more VF or SubFunction port representors, forces DevX API check when max Verbs device link ports larger than 255. Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 1

[dpdk-dev] [PATCH v4 5/8] net/mlx5: supports flow item of normal Tx queue

2021-10-22 Thread Xueming Li
Extends txq flow pattern to support both hairpin and regular txq. Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/

[dpdk-dev] [PATCH v4 2/8] net/mlx5: use netlink when IB port greater than 255

2021-10-22 Thread Xueming Li
IB spec doesn't allow 255 ports on a single HCA, port number of 256 was cast to u8 value 0 which invalid to ibv_query_port() This patch invokes Netlink api to query port state when port number greater than 255. Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux

[dpdk-dev] [PATCH v4 3/8] net/mlx5: improve Verbs flow priority discover for scalable

2021-10-22 Thread Xueming Li
To detect number flow Verbs flow priorities, PMD try to create Verbs flows in different priority. While Verbs is not designed to support ports larger than 255. When DevX supported by kernel driver, 16 Verbs priorities must be supported, no need to create Verbs flows. Signed-off-by: Xueming Li Ac

[dpdk-dev] [PATCH v4 1/8] common/mlx5: add netlink API to get RDMA port state

2021-10-22 Thread Xueming Li
Introduce netlink API to get rdma port state. Port state is restrieved based on RDMA device name and port index. Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/linux/meson.build | 2 + drivers/common/mlx5/linux/mlx5_nl.c | 136 +++--- d

[dpdk-dev] [PATCH v4 0/8] net/mlx5: support more than 255 representors

2021-10-22 Thread Xueming Li
This patch set supports representor number of a PF to be more than 255. CX6 and current OFED driver supports maxium 512 SFs. CX5 supports max 255 SFs. v2: - fixed FDB root table flow priority - add error check to Netlink port state API - commit log update and other minor fixes v3: - fix compil

[dpdk-dev] [PATCH v4 4/8] net/mlx5: support E-Switch manager egress traffic match

2021-10-22 Thread Xueming Li
For egress packet on representor, the vport ID in transport domain is E-Switch manager vport ID since representor shares resources of E-Switch manager. E-Switch manager vport ID and Tx queue internal device index are used to match representor egress packet. This patch adds flow item port ID match

Re: [dpdk-dev] [PATCH v7] ethdev: add namespace

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 12:28 PM, Andrew Rybchenko wrote: On 10/22/21 2:03 PM, Ferruh Yigit wrote: Add 'RTE_ETH' namespace to all enums & macros in a backward compatible Add 'RTE_ETH' namespace to all enums & macros in a backward compatible LGTM except two lines duplicated above. Thanks Andrew, I wil

[dpdk-dev] [v6] crypto/cnxk: add telemetry endpoints to cryptodev

2021-10-22 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to cryptodev. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-19601 ("cryptodev: add telemetry callbacks") Depends-on: patch-19915 ("cryptodev: add telemetry endpoint for cryptodev capabilities") v6: - checkpatch fixes. --- .../crypto/cnxk/cnxk_cryptode

[dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag

2021-10-22 Thread Ferruh Yigit
After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, drivers give jumbo frame decisions based on MTU value checks, but some of the checks were wrong by mistake, causing device initialization to fail, fixing them. Fixes: b563c1421282 ("ethdev: remove jumbo offload flag") Signed-off-by: Ferruh Yigit ---

[dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature

2021-10-22 Thread Ferruh Yigit
Jumbo offload is no more announced as capability, and 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag is removed. This patch is also removing 'Jumbo frame' feature from documentation. Fixes: b563c1421282 ("ethdev: remove jumbo offload flag") Signed-off-by: Ferruh Yigit Acked-by: Andrew Rybchenko ---

[dpdk-dev] [v3] cryptodev: add telemetry endpoint for cryptodev capabilities

2021-10-22 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint for cryptodev capabilities. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-19601 ("cryptodev: add telemetry callbacks") v3: - checkpatch fixes. --- lib/cryptodev/rte_cryptodev.c | 65 +++ 1 file changed, 65 insertions(+)

[dpdk-dev] [v5] crypto/cnxk: add telemetry endpoints to cryptodev

2021-10-22 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to cryptodev. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-19601 ("cryptodev: add telemetry callbacks") Depends-on: patch-19913 ("cryptodev: add telemetry endpoint for cryptodev capabilities") v5: - endpoint renamed as caps. --- .../crypto/cnxk/cnxk_

Re: [dpdk-dev] [PATCH v7 2/5] vhost: implement rte_power_monitor API

2021-10-22 Thread David Hunt
On 19/10/2021 5:38 AM, Xia, Chenbo wrote: -Original Message- From: Li, Miao Sent: Monday, October 18, 2021 10:17 PM To: dev@dpdk.org Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Li, Miao Subject: [PATCH v7 2/5] vhost: implement rte_power_monitor API This patch defines rte_vhost_powe

[dpdk-dev] [v2] cryptodev: add telemetry endpoint for cryptodev capabilities

2021-10-22 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint for cryptodev capabilities. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-19601 ("cryptodev: add telemetry callbacks") v2: - renamed endpoint as caps. --- lib/cryptodev/rte_cryptodev.c | 65 +++ 1 file changed, 65 insert

Re: [dpdk-dev] [PATCH] ethdev: fix removing jumbo offload flag

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 1:23 PM, Andrew Rybchenko wrote: On 10/22/21 3:17 PM, Ferruh Yigit wrote: After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, jumbo frame decision is given by MTU value checks, but some of the checks were wrong by mistake, causing device initialization to fail, fixing them. Also removi

Re: [dpdk-dev] [PATCH] ethdev: fix removing jumbo offload flag

2021-10-22 Thread Andrew Rybchenko
On 10/22/21 3:17 PM, Ferruh Yigit wrote: > After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, jumbo frame decision is > given by MTU value checks, but some of the checks were wrong by mistake, > causing device initialization to fail, fixing them. > > Also removing 'Jumbo frame' feature. Sorry, but I

[dpdk-dev] [PATCH] ethdev: fix removing jumbo offload flag

2021-10-22 Thread Ferruh Yigit
After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, jumbo frame decision is given by MTU value checks, but some of the checks were wrong by mistake, causing device initialization to fail, fixing them. Also removing 'Jumbo frame' feature. Fixes: b563c1421282 ("ethdev: remove jumbo offload flag") Signe

Re: [dpdk-dev] [PATCH v7 3/5] net/vhost: implement rte_power_monitor API

2021-10-22 Thread David Hunt
On 19/10/2021 5:39 AM, Xia, Chenbo wrote: -Original Message- From: Li, Miao Sent: Monday, October 18, 2021 10:17 PM To: dev@dpdk.org Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Li, Miao Subject: [PATCH v7 3/5] net/vhost: implement rte_power_monitor API This patch implements rte_pow

[dpdk-dev] [PATCH v2] common/cnxk: support BPHY telemetry

2021-10-22 Thread Tomasz Duszynski
Add initial support for baseband telemetry. Signed-off-by: Tomasz Duszynski --- v2: - make bphy telemetry available only on platforms supporting baseband - use platform types where possible - remove unused header drivers/common/cnxk/cnxk_telemetry_bphy.c | 52 +++ drivers/co

Re: [dpdk-dev] [PATCH v7 4/5] power: modify return of queue_stopped

2021-10-22 Thread David Hunt
On 21/10/2021 5:48 PM, Ferruh Yigit wrote: On 10/18/2021 3:16 PM, Miao Li wrote: Since some vdevs like virtio and vhost do not support rxq_info_get and queue state inquiry, the error return value -ENOTSUP need to be ignored when queue_stopped cannot get rx queue information and rx queue state.

Re: [dpdk-dev] [PATCH v7 5/5] examples/l3fwd-power: support virtio/vhost

2021-10-22 Thread David Hunt
On 19/10/2021 5:39 AM, Xia, Chenbo wrote: -Original Message- From: Li, Miao Sent: Monday, October 18, 2021 10:17 PM To: dev@dpdk.org Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Li, Miao Subject: [PATCH v7 5/5] examples/l3fwd-power: support virtio/vhost In l3fwd-power, there is defa

Re: [dpdk-dev] [PATCH v7 4/6] ethdev: remove jumbo offload flag

2021-10-22 Thread Andrew Rybchenko
On 10/22/21 2:25 PM, Ferruh Yigit wrote: > On 10/21/2021 1:43 AM, Thomas Monjalon wrote: >> 18/10/2021 15:48, Ferruh Yigit: >>> Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. >> [...] >>> --- a/doc/guides/nics/features.rst >>> +++ b/doc/guides/nics/features.rst >>> @@ -165,8 +165,7 @@ Jumbo fr

  1   2   >