Re: [dpdk-dev] [PATCH v6 1/5] ethdev: introduce shared Rx queue

2021-10-17 Thread Andrew Rybchenko
On 10/15/21 1:54 PM, Xueming(Steven) Li wrote: > On Fri, 2021-10-15 at 12:28 +0300, Andrew Rybchenko wrote: >> On 10/12/21 5:39 PM, Xueming Li wrote: >>> In current DPDK framework, each Rx queue is pre-loaded with mbufs to >>> save incoming packets. For some PMDs, when number of representors scale

Re: [dpdk-dev] [PATCH] maintainers: update for NTB

2021-10-17 Thread Li, Xiaoyun
> -Original Message- > From: Guo, Junfeng > Sent: Monday, October 18, 2021 14:33 > To: Li, Xiaoyun ; Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org; Guo, Junfeng > Subject: [PATCH] maintainers: update for NTB > > Remove Xiaoyun and add Junfeng. > > Signed-off-by: Junfeng Guo > --- >

Re: [dpdk-dev] [RFC] eal/arm: remove CASP constraints for GCC

2021-10-17 Thread Ruifeng Wang
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, October 4, 2021 6:03 PM > To: jer...@marvell.com; Ruifeng Wang > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [RFC] eal/arm: remove CASP constraints for GCC > > From: Pavan Nikhilesh > > GCC now assigns e

[dpdk-dev] [PATCH] maintainers: update for NTB

2021-10-17 Thread Junfeng Guo
Remove Xiaoyun and add Junfeng. Signed-off-by: Junfeng Guo --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ed8becce85..5d486ce3bc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1325,8 +1325,8 @@ F: drivers/raw/octeontx2_ep/ F:

[dpdk-dev] [Bug 829] [build]Meson build 'enic' failed on OpenSuse15.2 with GCC 7.5.0/clang 9.0.1

2021-10-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=829 Bug ID: 829 Summary: [build]Meson build 'enic' failed on OpenSuse15.2 with GCC 7.5.0/clang 9.0.1 Product: DPDK Version: 21.11 Hardware: All OS: All Statu

[dpdk-dev] [PATCH v7 5/5] examples/l3fwd-power: support virtio/vhost

2021-10-17 Thread Miao Li
In l3fwd-power, there is default port configuration which requires RSS and IPV4/UDP/TCP checksum. Once device does not support these, the l3fwd-power will exit and report an error. This patch updates the port configuration based on device capabilities after getting the device information to support

[dpdk-dev] [PATCH v7 4/5] power: modify return of queue_stopped

2021-10-17 Thread Miao Li
Since some vdevs like virtio and vhost do not support rxq_info_get and queue state inquiry, the error return value -ENOTSUP need to be ignored when queue_stopped cannot get rx queue information and rx queue state. This patch changes the return value of queue_stopped when rte_eth_rx_queue_info_get r

[dpdk-dev] [PATCH v7 3/5] net/vhost: implement rte_power_monitor API

2021-10-17 Thread Miao Li
This patch implements rte_power_monitor API in vhost PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and vhost_get_mo

[dpdk-dev] [PATCH v7 2/5] vhost: implement rte_power_monitor API

2021-10-17 Thread Miao Li
This patch defines rte_vhost_power_monitor_cond which is used to pass some information to vhost driver. The information is including the address to monitor, the expected value, the mask to extract value read from 'addr', the value size of monitor address, the match flag used to distinguish the valu

[dpdk-dev] [PATCH v7 1/5] net/virtio: implement rte_power_monitor API

2021-10-17 Thread Miao Li
This patch implements rte_power_monitor API in virtio PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and virtio_get_

[dpdk-dev] [PATCH v7 0/5] Implement rte_power_monitor API in virtio/vhost PMD

2021-10-17 Thread Miao Li
This patchset implements rte_power_monitor API in virtio and vhost PMD to reduce power consumption when no packet come in. This API can be called and tested in l3fwd-power after adding vhost and virtio support in l3fwd-power and ignoring the rx queue information check in queue_stopped(). v7: -fix

Re: [dpdk-dev] [PATCH v8 6/7] net/iavf: add watchdog for VFLR

2021-10-17 Thread Wu, Jingjing
> -Original Message- > From: Nicolau, Radu > Sent: Friday, October 15, 2021 6:15 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Doherty, Declan ; Sinha, Abhijit > ; Zhang, Qi Z ; Richardson, > Bruce > ; Ananyev, Konstantin > ; > Nicolau, Radu > Subject: [PATCH v8 6/7] net/

[dpdk-dev] [PATCH v3 2/2] security: add reserved bitfields

2021-10-17 Thread Akhil Goyal
In struct rte_security_ipsec_sa_options, for every new option added, there is an ABI breakage, to avoid, a reserved_opts bitfield is added to for the remaining bits available in the structure. Now for every new sa option, these reserved_opts can be reduced and new option can be added. Signed-off-b

[dpdk-dev] [PATCH v3 1/2] security: hide internal API

2021-10-17 Thread Akhil Goyal
rte_security_dynfield_register() is an internal API to be used by the driver, hence moving it to internal. Signed-off-by: Akhil Goyal Acked-by: Konstantin Ananyev Acked-by: Ray Kinsella --- lib/security/rte_security_driver.h | 2 +- lib/security/version.map | 7 ++- 2 files chang

Re: [dpdk-dev] [PATCH v4 1/2] lib/cmdline: release cl when cmdline exit

2021-10-17 Thread Peng, ZhihongX
> -Original Message- > From: Olivier Matz > Sent: Friday, October 15, 2021 8:58 PM > To: Peng, ZhihongX > Cc: dmitry.kozl...@gmail.com; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v4 1/2] lib/cmdline: release cl when cmdline exit > > On Wed, Oct 13, 2021 at 01:52:22AM +, zhih

Re: [dpdk-dev] [PATCH] app/testpmd: fix l4 sw csum over multi segments

2021-10-17 Thread Li, Xiaoyun
> -Original Message- > From: dev On Behalf Of Li, Xiaoyun > Sent: Monday, October 18, 2021 11:17 > To: Stephen Hemminger > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix l4 sw csum over multi > segments > > Hi > > > -Original M

Re: [dpdk-dev] [PATCH] app/testpmd: fix l4 sw csum over multi segments

2021-10-17 Thread Li, Xiaoyun
Hi > -Original Message- > From: Stephen Hemminger > Sent: Monday, October 18, 2021 11:00 > To: Li, Xiaoyun > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix l4 sw csum over multi > segments > > On Fri, 15 Oct 2021 13:13:06 +0800 > Xia

Re: [dpdk-dev] [PATCH] app/testpmd: fix l4 sw csum over multi segments

2021-10-17 Thread Stephen Hemminger
On Fri, 15 Oct 2021 13:13:06 +0800 Xiaoyun Li wrote: > + /* When sw csum is needed, multi-segs needs a buf to contain > + * the whole packet for later UDP/TCP csum calculation. > + */ > + if (m->nb_segs > 1 && !(tx_ol_flags & PKT_TX_TCP_SEG) && >

[dpdk-dev] [PATCH v2] app/testpmd: fix l4 sw csum over multi segments

2021-10-17 Thread Xiaoyun Li
In csum forwarding mode, software UDP/TCP csum calculation only takes the first segment into account while using the whole packet length so the calculation will read invalid memory region with multi-segments packets and will get wrong value. This patch fixes this issue. Fixes: af75078fece3 ("first

Re: [dpdk-dev] [PATCH] app/testpmd: fix l4 sw csum over multi segments

2021-10-17 Thread Li, Xiaoyun
Hi > -Original Message- > From: David Marchand > Sent: Friday, October 15, 2021 16:10 > To: Li, Xiaoyun > Cc: Yigit, Ferruh ; dev ; dpdk stable > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix l4 sw csum over multi > segments > > Hello, > > On Fri, Oct 15, 2021 at 7:27 AM Xiaoyun

Re: [dpdk-dev] [PATCH v6 0/5] Implement rte_power_monitor API in virtio/vhost PMD

2021-10-17 Thread Li, Miao
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Friday, October 15, 2021 8:58 PM > To: Li, Miao ; dev@dpdk.org > Cc: Xia, Chenbo > Subject: Re: [PATCH v6 0/5] Implement rte_power_monitor API in virtio/vhost > PMD > > Hi, > > On 10/15/21 19:09, Miao Li wrote: > > This patchset

Re: [dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring

2021-10-17 Thread Liu, Changpeng
I agree with Maxime, just add an error log doesn't help anything, there might be something wrong in other places, I don't have the context for this issue, if this can be reproduced in SPDK, I suggest to submit an issue to SPDK first. > -Original Message- > From: Xia, Chenbo > Sent: Thur

[dpdk-dev] [PATCH v3] net/vhost: merge vhost stats loop in vhost Tx/Rx

2021-10-17 Thread Gaoxiang Liu
To improve performance in vhost Tx/Rx, merge vhost stats loop. eth_vhost_tx has 2 loop of send num iteraion. It can be merge into one. eth_vhost_rx has the same issue as Tx. Signed-off-by: Gaoxiang Liu --- v2: * Fix coding style issues. v3: * add __rte_always_inline to vhost_update_single_pack

[dpdk-dev] [PATCH v2 1/1] net: fix aliasing issue in checksum computation

2021-10-17 Thread Georg Sauthoff
That means a superfluous cast is removed and aliasing through a uint8_t pointer is eliminated. NB: The C standard specifies that a unsigned char pointer may alias while the C standard doesn't include such requirement for uint8_t pointers. Also simplified the loop since a modern C compiler can spee

[dpdk-dev] [PATCH v2 0/1] net: fix aliasing issue in checksum computation

2021-10-17 Thread Georg Sauthoff
The current __rte_raw_cksum() function violates the C strict-aliasing rules since it uses a uint8_t pointer to access a trailing byte. This patch also fixes a superfluous cast, i.e.: uintptr_t ptr = (uintptr_t)buf; typedef uint16_t __attribute__((__may_alias__)) u16_p; con

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion for L2/L3 VXLAN

2021-10-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Lior Margalit > Sent: Thursday, October 14, 2021 9:22 AM > To: Matan Azrad > Cc: Lior Margalit ; dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion for L2/L3 VXLAN > > The RSS expansion algorithm i

Re: [dpdk-dev] [PATCH v26 0/6] support dmadev

2021-10-17 Thread Thomas Monjalon
13/10/2021 14:24, Chengwen Feng: > This patch set contains six patch for new add dmadev. > > Chengwen Feng (6): > dmadev: introduce DMA device library > dmadev: add control plane API support > dmadev: add data plane API support > dmadev: add multi-process support > dma/skeleton: introduc

Re: [dpdk-dev] [EXT] [PATCH v5 00/15] crypto: add raw vector support in DPAAx

2021-10-17 Thread Akhil Goyal
> This patch series adds support for raw vector API in dpaax_sec drivers This > also enhances the raw vector APIs to support OOP and security protocol > support. > > v2: fix aesni compilation and add release notes. > v3: ignore it > v4: fix the tot_length patch as per Konstantin's comments > v5: a

[dpdk-dev] [PATCH v5 15/15] test/crypto: add raw API support in 5G algos

2021-10-17 Thread Hemant Agrawal
This patch add support for RAW API testing with ZUC and SNOW test cases. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 57 ++- 1 file changed, 51 insertions(+), 6 deletions(-) diff --git a/app/test/test_cryptode

[dpdk-dev] [PATCH v5 14/15] test/crypto: add raw API test for dpaax

2021-10-17 Thread Hemant Agrawal
This patch add support for raw API tests for dpaa_sec and dpaa2_sec platforms. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 116 +++--- 1 file changed, 109 insertions(+), 7 deletions(-) diff --git a/app/test/test_c

[dpdk-dev] [PATCH v5 13/15] crypto/dpaa_sec: support AEAD and proto with raw APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh This add support for AEAD and proto offload with raw APIs for dpaa_sec driver. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec_raw_dp.c | 293 ++ 1 file changed, 293 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec_raw_d

[dpdk-dev] [PATCH v5 12/15] crypto/dpaa_sec: support authonly and chain with raw APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh This patch improves the raw vector support in dpaa_sec driver for authonly and chain usecase. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec.h| 3 +- drivers/crypto/dpaa_sec/dpaa_sec_raw_dp.c | 296 +- 2 files changed, 28

[dpdk-dev] [PATCH v5 11/15] crypto/dpaa_sec: support raw datapath APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh This patch add raw vector API framework for dpaa_sec driver. Signed-off-by: Gagandeep Singh --- doc/guides/rel_notes/release_21_11.rst| 1 + drivers/crypto/dpaa_sec/dpaa_sec.c| 23 +- drivers/crypto/dpaa_sec/dpaa_sec.h| 39 +- drivers/crypto/dpaa_s

[dpdk-dev] [PATCH v5 10/15] crypto/dpaa2_sec: enhance error checks with raw buffer APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh This patch improves error conditions and support of Wireless algos with raw buffers. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 31 - 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/crypto/dp

[dpdk-dev] [PATCH v5 09/15] crypto/dpaa2_sec: support OOP with raw buffer API

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh add support for out of order processing with raw vector APIs. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 1 + drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 156 +++- 2 files changed, 116 insertions(+), 41 deletions(-

[dpdk-dev] [PATCH v5 08/15] crypto/dpaa2_sec: support AEAD with raw buffer APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh add raw vector API support for AEAD algos. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 249 +--- 1 file changed, 214 insertions(+), 35 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c b/drivers/cr

[dpdk-dev] [PATCH v5 07/15] crypto/dpaa2_sec: support AUTHENC with raw buffer APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh This patch supports AUTHENC with raw buufer APIs Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 128 ++-- 1 file changed, 121 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c b/drive

[dpdk-dev] [PATCH v5 06/15] crypto/dpaa2_sec: support AUTH only with raw buffer APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh Auth only with raw buffer APIs has been supported in this patch. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 21 drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 114 ++-- 2 files changed, 108 insertions(+), 27 delet

[dpdk-dev] [PATCH v5 05/15] crypto/dpaa2_sec: support raw datapath APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh This path add framework for raw API support. The initial patch only test cipher only part. Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 13 +- drivers/

[dpdk-dev] [PATCH v5 04/15] crypto: fix raw process for multi-seg case

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh If no next segment available the “for” loop will fail and it still returns i+1 i.e. 2, which is wrong as it has filled only 1 buffer. Fixes: 7adf992fb9bf ("cryptodev: introduce CPU crypto API") Cc: marcinx.smoczyn...@intel.com Cc: sta...@dpdk.org Signed-off-by: Gagandeep S

[dpdk-dev] [PATCH v5 03/15] crypto: add dest_sgl in raw vector APIs

2021-10-17 Thread Hemant Agrawal
The structure rte_crypto_sym_vec is updated to add dest_sgl to support out of place processing. Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal Acked-by: Konstantin Ananyev --- doc/guides/rel_notes/deprecation.rst | 5 - doc/guides/rel_notes/release_21_11.rst | 5 - lib/cryptodev

[dpdk-dev] [PATCH v5 02/15] crypto: add total raw buffer length

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh The current crypto raw data vectors is extended to support rte_security usecases, where we need total data length to know how much additional memory space is available in buffer other than data length so that driver/HW can write expanded size data after encryption. Signed-o

[dpdk-dev] [PATCH v5 01/15] crypto: change sgl to src_sgl in vector

2021-10-17 Thread Hemant Agrawal
This patch renames the sgl to src_sgl to help differentiating between source and destination sgl. Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal Acked-by: Konstantin Ananyev --- app/test/test_cryptodev.c | 6 ++--- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 12 +---

[dpdk-dev] [PATCH v5 00/15] crypto: add raw vector support in DPAAx

2021-10-17 Thread Hemant Agrawal
This patch series adds support for raw vector API in dpaax_sec drivers This also enhances the raw vector APIs to support OOP and security protocol support. v2: fix aesni compilation and add release notes. v3: ignore it v4: fix the tot_length patch as per Konstantin's comments v5: address comments

Re: [dpdk-dev] [PATCH v4 01/14] eventdev: make driver interface as internal

2021-10-17 Thread Hemant Agrawal
For dpaax Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v4 05/14] drivers/event: invoke probing finish function

2021-10-17 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v2 2/4] mbuf: mark old VLAN offload flags as deprecated

2021-10-17 Thread Ajit Khaparde
On Sat, Oct 16, 2021 at 12:50 AM Andrew Rybchenko wrote: > > On 10/15/21 10:24 PM, Olivier Matz wrote: > > The flags PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT are > > marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated > > VLAN flags") (2017). But they were not using the RTE_DEPRECA

Re: [dpdk-dev] [PATCH v2 4/4] mbuf: add rte prefix to offload flags

2021-10-17 Thread Ajit Khaparde
On Sat, Oct 16, 2021 at 12:57 AM Andrew Rybchenko wrote: > > On 10/15/21 10:24 PM, Olivier Matz wrote: > > Fix the mbuf offload flags namespace by adding an RTE_ prefix to the > > name. The old flags remain usable, but a deprecation warning is issued > > at compilation. > > > > Signed-off-by: Oliv

Re: [dpdk-dev] [PATCH v2 0/6] Support MLX5 crypto driver on Windows

2021-10-17 Thread Matan Azrad
From: Tal Shnaiderman > Support the MLX5 crypto driver on Windows OS by moving the driver's > control path communication with the Kernel to be OS agnostic. > --- > Depends-on: series-19421 ("mlx5: sharing global MR cache between drivers") > > v2: Split build change for mlx5 only and the rest of

Re: [dpdk-dev] [PATCH] test/hash: use compiler atomics for sync

2021-10-17 Thread David Marchand
On Mon, Oct 4, 2021 at 8:15 PM Wang, Yipeng1 wrote: > New failure with MinGW > +-++--+---+ > | Environment | dpdk_meson_compile | dpdk_mingw64_compile | > dpdk_compile_spdk | > +=+=

Re: [dpdk-dev] [PATCH v2 2/5] ethdev: add capability to keep shared objects on restart

2021-10-17 Thread Ori Kam
Hi Dmitry. > -Original Message- > From: Dmitry Kozlyuk > Sent: Sunday, October 17, 2021 12:15 PM > Subject: RE: [PATCH v2 2/5] ethdev: add capability to keep shared objects on > restart > > > [...] > > > +By default it is unspecified if indirect actions persist after the > > device stop

[dpdk-dev] [PATCH v2 5/6] build: have Windows support checked per driver

2021-10-17 Thread Tal Shnaiderman
Remove the check and build failure in case of Windows OS from crypto/meson.build to the meson.build file of each crypto PMD to allow PMD support on this OS per driver. Signed-off-by: Tal Shnaiderman --- drivers/crypto/aesni_gcm/meson.build | 6 ++ drivers/crypto/aesni_mb/meson.build | 6 +++

[dpdk-dev] [PATCH v2 6/6] crypto/mlx5: support on Windows

2021-10-17 Thread Tal Shnaiderman
Add support for mlx5 crypto pmd on Windows OS. Add changes to release note and pmd guide. Signed-off-by: Tal Shnaiderman --- doc/guides/cryptodevs/mlx5.rst | 15 --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/common/mlx5/version.map | 2 +

[dpdk-dev] [PATCH v2 5/6] build: check Windows support per driver

2021-10-17 Thread Tal Shnaiderman
Remove the check and build failure from crypto/meson.build in case building for Windows OS. Add this check/failure in the meson.build file of each crypto PMD that is not enforcing it to allow PMD support for Windows per driver when applicable. Signed-off-by: Tal Shnaiderman --- drivers/crypto/a

[dpdk-dev] [PATCH v2 1/6] common/mlx5: add DV enums to Windows defs file

2021-10-17 Thread Tal Shnaiderman
Add needed DV enums used by the crypto PMD and missing for Windows OS. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/windows/mlx5_win_defs.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/common/mlx5/windows/mlx5_win_defs.h b/drivers/co

[dpdk-dev] [PATCH v2 0/6] Support MLX5 crypto driver on Windows

2021-10-17 Thread Tal Shnaiderman
Support the MLX5 crypto driver on Windows OS by moving the driver's control path communication with the Kernel to be OS agnostic. --- Depends-on: series-19421 ("mlx5: sharing global MR cache between drivers") v2: Split build change for mlx5 only and the rest of the drivers [AkhilG] --- Tal Shnaid

[dpdk-dev] [PATCH v2 3/6] crypto/mlx5: use OS agnostic functions for UMEM operations

2021-10-17 Thread Tal Shnaiderman
use the functions mlx5_os_umem_reg, mlx5_os_umem_dereg mlx5_os_get_umem_id instead of the glue functions to support UMEM operations on all OSs. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 8 drivers/crypto/mlx5/mlx5_crypto.h | 2 +- 2 fi

[dpdk-dev] [PATCH v2 2/6] crypto/mlx5: replace UNIX functions with EAL functions

2021-10-17 Thread Tal Shnaiderman
Use the OS agnostic EAL function rte_mem_page_size to get page size value instead of the Linux specific implementation. Also remove the usage of PTHREAD_MUTEX_INITIALIZER which is not support in Windows and initialize priv_list_lock in RTE_INIT. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azr

[dpdk-dev] [PATCH v2 4/6] crypto/mlx5: fix size of UMR WQE

2021-10-17 Thread Tal Shnaiderman
The size of the UMR WQE allocated object is decided by a sizof operation on the struct, however since the struct contains a union of flexible array members this sizeof results can differ between compilers. GCC for example treats the union as 0 sized, MSVC adds a padding of 16Bits. To resolve the

Re: [dpdk-dev] [PATCH v3 3/3] app/testpmd: support L2TPV2 and PPP protocol pattern

2021-10-17 Thread Ori Kam
Hi Jie, Sorry if I wan't clear on my last review. You don't need to implement encap/decap for those protocols just make sure they are working with the set encap and set decap along with the raw action. You can look at cmd_set_raw_parsed and use other tunnels as reference (for example gtp). >

Re: [dpdk-dev] [EXT] [PATCH v4 03/15] crypto: add dest_sgl in raw vector APIs

2021-10-17 Thread Akhil Goyal
> The structure rte_crypto_sym_vec is updated to > add dest_sgl to support out of place processing. > > Signed-off-by: Hemant Agrawal > Acked-by: Akhil Goyal > Acked-by: Konstantin Ananyev > --- > doc/guides/rel_notes/deprecation.rst | 5 - > lib/cryptodev/rte_crypto_sym.h | 2 ++ >

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: support PPP and L2TPV2 procotol

2021-10-17 Thread Ori Kam
Hi Jie, > -Original Message- > From: Jie Wang > Sent: Friday, October 15, 2021 12:58 PM > To: dev@dpdk.org > Wang > Subject: [PATCH v3 1/3] ethdev: support PPP and L2TPV2 procotol > > Added flow pattern items and header formats of L2TPv2 and PPP to support PPP > over L2TPv2 over > UD

Re: [dpdk-dev] [EXT] [PATCH v10 0/9] new features for ipsec and security libraries

2021-10-17 Thread Akhil Goyal
> Add support for: > NAT-T/UDP encapsulation > AES_CCM, CHACHA20_POLY1305 and AES_GMAC > SA telemetry > ESN with initial SQN value > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > > Radu Nicolau (9): > se

Re: [dpdk-dev] [EXT] [PATCH 5/5] crypto/mlx5: support on Windows

2021-10-17 Thread Tal Shnaiderman
> Subject: RE: [EXT] [PATCH 5/5] crypto/mlx5: support on Windows > > External email: Use caution opening links or attachments > > > > Add support for mlx5 crypto pmd on Windows OS. > > Add changes to release note and pmd guide. > > > > Signed-off-by: Tal Shnaiderman > > --- > > doc/guides/cryp

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: support PPP and L2TPV2 procotol

2021-10-17 Thread Ori Kam
HI Jie, > -Original Message- > From: Ferruh Yigit > Sent: Friday, October 15, 2021 2:10 PM > Subject: Re: [PATCH v3 1/3] ethdev: support PPP and L2TPV2 procotol > > On 10/15/2021 10:58 AM, Jie Wang wrote: > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this structure may change withou

Re: [dpdk-dev] [PATCH v2 2/5] ethdev: add capability to keep shared objects on restart

2021-10-17 Thread Ori Kam
Hi Dmitry > -Original Message- > From: Dmitry Kozlyuk > Sent: Friday, October 15, 2021 7:18 PM > To: dev@dpdk.org > Subject: [PATCH v2 2/5] ethdev: add capability to keep shared objects on > restart > > rte_flow_action_handle_create() did not mention what happens with an indirect > act

Re: [dpdk-dev] [PATCH v4 0/5] drivers/net: add NXP ENETFEC driver

2021-10-17 Thread Apeksha Gupta
Hi Ferruh, Do you have any further comments on this series ? Regards, Apeksha > -Original Message- > From: Apeksha Gupta > Sent: Friday, October 1, 2021 5:12 PM > To: david.march...@redhat.com; andrew.rybche...@oktetlabs.ru; > ferruh.yi...@intel.com > Cc: dev@dpdk.org; Sachin Saxena ; H

Re: [dpdk-dev] [PATCH v2 2/5] ethdev: add capability to keep shared objects on restart

2021-10-17 Thread Dmitry Kozlyuk
> [...] > > +By default it is unspecified if indirect actions persist after the > device stop. > > +If ``RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP`` is not advertised, then > > +indirect actions must be explicitly destroyed before stopping the > > +device if the application needs to ensure they are

Re: [dpdk-dev] [PATCH v4 02/15] crypto: add total raw buffer length

2021-10-17 Thread Hemant Agrawal
Hi Fan On 10/14/2021 6:09 PM, Zhang, Roy Fan wrote: Hi Hemant, I still think it is enough to use rte_crypto_vec as well as rte_crypto_sym_ofs is enough to describe the data including both the data and aad. Imagine 2 10 bytes segments case, encryption/hash size of 12 and aad of 8. We will have

Re: [dpdk-dev] [PATCH v7 1/5] ethdev: introduce shared Rx queue

2021-10-17 Thread Xueming(Steven) Li
On Sat, 2021-10-16 at 22:33 -0700, Ajit Khaparde wrote: > On Sat, Oct 16, 2021 at 1:43 AM Xueming Li wrote: > > > > In current DPDK framework, each Rx queue is pre-loaded with mbufs to > > save incoming packets. For some PMDs, when number of representors scale > > out in a switch domain, the memo