[dpdk-dev] [PATCH 3/3] net/sfc: implement the transfer proxy port callback

2021-10-14 Thread Andrew Rybchenko
From: Viacheslav Galaktionov In sfc, MAE admin serves as a transfer proxy. In order to track which ethdev is privileged, augment every independent switch port structure with information about its MAE privilege. Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Reviewed-by:

[dpdk-dev] [PATCH 2/3] net/sfc: allow ports without MAE privilege

2021-10-14 Thread Andrew Rybchenko
From: Viacheslav Galaktionov Register unprivileged ports in the switch domain registry in order to allow redirecting traffic to them. Differentiate between different levels of MAE support, update all MAE status checks. Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Revi

[dpdk-dev] [PATCH 1/3] common/sfc_efx/base: support unprivileged MAE clients

2021-10-14 Thread Andrew Rybchenko
From: Viacheslav Galaktionov In order to differentiate between privileged and unprivileged MAE clients, add a separate boolean flag to represent a NIC's MAE privilege level. Allow initializing unprivileged MAE clients by avoiding calls to functions that can only be called by the admin NIC. Sign

[dpdk-dev] [PATCH 0/3] net/sfc: support transfer rule proxy

2021-10-14 Thread Andrew Rybchenko
Prepare driver infrastructure and add support for transfer rules proxy. The API allows to find out right entry point for transfer rules (which require corresponding priviledges). Viacheslav Galaktionov (3): common/sfc_efx/base: support unprivileged MAE clients net/sfc: allow ports without MAE

Re: [dpdk-dev] [PATCH v3 15/18] vhost: fix typo in comment

2021-10-14 Thread Xia, Chenbo
> -Original Message- > From: Stephen Hemminger > Sent: Friday, October 15, 2021 5:56 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Maxime Coquelin > ; Xia, Chenbo > Subject: [PATCH v3 15/18] vhost: fix typo in comment > > Yet another spelling error found by codespell. > > Signed-off-b

[dpdk-dev] [PATCH] app/testpmd: fix l4 sw csum over multi segments

2021-10-14 Thread Xiaoyun Li
In csum forwarding mode, software UDP/TCP csum calculation only takes the first segment into account while using the whole packet length so the calculation will read invalid memory region with multi-segments packets and will get wrong value. This patch fixes this issue. Fixes: af75078fece3 ("first

[dpdk-dev] [PATCH V3] ethdev: fix eth device released repeatedly

2021-10-14 Thread Huisong Li
In secondary process, rte_eth_dev_close() doesn't clear eth_dev->data. If calling rte_dev_remove() after rte_eth_dev_close(), in rte_eth_dev_pci_generic_remove() function, the released eth device still can be found by its name in shared memory. As a result, the eth device will be released repeatedl

Re: [dpdk-dev] [PATCH V2] ethdev: fix eth device released repeatedly

2021-10-14 Thread lihuisong (C)
在 2021/10/14 20:50, Thomas Monjalon 写道: 14/10/2021 14:32, lihuisong (C): Hi, Thomas *The commit log:* In secondary process, rte_eth_dev_close() doesn't clear eth_dev->data. If calling rte_dev_remove() after rte_eth_dev_close(), in rte_eth_dev_pci_generic_remove() function, the released eth de

[dpdk-dev] [PATCH v2] hash: promote APIs to stable

2021-10-14 Thread Honnappa Nagarahalli
Promote APIs to stable. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- v2: 1) Removed EXPERIMENTAL warning in comments 2) Promoted all the APIs except rte_thash_*** APIs lib/hash/rte_hash.h | 17 - lib/hash/version.map | 10 +- 2 files changed, 5

Re: [dpdk-dev] [PATCH v1] doc: fix typo of Intel device name

2021-10-14 Thread Wang, Haiyue
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, October 13, 2021 18:39 > To: William Tu ; dev@dpdk.org > Cc: Wang, Haiyue > Subject: RE: [dpdk-dev] [PATCH v1] doc: fix typo of Intel device name > > > > > -Original Message- > > From: dev On Behalf Of William Tu > >

Re: [dpdk-dev] [PATCH v2] ethdev: fix one MAC address occupies two index in mac addrs

2021-10-14 Thread lihuisong (C)
在 2021/10/12 15:14, Thomas Monjalon 写道: 12/10/2021 04:58, lihuisong (C): 在 2021/10/11 18:35, Thomas Monjalon 写道: 11/10/2021 11:28, Min Hu (Connor): From: Huisong Li The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by rte_eth_

Re: [dpdk-dev] [PATCH v3 17/18] test-pmd: fix spelling errors in comments

2021-10-14 Thread Li, Xiaoyun
> -Original Message- > From: Stephen Hemminger > Sent: Friday, October 15, 2021 05:57 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Li, Xiaoyun > > Subject: [PATCH v3 17/18] test-pmd: fix spelling errors in comments app/test-pmd: fix spelling errors in comments Except the title, Acked-by

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: fix max Rx packet length

2021-10-14 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, October 12, 2021 8:54 AM [...] > Subject: [PATCH v6 1/6] ethdev: fix max Rx packet length > > There is a confusion on setting max Rx packet length, this patch aims to > clarify it. > > 'rte_eth_dev_configure()' API accepts max Rx

Re: [dpdk-dev] [PATCH v6 1/5] ethdev: update modify field flow action

2021-10-14 Thread Slava Ovsiienko
There is no actual fixing commits. I've just followed the practice of removing the deprecation notice in dedicated commit. So, no extra steps needed, thank you for the patch correction. With best regards, Slava > -Original Message- > From: Ferruh Yigit > Sent: Thursday, October 14, 202

Re: [dpdk-dev] [PATCH v7 1/2] net: fix IPv4 change announce

2021-10-14 Thread Slava Ovsiienko
> -Original Message- > From: Gregory Etelson > Sent: Thursday, October 14, 2021 20:41 > To: dev@dpdk.org; Gregory Etelson > Cc: Matan Azrad ; Raslan Darawsheh > ; olivier.m...@6wind.com; NBU-Contact-Thomas > Monjalon ; ferruh.yi...@intel.com; Akhil Goyal > ; Ori Kam ; Ray Kinsella > ; Sla

Re: [dpdk-dev] [PATCH v5 0/5] ethdev: introduce configurable flexible item

2021-10-14 Thread Slava Ovsiienko
Hi, Ferruh > -Original Message- > From: Ferruh Yigit > Sent: Thursday, October 14, 2021 19:09 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Shahaf Shuler ; Ori Kam > ; Gregory Etelson ; NBU-Contact- > Thomas Monjalon ; Qi Zhang > Subject: Re: [dpdk-dev] [P

Re: [dpdk-dev] [PATCH v3 14/18] sched: fix typo in comment

2021-10-14 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 14, 2021 10:56 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian ; Singh, Jasvinder > > Subject: [PATCH v3 14/18] sched: fix typo in comment > > Yet another spelling error found by codespell.

Re: [dpdk-dev] [PATCH v3 11/18] pipeline: fix spellin error in comment

2021-10-14 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 14, 2021 10:56 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian > Subject: [PATCH v3 11/18] pipeline: fix spellin error in comment > > Minor typo > > Signed-off-by: Stephen Hemminger > ---

Re: [dpdk-dev] [PATCH V2 1/2] app/testpmd: add tunnel types

2021-10-14 Thread Gregory Etelson
> Subject: [PATCH V2 1/2] app/testpmd: add > tunnel types > > Current testpmd implementation supports > VXLAN only for tunnel offload. > Add GRE, NVGRE and GENEVE for tunnel offload > flow matches. > > For example: > testpmd> flow tunnel create 0 type vxlan > port 0: flow tunnel #1 type vxlan > t

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang

2021-10-14 Thread Piotr Kubaj
The vector -> dpdk_vector renaming was done because there's a namespace pollution. vector is a keyword on ppc64le and that causes an error for clang. On 21-10-14 19:35:37, Piotr Kubaj wrote: > Couple of quite common issues: > 1. In rte_cycles.h, sys/platform/ppc.h and __ppc_get_timebase() are on

Re: [dpdk-dev] [PATCH v2] drivers/net: remove queue xstats auto-fill flag

2021-10-14 Thread Ferruh Yigit
On 9/28/2021 5:48 PM, Andrew Rybchenko wrote: Some drivers do not provide per-queue statistics. So, there is no point to have these misleading zeros in xstats. Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] drivers/net: remove queue xstats auto-fill flag

2021-10-14 Thread Ferruh Yigit
On 9/30/2021 2:50 PM, Andrew Rybchenko wrote: On 9/30/21 4:45 PM, Andrew Rybchenko wrote: On 9/30/21 4:00 PM, Ferruh Yigit wrote: On 9/29/2021 7:38 AM, Andrew Rybchenko wrote: On 9/28/21 8:10 PM, Stephen Hemminger wrote: On Tue, 28 Sep 2021 19:48:54 +0300 Andrew Rybchenko wrote: Some drive

Re: [dpdk-dev] [PATCH v5 5/5] app/testpmd: add flex item CLI commands

2021-10-14 Thread Gregory Etelson
Hello Ferruh, ..snip.. > > testpmd> flow flex_item create > > > > > The file here is .json file, right? What do you > think to provide some > sample .json file? I am not quite sure though > where can be a place for > them, perhaps a sub-folder under testpmd? > JSON file example will be added

Re: [dpdk-dev] [PATCH v3 05/18] rcu: fix typo in comment

2021-10-14 Thread Honnappa Nagarahalli
> > Another codespell find. > > Signed-off-by: Stephen Hemminger Reviewed-by: Honnappa Nagarahalli > --- > lib/rcu/rte_rcu_qsbr.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index > 18811c1cc106..62a420a785fc 1006

[dpdk-dev] [PATCH v3 18/18] test: fix spelling errors in comments

2021-10-14 Thread Stephen Hemminger
Lots of little typos in test programs. Signed-off-by: Stephen Hemminger --- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_fib.c | 2 +- app/test/test_f

[dpdk-dev] [PATCH v3 17/18] test-pmd: fix spelling errors in comments

2021-10-14 Thread Stephen Hemminger
More typos Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 826256b0b346..50af096c6a6e 100644

[dpdk-dev] [PATCH v3 16/18] ip_frag: fix typos

2021-10-14 Thread Stephen Hemminger
Minor typos in comment. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 69666c8b8271..4a89a5f5365a

[dpdk-dev] [PATCH v3 15/18] vhost: fix typo in comment

2021-10-14 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h index fd372d52594b..2c4801d9561c 100644 --- a/lib/vhost/rte_vhost.h +++

[dpdk-dev] [PATCH v3 14/18] sched: fix typo in comment

2021-10-14 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index a858f61f9548..329f4b2e7b48 100644 --- a/lib/sched/rte_sched.c +++ b/li

[dpdk-dev] [PATCH v3 13/18] rib: fix typo in comment

2021-10-14 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c index 96424e9c9f4f..4a6f29b0040d 100644 --- a/lib/rib/rte_rib6.c +++ b/lib/rib/rte_ri

[dpdk-dev] [PATCH v3 12/18] hash: fix typo in comment

2021-10-14 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index 696a1121e241..9c3ccb25be6d 100644 --- a/lib/hash/rte_thash.c +++ b/lib/ha

[dpdk-dev] [PATCH v3 11/18] pipeline: fix spellin error in comment

2021-10-14 Thread Stephen Hemminger
Minor typo Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pipeline/rte_swx_pipeline.h b/lib/pipeline/rte_swx_pipeline.h index 490ff60c0d02..4b7825956558 100644 --- a/lib/pipeline/rte_swx_pipeline.h +++

[dpdk-dev] [PATCH v3 10/18] bbdev: fix typo in comment

2021-10-14 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index defddcfc2843..6a97dd85e635 100644 --- a/lib/bbdev/rte_bbdev.c +++ b/li

[dpdk-dev] [PATCH v3 09/18] net: fix spelling error in gtp comment

2021-10-14 Thread Stephen Hemminger
More codespell finds. Signed-off-by: Stephen Hemminger --- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/net/rte_gtp.h b/lib/net/rte_gtp.h index 9f6deb9c7ef3..dca940c2c5ab 100644 --- a/lib/net/rte_gtp.h +++ b/lib/net/rte_gtp.h @@ -142,9 +142,9 @@

[dpdk-dev] [PATCH v3 08/18] eal: fix typos in comments

2021-10-14 Thread Stephen Hemminger
Minor spelling errors. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/rte_function_versioning.h b/lib/eal/include/rte_function

[dpdk-dev] [PATCH v3 07/18] acl: fix spelling errors

2021-10-14 Thread Stephen Hemminger
Lots of little typos in comments Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/acl/acl.h b/lib/acl/acl.h index 40

[dpdk-dev] [PATCH v3 06/18] bpf: fix spelling in comments

2021-10-14 Thread Stephen Hemminger
Found by running codespell on the bpf implementation. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_load_elf.c | 2 +- lib/bpf/bpf_pkt.c | 2 +- lib/bpf/bpf_validate.c | 8 4 files changed, 7 insertions(+), 7 deletions

[dpdk-dev] [PATCH v3 05/18] rcu: fix typo in comment

2021-10-14 Thread Stephen Hemminger
Another codespell find. Signed-off-by: Stephen Hemminger --- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index 18811c1cc106..62a420a785fc 100644 --- a/lib/rcu/rte_rcu_qsbr.h +++ b/lib/rcu/rte_rcu_qsbr.

[dpdk-dev] [PATCH v3 04/18] power: fix typo in comment

2021-10-14 Thread Stephen Hemminger
More spelling errors caught by codespell Signed-off-by: Stephen Hemminger --- lib/power/power_acpi_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c index 1e8aeb84037c..402ed8c99b42 100644 --- a/lib/power

[dpdk-dev] [PATCH v3 03/18] eventdev: fix typo in comment

2021-10-14 Thread Stephen Hemminger
Typo in comment found by codespell Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index ee20b39f4b24..b5c2dc1427c6 100

[dpdk-dev] [PATCH v3 02/18] ipsec: fix spelling errors

2021-10-14 Thread Stephen Hemminger
Lots of typos in comments found by codespell Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c| 2 +- lib/ipsec/sa.h| 2 +- 5 files changed, 6 insertions(+)

[dpdk-dev] [PATCH v3 01/18] node: fix typos

2021-10-14 Thread Stephen Hemminger
Spelling errors in comments including doxygen Signed-off-by: Stephen Hemminger --- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node/ethdev_rx_priv.h b/lib/node/ethde

[dpdk-dev] [PATCH v3 00/18] fix spelling errors

2021-10-14 Thread Stephen Hemminger
After finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments. v3 - incorporate feedback on vhost fix comment formatting in test portion v2 - checkpatch wants more than just subject remove autocorrect of

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-14 Thread Dmitry Kozlyuk
> Introducing UNKNOWN state seems wrong to me. > What should an application do when it is reported? > Now there's just no way to learn how the PMD behaves, but if it provides a > response, it can't be "I don't know what I do". > > Here's what I understood from the code, assuming there are no bugs

Re: [dpdk-dev] [v1] ethdev: add telemetry endpoint for device info

2021-10-14 Thread Ferruh Yigit
On 9/29/2021 5:25 AM, Gowrishankar Muthukrishnan wrote: Add telemetry endpoint /ethdev/info for device info. Signed-off-by: Gowrishankar Muthukrishnan Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-14 Thread Dmitry Kozlyuk
> -Original Message- > From: Ferruh Yigit > Sent: 14 октября 2021 г. 16:47 > To: Dmitry Kozlyuk ; dev@dpdk.org; Andrew Rybchenko > ; Ori Kam ; Raslan > Darawsheh > Cc: NBU-Contact-Thomas Monjalon ; Qi Zhang > ; jer...@marvell.com; Maxime Coquelin > > Subject: Re: [PATCH 2/5] ethdev: add

Re: [dpdk-dev] [PATCH v6 2/2] net: introduce IPv4 ihl and version fields

2021-10-14 Thread Gregory Etelson
Hello Thomas, > > > struct rte_ipv4_hdr { > > > - uint8_t version_ihl; /**< version > and header length */ > > > + __extension__ > > > + union { > > > + uint8_t version_ihl;/**< version > and header length */ > > > + struct { > > > +#if RTE_BYTE_ORDER ==

[dpdk-dev] [PATCH v7 2/2] net: introduce IPv4 ihl and version fields

2021-10-14 Thread Gregory Etelson
RTE IPv4 header definition combines the `version' and `ihl' fields into a single structure member. This patch introduces dedicated structure members for both `version' and `ihl' IPv4 fields. Separated header fields definitions allow to create simplified code to match on the IHL value in a flow rul

[dpdk-dev] [PATCH v7 0/2] net: introduce IPv4 ihl and version fields

2021-10-14 Thread Gregory Etelson
Gregory Etelson (2): net: fix IPv4 change announce net: introduce IPv4 ihl and version fields app/test/test_flow_classify.c | 8 doc/guides/rel_notes/deprecation.rst | 6 -- doc/guides/rel_notes/release_21_11.rst | 3 +++ lib/net/rte_ip.h | 14

[dpdk-dev] [PATCH v7 1/2] net: fix IPv4 change announce

2021-10-14 Thread Gregory Etelson
IPv4 header encodes fragment information into 16 bits field. 3 bits hold flags and remaining 13 bits are for fragment offset. 13 bits bit-field cannot be defined both for big and little endian systems. The patch removes IPv4 fragments union announce. Fixes: f7383e7c7ec1 ("net: announce changes in

[dpdk-dev] [PATCH] ring: fix size of name array in ring structure

2021-10-14 Thread Honnappa Nagarahalli
Use correct define for the name array size. The change breaks ABI and hence cannot be backported to stable branches. Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types") Cc: zoltan.k...@schaman.hu Signed-off-by: Honnappa Nagarahalli --- lib/ring/rte_ring_core.h | 7 +-- 1

Re: [dpdk-dev] [PATCH 1/1] net: fix aliasing issue in checksum computation

2021-10-14 Thread Morten Brørup
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, 14 October 2021 19.20 > > On 9/18/2021 12:49 PM, Georg Sauthoff wrote: > > That means a superfluous cast is removed and aliasing through a > uint8_t > > pointer is eliminated. Note that uint8_t does

[dpdk-dev] [PATCH 7/7] net/ena: update version to 2.5.0

2021-10-14 Thread Michal Krawczyk
This version update contains: * Fix for verification of the offload capabilities (especially for IPv6 packets). * Support for Tx and Rx free threshold values. * Fixes for per-queue offload capabilities. * Announce support of the scattered Rx offload. * NUMA aware allocations. * Chec

[dpdk-dev] [PATCH 6/7] net/ena: add check for missing Tx completions

2021-10-14 Thread Michal Krawczyk
In some cases Tx descriptors may be uncompleted by the HW and as a result they will never be released. This patch adds checking for the missing Tx completions to the ENA timer service, so in order to use this feature, the application must call the function rte_timer_manage(). Missing Tx completio

[dpdk-dev] [PATCH 5/7] net/ena: add NUMA aware allocations

2021-10-14 Thread Michal Krawczyk
Only the IO rings memory was allocated with taking the socket ID into the respect, while the other structures was allocated using the regular rte_zmalloc() API. Ring specific structures are now being allocated using the ring's socket ID. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin

[dpdk-dev] [PATCH 4/7] net/ena: indicate missing scattered Rx capability

2021-10-14 Thread Michal Krawczyk
ENA can't be forced to always pass single descriptor for the Rx packet. Even if the passed buffer size is big enough to hold the data, we can't make assumption that the HW won't use extra descriptor because of internal optimizations. This assumption may be true, but only for some of the FW revision

[dpdk-dev] [PATCH 3/7] net/ena: fix per-queue offload capabilities

2021-10-14 Thread Michal Krawczyk
PMD shouldn't advertise the same offloads as both per-queue and per-port [1]. Each offload capability should go either to the [rt]x_queue_offload_capa or [rt]x_offload_capa. As ENA currently doesn't support offloads which could be configured per-queue, only per-port flags should be set. In additi

[dpdk-dev] [PATCH 2/7] net/ena: support Tx/Rx free thresholds

2021-10-14 Thread Michal Krawczyk
The caller can pass Tx or Rx free threshold value to the configuration structure for each ring. It determines when the Tx/Rx function should start cleaning up/refilling the descriptors. ENA was ignoring this value and doing it's own calulcations. Now the user can configure ENA's behavior using thi

[dpdk-dev] [PATCH 1/7] net/ena: fix verification of the offload capabilities

2021-10-14 Thread Michal Krawczyk
ENA PMD has multiple checksum offload flags, which are more discrete than the DPDK offload capabilities flags. As the driver wasn't storing it's internal checksum offload capabilities and was relying only on the DPDK capabilities, not all scenarios could be properly covered (like when to prepare ps

[dpdk-dev] [PATCH 0/7] net/ena: update ENA PMD to v2.5.0

2021-10-14 Thread Michal Krawczyk
Hi, this version updates the driver to version 2.5.0. It mainly focuses on fixing the offload flags fixes. Other features included in this patchset are: * NUMA aware allocations for the queue specific structures * New watchdog - check for missing Tx completions * Support for [tr]x_free_thre

[dpdk-dev] [PATCH v6 3/3] common/octeontx2: enable build only on 64-bit Linux

2021-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Since AARCH32 extension is not implemented on octeontx2 family, only enable build for 64bit. Due to Linux kernel AF(Admin Function) driver dependency, only enable build for 64-bit Linux. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- drivers/common/octeontx2/me

[dpdk-dev] [PATCH v6 2/3] common/octeontx: enable build only on 64-bit Linux

2021-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Since AARCH32 extension is not implemented on octeontx family, only enable build for 64bit. Due to Linux kernel AF(Admin function) driver dependency, only enable build for 64-bit Linux. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- drivers/common/octeontx/meso

[dpdk-dev] [PATCH v6 1/3] net/thunderx: enable build only on 64-bit Linux

2021-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Since AARCH32 extension is not implemented on thunderx family, only enable build for 64bit. Due to Linux kernel AF(Admin function) driver dependency, only enable build for Linux. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v6 Changes: - Update commit log to

Re: [dpdk-dev] [PATCH v7 0/2] net: introduce IPv4 ihl and version fields

2021-10-14 Thread Ferruh Yigit
On 10/14/2021 6:41 PM, Gregory Etelson wrote: Gregory Etelson (2): net: fix IPv4 change announce net: introduce IPv4 ihl and version fields Series applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v1 1/1] doc: clarify vfio doc for built-in modules

2021-10-14 Thread Iremonger, Bernard
Hi Anatoly, > -Original Message- > From: dev On Behalf Of Anatoly Burakov > Sent: Thursday, October 14, 2021 1:53 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v1 1/1] doc: clarify vfio doc for built-in modules > > Currently, the documentation only contains instructions for enabli

Re: [dpdk-dev] [PATCH v2] mempool: enforce valid flags at creation

2021-10-14 Thread Stephen Hemminger
On Thu, 14 Oct 2021 21:29:16 +0200 David Marchand wrote: > If we do not enforce valid flags are passed by an application, this > application might face issues in the future when we add more flags. > > Signed-off-by: David Marchand > Reviewed-by: Andrew Rybchenko > Acked-by: Ray Kinsella > ---

[dpdk-dev] [PATCH v2] mempool: enforce valid flags at creation

2021-10-14 Thread David Marchand
If we do not enforce valid flags are passed by an application, this application might face issues in the future when we add more flags. Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko Acked-by: Ray Kinsella --- Changes since v1: - fixed checkpatch warning, - moved flags to validate

Re: [dpdk-dev] [PATCH] mempool: enforce valid flags at creation

2021-10-14 Thread David Marchand
On Tue, Oct 12, 2021 at 9:57 AM David Marchand wrote: > > On Tue, Oct 12, 2021 at 9:49 AM Andrew Rybchenko > wrote: > > > > On 10/12/21 10:28 AM, David Marchand wrote: > > > If we do not enforce valid flags are passed by an application, this > > > application might face issues in the future when

Re: [dpdk-dev] [PATCH v2] usertools/telemetry: add list of available file-prefixes

2021-10-14 Thread David Marchand
On Wed, Oct 13, 2021 at 3:01 PM Walsh, Conor wrote: > > This patch is also compatible with the v8 of the "improve telemetry support > with in-memory mode" patchset. Nice addition, can you add a description of this option in telemetry howto? Thanks. -- David Marchand

[dpdk-dev] [PATCH] net/i40e: fix gcc 11 build warning on POWER architecture

2021-10-14 Thread David Christensen
Building DPDK with a gcc 11 based compiler such as the IBM Advanced Toolchain 15 (1) generates a stringop-overflow warning when using -O3 optimization (DPDK default for production releases): writing 1 byte into a region of size 0 [-Wstringop-overflow=] The issue has been reported to the gcc proje

Re: [dpdk-dev] [PATCH v9 0/4] improve telemetry support with in-memory mode

2021-10-14 Thread David Marchand
On Thu, Oct 14, 2021 at 12:50 PM Bruce Richardson wrote: > > This patchset cleans up telemetry support for "in-memory" mode, so that > multiple independent processes can be run using that mode and still have > telemetry support. It also removes problems of one process removing the > socket of anot

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-14 Thread Akhil Goyal
Hi Fan, Check for below QAT fix also > > > > Unfortunately the patches still cause seg-fault at QAT and SW PMDs. > > > > - for qat it fails at rte_security_ops->session_size_get not implemented. And for this one diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c index

[dpdk-dev] [PATCH v4] examples/l3fwd: ipv4 and udp/tcp cksum verification through software

2021-10-14 Thread Usama Nadeem
checks if ipv4 and udptcp cksum offload capability available If not available, cksum is verified through software If cksum is corrupt, packet is dropped, rest of the packets are forwarded back. Bugzilla ID:545 Signed-off-by: Usama Nadeem --- examples/l3fwd/l3fwd.h | 6 examples/l3fwd/l

[dpdk-dev] [PATCH] ppc64le: fix build with Clang

2021-10-14 Thread Piotr Kubaj
Couple of quite common issues: 1. In rte_cycles.h, sys/platform/ppc.h and __ppc_get_timebase() are only for glibc. 2. In include/rte_atomic.h, the same issue already was encountered on arm64: https://mails.dpdk.org/archives/dev/2019-January/123331.html 3. In rte_altivec.h, defining vector to __vec

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang

2021-10-14 Thread Chautru, Nicolas
Hi Piotr, See below, personally not okay with such a change. > -Original Message- > From: Piotr Kubaj > Sent: Thursday, October 14, 2021 10:36 AM > To: Chautru, Nicolas ; Doherty, Declan > ; Power, Ciara ; Xing, > Beilei ; Wang, Haiyue ; > jiawe...@trustnetic.com; jianw...@trustnetic.co

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-14 Thread Akhil Goyal
Hi Fan, > > Unfortunately the patches still cause seg-fault at QAT and SW PMDs. > > - for qat it fails at rte_security_ops->session_size_get not implemented. > - for sw pmds the queue pair's session private mempools are not set. > Can you check if below change works for Kasumi. I will replicate

[dpdk-dev] [PATCH] pipeline: add support for action annotations

2021-10-14 Thread Yogesh Jangra
Enable restricting the scope of an action to regular table entries or to the table default entry in order to support the P4 language tableonly or defaultonly annotations. Signed-off-by: Yogesh Jangra Acked-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_ctl.c | 6 ++ lib/pipeli

Re: [dpdk-dev] [PATCH v7 2/2] net: introduce IPv4 ihl and version fields

2021-10-14 Thread Ajit Khaparde
On Thu, Oct 14, 2021 at 10:42 AM Gregory Etelson wrote: > > RTE IPv4 header definition combines the `version' and `ihl' fields > into a single structure member. > This patch introduces dedicated structure members for both `version' > and `ihl' IPv4 fields. Separated header fields definitions allo

[dpdk-dev] [PATCH v3] test/hash: fix buffer overflow

2021-10-14 Thread Vladimir Medvedkin
This patch fixes buffer overflow reported by ASAN, please reference https://bugs.dpdk.org/show_bug.cgi?id=818 Some tests for the rte_hash table use the rte_jhash_32b() as the hash function. This hash function interprets the length argument in units of 4 bytes. This patch adds a wrapper function a

Re: [dpdk-dev] [PATCH] test/hash: fix buffer overflow

2021-10-14 Thread Medvedkin, Vladimir
Hi David, On 14/10/2021 09:04, David Marchand wrote: Hello Vladimir, On Wed, Oct 13, 2021 at 9:27 PM Medvedkin, Vladimir wrote: With patch applied, ASan reports another issue. Did you test your fix with ASan? You're right, for some reason ASAN wasn't enabled. I applied patch and built runn

Re: [dpdk-dev] [PATCH v2] test/hash: fix buffer overflow

2021-10-14 Thread Medvedkin, Vladimir
Hi David, On 14/10/2021 10:34, David Marchand wrote: On Wed, Oct 13, 2021 at 9:28 PM Vladimir Medvedkin wrote: This patch fixes buffer overflow reported by ASAN, please reference https://bugs.dpdk.org/show_bug.cgi?id=818 Some tests for the rte_hash table use the rte_jhash_32b() as the hash f

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/6] eal/interrupts: avoid direct access to interrupt handle

2021-10-14 Thread Dmitry Kozlyuk
2021-10-14 17:31 (UTC+), Harman Kalra: > > -Original Message- > > From: Dmitry Kozlyuk > > Sent: Thursday, October 14, 2021 6:29 AM > > To: Harman Kalra > > Cc: dev@dpdk.org; Bruce Richardson ; > > david.march...@redhat.com; m...@ashroe.eu > > Subject: [EXT] Re: [PATCH v2 2/6] eal/int

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/6] eal/interrupts: implement get set APIs

2021-10-14 Thread Dmitry Kozlyuk
2021-10-14 17:15 (UTC+), Harman Kalra: > [...] > > > +int rte_intr_fd_get(const struct rte_intr_handle *intr_handle) { > > > + if (intr_handle == NULL) { > > > + RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n"); > > > + rte_errno = ENOTSUP; > > > + goto fail; > > >

Re: [dpdk-dev] [PATCH V2 1/2] app/testpmd: add tunnel types

2021-10-14 Thread Ferruh Yigit
On 9/23/2021 9:43 AM, Eli Britstein wrote: Current testpmd implementation supports VXLAN only for tunnel offload. Add GRE, NVGRE and GENEVE for tunnel offload flow matches. For example: testpmd> flow tunnel create 0 type vxlan port 0: flow tunnel #1 type vxlan testpmd> flow tunnel create 0 type

Re: [dpdk-dev] [PATCH 1/1] net: fix aliasing issue in checksum computation

2021-10-14 Thread Ferruh Yigit
On 9/18/2021 12:49 PM, Georg Sauthoff wrote: That means a superfluous cast is removed and aliasing through a uint8_t pointer is eliminated. Note that uint8_t doesn't have the same strict-aliasing properties as unsigned char. Also simplified the loop since a modern C compiler can speed up (i.e. a

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-14 Thread Zhang, Roy Fan
Hi, Unfortunately the patches still cause seg-fault at QAT and SW PMDs. - for qat it fails at rte_security_ops->session_size_get not implemented. - for sw pmds the queue pair's session private mempools are not set. Regards, Fan > -Original Message- > From: Akhil Goyal > Sent: Thursday,

Re: [dpdk-dev] [PATCH v6 1/2] net: fix IPv4 change announce

2021-10-14 Thread Ori Kam
Hi > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Thursday, October 14, 2021 3:33 PM > Subject: Re: [dpdk-dev] [PATCH v6 1/2] net: fix IPv4 change announce > > On 10/14/2021 1:21 PM, Gregory Etelson wrote: > > Hello Ferruh, > > > >> On 10/14/2021 9:37 AM, Thomas Monja

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/6] eal/interrupts: avoid direct access to interrupt handle

2021-10-14 Thread Harman Kalra
> -Original Message- > From: Dmitry Kozlyuk > Sent: Thursday, October 14, 2021 6:29 AM > To: Harman Kalra > Cc: dev@dpdk.org; Bruce Richardson ; > david.march...@redhat.com; m...@ashroe.eu > Subject: [EXT] Re: [PATCH v2 2/6] eal/interrupts: avoid direct access to > interrupt handle >

Re: [dpdk-dev] [PATCH v2] eal: add telemetry callbacks for memory info

2021-10-14 Thread Harman Kalra
Ping... > -Original Message- > From: Harman Kalra > Sent: Friday, October 8, 2021 6:14 PM > To: dev@dpdk.org; bruce.richard...@intel.com; ciara.po...@intel.com; > Anatoly Burakov > Cc: Harman Kalra > Subject: [PATCH v2] eal: add telemetry callbacks for memory info > > Registering new t

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/6] eal/interrupts: implement get set APIs

2021-10-14 Thread Harman Kalra
Hi Dmitry, Thanks for your inputs. Please see inline. > -Original Message- > From: Dmitry Kozlyuk > Sent: Thursday, October 14, 2021 6:29 AM > To: Harman Kalra > Cc: dev@dpdk.org; Thomas Monjalon ; Ray Kinsella > ; david.march...@redhat.com > Subject: [EXT] Re: [PATCH v2 1/6] eal/interr

Re: [dpdk-dev] [EXT] [v9 4/4] net/cnxk: add telemetry endpoints to ethdev

2021-10-14 Thread Harman Kalra
> -Original Message- > From: dev On Behalf Of Gowrishankar > Muthukrishnan > Sent: Wednesday, September 29, 2021 12:25 PM > To: dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Kiran Kumar > Kokkilagadda ; Nithin Kumar Dabilpuram > ; Sunil Kumar Kori ; Satha > Koteswara Rao Kottidi ; Ashw

Re: [dpdk-dev] [PATCH] hash: promote APIs to stable

2021-10-14 Thread Medvedkin, Vladimir
Hi Honnappa, On 14/10/2021 02:19, Honnappa Nagarahalli wrote: On Wed, 13 Oct 2021 16:38:58 -0500 Honnappa Nagarahalli wrote: --- a/lib/hash/rte_hash.h +++ b/lib/hash/rte_hash.h @@ -430,7 +430,6 @@ rte_hash_get_key_with_position(const struct rte_hash *h, const int32_t position, * -

Re: [dpdk-dev] [EXT] [v9 3/4] mempool/cnxk: add telemetry endpoints mempool

2021-10-14 Thread Harman Kalra
> -Original Message- > From: dev On Behalf Of Gowrishankar > Muthukrishnan > Sent: Wednesday, September 29, 2021 12:25 PM > To: dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Kiran Kumar > Kokkilagadda ; Nithin Kumar Dabilpuram > ; Sunil Kumar Kori ; Satha > Koteswara Rao Kottidi ; Ashw

Re: [dpdk-dev] [PATCH v5 5/5] app/testpmd: add flex item CLI commands

2021-10-14 Thread Ferruh Yigit
On 10/12/2021 1:54 PM, Viacheslav Ovsiienko wrote: From: Gregory Etelson Network port hardware is shipped with fixed number of supported network protocols. If application must work with a protocol that is not included in the port hardware by default, it can try to add the new protocol to port h

Re: [dpdk-dev] [EXT] [v9 2/4] common/cnxk: add telemetry endpoints to nix

2021-10-14 Thread Harman Kalra
> -Original Message- > From: dev On Behalf Of Gowrishankar > Muthukrishnan > Sent: Wednesday, September 29, 2021 12:25 PM > To: dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Kiran Kumar > Kokkilagadda ; Nithin Kumar Dabilpuram > ; Sunil Kumar Kori ; Satha > Koteswara Rao Kottidi ; Ashw

[dpdk-dev] [PATCH v6 12/12] app/test: enable subset of unit tests on Windows

2021-10-14 Thread Jie Zhou
- For fast tests and perf tests, add test stubs to skip not supported ones. - For driver tests, just skip on Windows totally to avoid unnecessary amount of test stubs. For example, there are about 30 cryptodev related tests (even though in the meson for CI it only listed about half) which w

[dpdk-dev] [PATCH v6 11/12] app/test: replace .sh scripts with .py scripts

2021-10-14 Thread Jie Zhou
- Add python script to get coremask - Add python script to check if system supports hugepages - Remove two corresponding .sh scripts - Replace calling of .sh with corresponding .py in meson.build Signed-off-by: Jie Zhou --- app/test/get-coremask.sh | 13 - app/test/get_coremask.py |

[dpdk-dev] [PATCH v6 09/12] app/test: differentiate a strerror on different OS

2021-10-14 Thread Jie Zhou
On Windows, strerror returns just "Unknown error" for errnum greater than MAX_ERRNO, while linux and freebsd returns "Unknown error ", which is the current expectation for errno_autotest. Differentiate the error string on Windows to remove a "duplicate error code" failure. Signed-off-by: Jie Zhou

[dpdk-dev] [PATCH v6 10/12] app/test: remove two alarm_autotest cases

2021-10-14 Thread Jie Zhou
Remove two alarm_autotest test cases which do bogus range check on Windows. Signed-off-by: Jie Zhou --- app/test/test_alarm.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test/test_alarm.c b/app/test/test_alarm.c index b4034339b8..70e97a3109 100644 --- a/app/test/test_alarm.c +++

[dpdk-dev] [PATCH v6 08/12] app/test: skip two logs_autotest cases on Windows

2021-10-14 Thread Jie Zhou
DPDK logs_autotest on Windows failed at "dynamic log types" tests. The failures are on 2 test cases for rte_log_set_level_regexp API, due to regular expression is not supported on Windows in DPDK yet and regcomp/regexec are just stubs on Windows (in regex.h). In app\test\test_logs.c, ifndef these

  1   2   3   4   >