Re: [dpdk-dev] [EXT] Re: [v5] telemetry: fix json output buffer size

2021-10-06 Thread Gowrishankar Muthukrishnan
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 6, 2021 11:09 PM > To: Gowrishankar Muthukrishnan > Cc: dev@dpdk.org; bruce.richard...@intel.com; ciara.po...@intel.com; Jerin > Jacob Kollanukkaran > Subject: [EXT] Re: [dpdk-dev] [v5] telemetry: fix jso

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/iavf: fix multi-process shared data

2021-10-06 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Thursday, September 30, 2021 6:57 PM > To: Yu, DapengX ; Richardson, Bruce > ; Ananyev, Konstantin > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net

Re: [dpdk-dev] [PATCH v1 3/3] test/crypto: add ZUC test cases for 256 bit key

2021-10-06 Thread Vidya Sagar Velumuri
Hi Pablo, From: De Lara Guarch, Pablo Sent: 01 October 2021 17:38 To: Vidya Sagar Velumuri ; Ankur Dwivedi ; Anoob Joseph ; Tejasree Kondoj ; Nithin Kumar Dabilpuram ; Kiran Kumar Kokkilagadda ; Sunil Kumar Kori ; Satha Koteswara Rao Kottidi ; Akhil Goyal ; Do

Re: [dpdk-dev] [PATCH v2] net/iavf: fix QFI field bit check for GTPU EH

2021-10-06 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Wednesday, September 29, 2021 8:32 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; sta...@dpdk.org; Yigit, Ferruh ; > Guo, Junfeng ; Liu, Lingyu > Subject: [PATCH v2] net/iavf: fix QFI field bit check for GTPU E

Re: [dpdk-dev] RHEL7 failures

2021-10-06 Thread Zhang, Qi Z
Hi Ferruh, David and Aman: Sorry for late response due to PRC holiday. I have just tested the patch and there is no issue be detected for functions Thank you so much for the help! Regards Qi > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, October 6

Re: [dpdk-dev] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-06 Thread Nipun Gupta
Sure Nicolas, this seems fine. I'll use this change instead of existing patch 1/10 and send a re-spin. Thanks, Nipun > -Original Message- > From: Nicolas Chautru > Sent: Thursday, October 7, 2021 2:29 AM > To: dev@dpdk.org; gak...@marvell.com; Nipun Gupta ; > t...@redhat.com > Cc: tho...

[dpdk-dev] [PATCH v2 16/18] common/mlx5: share MR management

2021-10-06 Thread michaelba
From: Michael Baum Add global shared MR cache as a field of common device structure. Move MR management to use this global cache for all drivers. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c| 54 - drivers/common/mlx5/mlx5_com

[dpdk-dev] [PATCH v2 18/18] common/mlx5: share MR mempool registration

2021-10-06 Thread michaelba
From: Michael Baum Expand the use of mempool registration to MR management for other drivers. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 148 ++ drivers/common/mlx5/mlx5_common.h | 9 ++ drivers/common/mlx5/mlx5_

[dpdk-dev] [PATCH v2 17/18] common/mlx5: support device DMA map and unmap

2021-10-06 Thread michaelba
From: Michael Baum Since MR management has moved to the common area, there is no longer a need for the DMA map and unmap function for each driver. This patch share those functions. For most drivers it supports these operations for the first time. Signed-off-by: Michael Baum Acked-by: Matan Azra

[dpdk-dev] [PATCH v2 14/18] common/mlx5: add global MR cache create function

2021-10-06 Thread michaelba
From: Michael Baum Add function for global shared MR cache structure initialization. This function include: - btree initialization. - set callbacks for reg and dereg MR. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_verbs.c | 15 +++ drivers

[dpdk-dev] [PATCH v2 15/18] common/mlx5: share MR top-half search function

2021-10-06 Thread michaelba
From: Michael Baum Add function to search in local liniar cache and use it in the drivers instead of their functions. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.h| 9 drivers/common/mlx5/mlx5_common_mr.c | 52 +++

[dpdk-dev] [PATCH v2 08/18] common/mlx5: share device context object

2021-10-06 Thread michaelba
From: Michael Baum Create shared context device in common area and add it as a field of common device. Use this context device in all drivers and remove the ctx field from their private structure. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c

[dpdk-dev] [PATCH v2 10/18] common/mlx5: share the protection domain object

2021-10-06 Thread michaelba
From: Michael Baum Create shared Protection Domain in common area and add it and its PDN as fields of common device structure. Use this Protection Domain in all drivers and remove the PD and PDN fields from their private structure. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- driver

[dpdk-dev] [PATCH v2 12/18] net/mlx5: remove redundancy in MR file

2021-10-06 Thread michaelba
From: Michael Baum This patch remove two redundant things from MR file: 1. mr_find_contig_memsegs_data structure which is moved to common file before. 2. External memory mechanism - mlx5_tx_update_ext_mp function. Since commit [1] which added support for DMA map and unmap, external mem

[dpdk-dev] [PATCH v2 07/18] net/mlx5: remove redundant flag in device config

2021-10-06 Thread michaelba
From: Michael Baum Device configure structure has flag named devx as same as SH structure with the same meaning. Remove the flag from the configuration structure and move all the usages to the SH flag. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c |

[dpdk-dev] [PATCH v2 13/18] common/mlx5: add MR ctrl init function

2021-10-06 Thread michaelba
From: Michael Baum Add function for MR control structure initialization. This function include: - btree initialization. - dev_gen_ptr initialization. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_mr.c| 28 + drivers/common/

[dpdk-dev] [PATCH v2 11/18] common/mlx5: share the HCA capabilities handle

2021-10-06 Thread michaelba
From: Michael Baum Add HCA attributes structure as a field of device config structure. It query in common probing, and updates the timestamp format fields. Each driver use HCA attributes from common device config structure, instead of query it for itself. Signed-off-by: Michael Baum Acked-by:

[dpdk-dev] [PATCH v2 04/18] common/mlx5: share memory related devargs

2021-10-06 Thread michaelba
From: Michael Baum Add device configure structure and function to parse user device arguments into it. Move parsing and management of relevant device arguments to common. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 184 ++

[dpdk-dev] [PATCH v2 02/18] common/mlx5: share basic probing with the internal drivers

2021-10-06 Thread michaelba
From: Michael Baum Create common probing structure that includes, for now, basic probing information detected by the common driver and share it with all the internal drivers. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 4 +- drivers/commo

[dpdk-dev] [PATCH v2 01/18] net/mlx5/windows: fix miss callback register for mem event

2021-10-06 Thread michaelba
From: Michael Baum In device initialization, the driver registers to free hugepages events. When husepage is released, this callback frees all its related MRs. In Windows initialization, this callback is not registered what may cause to use invalid memory. This patch adds memory event callback

[dpdk-dev] [PATCH v2 05/18] net/mlx5/windows: rearrange probing code

2021-10-06 Thread michaelba
From: Michael Baum Rearrange device detection code. Rearrange configuration structures filling. Remove unneeded variables. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/windows/mlx5_os.c | 224 - 1 file changed, 94 insertions(+), 130 deleti

[dpdk-dev] [PATCH v2 00/18] mlx5: sharing global MR cache between drivers

2021-10-06 Thread michaelba
From: Michael Baum The MLNX PMD supports 5 classes (net, RegEx, vDPA, Compress and Crypto). The various drivers are registered under the common driver, and managed by it. In the common driver probing, it calls in a loop the probe function of each driver registered to it. Each driver creates for i

[dpdk-dev] [PATCH v2 09/18] common/mlx5: add ROCE disable in context device creation

2021-10-06 Thread michaelba
From: Michael Baum Add option to get IB device after disabling RoCE. It is relevant if there is vDPA class in device arguments list. Use common device context in vDPA driver and remove the ctx field from its private structure. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/com

[dpdk-dev] [PATCH v2 03/18] common/mlx5: share common definitions

2021-10-06 Thread michaelba
From: Michael Baum Create MACRO definitions file in the common driver as preparation for MR and basic probe sharing. Move relevant definitions from the net driver to the above file. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 1 + drivers/co

[dpdk-dev] [PATCH v2 06/18] common/mlx5: move basic probing functions to common

2021-10-06 Thread michaelba
From: Michael Baum Move open IBV/DevX device function to common. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c| 86 ++ drivers/common/mlx5/linux/mlx5_common_os.h| 3 + drivers/common/mlx5/linux/mlx5_common_verbs.c | 70 +

[dpdk-dev] [PATCH v5 4/4] net/ixgbe: build on Windows

2021-10-06 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Signed-off-by: William Tu Acked-by: Pallavi Kadam Acked-by: Dmitry Kozlyuk --- doc/guides/nics/features/ixgbe.ini

[dpdk-dev] [PATCH v5 3/4] cryptodev: build on Windows

2021-10-06 Thread William Tu
From: Tal Shnaiderman Build the cryptography device library on Windows OS by removing unneeded include and exports blocking the compilation. Signed-off-by: Tal Shnaiderman Acked-by: Akhil Goyal Acked-by: William Tu --- lib/cryptodev/cryptodev_pmd.c | 2 ++ lib/cryptodev/rte_cryptodev.c | 1 -

[dpdk-dev] [PATCH v5 2/4] security: build on Windows

2021-10-06 Thread William Tu
From: Tal Shnaiderman Build the security library on Windows. Remove unneeded export from version file. Signed-off-by: Tal Shnaiderman Acked-by: Akhil Goyal Acked-by: William Tu --- lib/meson.build | 1 + lib/security/version.map | 3 --- 2 files changed, 1 insertion(+), 3 deletions

[dpdk-dev] [PATCH v5 1/4] security: use the net library for IP structs

2021-10-06 Thread William Tu
From: Tal Shnaiderman Remove the netinet includes and replaces them with rte_ip.h to support the in_addr/in6_addr structs on all operating systems. Signed-off-by: Tal Shnaiderman Acked-by: Akhil Goyal Acked-by: William Tu --- lib/net/rte_ip.h| 1 + lib/security/meson.build| 2

[dpdk-dev] [PATCH v4 0/4] net/ixgbe: build on Windows

2021-10-06 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Tal Shnaiderman (3): security: use the net library for IP structs security: build on Windows cryptodev: build on Wi

Re: [dpdk-dev] [PATCH v4 0/4] net/ixgbe: build on Windows

2021-10-06 Thread William Tu
Hi David, Thank you for pointing this out. On Wed, Oct 6, 2021 at 5:10 AM David Marchand wrote: > > Hello William, > > {standard input}: Assembler messages: > {standard input}:7067: Error: invalid register for .seh_savexmm > {standard input}:7069: Error: invalid register for .seh_savexmm > {stand

Re: [dpdk-dev] [PATCH v4 4/4] net/ixgbe: build on Windows

2021-10-06 Thread William Tu
On Tue, Oct 5, 2021 at 10:33 PM Kadam, Pallavi wrote: > > > On 10/5/2021 10:02 AM, William Tu wrote: > > This patch enables building the ixgbe driver for Windows. > > It also enables its dependencies on security and cryptodev. > > I tested on AWS using ixgbe VF device, using dpdk-testpmd. > > > >

Re: [dpdk-dev] [PATCH 1/5] ethdev: add capability to keep flow rules on restart

2021-10-06 Thread Ajit Khaparde
On Mon, Oct 4, 2021 at 5:52 PM wrote: > > From: Dmitry Kozlyuk > > Currently, it is not specified what happens to the flow rules when > the device is stopped, possibly reconfigured, then started. > If flow rules were kept, it could be convenient for application > developers, because they wouldn't

Re: [dpdk-dev] [PATCH 1/2] lib/ethdev: introduce RTE_ETH_DEV_CAPA_FLOW_CREATE_BEFORE_START

2021-10-06 Thread Ajit Khaparde
On Tue, Oct 5, 2021 at 10:29 AM Martin Havlik wrote: > > Not all PMDs allow RTE flow rules to be created before start. > This capability will be set for the ones that allow it. > > Signed-off-by: Martin Havlik Acked-by: Ajit Khaparde > --- > lib/ethdev/rte_ethdev.h | 2 ++ > 1 file changed, 2

Re: [dpdk-dev] [RFC PATCH 2/2] ethdev: add capability to keep indirect actions on restart

2021-10-06 Thread Ajit Khaparde
On Wed, Sep 1, 2021 at 1:55 AM Dmitry Kozlyuk wrote: > > rte_flow_action_handle_create() did not mention what happens > with an indirect action when a device is stopped, possibly reconfigured, > and started again. It is natural for some indirect actions to be > persistent, like counters and meters

Re: [dpdk-dev] [PATCH v8 1/8] bbdev: add big endian processing data processing info

2021-10-06 Thread Chautru, Nicolas
Hi Nipin, As mentioned earlier the bbdev api change related to endianness would be more explicit as an enum. I have put the change here as an adjusted proposal : https://patches.dpdk.org/project/dpdk/patch/1633553929-58670-2-git-send-email-nicolas.chau...@intel.com/ I have also set default valu

[dpdk-dev] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-06 Thread Nicolas Chautru
Adding device information to capture explicitly the assumption of the input/output data byte endianness being processed. Signed-off-by: Nicolas Chautru --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/baseband/acc100/rte_acc100_pmd.c | 1 + drivers/baseband/fpga_5g

[dpdk-dev] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-06 Thread Nicolas Chautru
Suggesting this bbdev api change attached to address the requirement for the new bbdev PMD from this serie : https://patches.dpdk.org/project/dpdk/patch/20211006113112.11163-2-nipun.gu...@nxp.com/ Nipin, please review and you can use this one in case that is okay with you. This is defined as an en

Re: [dpdk-dev] [PATCH v8 8/8] app/bbdev: handle endianness of test data

2021-10-06 Thread Chautru, Nicolas
> -Original Message- > From: nipun.gu...@nxp.com > Sent: Wednesday, October 6, 2021 4:31 AM > To: dev@dpdk.org; gak...@marvell.com; Chautru, Nicolas > > Cc: david.march...@redhat.com; hemant.agra...@nxp.com; Nipun Gupta > > Subject: [PATCH v8 8/8] app/bbdev: handle endianness of test d

Re: [dpdk-dev] [PATCH v1 02/12] ethdev: add eswitch port item to flow API

2021-10-06 Thread Ivan Malov
Hi all, I apologise for sending more mail. In fact, yet another option comes to mind. In order to move away from confusion with "port mirroring" but preserve the "symmetry" flavour in the new name, we can go for "SHADOW_PORT". So, to sum up, I propose the new diagram (see the previous letter

[dpdk-dev] [PATCH] eal/x86: fix some CPU extended features

2021-10-06 Thread David Marchand
Caught while checking CPUID related stuff in OVS. According to [1], for Structured Extended Feature Flags Enumeration Leaf (EAX = 0x07H, ECX = 0): - BMI1 is associated to EBX, bit 3 (was incorrectly 2), - SMEP is associated to EBX, bit 7 (was incorrectly 6), - BMI2 is associated to EBX, bit 8 (wa

Re: [dpdk-dev] [PATCH v1 02/12] ethdev: add eswitch port item to flow API

2021-10-06 Thread Ivan Malov
BTW, one more alternative to "MIRROR_PORT" is "REMOTE_PORT". On 06/10/2021 18:30, Ivan Malov wrote: Hi Ori, By the looks of it, we are starting to run into slight misunderstanding. As I see it, the main consequence of our Sep 14 gathering in Jitsi was understanding of the fact that the concept

Re: [dpdk-dev] [v5] telemetry: fix json output buffer size

2021-10-06 Thread Thomas Monjalon
29/09/2021 06:18, Gowrishankar Muthukrishnan: > Fix json output buffer size for an actual data length. > > Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON") Please could you give a bit more explanations? What was not working and why? [...] > - * This function is not for

Re: [dpdk-dev] [EXT] [PATCH v3 01/10] drivers/crypto: introduce IPsec-mb framework

2021-10-06 Thread Akhil Goyal
> Hi Akhil, > > >> From: Fan Zhang > >> > >> This patch introduces the new framework to share common code > between > >> the SW crypto PMDs that depend on the intel-ipsec-mb library. > >> This change helps to reduce future effort on the code maintenance and > >> feature updates. > >> > >> The PMD

Re: [dpdk-dev] [PATCH v4] eventdev/rx-adapter: fix segfault in queue conf get

2021-10-06 Thread Jerin Jacob
On Fri, Oct 1, 2021 at 11:00 AM Ganapati Kundapura wrote: > > rte_event_eth_rx_adapter_queue_conf_get() segfaults if called > without queue added to the Rx adapter. > > Added check to no queues in Rx adapter and error out on being > called with no queue in Rx adapter. > > Added test case to call q

Re: [dpdk-dev] [PATCH v4 0/7] hide eth dev related structures

2021-10-06 Thread Ali Alnubani
> -Original Message- > From: Ali Alnubani > Sent: Wednesday, October 6, 2021 7:43 PM > To: Konstantin Ananyev ; dev@dpdk.org > Cc: xiaoyun...@intel.com; ano...@marvell.com; jer...@marvell.com; > ndabilpu...@marvell.com; adwiv...@marvell.com; > shepard.sie...@atomicrules.com; ed.cz...@atomic

Re: [dpdk-dev] [PATCH v7 0/2] ethdev: change queue release callback

2021-10-06 Thread Ferruh Yigit
On 10/6/2021 12:18 PM, Xueming Li wrote: This patch is a preparation of shared Rx queue feature[1]. Rxq object could be shared among ports of a share group, a shared rxq object can't tell which port it belongs to. This is the motativation to clean up queue release callback API to use queue ID. v

Re: [dpdk-dev] [PATCH 2/3] ethdev: add flow item/action templates

2021-10-06 Thread Ivan Malov
Hi, On 06/10/2021 07:48, Alexander Kozyrev wrote: Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in an application, many flow rules share a common structure (the same item mask and/or action list) so th

Re: [dpdk-dev] [PATCH v7 2/2] ethdev: change queue release callback

2021-10-06 Thread Ferruh Yigit
On 10/6/2021 12:18 PM, Xueming Li wrote: Currently, most ethdev callback API use queue ID as parameter, but Rx and Tx queue release callback use queue object which is used by Rx and Tx burst data plane callback. To align with other eth device queue configuration callbacks: - queue release callba

Re: [dpdk-dev] [PATCH v2 03/10] bus/fslmc: add qbman debug APIs support

2021-10-06 Thread Nipun Gupta
Fixed and sent a new version. Thanks, Nipun > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 6, 2021 7:02 PM > To: Hemant Agrawal ; Nipun Gupta > > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Sachin Saxena > ; Youri Querry ; Roy > Pledge > Subject: Re: [dpdk-dev] [

[dpdk-dev] [PATCH v3 10/10] common/dpaax: fix paddr to vaddr invalid conversion

2021-10-06 Thread nipun . gupta
From: Gagandeep Singh If some of the VA entries of table are somehow not populated and are NULL, it can add offset to NULL and return the invalid VA in PA to VA conversion. In this patch, adding a check if the VA entry has valid address only then add offset and return VA. Fixes: 2f3d633aa593 ("

[dpdk-dev] [PATCH v3 09/10] raw/dpaa2_qdma: remove checks for lcore ID

2021-10-06 Thread nipun . gupta
From: Nipun Gupta There is no need for preventional check of rte_lcore_id() in data path. This patch removes the same. Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/raw/dpa

[dpdk-dev] [PATCH v3 08/10] raw/dpaa2_qdma: use correct params for config and queue setup

2021-10-06 Thread nipun . gupta
From: Nipun Gupta RAW configure and Queue setup APIs support size parameter for configure. This patch supports the same for DPAA2 QDMA PMD APIs Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 14 +++--- drivers/raw/dpaa2_qdma/rte_p

[dpdk-dev] [PATCH v3 07/10] net/dpaa: add comments to explain driver behaviour

2021-10-06 Thread nipun . gupta
From: Rohit Raj This patch adds comment to explain how dpaa_port_fmc_ccnode_parse function is working to get the HW queue from FMC policy file Signed-off-by: Rohit Raj Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_fmc.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH v3 06/10] net/dpaa2: update RSS to support additional distributions

2021-10-06 Thread nipun . gupta
From: Vanshika Shukla This patch updates the RSS support to support following additional distributions: - VLAN - ESP - AH - PPPOE Signed-off-by: Vanshika Shukla Acked-by: Hemant Agrawal --- drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 70 +- drivers/net/dpaa2/dpaa2_ethdev.

[dpdk-dev] [PATCH v3 05/10] net/dpaa2: add function to generate HW hash key

2021-10-06 Thread nipun . gupta
From: Hemant Agrawal This patch add support to generate the hash key in software equivalent to WRIOP key generation. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/base/dpaa2_tlu_hash.c | 153 drivers/net/dpaa2/meson.build | 1 + drivers/net/dpaa2/rte_

[dpdk-dev] [PATCH v3 04/10] net/dpaa2: add debug print for MTU set for jumbo

2021-10-06 Thread nipun . gupta
From: Hemant Agrawal This patch adds a debug print for MTU configured on the device when jumbo frames are enabled. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2

[dpdk-dev] [PATCH v3 03/10] bus/fslmc: add qbman debug APIs support

2021-10-06 Thread nipun . gupta
From: Hemant Agrawal Add support for debugging qbman FQs Signed-off-by: Youri Querry Signed-off-by: Roy Pledge Signed-off-by: Hemant Agrawal Signed-off-by: Nipun Gupta --- .../bus/fslmc/qbman/include/fsl_qbman_debug.h | 200 +- drivers/bus/fslmc/qbman/qbman_debug.c | 621 +++

[dpdk-dev] [PATCH v3 02/10] net/dpaa2: support Tx flow redirection action

2021-10-06 Thread nipun . gupta
From: Jun Yang TX redirection support by flow action RTE_FLOW_ACTION_TYPE_PHY_PORT and RTE_FLOW_ACTION_TYPE_PORT_ID This action is executed by HW to forward packets between ports. If the ingress packets match the rule, the packets are switched without software involved and perf is improved as we

[dpdk-dev] [PATCH v3 01/10] bus/fslmc: updated MC FW to 10.28

2021-10-06 Thread nipun . gupta
From: Hemant Agrawal Updating MC firmware support APIs to be latest. It supports improved DPDMUX (SRIOV equivalent) for traffic split between dpnis and additional PTP APIs. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/mc/dpdmai.c | 4 +- drivers/bus/fslmc/mc/fsl_dpdmai.h |

[dpdk-dev] [PATCH v3 00/10] NXP DPAAx Bus and PMD changes

2021-10-06 Thread nipun . gupta
From: Nipun Gupta This series adds new functionality related to flow redirection, generating HW hash key etc. It also updates the MC firmware version and includes a fix in dpaxx library. Changes in v1: - Fix checkpatch errors Changes in v2: - remove unrequired multi-tx ordered patch Changes in v

Re: [dpdk-dev] [PATCH v3 16/28] net/cnxk: support inline security setup for cn9k

2021-10-06 Thread Nithin Kumar Dabilpuram
On 10/6/21 9:51 PM, Ferruh Yigit wrote: On 10/1/2021 2:40 PM, Nithin Dabilpuram wrote: +static int +nix_security_release(struct cnxk_eth_dev *dev) +{ +    struct rte_eth_dev *eth_dev = dev->eth_dev; +    struct cnxk_eth_sec_sess *eth_sec, *tvar; +    struct roc_nix *nix = &dev->nix; +    int

Re: [dpdk-dev] [PATCH v1 1/5] devtools: script to remove unused headers includes

2021-10-06 Thread Thomas Monjalon
06/10/2021 18:28, Bruce Richardson: > On Wed, Oct 06, 2021 at 04:19:46PM +0100, Morrissey, Sean wrote: > > > > On 06/10/2021 14:37, Thomas Monjalon wrote: > > > 04/10/2021 12:10, Sean Morrissey: > > > > This script can be used for removing headers flagged for removal by the > > > > include-what-yo

Re: [dpdk-dev] [PATCH v4 0/7] hide eth dev related structures

2021-10-06 Thread Ali Alnubani
> -Original Message- > From: dev On Behalf Of Konstantin Ananyev > Sent: Monday, October 4, 2021 4:56 PM > To: dev@dpdk.org > Cc: xiaoyun...@intel.com; ano...@marvell.com; jer...@marvell.com; > ndabilpu...@marvell.com; adwiv...@marvell.com; > shepard.sie...@atomicrules.com; ed.cz...@atomic

Re: [dpdk-dev] [PATCH v2 5/5] lib/eal: remove unneeded header includes

2021-10-06 Thread David Christensen
On 10/6/21 4:13 AM, Sean Morrissey wrote: These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Reviewed-by: Harry van Haaren Reviewed-by: Mattias Rönnblom --- lib/eal/common/eal_common_dev.c| 5 - lib/eal/common/eal_common_de

Re: [dpdk-dev] [PATCH v2 1/2] net: rename Ethernet header fields

2021-10-06 Thread Thomas Monjalon
01/10/2021 18:33, Dmitry Kozlyuk: > Definition of `rte_ether_addr` structure used a workaround allowing DPDK > and Windows SDK headers to be used in the same file, because Windows SDK > defines `s_addr` as a macro. Rename `s_addr` to `src_addr` and `d_addr` > to `dst_addr` to avoid the conflict and

Re: [dpdk-dev] [PATCH] app/testpmd: Document what the application does.

2021-10-06 Thread Ben Pfaff
On Tue, Sep 14, 2021 at 08:58:31AM +0100, Ferruh Yigit wrote: > On 9/10/2021 6:57 PM, Ben Pfaff wrote: > > I could not find anything in the documentation that says what > > testpmd does. This should save other people time trying to > > figure that out in the future. > > > > Signed-off-by: Ben Pfa

Re: [dpdk-dev] [PATCH v1 1/5] devtools: script to remove unused headers includes

2021-10-06 Thread Bruce Richardson
On Wed, Oct 06, 2021 at 04:19:46PM +0100, Morrissey, Sean wrote: > > On 06/10/2021 14:37, Thomas Monjalon wrote: > > 04/10/2021 12:10, Sean Morrissey: > > > This script can be used for removing headers flagged for removal by the > > > include-what-you-use (IWYU) tool. The script has the ability to

[dpdk-dev] [PATCH] MAINTAINERS: update entry for compressdev

2021-10-06 Thread Fiona Trahe
Replacing myself with Fan as compressdev API maintainer. Signed-off-by: Fiona Trahe --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 278e5b3..2586468 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -438,7 +438,7 @@ F: doc/gui

Re: [dpdk-dev] [PATCH 3/3] ethdev: add async queue-based flow rules operations

2021-10-06 Thread Ivan Malov
Hi, On 06/10/2021 07:48, Alexander Kozyrev wrote: A new, faster, queue-based flow rules management mechanism is needed for applications offloading rules inside the datapath. This asynchronous and lockless mechanism frees the CPU for further packet processing and reduces the performance impact of

Re: [dpdk-dev] [PATCH v3 16/28] net/cnxk: support inline security setup for cn9k

2021-10-06 Thread Ferruh Yigit
On 10/1/2021 2:40 PM, Nithin Dabilpuram wrote: +static int +nix_security_release(struct cnxk_eth_dev *dev) +{ + struct rte_eth_dev *eth_dev = dev->eth_dev; + struct cnxk_eth_sec_sess *eth_sec, *tvar; + struct roc_nix *nix = &dev->nix; + int rc, ret = 0; + + /* Cleanu

[dpdk-dev] [PATCH 08/12] net/mlx5: support TSO offload on Windows

2021-10-06 Thread Tal Shnaiderman
Support of the TSO offloading by checking the relevant FW capability for NIC support. Supported offloads: DEV_TX_OFFLOAD_TCP_TSO DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/net/mlx5/wind

[dpdk-dev] [PATCH 07/12] common/mlx5: read TSO capability from DevX

2021-10-06 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability max_lso_cap to query the NIC for TSO offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common

[dpdk-dev] [PATCH 11/12] common/mlx5: read FCS scattering capability from DevX

2021-10-06 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability scatter_fcs to query the NIC support for the CRC keeping offload. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drive

[dpdk-dev] [PATCH 09/12] common/mlx5: read VLAN capability from DevX

2021-10-06 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability vlan_cap to query the NIC for VLAN stripping support Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx

[dpdk-dev] [PATCH 10/12] net/mlx5: support VLAN stripping offload on Windows

2021-10-06 Thread Tal Shnaiderman
Support of the VLAN stripping offloading by checking the relevant FW capability (vlan_cap) for NIC support. Supported offload: DEV_RX_OFFLOAD_VLAN_STRIP Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/net/mlx5/windows/mlx5_flow_os.h | 1 + drivers/net/mlx5/windows/mlx5_os.c

[dpdk-dev] [PATCH 06/12] net/mlx5: query tunneling support on Windows

2021-10-06 Thread Tal Shnaiderman
Query tunneling supported on the NIC. Save the offloads values in a config parameter. This is needed for the following TSO support: DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/net/mlx5/m

[dpdk-dev] [PATCH 12/12] net/mlx5: support keep-CRC offload on Windows

2021-10-06 Thread Tal Shnaiderman
Support of the keep-CRC offloading by checking the relevant FW capability (scatter_fcs) for NIC support. Supported offload: DEV_RX_OFFLOAD_KEEP_CRC Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/net/mlx5/windows/mlx5_os.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[dpdk-dev] [PATCH 05/12] common/mlx5: read tunneling capabilities from DevX

2021-10-06 Thread Tal Shnaiderman
mlx5 in Windows needs the tunneling hca capabilities to query the NIC for Inner TSO offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++ driv

[dpdk-dev] [PATCH 03/12] net/mlx5: query software parsing support on Windows

2021-10-06 Thread Tal Shnaiderman
Query software parsing supported on the NIC. Save the offloads values in a config parameter. This is needed for the outer IPv4 checksum and IP and UPD tunneled packet TSO support. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c| 16

[dpdk-dev] [PATCH 04/12] net/mlx5: fix tunneling support query

2021-10-06 Thread Tal Shnaiderman
Currently, the PMD decides if the tunneling offload can enable VXLAN/GRE/GENEVE tunneled TSO support by checking config->tunnel_en (single bit) and config->tso. This is incorrect, the right way is to check the following flags returned by the mlx5dv_query_device function: MLX5DV_RAW_PACKET_CAP_TUN

[dpdk-dev] [PATCH 01/12] net/mlx5: fix software parsing support query

2021-10-06 Thread Tal Shnaiderman
Currently, the PMD decides if the software parsing offload can enable outer IPv4 checksum and tunneled TSO support by checking config->hw_csum and config->tso respectively. This is incorrect, the right way is to check the following flags returned by the mlx5dv_query_device function: MLX5DV_SW_PAR

[dpdk-dev] [PATCH 02/12] common/mlx5: read software parsing capabilities from DevX

2021-10-06 Thread Tal Shnaiderman
mlx5 in Windows needs the software parsing hca capabilities to query the NIC for TSO and Checksum offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c |

[dpdk-dev] [PATCH 00/12] Expand NIC offloads support on Windows

2021-10-06 Thread Tal Shnaiderman
The series supports a group of NIC offloads on Windows: DEV_TX_OFFLOAD_TCP_TSO DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO DEV_RX_OFFLOAD_VLAN_STRIP DEV_RX_OFFLOAD_KEEP_CRC Tal Shnaiderman (12): net/mlx5: fix software parsing support query common/mlx5

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-10-06 Thread Ori Kam
Hi Andrew, > -Original Message- > From: dev On Behalf Of Andrew Rybchenko > Sent: Tuesday, September 28, 2021 6:23 PM > Subject: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter > attribute > > Indirect actions should be used to do shared counters. > > Signed-off-by: Andrew R

Re: [dpdk-dev] [EXT] [PATCH v3 01/10] drivers/crypto: introduce IPsec-mb framework

2021-10-06 Thread Power, Ciara
Hi Akhil, >-Original Message- >From: Akhil Goyal >Sent: Wednesday 6 October 2021 14:51 >To: Power, Ciara ; dev@dpdk.org >Cc: Zhang, Roy Fan ; Bronowski, PiotrX >; Thomas Monjalon ; De >Lara Guarch, Pablo ; Ray Kinsella > >Subject: RE: [EXT] [PATCH v3 01/10] drivers/crypto: introduce IPsec

Re: [dpdk-dev] [PATCH v7 1/2] ethdev: make queue release callback optional

2021-10-06 Thread Hemant Agrawal
Acked-by: Hemant Agrawal > -Original Message- > From: Xueming Li > Sent: Wednesday, October 6, 2021 4:48 PM > To: dev@dpdk.org > Cc: xuemi...@nvidia.com; Ferruh Yigit ; Andrew > Rybchenko ; Singh Aman Deep > ; Thomas Monjalon ; > John W. Linville ; Ciara Loftus > ; Qi Zhang ; Hemant > A

Re: [dpdk-dev] [PATCH v1 02/12] ethdev: add eswitch port item to flow API

2021-10-06 Thread Ivan Malov
Hi Ori, By the looks of it, we are starting to run into slight misunderstanding. As I see it, the main consequence of our Sep 14 gathering in Jitsi was understanding of the fact that the concept of item / action PORT_ID is vague and needs a replacement. As a bare minimum, separate items should b

[dpdk-dev] [PATCH v7 2/2] ethdev: change queue release callback

2021-10-06 Thread Xueming Li
Currently, most ethdev callback API use queue ID as parameter, but Rx and Tx queue release callback use queue object which is used by Rx and Tx burst data plane callback. To align with other eth device queue configuration callbacks: - queue release callbacks are changed to use queue ID - all drive

Re: [dpdk-dev] [PATCH v1 1/5] devtools: script to remove unused headers includes

2021-10-06 Thread Morrissey, Sean
On 06/10/2021 14:37, Thomas Monjalon wrote: 04/10/2021 12:10, Sean Morrissey: This script can be used for removing headers flagged for removal by the include-what-you-use (IWYU) tool. The script has the ability to remove headers from specified sub-directories or dpdk as a whole. My fear is th

[dpdk-dev] [PATCH v7 1/2] ethdev: make queue release callback optional

2021-10-06 Thread Xueming Li
Some drivers don't need Rx and Tx queue release callback, make them optional. Clean up empty queue release callbacks for some drivers. Signed-off-by: Xueming Li Reviewed-by: Andrew Rybchenko Acked-by: Ferruh Yigit Acked-by: Thomas Monjalon --- app/test/virtual_pmd.c| 12 --

[dpdk-dev] [PATCH v7 0/2] ethdev: change queue release callback

2021-10-06 Thread Xueming Li
This patch is a preparation of shared Rx queue feature[1]. Rxq object could be shared among ports of a share group, a shared rxq object can't tell which port it belongs to. This is the motativation to clean up queue release callback API to use queue ID. v2: included new NFP PMD driver v3: - commit

Re: [dpdk-dev] [PATCH v2] eal/freebsd: lock memory device to prevent conflicts

2021-10-06 Thread Thomas Monjalon
13/09/2021 16:08, Bruce Richardson: > Only a single DPDK process on the system can be using the /dev/contigmem > mappings at a time, but this was never explicitly enforced, e.g. when > using --in-memory flag on two processes. To prevent possible conflict > issues, we lock the dev node when it's in

Re: [dpdk-dev] [PATCH] examples/kni: add dev close step when kni free

2021-10-06 Thread Thomas Monjalon
21/09/2021 09:48, Ferruh Yigit: > On 9/14/2021 7:02 AM, Min Hu (Connor) wrote: > > From: Huisong Li > > > > This patch adds dev_close() step to release network adapter resources > > when kni free. > > > > Signed-off-by: Huisong Li > > Signed-off-by: Min Hu (Connor) > > Acked-by: Ferruh Yigit

Re: [dpdk-dev] [EXT] [PATCH v3 09/10] crypto/ipsec_mb: add chacha20-poly1305 PMD to framework

2021-10-06 Thread Akhil Goyal
> From: Kai Ji > > Add in new chacha20_poly1305 support in ipsec_mb. > Add in new chacha20_poly1305 test vector for SGL test. > > Signed-off-by: Kai Ji > Signed-off-by: Ciara Power > > --- > v3: > - Fixed some formatting. > - Removed unnecessary get session function. > > v2: > - Added

Re: [dpdk-dev] [EXT] [PATCH v3 04/10] drivers/crypto: move aesni-gcm PMD to IPsec-mb framework

2021-10-06 Thread Akhil Goyal
> diff --git a/drivers/crypto/ipsec_mb/meson.build > b/drivers/crypto/ipsec_mb/meson.build > index bac5d85e26..8550eaee9a 100644 > --- a/drivers/crypto/ipsec_mb/meson.build > +++ b/drivers/crypto/ipsec_mb/meson.build > @@ -23,6 +23,7 @@ endif > > sources = files('rte_ipsec_mb_pmd.c', >

Re: [dpdk-dev] [PATCH v3] ifpga/base/meson: fix looking for librt

2021-10-06 Thread Thomas Monjalon
28/09/2021 06:36, mohamad.noor.alim.hus...@intel.com: > From: Mohamad Noor Alim Hussin > > Finding with "librt" keyword would give the output with > full path of librt such as > /usr/lib/gcc/x86_64-linux-gnu/7/../../../x86_64-linux-gnu/librt.so > instead of -lrt in libdpdk.pc pkg-config file. >

Re: [dpdk-dev] [EXT] [PATCH v3 02/10] crypto/ipsec_mb: add multiprocess support

2021-10-06 Thread Akhil Goyal
> The ipsec_mb SW PMD now has multiprocess support. > The queue-pair IMB_MGR is stored in a memzone instead of being allocated > externally by the Intel IPSec MB library, when v1.1 is used. > If v1.0 is used, multi process is not supported, and allocation is > done as before. > The secondary proces

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-10-06 Thread Somnath Kotur
On Tue, Sep 28, 2021 at 8:53 PM Andrew Rybchenko wrote: > > Indirect actions should be used to do shared counters. > > Signed-off-by: Andrew Rybchenko > --- > app/test-pmd/cmdline_flow.c| 10 -- > doc/guides/prog_guide/rte_flow.rst | 19 +-- > doc/guides/rel_notes/depre

Re: [dpdk-dev] [EXT] [PATCH v3 01/10] drivers/crypto: introduce IPsec-mb framework

2021-10-06 Thread Akhil Goyal
> From: Fan Zhang > > This patch introduces the new framework to share common code between > the SW crypto PMDs that depend on the intel-ipsec-mb library. > This change helps to reduce future effort on the code maintenance and > feature updates. > > The PMDs that will be added to this framework

  1   2   >