Re: [dpdk-dev] [PATCH v2] eal: reword logs for CPU and NUMA counts

2021-09-22 Thread Thomas Monjalon
16/09/2021 12:41, Bruce Richardson: > On Thu, Sep 16, 2021 at 12:39:20PM +0200, Thomas Monjalon wrote: > > 16/09/2021 12:32, Thomas Monjalon: > > > Some logs about cores and nodes were using hypotetic plural (s) form. > > > A fixed plural form with value at the end is preferred. > > > > > > Signed

Re: [dpdk-dev] [PATCH v2] doc: remove references to the old build system

2021-09-22 Thread Thomas Monjalon
23/09/2021 08:47, Thomas Monjalon: > Some docs and comments in Meson files are still mentioning > the old build system based on "make", removed in 20.11. > After one year, such references are better to be removed. > > Signed-off-by: Thomas Monjalon > Acked-by: Bruce Richardson > Acked-by: David

Re: [dpdk-dev] [PATCH v2 0/2] mlx5: support global device syntax

2021-09-22 Thread Xueming(Steven) Li
On Mon, 2021-09-20 at 10:07 +0200, Thomas Monjalon wrote: > 18/01/2021 16:26, Xueming Li: > > Xueming Li (2): > > common/mlx5: support device global syntax > > net/mlx5: support new global device syntax > > > > drivers/common/mlx5/mlx5_common_pci.c | 6 +- > > drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v2] doc: remove references to the old build system

2021-09-22 Thread Thomas Monjalon
Some docs and comments in Meson files are still mentioning the old build system based on "make", removed in 20.11. After one year, such references are better to be removed. Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson Acked-by: David Marchand --- v2: keep comparison with make in bu

Re: [dpdk-dev] [PATCH] doc: remove template comments in old release notes

2021-09-22 Thread Thomas Monjalon
16/09/2021 16:27, David Marchand: > On Wed, Sep 15, 2021 at 6:25 PM Thomas Monjalon wrote: > > > > The release notes comments mention how to generate the documentation > > with the old & removed build system. > > > > Rather than fixing these comments, all old release notes comments > > are removed

Re: [dpdk-dev] [PATCH] lib: remove C++ include guard from private headers

2021-09-22 Thread Thomas Monjalon
15/09/2021 18:46, Thomas Monjalon: > The private headers are compiled internally with a C compiler. > Thus extern "C" declaration is useless in such files. > > Signed-off-by: Thomas Monjalon Applied

[dpdk-dev] [v4] telemetry: fix json output buffer size

2021-09-22 Thread Gowrishankar Muthukrishnan
Fix json output buffer size for a single largest value. Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON") Signed-off-by: Gowrishankar Muthukrishnan --- v4: - corrected typo in commit message. v3: - use "len" param as buffer size. --- lib/telemetry/telemetry_json.h | 5

[dpdk-dev] [v3] telemetry: fix json output buffer size

2021-09-22 Thread Gowrishankar Muthukrishnan
Fix json output buffer size for a single largest value. Also fix compile assertion for the size of output buffer. Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON") Signed-off-by: Gowrishankar Muthukrishnan --- v3: - use "len" param as buffer size. --- lib/telemetry/te

[dpdk-dev] [Bug 812] [build]Meson build failed on OpenSuse15.3 with GCC 7.5.0/clang 11.0.1

2021-09-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=812 Bug ID: 812 Summary: [build]Meson build failed on OpenSuse15.3 with GCC 7.5.0/clang 11.0.1 Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNC

Re: [dpdk-dev] [RFC v2 3/5] ethdev: copy ethdev 'burst' API into separate structure

2021-09-22 Thread Wang, Haiyue
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, September 22, 2021 22:10 > To: dev@dpdk.org > Cc: Li, Xiaoyun ; ano...@marvell.com; > jer...@marvell.com; > ndabilpu...@marvell.com; adwiv...@marvell.com; shepard.sie...@atomicrules.com; > ed.cz...@atomicrules.com; john.m

Re: [dpdk-dev] [v2] telemetry: fix json output buffer size

2021-09-22 Thread Gowrishankar Muthukrishnan
Hi Ciara, > I am not sure about why we would want this to allow for > "RTE_TEL_MAX_SINGLE_STRING_LEN - 6". > The RTE_TEL_MAX_SINGLE_STRING_LEN is used to represent the max size of a > singular string value e.g. the response to client being {"" : " value > here up to max size in length>" } > > I

Re: [dpdk-dev] [RFC v2 2/5] ethdev: change input parameters for rx_queue_count

2021-09-22 Thread Wang, Haiyue
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, September 22, 2021 22:10 > To: dev@dpdk.org > Cc: Li, Xiaoyun ; ano...@marvell.com; > jer...@marvell.com; > ndabilpu...@marvell.com; adwiv...@marvell.com; shepard.sie...@atomicrules.com; > ed.cz...@atomicrules.com; john.m

Re: [dpdk-dev] [PATCH v1] sched: adds function to get 64 bits greatest common divisor

2021-09-22 Thread Xueming(Steven) Li
On Wed, 2021-09-22 at 18:09 +0100, Kevin Traynor wrote: > On 15/09/2021 11:26, Xueming Li wrote: > > This patch adds new function that compute the greatest common > > divisor of 64 bits, also changes the original 32 bits function to call > > this new 64 bits version. > > > > Can you say why it is

Re: [dpdk-dev] [PATCH v5 2/2] app/testpmd: fix txonly forwording

2021-09-22 Thread Zhang, AlvinX
> -Original Message- > From: Ivan Malov > Sent: Thursday, September 23, 2021 12:26 PM > To: Zhang, AlvinX ; Li, Xiaoyun > ; Ananyev, Konstantin > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v5 2/2] app/testpmd: fix txonly forwording > > Hi Alvin, > > There's a typo in the co

Re: [dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests

2021-09-22 Thread Anoob Joseph
Hi Akhil, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Tuesday, September 21, 2021 9:38 PM > To: Anoob Joseph ; Declan Doherty > ; Fan Zhang ; > Konstantin Ananyev ; Ciara Power > > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran

Re: [dpdk-dev] [PATCH v5 2/2] app/testpmd: fix txonly forwording

2021-09-22 Thread Ivan Malov
Hi Alvin, There's a typo in the commit summary: forwording -> forwarding. On 23/09/2021 04:49, Alvin Zhang wrote: When random number of Tx segments is enabled, because the actual number of segments may be only one, the first segment of the Tx packets must accommodate a complete being sending Et

Re: [dpdk-dev] [PATCH] app/testpmd: add cmdline to show LACP bonding info

2021-09-22 Thread Li, Xiaoyun
Hi > -Original Message- > From: dev On Behalf Of Min Hu (Connor) > Sent: Wednesday, September 22, 2021 14:25 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; tho...@monjalon.net > Subject: [dpdk-dev] [PATCH] app/testpmd: add cmdline to show LACP bonding > info > > From: Chengchang Tang > > Add

Re: [dpdk-dev] [PATCH v3 2/2] vhost: add thread-safe API for clearing in-flight packets in async vhost

2021-09-22 Thread Yang, YvonneX
> -Original Message- > From: Wang, YuanX > Sent: Wednesday, September 22, 2021 4:56 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, > Jiayu ; Ding, Xuan ; Jiang, > Cheng1 ; Ma, WenwuX ; > Yang, YvonneX ; Pai G, Sunil > > Subject: [PATCH v3 2/2] vhost: add thre

Re: [dpdk-dev] [PATCH v3 1/2] vhost: support to clear in-flight packets for async dequeue

2021-09-22 Thread Yang, YvonneX
> -Original Message- > From: Wang, YuanX > Sent: Wednesday, September 22, 2021 4:56 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, > Jiayu ; Ding, Xuan ; Jiang, > Cheng1 ; Ma, WenwuX ; > Yang, YvonneX ; Pai G, Sunil > > Subject: [PATCH v3 1/2] vhost: support

Re: [dpdk-dev] [PATCH v3] vhost: add unsafe API to check inflight packets

2021-09-22 Thread Ding, Xuan
Hi, > -Original Message- > From: Kevin Traynor > Sent: Wednesday, September 22, 2021 1:28 AM > To: Ding, Xuan ; dev@dpdk.org; > maxime.coque...@redhat.com; Xia, Chenbo > Cc: Hu, Jiayu ; Jiang, Cheng1 ; > Richardson, Bruce ; Pai G, Sunil > ; Yang, YvonneX > Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH v5 2/2] app/testpmd: fix txonly forwording

2021-09-22 Thread Alvin Zhang
When random number of Tx segments is enabled, because the actual number of segments may be only one, the first segment of the Tx packets must accommodate a complete being sending Eth/IP/UDP packet. Besides, if multiple flow is enabled, the forwarding will update the IP and UDP header, these header

[dpdk-dev] [PATCH v5 1/2] app/testpmd: update forward engine beginning

2021-09-22 Thread Alvin Zhang
For each forward engine, there may be some special conditions must be met before the forwarding runs. Adding checks for these conditions in configuring is not suitable, because one condition may rely on multiple configurations, and the conditions required by each forward engine is not general. Th

Re: [dpdk-dev] [PATCH v4 00/13] enhancements to host based flow table management

2021-09-22 Thread Ajit Khaparde
On Wed, Sep 22, 2021 at 10:36 AM Ferruh Yigit wrote: > > On 9/21/2021 5:50 AM, Ajit Khaparde wrote: > > On Mon, Sep 20, 2021 at 12:42 AM Venkat Duvvuru > > wrote: > >> > >> This patch set adds support for new offload features/enhancments for > >> Thor adapters like VF representor support, new flo

Re: [dpdk-dev] [PATCH 00/12] ice base code batch 2 for DPDK 21.11

2021-09-22 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, September 22, 2021 8:45 PM > To: Zhang, Qi Z ; Guo, Junfeng > ; Yang, Qiming > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 00/12] ice base code batch 2 for DPDK 21.11 > > On 9/17/2021 9:48 AM, Zhang, Qi Z wrote: > > >

[dpdk-dev] Minutes of Technical Board Meeting, 2021-09-08

2021-09-22 Thread Honnappa Nagarahalli
Minutes of Technical Board Meeting, 2021-09-08 Members Attending: 10/12 - Aaron Conole - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Honnappa Nagarahalli (Chair) - Kevin Traynor - Maxime Coquelin - Olivier Matz - Stephen Hemminger - Thomas Monjalon NOTE: The Technical Board meetings take p

[dpdk-dev] [PATCH 3/3] ethdev: implement RTE flex item API

2021-09-22 Thread Viacheslav Ovsiienko
From: Gregory Etelson RTE flex item API was introduced in "ethdev: introduce configurable flexible item" patch. The API allows DPDK application to define parser for custom network header in port hardware and offload flows that will match the custom header elements. Signed-off-by: Gregory Etelso

[dpdk-dev] [PATCH 2/3] ethdev: support flow elements with variable length

2021-09-22 Thread Viacheslav Ovsiienko
From: Gregory Etelson RTE flow API provides RAW item type for packet patterns of variable length. The RAW item structure has fixed size members that describe the variable pattern length and methods to process it. A new RTE flow item type with variable length pattern that does not fit the RAW ite

[dpdk-dev] [PATCH 1/3] ethdev: introduce configurable flexible item

2021-09-22 Thread Viacheslav Ovsiienko
1. Introduction and Retrospective Nowadays the networks are evolving fast and wide, the network structures are getting more and more complicated, the new application areas are emerging. To address these challenges the new network protocols are continuously being developed, considered by technical

[dpdk-dev] [PATCH 0/3] ethdev: introduce configurable flexible item

2021-09-22 Thread Viacheslav Ovsiienko
1. Introduction and Retrospective Nowadays the networks are evolving fast and wide, the network structures are getting more and more complicated, the new application areas are emerging. To address these challenges the new network protocols are continuously being developed, considered by technical

[dpdk-dev] [PATCH] test/hash: use compiler atomics for sync

2021-09-22 Thread Dharmik Thakkar
Convert rte_atomic usages to compiler atomic built-ins for stats sync Signed-off-by: Dharmik Thakkar Reviewed-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test/test_hash_multiwriter.c | 19 app/test/test_hash_readwrite.c | 80 +++- 2 files changed, 45

[dpdk-dev] [PATCH v1] windows/netuio: add Intel 82599 10GbE VF device ID

2021-09-22 Thread William Tu
Add Intel 82599 10GbE Ethernet adapter VF device IDs to netuio inf file in order to enable them on Windows. Signed-off-by: William Tu --- windows/netuio/netuio.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf index d166868..6b45ab0 1

Re: [dpdk-dev] [PATCH v3 3/3] doc: update iavf PMD and 21.11 release notes

2021-09-22 Thread Shukla, Shivanshu
-Original Message- From: Kadam, Pallavi Sent: Thursday, September 9, 2021 4:23 PM To: dev@dpdk.org Cc: tho...@monjalon.net; Zhang, Qi Z ; f...@mellanox.com; narcisa.vas...@microsoft.com; dmitry.kozl...@gmail.com; Yigit, Ferruh ; Wu, Jingjing ; Xing, Beilei ; Menon, Ranjit ; Shukla, Sh

Re: [dpdk-dev] [PATCH v3 2/3] lib/net: fix support of random

2021-09-22 Thread Shukla, Shivanshu
Ack-by: Shivanshu Shukla -Original Message- From: Kadam, Pallavi Sent: Thursday, September 9, 2021 4:23 PM To: dev@dpdk.org Cc: tho...@monjalon.net; Zhang, Qi Z ; f...@mellanox.com; narcisa.vas...@microsoft.com; dmitry.kozl...@gmail.com; Yigit, Ferruh ; Wu, Jingjing ; Xing, Beilei ;

Re: [dpdk-dev] [PATCH v3 1/3] net/iavf: build on Windows

2021-09-22 Thread Shukla, Shivanshu
Ack-by:Shivanshu Shukla -Original Message- From: Kadam, Pallavi Sent: Thursday, September 9, 2021 4:23 PM To: dev@dpdk.org Cc: tho...@monjalon.net; Zhang, Qi Z ; f...@mellanox.com; narcisa.vas...@microsoft.com; dmitry.kozl...@gmail.com; Yigit, Ferruh ; Wu, Jingjing ; Xing, Beilei ; M

Re: [dpdk-dev] [PATCH v3 0/3] Support iavf PMD on Windows

2021-09-22 Thread Shukla, Shivanshu
Ack-by: Shivanshu Shukla -Original Message- From: Kadam, Pallavi Sent: Thursday, September 9, 2021 4:23 PM To: dev@dpdk.org Cc: tho...@monjalon.net; Zhang, Qi Z ; f...@mellanox.com; narcisa.vas...@microsoft.com; dmitry.kozl...@gmail.com; Yigit, Ferruh ; Wu, Jingjing ; Xing, Beilei ;

Re: [dpdk-dev] [PATCH v3 0/3] Support iavf PMD on Windows

2021-09-22 Thread Shukla, Shivanshu
Ack-by: shivanshu.shu...@intel.com On 9/9/2021 4:23 PM, Pallavi Kadam wrote: This patch-set enables building the iavf PMD on Windows. Currently, it uses alarm functions so, depends on following series. Depends-on: series-18447 ("net/iavf: enable interrupt polling") v3 changes: - Fix do

Re: [dpdk-dev] [PATCH 11/12] net/ice/base: implement support for SMA controller

2021-09-22 Thread Machnikowski, Maciej
It's SubMiniature version A - type of external connector we use on our time-enhanced NICs. > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, September 22, 2021 2:44 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: Guo, Junfeng ; dev@dpdk.org; Machnikowski, > Maciej > Subject: Re

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Add support for Windows

2021-09-22 Thread William Tu
I forgot to add the CC list. On Wed, Sep 22, 2021 at 1:58 PM William Tu wrote: > > This patch enables building the ixgbe driver for Windows. > It also enables its dependencies on security and cryptodev. > I tested on AWS using Intel Corporation 82599 Ethernet > Controller Virtual Function [8086:1

[dpdk-dev] [PATCH v2] net/ixgbe: Add support for Windows

2021-09-22 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using Intel Corporation 82599 Ethernet Controller Virtual Function [8086:10ed], using dpdk-testpmd. Signed-off-by: William Tu --- Depends-on: series-18880 ("crypto

[dpdk-dev] [PATCH] bus/pci: fix numa node return value

2021-09-22 Thread Pallavi Kadam
On older CPUs, currently numa_node returns value only for socket 0. Instead, application should be able to make correct decision and also to keep consistent with the Linux code, replace the return value to -1. Fixes: ac7c98d04f2c ("bus/pci: ignore missing NUMA node on Windows") Cc: tal...@nvidia.c

Re: [dpdk-dev] [PATCH] maintainers: sort NXP raw drivers

2021-09-22 Thread Thomas Monjalon
15/09/2021 21:03, David Marchand: > On Wed, Sep 15, 2021 at 6:49 PM Thomas Monjalon wrote: > > > > Drivers are alphabetically sorted. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: David Marchand Applied

Re: [dpdk-dev] [PATCH V3 2/5] common/mlx5: update new MMO HCA capabilities

2021-09-22 Thread Thomas Monjalon
15/09/2021 02:05, Raja Zidane: > New MMO HCA capabilities were added and others were renamed. > Align hca capabilities with new prm. > Add support in devx interface for changes in HCA capabilities. > > Signed-off-by: Raja Zidane > Acked-by: Matan Azrad > --- > --- a/drivers/common/mlx5/mlx5_devx

Re: [dpdk-dev] [dpdk-stable] [PATCH] regex/mlx5: fix RegEx probing error flow

2021-09-22 Thread Thomas Monjalon
01/09/2021 10:11, Ori Kam: > > From: Michael Baum > > > > In RegEx device probing, there is register read trying after context device > > creation. > > > > When the reading fails, the context device was not freed what caused a > > memory leak. > > > > Free it. > > > > Fixes: f324162e8e77 ("reg

Re: [dpdk-dev] [PATCH] net/mlx5: fix empty err msg in mlx5_flow_tunnel_validate

2021-09-22 Thread Thomas Monjalon
Hi, > Signed-off-by: wenxu Please could capitalize your name? Should it be split in 2 words? Convention in DPDK is to have first name first and family name at the end. Thanks

Re: [dpdk-dev] [PATCH v4 00/13] enhancements to host based flow table management

2021-09-22 Thread Ferruh Yigit
On 9/21/2021 5:50 AM, Ajit Khaparde wrote: > On Mon, Sep 20, 2021 at 12:42 AM Venkat Duvvuru > wrote: >> >> This patch set adds support for new offload features/enhancments for >> Thor adapters like VF representor support, new flow matches/actions >> & dynamic SRAM manager support. >> >> Farah Smi

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-22 Thread Jerin Jacob
On Wed, Sep 22, 2021 at 10:06 PM Bruce Richardson wrote: > > On Wed, Sep 22, 2021 at 08:56:50AM +0100, Bruce Richardson wrote: > > On Wed, Sep 22, 2021 at 09:51:42AM +0800, fengchengwen wrote: > > > On 2021/9/22 2:11, Jerin Jacob wrote: > > > > On Tue, Sep 21, 2021 at 10:42 PM Pai G, Sunil > > >

Re: [dpdk-dev] [PATCH v1] sched: adds function to get 64 bits greatest common divisor

2021-09-22 Thread Kevin Traynor
On 15/09/2021 11:26, Xueming Li wrote: This patch adds new function that compute the greatest common divisor of 64 bits, also changes the original 32 bits function to call this new 64 bits version. Can you say why it is needed? It's unused apart from being called for the original 32 bit versi

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-22 Thread Xueming(Steven) Li
On Wed, 2021-09-22 at 11:57 +0100, Ferruh Yigit wrote: > > > > > > <...> > > > > > > > void > > > > -i40e_dev_rx_queue_release(void *rxq) > > > > +i40e_dev_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid) > > > > +{ > > > > + i40e_rx_queue_release(dev->data->rx_queues[qid]); > > > >

[dpdk-dev] [PATCH v2] flow_classify: remove eperimental tag from the API

2021-09-22 Thread Bernard Iremonger
This API was introduced in 17.11, removing experimental tag to promote to stable state. Signed-off-by: Bernard Iremonger --- examples/flow_classify/meson.build| 2 +- lib/flow_classify/rte_flow_classify.h | 7 --- lib/flow_classify/version.map | 2 +- 3 files changed, 2 insertion

Re: [dpdk-dev] [PATCH v4 02/11] dma/ioat: create dmadev instances on PCI probe

2021-09-22 Thread Conor Walsh
On 22/09/2021 09:04, fengchengwen wrote: On 2021/9/17 23:42, Conor Walsh wrote: When a suitable device is found during the PCI probe, create a dmadev instance for each channel. Internal structures and HW definitions required for device creation are also included. Signed-off-by: Conor Walsh R

Re: [dpdk-dev] [PATCH v4 04/11] dma/ioat: add configuration functions

2021-09-22 Thread Conor Walsh
On 22/09/2021 09:08, fengchengwen wrote: On 2021/9/17 23:42, Conor Walsh wrote: Add functions for device configuration. The info_get and close functions are included here also. info_get can be useful for checking successful configuration and close is used by the dmadev api when releasing a con

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-22 Thread Bruce Richardson
On Wed, Sep 22, 2021 at 08:56:50AM +0100, Bruce Richardson wrote: > On Wed, Sep 22, 2021 at 09:51:42AM +0800, fengchengwen wrote: > > On 2021/9/22 2:11, Jerin Jacob wrote: > > > On Tue, Sep 21, 2021 at 10:42 PM Pai G, Sunil > > > wrote: > > >> > > >> Hi Jerin, > > >> > > >> > > >> > > > To u

Re: [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from the API

2021-09-22 Thread Iremonger, Bernard
Hi Kevin, > -Original Message- > From: Kevin Traynor > Sent: Wednesday, September 22, 2021 3:48 PM > To: Iremonger, Bernard ; Kinsella, Ray > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from > the API > > s/eperimental/experimental/ > > On 15/0

Re: [dpdk-dev] [PATCH] doc: announce changes in EFD function

2021-09-22 Thread Ferruh Yigit
On 9/1/2021 4:14 PM, Mcnamara, John wrote: > >> -Original Message- >> From: dev On Behalf Of Pablo de Lara >> Sent: Tuesday, August 31, 2021 3:31 PM >> To: Marohn, Byron ; Wang, Yipeng1 >> >> Cc: dev@dpdk.org; De Lara Guarch, Pablo >> Subject: [dpdk-dev] [PATCH] doc: announce changes in

Re: [dpdk-dev] [EXT] [PATCH v2 4/5] eventdev/rx_adapter: implement per queue event buffer

2021-09-22 Thread Naga Harish K, S V
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, September 22, 2021 2:22 AM > To: Naga Harish K, S V ; Jerin Jacob > Kollanukkaran ; Jayatheerthan, Jay > > Cc: dev@dpdk.org > Subject: RE: [EXT] [dpdk-dev] [PATCH v2 4/5] eventdev/rx_adapter: > implement per qu

Re: [dpdk-dev] [EXT] [PATCH v2 3/5] eventdev/rx_adapter:add per queue event buffer configure support

2021-09-22 Thread Naga Harish K, S V
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, September 22, 2021 2:02 AM > To: Naga Harish K, S V ; Jerin Jacob > Kollanukkaran ; Jayatheerthan, Jay > > Cc: dev@dpdk.org > Subject: RE: [EXT] [dpdk-dev] [PATCH v2 3/5] eventdev/rx_adapter:add per > queue eve

Re: [dpdk-dev] [PATCH v2] examples/l3fwd: add changes to use event vector

2021-09-22 Thread Shijith Thotton
>04/09/2021 09:46, Shijith Thotton: >> +* ``--enable-vector:`` Optional, Enable event vectorization. Only valid if >> -- >mode=eventdev. > >As for the IPsec example, the option name --event-vector >would be more appropriate because "vector" can refer to something else. > Will change option name t

Re: [dpdk-dev] [EXT] [PATCH v2 2/5] test/event: add unit test for event buffer size config api

2021-09-22 Thread Naga Harish K, S V
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, September 22, 2021 1:58 AM > To: Naga Harish K, S V ; Jerin Jacob > Kollanukkaran ; Jayatheerthan, Jay > > Cc: dev@dpdk.org > Subject: RE: [EXT] [dpdk-dev] [PATCH v2 2/5] test/event: add unit test for > event b

Re: [dpdk-dev] [EXT] [PATCH v2 1/5] eventdev/rx_adapter: add support to configure event buffer size

2021-09-22 Thread Naga Harish K, S V
Hi Pavan, > -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, September 22, 2021 1:55 AM > To: Naga Harish K, S V ; Jerin Jacob > Kollanukkaran ; Jayatheerthan, Jay > > Cc: dev@dpdk.org; Kundapura, Ganapati > Subject: RE: [EXT] [dpdk-dev] [PATCH v2 1/5] eventdev/

Re: [dpdk-dev] [PATCH v2 3/5] eventdev/rx_adapter:add per queue event buffer configure support

2021-09-22 Thread Naga Harish K, S V
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Tuesday, September 21, 2021 9:55 PM > To: Naga Harish K, S V > Cc: Jerin Jacob ; Jayatheerthan, Jay > ; dpdk-dev > Subject: Re: [dpdk-dev] [PATCH v2 3/5] eventdev/rx_adapter:add per queue > event buffer configure support > > On

[dpdk-dev] [PATCH v3 5/5] test/event: add unit test for Rx adapter

2021-09-22 Thread Naga Harish K S V
this patch adds unit tests for checking per rx queue event buffer feature using rte_event_eth_rx_adapter_queue_add api. Signed-off-by: Naga Harish K S V --- app/test/test_event_eth_rx_adapter.c | 86 1 file changed, 86 insertions(+) diff --git a/app/test/test_event_

[dpdk-dev] [PATCH v3 4/5] eventdev/rx_adapter: implement per queue event buffer

2021-09-22 Thread Naga Harish K S V
this patch implement the per queue event buffer with required validations. Signed-off-by: Naga Harish K S V --- lib/eventdev/rte_event_eth_rx_adapter.c | 187 +--- 1 file changed, 138 insertions(+), 49 deletions(-) diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/

[dpdk-dev] [PATCH v3 3/5] eventdev/rx_adapter: introduce per queue event buffer

2021-09-22 Thread Naga Harish K S V
To configure per queue event buffer size, application sets ``rte_event_eth_rx_adapter_params::use_queue_event_buf`` flag as true and is passed to ``rte_event_eth_rx_adapter_create_with_params`` api. The per queue event buffer size is populated in ``rte_event_eth_rx_adapter_queue_conf::event_buf_s

[dpdk-dev] [PATCH v3 2/5] test/event: add unit test for Rx adapter

2021-09-22 Thread Naga Harish K S V
this patch adds unit test for rte_event_eth_rx_adapter_create_with_params api and validate all possible input combinations. Signed-off-by: Naga Harish K S V --- app/test/test_event_eth_rx_adapter.c | 53 +--- 1 file changed, 49 insertions(+), 4 deletions(-) diff --git a/

[dpdk-dev] [PATCH v3 1/5] eventdev/rx_adapter: add event buffer size configurability

2021-09-22 Thread Naga Harish K S V
Currently event buffer is static array with a default size defined internally. To configure event buffer size from application, ``rte_event_eth_rx_adapter_create_with_params`` api is added which takes ``struct rte_event_eth_rx_adapter_params`` to configure event buffer size in addition other param

Re: [dpdk-dev] [RFC 0/7] hide eth dev related structures

2021-09-22 Thread Ananyev, Konstantin
> > Hi Jerin, > > > > > > NOTE: This is just an RFC to start further discussion and collect the > > > > feedback. > > > > Due to significant amount of work, changes required are applied only to > > > > two > > > > PMDs so far: net/i40e and net/ice. > > > > So to build it you'll need to add: > >

Re: [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from the API

2021-09-22 Thread Kevin Traynor
s/eperimental/experimental/ On 15/09/2021 16:16, Bernard Iremonger wrote: This API was introduced in 17.11, removing experimental tag to promote to stable state. Signed-off-by: Bernard Iremonger --- lib/flow_classify/rte_flow_classify.h | 7 --- lib/flow_classify/version.map | 2

[dpdk-dev] [RFC v2 5/5] ethdev: hide eth dev related structures

2021-09-22 Thread Konstantin Ananyev
Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related data into private header (ethdev_driver.h). Make changes to keep DPDK building after that. Remove references to 'rte_eth_devices[]' from test-pmd. Signed-off-by: Konstantin Ananyev --- app/test-pmd/config.c

[dpdk-dev] [RFC v2 4/5] ethdev: make burst functions to use new flat array

2021-09-22 Thread Konstantin Ananyev
Rework 'fast' burst functions to use rte_eth_burst_api[]. While it is an API/ABI breakage, this change is intended to be transparent for both users (no changes in user app is required) and PMD developers (no changes in PMD is required). One extra thing to note - RX/TX callback invocation will cause

[dpdk-dev] [RFC v2 3/5] ethdev: copy ethdev 'burst' API into separate structure

2021-09-22 Thread Konstantin Ananyev
Copy public function pointers (rx_pkt_burst(), etc.) and related pointers to internal data from rte_eth_dev structure into a separate flat array. We can keep it public to still use inline functions for 'fast' calls (like rte_eth_rx_burst(), etc.) to avoid/minimize slowdown. The intention is to make

[dpdk-dev] [RFC v2 2/5] ethdev: change input parameters for rx_queue_count

2021-09-22 Thread Konstantin Ananyev
Currently majority of 'fast' ethdev ops take pointers to internal queue data structures as an input parameter. While eth_rx_queue_count() takes a pointer to rte_eth_dev and queue index. For future work to hide rte_eth_devices[] and friends it would be plausible to unify parameters list of all 'fast

[dpdk-dev] [RFC v2 1/5] ethdev: allocate max space for internal queue array

2021-09-22 Thread Konstantin Ananyev
At queue configure stage always allocate space for maximum possible number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer pointer to internal queue data without extra checking of current number of configured queues. That would help

[dpdk-dev] [RFC v2 0/5] hide eth dev related structures

2021-09-22 Thread Konstantin Ananyev
The aim of these patch series is to make rte_ethdev core data structures (rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback, etc.) internal to DPDK and not visible to the user. That should allow future possible changes to core ethdev related structures to be transparent to the user and help to i

Re: [dpdk-dev] [PATCH v5 1/3] eal/linux: make hugetlbfs analysis reusable

2021-09-22 Thread John Levon
On Tue, Sep 21, 2021 at 11:16:30AM +0300, dkozl...@nvidia.com wrote: > From: Dmitry Kozlyuk > > get_hugepage_dir() searched for a hugetlbfs mount with a given page size > using handcraft parsing of /proc/mounts and mixing traversal logic with > selecting the needed entry. Separate code to enumer

Re: [dpdk-dev] [PATCH v3 3/4] net/i40e: fix memzone leak when re-configure the RX/TX queues

2021-09-22 Thread Wang, Haiyue
> -Original Message- > From: Yunjian Wang > Sent: Wednesday, September 22, 2021 21:30 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Xing, Beilei > ; Yang, Qiming > ; Zhang, Qi Z ; > dingxiaoxi...@huawei.com; Yunjian Wang > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v3 3/4] net/i40e: fix me

Re: [dpdk-dev] [PATCH 11/12] net/ice/base: implement support for SMA controller

2021-09-22 Thread Ferruh Yigit
On 9/22/2021 1:56 PM, Machnikowski, Maciej wrote: > It's SubMiniature version A - type of external connector we use on our > time-enhanced NICs. > Thanks, will use it in the commit log as "SMA (SubMiniature version A) ..." >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday

Re: [dpdk-dev] [PATCH v3 2/4] net/ice: fix memzone leak when re-configure the RX/TX queues

2021-09-22 Thread Wang, Haiyue
> -Original Message- > From: Yunjian Wang > Sent: Wednesday, September 22, 2021 21:29 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Xing, Beilei > ; Yang, Qiming > ; Zhang, Qi Z ; > dingxiaoxi...@huawei.com; Yunjian Wang > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v3 2/4] net/ice: fix mem

Re: [dpdk-dev] [PATCH v3 4/4] net/ixgbe: fix memzone leak when re-configure the RX/TX queues

2021-09-22 Thread Wang, Haiyue
> -Original Message- > From: Yunjian Wang > Sent: Wednesday, September 22, 2021 21:30 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Xing, Beilei > ; Yang, Qiming > ; Zhang, Qi Z ; > dingxiaoxi...@huawei.com; Yunjian Wang > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v3 4/4] net/ixgbe: fix m

Re: [dpdk-dev] [PATCH v3 1/4] net/e1000: fix memzone leak when re-configure the RX/TX queues

2021-09-22 Thread Wang, Haiyue
> -Original Message- > From: Yunjian Wang > Sent: Wednesday, September 22, 2021 21:28 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Xing, Beilei > ; Yang, Qiming > ; Zhang, Qi Z ; > dingxiaoxi...@huawei.com; Yunjian Wang > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v3 1/4] net/e1000: fix m

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-22 Thread Xueming(Steven) Li
Hi Ferruh, Appreciate for the careful check! On Tue, 2021-09-21 at 19:13 +0100, Ferruh Yigit wrote: > On 9/18/2021 1:35 PM, Xueming Li wrote: > > Currently, most ethdev callback API use queue ID as parameter, but Rx > > and Tx queue release callback use queue object which is used by Rx and > > T

[dpdk-dev] [PATCH v3 4/4] net/ixgbe: fix memzone leak when re-configure the RX/TX queues

2021-09-22 Thread Yunjian Wang
Normally when closing the device the queue memzone should be freed. But the memzone will be not freed, when device setup ops like: rte_eth_bond_slave_remove -->__eth_bond_slave_remove_lock_free >slave_remove -->rte_eth_dev_internal_reset >rte_eth_dev_rx_queue_config -->eth_

[dpdk-dev] [PATCH v3 3/4] net/i40e: fix memzone leak when re-configure the RX/TX queues

2021-09-22 Thread Yunjian Wang
Normally when closing the device the queue memzone should be freed. But the memzone will be not freed, when device setup ops like: rte_eth_bond_slave_remove -->__eth_bond_slave_remove_lock_free >slave_remove -->rte_eth_dev_internal_reset >rte_eth_dev_rx_queue_config -->eth_

[dpdk-dev] [PATCH v3 2/4] net/ice: fix memzone leak when re-configure the RX/TX queues

2021-09-22 Thread Yunjian Wang
Normally when closing the device the queue memzone should be freed. But the memzone will be not freed, when device setup ops like: rte_eth_bond_slave_remove -->__eth_bond_slave_remove_lock_free >slave_remove -->rte_eth_dev_internal_reset >rte_eth_dev_rx_queue_config -->eth_

[dpdk-dev] [PATCH v3 1/4] net/e1000: fix memzone leak when re-configure the RX/TX queues

2021-09-22 Thread Yunjian Wang
Normally when closing the device the queue memzone should be freed. But the memzone will be not freed, when device setup ops like: rte_eth_bond_slave_remove -->__eth_bond_slave_remove_lock_free >slave_remove -->rte_eth_dev_internal_reset >rte_eth_dev_rx_queue_config -->eth_

[dpdk-dev] [PATCH v3 0/4] fixes for intel drivers

2021-09-22 Thread Yunjian Wang
This series for fixing memzone leak when re-configure the RX/TX queues for igb, ixgbe, i40e, ice & em drivers. --- v3: * 1. Update commit log * 2. And ice fdir rxq/txq memzones are freed v2: * Update commit log Yunjian Wang (4): net/e1000: fix memzone leak when re-configure the RX/TX

Re: [dpdk-dev] [PATCH v6 10/10] ipsec: add ol_flags support

2021-09-22 Thread Zhang, Roy Fan
> -Original Message- > From: Nicolau, Radu > Sent: Friday, September 17, 2021 10:18 AM > To: Ananyev, Konstantin ; Iremonger, > Bernard ; Medvedkin, Vladimir > > Cc: dev@dpdk.org; m...@ashroe.eu; Richardson, Bruce > ; Zhang, Roy Fan ; > hemant.agra...@nxp.com; gak...@marvell.com; ano...@m

Re: [dpdk-dev] [PATCH 00/12] ice base code batch 2 for DPDK 21.11

2021-09-22 Thread Ferruh Yigit
On 9/17/2021 9:48 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Guo, Junfeng >> Sent: Friday, September 17, 2021 10:14 AM >> To: Zhang, Qi Z ; Yang, Qiming >> >> Cc: dev@dpdk.org >> Subject: RE: [PATCH 00/12] ice base code batch 2 for DPDK 21.11 >> >> >> >>> -Original Me

Re: [dpdk-dev] [PATCH 11/12] net/ice/base: implement support for SMA controller

2021-09-22 Thread Ferruh Yigit
On 9/16/2021 10:53 AM, Qi Zhang wrote: > Add support for controlling SMA connectors using GPIO get/set AQs. > > Signed-off-by: Maciej Machnikowski > Signed-off-by: Qi Zhang > --- > drivers/net/ice/base/ice_ptp_hw.c | 213 ++ > drivers/net/ice/base/ice_ptp_hw.h | 11

[dpdk-dev] [PATCH v4 1/2] eal: add additional info if core list too long

2021-09-22 Thread David Hunt
If the user requests to use an lcore above 128 using -l, the eal will exit with "EAL: invalid core list syntax" and very little else useful information. This patch adds some extra information suggesting to use --lcores so that physical cores above RTE_MAX_LCORE (default 128) can be used. This is a

[dpdk-dev] [PATCH v4 2/2] eal: add additional info if core mask too long

2021-09-22 Thread David Hunt
If the user requests to use an lcore above 128 using -c, the eal will exit with "EAL: invalid core list syntax" and very little else useful information. This patch adds some extra information suggesting to use --lcores so that physical cores above RTE_MAX_LCORE (default 128) can be used. This is a

Re: [dpdk-dev] [PATCH v2 1/5] net/virtio: add initial RSS support

2021-09-22 Thread Maxime Coquelin
On 9/22/21 13:20, Andrew Rybchenko wrote: On 9/22/21 12:57 PM, Maxime Coquelin wrote: Provide the capability to update the hash key, hash types and RETA table on the fly (without needing to stop/start the device). However, the key length and the number of RETA entries are fixed to 40B and 128

Re: [dpdk-dev] [PATCH v2 3/5] app/testpmd: fix RSS type display

2021-09-22 Thread Li, Xiaoyun
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, September 22, 2021 17:58 > To: dev@dpdk.org; Xia, Chenbo ; > amore...@redhat.com; david.march...@redhat.com; > andrew.rybche...@oktetlabs.ru; Yigit, Ferruh ; > michae...@nvidia.com; viachesl...@nvidia.com; Li, Xiaoyun > > C

Re: [dpdk-dev] [PATCH v2 4/4] net/ixgbe: delete HW rings when releasing queues

2021-09-22 Thread Wang, Haiyue
> -Original Message- > From: wangyunjian > Sent: Wednesday, September 22, 2021 19:14 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; Zhang, Qi Z > ; dingxiaoxiong > Subject: RE: [dpdk-dev] [PATCH v2 4/4] net/ixgbe: delete HW rings when > releasing queues > > >

Re: [dpdk-dev] [PATCH v2 5/5] app/testpmd: add missing flow types in port info

2021-09-22 Thread Li, Xiaoyun
Hi > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, September 22, 2021 17:58 > To: dev@dpdk.org; Xia, Chenbo ; > amore...@redhat.com; david.march...@redhat.com; > andrew.rybche...@oktetlabs.ru; Yigit, Ferruh ; > michae...@nvidia.com; viachesl...@nvidia.com; Li, Xiaoyun > >

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-09-22 Thread Xia, Chenbo
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, September 22, 2021 5:27 PM > To: Xia, Chenbo ; Burakov, Anatoly > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent > > On 9/22/2021 4:30 AM, Xia, Chenbo wrote: > > Hi Anatoly, > >

Re: [dpdk-dev] [PATCH v2 2/5] app/testpmd: fix RSS key length

2021-09-22 Thread Li, Xiaoyun
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, September 22, 2021 17:58 > To: dev@dpdk.org; Xia, Chenbo ; > amore...@redhat.com; david.march...@redhat.com; > andrew.rybche...@oktetlabs.ru; Yigit, Ferruh ; > michae...@nvidia.com; viachesl...@nvidia.com; Li, Xiaoyun > > Cc:

Re: [dpdk-dev] [PATCH v2 1/5] net/virtio: add initial RSS support

2021-09-22 Thread Andrew Rybchenko
On 9/22/21 12:57 PM, Maxime Coquelin wrote: > Provide the capability to update the hash key, hash types > and RETA table on the fly (without needing to stop/start > the device). However, the key length and the number of RETA > entries are fixed to 40B and 128 entries respectively. This > is done in

Re: [dpdk-dev] [PATCH v5 1/2] eventdev: add rx queue conf get api

2021-09-22 Thread Kundapura, Ganapati
Hi Jerin, > -Original Message- > From: Kundapura, Ganapati > Sent: 20 September 2021 14:44 > To: Jerin Jacob > Cc: Jayatheerthan, Jay ; dpdk-dev > ; Yigit, Ferruh > Subject: RE: [PATCH v5 1/2] eventdev: add rx queue conf get api > > Hi Jerin, > > > -Original Message- > > From:

Re: [dpdk-dev] [PATCH v2 4/4] net/ixgbe: delete HW rings when releasing queues

2021-09-22 Thread wangyunjian
> -Original Message- > From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > Sent: Wednesday, September 22, 2021 3:05 PM > To: wangyunjian ; dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; Zhang, Qi Z ; dingxiaoxiong > > Subject: RE: [dpdk-dev] [PATCH v2 4/4] net/ixgbe: delete HW rings

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-22 Thread Ferruh Yigit
On 9/22/2021 10:35 AM, Xueming(Steven) Li wrote: > Hi Ferruh, > > Appreciate for the careful check! > > On Tue, 2021-09-21 at 19:13 +0100, Ferruh Yigit wrote: >> On 9/18/2021 1:35 PM, Xueming Li wrote: >>> Currently, most ethdev callback API use queue ID as parameter, but Rx >>> and Tx queue rel

  1   2   >