Re: [dpdk-dev] [PATCH] eal: add log to print dpdk version at start

2021-08-31 Thread Andrew Rybchenko
On 9/1/21 9:18 AM, Aman Singh wrote: >>From the logs it is difficult to get the DPDK version > that was used. So added a debug log to print the same. > The log has been added in eal_init so it gets printed > at startup for any application. > > Signed-off-by: Aman Singh > --- > lib/eal/freebsd/ea

Re: [dpdk-dev] [PATCH v3 4/4] mbuf: make rte_mbuf_check part of stable API

2021-08-31 Thread Andrew Rybchenko
On 9/1/21 9:46 AM, Andrew Rybchenko wrote: > On 8/31/21 10:35 PM, Stephen Hemminger wrote: >> This one has been in for required time period. >> >> Signed-off-by: Stephen Hemminger > > Experimental warning should be removed from the description. Apologies, there is no experimental warning in the

Re: [dpdk-dev] [EXT] Re: [RFC 11/15] eventdev: reserve fields in timer object

2021-08-31 Thread Pavan Nikhilesh Bhagavatula
>On Tue, 24 Aug 2021 01:10:15 +0530 > wrote: > >> From: Pavan Nikhilesh >> >> Reserve fields in rte_event_timer data structure to address future >> use cases. >> Also, remove volatile from rte_event_timer. >> >> Signed-off-by: Pavan Nikhilesh > >Reserve fields are not a good idea. They don't solv

Re: [dpdk-dev] [PATCH v3 4/4] mbuf: make rte_mbuf_check part of stable API

2021-08-31 Thread Andrew Rybchenko
On 8/31/21 10:35 PM, Stephen Hemminger wrote: > This one has been in for required time period. > > Signed-off-by: Stephen Hemminger Experimental warning should be removed from the description. Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v3 3/4] mbuf: make rte_mbuf_tx_offload as stable

2021-08-31 Thread Andrew Rybchenko
On 8/31/21 10:35 PM, Stephen Hemminger wrote: > This function should be made stable now. > > Also, fix the docbook comment format. > > Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value") > Cc: konstantin.anan...@intel.com > Signed-off-by: Stephen Hemminger I'm not sure t

Re: [dpdk-dev] [PATCH v3 2/4] mbuf: make rte_mbuf_dynfield API's stable

2021-08-31 Thread Andrew Rybchenko
On 8/31/21 10:35 PM, Stephen Hemminger wrote: > These functions to register dynamic fields were added in 20.11 > and should be promoted to stable. > > Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v3 1/4] mbuf: make rte_pktmbuf_free_bulk and rte_pktmbuf_copy stable API's

2021-08-31 Thread Andrew Rybchenko
On 8/31/21 10:35 PM, Stephen Hemminger wrote: > These two functions were added in 20.11 as experimental. > Time to promote the to stable status. > > Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [RFC 12/15] eventdev: move timer adapters memory to hugepage

2021-08-31 Thread Pavan Nikhilesh Bhagavatula
>Hi Pavan, > >> -Original Message- >> From: pbhagavat...@marvell.com >> Sent: Monday, August 23, 2021 2:40 PM >> To: jer...@marvell.com; Carrillo, Erik G >> Cc: Ananyev, Konstantin ; >dev@dpdk.org; >> Pavan Nikhilesh >> Subject: [dpdk-dev] [RFC 12/15] eventdev: move timer adapters >memor

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix mac resourece leak

2021-08-31 Thread Wang, Haiyue
> -Original Message- > From: Qiming Chen > Sent: Tuesday, August 31, 2021 22:22 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Qiming Chen > ; sta...@dpdk.org > Subject: [PATCH v2] net/ixgbe: fix mac resourece leak > > In the eth_ixgbevf_dev_init and eth_ixgbe_dev_init functions, memory is > al

Re: [dpdk-dev] [RFC] Control packet event adapter and FIFO library

2021-08-31 Thread Jerin Jacob
On Wed, Sep 1, 2021 at 11:12 AM Kaladi, Ashok K wrote: > > Dear dpdk-dev team, > > We would like to propose the following RFC for your review. > > A user space application may need access to the packets handled by eventdev > based DPDK application. This application doesn't use mbuf or eventdev bas

Re: [dpdk-dev] [PATCH 2/2] net/ice: fix generic build on FreeBSD

2021-08-31 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Monday, August 30, 2021 4:18 PM > To: Richardson, Bruce ; dev@dpdk.org > Cc: brian90...@gmail.com; Lu, Wenzhuo ; > sta...@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Subject: RE: [PATCH 2/2] net/ice: fix generic build on FreeBSD > > > > --

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix generic build on FreeBSD

2021-08-31 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Bruce Richardson > Sent: Thursday, August 19, 2021 12:38 AM > To: dev@dpdk.org > Cc: brian90...@gmail.com; Richardson, Bruce ; > Lu, Wenzhuo ; sta...@dpdk.org; Xing, Beilei > > Subject: [dpdk-dev] [PATCH 1/2] net/i40e: fix generic build on

[dpdk-dev] [PATCH] eal: add log to print dpdk version at start

2021-08-31 Thread Aman Singh
>From the logs it is difficult to get the DPDK version that was used. So added a debug log to print the same. The log has been added in eal_init so it gets printed at startup for any application. Signed-off-by: Aman Singh --- lib/eal/freebsd/eal.c | 2 +- lib/eal/linux/eal.c | 2 +- lib/eal/wi

Re: [dpdk-dev] [PATCH] net/ixgbe: fix rx multicst count isn't clear

2021-08-31 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Monday, August 30, 2021 12:32 PM > To: Qiming Chen ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix rx multicst count isn't clear > > > -Original Message- > > From: Qiming Ch

[dpdk-dev] [PATCH 1/2] vfio: allow partially unmapping adjacent memory

2021-08-31 Thread Xuan Ding
Currently, if we map a memory area A, then map a separate memory area B that by coincidence happens to be adjacent to A, current implementation will merge these two segments into one, and if partial unmapping is not supported, these segments will then be only allowed to be unmapped in one go. In ot

[dpdk-dev] [PATCH 2/2] vhost: enable IOMMU for async vhost

2021-08-31 Thread Xuan Ding
The use of IOMMU has many advantages, such as isolation and address translation. This patch extends the capbility of DMA engine to use IOMMU if the DMA device is bound to vfio. When set memory table, the guest memory will be mapped into the default container of DPDK. Signed-off-by: Xuan Ding ---

[dpdk-dev] [RFC] Control packet event adapter and FIFO library

2021-08-31 Thread Kaladi, Ashok K
Dear dpdk-dev team, We would like to propose the following RFC for your review. A user space application may need access to the packets handled by eventdev based DPDK application. This application doesn't use mbuf or eventdev based DPDK APIs. Presently this is not possible without passing packets

[dpdk-dev] [PATCH 0/2] *** support IOMMU for DMA device ***

2021-08-31 Thread Xuan Ding
This series adds support for DMA device to use vfio. The first patch is to extend current vfio dma mapping API to allow partial unmapping for adjacent memory if the platform does not support partial unmapping. Xuan Ding (2): vfio: allow partially unmapping adjacent memory vhost: enable IOMMU f

[dpdk-dev] [PATCH v1 3/3] ethdev: promote burst mode API to stable

2021-08-31 Thread Haiyue Wang
The DPDK Symbol Bot reports: Please note the symbols listed below have expired. In line with the DPDK ABI policy, they should be scheduled for removal, in the next DPDK release. Symbol rte_eth_rx_burst_mode_get rte_eth_tx_burst_mode_get Signed-off-by: Haiyue Wang --- lib/ethdev/rte_ethdev.h | 2

[dpdk-dev] [PATCH v1 2/3] net/ice: promote some API to stable

2021-08-31 Thread Haiyue Wang
The DPDK Symbol Bot reports: Please note the symbols listed below have expired. In line with the DPDK ABI policy, they should be scheduled for removal, in the next DPDK release. Symbol rte_net_ice_dynfield_proto_xtr_metadata_offs rte_net_ice_dynflag_proto_xtr_vlan_mask rte_net_ice_dynflag_proto_xt

[dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable

2021-08-31 Thread Haiyue Wang
The DPDK Symbol Bot reports: Please note the symbols listed below have expired. In line with the DPDK ABI policy, they should be scheduled for removal, in the next DPDK release. Symbol rte_pmd_ixgbe_mdio_lock rte_pmd_ixgbe_mdio_unlock rte_pmd_ixgbe_mdio_unlocked_read rte_pmd_ixgbe_mdio_unlocked_wr

[dpdk-dev] [PATCH v1 0/3] Promote some API to stable

2021-08-31 Thread Haiyue Wang
According to DPDK ABI Policy, section 3.5.3. https://doc.dpdk.org/guides/contributing/abi_policy.html Promote some API reported by DPDK Symbol Bot to stable. Haiyue Wang (3): net/ixgbe: promote some API to stable net/ice: promote some API to stable ethdev: promote burst mode API to stable

[dpdk-dev] [PATCH] net/ice: enable CVL DCF device reset API

2021-08-31 Thread dapengx . yu
From: Dapeng Yu DCF PMD needs to support rte_eth_dev_reset, the reason is when a DCF instance is killed, all the flow rules still exists in hardware, when DCF gets to reconnect, it already lost the flow context, and if the application wants to create new rules, it may fail due to firmware reports

Re: [dpdk-dev] [PATCH v4] ethdev: fix representor port ID search by name

2021-08-31 Thread Xing, Beilei
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, September 1, 2021 12:06 AM > To: Ajit Khaparde ; Somnath Kotur > ; Daley, John ; > Hyong Youb Kim ; Xing, Beilei ; > Yang, Qiming ; Zhang, Qi Z ; > Wang, Haiyue ; Matan Azrad > ; Shahaf Shuler ; Viacheslav > Ovsiienko ; Th

Re: [dpdk-dev] [EXT] Re: [PATCH] common/cnxk: add ROC API to merge base steering rule

2021-08-31 Thread Satheesh Paul
Please find reply inline. -Original Message- From: Kinsella, Ray Sent: 31 August 2021 09:11 PM To: Satheesh Paul ; Nithin Kumar Dabilpuram ; Kiran Kumar Kokkilagadda ; Sunil Kumar Kori ; Satha Koteswara Rao Kottidi Cc: dev@dpdk.org Subject: [EXT] Re: [dpdk-dev] [PATCH] common/cnxk: a

Re: [dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring

2021-08-31 Thread Li Feng
ping... BTW, how could I retrigger the failure CI? The failure is not about this patch. Thanks, Feng Li Li Feng 于2021年8月27日周五 下午1:16写道: > > When getting reqs from the avail ring, the id may exceed inflight > queue size. Then the dpdk will crash forever. > > Signed-off-by: Li Feng > --- > lib/v

Re: [dpdk-dev] [PATCH v1] bbdev: remove experimental tag from API

2021-08-31 Thread Hemant Agrawal
> > On Tue, Aug 31, 2021 at 6:27 PM Nicolas Chautru > wrote: > > > > This was previously suggested last year > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc > > hes.dpdk.org%2Fproject%2Fdpdk%2Fpatch%2F1593213242-157394-2-git- > send-e > > mail- > nicolas.chautru%40int

[dpdk-dev] [PATCH v2 3/3] doc: remove i40evf related documentation

2021-08-31 Thread Robin Zhang
As announced in the deprecation note, i40evf has been removed. So removing deprecation notice and other i40evf related documentation. Signed-off-by: Robin Zhang --- doc/guides/howto/lm_bond_virtio_sriov.rst | 4 ++-- doc/guides/nics/intel_vf.rst | 8 +--- doc/guides/rel_notes/de

[dpdk-dev] [PATCH v2 2/3] net/iavf: remove i40evf devargs option

2021-08-31 Thread Robin Zhang
Due to i40evf will be removed, so there's no need to keep the devargs option "driver=i40evf" in iavf. Signed-off-by: Robin Zhang --- drivers/net/iavf/iavf_ethdev.c | 52 ++ 1 file changed, 2 insertions(+), 50 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev

[dpdk-dev] [PATCH v2 1/3] net/i40e: remove i40evf

2021-08-31 Thread Robin Zhang
The default VF driver for Intel 700 Series Ethernet Controller already switch to iavf in DPDK 21.05. And i40evf is no need to maintain now, so remove i40evf related code. Signed-off-by: Robin Zhang --- drivers/net/i40e/i40e_ethdev.h|1 - drivers/net/i40e/i40e_ethdev_vf.c | 3015 -

[dpdk-dev] [PATCH v2 0/3] net/i40e: remove i40evf

2021-08-31 Thread Robin Zhang
In DPDK 21.05, iavf already became the default VF for i40e devices. So remove i40evf due to it's no need to maintain now. v2: - update 21.11 release note, remove some missed documentation. Robin Zhang (3): net/i40e: remove i40evf net/iavf: remove i40evf devargs option doc: remove i40evf rel

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix mbuf leak

2021-08-31 Thread Wang, Haiyue
Please reply with plain text format. ;-) This is better: Fixes: af75078fece3 ("first public release") From: Qiming Chen Sent: Wednesday, September 1, 2021 09:51 To: ktray...@redhat.com Cc: dev@dpdk.org; Wang, Haiyue ; sta...@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix mbuf leak

[dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

2021-08-31 Thread Xiaoyun Li
Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API that was introduced in 18.11 and have been around for 11 releases. Signed-off-by: Xiaoyun Li --- lib/ethdev/rte_ethdev.h | 4 lib/ethdev/version.map | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/li

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix mbuf leak

2021-08-31 Thread Qiming Chen
This is already the oldest commit node in git, and it has not been recorded before。 Which commit should I fill in? | | Qiming Chen | | chenqiming_hua...@163.com | 签名由网易邮箱大师定制 On 8/31/2021 18:00,Kevin Traynor wrote: On 31/08/2021 09:06, Qiming Chen wrote: A local test found that repeated port s

Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping

2021-08-31 Thread Ding, Xuan
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, September 1, 2021 12:01 AM > To: Ding, Xuan ; dev@dpdk.org; Burakov, Anatoly > > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, > Jiayu ; Richardson, Bruce > Subject: Re: [PATCH] doc: announce change in vfio dma

[dpdk-dev] [PATCH] crypto/mlx5: support timestamp format

2021-08-31 Thread Michael Baum
This patch adds support for the timestamp format settings for the receive and send queues. If the firmware version x.30.1000 or above is installed and the NIC timestamps are configured with the real-time format, the default zero values for newly added fields cause the queue creation to fail. The p

[dpdk-dev] [PATCH] compress/mlx5: fix QP setup error flow

2021-08-31 Thread Michael Baum
The QP setup function allocates buffer for its opaque MR and register it into MR structure. After buffer alloction and before MR registration, it tries allocate MR Btree. When the MR Btree allocation fails, the buffer was not freed what caused a memory leak. Allocate the MR Btree before buffer al

[dpdk-dev] [PATCH 6/6] common/mlx5: fix resource cleanliness in a device remove

2021-08-31 Thread Michael Baum
The common remove function call in a loop to remove function for each driver which have been registered. If all removes are succeeded, it return 0 without to free the device which allocated in probe function. Otherwise, it free the device. In fact we expect exactly the opposite behavior. If all re

[dpdk-dev] [PATCH] regex/mlx5: fix RegEx probing error flow

2021-08-31 Thread Michael Baum
In RegEx device probing, there is register read trying after context device creation. When the reading fails, the context device was not freed what caused a memory leak. Free it. Fixes: f324162e8e77 ("regex/mlx5: support combined rule file") Cc: sta...@dpdk.org Signed-off-by: Michael Baum ---

[dpdk-dev] [PATCH 5/6] common/mlx5: fix device list operation concurrency

2021-08-31 Thread Michael Baum
The MLX5 common driver has a global list of mlx5 devices which are probed. In probe function it create one and insert it to the list. Similarly it removes the device in remove function. These operations are not safe as there can be such operations in parallel, by different threads. Add global loc

[dpdk-dev] [PATCH 4/6] common/mlx5: fix class combination validation

2021-08-31 Thread Michael Baum
The common probe function gets as a user argument the classes it should create, and checks whether the combination is valid. In case the device already exists, it checks the integration of the above with the classes that the device has. However, the function does not check the combination when the

[dpdk-dev] [PATCH 0/6] mlx5: some independent fixes

2021-08-31 Thread Michael Baum
Some independent fixes in mlx5 net and common driver. Michael Baum (6): net/mlx5: fix shared device context creation error flow net/mlx5: fix PCI probing error flow net/mlx5: fix allow duplicate pattern devarg default common/mlx5: fix class combination validation common/mlx5: fix device

[dpdk-dev] [PATCH 2/6] net/mlx5: fix PCI probing error flow

2021-08-31 Thread Michael Baum
In PCI probing, there is internal probe function that is called several times for several PFs. When one of them fails, the previous PFs are not destroyed what may cause a memory leak. Destroy them. Fixes: 08c2772fc747 ("net/mlx5: support list of representor PF") Cc: sta...@dpdk.org Signed-off-b

[dpdk-dev] [PATCH 3/6] net/mlx5: fix allow duplicate pattern devarg default

2021-08-31 Thread Michael Baum
In order to allow\disallow configuring rules with identical patterns, the new device argument 'allow_duplicate_pattern' was introduced. The default is to allow, and it is initialized to 1 in PCI probe function. However, on auxiliary bus probing (for Sub-Function) it is not initialized at all, so i

[dpdk-dev] [PATCH 1/6] net/mlx5: fix shared device context creation error flow

2021-08-31 Thread Michael Baum
In shared device context creation, there are two validations after MR btree memory allocation. When one of them fails, the MR btree memory was not freed what caused a memory leak. Free it. Fixes: 632f0f19056f ("net/mlx5: manage shared counters in three-level table") Cc: sta...@dpdk.org Signed-o

[dpdk-dev] Canceled: DTS improvement WG - Debate/triag inputs

2021-08-31 Thread Honnappa Nagarahalli
Hello, I am not ready yet from my side with the summary excel sheet/slides. I will schedule one once I am ready. Thanks, Honnappa Hello, We will continuing debating/triaging the inputs from [1]. As discussed, I am blocking the calendar for next 4 weeks.

[dpdk-dev] [PATCH] rib: promote experimental API's to stable

2021-08-31 Thread Stephen Hemminger
The rib and rib6 API's have been in since 19.11 and should be marked as stable. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib.h | 18 -- lib/rib/rte_rib6.h | 18 -- lib/rib/version.map | 2 +- 3 files changed, 1 insertion(+), 37 deletions(-) diff --git

[dpdk-dev] [PATCH] eal: make rte_lcore_cpuset and rte_lcore_to_cpu_id stable

2021-08-31 Thread Stephen Hemminger
These were converted from inline to functions in 19.11 and should be marked as stable now. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_lcore.h | 8 lib/eal/version.map | 4 ++-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/eal/include/rte_lcor

[dpdk-dev] [PATCH] net: make rte_ether_unformat_addr stable

2021-08-31 Thread Stephen Hemminger
This function has been in since 19.11. Signed-off-by: Stephen Hemminger --- lib/net/rte_ether.h | 1 - lib/net/version.map | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/net/rte_ether.h b/lib/net/rte_ether.h index 7ee5e9a292cc..478003699c2d 100644 --- a/lib/net/rte_eth

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-08-31 Thread Bruce Richardson
On Tue, Aug 31, 2021 at 09:50:43PM +0530, Kamaraj P wrote: > Thanks David. Will check it out. > > BTW are there any steps where DPDK testpmd can run as a non privileged user > mode ( with any driver )? > Please share if you have any pointers. > > Thanks, > Kamaraj > Not sure if this is generally

[dpdk-dev] [PATCH v3 4/4] mbuf: make rte_mbuf_check part of stable API

2021-08-31 Thread Stephen Hemminger
This one has been in for required time period. Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf.h | 1 - lib/mbuf/version.map | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h index 627790fe26e7..c70330f09dd8 100644 --- a/lib/m

[dpdk-dev] [PATCH v3 3/4] mbuf: make rte_mbuf_tx_offload as stable

2021-08-31 Thread Stephen Hemminger
This function should be made stable now. Also, fix the docbook comment format. Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value") Cc: konstantin.anan...@intel.com Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf.h | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

[dpdk-dev] [PATCH v3 2/4] mbuf: make rte_mbuf_dynfield API's stable

2021-08-31 Thread Stephen Hemminger
These functions to register dynamic fields were added in 20.11 and should be promoted to stable. Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf_dyn.h | 15 --- lib/mbuf/version.map| 18 +- 2 files changed, 9 insertions(+), 24 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH v3 1/4] mbuf: make rte_pktmbuf_free_bulk and rte_pktmbuf_copy stable API's

2021-08-31 Thread Stephen Hemminger
These two functions were added in 20.11 as experimental. Time to promote the to stable status. Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf.h | 2 -- lib/mbuf/version.map | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h

[dpdk-dev] [PATCH v3 0/4] mbuf: promote experimental API's to stable

2021-08-31 Thread Stephen Hemminger
These experimental API's in mbuf should be changed to officially supported. v3 - add rte_mbuf_check Stephen Hemminger (4): mbuf: take experimental of mbuf copy and bulk free mbuf: remove experimental from dynamic field support mbuf: mark function rte_mbuf_tx_offload with __rte_expermental

Re: [dpdk-dev] [PATCH] eal: promote register type and pick level API as stable

2021-08-31 Thread Kinsella, Ray
On 31/08/2021 19:14, Ivan Malov wrote: > This one might be quite mature to be attested as stable. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > --- Acked-by: Ray Kinsella

[dpdk-dev] [PATCH] eal: promote register type and pick level API as stable

2021-08-31 Thread Ivan Malov
This one might be quite mature to be attested as stable. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- lib/eal/include/rte_log.h | 4 lib/eal/version.map | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/eal/include/rte_log.h b/lib/eal/include/rt

Re: [dpdk-dev] [PATCH] lib/cmdline: release cl when cmdline exit

2021-08-31 Thread Dmitry Kozlyuk
2021-08-31 10:28 (UTC+0800), zhihongx.p...@intel.com: > From: Zhihong Peng > > Malloc cl in the cmdline_stdin_new function, so release in the > cmdline_stdin_exit function is logical, so that cl will not be > released alone. > > Fixes: af75078fece3 (first public release) > Cc: sta...@dpdk.org >

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-08-31 Thread Aaron Conole
David Marchand writes: > On Tue, Aug 31, 2021 at 5:27 PM Kamaraj P wrote: >> >> Hi Thomas, >> We are trying with the IGB_UIO driver in our DPDK application. > > Running with igb-uio as a non priviledged user is not possible (or, at > best, makes little sense). > > >> Is there any documentation w

Re: [dpdk-dev] [PATCH v2 13/13] app/test: enable subset of unit tests on Windows

2021-08-31 Thread Dmitry Kozlyuk
2021-08-31 10:01 (UTC-0700), Jie Zhou: > On Sun, Aug 29, 2021 at 01:18:12AM +0300, Dmitry Kozlyuk wrote: > > 2021-08-18 10:13 (UTC-0700), Jie Zhou: > > > In app/test/meson.build > > > - Specify the subset of source files to compile on Windows > > > - Specify the subset of tests to be enabled on W

Re: [dpdk-dev] [PATCH] bus/vmbus: map to the correct ring buffer addresses for the secondary process

2021-08-31 Thread Stephen Hemminger
On Mon, 30 Aug 2021 22:56:44 -0700 lon...@linuxonhyperv.com wrote: > From: Long Li > > The driver code had wrong assumption that all the addresses to ring buffers > in the secondary process are the same as those in the primary process. This > is not always correct as the channels could be mapped

Re: [dpdk-dev] [PATCH v2 02/13] driver/mempool: build mempool stack on Windows

2021-08-31 Thread Jie Zhou
On Sun, Aug 29, 2021 at 01:43:13AM +0300, Dmitry Kozlyuk wrote: > 2021-08-18 10:13 (UTC-0700), Jie Zhou: > > mempool_autotest failed on Windows at setting the "stack" handler > > test case. Per debugging, in rte_mempool_ops_table, there are only > > 6 ring ops registered, and no "stack" ops registe

Re: [dpdk-dev] [PATCH v2 13/13] app/test: enable subset of unit tests on Windows

2021-08-31 Thread Jie Zhou
On Sun, Aug 29, 2021 at 01:18:12AM +0300, Dmitry Kozlyuk wrote: > 2021-08-18 10:13 (UTC-0700), Jie Zhou: > > In app/test/meson.build > > - Specify the subset of source files to compile on Windows > > - Specify the subset of tests to be enabled on Windows > > Signed-off-by: Jie Zhou > > --- > > ap

Re: [dpdk-dev] [PATCH] lib/cmdline: release cl when cmdline exit

2021-08-31 Thread Stephen Hemminger
On Tue, 31 Aug 2021 10:28:44 +0800 zhihongx.p...@intel.com wrote: > From: Zhihong Peng > > Malloc cl in the cmdline_stdin_new function, so release in the > cmdline_stdin_exit function is logical, so that cl will not be > released alone. > > Fixes: af75078fece3 (first public release) > Cc: sta..

Re: [dpdk-dev] [PATCH v2 12/13] app/test: replace .sh scripts with .py scripts

2021-08-31 Thread Jie Zhou
On Sun, Aug 29, 2021 at 01:17:38AM +0300, Dmitry Kozlyuk wrote: > 2021-08-18 10:13 (UTC-0700), Jie Zhou: > > - Add python scripts to get coremask and check hugepage config > > - Remove two corresponding .sh scripts > > - Replace calling of .sh with corresponding .py in meson.build > > There are mu

Re: [dpdk-dev] [PATCH v1] bbdev: remove experimental tag from API

2021-08-31 Thread David Marchand
On Tue, Aug 31, 2021 at 6:27 PM Nicolas Chautru wrote: > > This was previously suggested last year > https://patches.dpdk.org/project/dpdk/patch/1593213242-157394-2-git-send-email-nicolas.chau...@intel.com/ > but there was request from community to wait another year to confirm formally > this ap

Re: [dpdk-dev] [PATCH v4] ethdev: fix representor port ID search by name

2021-08-31 Thread Andrew Rybchenko
On 8/31/21 7:32 PM, Wang, Haiyue wrote: >> -Original Message- >> From: Andrew Rybchenko >> Sent: Wednesday, September 1, 2021 00:06 >> To: Ajit Khaparde ; Somnath Kotur >> ; Daley, >> John ; Hyong Youb Kim ; Xing, Beilei >> ; >> Yang, Qiming ; Zhang, Qi Z ; >> Wang, Haiyue >> ; Matan Az

Re: [dpdk-dev] [PATCH v4] ethdev: fix representor port ID search by name

2021-08-31 Thread Wang, Haiyue
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, September 1, 2021 00:06 > To: Ajit Khaparde ; Somnath Kotur > ; Daley, > John ; Hyong Youb Kim ; Xing, Beilei > ; > Yang, Qiming ; Zhang, Qi Z ; > Wang, Haiyue > ; Matan Azrad ; Shahaf Shuler > ; > Viacheslav Ovsiienko ;

[dpdk-dev] [PATCH v1] bbdev: remove experimental tag from API

2021-08-31 Thread Nicolas Chautru
This promotes the bbdev interface to stable. Overdue for some time as bbdev interface has been stable. Signed-off-by: Nicolas Chautru --- doc/guides/rel_notes/release_21_11.rst | 2 ++ lib/bbdev/rte_bbdev.h | 32 lib/bbdev/rte_bbdev_op.h

[dpdk-dev] [PATCH v1] bbdev: remove experimental tag from API

2021-08-31 Thread Nicolas Chautru
Sending again this change to move bbdev to stable API. This was previously suggested last year https://patches.dpdk.org/project/dpdk/patch/1593213242-157394-2-git-send-email-nicolas.chau...@intel.com/ but there was request from community to wait another year to confirm formally this api is mature

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-08-31 Thread Kamaraj P
Thanks David. Will check it out. BTW are there any steps where DPDK testpmd can run as a non privileged user mode ( with any driver )? Please share if you have any pointers. Thanks, Kamaraj On Tue, Aug 31, 2021 at 9:05 PM David Marchand wrote: > On Tue, Aug 31, 2021 at 5:27 PM Kamaraj P wrote

[dpdk-dev] [PATCH v2] app/testpmd: add command to print representor info

2021-08-31 Thread Andrew Rybchenko
From: Viacheslav Galaktionov Make it simpler to debug configurations and code related to the representor info API. Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- v2: - change output format to log just one line per range app/test-pmd/c

Re: [dpdk-dev] [PATCH] examples/service_cores: fix lcore count check

2021-08-31 Thread Van Haaren, Harry
> -Original Message- > From: Ruifeng Wang > Sent: Monday, August 30, 2021 9:04 AM > To: Van Haaren, Harry ; Varghese, Vipin > > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; > n...@arm.com; honnappa.nagaraha...@arm.com; Ruifeng Wang > ; sta...@dpdk.org > Subject: [PATC

[dpdk-dev] [PATCH v4] ethdev: fix representor port ID search by name

2021-08-31 Thread Andrew Rybchenko
From: Viacheslav Galaktionov Getting a list of representors from a representor does not make sense. Instead, a parent device should be used. To this end, extend the rte_eth_dev_data structure to include the port ID of the backing device for representors. Signed-off-by: Viacheslav Galaktionov S

Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping

2021-08-31 Thread Ferruh Yigit
On 8/31/2021 2:10 PM, Xuan Ding wrote: > Currently, the VFIO subsystem will compact adjacent DMA regions for the > purposes of saving space in the internal list of mappings. This has a > side effect of compacting two separate mappings that just happen to be > adjacent in memory. Since VFIO implemen

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix minimum descriptor sizes

2021-08-31 Thread Ferruh Yigit
On 8/23/2021 8:59 AM, heinrich.k...@corigine.com wrote: > From: Heinrich Kuhn > > The NFP4000/6000 supports a minimum of 256 Tx/Rx descriptors and not 64. > Before this patch when a DPDK application configured < 256 Tx > descriptors the hardware read/write pointers would be unmasked and not > wra

Re: [dpdk-dev] [PATCH] maintainers: update for NFP

2021-08-31 Thread Ferruh Yigit
On 8/23/2021 9:29 AM, heinrich.k...@corigine.com wrote: > From: Heinrich Kuhn > > Some of Netronome's activities and people have moved over to Corigine, > including NFP PMD maintenance and myself. > > Signed-off-by: Heinrich Kuhn Applied to dpdk-next-net/main, thanks.

[dpdk-dev] [PATCH v2 2/2] net/virtio: fix virtio-user Rx interrupts with multi queue

2021-08-31 Thread David Marchand
The callfds[] array stores eventfds sequentially for Rx and Tx vq. Fixes: 3d4fb6fd2505 ("net/virtio-user: support Rx interrupt") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[dpdk-dev] [PATCH v2 1/2] net/virtio: reconfigure LSC handler when required

2021-08-31 Thread David Marchand
There is no reason to re-register a interrupt handler for LSC if this feature was not requested in the first place. A simple usecase is when asking for Rx interrupts without LSC interrupt. Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts") Cc: sta...@dpdk.org Signed-off-by: David March

[dpdk-dev] [PATCH v2 0/2] virtio-user interrupt fixes

2021-08-31 Thread David Marchand
Trying to use virtio-user as a replacement for taps in OVS, I ended up with some fixes on the interrupt side. The patches for OVS are not ready yet, but sending the DPDK fixes in any case. @CI guys: Patch 2 probably means there is a hole in the virtio-user interrupt test plan in DTS (I could not f

Re: [dpdk-dev] [RFC 2/7] eal/interrupts: implement get set APIs

2021-08-31 Thread Kinsella, Ray
On 26/08/2021 15:57, Harman Kalra wrote: > Implementing get set APIs for interrupt handle fields. > To make any change to the interrupt handle fields, one > should make use of these APIs. > > Signed-off-by: Harman Kalra > --- > lib/eal/common/eal_common_interrupts.c | 506

Re: [dpdk-dev] [RFC 1/7] eal: interrupt handle API prototypes

2021-08-31 Thread Kinsella, Ray
On 26/08/2021 15:57, Harman Kalra wrote: > Defining protypes of get/set APIs for accessing/manipulating > interrupt handle fields. > > Internal interrupt header i.e. rte_eal_interrupt.h is rearranged, > as APIs defined are moved to rte_interrupts.h and epoll specific > definitions are moved to

Re: [dpdk-dev] [EXT] [PATCH] doc: announce library refactor for ABI improvement

2021-08-31 Thread Kinsella, Ray
On 26/08/2021 16:44, Andrew Rybchenko wrote: > On 8/26/21 2:04 PM, Bruce Richardson wrote: >> On Thu, Aug 26, 2021 at 10:46:35AM +, Akhil Goyal wrote: Target is to reduce the public interface surface to improve the ABI stability and this is preparation for the longer term stable AB

Re: [dpdk-dev] [PATCH 5/8] crypto/cnxk: add cn9k crypto adapter fast path ops

2021-08-31 Thread Kinsella, Ray
On 30/08/2021 12:09, Shijith Thotton wrote: > Added crypto adapter enqueue and dequeue operations for CN9K. > > Signed-off-by: Shijith Thotton > --- > drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 235 --- > drivers/crypto/cnxk/cn9k_cryptodev_ops.h | 6 + > drivers/crypto/c

Re: [dpdk-dev] [PATCH 7/8] crypto/cnxk: add cn10k crypto adapter fast path ops

2021-08-31 Thread Kinsella, Ray
On 30/08/2021 12:09, Shijith Thotton wrote: > Added crypto adapter enqueue and dequeue operations for CN10K. > > Signed-off-by: Shijith Thotton > --- > drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 95 +++ > drivers/crypto/cnxk/cn10k_cryptodev_ops.h | 6 ++ > drivers/crypto

Re: [dpdk-dev] [PATCH v2] ethdev: fix representor port ID search by name

2021-08-31 Thread Andrew Rybchenko
On 8/29/21 3:17 PM, Xueming(Steven) Li wrote: > > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Sunday, August 29, 2021 4:23 PM >> To: Xueming(Steven) Li ; Viacheslav Galaktionov >> >> Cc: Ajit Khaparde ; Somnath Kotur >> ; John Daley >> ; Hyong Youb Kim ; Beilei Xing >> ;

Re: [dpdk-dev] [PATCH v3] ethdev: fix representor port ID search by name

2021-08-31 Thread Andrew Rybchenko
On 8/20/21 3:18 PM, Andrew Rybchenko wrote: > From: Viacheslav Galaktionov > > Getting a list of representors from a representor does not make sense. > Instead, a parent device should be used. > > To this end, extend the rte_eth_dev_data structure to include the port ID > of the parent device fo

Re: [dpdk-dev] [PATCH] common/cnxk: add ROC API to merge base steering rule

2021-08-31 Thread Kinsella, Ray
On 31/08/2021 05:16, psathe...@marvell.com wrote: > From: Satheesh Paul > > This patch adds an ROC API to merge base steering rule with rules > added by VF. > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kumar Kokkilagadda > --- > drivers/common/cnxk/roc_npc.c | 27 +++

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-08-31 Thread David Marchand
On Tue, Aug 31, 2021 at 5:27 PM Kamaraj P wrote: > > Hi Thomas, > We are trying with the IGB_UIO driver in our DPDK application. Running with igb-uio as a non priviledged user is not possible (or, at best, makes little sense). > Is there any documentation where we need to start to run a DPDK ap

Re: [dpdk-dev] [PATCH] net/af_packet: try to reinsert the stripped vlan tag

2021-08-31 Thread Ferruh Yigit
On 8/20/2021 1:46 PM, Tudor Cornea wrote: > The af_packet pmd driver binds to a raw socket and allows > sending and receiving of packets through the kernel. > > Since commit bcc6d47903 [1], the kernel strips the vlan tags early in > __netif_receive_skb_core(), so we receive untagged packets while

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-08-31 Thread Kamaraj P
Hi Thomas, We are trying with the IGB_UIO driver in our DPDK application. Is there any documentation where we need to start to run a DPDK application with minimal system capability? Also please let us know if there is any known dependency with DPDK versions (dpdk application with 18, 19.11 versions

Re: [dpdk-dev] [PATCH 0/3] net/i40e: remove i40evf

2021-08-31 Thread Kinsella, Ray
Please check dpdk documentation for references to i40evf also. See guides/nics/intel_vf.rst and guides/howto/lm_bond_virtio_sriov.rst. On 30/08/2021 04:12, Robin Zhang wrote: > In DPDK 21.05, iavf already became the default VF for i40e devices. > So remove i40evf due to it's no need to maintain n

Re: [dpdk-dev] [PATCH] app/testpmd: configurable number of flows in flowgen

2021-08-31 Thread Ferruh Yigit
On 8/23/2021 12:08 PM, Li, Xiaoyun wrote: > Hi > >> -Original Message- >> From: Zhihong Wang >> Sent: Thursday, August 19, 2021 20:36 >> To: dev@dpdk.org; Yigit, Ferruh ; Li, Xiaoyun >> ; Singh, Aman Deep ; >> irussk...@marvell.com; cchempara...@tilera.com >> Cc: Zhihong Wang >> Subject:

Re: [dpdk-dev] [PATCH v2] doc: fix CI typo warnings

2021-08-31 Thread Kinsella, Ray
On 23/08/2021 16:18, Aaron Conole wrote: > Ray Kinsella writes: > >> Fix documentation typos that are generating spurious CI warnings. >> >> Signed-off-by: Ray Kinsella >> --- >> v2: >> * Fix some additional typos pointed out by Aaron Conole >> >> doc/guides/rel_notes/deprecation.rst

[dpdk-dev] [PATCH v10 3/3] maintainers: add new abi scripts

2021-08-31 Thread Ray Kinsella
Add new abi management scripts to the MAINTAINERS file. Signed-off-by: Ray Kinsella --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 266f5ac1da..ff8245271f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -129,6 +129,8 @@ F: devtools/gen-abi.sh

[dpdk-dev] [PATCH v10 1/3] devtools: script to track symbols over releases

2021-08-31 Thread Ray Kinsella
This script tracks the growth of stable and experimental symbols over releases since v19.11. The script has the ability to count the added symbols between two dpdk releases, and to list experimental symbols present in two dpdk releases (expired symbols). example usages: Count symbols added since

[dpdk-dev] [PATCH v10 2/3] devtools: script to send notifications of expired symbols

2021-08-31 Thread Ray Kinsella
Use this script with the output of the DPDK symbol tool, to notify maintainers of expired symbols by email. You need to define the environment variable DPDK_GETMAINTAINER_PATH for this tool to work. Use terminal output to review the emails before sending. e.g. $ devtools/symbol-tool.py list-expire

[dpdk-dev] [PATCH v10 0/3] devtools: scripts to count and track symbols

2021-08-31 Thread Ray Kinsella
Scripts to count and track the lifecycle of DPDK symbols. The symbol-tool script reports on the growth of symbols over releases and list expired symbols. The notify-symbol-maintainers script consumes the input from symbol-tool and generates email notifications of expired symbols. v2: reworked to

[dpdk-dev] [PATCH v4] net/virtio: fix repeated memory free of vq

2021-08-31 Thread Gaoxiang Liu
When virtio_init_queue returns error, the memory of vq is freed. But the value of hw->vqs[queue_idx] does not restore. If virtio_init_queue returns error, the memory of vq is freed again in virtio_free_queues. Fixes: 69c80d4ef89b ("net/virtio: allocate queue at init stage") Cc: sta...@dpdk.org Si

[dpdk-dev] [PATCH] doc: announce changes in EFD function

2021-08-31 Thread Pablo de Lara
Signed-off-by: Pablo de Lara --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 76a4abfd6b..e9fdbd1cdd 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guide

  1   2   >