[dpdk-dev] [PATCH RFC] net/ena: Add Windows support.

2021-08-13 Thread William Tu
I don't have a physical Windows testbed so I want to see if I can get virtual nic working, in this case ENA driver on AWS. The patch passes build on Windows, but I haven't tested loading the ena driver. I want to know if this is the right direction, or whether I also need to change other places in

[dpdk-dev] [PATCH v6] eal: remove sys/queue.h from public headers.

2021-08-13 Thread William Tu
Currently there are some public headers that include 'sys/queue.h', which is not POSIX, but usually provided by the Linux/BSD system library. (Not in POSIX.1, POSIX.1-2001, or POSIX.1-2008. Present on the BSDs.) The file is missing on Windows. During the Windows build, DPDK uses a bundled copy, so

Re: [dpdk-dev] [PATCHv5] eal: remove sys/queue.h from public headers.

2021-08-13 Thread William Tu
Hi Dmitry, Thanks for your feedback! On Fri, Aug 13, 2021 at 11:59 AM Dmitry Kozlyuk wrote: > > 2021-08-13 03:36 (UTC+), William Tu: > > Currently there are some public headers that include 'sys/queue.h', which > > is not POSIX, but usually provided by the Linux/BSD system library. > > (Not i

[dpdk-dev] [PATCH 3/4] examples/pipeline: add support for learner tables

2021-08-13 Thread Cristian Dumitrescu
Add application-level support for learner tables. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 174 1 file changed, 174 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index a29be05ef4..ad6e3db8d7 100644 -

[dpdk-dev] [PATCH 4/4] examples/pipeline: add learner table example

2021-08-13 Thread Cristian Dumitrescu
Added the files to illustrate the learner table usage. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/examples/learner.cli | 35 examples/pipeline/examples/learner.spec | 109 2 files changed, 144 insertions(+) create mode 100644 examples/pipeline/e

[dpdk-dev] [PATCH 1/4] table: add support learner tables

2021-08-13 Thread Cristian Dumitrescu
A learner table is typically used for learning or connection tracking, where it allows for the implementation of the "add on miss" scenario: whenever the lookup key is not found in the table (lookup miss), the data plane can decide to add this key to the table with a given action with no control pl

[dpdk-dev] [PATCH 2/4] pipeline: add support for learner tables

2021-08-13 Thread Cristian Dumitrescu
Add pipeline level support for learner tables. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_ctl.c | 479 - lib/pipeline/rte_swx_ctl.h | 185 + lib/pipeline/rte_swx_pipeline.c | 988 +-- lib/pipeline/rte_swx_pipeline.

Re: [dpdk-dev] [PATCH v2] bus/vmbus: Fix crash when handling packets in secondary process

2021-08-13 Thread Jonathan Erb
The first part makes sense. There are several ways to iterate over all the subchannels. I'm probably not fully understanding the second part. vmbus_uio_map_secondary_subchan() wants to map to br->vbr but that does not appear to be initialized anywhere. In fact, it looks like we should set br-

[dpdk-dev] Failsafe PMD - Attach to Secondary Process

2021-08-13 Thread Kumara Parameshwaran
Hi, Recently I was using the failsafe PMD with multi process scenario and found the secondary process was not working as expected. . I saw you were mentioned as the maintainer for this PMD. I have attached the patch, please let me know if this is okay. I think in the following commit, the fail

Re: [dpdk-dev] [PATCHv5] eal: remove sys/queue.h from public headers.

2021-08-13 Thread Dmitry Kozlyuk
2021-08-13 03:36 (UTC+), William Tu: > Currently there are some public headers that include 'sys/queue.h', which > is not POSIX, but usually provided by the Linux/BSD system library. > (Not in POSIX.1, POSIX.1-2001, or POSIX.1-2008. Present on the BSDs.) > The file is missing on Windows. During

Re: [dpdk-dev] [20.11.3] test/power: fix CPU frequency when turbo enabled

2021-08-13 Thread Luca Boccassi
On Fri, 2021-08-13 at 15:18 +0100, David Hunt wrote: > On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not > be exactly the same as what was set when using CPPC cpufreq driver. > For other cpufreq driver, no need to round it currently, or else > this check will fail with turbo enabled

Re: [dpdk-dev] [PATCH 27/28] net/ice/base: correct spellling of word data

2021-08-13 Thread Ferruh Yigit
On 8/13/2021 5:50 PM, Ferruh Yigit wrote: > On 8/10/2021 3:51 AM, Qi Zhang wrote: >> Correct spelling of word data instead of date. > > Spelling of 'spellling' needs to be corrected in patch title. > Fixes: 453d087ccaff ("net/ice/base: add common functions") Cc: sta...@dpdk.org >> >> Signed-off

[dpdk-dev] [PATCH v1 6/6] bbdev: reduce warning level for one scenario

2021-08-13 Thread Nicolas Chautru
Queue setup may genuinely fail when adding incremental queues for a given priority level. In that case application would attempt to configure a queue at a different priority level. Not an actual error. Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev.c | 7 --- 1 file changed, 4 insert

[dpdk-dev] [PATCH v1 5/6] doc: clarification of usage of HARQ in bbdev doc

2021-08-13 Thread Nicolas Chautru
New paragraph detailing typical VRAN usecase and mapping to bbdev API usage. Signed-off-by: Nicolas Chautru --- doc/guides/prog_guide/bbdev.rst | 23 +++ 1 file changed, 23 insertions(+) diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst index 8bd

[dpdk-dev] [PATCH v1 4/6] baseband/acc100: add support for 4G CRC drop

2021-08-13 Thread Nicolas Chautru
This implements in PMD the option to drop the CB CRC after 4G decoding to help transport block concatenation. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/acc100.rst | 1 + doc/guides/rel_notes/release_21_11.rst | 4 drivers/baseband/acc100/rte_acc100_pmd.c | 12

[dpdk-dev] [PATCH v1 3/6] bbdev: add capability for 4G CB CRC DROP

2021-08-13 Thread Nicolas Chautru
Adding option to drop CRC24B to align with existing feature for 5G Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_vector.c | 2 ++ lib/bbdev/rte_bbdev_op.h | 5 - 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/t

[dpdk-dev] [PATCH v1 2/6] baseband/turbo_sw: add support for CRC16

2021-08-13 Thread Nicolas Chautru
This is to support the case for operation where CRC16 is to be appended or checked. Signed-off-by: Nicolas Chautru --- doc/guides/rel_notes/release_21_11.rst | 3 +++ drivers/baseband/turbo_sw/bbdev_turbo_software.c | 17 + 2 files changed, 20 insertions(+) diff --git

[dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 check

2021-08-13 Thread Nicolas Chautru
Adding a missing operation when CRC16 is being used for TB CRC check. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_vector.c | 2 ++ doc/guides/prog_guide/bbdev.rst| 3 +++ doc/guides/rel_notes/release_21_11.rst | 1 + lib/bbdev/rte_bbdev_op.h | 34 +++

[dpdk-dev] [PATCH v1 0/6] bbdev update related to CRC usage

2021-08-13 Thread Nicolas Chautru
Capturing in this serie minor change to bbdev to support a more comprehensive set of options for CRC used for 4G and 5G (exposed as optional capabilities). This also includes clarifications in documention and minor update to log print. Nicolas Chautru (6): bbdev: add capability for CRC16 chec

Re: [dpdk-dev] [PATCH 27/28] net/ice/base: correct spellling of word data

2021-08-13 Thread Ferruh Yigit
On 8/10/2021 3:51 AM, Qi Zhang wrote: > Correct spelling of word data instead of date. Spelling of 'spellling' needs to be corrected in patch title. > > Signed-off-by: Kevin Scott > Signed-off-by: Qi Zhang > --- > drivers/net/ice/base/ice_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

[dpdk-dev] [Bug 791] Broadcom N2100G NIC does not reset after use

2021-08-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=791 Bug ID: 791 Summary: Broadcom N2100G NIC does not reset after use Product: DPDK Version: 21.08 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-13 Thread Stephen Hemminger
On Tue, 6 Jul 2021 22:14:09 +0530 Vijay Srivastava wrote: > +static pthread_mutex_t sfc_vdpa_adapter_list_lock = > PTHREAD_MUTEX_INITIALIZER; > + Why do you need a pthread_mutex when simple DPDK spin lock will do?

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-13 Thread Stephen Hemminger
On Tue, 6 Jul 2021 22:14:09 +0530 Vijay Srivastava wrote: > +uint32_t > +sfc_vdpa_register_logtype(const struct rte_pci_addr *pci_addr, > + const char *lt_prefix_str, uint32_t ll_default) > +{ > + size_t lt_prefix_str_size = strlen(lt_prefix_str); > + size_t lt_str_s

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-13 Thread Stephen Hemminger
On Tue, 6 Jul 2021 22:14:09 +0530 Vijay Srivastava wrote: > +# Enable more warnings > +extra_flags += [ > + '-Wdisabled-optimization' > +] > + > +# Compiler and version dependent flags > +extra_flags += [ > + '-Waggregate-return', > + '-Wbad-function-cast' > +] > + Having each driver

Re: [dpdk-dev] [PATCH v3 0/7] Refactor the NFP PMD

2021-08-13 Thread Ferruh Yigit
On 8/13/2021 1:46 PM, Heinrich Kuhn wrote: > > > On 2021/07/29 15:47, Heinrich Kuhn wrote: >> This patch set restructures the NFP PMD, aligning it more with the >> common layout adopted by most other PMD's. Although the changes look >> fairly large, functionally nothing is added or removed from t

Re: [dpdk-dev] 20.11.3 patches review and test

2021-08-13 Thread David Hunt
On 13/8/2021 2:31 PM, Luca Boccassi wrote: On Fri, 2021-08-13 at 11:42 +, Jiang, YuX wrote: Hi Luca, Testing with dpdk v20.11.3-rc1 from Intel looks good, no critical issue is found. Below issues have been fixed in 20.11.3-rc1: 1)ddp_gtp_qregion/fd_gtpu_ipv4_dstip: flow director does not

[dpdk-dev] [PATCH] vhost: fix crash on port deletion

2021-08-13 Thread Gaoxiang Liu
The rte_vhost_driver_unregister() and vhost_user_read_cb() can be called at the same time by 2 threads. Eg thread1 calls rte_vhost_driver_unregister() and frees memory of "conn". Because socket fd has not been deleted from poll waiting fds, "vhost-events" thread calls fdset_event_dispatch, then cal

[dpdk-dev] [20.11.3] test/power: fix CPU frequency when turbo enabled

2021-08-13 Thread David Hunt
On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what was set when using CPPC cpufreq driver. For other cpufreq driver, no need to round it currently, or else this check will fail with turbo enabled. For example, with acpi_cpufreq, cpuinfo_cur_freq can be 240

[dpdk-dev] [PATCH] vhost: fix crash on port deletion The rte_vhost_driver_unregister() and vhost_user_read_cb() can be called at the same time by 2 threads. Eg thread1 calls rte_vhost_driver_unregiste

2021-08-13 Thread Gaoxiang Liu
The fix is to move the "fdset_try_del" in front of free memory of conn, then avoid the race condition. The core trace is: Program terminated with signal 11, Segmentation fault. Fixes: 52d874dc6705 ("vhost: fix crash on closing in client mode") v2: fix coding style issues v3: add detailed log S

Re: [dpdk-dev] [PATCH] net/iavf: support FDIR L3 fields for IP fragment packets

2021-08-13 Thread Ferruh Yigit
On 8/2/2021 8:57 AM, Wenjun Wu wrote: > Add support of FDIR L3 fields for both IPv4 and IPv6 fragment packets. > Description mentions from both IPv4 & IPv6 but only IPv6 macro is updated, is this expected? Is following correct: Before this patch flow director rules were not applied to fragmented

Re: [dpdk-dev] 20.11.3 patches review and test

2021-08-13 Thread Luca Boccassi
On Fri, 2021-08-13 at 11:42 +, Jiang, YuX wrote: > Hi Luca, > > Testing with dpdk v20.11.3-rc1 from Intel looks good, no critical issue is > found. > Below issues have been fixed in 20.11.3-rc1: > 1)ddp_gtp_qregion/fd_gtpu_ipv4_dstip: flow director does not work. > 2)rxtx_offload/rxoffload_po

Re: [dpdk-dev] [PATCH v1] net/ice: fix the reversed priority of DCF switch rule

2021-08-13 Thread Thomas Monjalon
13/08/2021 12:45, Ferruh Yigit: > On 8/2/2021 8:25 AM, Wenjun Wu wrote: > > This patch fixes the reversed priority of DCF switch rule. Priority 0 and 1 > > are supported, and priority 0 should be the highest priority. > > > > Fixes: 2321e34c23b3 ("net/ice: support flow priority for DCF switch filt

Re: [dpdk-dev] [PATCH v3 0/7] Refactor the NFP PMD

2021-08-13 Thread Heinrich Kuhn
On 2021/07/29 15:47, Heinrich Kuhn wrote: > This patch set restructures the NFP PMD, aligning it more with the > common layout adopted by most other PMD's. Although the changes look > fairly large, functionally nothing is added or removed from the driver > and the existing code is mostly just re

Re: [dpdk-dev] [PATCH v1 2/2] net/ice: remove redundant default RSS field for IP fragment packets

2021-08-13 Thread Ferruh Yigit
On 8/2/2021 9:36 AM, Wenjun Wu wrote: > This patch removes redundant default RSS field for IP fragment packets, > only src MAC address and dst MAC address are needed. > Same comments with first patch. Impact is not clear, and this patch seems a little different from first path, this clears one fl

Re: [dpdk-dev] [PATCH v1 1/2] net/iavf: remove redundant default RSS field for IP fragment packets

2021-08-13 Thread Ferruh Yigit
On 8/2/2021 9:36 AM, Wenjun Wu wrote: > This patch removes redundant default RSS field for IP fragment packets, > only src MAC address and dst MAC address are needed. > Hi Wenjun, The impact is not clear, from the description I take this as code refactoring without any impact but can you please

Re: [dpdk-dev] 20.11.3 patches review and test

2021-08-13 Thread Jiang, YuX
Hi Luca, Testing with dpdk v20.11.3-rc1 from Intel looks good, no critical issue is found. Below issues have been fixed in 20.11.3-rc1: 1)ddp_gtp_qregion/fd_gtpu_ipv4_dstip: flow director does not work. 2)rxtx_offload/rxoffload_port: Pkt1 can't be distributed to the same queue. Test Scope: # Ba

Re: [dpdk-dev] [EXT] [PATCH v3 00/10] new features for ipsec and security libraries

2021-08-13 Thread Nicolau, Radu
On 8/13/2021 12:08 PM, Akhil Goyal wrote: Changelog?? Sorry, just a small fix for a build error and corrected misspelled email address. Add support for: TSO, NAT-T/UDP encapsulation, ESN AES_CCM, CHACHA20_POLY1305 and AES_GMAC SA telemetry mbuf offload flags Initial SQN value Signed-off-by

Re: [dpdk-dev] [EXT] [PATCH v3 00/10] new features for ipsec and security libraries

2021-08-13 Thread Akhil Goyal
Changelog?? > Add support for: > TSO, NAT-T/UDP encapsulation, ESN > AES_CCM, CHACHA20_POLY1305 and AES_GMAC > SA telemetry > mbuf offload flags > Initial SQN value > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buc

Re: [dpdk-dev] [PATCH v1] net/ice: fix the reversed priority of DCF switch rule

2021-08-13 Thread Ferruh Yigit
On 8/2/2021 8:25 AM, Wenjun Wu wrote: > This patch fixes the reversed priority of DCF switch rule. Priority 0 and 1 > are supported, and priority 0 should be the highest priority. > > Fixes: 2321e34c23b3 ("net/ice: support flow priority for DCF switch filter") > I guess 'Cc: sta...@dpdk.org' tag

Re: [dpdk-dev] [PATCH v14 5/6] doc: add DMA device library guide

2021-08-13 Thread Walsh, Conor
Hi Chengwen, v15 looks good to me. Thanks for the changes, Conor. > Hi Conor, > > Already sent v15, Most of feedback modified, unmodified inline > > Thanks. > > On 2021/8/10 23:27, Walsh, Conor wrote: > > [snip] > > > > Hi Chengwen, > > I have included some feedback to improve the grammar and

[dpdk-dev] [Bug 790] [dpdk-20.11] unit_tests_power/power_cpufreq: unit test failed

2021-08-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=790 Bug ID: 790 Summary: [dpdk-20.11] unit_tests_power/power_cpufreq: unit test failed Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED

[dpdk-dev] [PATCH v3 10/10] ipsec: add ol_flags support

2021-08-13 Thread Radu Nicolau
Set mbuff->ol_flags for IPsec packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/esp_inb.c | 17 -- lib/ipsec/esp_outb.c | 48 ++- lib/ipsec

[dpdk-dev] [PATCH v3 09/10] ipsec: add support for initial SQN value

2021-08-13 Thread Radu Nicolau
Update IPsec library to support initial SQN value. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/esp_outb.c | 19 --- lib/ipsec/sa.c | 29 ++--- 2 files ch

[dpdk-dev] [PATCH v3 08/10] ipsec: add support for SA telemetry

2021-08-13 Thread Radu Nicolau
Add telemetry support for ipsec SAs Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/esp_inb.c | 1 + lib/ipsec/esp_outb.c | 12 +- lib/ipsec/meson.build | 2 +- lib/ipsec/rte_ipsec.h | 11 ++ li

[dpdk-dev] [PATCH v3 07/10] ipsec: add support for NAT-T

2021-08-13 Thread Radu Nicolau
Add support for the IPsec NAT-Traversal use case for Tunnel mode packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/iph.h | 13 + lib/ipsec/rte_ipsec_sa.h | 8 +++- lib/ip

[dpdk-dev] [PATCH v3 06/10] ipsec: add transmit segmentation offload support

2021-08-13 Thread Radu Nicolau
Add support for transmit segmentation offload to inline crypto processing mode. This offload is not supported by other offload modes, as at a minimum it requires inline crypto for IPsec to be supported on the network interface. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off

[dpdk-dev] [PATCH v3 05/10] ipsec: add support for AEAD algorithms

2021-08-13 Thread Radu Nicolau
Add support for AES_CCM, CHACHA20_POLY1305 and AES_GMAC. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/crypto.h | 137 +++ lib/ipsec/esp_inb.c | 66 +

[dpdk-dev] [PATCH v3 04/10] mbuf: add IPsec ESP tunnel type

2021-08-13 Thread Radu Nicolau
Add tunnel type for IPsec ESP tunnels Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/mbuf/rte_mbuf_core.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.

[dpdk-dev] [PATCH v3 03/10] security: add ESN field to ipsec_xform

2021-08-13 Thread Radu Nicolau
Update ipsec_xform definition to include ESN field. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/security/rte_security.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/security/rte_security

[dpdk-dev] [PATCH v3 02/10] security: add UDP params for IPsec NAT-T

2021-08-13 Thread Radu Nicolau
Add support for specifying UDP port params for UDP encapsulation option. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/security/rte_security.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/

[dpdk-dev] [PATCH v3 01/10] security: add support for TSO on IPsec session

2021-08-13 Thread Radu Nicolau
Allow user to provision a per security session maximum segment size (MSS) for use when Transmit Segmentation Offload (TSO) is supported. The MSS value will be used when PKT_TX_TCP_SEG or PKT_TX_UDP_SEG ol_flags are specified in mbuf. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Sign

[dpdk-dev] [PATCH v3 00/10] new features for ipsec and security libraries

2021-08-13 Thread Radu Nicolau
Add support for: TSO, NAT-T/UDP encapsulation, ESN AES_CCM, CHACHA20_POLY1305 and AES_GMAC SA telemetry mbuf offload flags Initial SQN value Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Radu Nicolau (10): securit

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-13 Thread Andrew Rybchenko
On 8/13/21 12:23 PM, Xia, Chenbo wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Friday, August 13, 2021 4:39 PM >> To: Xia, Chenbo ; Vijay Srivastava >> ; dev@dpdk.org >> Cc: maxime.coque...@redhat.com; Vijay Kumar Srivastava >> Subject: Re: [PATCH 01/10]

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-13 Thread Xia, Chenbo
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Friday, August 13, 2021 4:39 PM > To: Xia, Chenbo ; Vijay Srivastava > ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Vijay Kumar Srivastava > Subject: Re: [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver > > Hi Chen

Re: [dpdk-dev] [PATCH v14 5/6] doc: add DMA device library guide

2021-08-13 Thread fengchengwen
Hi Conor, Already sent v15, Most of feedback modified, unmodified inline Thanks. On 2021/8/10 23:27, Walsh, Conor wrote: > [snip] > > Hi Chengwen, > I have included some feedback to improve the grammar and readability > of the docs inline. > [snip] >> +the EAL command line options. >> + >> +

[dpdk-dev] [PATCH v15 3/6] dmadev: introduce DMA device library PMD header

2021-08-13 Thread Chengwen Feng
This patch introduce DMA device library PMD header which was driver facing APIs for a DMA device. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmadev.h | 2 ++ lib/dmadev/rte_dmadev_pmd.h | 72 ++

[dpdk-dev] [PATCH v15 6/6] maintainers: add for dmadev

2021-08-13 Thread Chengwen Feng
This patch add myself as dmadev's maintainer and update release notes. Signed-off-by: Chengwen Feng --- MAINTAINERS| 5 + doc/guides/rel_notes/release_21_11.rst | 6 ++ 2 files changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 266f5ac..fd

[dpdk-dev] [PATCH v15 5/6] doc: add DMA device library guide

2021-08-13 Thread Chengwen Feng
This patch adds dmadev library guide. Signed-off-by: Chengwen Feng Acked-by: Conor Walsh --- doc/guides/prog_guide/dmadev.rst | 125 doc/guides/prog_guide/img/dmadev.svg | 283 +++ doc/guides/prog_guide/index.rst | 1 + 3 files changed

[dpdk-dev] [PATCH v15 1/6] dmadev: introduce DMA device library public APIs

2021-08-13 Thread Chengwen Feng
The 'dmadevice' is a generic type of DMA device. This patch introduce the 'dmadevice' public APIs which expose generic operations that can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Jerin Jacob -

[dpdk-dev] [PATCH v15 2/6] dmadev: introduce DMA device library internal header

2021-08-13 Thread Chengwen Feng
This patch introduce DMA device library internal header, which contains internal data types that are used by the DMA devices in order to expose their ops to the class. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/

[dpdk-dev] [PATCH v15 4/6] dmadev: introduce DMA device library implementation

2021-08-13 Thread Chengwen Feng
This patch introduce DMA device library implementation which includes configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- config/rte_config.h | 3 + lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmade

[dpdk-dev] [PATCH v15 0/6] support dmadev

2021-08-13 Thread Chengwen Feng
This patch set contains six patch for new add dmadev. Chengwen Feng (6): dmadev: introduce DMA device library public APIs dmadev: introduce DMA device library internal header dmadev: introduce DMA device library PMD header dmadev: introduce DMA device library implementation doc: add DMA

Re: [dpdk-dev] [PATCH v1] examples/l3fwd: fix jumbo packet drop issue

2021-08-13 Thread Ferruh Yigit
On 8/13/2021 5:48 AM, Rohit Raj wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, August 11, 2021 5:01 PM >> To: Rohit Raj >> Cc: dev@dpdk.org; Nipun Gupta ; Hemant Agrawal >> ; Sachin Saxena ; >> Vanshika Shukla >> Subject: Re: [dpdk-dev] [PATCH v1] examples/l

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-13 Thread Andrew Rybchenko
Hi Chenbo, many thanks for review. See few questions/notes below. On 8/11/21 5:26 AM, Xia, Chenbo wrote: > Hi Vijay, > >> -Original Message- >> From: Vijay Srivastava >> Sent: Wednesday, July 7, 2021 12:44 AM >> To: dev@dpdk.org >> Cc: maxime.coque...@redhat.com; Xia, Chenbo ; >> andrew

Re: [dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-08-13 Thread Huisong Li
在 2021/8/13 14:12, Thomas Monjalon 写道: 13/08/2021 04:11, Huisong Li: Hi, all This patch can enhance the security of device uninstallation to eliminate dependency on user usage methods. Can you check this patch? 在 2021/8/3 10:30, Huisong Li 写道: Ethernet devices in DPDK can be released by r

[dpdk-dev] [PATCH v5 4/4] app/testpmd: use per-core variable in flowgen

2021-08-13 Thread Zhihong Wang
Use per-core variable for flow indexing to solve cache contention in multi-core scenarios. Signed-off-by: Zhihong Wang Acked-by: Xiaoyun Li --- v5: replace modulo operation to improve performance v4: use loop local variable to improve performance app/test-pmd/flowgen.c | 9 +++-- 1 file ch

[dpdk-dev] [PATCH v5 3/4] app/testpmd: record rx_burst and fwd_dropped in flowgen

2021-08-13 Thread Zhihong Wang
Call inc_rx_burst_stats for rx operation, and record fwd_dropped. Signed-off-by: Zhihong Wang Acked-by: Xiaoyun Li --- app/test-pmd/flowgen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c index 96d0cc79df..229794ee9c 100644 --- a/app/test-

[dpdk-dev] [PATCH v5 2/4] app/testpmd: use rte_ipv4_cksum in flowgen

2021-08-13 Thread Zhihong Wang
Use the rte_ipv4_cksum API to replace local ip_sum implementation. Signed-off-by: Zhihong Wang Acked-by: Xiaoyun Li --- app/test-pmd/flowgen.c | 25 + 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c index f2e6

[dpdk-dev] [PATCH v5 1/4] app/testpmd: fix tx retry in flowgen

2021-08-13 Thread Zhihong Wang
Fix tx_pkt number in tx retry logic. Fixes: bf56fce1fb45 ("app/testpmd: add retry option") Cc: sta...@dpdk.org Signed-off-by: Zhihong Wang Acked-by: Xiaoyun Li --- app/test-pmd/flowgen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/flowgen.c b/app/test

[dpdk-dev] [PATCH v5 0/4] app/testpmd: flowgen fixes and improvements

2021-08-13 Thread Zhihong Wang
This series fixes a tx retry defect and improves multi-core performance by using per-core variable for flow indexing. v5: replace modulo operation to improve performance v4: use loop local variable to improve performance v3: split changes and keep original flow generation logic v2: fix assigning i

[dpdk-dev] [PATCH 1/2] Hooks to allow the setting of filters on tcp flags

2021-08-13 Thread Sowmini Varadhan
The rte_eth_ntuple_filter allows tcp_flags which can check for things like #define RTE_TCP_CWR_FLAG 0x80 /**< Congestion Window Reduced */ #define RTE_TCP_ECE_FLAG 0x40 /**< ECN-Echo */ #define RTE_TCP_URG_FLAG 0x20 /**< Urgent Pointer field significant */ #define RTE_TCP_ACK_FLAG 0

[dpdk-dev] [PATCH 2/2] Allow the flow_classify example to add an ACL table for tcp.

2021-08-13 Thread Sowmini Varadhan
The struct rte_flow_classifier can have upto RTE_FLOW_CLASSIFY_TABLE_MAX (32) classifier tables, but the existing flow_classify examples only adds a single table for the L4 5-tuple. When dealing with tcp flows, we frequently want to add add ACLs and filters to filter based on the state of the TCP

[dpdk-dev] [PATCH 0/2] TCP flow classification using 4-tuple and flags

2021-08-13 Thread Sowmini Varadhan
The problem space of TCP flow tracking and classification based on TCP state requires the ability to classify TCP flows on more packet properties than just the 4-tuple, e.g., TCP flags. This patch-set provides the set of changes needed in the examples/flow_classify.c needed to achieve this. Patch

[dpdk-dev] EAL: failed to parse device "XX:XX.X" on CentOS 7

2021-08-13 Thread Thao Hull
Hi. This looks similar to the problem I am having. https://lore.kernel.org/dpdk-dev/bug-68...@http.bugs.dpdk.org%2F/T/ I can't figure out how this issue was resolved on Centos7 per the thread. Can someone please explain how to get past this failure error? Just like this user, testpmd works fine

[dpdk-dev] [PATCH v3 2/2] drivers/raw: remove octeontx2-ep driver

2021-08-13 Thread Radha Mohan Chintakuntla
Removing the rawdev based octeontx2-ep driver as the dependent common/octeontx2 will soon be going away. Moreover this driver is no longer required as the net/octeontx_ep driver is sufficient. Signed-off-by: Radha Mohan Chintakuntla --- Changes from v2: Fixed DPDK CI reported issues for more docu

[dpdk-dev] [PATCH v3 1/2] drivers/raw: remove octeontx2-dma driver

2021-08-13 Thread Radha Mohan Chintakuntla
Removing the rawdev based octeontx2-dma driver as the dependent common/octeontx2 will be soon be going away. Also a new DMA driver will be coming in this place once the rte_dmadev library is in. Signed-off-by: Radha Mohan Chintakuntla --- Changes from v2: Fixed DPDK CI reported issues for more do