Re: [dpdk-dev] [PATCH v2 0/2] fix bugs for ethtool APP

2021-07-16 Thread Min Hu (Connor)
Hi, all, any comments? 在 2021/6/28 11:22, Min Hu (Connor) 写道: Hi, all, any comments? 在 2021/5/6 11:46, Min Hu (Connor) 写道: This patch fixed fix bugs for ethtool APP. Chengwen Feng (1):    examples/ethtool: fix Rx/Tx queue setup with rte socket id Huisong Li (1):    examples/ethtool

Re: [dpdk-dev] [PATCH v2] app/procinfo: add device registers dump

2021-07-16 Thread Min Hu (Connor)
Hi, all, any comments for this patch? 在 2021/7/10 5:55, Thomas Monjalon 写道: 21/06/2021 04:17, Min Hu (Connor): From: Chengchang Tang This patch add support for dump the device registers from a running application. It can help developers locate the problem. Signed-off-by: Chengchang T

Re: [dpdk-dev] [PATCH] examples/ethtool: fix pause configuration

2021-07-16 Thread Min Hu (Connor)
Hi, all, any comments? 在 2021/6/28 10:17, Min Hu (Connor) 写道: Hi, all, any comments? 在 2021/4/28 16:42, Min Hu (Connor) 写道: From: Huisong Li Currently, the pause command in ethtool to enable Rx/Tx pause has the following problem. Namely, Assume that the device supports flow cont

[dpdk-dev] [PATCH 7/8] net/hns3: fix flow list separate management

2021-07-16 Thread Min Hu (Connor)
From: Chengwen Feng Currently, hns3 driver saves rte flow list into the rte_eth_dev.process_private filed, it may cause following problem: The FDIR/RSS rules cannot be managed in a unified manner because the management structure is not visible between processes. This patch fixes it by moving rte

[dpdk-dev] [PATCH 6/8] net/hns3: fix a print position about auto-negotiation

2021-07-16 Thread Min Hu (Connor)
From: Huisong Li PF driver prints a warning on device that does not support auto-negotiation when user does not configure "link_speeds" (default 0), which means auto-negotiation. Currently, this warning information is printed in dev_configure stage and a success is returned. Perhaps the user may

[dpdk-dev] [PATCH 3/8] net/hns3: fix incorrect comment

2021-07-16 Thread Min Hu (Connor)
From: Chengwen Feng This patch fixed incorrect comment of hns3_parse_fdir_filter(). Fixes: fcba820d9b9e ("net/hns3: support flow director") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_flow.c | 59 +-

[dpdk-dev] [PATCH 8/8] net/hns3: fix Tx pkt prepare address when dev stop

2021-07-16 Thread Min Hu (Connor)
From: Huisong Li In some special scenarios, such as TSO scenarios, the user layer may need to call the tx_pkt_prepare(), and then call tx_pkt_burst() to send packets. If the return value of tx_pkt_parepare() isn't equal to the numbers of packets requested to send, warning message may be printed a

[dpdk-dev] [PATCH 2/8] net/hns3: delete unnecessary zero assignments

2021-07-16 Thread Min Hu (Connor)
From: Chengwen Feng The output parameter 'cap' was cleared at the function entry, the latter zero assignment 'cap' fields was unnecessary, so delete them. Fixes: c09c7847d892 ("net/hns3: support traffic management") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor

[dpdk-dev] [PATCH 5/8] net/hns3: delete duplicate compile-time check

2021-07-16 Thread Min Hu (Connor)
From: Chengchang Tang This patch delete duplicate compile-gime check. Fixes: cb12e988f35f ("net/hns3: add compile-time verification on Rx vector") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx_vec.c | 4 1 file changed,

[dpdk-dev] [PATCH 4/8] net/hns3: fix the timing issue of clearing interrupt source

2021-07-16 Thread Min Hu (Connor)
From: HongBo Zheng Currently, the PF/VF does not clear the interrupt source immediately after receiving the interrupt. As a result, if the second interrupt task is triggered when processing the first interrupt task, clearing the interrupt source before exiting will clear the interrupt sources of

[dpdk-dev] [PATCH 1/8] net/hns3: fix residual MAC address entry

2021-07-16 Thread Min Hu (Connor)
From: Chengchang Tang Currently, even if we fail to remove the origin MAC address from the HW, the set_default_mac will go on, and add the new MAC address to the HW. Eventually cause the original MAC address entry to remain in the HW, and users may receive unexpected packets. This patch make set

[dpdk-dev] [PATCH 0/8] bugfix for hns3 PMD

2021-07-16 Thread Min Hu (Connor)
This patchset contains 8 bugfixes for hns3 PMD. Chengchang Tang (2): net/hns3: fix residual MAC address entry net/hns3: delete duplicate compile-time check Chengwen Feng (3): net/hns3: delete unnecessary zero assignments net/hns3: fix incorrect comment net/hns3: fix flow list separate m

[dpdk-dev] [PATCH] net/hns3: supports disabling PFC by dev configure API

2021-07-16 Thread Min Hu (Connor)
From: Huisong Li If "dcb_capability_en" in "data->dev_conf" delivered from the dev_configure does not have the ETH_DCB_PFC_SUPPORT flag, the user wants to disable PFC, and only enable ETS. Therefore, this patch supports the function of disabling PFC by the field. In addition, this patch updates "

Re: [dpdk-dev] [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD

2021-07-16 Thread Akhil Goyal
> > v2: > > - Add data-path part. > > > > v3: > > - Rebase. > > > > v4: > > - Rebase + Address the following Akhil comments: > > - Set HW feature flag in the capability patch. > > - Fix mp object release in session clear. > > - Some spelling and word missing in doc. > > - Squash data-unit adjustm

Re: [dpdk-dev] [EXT] [PATCH v8 16/16] test/crypto: add AES-XTS multi segment OOP tests

2021-07-16 Thread Akhil Goyal
> The AES-XTS algorithm can supports wrapped key and data-unit. > The encryption/decryption can be done out of place and using multi > segments. > > Add multi segment and out of place tests to the recently added AES-XTS > vectors, which support using data-unit and a wrapped key. > > Signed-off-by

Re: [dpdk-dev] [EXT] [PATCH v8 15/16] test/crypto: add data-unit and wrapped vectors

2021-07-16 Thread Akhil Goyal
> The AES-XTS algorithm supports using a wrapped key. > In AES-XTS the data-unit defines the data block size to be > encrypted\decrypted. > > Add AES-XTS vectors with a wrapped key. > Add a variable stating whether the key is wrapped or not. > Add the AES-XTS data-unit. > > Signed-off-by: Shiri K

Re: [dpdk-dev] [EXT] [PATCH v8 14/16] test/crypto: add mlx5 crypto driver

2021-07-16 Thread Akhil Goyal
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > index 31201d93e1..e46668a1e0 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -14569,6 +14569,12 @@ test_cryptodev_cpu_aesni_gcm(void) > return rc; > } > > +static int > +test_cryptodev_mlx

Re: [dpdk-dev] [EXT] [PATCH v8 06/16] crypto/mlx5: add dev stop and start operations

2021-07-16 Thread Akhil Goyal
> Add the dev_start function that is used to start a configured device. > Add the dev_stop function that is used to stop a configured device. > > Both functions set the dev parameter as used and return 0. > > Signed-off-by: Shiri Kuzin > Acked-by: Matan Azrad > --- > drivers/crypto/mlx5/mlx5_c

Re: [dpdk-dev] [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations

2021-07-16 Thread Akhil Goyal
> Sessions are used in symmetric transformations in order to prepare > objects and data for packet processing stage. > > A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct, > bsf_size, bsf_p_type, block size index, encryption_order and encryption > standard. > > Implement the ne

Re: [dpdk-dev] [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations

2021-07-16 Thread Akhil Goyal
> Sessions are used in symmetric transformations in order to prepare > objects and data for packet processing stage. > > A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct, > bsf_size, bsf_p_type, block size index, encryption_order and encryption > standard. > > Implement the ne

Re: [dpdk-dev] [EXT] [PATCH v8 04/16] crypto/mlx5: add basic operations

2021-07-16 Thread Akhil Goyal
> The basic dev control operations are configure, close and get info. > > Extended the existing support of configure and close: > -mlx5_crypto_dev_configure- function used to configure device. > -mlx5_crypto_dev_close- function used to close a configured >device. > > Added co

Re: [dpdk-dev] [EXT] [PATCH v8 02/16] crypto/mlx5: add DEK object management

2021-07-16 Thread Akhil Goyal
> A DEK(Data encryption Key) is an mlx5 HW object which represents the > cipher algorithm key. > The DEKs are used during data encryption/decryption operations. > > In symmetric algorithms like AES-STS, we use the same DEK for both > encryption and decryption. > > Use the mlx5 hash-list tool to m

Re: [dpdk-dev] [EXT] [PATCH v8 01/16] drivers: introduce mlx5 crypto PMD

2021-07-16 Thread Akhil Goyal
> diff --git a/doc/guides/rel_notes/release_21_08.rst > b/doc/guides/rel_notes/release_21_08.rst > index 7d289e07e3..2bf4ce7a73 100644 > --- a/doc/guides/rel_notes/release_21_08.rst > +++ b/doc/guides/rel_notes/release_21_08.rst > @@ -125,6 +125,11 @@ New Features >The experimental PMD power ma

Re: [dpdk-dev] [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD

2021-07-16 Thread Akhil Goyal
> v2: > - Add data-path part. > > v3: > - Rebase. > > v4: > - Rebase + Address the following Akhil comments: > - Set HW feature flag in the capability patch. > - Fix mp object release in session clear. > - Some spelling and word missing in doc. > - Squash data-unit adjustment to the session opera

Re: [dpdk-dev] [EXT] [PATCH v2 00/16] Add support for fourth generation of Intel QuickAssist Technology devices

2021-07-16 Thread Akhil Goyal
> This patchset adds support for fourth generation (GEN4) of Intel QuickAssist > Technology (QAT) devices. > Symmetric crypto PMD is enabled with following algorithms: > > * AES-CBC > * AES-CMAC > * AES-XCBC MAC > * NULL (auth, cipher) > * SHA1-HMAC > * SHA2-HMAC (224, 256, 384, 512) > * Chacha20-

Re: [dpdk-dev] [EXT] [PATCH v2 16/16] test/crypto: check if RAW API is supported

2021-07-16 Thread Akhil Goyal
> -- > From: Adam Dybkowski > > This patch adds checking if RAW API is supported at the start > of the test command "cryptodev_qat_raw_api_autotest". > > Signed-off-by: Adam Dybkowski > --- > app/test/test_cryptodev.c | 34 +++

[dpdk-dev] [PATCH] eventdev: configure the Rx event buffer size

2021-07-16 Thread Ganapati Kundapura
As of now Rx event buffer size is static and set to 128. This patch sets the Rx event buffer size to 192, configurable at compile time and also errors out at run time if Rx event buffer size is configured more than 16 bits. Signed-off-by: Ganapati Kundapura --- config/rte_config.h

[dpdk-dev] [PATCH v4] crypto/ccp: moving vdev to PCI driver

2021-07-16 Thread asomalap
From: Amaranath Somalapuram drop all the code duplicating the PCI bus driver develped for Enable IOMMU in vdev. Signed-off-by: Amaranath Somalapuram --- drivers/crypto/ccp/ccp_dev.c | 66 + drivers/crypto/ccp/ccp_dev.h | 3 +- drivers/crypto/ccp/rte_ccp_pmd.c | 158 +

Re: [dpdk-dev] [RFC PATCH v4 1/3] sched: add PIE based congestion management

2021-07-16 Thread Dumitrescu, Cristian
Hi Wojciech, > -Original Message- > From: Liguzinski, WojciechX > Sent: Monday, July 5, 2021 9:04 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Dharmappa, Savinay ; Ajmera, Megha > > Subject: [RFC PATCH v4 1/3] sched: add PIE based congestion management > > Imp

[dpdk-dev] [PATCH 21.11 v2 1/3] eal/linux: make hugetlbfs analysis reusable

2021-07-16 Thread Dmitry Kozlyuk
get_hugepage_dir() searched for a hugetlbfs mount with a given page size using handcraft parsing of /proc/mounts and mixing traversal logic with selecting the needed entry. Separate code to enumerate hugetlbfs mounts to eal_hugepage_mount_walk() taking a callback that can inspect already parsed ent

[dpdk-dev] [PATCH 21.11 v2 3/3] app/test: add allocator performance autotest

2021-07-16 Thread Dmitry Kozlyuk
Memory allocator performance is crucial to applications that deal with large amount of memory or allocate frequently. DPDK allocator performance is affected by EAL options, API used and, at least, allocation size. New autotest is intended to be run with different EAL options. It measures performanc

[dpdk-dev] [PATCH 21.11 v2 0/3] eal: add memory pre-allocation from existing files

2021-07-16 Thread Dmitry Kozlyuk
Hugepage allocation from the system takes time, resulting in slow startup or sporadic delays later. Most of the time spent in kernel is zero-filling memory for security reasons, which may be irrelevant in a controlled environment. The bottleneck is memory access speed, so for speeduup the amount of

[dpdk-dev] [PATCH 21.11 v2 2/3] eal: add memory pre-allocation from existing files

2021-07-16 Thread Dmitry Kozlyuk
From: Viacheslav Ovsiienko The primary DPDK process launch might take a long time if initially allocated memory is large. From practice allocation of 1 TB of memory over 1 GB hugepages on Linux takes tens of seconds. Fast restart is highly desired for some applications and launch delay presents a

[dpdk-dev] Minutes of Technical Board Meeting 2021-06-02

2021-07-16 Thread Stephen Hemminger
Minutes of Technical Board Meeting, 2021-06-02 == NOTE: The technical board meetings every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK community members are welcome to attend. NOTE: Next meeting will be on We

[dpdk-dev] [PATCH v3] crypto/ccp: moving vdev to PCI driver

2021-07-16 Thread asomalap
From: Amaranath Somalapuram drop all the code duplicating the PCI bus driver develped for Enable IOMMU in vdev. Signed-off-by: Amaranath Somalapuram --- drivers/crypto/ccp/ccp_dev.c | 66 + drivers/crypto/ccp/ccp_dev.h | 3 +- drivers/crypto/ccp/rte_ccp_pmd.c | 158 +

Re: [dpdk-dev] [PATCH v2] net/mlx5: do not allow copy to mark via modify field

2021-07-16 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Friday, July 16, 2021 11:43 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko > Subject: [PATCH v2] net/mlx5: do not allow copy to mark via modify field > > The Mark action is a two-stage process in the Mell

[dpdk-dev] [PATCH v2] crypto/ccp: moving vdev to PCI driver

2021-07-16 Thread asomalap
From: Amaranath Somalapuram drop all the code duplicating the PCI bus driver develped for Enable IOMMU in vdev. Signed-off-by: Amaranath Somalapuram --- drivers/crypto/ccp/ccp_dev.c | 66 + drivers/crypto/ccp/ccp_dev.h | 3 +- drivers/crypto/ccp/rte_ccp_pmd.c | 158 +

Re: [dpdk-dev] [PATCH v5] dmadev: introduce DMA device library

2021-07-16 Thread Bruce Richardson
On Fri, Jul 16, 2021 at 10:45:35AM +0800, Chengwen Feng wrote: > This patch introduce 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng

Re: [dpdk-dev] [pull-request] dpdk-next-net-mrvl for for-next-net v21.08 - RC2

2021-07-16 Thread Thomas Monjalon
13/07/2021 13:23, Jerin Jacob Kollanukkaran: > The following changes since commit a95bbb72623c310df4d0c8ad45c2ee06f538e01b: > > version: 21.08-rc1 (2021-07-10 12:01:52 +0200) > > are available in the Git repository at: > > http://dpdk.org/git/next/dpdk-next-net-mrvl Pulled, thanks.

Re: [dpdk-dev] [pull-request] dpdk-next-net for main v21.08 - RC2

2021-07-16 Thread Thomas Monjalon
13/07/2021 15:17, Andrew Rybchenko: > The following changes since commit a95bbb72623c310df4d0c8ad45c2ee06f538e01b: > > version: 21.08-rc1 (2021-07-10 12:01:52 +0200) > > are available in the Git repository at: > > http://dpdk.org/git/next/dpdk-next-net Pulled, thanks.

[dpdk-dev] [RFC v2 8/8] test: support ethdev

2021-07-16 Thread Ferruh Yigit
Added unit test for ethdev APIs, this unit test 'ethdev_api_autotest' can run without physical device. If there are physical devices probed, they will be ignored by the unit test. A few issues fixed or some clarification added in the ehtdev library with in this unit test patch. Signed-off-by: Fer

[dpdk-dev] [RFC v2 7/8] test/virtual_pmd: support queue start/stop

2021-07-16 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- app/test/virtual_pmd.c | 52 ++ 1 file changed, 52 insertions(+) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index 27c8501b96a7..4b8318cf39dd 100644 --- a/app/test/virtual_pmd.c +++ b/app/test/virtual_pmd.c

[dpdk-dev] [RFC v2 6/8] test/virtual_pmd: provide descriptor limit info

2021-07-16 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- app/test/virtual_pmd.c | 4 app/test/virtual_pmd.h | 4 2 files changed, 8 insertions(+) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index e0ea213ae231..27c8501b96a7 100644 --- a/app/test/virtual_pmd.c +++ b/app/test/virtual_pmd.c @@ -10

[dpdk-dev] [RFC v2 5/8] test/virtual_pmd: support get queue info device ops

2021-07-16 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- app/test/virtual_pmd.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index f2d807de8d89..e0ea213ae231 100644 --- a/app/test/virtual_pmd.c +++ b/app/test/virtual_pmd.c

[dpdk-dev] [RFC v2 4/8] test/virtual_pmd: enable getting device data

2021-07-16 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- app/test/virtual_pmd.c | 10 ++ app/test/virtual_pmd.h | 4 2 files changed, 14 insertions(+) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index 615243e19aed..f2d807de8d89 100644 --- a/app/test/virtual_pmd.c +++ b/app/test/virtual_pmd

[dpdk-dev] [RFC v2 3/8] test/virtual_pmd: enable updating device flags

2021-07-16 Thread Ferruh Yigit
To be able to test various dev_flags. Signed-off-by: Ferruh Yigit --- app/test/virtual_pmd.c | 10 ++ app/test/virtual_pmd.h | 4 2 files changed, 14 insertions(+) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index 17f28c5a304c..615243e19aed 100644 --- a/app/test/v

[dpdk-dev] [RFC v2 2/8] test/virtual_pmd: enable getting device operations

2021-07-16 Thread Ferruh Yigit
This will be used to overwrite the dev_ops for various tests. Signed-off-by: Ferruh Yigit --- app/test/virtual_pmd.c | 14 -- app/test/virtual_pmd.h | 6 ++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index 6098

[dpdk-dev] [RFC v2 1/8] test/virtual_pmd: clean rings on close

2021-07-16 Thread Ferruh Yigit
Not cleaning the rings prevents creating devices again, which breaks to run some unit tests multiple times. Signed-off-by: Ferruh Yigit --- app/test/virtual_pmd.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c ind

Re: [dpdk-dev] [PATCH] raw/ioat: fix termination descriptor for batch

2021-07-16 Thread Bruce Richardson
On Fri, Jul 16, 2021 at 02:50:27PM +0100, Konstantin Ananyev wrote: > When batch_size == 1, idxd has to add a dummy termination descriptor > to satisfy HW requirements. > Right now it uses NOP descriptor with FENCE flag. > This is excessive and fencing can slowdown things quite significantly. > The

Re: [dpdk-dev] [PATCH] raw/ioat: fix config script queue size calculation

2021-07-16 Thread Bruce Richardson
On Fri, Jul 16, 2021 at 01:21:55PM +, Kevin Laatz wrote: > The queue size calculation is currently based on "max_tokens" rather than > "max_work_queues_size". This is resulting in the queue size being > incorrectly configured when using the script to configure devices bound to > the IDXD kernel

Re: [dpdk-dev] [PATCH v4] build: optional NUMA and cpu counts detection

2021-07-16 Thread Bruce Richardson
On Fri, Jul 16, 2021 at 01:53:18PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: David Christensen > > Sent: Tuesday, July 6, 2021 8:11 PM > > To: Bruce Richardson ; Juraj Linkeš > > > > Cc: tho...@monjalon.net; david.march...@redhat.com; > > honnappa.nagaraha...@arm.c

Re: [dpdk-dev] [PATCH] raw/ioat: fix config script queue size calculation

2021-07-16 Thread Ananyev, Konstantin
> The queue size calculation is currently based on "max_tokens" rather than > "max_work_queues_size". This is resulting in the queue size being > incorrectly configured when using the script to configure devices bound to > the IDXD kernel driver. > This patch fixes this miscalculation so devices

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-16 Thread Hu, Jiayu
> -Original Message- > From: David Marchand > Sent: Friday, July 16, 2021 9:53 PM > To: Hu, Jiayu > Cc: Maxime Coquelin ; Ma, WenwuX > ; dev@dpdk.org; Xia, Chenbo > ; Jiang, Cheng1 ; Wang, > YuanX > Subject: Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for > split ring >

Re: [dpdk-dev] [PATCH v4] build: optional NUMA and cpu counts detection

2021-07-16 Thread Juraj Linkeš
> -Original Message- > From: David Christensen > Sent: Tuesday, July 6, 2021 8:11 PM > To: Bruce Richardson ; Juraj Linkeš > > Cc: tho...@monjalon.net; david.march...@redhat.com; > honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com; > ferruh.yi...@intel.com; jerinjac...@gmail.com; dev@d

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-16 Thread David Marchand
On Fri, Jul 16, 2021 at 3:45 PM Hu, Jiayu wrote: > > - I don't like this threshold, this is too low level and most users will > > only see > > the shiny aspect "better performance" without understanding the > > consequences. > > By default, it leaves the door open to a _bad_ behavior, that is pac

[dpdk-dev] [PATCH] raw/ioat: fix termination descriptor for batch

2021-07-16 Thread Konstantin Ananyev
When batch_size == 1, idxd has to add a dummy termination descriptor to satisfy HW requirements. Right now it uses NOP descriptor with FENCE flag. This is excessive and fencing can slowdown things quite significantly. The patch removes FENCE flag from termination dummy descriptor. That helps to imp

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-16 Thread Hu, Jiayu
> -Original Message- > From: David Marchand > Sent: Friday, July 16, 2021 4:15 PM > To: Hu, Jiayu > Cc: Maxime Coquelin ; Ma, WenwuX > ; dev@dpdk.org; Xia, Chenbo > ; Jiang, Cheng1 ; Wang, > YuanX > Subject: Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for > split ring >

[dpdk-dev] [PATCH v2] doc/guides: add details for new test structure

2021-07-16 Thread Ciara Power
The testing guide is now updated to include details about using sub-testsuites. Some example code is given to demonstrate how they can be used. A note is also added to highlight the need for using vdev EAL args when running cryptodev tests. Depends-on: patch-95866 ("guides: add a guide for develo

[dpdk-dev] [PATCH v1] lib/distributor: fix unaligned 128-bit write

2021-07-16 Thread David Hunt
When the distributor sample app is built as a 32-bit app, the data buffer passed to find_match_vec can be unaligned, causing a segmentation fault due to writing a 128-bit value using _mm_store_si128(). 128-bit align the data being passed in so this does not happen. Fixes: 775003ad2f96 ("distribut

[dpdk-dev] [PATCH v5 3/3] vhost: add thread unsafe async registeration functions

2021-07-16 Thread Jiayu Hu
This patch adds thread unsafe version for async register and unregister functions. Signed-off-by: Jiayu Hu --- doc/guides/prog_guide/vhost_lib.rst | 14 lib/vhost/rte_vhost_async.h | 41 ++ lib/vhost/version.map | 4 + lib/vhost/vhost.c |

[dpdk-dev] [PATCH v5 2/3] vhost: rework async configuration structure

2021-07-16 Thread Jiayu Hu
This patch reworks the async configuration structure to improve code readability. In addition, add preserved padding fields on the structure for future usage. Signed-off-by: Jiayu Hu --- doc/guides/prog_guide/vhost_lib.rst | 21 + examples/vhost/main.c | 8 +++

[dpdk-dev] [PATCH v5 1/3] vhost: fix lock on device readiness notification

2021-07-16 Thread Jiayu Hu
The vhost notifies the application of device readiness via vhost_user_notify_queue_state(), but calling this function is not protected by the lock. This patch is to make this function call lock protected. Fixes: d0fcc38f5fa4 ("vhost: improve device readiness notifications") Cc: sta...@dpdk.org Si

[dpdk-dev] [PATCH v5 0/3] provide thread unsafe async registration functions

2021-07-16 Thread Jiayu Hu
Lock protection is needed during the vhost notifies the application of device readiness, so the first patch adds lock protection. In addition, the second patch reworks async feature structure to improve readability. After performing locking, existed async vhost registration functions will cause dea

[dpdk-dev] [PATCH] raw/ioat: fix config script queue size calculation

2021-07-16 Thread Kevin Laatz
The queue size calculation is currently based on "max_tokens" rather than "max_work_queues_size". This is resulting in the queue size being incorrectly configured when using the script to configure devices bound to the IDXD kernel driver. This patch fixes this miscalculation so devices are configur

Re: [dpdk-dev] [PATCH v5] dmadev: introduce DMA device library

2021-07-16 Thread Jerin Jacob
On Fri, Jul 16, 2021 at 8:19 AM Chengwen Feng wrote: > > This patch introduce 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng > --- >

Re: [dpdk-dev] [RFC PATCH v4 1/3] sched: add PIE based congestion management

2021-07-16 Thread Dumitrescu, Cristian
Hi Wojciech, > -Original Message- > From: Liguzinski, WojciechX > Sent: Monday, July 5, 2021 9:04 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Dharmappa, Savinay ; Ajmera, Megha > > Subject: [RFC PATCH v4 1/3] sched: add PIE based congestion management > > Imp

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-16 Thread Jerin Jacob
On Thu, Jul 15, 2021 at 9:34 PM fengchengwen wrote: > > @burce, jerin Some unmodified review comments are returned here: > > 1. > COMMENT: > +memset(dmadev_shared_data->data, 0, > > +sizeof(dmadev_shared_data->data)); > I believe all memzones are ze

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-16 Thread Bruce Richardson
On Fri, Jul 16, 2021 at 06:10:48PM +0530, Jerin Jacob wrote: > On Fri, Jul 16, 2021 at 8:34 AM fengchengwen wrote: > > > > On 2021/7/16 0:33, Bruce Richardson wrote: > > > On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: > > >> @burce, jerin Some unmodified review comments are return

[dpdk-dev] [PATCH v1] crypto/ccp: moving vdev to PCI driver

2021-07-16 Thread asomalap
From: Amaranath Somalapuram drop all the code duplicating the PCI bus driver develped for Enable IOMMU in vdev. Signed-off-by: Amaranath Somalapuram --- drivers/crypto/ccp/ccp_dev.c | 67 ++--- drivers/crypto/ccp/ccp_dev.h | 3 +- drivers/crypto/ccp/rte_ccp_pmd.c | 156 +

Re: [dpdk-dev] [RFC PATCH v4 0/3] Add PIE support for HQoS library

2021-07-16 Thread Dumitrescu, Cristian
Hi Wojciech, Thank you for doing this work! > -Original Message- > From: Liguzinski, WojciechX > Sent: Monday, July 5, 2021 9:04 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Dharmappa, Savinay ; Ajmera, Megha > > Subject: [RFC PATCH v4 0/3] Add PIE support for

[dpdk-dev] [PATCH v2] net/mlx5: do not allow copy to mark via modify field

2021-07-16 Thread Alexander Kozyrev
The Mark action is a two-stage process in the Mellanox driver. First, a hardware register is filled with the required value, then this value is registered in the software resource table. The MODIFY_FIELD action can instruct a Mellanox NIC to copy some value from an arbitrary packet header field in

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-16 Thread Jerin Jacob
On Fri, Jul 16, 2021 at 8:34 AM fengchengwen wrote: > > On 2021/7/16 0:33, Bruce Richardson wrote: > > On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: > >> @burce, jerin Some unmodified review comments are returned here: > >> > > [snip] > > > > >> 2. COMMENT: > + * @see struct rte_

[dpdk-dev] [Bug 759] testpmd: bonding mode 4 on mlx5 doesn't work

2021-07-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=759 Bug ID: 759 Summary: testpmd: bonding mode 4 on mlx5 doesn't work Product: DPDK Version: 20.11 Hardware: x86 URL: https://mails.dpdk.org/archives/dev/2021-July/213360.h

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-16 Thread Jerin Jacob
On Fri, Jul 16, 2021 at 3:20 PM Bruce Richardson wrote: > > On Fri, Jul 16, 2021 at 11:04:30AM +0800, fengchengwen wrote: > > On 2021/7/16 0:33, Bruce Richardson wrote: > > > On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: > > >> @burce, jerin Some unmodified review comments are ret

[dpdk-dev] dpdk-next-eventdev for for-main v21.08 - RC2

2021-07-16 Thread Jerin Jacob Kollanukkaran
The following changes since commit a95bbb72623c310df4d0c8ad45c2ee06f538e01b:   version: 21.08-rc1 (2021-07-10 12:01:52 +0200) are available in the Git repository at:   http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 85b2bc49ce33f9d73a4ebd89483991a95b96b0c8:   event/c

Re: [dpdk-dev] [PATCH v3] config/arm: split march cfg into arch and features

2021-07-16 Thread Juraj Linkeš
> -Original Message- > From: fengchengwen > Sent: Friday, July 16, 2021 5:42 AM > To: Ruifeng Wang ; Juraj Linkeš > ; tho...@monjalon.net; > david.march...@redhat.com; bruce.richard...@intel.com; Honnappa > Nagarahalli ; ferruh.yi...@intel.com; > jerinjac...@gmail.com; jer...@marvell.com

Re: [dpdk-dev] [PATCH v9 7/7] event/cnxk: add Tx event vector fastpath

2021-07-16 Thread Jerin Jacob
On Wed, Jul 14, 2021 at 2:33 PM wrote: > > From: Pavan Nikhilesh > > Add Tx event vector fastpath, integrate event vector Tx routine > into Tx burst. > > Signed-off-by: Pavan Nikhilesh Series Acked-by: Jerin Jacob Series v9 Applied to dpdk-next-net-eventdev/for-main. Thanks > --- > drivers/

Re: [dpdk-dev] [PATCH v4 19/20] net/sfc: support flow action COUNT in transfer rules

2021-07-16 Thread David Marchand
Hello gyus, On Fri, Jul 2, 2021 at 10:41 AM Andrew Rybchenko wrote: > > From: Igor Romanov > > For now, a rule may have only one dedicated counter, shared counters > are not supported. > > HW delivers (or "streams") counter readings using special packets. > The driver creates a dedicated Rx queu

Re: [dpdk-dev] [PATCH v4] crypto/ccp: moving vdev to PCI driver

2021-07-16 Thread David Marchand
On Fri, Jul 16, 2021 at 2:03 PM wrote: > > From: Amaranath Somalapuram > > drop all the code duplicating the PCI bus driver > develped for Enable IOMMU in vdev. > > Signed-off-by: Amaranath Somalapuram Title does not follow DPDK convention. https://doc.dpdk.org/guides/contributing/patches.html#

Re: [dpdk-dev] [PATCH v4] net/softnic: fix memory leak in parsing arguments

2021-07-16 Thread Singh, Jasvinder
> -Original Message- > From: Yu, DapengX > Sent: Thursday, July 15, 2021 6:38 AM > To: Singh, Jasvinder ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH v4] net/softnic: fix memory leak in parsing arguments > > From: Dapeng Yu > > In funct

[dpdk-dev] new IRC channel

2021-07-16 Thread Thomas Monjalon
As agreed in a Technical Board meeting, the preferred IRC channel for the DPDK project moved from freenode to Libera.Chat: https://mails.dpdk.org/archives/dev/2021-July/214662.html The website is updated: https://core.dpdk.org/contribute/ There is a good guide to start with Libera

Re: [dpdk-dev] [PATCH] doc/sample_app_ug: use code snippets in sample app guides

2021-07-16 Thread Walsh, Conor
> Hello, Hi David, thanks for your reply I will be handling this as Conor Fogarty is OOO. > > On Wed, Jul 14, 2021 at 11:59 AM Conor Fogarty > wrote: > > > > Currently the sample app user guides use hard coded code snippets, > > this patch changes these to use literalinclude which will dynamica

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-16 Thread Bruce Richardson
On Fri, Jul 16, 2021 at 11:04:30AM +0800, fengchengwen wrote: > On 2021/7/16 0:33, Bruce Richardson wrote: > > On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: > >> @burce, jerin Some unmodified review comments are returned here: > >> > > [snip] > > > > >> 2. COMMENT: > + * @see s

[dpdk-dev] [PATCH v2] crypto/octeontx2: fix lookaside IPsec IV pointer

2021-07-16 Thread Tejasree Kondoj
Fixing IV pointer population in lookaside IPsec outbound instruction. Fixes: fab634eb87ca ("crypto/octeontx2: support security session data path") Signed-off-by: Tejasree Kondoj --- v2: * Fixed unused variable warning drivers/crypto/octeontx2/otx2_ipsec_po_ops.h | 12 ++-- 1 file chang

[dpdk-dev] [PATCH v1 2/3] net/hinic/base: fix the problem of LRO

2021-07-16 Thread Guoyang Zhou
The rx queue must config as ceq disable, and must set msix state disable. Otherwise when lro is enable, there will be problems with packet aggregation because of firmware. Fixes: 9d02f40d6503 ("net/hinic: fix LRO") Cc: sta...@dpdk.org Signed-off-by: Guoyang Zhou --- drivers/net/hinic/base/hinic_

[dpdk-dev] [PATCH v1 3/3] net/hinic: fix the problem of MTU inconsistent

2021-07-16 Thread Guoyang Zhou
The configuration of mtu is inconsistent in the driver and firmware when the port is stopped, started and reconfigured. Before, HINIC_MAX_JUMBO_FRAME_SIZE include vlan tag, but when frame and pktlen are converted to each other do not include vlan tag. And port_mtu_set function will use HINIC_MAX_JU

[dpdk-dev] [PATCH v1 1/3] net/hinic: increase the protection of the VLAN

2021-07-16 Thread Guoyang Zhou
If the vlan id 0 is deleted for hinic, all packets without vlan will be discarded when the vlan filter is turned on. Fixes: 50ce3e7aec8f ("ethdev: fix VLAN offloads set if no relative capabilities") Cc: sta...@dpdk.org Signed-off-by: Guoyang Zhou --- drivers/net/hinic/hinic_pmd_ethdev.c | 3 +++

[dpdk-dev] [PATCH v1 0/3] fix some problems of mtu, vlan, lro

2021-07-16 Thread Guoyang Zhou
The vlan id 0 can not be deleted, and the rx queue must config as ceq disable, and must set msix state disable because of lro function, and fix the problem of MTU inconsistent in the driver and firmware. -- v1: - increase the protection of the VLAN interface - fix the problem of LRO - fix th

Re: [dpdk-dev] RFC enabling dll/dso for dpdk on windows

2021-07-16 Thread Dmitry Kozlyuk
2021-07-08 18:03 (UTC-0700), Tyler Retzlaff: > On Thu, Jul 08, 2021 at 11:49:53PM +0300, Dmitry Kozlyuk wrote: > > Hi Tyler, > > > > 2021-07-08 12:21 (UTC-0700), Tyler Retzlaff: > > > hi folks, > > > > > > we would like to submit a a patch series that makes dll/dso for dpdk > > > work on window

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-07-16 Thread Ferruh Yigit
On 7/12/2021 4:12 AM, Li, Xiaoyun wrote: > > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Friday, July 9, 2021 17:27 >> To: Wang, Jie1X ; dev@dpdk.org >> Cc: Li, Xiaoyun ; sta...@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd doesn't show RSS >> hash off

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-16 Thread Maxime Coquelin
On 7/16/21 9:55 AM, Hu, Jiayu wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Friday, July 16, 2021 3:46 PM >> To: Hu, Jiayu ; Ma, WenwuX ; >> dev@dpdk.org >> Cc: Xia, Chenbo ; Jiang, Cheng1 >> ; Wang, YuanX >> Subject: Re: [PATCH v5 3/4] vhost: support async deque

Re: [dpdk-dev] [PATCH v4 2/5] vhost: add unsafe API to drain pkts in async vhost

2021-07-16 Thread Xia, Chenbo
Hi Cheng, > -Original Message- > From: Jiang, Cheng1 > Sent: Friday, July 16, 2021 10:59 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Jiang, Cheng1 > Subject: [PATCH v4 2/5] vhost: add unsafe API to drain pkts in async vhost > > App

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-07-16 Thread Ferruh Yigit
On 7/16/2021 9:30 AM, Li, Xiaoyun wrote: >> -Original Message- >> From: stable On Behalf Of Li, Xiaoyun >> Sent: Thursday, July 15, 2021 12:54 >> To: Wang, Jie1X ; dev@dpdk.org >> Cc: andrew.rybche...@oktetlabs.ru; sta...@dpdk.org >> Subject: Re: [dpdk-stable] [PATCH v4] app/testpmd: fix t

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] drivers: add octeontx crypto adapter framework

2021-07-16 Thread Akhil Goyal
Hi David, > > deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev', > 'net_octeontx'] > > +deps += ['crypto_octeontx'] > > This extra dependency resulted in disabling the event/octeontx driver > in FreeBSD, since crypto/octeontx only builds on Linux. > Removing hw support triggers a ABI fa

[dpdk-dev] [PATCH v2 7/7] net/nfp: batch file rename for consistency

2021-07-16 Thread Heinrich Kuhn
Rename the nfp_net.c file to nfp_common as it now contains functions common to VF and PF functionality. Rename the header file too to be consistent. Also remove the "net" naming from the _ctrl and _logs files for consistency across the PMD. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman

[dpdk-dev] [PATCH v2 6/7] net/nfp: move PF functions into new file

2021-07-16 Thread Heinrich Kuhn
Similar to the last commit, this changeset moves all the PF specific functions to a new file called nfp_ethdev.c. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/meson.build |1 + drivers/net/nfp/nfp_ethdev.c | 1099 ++ drivers/n

[dpdk-dev] [PATCH v2 5/7] net/nfp: move VF functions into new file

2021-07-16 Thread Heinrich Kuhn
Move any ethdev functionality specific to VF devices into a new file called nfp_ethdev_vf.c. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/meson.build | 1 + drivers/net/nfp/nfp_ethdev_vf.c | 504 drivers/net/nfp/nfp_net.c

[dpdk-dev] [PATCH v2 4/7] net/nfp: prototype common functions in header file

2021-07-16 Thread Heinrich Kuhn
The majority of "ethdev" type functions are used for both PF devices and VF devices. Prototype these functions in the nfp_net_pmd header file in preparation of splitting PF and VF specific functions. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/nfp_net.c | 87

[dpdk-dev] [PATCH v2 3/7] net/nfp: move CPP bridge to a separate file

2021-07-16 Thread Heinrich Kuhn
This commit moves the CPP bridge logic to a separate file. A new corresponding header file is also created. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/meson.build | 1 + drivers/net/nfp/nfp_cpp_bridge.c | 392 +++ drivers/net/

[dpdk-dev] [PATCH v2 2/7] net/nfp: move rxtx functions to their own file

2021-07-16 Thread Heinrich Kuhn
Create a new rxtx file and move the Rx/Tx functions to this file. This commit will also move the needed shared functions to the nfp_net_pmd.h file as needed. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/meson.build |1 + drivers/net/nfp/nfp_net.c | 1090

  1   2   >