Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

Hi Maxime, Thanks for your comments. Applies are inline. > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, July 13, 2021 10:30 PM > To: Ma, WenwuX ; dev@dpdk.org > Cc: Xia, Chenbo ; Jiang, Cheng1 > ; Hu, Jiayu ; Wang, YuanX > > Subject: Re: [PATCH v5 3/4] vhost: support asyn

Re: [dpdk-dev] [PATCH] net/mlx5: do not allow copy to mark via modify field

Hi, Alexander > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 16, 2021 21:35 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH] net/mlx5: do not allow copy to mark via modify field > > Mark requires a tag resource to be

Re: [dpdk-dev] [PATCH v2 11/14] vdpa/mlx5: remove PCI specifics

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:15 > To: Slava Ovsiienko > Cc: NBU-Contact-Thomas Monjalon ; > dev@dpdk.org; Xueming(Steven) Li ; Matan Azrad > > Subject: [PATCH v2 11/14] vdpa/mlx5: remove PCI specifics > > From: Thomas Monjalon > > R

[dpdk-dev] [PATCH] net/txgbe: fix VLAN filter setting for VF

Fix the function call error on VLAN filter table address setting for VF. Fixes: aa1ae7941e71 ("net/txgbe: support VF VLAN") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev_vf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/txgbe/

Re: [dpdk-dev] [PATCH v2 14/14] common/mlx5: clean up legacy PCI bus driver

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:15 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Xueming(Steven) Li ; Matan > Azrad ; Shahaf Shuler ; Ray > Kinsella > Subject: [PATCH v2 14/14] common/mlx5: clean up legacy PCI bus driver > > Clean up legacy

Re: [dpdk-dev] [PATCH v2 13/14] compress/mlx5: migrate to common driver

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:15 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Xueming(Steven) Li ; Matan > Azrad ; Fiona Trahe ; Ashish > Gupta > Subject: [PATCH v2 13/14] compress/mlx5: migrate to common driver > > To support auxiliary b

Re: [dpdk-dev] [PATCH v2 12/14] vdpa/mlx5: support SubFunction

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:15 > To: Slava Ovsiienko > Cc: NBU-Contact-Thomas Monjalon ; > dev@dpdk.org; Xueming(Steven) Li ; Matan Azrad > > Subject: [PATCH v2 12/14] vdpa/mlx5: support SubFunction > > From: Thomas Monjalon > > Su

Re: [dpdk-dev] [PATCH v2 10/14] vdpa/mlx5: define driver name as macro

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:15 > To: Slava Ovsiienko > Cc: NBU-Contact-Thomas Monjalon ; > dev@dpdk.org; Xueming(Steven) Li ; Matan Azrad > > Subject: [PATCH v2 10/14] vdpa/mlx5: define driver name as macro > > From: Thomas Monjalon

Re: [dpdk-dev] [PATCH v2 09/14] regex/mlx5: migrate to common driver

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:15 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Xueming(Steven) Li ; Ori Kam > > Subject: [PATCH v2 09/14] regex/mlx5: migrate to common driver > > To support auxiliary bus, upgrades driver to use mlx5 common

Re: [dpdk-dev] [PATCH v2 08/14] net/mlx5: check max Verbs port number

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:15 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Xueming(Steven) Li ; Matan > Azrad ; Shahaf Shuler > Subject: [PATCH v2 08/14] net/mlx5: check max Verbs port number > > Verbs API doesn't support Device port n

Re: [dpdk-dev] [PATCH v2 07/14] net/mlx5: support SubFunction

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:15 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Xueming(Steven) Li ; Matan > Azrad ; Shahaf Shuler ; Anatoly > Burakov > Subject: [PATCH v2 07/14] net/mlx5: support SubFunction > > This patch introduces SF su

Re: [dpdk-dev] [PATCH v2 06/14] net/mlx5: migrate to bus-agnostic common driver

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:14 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Xueming(Steven) Li ; Matan > Azrad ; Shahaf Shuler ; Anatoly > Burakov > Subject: [PATCH v2 06/14] net/mlx5: migrate to bus-agnostic common driver > > To suppor

Re: [dpdk-dev] [PATCH v2 05/14] net/mlx5: remove PCI dependency

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:14 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Xueming(Steven) Li ; Matan > Azrad ; Shahaf Shuler > Subject: [PATCH v2 05/14] net/mlx5: remove PCI dependency > > To support more bus types, remove PCI depende

Re: [dpdk-dev] [PATCH v2 04/14] common/mlx5: get PCI device address from any bus

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:14 > To: Slava Ovsiienko > Cc: NBU-Contact-Thomas Monjalon ; > dev@dpdk.org; Xueming(Steven) Li ; Matan Azrad > ; Shahaf Shuler ; Ray Kinsella > > Subject: [PATCH v2 04/14] common/mlx5: get PCI device addre

Re: [dpdk-dev] [PATCH v2 03/14] common/mlx5: support auxiliary bus

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:14 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Xueming(Steven) Li ; Matan > Azrad ; Shahaf Shuler ; Ray > Kinsella > Subject: [PATCH v2 03/14] common/mlx5: support auxiliary bus > > This patch adds auxiliary

Re: [dpdk-dev] [PATCH v2 02/14] common/mlx5: move description of PCI sysfs functions

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:14 > To: Slava Ovsiienko > Cc: NBU-Contact-Thomas Monjalon ; > dev@dpdk.org; Xueming(Steven) Li ; Matan Azrad > ; Shahaf Shuler > Subject: [PATCH v2 02/14] common/mlx5: move description of PCI sysfs > funct

Re: [dpdk-dev] [PATCH v2 01/14] common/mlx5: add common device driver

> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, July 13, 2021 16:14 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Xueming(Steven) Li ; Matan > Azrad ; Shahaf Shuler ; Ray > Kinsella > Subject: [PATCH v2 01/14] common/mlx5: add common device driver > > To support auxiliary b

[dpdk-dev] [PATCH v3] net/softnic: fix memory leak in parsing arguments

From: Dapeng Yu In function pmd_parse_args(), firmware path is duplicated from device arguments as character string, but is never freed, which cause memory leak. This patch changes the type of firmware member of struct pmd_params to character array, to make memory resource release unnecessary, a

Re: [dpdk-dev] [PATCH v2] vhost: fix assuming packed ring size is a power of 2

> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, July 7, 2021 6:30 PM > To: dev@dpdk.org; Jiang, Cheng1 ; Xia, Chenbo > > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH v2] vhost: fix assuming packed ring size is a power of 2 > > Unlike split ring, packed ring doe

Re: [dpdk-dev] [PATCH v2] ifpga/base/meson: fix looking for librt

> > Hi Tianfei, > > To reproduce this, assume using Ubuntu 20.04. > 1. Install libfdt (It will include ifpga driver from drivers/raw/ifpga/base) > $ sudo apt-get install libfdt-dev > 2. configure DPDK library > $ meson build > 3. check libdpdk.pc file in build/meson-private/libdpdk.pc. It

Re: [dpdk-dev] [PATCH v4] ethdev: add IPv4 and L4 checksum RSS offload types

> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, July 13, 2021 6:24 PM > To: Zhang, AlvinX ; Zhang, Qi Z > ; ajit.khapa...@broadcom.com > Cc: dev@dpdk.org; Singh, Aman Deep > Subject: Re: [PATCH v4] ethdev: add IPv4 and L4 checksum RSS offload types > > On 7/13/21 12:38 PM,

[dpdk-dev] [PATCH v1] app/testpmd: fix port MAC address after resetting port

MAC address of each port in global variable ports hasn't been updated after resetting. It was the initial one after resetting VF MAC address. This patch gets correct port MAC address when starting port. Fixes: a5279d25616d ("app/testpmd: check status of getting MAC address") Cc: sta...@dpdk.org S

Re: [dpdk-dev] [PATCH 1/1] net/i40e: fix compilation failure on core-avx-i

Hi Shahed, > -Original Message- > From: Shahed Shaikh mailto:sha...@niometrics.com>> > Sent: Tuesday, June 22, 2021 5:37 PM > To: Xing, Beilei mailto:beilei.x...@intel.com>> > Cc: dev@dpdk.org; Shahed Shaikh > mailto:sha...@niometrics.com>>; > sta...@dpdk.org

Re: [dpdk-dev] Canceled: DTS improvement WG - Debate/triag inputs - Extending for next 5 weeks

Hi Lincoln, That was the last meeting in that series. I have added a new series. This is with Zoom. Hopefully, it works better for everyone. Thanks, Honnappa From: Lincoln Lavoie Sent: Tuesday, July 6, 2021 8:56 AM To: Honnappa Nagarahalli Cc: Chen, Zhaoyan ; Buckley, Daniel M

Re: [dpdk-dev] [PATCH 2/2] lib/sched: optimize exception handling code

Acked-by: Cristian Dumitrescu

[dpdk-dev] DTS improvement WG - Debate/triag inputs

Hello, We will continuing debating/triaging the inputs from [1]. As discussed, I am blocking the calendar for next 4 weeks. Thank you, Honnappa [1] https://docs.google.com/document/d/1c5S0_mZzFvzZfYkqyORLT2-qNvUb-fBdjA6DGusy4yM/edit#

Re: [dpdk-dev] [PATCH 1/2] lib/sched: fix return value judgment

Acked-by: Cristian Dumitrescu

Re: [dpdk-dev] RHEL 7 support

On Tue, Jul 13, 2021 at 2:48 AM Kevin Traynor wrote: > > On 12/07/2021 18:34, Honnappa Nagarahalli wrote: > > > > > >> > >> Hi, > >> > >> I would like to open a discussion about RHEL 7 support in DPDK. > >> How long do we want to support it in new DPDK versions? > >> Can we drop RHEL 7 support st

[dpdk-dev] [PATCH] eal: fix argument to rte_bsf32_safe

The first argument to rte_bsf32_safe was incorrectly declared as a 64 bit value. This function only correctly handles on 32 bit values and the underlying function rte_bsf32 only accepts 32 bit values. This was introduced when the safe version was added and probably cause by copy/paste from the 64 b

Re: [dpdk-dev] RHEL 7 support

On Tue, Jul 13, 2021 at 5:48 AM Kevin Traynor wrote: > > On 12/07/2021 18:34, Honnappa Nagarahalli wrote: > > > > > >> > >> Hi, > >> > >> I would like to open a discussion about RHEL 7 support in DPDK. > >> How long do we want to support it in new DPDK versions? > >> Can we drop RHEL 7 support st

Re: [dpdk-dev] [PATCH v2 0/2] net/mlx5: add flow rule match for IPv4 IHL field

Hi, > -Original Message- > From: Gregory Etelson > Sent: Monday, July 5, 2021 2:41 PM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh > Subject: [PATCH v2 0/2] net/mlx5: add flow rule match for IPv4 IHL field > > Expand MLX5 PMD flows functionality with a mat

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

Hi Jan, > -Original Message- > From: Jan Viktorin > Sent: Tuesday, July 13, 2021 2:06 PM > > On Tue, 13 Jul 2021 12:26:35 +0300 > Andrew Rybchenko wrote: > > > On 7/13/21 11:18 AM, Havlík Martin wrote: > > > Dne 2021-07-12 15:07, Ori Kam napsal: > > >> Hi Jan, > > >> > > >>> -Origi

Re: [dpdk-dev] [PATCH v5 4/4] examples/vhost: support vhost async dequeue data path

On 7/5/21 8:11 PM, Wenwu Ma wrote: > This patch is to add vhost async dequeue data-path in vhost sample. > vswitch can leverage IOAT to accelerate vhost async dequeue data-path. " This patch adds support for async dequeue path to Vhost example. " > Signed-off-by: Wenwu Ma > --- > doc/guides/

Re: [dpdk-dev] [Bug 754] quick question about including netinet/ip.h in rte_ethdev.h

On Tue, 13 Jul 2021 10:14:20 + bugzi...@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=754 > > Bug ID: 754 >Summary: quick question about including netinet/ip.h in > rte_ethdev.h >Product: DPDK >Version: 19.11 >

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

On Tue, Jul 13, 2021 at 08:27:43PM +0800, Chengwen Feng wrote: > This patch introduce 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng

Re: [dpdk-dev] [PATCH 1/2] security: enforce semantics for Tx inline processing

On Tue, Jul 13, 2021 at 02:08:18PM +, Ananyev, Konstantin wrote: > > > > > Adding more rte_security and PMD maintainers into the loop. > > > > > > > > > > > > > > > For Tx inline processing, when > > > > > > > > > > > > > RTE_SECURITY_TX_OLOAD_NEED_MDATA is > > > > > > > > > > > > > set, rt

[dpdk-dev] [PATCH 6/6] net/ena: update version to v2.4.0

This version update contains: * Rx interrupts feature, * Support for the RSS hash function reconfiguration, * Small rework of the works, * Reset trigger on Tx path fix. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dpdk-dev] [PATCH 5/6] net/ena: rework RSS configuration

Allow user to specify his own hash key and hash ctrl if the device is supporting that. HW interprets the key in reverse byte order, so the PMD reorders the key before passing it to the ena_com layer. Default key is being set in random matter each time the device is being initialized. Moreover, ma

[dpdk-dev] [PATCH 4/6] net/ena: add support for Rx interrupts

In order to support asynchronous Rx in the applications, the driver has to configure the event file descriptors and configure the HW. This patch configures appropriate data structures for the rte_ethdev layer, adds .rx_queue_intr_enable and .rx_queue_intr_disable API handlers, and configures IO qu

[dpdk-dev] [PATCH 3/6] net/ena: trigger reset when Tx prepare fails

If the prepare function failed, then it means the descriptors are in the invalid state. This condition now triggers the reset, which should be further handled by the application. To notify the application about prepare function failure, the error log was added. In general, it should never fail in

[dpdk-dev] [PATCH 2/6] net/ena: make use of the IO debug build option

ENA defined its own logger flags for Tx and Rx, but they weren't technically used anywhere. Those data path loggers weren't used anywhere after the definition. This commit uses the generic RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX flags to define PMD_TX_LOG and PMD_RX_LOG which are now being use

[dpdk-dev] [PATCH 1/6] net/ena: adjust driver logs

ENA logs were not consistent regarding the new line character. Few of them were relying on the new line character added by the PMD_*_LOG macros, but most were adding the new line character by themselves. It was causing ENA logs to add extra empty line after almost each log. To unify this behavior,

[dpdk-dev] [PATCH 0/6] net/ena: v2.4.0 driver update

Hi, this set contains 2 major ENA features: * RSS hash function key and reconfiguration - API for changing hf was also introduced, although it's not supported in the device right now. * Rx interrupts support. Moreover support for the RTE_ETHDEV_DEBUG_[TR]X flags introduced in v21.05 was added

Re: [dpdk-dev] [PATCH v7 2/2] app/testpmd: support matching the reserved filed for VXLAN

HI Raslan: Yes, you are right. Forgot to correct the typo when addressing your comment to change the title. BR Rongwei > -Original Message- > From: Raslan Darawsheh > Sent: Tuesday, July 13, 2021 11:34 PM > To: Rongwei Liu ; Matan Azrad ; > Slava Ovsiienko ; Ori Kam ; >

Re: [dpdk-dev] [PATCH v7 2/2] app/testpmd: support matching the reserved filed for VXLAN

> -Original Message- > From: Raslan Darawsheh > Sent: Tuesday, July 13, 2021 3:55 PM > To: Rongwei Liu ; Matan Azrad > ; Slava Ovsiienko ; Ori Kam > ; NBU-Contact-Thomas Monjalon > ; Xiaoyun Li > Cc: dev@dpdk.org > Subject: RE: [PATCH v7 2/2] app/testpmd: support matching the reserved >

[dpdk-dev] [PATCH v2] net/mlx5: fix threshold for mbuf replenishment in MPRQ

The replenishment scheme for the vectorized MPRQ Rx burst aims to improve the cache locality by allocating new mbufs only when there are almost no mbufs left: one burst gap between allocated and consumed indexes. This gap is not big enough to accommodate a corner case when we have a very aggressiv

Re: [dpdk-dev] [PATCH v6 00/26] net/mlx5: insertion rate optimization

Hi, > -Original Message- > From: Suanming Mou > Sent: Tuesday, July 13, 2021 11:45 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Raslan Darawsheh ; Ori Kam ; > dev@dpdk.org > Subject: [PATCH v6 00/26] net/mlx5: insertion rate optimization > > This patch series optimize the flow inserti

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

On 7/5/21 8:11 PM, Wenwu Ma wrote: > From: Yuan Wang > > This patch implements asynchronous dequeue data path for split ring. > A new asynchronous dequeue function is introduced. With this function, > the application can try to receive packets from the guest with > offloading large copies to t

Re: [dpdk-dev] [PATCH v2] dmadev: introduce DMA device library

On Tue, Jul 13, 2021 at 03:19:39PM +0100, Ananyev, Konstantin wrote: > > > +#include "rte_dmadev_core.h" > > + > > +/** > > + * DMA flags to augment operation preparation. > > + * Used as the 'flags' parameter of rte_dmadev_copy/copy_sg/fill/fill_sg. > > + */ > > +#define RTE_DMA_FLAG_FENCE (1

Re: [dpdk-dev] [PATCH v2] dmadev: introduce DMA device library

> +#include "rte_dmadev_core.h" > + > +/** > + * DMA flags to augment operation preparation. > + * Used as the 'flags' parameter of rte_dmadev_copy/copy_sg/fill/fill_sg. > + */ > +#define RTE_DMA_FLAG_FENCE (1ull << 0) > +/**< DMA fence flag > + * It means the operation with this flag must be

Re: [dpdk-dev] [PATCH 1/2] security: enforce semantics for Tx inline processing

> > Adding more rte_security and PMD maintainers into the loop. > > > > > > > > > > > > > For Tx inline processing, when > > > > > > > > > > > > RTE_SECURITY_TX_OLOAD_NEED_MDATA is > > > > > > > > > > > > set, rte_security_set_pkt_metadata() needs to be called > > > > > > > > > > > > for pkts

Re: [dpdk-dev] [PATCH 4/4] ethdev: remove jumbo offload flag

On 7/9/21 8:29 PM, Ferruh Yigit wrote: > Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. > > Instead of drivers announce this capability, application can deduct the > capability by checking reported 'dev_info.max_mtu' or > 'dev_info.max_rx_pktlen'. > > And instead of application explicitly se

Re: [dpdk-dev] [PATCH 3/4] ethdev: move check to library for MTU set

On 7/9/21 8:29 PM, Ferruh Yigit wrote: > Move requested MTU value check to the API to prevent the duplicated > code. > > Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH 2/4] ethdev: move jumbo frame offload check to library

On 7/9/21 8:29 PM, Ferruh Yigit wrote: > Setting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support, > and application should enable the jumbo frame offload support for it. > > When jumbo frame offload is not enabled by application, but MTU bigger > than RTE_ETHER_MTU is requested ther

[dpdk-dev] [PATCH 10/10] ipsec: add ol_flags support

Set mbuff->ol_flags for IPsec packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/esp_inb.c | 17 -- lib/ipsec/esp_outb.c | 48 ++- lib/ipsec

[dpdk-dev] [PATCH 09/10] ipsec: add support for initial SQN value

Update IPsec library to support initial SQN value. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/esp_outb.c | 19 --- lib/ipsec/sa.c | 29 ++--- 2 files ch

[dpdk-dev] [PATCH 08/10] ipsec: add support for SA telemetry

Add telemetry support for ipsec SAs Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/esp_inb.c | 1 + lib/ipsec/esp_outb.c | 12 +- lib/ipsec/meson.build | 2 +- lib/ipsec/rte_ipsec.h | 11 ++ li

[dpdk-dev] [PATCH 07/10] ipsec: add support for NAT-T

Add support for the IPsec NAT-Traversal use case for Tunnel mode packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/iph.h | 13 + lib/ipsec/rte_ipsec_sa.h | 8 +++- lib/ip

[dpdk-dev] [PATCH 06/10] ipsec: add transmit segmentation offload support

Add support for transmit segmentation offload to inline crypto processing mode. This offload is not supported by other offload modes, as at a minimum it requires inline crypto for IPsec to be supported on the network interface. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off

[dpdk-dev] [PATCH 05/10] ipsec: add support for AEAD algorithms

Add support for AES_CCM, CHACHA20_POLY1305 and AES_GMAC. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/crypto.h | 137 +++ lib/ipsec/esp_inb.c | 66 +

[dpdk-dev] [PATCH 04/10] mbuf: add IPsec ESP tunnel type

Add tunnel type for IPsec ESP tunnels Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/mbuf/rte_mbuf_core.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.

[dpdk-dev] [PATCH 03/10] security: add ESN field to ipsec_xform

Update ipsec_xform definition to include ESN field. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/security/rte_security.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/security/rte_security

[dpdk-dev] [PATCH 02/10] security: add UDP params for IPsec NAT-T

Add support for specifying UDP port params for UDP encapsulation option. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/security/rte_security.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/

[dpdk-dev] [PATCH 01/10] security: add support for TSO on IPsec session

Allow user to provision a per security session maximum segment size (MSS) for use when Transmit Segmentation Offload (TSO) is supported. The MSS value will be used when PKT_TX_TCP_SEG or PKT_TX_UDP_SEG ol_flags are specified in mbuf. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Sign

[dpdk-dev] [PATCH 00/10] new features for ipsec and security libraries

Add support for: TSO, NAT-T/UDP encapsulation, ESN AES_CCM, CHACHA20_POLY1305 and AES_GMAC SA telemetry mbuf offload flags Initial SQN value This patchset introduces ABI breakages and it is intended for 21.11 release Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhij

[dpdk-dev] [RFC 10/10] ipsec: add ol_flags support

Set mbuff->ol_flags for IPsec packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/esp_inb.c | 17 -- lib/ipsec/esp_outb.c | 48 ++- lib/ipsec

[dpdk-dev] [RFC 09/10] ipsec: add support for initial SQN value

Update IPsec library to support initial SQN value. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/esp_outb.c | 19 --- lib/ipsec/sa.c | 29 ++--- 2 files ch

[dpdk-dev] [RFC 08/10] ipsec: add support for SA telemetry

Add telemetry support for ipsec SAs Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/esp_inb.c | 1 + lib/ipsec/esp_outb.c | 12 +- lib/ipsec/meson.build | 2 +- lib/ipsec/rte_ipsec.h | 11 ++ li

[dpdk-dev] [RFC 07/10] ipsec: add support for NAT-T

Add support for the IPsec NAT-Traversal use case for Tunnel mode packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/iph.h | 13 + lib/ipsec/rte_ipsec_sa.h | 8 +++- lib/ip

[dpdk-dev] [RFC 06/10] ipsec: add transmit segmentation offload support

Add support for transmit segmentation offload to inline crypto processing mode. This offload is not supported by other offload modes, as at a minimum it requires inline crypto for IPsec to be supported on the network interface. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off

[dpdk-dev] [RFC 05/10] ipsec: add support for AEAD algorithms

Add support for AES_CCM, CHACHA20_POLY1305 and AES_GMAC. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/crypto.h | 137 +++ lib/ipsec/esp_inb.c | 66 +

Re: [dpdk-dev] [PATCH v7 1/2] net/mlx5: support matching on the reserved field of VXLAN

Hi Raslan: That' my first time and not familiar with the process. Keep in mind now. Thanks. BR Rongwei > -Original Message- > From: Raslan Darawsheh > Sent: Tuesday, July 13, 2021 8:56 PM > To: Rongwei Liu ; Matan Azrad ; > Slava Ovsiienko ; Ori Kam ; > NBU-Contac

[dpdk-dev] [RFC 04/10] mbuf: add IPsec ESP tunnel type

Add tunnel type for IPsec ESP tunnels Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/mbuf/rte_mbuf_core.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.

[dpdk-dev] [RFC 03/10] security: add ESN field to ipsec_xform

Update ipsec_xform definition to include ESN field. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/security/rte_security.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/security/rte_security

[dpdk-dev] [RFC 02/10] security: add UDP params for IPsec NAT-T

Add support for specifying UDP port params for UDP encapsulation option. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/security/rte_security.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/

[dpdk-dev] [RFC 00/10] new features for ipsec and security libraries

Add support for: TSO, NAT-T/UDP encapsulation, ESN AES_CCM, CHACHA20_POLY1305 and AES_GMAC SA telemetry mbuf offload flags Initial SQN value Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Radu Nicolau (10): securit

[dpdk-dev] [RFC 01/10] security: add support for TSO on IPsec session

Allow user to provision a per security session maximum segment size (MSS) for use when Transmit Segmentation Offload (TSO) is supported. The MSS value will be used when PKT_TX_TCP_SEG or PKT_TX_UDP_SEG ol_flags are specified in mbuf. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Sign

Re: [dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback

Hi Thomas From: Thomas Monjalon > When registering a new event callback, if allocation fails, there is no need > for > unregistering the callback, because it is not registered. > > Fixes: 9ec0b3869d8d ("ethdev: allow event registration for all ports") > Cc: sta...@dpdk.org > > Signed-off-by: Th

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

On Tue, Jul 13, 2021 at 09:06:39PM +0800, fengchengwen wrote: > Thank you for your valuable comments, and I think we've taken a big step > forward. > > @andrew Could you provide the copyright line so that I can add it to relevant > file. > > @burce, jerin Some unmodified review comments are re

Re: [dpdk-dev] [PATCH v8 7/7] event/cnxk: add Tx event vector fastpath

On Mon, Jul 12, 2021 at 5:01 AM wrote: > > From: Pavan Nikhilesh > > Add Tx event vector fastpath, integrate event vector Tx routine > into Tx burst. > > Signed-off-by: Pavan Nikhilesh * **Added support for Marvell CN10K, CN9K, event Rx/Tx adapter.** * Added Rx/Tx adapter support for event/cn

Re: [dpdk-dev] [PATCH v5 2/4] examples/vhost: use a new API to query remaining ring space

On 7/5/21 8:11 PM, Wenwu Ma wrote: > A new API for querying the remaining descriptor ring capacity > is available, so we use the new one instead of the old one. > > Signed-off-by: Wenwu Ma > --- > examples/vhost/ioat.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --g

Re: [dpdk-dev] [PATCH v5 1/4] examples/vhost: refactor vhost enqueue and dequeue datapaths.

Hi Wenwu, Please do not add dot in the commit title. On 7/5/21 8:11 PM, Wenwu Ma wrote: > Previously, by judging the flag, we call different enqueue/dequeue > functions in data path. > > Now, we use an ops that was initialized when Vhost was created, > so that we can call ops directly in Vhost d

Re: [dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback

On 7/13/21 4:17 PM, Thomas Monjalon wrote: > When registering a new event callback, if allocation fails, > there is no need for unregistering the callback, > because it is not registered. > > Fixes: 9ec0b3869d8d ("ethdev: allow event registration for all ports") > Cc: sta...@dpdk.org > > Signed-o

[dpdk-dev] [PATCH v2 11/14] vdpa/mlx5: remove PCI specifics

From: Thomas Monjalon Removes PCI specific driver, replaces with common class driver. Signed-off-by: Thomas Monjalon --- drivers/vdpa/mlx5/mlx5_vdpa.c | 119 ++ drivers/vdpa/mlx5/mlx5_vdpa.h | 1 - 2 files changed, 34 insertions(+), 86 deletions(-) diff --git

[dpdk-dev] [pull-request] dpdk-next-net for main v21.08 - RC2

The following changes since commit a95bbb72623c310df4d0c8ad45c2ee06f538e01b: version: 21.08-rc1 (2021-07-10 12:01:52 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-net for you to fetch changes up to 1f24e0b41cc0fe7a6660a638e81ef9872ca14ca6: app/testpmd:

[dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback

When registering a new event callback, if allocation fails, there is no need for unregistering the callback, because it is not registered. Fixes: 9ec0b3869d8d ("ethdev: allow event registration for all ports") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- lib/ethdev/rte_ethdev.c | 2 --

[dpdk-dev] [PATCH v2 14/14] common/mlx5: clean up legacy PCI bus driver

Clean up legacy PCI bus driver since all mlx5 PMDs moved to new common PCI bus driver. Signed-off-by: Xueming Li --- drivers/common/mlx5/linux/mlx5_common_os.h | 1 - drivers/common/mlx5/mlx5_common.c | 1 - drivers/common/mlx5/mlx5_common.h | 1 + drivers/common/mlx5/mlx

[dpdk-dev] [PATCH v2 13/14] compress/mlx5: migrate to common driver

To support auxiliary bus, upgrades driver to use mlx5 common driver structure. Signed-off-by: Xueming Li --- drivers/compress/mlx5/mlx5_compress.c | 71 ++- 1 file changed, 15 insertions(+), 56 deletions(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/co

[dpdk-dev] [PATCH v2 12/14] vdpa/mlx5: support SubFunction

From: Thomas Monjalon Supports SubFunction on auxiliary bus. SF probe devargs: auxiliary:mlx5_core.sf.,class=vdpa Signed-off-by: Thomas Monjalon --- doc/guides/vdpadevs/mlx5.rst | 10 ++ drivers/vdpa/mlx5/mlx5_vdpa.c | 8 ++-- 2 files changed, 16 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH v2 09/14] regex/mlx5: migrate to common driver

To support auxiliary bus, upgrades driver to use mlx5 common driver structure. Signed-off-by: Xueming Li --- drivers/regex/mlx5/mlx5_regex.c | 49 - drivers/regex/mlx5/mlx5_regex.h | 1 - 2 files changed, 18 insertions(+), 32 deletions(-) diff --git a/drivers/re

[dpdk-dev] [PATCH v2 10/14] vdpa/mlx5: define driver name as macro

From: Thomas Monjalon Uses macro for pmd driver name. Signed-off-by: Thomas Monjalon --- drivers/vdpa/mlx5/mlx5_vdpa.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c index 8b5bfd8c3d..5ab7c525c2 100644

[dpdk-dev] [PATCH v2 05/14] net/mlx5: remove PCI dependency

To support more bus types, remove PCI dependency where possible. Signed-off-by: Xueming Li --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 +- drivers/net/mlx5/linux/mlx5_os.c| 4 +-- drivers/net/mlx5/mlx5.c | 45 ++--- drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH v2 08/14] net/mlx5: check max Verbs port number

Verbs API doesn't support Device port number larger than 255 by design. Adds check and fails probing with proper error log. Signed-off-by: Xueming Li --- drivers/net/mlx5/linux/mlx5_os.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5

[dpdk-dev] [PATCH v2 07/14] net/mlx5: support SubFunction

This patch introduces SF support. Similar to VF, SF on auxiliary bus is a portion of hardware PF, no representor or bonding parameters for SF. Devargs to support SF: -a auxiliary:mlx5_core.sf.8,dv_flow_en=1 New global syntax to support SF: -a bus=auxiliary,name=mlx5_core.sf.8/class=eth/driver=mlx

[dpdk-dev] [PATCH v2 06/14] net/mlx5: migrate to bus-agnostic common driver

To support SubFunction based on auxiliary bus, common driver supports new bus-agnostic driver. This patch migrates net driver to new common driver. Signed-off-by: Xueming Li --- drivers/net/mlx5/linux/mlx5_os.c | 46 -- drivers/net/mlx5/linux/mlx5_os.h | 3 -- drive

[dpdk-dev] [PATCH v2 03/14] common/mlx5: support auxiliary bus

This patch adds auxiliary bus driver and delegate to registered internal mlx5 common device drivers, i.e. eth, vdpa... Current major target is to support SubFunction on auxiliary bus. As a limitation of current driver, numa node of device is detected from PCI bus of device symbol link, will remov

[dpdk-dev] [PATCH v2 04/14] common/mlx5: get PCI device address from any bus

From: Thomas Monjalon A function is exported to allow retrieving the PCI address of the parent PCI device of a Sub-Function in auxiliary bus sysfs. The function mlx5_dev_to_pci_str() is accepting both PCI and auxiliary devices. In case of a PCI device, it is simply using the device name. The fun

[dpdk-dev] [PATCH v2 02/14] common/mlx5: move description of PCI sysfs functions

From: Thomas Monjalon The Linux-specific functions mlx5_get_pci_addr() and mlx5_get_ifname_sysfs() are better described in the .h file. The requirement for using mlx5_get_pci_addr() is explicit: the node /device must exist in the provided sysfs path. Signed-off-by: Thomas Monjalon --- drivers

[dpdk-dev] [PATCH v2 01/14] common/mlx5: add common device driver

To support auxiliary bus, introduces common device driver and callbacks, suppose to replace mlx5 common PCI bus driver. Mlx5 class drivers, i.e. eth, vDPA, regex and compress normally consumes single Verbs device context to probe a device. The Verbs device comes from PCI address if the device is P

[dpdk-dev] [PATCH v2 00/14] net/mlx5: support Sub-Function

Sub-Function [1] is a portion of the PCI device, a SF netdev has its own dedicated queues(txq, rxq). A SF shares PCI level resources with other SFs and/or with its parent PCI function. Auxiliary bus is the fundamental of SF. This patch set introduces Sub-Function support for mlx5 PMD driver includ

  1   2   3   >