Re: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait until equal

2021-07-07 Thread Jerin Jacob
On Thu, Jul 8, 2021 at 11:55 AM Ruifeng Wang wrote: > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, July 7, 2021 8:37 PM > > To: Bruce Richardson > > Cc: Ruifeng Wang ; tho...@monjalon.net; Jan > > Viktorin ; jer...@marvell.com; dev@dpdk.org; > > david.march...@redhat

Re: [dpdk-dev] [EXT] [PATCH] compress/mlx5: fix memory region unregistration

2021-07-07 Thread Michael Baum
Hi, From: Akhil Goyal > > The issue can cause illegal physical address access while a huge-page > > A is released and huge-page B is allocated on the same virtual address. > > The old MR can be matched using the virtual address of huge-page B but > > the HW will access the physical address of hug

Re: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait until equal

2021-07-07 Thread Ruifeng Wang
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, July 7, 2021 8:37 PM > To: Bruce Richardson > Cc: Ruifeng Wang ; tho...@monjalon.net; Jan > Viktorin ; jer...@marvell.com; dev@dpdk.org; > david.march...@redhat.com; nd ; Honnappa Nagarahalli > > Subject: Re: [dpdk-dev] [PATCH v

Re: [dpdk-dev] [PATCH v7 14/19] net/ngbe: add device start and stop operations

2021-07-07 Thread Jiawen Wu
On July 7, 2021 10:05 PM, Andrew Rybchenko wrote: > On 7/6/21 12:55 PM, Jiawen Wu wrote: > > Setup MSI-X interrupt, complete PHY configuration and set device link > > speed to start device. Disable interrupt, stop hardware and clear > > queues to stop device. > > > > Signed-off-by: Jiawen Wu > >

Re: [dpdk-dev] [PATCH 0/2] fix RSS expansion missing items

2021-07-07 Thread Matan Azrad
From: Xiaoyu Min > This patch set fixs the missing items in RSS expansion. > > Xiaoyu Min (2): > net/mlx5: fix missing RSS expandable items > net/mlx5: fix missing RSS expansion of IPv6 frag > Series-acked -by: Matan Azrad > drivers/net/mlx5/mlx5_flow.c | 10 +- > 1 file chang

Re: [dpdk-dev] [PATCH v2] net/ice: support QoS BW config after VF reset in DCF

2021-07-07 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Thursday, July 8, 2021 10:34 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei ; Xu, Ting > Subject: [PATCH v2] net/ice: support QoS BW config after VF reset in DCF > > When VF reset happens, the QoS bandwidth configu

Re: [dpdk-dev] [PATCH v2] net/ice: fix error check for QoS in DCF

2021-07-07 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Thursday, July 8, 2021 10:32 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei ; Xu, Ting ; > sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix error check for QoS in DCF > > This patch fixed some unreasonable error c

Re: [dpdk-dev] [PATCH v1 0/2] simplify flow rules of FDIR for IP fragment

2021-07-07 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Wednesday, July 7, 2021 2:18 PM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Wu, Wenjun1 > Subject: [PATCH v1 0/2] simplify flow rules of FDIR for IP fragment > > This patch simplify the pattern of flow rules of FDIR for IP fragment. > > Flo

[dpdk-dev] [PATCH v3] vhost: allow to check in-flight packets for async vhost

2021-07-07 Thread Jiayu Hu
This patch allows to check the amount of in-flight packets for the vhost queue using async acceleration. Signed-off-by: Jiayu Hu Reviewed-by: Maxime Coquelin --- v3: * update commit log and doc v2: * use DEBUG log level * return -1 when async is not registered doc/guides/prog_guide/vhost_lib.r

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-07 Thread fengchengwen
On 2021/7/7 19:01, Bruce Richardson wrote: > On Wed, Jul 07, 2021 at 04:04:16PM +0530, Jerin Jacob wrote: >> On Wed, Jul 7, 2021 at 2:05 PM Bruce Richardson >> wrote: >>> >>> On Wed, Jul 07, 2021 at 01:38:58PM +0530, Jerin Jacob wrote: On Mon, Jul 5, 2021 at 10:46 PM Bruce Richardson wr

[dpdk-dev] [PATCH v6 2/2] test/power: round cpuinfo cur freq only in CPPC cpufreq

2021-07-07 Thread Richael Zhuang
On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what was set when using CPPC cpufreq driver. For other cpufreq driver, no need to round it currently, or else this check will fail with turbo enabled. For example, with acpi_cpufreq, cpuinfo_cur_freq can be 240

[dpdk-dev] [PATCH v6 1/2] power: add support for cppc cpufreq

2021-07-07 Thread Richael Zhuang
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are supported, which are both not available on arm64 platforms. Add support for cppc_cpufreq driver which works on most arm64 platforms. Signed-off-by: Richael Zhuang --- app/test/test_power.c | 3 +- app/test/test_power_c

[dpdk-dev] [PATCH v6 0/2] power: add support for cppc cpufreq driver

2021-07-07 Thread Richael Zhuang
v6: fix some checkpatch errors and warnings rebase on Anatoly's patch: http://dpdk.org/patch/94763 Richael Zhuang (2): power: add support for cppc cpufreq test/power: round cpuinfo cur freq only in CPPC cpufreq app/test/test_power.c | 3 +- app/test/test_power_cpufreq.c | 26 +-

[dpdk-dev] [PATCH v2] net/ice: support QoS BW config after VF reset in DCF

2021-07-07 Thread Ting Xu
When VF reset happens, the QoS bandwidth configuration will be lost. If the reset is not caused by DCB change, it is supposed to replay the bandwidth configuration to VF by DCF. In this patch, when a vsi update PF event is received from PF after VF reset, and it is confirmed that DCB is not changed

[dpdk-dev] [PATCH v2] net/ice: fix error check for QoS in DCF

2021-07-07 Thread Ting Xu
This patch fixed some unreasonable error check. Move all checks into one helper function before configuring. Skip the check for DCF (VF0). Fixes: 3a5a5bfc618b ("net/ice: support QoS config VF bandwidth in DCF") Cc: sta...@dpdk.org Signed-off-by: Ting Xu --- v1->v2: rebase --- drivers/net/ice/i

Re: [dpdk-dev] [PATCH v5 1/2] power: add support for cppc cpufreq

2021-07-07 Thread Richael Zhuang
> -Original Message- > From: David Hunt > Sent: Wednesday, July 7, 2021 9:47 PM > To: Richael Zhuang ; dev@dpdk.org > Cc: yux.ji...@intel.com > Subject: Re: [PATCH v5 1/2] power: add support for cppc cpufreq > > Hi Richael, > > On 25/6/2021 3:02 AM, Richael Zhuang wrote: > > Currently

Re: [dpdk-dev] [PATCH v3] ethdev: add IPv4 and L4 checksum RSS offload types

2021-07-07 Thread Zhang, Qi Z
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, July 7, 2021 9:11 PM > To: Zhang, Qi Z ; Zhang, AlvinX > ; ajit.khapa...@broadcom.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v3] ethdev: add IPv4 and L4 checksum RSS offload types > > On 7/7/21 4:00 PM, Zhang, Qi Z wrote

Re: [dpdk-dev] [PATCH RESEND] eal: allow hugetlbfs sub-directories

2021-07-07 Thread John Levon
On Wed, Jul 07, 2021 at 11:06:05PM +0300, Dmitry Kozlyuk wrote: > > get_hugepage_dir() was implemented in such a way that a --huge-dir option > > had to exactly match the mountpoint, but there's no reason for this > > restriction. Fix the implementation to allow a sub-directory within a > > suitab

Re: [dpdk-dev] [pull-request] next-crypto 21.08 rc1

2021-07-07 Thread Thomas Monjalon
07/07/2021 21:30, Akhil Goyal: > Shijith Thotton (2): > drivers: add octeontx crypto adapter framework > drivers: add octeontx crypto adapter data path It seems there is an ABI breakage: devtools/check-abi.sh: line 38: 958581 Segmentation fault (core dumped) abidiff $ABIDIFF_OPTIONS $

Re: [dpdk-dev] [RFC] toolchain specific macro expansion

2021-07-07 Thread Tyler Retzlaff
On Wed, Jul 07, 2021 at 10:35:56PM +0200, Thomas Monjalon wrote: > 07/07/2021 22:23, Tyler Retzlaff: > > On Thu, Jun 24, 2021 at 06:29:20PM +0200, Thomas Monjalon wrote: > > > 24/06/2021 18:02, Tyler Retzlaff: > > > > On Thu, Jun 24, 2021 at 08:54:49AM +0200, Thomas Monjalon wrote: > > > > > 23/06/

[dpdk-dev] [PATCH] pipeline: add support for LPM lookup

2021-07-07 Thread Cristian Dumitrescu
Add support for the Longest Prefix Match (LPM) lookup to the SWX pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Churchill Khangar --- lib/pipeline/rte_swx_ctl.c | 99 ++--- lib/pipeline/rte_swx_pipeline.c | 78 +- 2 files cha

Re: [dpdk-dev] [RFC] toolchain specific macro expansion

2021-07-07 Thread Thomas Monjalon
07/07/2021 22:23, Tyler Retzlaff: > On Thu, Jun 24, 2021 at 06:29:20PM +0200, Thomas Monjalon wrote: > > 24/06/2021 18:02, Tyler Retzlaff: > > > On Thu, Jun 24, 2021 at 08:54:49AM +0200, Thomas Monjalon wrote: > > > > 23/06/2021 20:26, Tyler Retzlaff: > > > > > // lib/eal/gcc/rte_toolchain_common.h

[dpdk-dev] [PATCH v2] eal/windows: enforce alarm APIs parameter check

2021-07-07 Thread Jie Zhou
eal/windows alarm APIs rte_eal_alarm_set and rte_eal_alarm_cancel did not check parameters to fail fast for invalid parameters, which caught by DPDK UT alarm_autotest. Enforce eal/windows alarm APIs parameter check to fail fast for invalid parameters. Fixes: f4cbdbc7fbd2 ("eal/windows: implement

Re: [dpdk-dev] [RFC] toolchain specific macro expansion

2021-07-07 Thread Tyler Retzlaff
On Thu, Jun 24, 2021 at 06:29:20PM +0200, Thomas Monjalon wrote: > 24/06/2021 18:02, Tyler Retzlaff: > > On Thu, Jun 24, 2021 at 08:54:49AM +0200, Thomas Monjalon wrote: > > > 23/06/2021 20:26, Tyler Retzlaff: > > > > // lib/eal/gcc/rte_toolchain_common.h > > > > #define __rte_noreturn __attribute_

Re: [dpdk-dev] [PATCH RESEND] eal: allow hugetlbfs sub-directories

2021-07-07 Thread Dmitry Kozlyuk
2021-06-25 11:44 (UTC+0100), John Levon: > get_hugepage_dir() was implemented in such a way that a --huge-dir option > had to exactly match the mountpoint, but there's no reason for this > restriction. Fix the implementation to allow a sub-directory within a > suitable hugetlbfs mountpoint to be sp

[dpdk-dev] [pull-request] next-crypto 21.08 rc1

2021-07-07 Thread Akhil Goyal
The following changes since commit 71f8bd4e60eacbaadfe568293620367bb7a0468f: net/tap: define offload capabilities constants (2021-07-02 19:03:03 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 2d61d4b60f4ca2b6b2b1de210

Re: [dpdk-dev] atomic operations

2021-07-07 Thread Thomas Monjalon
07/07/2021 21:04, Honnappa Nagarahalli: > > > > > > In the deprecation notices of DPDK 21.05, we can still read this: > > " > > * rte_atomicNN_xxx: These APIs do not take memory order parameter. This > > does > > not allow for writing optimized code for all the CPU architectures > > supported

Re: [dpdk-dev] [EXT] [PATCH] compress/mlx5: fix memory region unregistration

2021-07-07 Thread Akhil Goyal
> The issue can cause illegal physical address access while a huge-page A > is released and huge-page B is allocated on the same virtual address. > The old MR can be matched using the virtual address of huge-page B but > the HW will access the physical address of huge-page A which is no more > part

Re: [dpdk-dev] atomic operations

2021-07-07 Thread Honnappa Nagarahalli
> > In the deprecation notices of DPDK 21.05, we can still read this: > " > * rte_atomicNN_xxx: These APIs do not take memory order parameter. This > does > not allow for writing optimized code for all the CPU architectures supported > in DPDK. DPDK will adopt C11 atomic operations semantics

Re: [dpdk-dev] [PATCH v2 1/2] eal: create runtime dir even when shared data is not used

2021-07-07 Thread Tyler Retzlaff
On Fri, Jul 02, 2021 at 01:55:53PM +0100, Bruce Richardson wrote: > When multi-process is not wanted and DPDK is run with the "no-shconf" > flag, the telemetry library still needs a runtime directory to place the > unix socket for telemetry connections. Therefore, rather than not > creating the dir

Re: [dpdk-dev] [PATCH 2/2] crypto/octeontx2: clear session priv mem upon destroy

2021-07-07 Thread Akhil Goyal
> During session destroy, clear session private memory. > > Signed-off-by: Anoob Joseph > --- > drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c > b/drivers/crypto/octeontx2/otx2_cryptodev_sec.

Re: [dpdk-dev] ABI/API stability towards drivers

2021-07-07 Thread Tyler Retzlaff
On Fri, Jul 02, 2021 at 10:00:11AM +0200, Morten Brørup wrote: > Regarding the ongoing ABI stability project, it is suggested to export driver > interfaces as internal. > > What are we targeting regarding ABI and API stability towards drivers? last discussed the outcome was that there was no pro

Re: [dpdk-dev] [PATCH v3] doc: policy on the promotion of experimental APIs

2021-07-07 Thread Tyler Retzlaff
On Thu, Jul 01, 2021 at 11:38:42AM +0100, Ray Kinsella wrote: > Clarifying the ABI policy on the promotion of experimental APIS to stable. > We have a fair number of APIs that have been experimental for more than > 2 years. This policy amendment indicates that these APIs should be > promoted or rem

Re: [dpdk-dev] [PATCH v4 2/2] common/mlx5: fix compilation flag on port query API

2021-07-07 Thread Thomas Monjalon
The title could be: common/mlx5: fix compatibility with OFED port query API 07/07/2021 17:54, Viacheslav Ovsiienko: > The compilation flag HAVE_MLX5DV_DR_DEVX_PORT depends on presence > of mlx5dv_query_devx_port routine in rdma-core library. > > The mlx5dv_query_devx_port routine exists only in O

Re: [dpdk-dev] [PATCH v1] lib/eal: enforce alarm APIs parameters check

2021-07-07 Thread Jie Zhou
On Thu, Jul 01, 2021 at 02:45:24PM -0700, Tyler Retzlaff wrote: > On Fri, Jul 02, 2021 at 12:36:45AM +0300, Dmitry Kozlyuk wrote: > > 2021-07-01 09:21 (UTC-0700), Tyler Retzlaff: > > > On Thu, Jul 01, 2021 at 02:31:29AM +0300, Dmitry Kozlyuk wrote: > > > > Hi Jie, > > > > > > > > 2021-06-23 17:36

Re: [dpdk-dev] [PATCH v4 1/2] common/mlx5: add provider query port support to glue library

2021-07-07 Thread Thomas Monjalon
The title could be: common/mlx5: use new port query API if available 07/07/2021 17:54, Viacheslav Ovsiienko: > In order to get E-Switch vport identifiers the mlx5 PMD relies > on two approaches: > [a] use port query API if it is provided by rdma-core library > [b] otherwise, deduce vport ids f

Re: [dpdk-dev] [PATCH v6 5/7] power: support callbacks for multiple Rx queues

2021-07-07 Thread Ananyev, Konstantin
> > > >> Currently, there is a hard limitation on the PMD power management > >> support that only allows it to support a single queue per lcore. This > >> is > >> not ideal as most DPDK use cases will poll multiple queues per core. > >> > >> The PMD power management me

Re: [dpdk-dev] [PATCH v2 0/2] control rules with identical pattern behavior

2021-07-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Tuesday, July 6, 2021 11:12 AM > To: Matan Azrad ; Ori Kam ; Slava > Ovsiienko ; NBU-Contact-Thomas Monjalon > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v2 0/2] control rules with identical pattern behavior > > In

[dpdk-dev] [PATCH 3/3] net/cnxk: update link status when device stopped

2021-07-07 Thread skoteshwar
From: Satha Rao Set link status to down and don't fetch link status from kernel when device in stopped state. Signed-off-by: Satha Rao --- drivers/net/cnxk/cnxk_ethdev.c | 5 + drivers/net/cnxk/cnxk_link.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/

[dpdk-dev] [PATCH 2/3] net/octeontx2: get tm node stats after resource allocated

2021-07-07 Thread skoteshwar
From: Satha Rao We are getting kernel crash while reading tm node stats when tm hierarchy is not committed. Until hierarchy committed hardware resources are not allocated for node, this causes mbox timeout. This patch check for status of HW resources before reading statistics. Signed-off-by: Sat

[dpdk-dev] [PATCH 1/3] net/octeontx2: handle link status when device stopped

2021-07-07 Thread skoteshwar
From: Satha Rao Set link status to down and don't fetch link status from kernel when device in stopped state. Signed-off-by: Satha Rao --- drivers/net/octeontx2/otx2_ethdev.c | 5 + drivers/net/octeontx2/otx2_link.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/dr

Re: [dpdk-dev] [PATCH] crypto/mvsam: fix input args parsing

2021-07-07 Thread Akhil Goyal
> From: Dana Vardi > > This patch fix the input arguments assignment to the correct > parameters in mrvl_pmd_init_params struct. > > Fixes: 25b05a1c806 ("crypto/mvsam: parse max number of sessions") > Cc: sta...@dpdk.org > > Signed-off-by: Dana Vardi > Reviewed-by: Liron Himi > --- Applied to

Re: [dpdk-dev] [PATCH] crypto/mvsam: add comments for three crypto devs

2021-07-07 Thread Akhil Goyal
> > Till now comments explain queue mapping per > one and two crypto devices. > Now added comments for queue mapping for three > crypto devices supported in CN9132. > > Signed-off-by: Michael Shamis > Reviewed-by: Liron Himi > --- Applied to dpdk-next-crypto Title updated as " crypto/mvsam: up

[dpdk-dev] [PATCH v4 2/2] common/mlx5: fix compilation flag on port query API

2021-07-07 Thread Viacheslav Ovsiienko
The compilation flag HAVE_MLX5DV_DR_DEVX_PORT depends on presence of mlx5dv_query_devx_port routine in rdma-core library. The mlx5dv_query_devx_port routine exists only in OFED versions of rdma-core library and is being planned to be removed and replaced with Upstream compatible mlx5dv_query_port.

[dpdk-dev] [PATCH v4 1/2] common/mlx5: add provider query port support to glue library

2021-07-07 Thread Viacheslav Ovsiienko
In order to get E-Switch vport identifiers the mlx5 PMD relies on two approaches: [a] use port query API if it is provided by rdma-core library [b] otherwise, deduce vport ids from the related VF index The latter is not reliable and may not work with newer kernel drivers and in some configurati

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-07-07 Thread Jan Viktorin
On Sun, 4 Jul 2021 15:18:01 + Matan Azrad wrote: > From: Havlík Martin > > Dne 2021-06-23 09:04, Min Hu (Connor) napsal: > > > 在 2021/6/22 17:25, Martin Havlik 写道: > > >> When dedicated queues are enabled, mlx5 PMD fails to install RTE > > >> Flows if the underlying ethdev is not started:

Re: [dpdk-dev] [PATCH] crypto/mvsam: add comments for three crypto devs

2021-07-07 Thread Akhil Goyal
> From: Michael Shamis > > Till now comments explain queue mapping per > one and two crypto devices. > Now added comments for queue mapping for three > crypto devices supported in CN9132. > > Signed-off-by: Michael Shamis > Reviewed-by: Liron Himi > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] crypto/mvsam: fix memset of mrvl sess private data

2021-07-07 Thread Akhil Goyal
> From: Dana Vardi > > This patch fix wrong clear memory session pointer. > > When call mrvl_crypto_pmd_sym_session_clear function, > it might cause the following error: > CRYPTODEV: set_sym_session_private_data() line 497: > Set private data for driver 1 not allowed > > This fix set zeroes to

Re: [dpdk-dev] [PATCH] crypto/mvsam: fix capabilities for crypto algorithms

2021-07-07 Thread Akhil Goyal
> Increased AAD max size up to 64B and allowed AAD increment step > 1B according to EIP197 token HW limitation. > In addition, some capabilities were found incorrect due to > running FIPS tests. The patch fix the capabilities. > > Fixes: 8a61c83af2f ("crypto/mrvl: add mrvl crypto driver") > Fixes:

Re: [dpdk-dev] [PATCH] crypto/mvsam: set session params for AES-GCM mode

2021-07-07 Thread Akhil Goyal
> For AEAD session and AES-GCM mode, IV offset will > set to include the Nonce. > In addition, the following operations order will define: > first encryption and then authentication. > > Fixes: 8a61c83af2fa ("crypto/mrvl: add mrvl crypto driver") > Cc: sta...@dpdk.org > > Signed-off-by: Dana Vard

Re: [dpdk-dev] [PATCH v5 1/2] vhost: enable IOMMU for async vhost

2021-07-07 Thread Ding, Xuan
> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, July 7, 2021 10:34 PM > To: Ding, Xuan ; Maxime Coquelin > ; Xia, Chenbo ; > Thomas Monjalon ; David Marchand > > Cc: dev@dpdk.org; Hu, Jiayu ; Pai G, Sunil > ; Richardson, Bruce ; > Van Haaren, Harry ; Liu, Yong > ; Ma, W

Re: [dpdk-dev] [PATCH v5 0/2] Support compressed firmwares

2021-07-07 Thread David Marchand
On Wed, Jul 7, 2021 at 2:08 PM David Marchand wrote: > > Fedora 34 only provides compressed firmwares. > > Introduce an internal driver helper to handle transparently compression. > > I chose libarchive for decompressing as it seems widely available and > DPDK had used it in the past. > > Windows

Re: [dpdk-dev] [PATCH v3 1/2] eal: create runtime dir even when shared data is not used

2021-07-07 Thread David Marchand
On Wed, Jul 7, 2021 at 2:53 PM Bruce Richardson wrote: > > When multi-process is not wanted and DPDK is run with the "no-shconf" > flag, the telemetry library still needs a runtime directory to place the > unix socket for telemetry connections. Therefore, rather than not > creating the directory w

Re: [dpdk-dev] [PATCH v5 1/2] vhost: enable IOMMU for async vhost

2021-07-07 Thread Bruce Richardson
On Wed, Jul 07, 2021 at 03:33:44PM +0100, Burakov, Anatoly wrote: > On 07-Jul-21 1:54 PM, Ding, Xuan wrote: > > Hi Anatoly, > > > > > -Original Message- > > > From: Burakov, Anatoly > > > Sent: Wednesday, July 7, 2021 8:18 PM > > > To: Ding, Xuan ; Maxime Coquelin > > > ; Xia, Chenbo ; >

Re: [dpdk-dev] Use WFE for spinlock and ring

2021-07-07 Thread Stephen Hemminger
On Sun, 25 Apr 2021 05:56:51 + Ruifeng Wang wrote: > The rte_wait_until_equal_xxx APIs abstract the functionality of 'polling > for a memory location to become equal to a given value'[1]. > > Use the API for the rte spinlock and ring implementations. > With the wait until equal APIs being st

Re: [dpdk-dev] [PATCH 4/4] eal/pause: remove experimental tag from wait until equal

2021-07-07 Thread Stephen Hemminger
On Fri, 11 Sep 2020 13:45:34 +0800 Joyce Kong wrote: > rte_wait_until_equal_xx APIs were introduced in 19.11 release > and there were no changes in the public APIs since then, it > should be mature enough to remove the experimental tag. > > Signed-off-by: Joyce Kong > Reviewed-by: Phil Yang >

Re: [dpdk-dev] [EXT] [PATCH] test/crypto: use formal array size macro

2021-07-07 Thread Akhil Goyal
> > > Replaces the use of local ARRAY_SIZE macro, which is not used > > anywhere else, with the formal RTE_DIM macro for better > > consistency in crypto unit test. > > > > Signed-off-by: Rebecca Troy > > --- > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] test/crypto: fix typo in ESN testcase

2021-07-07 Thread Akhil Goyal
> Acked-by: Hemant Agrawal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v6 5/7] power: support callbacks for multiple Rx queues

2021-07-07 Thread Burakov, Anatoly
On 07-Jul-21 1:51 PM, Ananyev, Konstantin wrote: -Original Message- From: Burakov, Anatoly Sent: Wednesday, July 7, 2021 12:54 PM To: Ananyev, Konstantin ; dev@dpdk.org; Hunt, David Cc: Loftus, Ciara Subject: Re: [PATCH v6 5/7] power: support callbacks for multiple Rx queues On 07

Re: [dpdk-dev] [PATCH v5 1/2] vhost: enable IOMMU for async vhost

2021-07-07 Thread Burakov, Anatoly
On 07-Jul-21 1:54 PM, Ding, Xuan wrote: Hi Anatoly, -Original Message- From: Burakov, Anatoly Sent: Wednesday, July 7, 2021 8:18 PM To: Ding, Xuan ; Maxime Coquelin ; Xia, Chenbo ; Thomas Monjalon ; David Marchand Cc: dev@dpdk.org; Hu, Jiayu ; Pai G, Sunil ; Richardson, Bruce ; Van Ha

Re: [dpdk-dev] [PATCH] test/crypto: fix typo in AES testcase description

2021-07-07 Thread Akhil Goyal
> Hi Rebecca, > > >Fixed typo in the testcase description for AES in the crypto unit test suite > >by > >changing the word 'Scater' to 'Scatter'. > > > >Fixes: c9c9c4ed8746 ("app/test: check scatter-gather for crypto drivers") > > > >Cc: tomaszx.kula...@intel.com > >Cc: sta...@dpdk.org > >Signed-

Re: [dpdk-dev] [EXT] [PATCH] test/crypto: rename slave to worker

2021-07-07 Thread Akhil Goyal
> Modifies the scheduler tests in the crypto unit test suite > to replace the usage of the word 'slave' with the more > appropriate word 'worker'. > > The scheduler test functions were modified as follows: > test_scheduler_attach_slave_op is now called > test_scheduler_attach_worker_op, > test_s

Re: [dpdk-dev] [PATCH v2] test/crypto: fix autotest function parameters

2021-07-07 Thread Akhil Goyal
> Acked-by: Hemant Agrawal Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v7 00/19] net: ngbe PMD

2021-07-07 Thread Andrew Rybchenko
On 7/6/21 12:55 PM, Jiawen Wu wrote: > This patch set provides a skeleton of ngbe PMD, > which adapted to Wangxun WX1860 series NICs. Hopefully final review. $ ./devtools/check-meson.py Error: Incorrect indent at drivers/net/meson.build:43 Error: Incorrect indent at drivers/net/ngbe/meson.build:1

Re: [dpdk-dev] [PATCH v7 19/19] net/ngbe: support to close and reset device

2021-07-07 Thread Andrew Rybchenko
On 7/6/21 12:55 PM, Jiawen Wu wrote: > Support to close and reset device. > > Signed-off-by: Jiawen Wu > --- > drivers/net/ngbe/ngbe_ethdev.c | 63 -- > drivers/net/ngbe/ngbe_ethdev.h | 2 ++ > drivers/net/ngbe/ngbe_rxtx.c | 20 +++ > 3 files changed, 8

Re: [dpdk-dev] [EXT] [PATCH] test: fix crypto_op length for sessionless case

2021-07-07 Thread Akhil Goyal
Hi Abhinandan, > Currently, private_data_offset for the sessionless is computed > wrongly which includes extra bytes added because of using > sizeof(struct rte_crypto_sym_xform) * 2) instead of > (sizeof(union rte_event_crypto_metadata)). Due to this buffer > overflow, the corruption was leading t

Re: [dpdk-dev] [PATCH v7 14/19] net/ngbe: add device start and stop operations

2021-07-07 Thread Andrew Rybchenko
On 7/6/21 12:55 PM, Jiawen Wu wrote: > Setup MSI-X interrupt, complete PHY configuration and set device link > speed to start device. Disable interrupt, stop hardware and clear queues > to stop device. > > Signed-off-by: Jiawen Wu WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Docum

Re: [dpdk-dev] [PATCH v2 1/3] vhost: add unsafe API to drain pkts in async vhost

2021-07-07 Thread Jiang, Cheng1
Hi Sunil, Replies are inline. > -Original Message- > From: Pai G, Sunil > Sent: Monday, July 5, 2021 10:58 PM > To: Jiang, Cheng1 ; maxime.coque...@redhat.com; > Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Jiang, Cheng1 > Subject: RE: [dpdk-dev] [PATCH v2 1/3] vhost:

Re: [dpdk-dev] [PATCH v7 13/19] net/ngbe: add Tx queue setup and release

2021-07-07 Thread Andrew Rybchenko
On 7/6/21 12:55 PM, Jiawen Wu wrote: > Setup device Tx queue and release Tx queue. > > Signed-off-by: Jiawen Wu Same here, format string should be on the next its own line: ### net/ngbe: add Tx queue setup and release CHECK:CAMELCASE: Avoid CamelCase: #299: FILE: drivers/net/ngbe/ngbe_rxtx.c:

Re: [dpdk-dev] [PATCH v7] build: use platform for generic and native builds

2021-07-07 Thread Bruce Richardson
On Tue, Jul 06, 2021 at 11:44:28AM +0200, Juraj Linkeš wrote: > The current meson option 'machine' should only specify the ISA, which is > not sufficient for Arm, where setting ISA implies other settings as well > (and is used in Arm configuration as such). > Use the existing 'platform' meson optio

Re: [dpdk-dev] [PATCH v7 12/19] net/ngbe: add Rx queue setup and release

2021-07-07 Thread Andrew Rybchenko
On 7/6/21 12:55 PM, Jiawen Wu wrote: > Setup device Rx queue and release Rx queue. > > Signed-off-by: Jiawen Wu I thikn format string should be on the next its own line to address below warnings: ### net/ngbe: add Rx queue setup and release WARNING:LONG_LINE: line length of 86 exceeds 80 colum

Re: [dpdk-dev] [PATCH v7 10/19] net/ngbe: support link update

2021-07-07 Thread Andrew Rybchenko
On 7/6/21 12:55 PM, Jiawen Wu wrote: > Register to handle device interrupt. > > Signed-off-by: Jiawen Wu Please, fix below errors. ### net/ngbe: support link update ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #548: FILE: drivers/net/ngbe/ngbe_ethdev.h:10:

Re: [dpdk-dev] [PATCH v7 02/19] net/ngbe: support probe and remove

2021-07-07 Thread Andrew Rybchenko
On 7/6/21 12:55 PM, Jiawen Wu wrote: > Add device IDs for Wangxun 1Gb NICs, map device IDs to register ngbe > PMD. Add basic PCIe ethdev probe and remove. > > Signed-off-by: Jiawen Wu [snip] > > RTE_PMD_REGISTER_PCI(net_ngbe, rte_ngbe_pmd); > +RTE_PMD_REGISTER_PCI_TABLE(net_ngbe, pci_id_ngbe

Re: [dpdk-dev] [PATCH v5 1/2] power: add support for cppc cpufreq

2021-07-07 Thread David Hunt
Hi Richael, On 25/6/2021 3:02 AM, Richael Zhuang wrote: Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are supported, which are both not available on arm64 platforms. Add support for cppc_cpufreq driver which works on most arm64 platforms. Signed-off-by: Richael Zhuang --- H

Re: [dpdk-dev] [dpdk-dev v2] crypto/aesni_gcm: fix performance issue

2021-07-07 Thread Akhil Goyal
> > > > This patch fixes the aesni_gcm performance issue on systems with AVX512 > > CPU flag presented but with VAES CPU flag missing, such as Skylake. > > > > Fixes: 81fe96a0cece ("crypto/aesni_gcm: use architecture independent > API") > > Cc: pablo.de.lara.gua...@intel.com > > > > Signed-off-by:

[dpdk-dev] [PATCH v18 6/7] build: add aarch32 to meson cross-compilation

2021-07-07 Thread Juraj Linkeš
Create meson cross file arm32_armv8a_linux_gcc. Use arm-linux-gnueabihf- toolset which comes with standard packages on most used systems, such as Ubuntu and CentOS. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- config/arm/arm32_armv8_linux_gcc | 16 1 file changed, 16

[dpdk-dev] [PATCH v18 7/7] doc: add aarch32 build guidance

2021-07-07 Thread Juraj Linkeš
From: Phil Yang Add cross-compiling guidance for 32-bit aarch32 DPDK on aarch64 host. Signed-off-by: Phil Yang Acked-by: Ruifeng Wang Acked-by: Aaron Conole --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 38 +++ 1 file changed, 31 insertions(+), 7 deletions(-) diff --gi

[dpdk-dev] [PATCH v18 5/7] build: add aarch32 meson build flags

2021-07-07 Thread Juraj Linkeš
Add aarch32 armv8 SoC to build config. Also modify how arm flags are updated in meson build - for 32-bit build, update only if cross-compiling. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- config/arm/meson.build | 88 +- 1 file changed, 61 inser

[dpdk-dev] [PATCH v18 4/7] eal/arm: update CPU flags

2021-07-07 Thread Juraj Linkeš
There are two execution states on armv8 architecture, aarch64 and aarch32. Add PLATFORM_STR for the latter and update RTE_ARCH_* flags according to e9b97392640. Signed-off-by: Juraj Linkeš --- lib/eal/arm/include/rte_cpuflags_32.h | 1 + lib/eal/arm/rte_cpuflags.c| 11 ++- 2

[dpdk-dev] [PATCH v18 3/7] net/virtio: fix aarch32 build

2021-07-07 Thread Juraj Linkeš
NEON vector path of the PMD needs aarch64 support. But it was enabled for aarch32 build as well because aarch32 build had cpu_family set to aarch64. So build for aarch32 will fail due to unsupported intrinsics. Fix aarch32 build by updating meson file to exclude NEON vector implementation for aarc

[dpdk-dev] [PATCH v18 2/7] net/bnxt: fix aarch32 build

2021-07-07 Thread Juraj Linkeš
From: Ruifeng Wang NEON vector path of the PMD needs aarch64 support. But it was enabled for aarch32 build as well because aarch32 build had cpu_family set to aarch64. So build for aarch32 will fail due to unsupported intrinsics. Fix aarch32 build by updating meson file to exclude NEON vector im

[dpdk-dev] [PATCH v18 1/7] net/sfc: fix aarch32 build

2021-07-07 Thread Juraj Linkeš
From: Ruifeng Wang The sfc PMD was enabled for aarch32 which is 32-bit mode but has cpu_family set to aarch64. As sfc support only 64-bit system, it should be disabled for aarch32. Updated meson file to disable sfc for aarch32 build. Fixes: 141d2870675a ("net/sfc: support aarch64 architecture")

[dpdk-dev] [PATCH v18 0/7] aarch64 -> aarch32 cross compilation support

2021-07-07 Thread Juraj Linkeš
Add support for aarch32 cross build in meson. Aarch32 is an execution state that allows execution of 32-bit code on armv8 machines. This execution state contains a superset of previous armv7 32-bit instructions and features. Thus the aarch32 build is distinct from arvm7 build. v18: Rebased, adjus

Re: [dpdk-dev] [PATCH v3] ethdev: add IPv4 and L4 checksum RSS offload types

2021-07-07 Thread Andrew Rybchenko
On 7/7/21 4:00 PM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Wednesday, July 7, 2021 5:49 PM >> To: Zhang, Qi Z ; Zhang, AlvinX >> ; ajit.khapa...@broadcom.com >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v3] ethdev: add IPv4 and L4 checksum RSS offloa

Re: [dpdk-dev] [PATCH v3] ethdev: add IPv4 and L4 checksum RSS offload types

2021-07-07 Thread Zhang, Qi Z
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, July 7, 2021 5:49 PM > To: Zhang, Qi Z ; Zhang, AlvinX > ; ajit.khapa...@broadcom.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v3] ethdev: add IPv4 and L4 checksum RSS offload types > > On 7/7/21 6:23 AM, Zhang, Qi Z wrote

Re: [dpdk-dev] [PATCH v5 1/2] vhost: enable IOMMU for async vhost

2021-07-07 Thread Ding, Xuan
Hi Anatoly, > -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, July 7, 2021 8:18 PM > To: Ding, Xuan ; Maxime Coquelin > ; Xia, Chenbo ; > Thomas Monjalon ; David Marchand > > Cc: dev@dpdk.org; Hu, Jiayu ; Pai G, Sunil > ; Richardson, Bruce ; Van > Haaren, Harry ; Liu, Yong

[dpdk-dev] [PATCH v3 1/2] eal: create runtime dir even when shared data is not used

2021-07-07 Thread Bruce Richardson
When multi-process is not wanted and DPDK is run with the "no-shconf" flag, the telemetry library still needs a runtime directory to place the unix socket for telemetry connections. Therefore, rather than not creating the directory when this flag is set, we can change the code to attempt the creati

[dpdk-dev] [PATCH v3 2/2] telemetry: add extra log message on socket bind failure

2021-07-07 Thread Bruce Richardson
If the library fails to create the needed socket, add an additional check to report if the error is due to a missing DPDK runtime dir. Signed-off-by: Bruce Richardson Reviewed-by: David Marchand Acked-by: Morten Brørup Acked-by: Ciara Power --- lib/telemetry/telemetry.c | 5 + 1 file chan

Re: [dpdk-dev] [PATCH v6 5/7] power: support callbacks for multiple Rx queues

2021-07-07 Thread Ananyev, Konstantin
> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, July 7, 2021 12:54 PM > To: Ananyev, Konstantin ; dev@dpdk.org; Hunt, > David > Cc: Loftus, Ciara > Subject: Re: [PATCH v6 5/7] power: support callbacks for multiple Rx queues > > On 07-Jul-21 11:11 AM, Ananyev, Konstan

[dpdk-dev] [dpdk-announce] DPDK 20.11.2 released

2021-07-07 Thread Xueming(Steven) Li
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-20.11.2.tar.xz The git tree is at: https://git.dpdk.org/dpdk-stable/log/?h=20.11 Special thanks to Luca for his great help on this version! Xueming Li --- .ci/linux-build.sh |

Re: [dpdk-dev] [PATCH v2 1/2] eal: create runtime dir even when shared data is not used

2021-07-07 Thread Bruce Richardson
On Wed, Jul 07, 2021 at 02:35:15PM +0200, David Marchand wrote: > On Mon, Jul 5, 2021 at 4:39 PM Bruce Richardson > wrote: > > > Should this change be applied to FreeBSD too? > > > > > Yes it should. :-( For some reason I assumed that this would not be relevant > > for FreeBSD, but I obviously sho

Re: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait until equal

2021-07-07 Thread Jerin Jacob
On Wed, Jul 7, 2021 at 5:57 PM Bruce Richardson wrote: > > On Wed, Jul 07, 2021 at 06:46:33AM +, Ruifeng Wang wrote: > > > -Original Message- > > > From: Thomas Monjalon > > > Sent: Wednesday, July 7, 2021 2:32 PM > > > To: Ruifeng Wang > > > Cc: Jan Viktorin ; jer...@marvell.com; Br

Re: [dpdk-dev] [PATCH v2 1/2] eal: create runtime dir even when shared data is not used

2021-07-07 Thread David Marchand
On Mon, Jul 5, 2021 at 4:39 PM Bruce Richardson wrote: > > Should this change be applied to FreeBSD too? > > > Yes it should. :-( For some reason I assumed that this would not be relevant > for FreeBSD, but I obviously should have double-checked the code! Ok, how do you want to handle it? Should

Re: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait until equal

2021-07-07 Thread Bruce Richardson
On Wed, Jul 07, 2021 at 06:46:33AM +, Ruifeng Wang wrote: > > -Original Message- > > From: Thomas Monjalon > > Sent: Wednesday, July 7, 2021 2:32 PM > > To: Ruifeng Wang > > Cc: Jan Viktorin ; jer...@marvell.com; Bruce > > Richardson ; dev@dpdk.org; > > david.march...@redhat.com; nd ;

Re: [dpdk-dev] [PATCH v5 1/2] vhost: enable IOMMU for async vhost

2021-07-07 Thread Burakov, Anatoly
On 07-Jul-21 7:25 AM, Ding, Xuan wrote: Hi, -Original Message- From: Maxime Coquelin Sent: Tuesday, July 6, 2021 5:32 PM To: Burakov, Anatoly ; Ding, Xuan ; Xia, Chenbo ; Thomas Monjalon ; David Marchand Cc: dev@dpdk.org; Hu, Jiayu ; Pai G, Sunil ; Richardson, Bruce ; Van Haaren, Harr

Re: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait until equal

2021-07-07 Thread David Marchand
On Wed, Jul 7, 2021 at 7:44 AM Ruifeng Wang wrote: > diff --git a/meson_options.txt b/meson_options.txt > index 56bdfd0f0a..5012803c77 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -44,3 +44,5 @@ option('tests', type: 'boolean', value: true, description: > 'build unit tes

[dpdk-dev] [PATCH v5 2/2] eal: handle compressed firmware

2021-07-07 Thread David Marchand
Introduce an internal firmware loading helper to remove code duplication in our drivers and handle xz compressed firmware by calling libarchive. This helper tries to look for .xz suffixes so that drivers are not aware the firmware has been compressed. libarchive is set as an optional dependency:

[dpdk-dev] [PATCH v5 1/2] net/ice: factorize firmware loading

2021-07-07 Thread David Marchand
Both "normal" and "dcf" inits have their copy of some firmware loading code. The DSN query is moved in specific parts for the "normal" and "dcf" init. A common helper ice_load_pkg is then introduced and takes an adapter pointer as its main input. This helper takes care of finding the right firmw

[dpdk-dev] [PATCH v5 0/2] Support compressed firmwares

2021-07-07 Thread David Marchand
Fedora 34 only provides compressed firmwares. Introduce an internal driver helper to handle transparently compression. I chose libarchive for decompressing as it seems widely available and DPDK had used it in the past. Windows support only matters for net/ice and firmware loading was skipped in

[dpdk-dev] [PATCH_v3 3/3] regex/mlx5: fix redundancy in PCI remove function

2021-07-07 Thread Michael Baum
In the PCI removal function, PMD releases all driver resources and cancels the regexdev registry. However, regexdev registration is accidentally canceled twice. Remove one of them. Fixes: b34d816363b5 ("regex/mlx5: support rules import") Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- dri

  1   2   >