Re: [dpdk-dev] [PATCH] vhost: fix invalid use of stored last used index

2021-05-14 Thread David Marchand
On Fri, May 14, 2021 at 6:02 PM Balazs Nemeth wrote: > > The optimization introduced by commit d18db8049c7c ("vhost: read last > used index once") didn't account for the fact that > vhost_flush_enqueue_shadow_packed increments the last_used_idx. For this > reason, store last_used_idx after the pot

[dpdk-dev] [PATCH 4/6] net/hns3: fix DCB configuration

2021-05-14 Thread Min Hu (Connor)
From: Huisong Li Currently, the DCB configuration takes effect in the dev_start stage, and the mapping between TCs and queues are also updated in this stage. However, the DCB configuration is delivered in the dev_configure stage. If the configuration fails, it should be intercepted in this stage.

[dpdk-dev] [PATCH 2/6] net/hns3: fix requested FC mode roolback

2021-05-14 Thread Min Hu (Connor)
From: Huisong Li Currently, the "requested_fc_mode" lacks rollback when enabling link FC or PFC fails. For example, it encounters a reset. This may result in incorrect FC mode after a reset. Fixes: d4fdb71a0e7b ("net/hns3: fix flow control mode") Fixes: 62e3ccc2b94c ("net/hns3: support flow cont

[dpdk-dev] [PATCH 1/6] net/hns3: fix check of Rx/Tx queue numbers

2021-05-14 Thread Min Hu (Connor)
From: Huisong Li The Rx/Tx queue numbers should be greater than TC number, this patch adds this check for PF before updating the mapping between TC and queue. Fixes: a951c1ed3ab5 ("net/hns3: support different numbers of Rx and Tx queues") Fixes: 76d794566d43 ("net/hns3: maximize queue number") C

[dpdk-dev] [PATCH 6/6] net/hns3: fix link speed when VF device is down

2021-05-14 Thread Min Hu (Connor)
From: Huisong Li When the port is link down state, it is meaningless to display the port link speed. It should be an undefined state. Fixes: 59fad0f32135 ("net/hns3: support link update operation") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/h

[dpdk-dev] [PATCH 0/6] bugfix for hns3 PMD

2021-05-14 Thread Min Hu (Connor)
This patch set contains six bugfixes for hns3 PMD. Huisong Li (6): net/hns3: fix check of Rx/Tx queue numbers net/hns3: fix requested FC mode roolback net/hns3: remove meaningless packet buffer rollback net/hns3: fix DCB configuration net/hns3: fix DCB cannot be reconfigured net/hns3:

[dpdk-dev] [PATCH 5/6] net/hns3: fix DCB cannot be reconfigured

2021-05-14 Thread Min Hu (Connor)
From: Huisong Li Whether the enable bit of the pfc ("pfc_en") is changed is one of the conditions for reconfiguring the DCB. Currently, pfc_en is not rolled back when DCB configuration fails. This patch fixes it. Fixes: 62e3ccc2b94c ("net/hns3: support flow control") Cc: sta...@dpdk.org Signed-

[dpdk-dev] [PATCH 3/6] net/hns3: remove meaningless packet buffer rollback

2021-05-14 Thread Min Hu (Connor)
From: Huisong Li Packet buffer allocation and hardware pause configuration fail normally when a reset occurs. If the execution fails, rollback of the packet buffer still fails. So this rollback is meaningless. Fixes: 62e3ccc2b94c ("net/hns3: support flow control") Cc: sta...@dpdk.org Signed-off

[dpdk-dev] [PATCH] vhost: fix invalid use of stored last used index

2021-05-14 Thread Balazs Nemeth
The optimization introduced by commit d18db8049c7c ("vhost: read last used index once") didn't account for the fact that vhost_flush_enqueue_shadow_packed increments the last_used_idx. For this reason, store last_used_idx after the potential call to vhost_flush_enqueue_shadow_packed. Fixes: d18db8

[dpdk-dev] [PATCH] crypto/zuc: fix gcc11 maybe-uninitialized warnings

2021-05-14 Thread Kevin Traynor
gcc11 complains that some arrays may be uninitialized in process_zuc_hash_op(). This is because their initialization depends on num_ops being > 0. For example: $ gcc --version gcc (GCC) 11.1.1 20210428 (Red Hat 11.1.1-1) In file included from ../drivers/crypto/zuc/zuc_pmd_private.h:8,

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-14 Thread Honnappa Nagarahalli
> > Currently, the SVE code is compiled only when -march supports SVE (e.g. '- > march=armv8.2a+sve'), there maybe some problem[1] with this approach. > > The solution: > a. If the minimum instruction set support SVE then compiles it. > b. Else if the compiler support SVE then compiles it. > c.

Re: [dpdk-dev] [PATCH] net/nfp: fix internal NFP port addressing

2021-05-14 Thread Ferruh Yigit
On 5/14/2021 10:19 AM, Heinrich Kuhn wrote: > Depending on the breakout mode of the physical ports the internal NFP > port number might differ from the actual physical port number. Prior to > this patch the physical port number was used when making configuration > changes to the physical ports (ena

Re: [dpdk-dev] [PATCH v5 2/3] doc: add flow API features tables

2021-05-14 Thread Thomas Monjalon
14/05/2021 12:42, Ferruh Yigit: > On 4/7/2021 11:33 PM, Thomas Monjalon wrote: > > The NICs overview table lists all supported features per driver. > > There was a single row for "Flow API", > > although rte_flow is composed of many items and actions. > > > > The row "Flow API" is replaced with tw

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

2021-05-14 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, May 12, 2021 11:31 AM > To: Pavan Nikhilesh Bhagavatula > Cc: Honnappa Nagarahalli ; > tho...@monjalon.net; Jerin Jacob Kollanukkaran ; Juraj > Linkeš ; Jan Viktorin ; > Ruifeng Wang ; dev@dpdk.org; nd > Subject: Re: [dp

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

2021-05-14 Thread Juraj Linkeš
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, May 12, 2021 11:18 AM > To: Honnappa Nagarahalli ; > tho...@monjalon.net > Cc: Jerin Jacob Kollanukkaran ; Juraj Linkeš > ; Jan Viktorin ; Ruifeng > Wang ; Bruce Richardson > ; dev@dpdk.org; nd ; nd > > Subject

Re: [dpdk-dev] [PATCH v5 3/3] devtools: check flow API doc tables

2021-05-14 Thread Ferruh Yigit
On 4/7/2021 11:33 PM, Thomas Monjalon wrote: > The script check-doc-vs-code.sh may be used to add > some automatic checks of the doc. > > If run without any argument, a complete check is done. > The optional argument is a git history reference point > to check faster only what has changed since th

Re: [dpdk-dev] [PATCH v5 2/3] doc: add flow API features tables

2021-05-14 Thread Ferruh Yigit
On 4/7/2021 11:33 PM, Thomas Monjalon wrote: > The NICs overview table lists all supported features per driver. > There was a single row for "Flow API", > although rte_flow is composed of many items and actions. > > The row "Flow API" is replaced with two new tables for items and actions. > > Als

Re: [dpdk-dev] [PATCH v4 1/2] config/arm: select most suitable -march for kunpeng soc

2021-05-14 Thread fengchengwen
On 2021/5/14 7:12, Honnappa Nagarahalli wrote: > >> >> On Thu, May 13, 2021 at 6:41 PM Chengwen Feng >> wrote: >>> >>> Currently, the soc_kunpeng930 declares '-march=armv8.2-a+crypto+sve', >>> but some compiler doesn't recognize the march because it doesn't >>> support sve. >>> >>> To solve th

Re: [dpdk-dev] [dpdk-announce] release candidate 21.05-rc3

2021-05-14 Thread Jiang, YuX
Update the test status for Intel part. Till now 70% is executed, 70% is debugged and no critical issue blocked the test. # Basic Intel(R) NIC testing * Build or compile: *Build: cover the build test combination with latest GCC/Clang/ICC version and the popular OS revision

[dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-14 Thread Chengwen Feng
Currently, the SVE code is compiled only when -march supports SVE (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this approach. The solution: a. If the minimum instruction set support SVE then compiles it. b. Else if the compiler support SVE then compiles it. c. Otherwise don't com

[dpdk-dev] [PATCH v5 1/2] config/arm: select most suitable -march for kunpeng soc

2021-05-14 Thread Chengwen Feng
Currently, the soc_kunpeng930 declares '-march=armv8.2-a+crypto+sve', but some compiler doesn't recognize the march because it doesn't support sve. To solve this bug we use the following scheme: 1. Define 'march_base' tuple which defines support march, it should arrange from lower to higher. e.g.

[dpdk-dev] [PATCH v5 0/2] bugfix for Kunpeng SVE compile

2021-05-14 Thread Chengwen Feng
This patch set contains two bugfixes for Kunpeng SVE compile. --- v5: * make sure 'march_feature' parsed depend on 'march_base' * only the kunpeng930 use the new option v4: * fix compile option combine problem of 1/2 patch v3: * fix checkpatch error of 1/2 patch * modify comments of 1/2 patch v2:

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-14 Thread Thomas Monjalon
14/05/2021 11:09, Ferruh Yigit: > On 5/14/2021 9:18 AM, David Marchand wrote: > > On Thu, May 13, 2021 at 5:04 PM Ferruh Yigit wrote: > >>> If you choose to revert, we can ask Red Hat QA to test RC3 without > >>> further delay. Please let us know when you consider the options. > >>> > >> > >> If t

[dpdk-dev] [PATCH] net/nfp: fix internal NFP port addressing

2021-05-14 Thread Heinrich Kuhn
Depending on the breakout mode of the physical ports the internal NFP port number might differ from the actual physical port number. Prior to this patch the physical port number was used when making configuration changes to the physical ports (enable, admin up etc). After this change the internal p

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-14 Thread Ferruh Yigit
On 5/14/2021 9:18 AM, David Marchand wrote: > On Thu, May 13, 2021 at 5:04 PM Ferruh Yigit wrote: >>> If you choose to revert, we can ask Red Hat QA to test RC3 without >>> further delay. Please let us know when you consider the options. >>> >> >> If the patch is not good to go as it is I suggest

[dpdk-dev] [PATCH v2] devtools: add acronyms in dictionary for commit checks

2021-05-14 Thread Ferruh Yigit
GCC -> GNU Compiler Collection ID -> Identification/Identity/Identifier IP -> Internet Protocol QinQ-> IEEE 802.1Q in 802.1Q SoC -> System on a chip VEB -> Virtual Ethernet Bridge Windows -> Signed-off-by: Ferruh Yigit --- Cc: David Marchand v2: * Added 'SoC'. --- dev

Re: [dpdk-dev] [PATCH] devtools: add acronyms in dictionary for commit checks

2021-05-14 Thread Ferruh Yigit
On 5/14/2021 9:15 AM, David Marchand wrote: > On Fri, May 14, 2021 at 10:04 AM Ferruh Yigit wrote: >> >> GCC -> GNU Compiler Collection >> ID -> Identification/Identity/Identifier >> IP -> Internet Protocol >> QinQ-> IEEE 802.1Q in 802.1Q >> VEB -> Virtual Ethernet Bridge >>

[dpdk-dev] 回复: [dpdk-stable] [PATCH] crypto/qat: fix uninitilized compiler warning

2021-05-14 Thread Feifei Wang
> -邮件原件- > 发件人: David Marchand > 发送时间: 2021年5月14日 16:14 > 收件人: Feifei Wang > 抄送: John Griffin ; Fiona Trahe > ; Deepak Kumar Jain ; > Herbert Guan ; Jerin Jacob > ; dev ; nd > ; dpdk stable ; Ruifeng Wang > > 主题: Re: [dpdk-stable] [PATCH] crypto/qat: fix uninitilized compiler warning >

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-14 Thread David Marchand
On Thu, May 13, 2021 at 5:04 PM Ferruh Yigit wrote: > > If you choose to revert, we can ask Red Hat QA to test RC3 without > > further delay. Please let us know when you consider the options. > > > > If the patch is not good to go as it is I suggest reverting it, as far as I > know > Chenbo will

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-14 Thread David Marchand
On Thu, May 13, 2021 at 4:11 PM David Marchand wrote: > On Thu, May 13, 2021 at 2:38 PM Chenbo Xia wrote: > > > > This patch fixes an issue of application crash because of vhost iotlb > > not initialized when virtio has multiqueue enabled. > > > > iotlb messages will be sent when some queues are

Re: [dpdk-dev] [PATCH] devtools: add acronyms in dictionary for commit checks

2021-05-14 Thread David Marchand
On Fri, May 14, 2021 at 10:04 AM Ferruh Yigit wrote: > > GCC -> GNU Compiler Collection > ID -> Identification/Identity/Identifier > IP -> Internet Protocol > QinQ-> IEEE 802.1Q in 802.1Q > VEB -> Virtual Ethernet Bridge > Windows -> Windows -> Fenêtres ? :-) Can you add So

Re: [dpdk-dev] [dpdk-stable] [PATCH] crypto/qat: fix uninitilized compiler warning

2021-05-14 Thread David Marchand
On Fri, May 14, 2021 at 10:01 AM Feifei Wang wrote: > > > @@ -1190,8 +1190,8 @@ static int partial_hash_compute(enum > > icp_qat_hw_auth_algo hash_alg, > > > uint8_t *data_out) { > > > int digest_size; > > > - uint8_t digest[qat_hash_get_digest_size( > > > -

[dpdk-dev] [PATCH] devtools: add acronyms in dictionary for commit checks

2021-05-14 Thread Ferruh Yigit
GCC -> GNU Compiler Collection ID -> Identification/Identity/Identifier IP -> Internet Protocol QinQ-> IEEE 802.1Q in 802.1Q VEB -> Virtual Ethernet Bridge Windows -> Signed-off-by: Ferruh Yigit --- devtools/words-case.txt | 6 ++ 1 file changed, 6 insertions(+) diff -

[dpdk-dev] 回复: [dpdk-stable] [PATCH] crypto/qat: fix uninitilized compiler warning

2021-05-14 Thread Feifei Wang
Hi, David > -邮件原件- > 发件人: David Marchand > 发送时间: 2021年5月14日 15:50 > 收件人: Feifei Wang > 抄送: John Griffin ; Fiona Trahe > ; Deepak Kumar Jain ; > Herbert Guan ; Jerin Jacob > ; dev ; nd > ; dpdk stable ; Ruifeng Wang > > 主题: Re: [dpdk-stable] [PATCH] crypto/qat: fix uninitilized compiler

Re: [dpdk-dev] [dpdk-stable] [PATCH] crypto/qat: fix uninitilized compiler warning

2021-05-14 Thread David Marchand
On Fri, May 14, 2021 at 9:41 AM Feifei Wang wrote: > > In Arm platform, when "RTE_ARCH_ARM64_MEMCPY" is set as true, compiler > will report variable uninitilized warning: > > ../drivers/crypto/qat/qat_sym_session.c: In function ‘partial_hash_compute’: > ../lib/eal/include/generic/rte_byteorder.h:2

[dpdk-dev] [PATCH] crypto/qat: fix uninitilized compiler warning

2021-05-14 Thread Feifei Wang
In Arm platform, when "RTE_ARCH_ARM64_MEMCPY" is set as true, compiler will report variable uninitilized warning: ../drivers/crypto/qat/qat_sym_session.c: In function ‘partial_hash_compute’: ../lib/eal/include/generic/rte_byteorder.h:241:24: warning: ‘’ may be used uninitialized in this function