Re: [dpdk-dev] [PATCH v5 2/2] mempool: distinguish debug counters from cache and pool

2021-05-03 Thread Olivier Matz
On Tue, Apr 27, 2021 at 11:01:40AM -0500, Dharmik Thakkar wrote: > From: Joyce Kong > > If cache is enabled, objects will be retrieved/put from/to cache, > subsequently from/to the common pool. Now the debug stats calculate > the objects retrieved/put from/to cache and pool together, it is > bett

Re: [dpdk-dev] [PATCH] examples/rxtx_callbacks: fix port ID format specifier

2021-05-03 Thread Dmitry Kozlyuk
2021-05-03 17:11 (UTC-0700), Tyler Retzlaff: > On Sun, May 02, 2021 at 05:56:56AM +0300, Dmitry Kozlyuk wrote: > > Use "%u" and a cast as in other places when port ID is formatted. > > This fixes -Wformat warning with clang 10.0.0 on Windows. > > > > Fixes: f8244c6399d9 ("ethdev: increase port id

Re: [dpdk-dev] [PATCH 0/3] add lock-free stack support discovery

2021-05-03 Thread David Marchand
On Mon, Apr 12, 2021 at 10:29 AM Stanislaw Kardach wrote: > > The lock-free stack implementation (RTE_STACK_F_LF) is supported only on a > subset of platforms, namely x86_64 and arm64. Platforms supporting 128b > atomics > have to opt-in to a generic or C11 implementations. All other platforms us

Re: [dpdk-dev] [PATCH 0/3] add lock-free stack support discovery

2021-05-03 Thread David Marchand
On Mon, May 3, 2021 at 8:35 PM Stanisław Kardach wrote: > On Mon, 3 May 2021, 16:28 Olivier Matz, wrote: >> On Mon, May 03, 2021 at 04:21:25PM +0200, David Marchand wrote: >> > On Mon, Apr 12, 2021 at 10:29 AM Stanislaw Kardach >> > wrote: >> > > >> > > I have added cc to sta...@dpdk.org becaus

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add link speed check before port start

2021-05-03 Thread Huisong Li
在 2021/4/30 12:46, Li, Xiaoyun 写道: -Original Message- From: Huisong Li Sent: Friday, April 30, 2021 12:04 To: Li, Xiaoyun Cc: Yigit, Ferruh ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add link speed check before port start 在 2021/4/30 11:19, Li, Xiaoyun 写道:

Re: [dpdk-dev] [PATCH v2] test/timer: fix memzone reserve failure check

2021-05-03 Thread Carrillo, Erik G
> -Original Message- > From: Min Hu (Connor) > Sent: Monday, May 3, 2021 8:08 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Carrillo, Erik G > ; rsanf...@akamai.com > Subject: [PATCH v2] test/timer: fix memzone reserve failure check > > Segmentation fault may occur without checking if memzo

Re: [dpdk-dev] [PATCH] test/timer: fix memzone reserve failure check

2021-05-03 Thread Min Hu (Connor)
在 2021/5/2 4:00, Carrillo, Erik G 写道: -Original Message- From: Min Hu (Connor) Sent: Thursday, April 22, 2021 4:19 AM To: dev@dpdk.org Cc: Yigit, Ferruh ; rsanf...@akamai.com; Carrillo, Erik G Subject: [PATCH] test/timer: fix memzone reserve failure check Segmentation fault may occu

[dpdk-dev] [PATCH v2] test/timer: fix memzone reserve failure check

2021-05-03 Thread Min Hu (Connor)
Segmentation fault may occur without checking if memzone reserves succeed or not. This patch fixed it. Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- v2: * use TEST_ASSERT_NOT_NULL check "mz" instead of checking

[dpdk-dev] [PATCH v10 05/10] app/testpmd: resolve name collisions

2021-05-03 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c inde

[dpdk-dev] [PATCH v10 10/10] app/testpmd: enable building testpmd on Windows

2021-05-03 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build | 6 ++ app/test-

[dpdk-dev] [PATCH v10 09/10] app/testpmd: fix unused function warnings

2021-05-03 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 82 +-- 1

[dpdk-dev] [PATCH v10 07/10] app/testpmd: replace POSIX specific code

2021-05-03 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou ---

[dpdk-dev] [PATCH v10 08/10] app/testpmd: fix headers inclusion

2021-05-03 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files changed, 1 insertion(+), 6 d

[dpdk-dev] [PATCH v10 06/10] app/testpmd: fix parse_fec_mode return type name

2021-05-03 Thread Jie Zhou
Replace parse_fec_mode misleading return type name mode with fec_capa Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: sta...@dpdk.org Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 2 +-

[dpdk-dev] [PATCH v10 04/10] eal/Windows: add clock_gettime on Windows

2021-05-03 Thread Jie Zhou
Add clock_gettime on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 38 +++ 1 file changed, 38 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h

[dpdk-dev] [PATCH v10 00/10] app/testpmd: enable testpmd on Windows

2021-05-03 Thread Jie Zhou
This patchset is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that testpmd depends on - Add necessary macros required by testpmd on Windows in rte_os_shim.h - Add device event stubs for Windows - Resolve name collisions with Windows types - Add clock_gett

[dpdk-dev] [PATCH v10 03/10] eal/windows: add device event stubs

2021-05-03 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/eal/windows/eal_dev.c diff --git

[dpdk-dev] [PATCH v10 02/10] eal/windows: add necessary macros

2021-05-03 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h index

[dpdk-dev] [PATCH v10 01/10] lib: build libraries that testpmd depends on

2021-05-03 Thread Jie Zhou
Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index c9a20f65b..2d499b238 100644 --- a/lib/meson.build +++ b/lib/meson.

[dpdk-dev] [PATCH v5 35/35] event/cnxk: add devargs to control timer adapters

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add devargs to control each event timer adapter i.e. TIM rings internal parameters uniquely. The following dict format is expected [ring-chnk_slots-disable_npa-stats_ena]. 0 represents default values. Example: --dev "0002:1e:00.0,tim_ring_ctl=[2-1023-1-0]" Signed-o

[dpdk-dev] [PATCH v5 34/35] event/cnxk: add timer adapter start and stop

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add event timer adapter start and stop functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 71 - 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/drivers/event/cnxk/cn

[dpdk-dev] [PATCH v5 33/35] event/cnxk: add timer stats get and reset

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add event timer adapter statistics get and reset functions. Stats are disabled by default and can be enabled through devargs. Example: --dev "0002:1e:00.0,tim_stats_ena=1" Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- doc/guides/eventdevs/cnx

[dpdk-dev] [PATCH v5 32/35] event/cnxk: add timer cancel function

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add function to cancel event timer that has been armed. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 1 + drivers/event/cnxk/cnxk_tim_evdev.h | 5 drivers/event/cnxk/cnxk_tim_worker.c | 30 ++

[dpdk-dev] [PATCH v5 31/35] event/cnxk: add timer arm timeout burst

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer arm timeout burst function. All the timers requested to be armed have the same timeout. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 7 ++ drivers/event/cnxk/cnxk_tim_evdev.h | 12 +++ driver

[dpdk-dev] [PATCH v5 30/35] event/cnxk: add timer arm routine

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer arm routine. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 18 ++ drivers/event/cnxk/cnxk_tim_evdev.h | 23 ++ drivers/event/cnxk/cnxk_tim_worker.c | 95 + drivers/event/cnxk/cnxk_tim_

[dpdk-dev] [PATCH v5 29/35] event/cnxk: add TIM bucket operations

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add TIM bucket operations used for event timer arm and cancel. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.h | 30 +++ drivers/event/cnxk/cnxk_tim_worker.c | 6 ++ drivers/event/cnxk/cnxk_tim_worker.h | 123

[dpdk-dev] [PATCH v5 28/35] event/cnxk: add devargs for chunk size and rings

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add devargs to control default chunk size and max numbers of timer rings to attach to a given RVU PF. Example: --dev "0002:1e:00.0,tim_chnk_slots=1024" --dev "0002:1e:00.0,tim_rings_lmt=4" Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton ---

[dpdk-dev] [PATCH v5 27/35] event/cnxk: add timer adapter info function

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add TIM event timer adapter info get function. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_tim_evdev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/event/cnxk/cnxk_tim_evdev.c b/drivers/event/cn

[dpdk-dev] [PATCH v5 26/35] event/cnxk: allow adapters to resize inflights

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add internal SSO functions to allow event adapters to resize SSO buffers that are used to hold in-flight events in DRAM. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_eventdev.c | 33 drivers/event/cnxk/cnxk_

[dpdk-dev] [PATCH v5 25/35] event/cnxk: add devargs to disable NPA

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh If the chunks are allocated from NPA then TIM can automatically free them when traversing the list of chunks. Add devargs to disable NPA and use software mempool to manage chunks. Example: --dev "0002:0e:00.0,tim_disable_npa=1" Signed-off-by: Shijith Thotton Signe

[dpdk-dev] [PATCH v5 24/35] event/cnxk: create and free timer adapter

2021-05-03 Thread pbhagavatula
From: Shijith Thotton When the application calls timer adapter create the following is used: - Allocate a TIM LF based on number of LF's provisioned. - Verify the config parameters supplied. - Allocate memory required for * Buckets based on min and max timeout supplied. * Allocate

[dpdk-dev] [PATCH v5 23/35] event/cnxk: add timer adapter capabilities

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add function to retrieve event timer adapter capabilities. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 2 ++ drivers/event/cnxk/cn9k_eventdev.c | 2 ++ drivers/event/cnxk/cnxk_tim_evdev.c | 22 +++

[dpdk-dev] [PATCH v5 22/35] event/cnxk: support event timer

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add event timer adapter a.k.a TIM initialization on SSO probe. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- doc/guides/eventdevs/cnxk.rst | 6 drivers/event/cnxk/cnxk_eventdev.c | 3 ++ drivers/event/cnxk/cnxk_eventdev.h | 2 ++ drive

[dpdk-dev] [PATCH v5 21/35] event/cnxk: add event port and queue xstats

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add support for retrieving statistics from SSO HWS and HWGRP. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_sso.c| 63 + drivers/common/cnxk/roc_sso.h| 19 ++ drivers/common/cnxk/version.map | 2 + drivers/event/cnxk/c

[dpdk-dev] [PATCH v5 20/35] event/cnxk: add SSO selftest and dump

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add selftest to verify sanity of SSO and also add function to dump internal state of SSO. Signed-off-by: Pavan Nikhilesh --- app/test/test_eventdev.c| 14 + drivers/event/cnxk/cn10k_eventdev.c |8 + drivers/event/cnxk/cn9k_eventdev.c

[dpdk-dev] [PATCH v5 19/35] event/cnxk: add device stop and close functions

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add event device stop and close callback functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 15 + drivers/event/cnxk/cn9k_eventdev.c | 14 + drivers/event/cnxk/cnxk_eventdev.c | 48

[dpdk-dev] [PATCH v5 18/35] event/cnxk: add device start function

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add eventdev start function along with few cleanup API's to maintain sanity. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 127 drivers/event/cnxk/cn9k_eventdev.c | 113 ++

[dpdk-dev] [PATCH v5 17/35] event/cnxk: add SSO GWS dequeue fastpath functions

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO GWS event dequeue fastpath functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 10 ++- drivers/event/cnxk/cn10k_worker.c | 54 + drivers/event/cnxk/cn10k_worker.h | 12 +++ drivers/event/cnxk/cn9k_eventdev.c | 1

[dpdk-dev] [PATCH v5 16/35] event/cnxk: add SSO GWS fastpath enqueue functions

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO GWS fastpath event device enqueue functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 16 +++- drivers/event/cnxk/cn10k_worker.c | 54 ++ drivers/event/cnxk/cn10k_worker.h | 12 +++ drivers/event/cnxk/cn9k_eventde

[dpdk-dev] [PATCH v5 15/35] event/cnxk: add SSO HW device operations

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO HW device operations used for enqueue/dequeue. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_worker.c | 7 + drivers/event/cnxk/cn10k_worker.h | 151 + drivers/event/cnxk/cn9k_worker.c | 7 + drivers/event/cnxk/cn9k_worker.h

[dpdk-dev] [PATCH v5 14/35] event/cnxk: add devargs to configure getwork mode

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add devargs to configure the platform specific getwork mode. CN9K getwork mode by default is set to use dual workslot mode. Add option to force single workslot mode. Example: --dev "0002:0e:00.0,single_ws=1" CN10K supports multiple getwork prefetch modes, by defaul

[dpdk-dev] [PATCH v5 13/35] event/cnxk: add event port link and unlink

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add platform specific event port, queue link and unlink APIs. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 64 +- drivers/event/cnxk/cn9k_eventdev.c | 101 drivers/e

[dpdk-dev] [PATCH v5 12/35] event/cnxk: add port config functions

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add SSO HWS a.k.a event port setup and release functions. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 121 +++ drivers/event/cnxk/cn9k_eventdev.c | 147 drivers/

[dpdk-dev] [PATCH v5 11/35] event/cnxk: add devargs to control SSO HWGRP QoS

2021-05-03 Thread pbhagavatula
From: Shijith Thotton SSO HWGRPs i.e. queue uses DRAM & SRAM buffers to hold in-flight events. By default the buffers are assigned to the SSO HWGRPs to satisfy minimum HW requirements. SSO is free to assign the remaining buffers to HWGRPs based on a preconfigured threshold. We can control the QoS

[dpdk-dev] [PATCH v5 10/35] event/cnxk: add devargs for inflight buffer count

2021-05-03 Thread pbhagavatula
From: Shijith Thotton The number of events for a *open system* event device is specified as -1 as per the eventdev specification. Since, SSO inflight events are only limited by DRAM size, the xae_cnt devargs parameter is introduced to provide upper limit for in-flight events. Example: --

[dpdk-dev] [PATCH v5 09/35] event/cnxk: allocate event inflight buffers

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Allocate buffers in DRAM that hold inflight events. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 7 ++ drivers/event/cnxk/cn9k_eventdev.c | 7 ++ drivers/event/cnxk/cnxk_eventdev.c | 105 +++

[dpdk-dev] [PATCH v5 08/35] event/cnxk: add event queue config functions

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add setup and release functions for event queues i.e. SSO HWGRPs. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 2 ++ drivers/event/cnxk/cn9k_eventdev.c | 2 ++ drivers/event/cnxk/cnxk_eventdev.c | 19

[dpdk-dev] [PATCH v5 07/35] event/cnxk: add platform specific device config

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add platform specific event device configuration that attaches the requested number of SSO HWS(event ports) and HWGRP(event queues) LFs to the RVU PF/VF. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 35 ++

[dpdk-dev] [PATCH v5 06/35] event/cnxk: add common configuration validation

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add configuration validation, port and queue configuration functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_eventdev.c | 70 ++ drivers/event/cnxk/cnxk_eventdev.h | 6 +++ 2 files changed, 7

[dpdk-dev] [PATCH v5 05/35] event/cnxk: add platform specific device probe

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add platform specific event device probe and remove, also add event device info get function. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 101 +++ drivers/event/cnxk/cn9k_eventdev.c | 10

[dpdk-dev] [PATCH v5 04/35] event/cnxk: add device capabilities function

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add the info_get function to return details on the queues, flow, prioritization capabilities, etc. which this device has. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_eventdev.c | 24 drivers/event/cnx

[dpdk-dev] [PATCH v5 03/35] event/cnxk: add build infra and device setup

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add meson build infra structure along with the event device SSO initialization and teardown functions. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh Acked-by: Ray Kinsella --- MAINTAINERS| 6 +++ doc/guides/eventdevs/cnxk.rst

[dpdk-dev] [PATCH v5 02/35] common/cnxk: update inline asm prefix

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Update inline asm prefix to prevent overriding cpu type, instead express the additional extensions required. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_platform.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/common/c

[dpdk-dev] [PATCH v5 01/35] common/cnxk: rename deprecated constant

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh The PCI_ANY_ID constant is deprecated and renamed as RTE_PCI_ANY_ID. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_platform.h | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/common/cnxk/roc_platform.h b/

[dpdk-dev] [PATCH v5 00/35] Marvell CNXK Event device Driver

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh This patchset adds support for Marvell CN106XX SoC based on 'common/cnxk' driver. In future, CN9K a.k.a octeontx2 will also be supported by same driver when code is ready and 'event/octeontx2' will be deprecated. v5 Changes: - Update inline asm extension prefix. v4 Changes

Re: [dpdk-dev] [PATCH] examples/rxtx_callbacks: fix port ID format specifier

2021-05-03 Thread Tyler Retzlaff
On Sun, May 02, 2021 at 05:56:56AM +0300, Dmitry Kozlyuk wrote: > Use "%u" and a cast as in other places when port ID is formatted. > This fixes -Wformat warning with clang 10.0.0 on Windows. > > Fixes: f8244c6399d9 ("ethdev: increase port id range") > Cc: sta...@dpdk.org > > Signed-off-by: Dmitr

Re: [dpdk-dev] [PATCH 1/3] eal/windows: fix use of incorrect thread ID

2021-05-03 Thread Tyler Retzlaff
On Sun, May 02, 2021 at 05:33:31AM +0300, Dmitry Kozlyuk wrote: > Interrupt thread ID retained its value after interrupt thread finish. > Other interrupt routines could then operate on the wrong thread. > Clear interrupt thread ID before thread termination. > > Fixes: 5c016fc0205a ("eal/windows: a

Re: [dpdk-dev] [PATCH v9 06/10] app/testpmd: fix parse_fec_mode return type

2021-05-03 Thread Jie Zhou
On Mon, May 03, 2021 at 02:43:32PM -0700, Jie Zhou wrote: > On Mon, May 03, 2021 at 05:38:21PM +, Tal Shnaiderman wrote: > > > Subject: [PATCH v9 06/10] app/testpmd: fix parse_fec_mode return type > > > > > > > I think you should name this patch " app/testpmd: fix parse_fec_mode > > misleadi

Re: [dpdk-dev] [PATCH v9 06/10] app/testpmd: fix parse_fec_mode return type

2021-05-03 Thread Jie Zhou
On Mon, May 03, 2021 at 05:38:21PM +, Tal Shnaiderman wrote: > > Subject: [PATCH v9 06/10] app/testpmd: fix parse_fec_mode return type > > > > I think you should name this patch " app/testpmd: fix parse_fec_mode > misleading return type name" > > Do we need a fixes/CC stable tags here? Wil

Re: [dpdk-dev] [PATCH v9 07/10] app/testpmd: replace POSIX specific code

2021-05-03 Thread Jie Zhou
On Mon, May 03, 2021 at 05:37:52PM +, Tal Shnaiderman wrote: > > Subject: [PATCH v9 07/10] app/testpmd: replace POSIX specific code > > > > External email: Use caution opening links or attachments > > > > > > - Make printf format OS independent > > - Replace htons with RTE_BE16 > > - Repla

Re: [dpdk-dev] [PATCH v9 01/10] lib: build libraries that testpmd depends on

2021-05-03 Thread Jie Zhou
On Mon, May 03, 2021 at 05:36:30PM +, Tal Shnaiderman wrote: > > Subject: [PATCH v9 01/10] lib: build libraries that testpmd depends on > > > > External email: Use caution opening links or attachments > > > > > > Enable building libraries that testpmd depends on > > > > You should mention

Re: [dpdk-dev] [PATCH v4 09/12] raw/ioat: move idxd functions to separate file

2021-05-03 Thread Thomas Monjalon
30/04/2021 17:06, Bruce Richardson: > Split the rte_ioat_rawdev_fns.h file into two separate headers, so that the > data structures for the original ioat devices and the newer idxd ones can > be kept separate from each other. This makes code management and rework > easier. > > Signed-off-by: Bruce

Re: [dpdk-dev] [PATCH v4 08/12] raw/ioat: add bus driver for device scanning automatically

2021-05-03 Thread Thomas Monjalon
30/04/2021 17:06, Bruce Richardson: > Rather than using a vdev with args, DPDK can scan and initialize the > devices automatically using a bus-type driver. This bus does not need to > worry about registering device drivers, rather it can initialize the > devices directly on probe. > > The device i

Re: [dpdk-dev] [PATCH v4 04/12] raw/ioat: add explicit padding to descriptor struct

2021-05-03 Thread Thomas Monjalon
30/04/2021 17:06, Bruce Richardson: > Add an explicit padding field to the end of the descriptor structure so > that when the batch descriptor is defined on the stack for perform-ops, the > unused space is all zeroed appropriately. > > Signed-off-by: Bruce Richardson > --- > --- a/drivers/raw/ioa

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-05-03 Thread Thomas Monjalon
21/04/2021 11:11, Conor Walsh: > + The following will include a snippet from the skeleton sample app:: > + > + .. literalinclude:: ../../../examples/skeleton/basicfwd.c > +:language: c > +:start-after: Display the port MAC address. > +:end-before: Enable RX in promiscu

Re: [dpdk-dev] [PATCH 0/3] add lock-free stack support discovery

2021-05-03 Thread Stanisław Kardach
On Mon, 3 May 2021, 16:28 Olivier Matz, wrote: > On Mon, May 03, 2021 at 04:21:25PM +0200, David Marchand wrote: > > On Mon, Apr 12, 2021 at 10:29 AM Stanislaw Kardach > wrote: > > > > > > The lock-free stack implementation (RTE_STACK_F_LF) is supported only > on a > > > subset of platforms, nam

Re: [dpdk-dev] [PATCH v9 08/10] app/testpmd: fix headers inclusion

2021-05-03 Thread Tal Shnaiderman
> Subject: [PATCH v9 08/10] app/testpmd: fix headers inclusion > > External email: Use caution opening links or attachments > > > - Include rte_os_shim.h in testpmd.h > - Remove redundant headers > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > --- > app/test-pmd/cmdline.c | 3 --

Re: [dpdk-dev] [PATCH v9 03/10] eal/windows: add device event stubs

2021-05-03 Thread Tal Shnaiderman
> Subject: [PATCH v9 03/10] eal/windows: add device event stubs > > External email: Use caution opening links or attachments > > > Add device event stubs in eal_dev.c for Windows > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > --- > lib/eal/windows/eal_dev.c | 33 ++

Re: [dpdk-dev] [PATCH v9 09/10] app/testpmd: fix unused function warnings

2021-05-03 Thread Tal Shnaiderman
> Subject: [PATCH v9 09/10] app/testpmd: fix unused function warnings > > External email: Use caution opening links or attachments > > > Function print_fdir_mask and print_fdir_flex_payload is only called when > either i40e or ixgbe presents. Add #if defined to remove "unused function" > compila

Re: [dpdk-dev] [PATCH v9 10/10] app/testpmd: enable building testpmd on Windows

2021-05-03 Thread Tal Shnaiderman
> Subject: [PATCH v9 10/10] app/testpmd: enable building testpmd on > Windows > > External email: Use caution opening links or attachments > > > From: Jie Zhou > > - Disable unsupported Apps on Windows > - Enable building of testpmd on Windows > > Signed-off-by: Jie Zhou > Signed-off-by: Jie

Re: [dpdk-dev] [PATCH v9 06/10] app/testpmd: fix parse_fec_mode return type

2021-05-03 Thread Tal Shnaiderman
> Subject: [PATCH v9 06/10] app/testpmd: fix parse_fec_mode return type > I think you should name this patch " app/testpmd: fix parse_fec_mode misleading return type name" Do we need a fixes/CC stable tags here? > External email: Use caution opening links or attachments > > > Fix parse_fec_m

Re: [dpdk-dev] [PATCH v9 07/10] app/testpmd: replace POSIX specific code

2021-05-03 Thread Tal Shnaiderman
> Subject: [PATCH v9 07/10] app/testpmd: replace POSIX specific code > > External email: Use caution opening links or attachments > > > - Make printf format OS independent > - Replace htons with RTE_BE16 > - Replace POSIX specific inet_aton with OS independent inet_pton > - Replace sleep with

Re: [dpdk-dev] [PATCH v9 05/10] app/testpmd: resolve name collisions

2021-05-03 Thread Tal Shnaiderman
> Subject: [PATCH v9 05/10] app/testpmd: resolve name collisions > > External email: Use caution opening links or attachments > > > Resolve name collisions with Windows types > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > --- > app/test-pmd/cmdline_flow.c | 512 ++---

Re: [dpdk-dev] [PATCH v9 04/10] eal/Windows: add clock_gettime on Windows

2021-05-03 Thread Tal Shnaiderman
> Subject: [PATCH v9 04/10] eal/Windows: add clock_gettime on Windows > > External email: Use caution opening links or attachments > > > Add clock_gettime on Windows in rte_os_shim.h > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > --- > app/test-pmd/config.c | 1 + U

Re: [dpdk-dev] [PATCH v9 02/10] eal/windows: add necessary macros

2021-05-03 Thread Tal Shnaiderman
> Subject: [PATCH v9 02/10] eal/windows: add necessary macros > > External email: Use caution opening links or attachments > > > Add required macros by testpmd on Windows in rte_os_shim.h > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > --- > lib/eal/windows/include/rte_os_shim.h | 9

Re: [dpdk-dev] [PATCH v9 01/10] lib: build libraries that testpmd depends on

2021-05-03 Thread Tal Shnaiderman
> Subject: [PATCH v9 01/10] lib: build libraries that testpmd depends on > > External email: Use caution opening links or attachments > > > Enable building libraries that testpmd depends on > You should mention the change is for Windows only. > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zh

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v6 02/10] eal: add thread attributes

2021-05-03 Thread Tyler Retzlaff
-Original Message- From: Thomas Monjalon Sent: Thursday, April 29, 2021 12:48 AM 29/04/2021 02:50, Dmitry Kozlyuk: > > 2021-04-02 18:39 (UTC-0700), Narcisa Ana Maria Vasile: > > > +int > > > +rte_thread_attr_init(rte_thread_attr_t *attr) { > > > + if (attr == NULL) { > > > +

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v6 06/10] eal: add thread lifetime management

2021-05-03 Thread Dmitry Malloy
Thread cancellation is a pain point. Emulating it properly is nearly impossible (without hooking into various OS calls which are supposed to be "cancellation points"). I do like the cancellation token idea, but I'm not sure how existing clients, who rely on existing phtread_cancel() semantic, wi

[dpdk-dev] [PATCH v4 3/3] vhost: fix offload flags in Rx path

2021-05-03 Thread David Marchand
The vhost library currently configures Tx offloading (PKT_TX_*) on any packet received from a guest virtio device which asks for some offloading. This is problematic, as Tx offloading is something that the application must ask for: the application needs to configure devices to support every used o

[dpdk-dev] [PATCH v4 2/3] net/virtio: refactor Tx offload helper

2021-05-03 Thread David Marchand
Purely cosmetic but it is rather odd to have an "offload" helper that checks if it actually must do something. We already have the same checks in most callers, so move this branch in them. Signed-off-by: David Marchand Reviewed-by: Flavio Leitner Reviewed-by: Ruifeng Wang Reviewed-by: Maxime Co

[dpdk-dev] [PATCH v4 1/3] net/virtio: do not touch Tx offload flags

2021-05-03 Thread David Marchand
Tx offload flags are of the application responsibility. Leave the mbuf alone and use a local storage for implicit tcp checksum offloading in case of TSO. Signed-off-by: David Marchand Reviewed-by: Maxime Coquelin Acked-by: Flavio Leitner --- drivers/net/virtio/virtqueue.h | 6 -- 1 file ch

[dpdk-dev] [PATCH v4 0/3] Offload flags fixes

2021-05-03 Thread David Marchand
The important part is the last patch on vhost handling of offloading requests coming from a virtio guest interface. The rest are small fixes that I accumulated while reviewing the mbuf offload flags. On this last patch, it has the potential of breaking existing applications using the vhost librar

[dpdk-dev] [PATCH] telemetry: remove internal symbol from public header

2021-05-03 Thread jerinj
From: Jerin Jacob Remove TELEMETRY_MAX_CALLBACKS symbol from public rte_telemetry.h header file. Signed-off-by: Jerin Jacob --- lib/telemetry/rte_telemetry.h | 2 -- lib/telemetry/telemetry.c | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/telemetry/rte_telemetr

Re: [dpdk-dev] New PMD integration to next version release

2021-05-03 Thread Stephen Hemminger
On Mon, 3 May 2021 16:00:42 +0530 Supriya Shekhar Mane wrote: > Hi Maintainers, > > We want to open source the *Dakota Ethernet PMD*. > We are ready with changes to be open source. > We want to integrate our changes onto the next release: *19.11.9* > Kindly, guide us with the process and initiat

Re: [dpdk-dev] [PATCH v3 0/4] Offload flags fixes

2021-05-03 Thread David Marchand
On Mon, May 3, 2021 at 5:24 PM Maxime Coquelin wrote: > On 5/3/21 3:26 PM, David Marchand wrote: > > The important part is the last patch on vhost handling of offloading > > requests coming from a virtio guest interface. > > > > The rest are small fixes that I accumulated while reviewing the mbuf

Re: [dpdk-dev] [EXT] [PATCH] regex/octeontx2: remove unused include directory

2021-05-03 Thread Guy Kaneti
> -Original Message- > From: Thomas Monjalon > Sent: Monday, May 3, 2021 5:46 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Guy Kaneti > Subject: [EXT] [PATCH] regex/octeontx2: remove unused include directory > > External Email > > -

[dpdk-dev] [PATCH v4 34/34] event/cnxk: add devargs to control timer adapters

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add devargs to control each event timer adapter i.e. TIM rings internal parameters uniquely. The following dict format is expected [ring-chnk_slots-disable_npa-stats_ena]. 0 represents default values. Example: --dev "0002:1e:00.0,tim_ring_ctl=[2-1023-1-0]" Signed-o

[dpdk-dev] [PATCH v4 32/34] event/cnxk: add timer stats get and reset

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add event timer adapter statistics get and reset functions. Stats are disabled by default and can be enabled through devargs. Example: --dev "0002:1e:00.0,tim_stats_ena=1" Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- doc/guides/eventdevs/cnx

[dpdk-dev] [PATCH v4 33/34] event/cnxk: add timer adapter start and stop

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add event timer adapter start and stop functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 71 - 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/drivers/event/cnxk/cn

[dpdk-dev] [PATCH v4 31/34] event/cnxk: add timer cancel function

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add function to cancel event timer that has been armed. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 1 + drivers/event/cnxk/cnxk_tim_evdev.h | 5 drivers/event/cnxk/cnxk_tim_worker.c | 30 ++

[dpdk-dev] [PATCH v4 30/34] event/cnxk: add timer arm timeout burst

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer arm timeout burst function. All the timers requested to be armed have the same timeout. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 7 ++ drivers/event/cnxk/cnxk_tim_evdev.h | 12 +++ driver

Re: [dpdk-dev] [PATCH v3 0/4] Offload flags fixes

2021-05-03 Thread Maxime Coquelin
Hi David, On 5/3/21 3:26 PM, David Marchand wrote: > The important part is the last patch on vhost handling of offloading > requests coming from a virtio guest interface. > > The rest are small fixes that I accumulated while reviewing the mbuf > offload flags. > > On this last patch, it has the

[dpdk-dev] [PATCH v4 29/34] event/cnxk: add timer arm routine

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer arm routine. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 18 ++ drivers/event/cnxk/cnxk_tim_evdev.h | 23 ++ drivers/event/cnxk/cnxk_tim_worker.c | 95 + drivers/event/cnxk/cnxk_tim_

[dpdk-dev] [PATCH v4 28/34] event/cnxk: add TIM bucket operations

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add TIM bucket operations used for event timer arm and cancel. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.h | 30 +++ drivers/event/cnxk/cnxk_tim_worker.c | 6 ++ drivers/event/cnxk/cnxk_tim_worker.h | 123

[dpdk-dev] [PATCH v4 27/34] event/cnxk: add devargs for chunk size and rings

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add devargs to control default chunk size and max numbers of timer rings to attach to a given RVU PF. Example: --dev "0002:1e:00.0,tim_chnk_slots=1024" --dev "0002:1e:00.0,tim_rings_lmt=4" Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton ---

[dpdk-dev] [PATCH v4 26/34] event/cnxk: add timer adapter info function

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add TIM event timer adapter info get function. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_tim_evdev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/event/cnxk/cnxk_tim_evdev.c b/drivers/event/cn

[dpdk-dev] [PATCH v4 25/34] event/cnxk: allow adapters to resize inflights

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh Add internal SSO functions to allow event adapters to resize SSO buffers that are used to hold in-flight events in DRAM. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_eventdev.c | 33 drivers/event/cnxk/cnxk_

[dpdk-dev] [PATCH v4 24/34] event/cnxk: add devargs to disable NPA

2021-05-03 Thread pbhagavatula
From: Pavan Nikhilesh If the chunks are allocated from NPA then TIM can automatically free them when traversing the list of chunks. Add devargs to disable NPA and use software mempool to manage chunks. Example: --dev "0002:0e:00.0,tim_disable_npa=1" Signed-off-by: Shijith Thotton Signe

[dpdk-dev] [PATCH v4 23/34] event/cnxk: create and free timer adapter

2021-05-03 Thread pbhagavatula
From: Shijith Thotton When the application calls timer adapter create the following is used: - Allocate a TIM LF based on number of LF's provisioned. - Verify the config parameters supplied. - Allocate memory required for * Buckets based on min and max timeout supplied. * Allocate

[dpdk-dev] [PATCH v4 22/34] event/cnxk: add timer adapter capabilities

2021-05-03 Thread pbhagavatula
From: Shijith Thotton Add function to retrieve event timer adapter capabilities. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 2 ++ drivers/event/cnxk/cn9k_eventdev.c | 2 ++ drivers/event/cnxk/cnxk_tim_evdev.c | 22 +++

  1   2   >