Re: [dpdk-dev] [PATCH] raw/octeontx2_dma: fix unavailable PCI device in dpivf

2021-04-08 Thread Jerin Jacob
On Mon, Mar 22, 2021 at 8:52 PM Radha Mohan Chintakuntla wrote: > > Add PCI device to dpivf structure. > > Fixes: 4495bd887d38 ("raw/octeontx2_dma: support multiple DPI blocks") Since it is a fix, Please describe what is fixed in git commit log. > Signed-off-by: Radha Mohan Chintakuntla > ---

Re: [dpdk-dev] [PATCH v4 00/11] Add Marvell CNXK mempool driver

2021-04-08 Thread Jerin Jacob
On Thu, Apr 8, 2021 at 3:21 PM Ashwin Sekhar T K wrote: > > This patchset adds the mempool/cnxk driver which provides the support for the > integrated mempool device found in Marvell CN10K SoC. > > The code includes mempool driver functionality for Marvell CN9K SoC as well, > but right now it is n

[dpdk-dev] [PATCH v18 3/3] config: fix Arm implementer and its SoCs

2021-04-08 Thread Juraj Linkeš
Fix the implementer and part number of DPAA and ARMADA SoCs. The current values of 16 cores and 1 NUMA node don't cover all SoCs from the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA nodes. Increase these to 64 and 4 to widen the coverage. Add configuration to SoC options where smalle

[dpdk-dev] [PATCH v18 2/3] build: add 'platform' meson option and Arm SoC config

2021-04-08 Thread Juraj Linkeš
Add Arm SoC configuration sets to Arm meson.build and add an arch agnostic meson option, 'platform', to select from these SoC configurations for meson native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as w

[dpdk-dev] [PATCH v18 1/3] build: disable/enable drivers in Arm builds

2021-04-08 Thread Juraj Linkeš
Add support for enabling or disabling drivers for Arm cross build. Do not implement any enable/disable lists yet. Enabling drivers is useful when building for an SoC where we only want to build a few drivers. That way the list won't be too long. Similarly, disabling drivers is useful when we want

[dpdk-dev] [PATCH v18 0/3] Arm build options rework

2021-04-08 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. We also want to be able to enable/disable which drivers are built withou

Re: [dpdk-dev] [Linuxarm] Re: [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx

2021-04-08 Thread oulijun
在 2021/4/2 10:33, Li, Xiaoyun 写道: -Original Message- From: oulijun Sent: Friday, April 2, 2021 09:45 To: Li, Xiaoyun ; Yigit, Ferruh Cc: dev@dpdk.org; linux...@openeuler.org Subject: Re: [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx 在 2021/3/29 9:53,

[dpdk-dev] [PATCH v4 4/4] net/iavf: add offload path for Rx AVX512 flex desc

2021-04-08 Thread Wenzhuo Lu
Add a specific path for RX AVX512 (flexible descriptor). In this path, support the HW offload features, like, checksum, VLAN stripping, RSS hash. This path is chosen automatically according to the configuration. 'inline' is used, then the duplicate code is generated by the compiler. Signed-off-by

[dpdk-dev] [PATCH v4 3/4] net/iavf: add offload path for Rx AVX512

2021-04-08 Thread Wenzhuo Lu
Add a specific path for RX AVX512 (traditional). In this path, support the HW offload features, like, checksum, VLAN stripping, RSS hash. This path is chosen automatically according to the configuration. 'inline' is used, then the duplicate code is generated by the compiler. Signed-off-by: Wenzhu

[dpdk-dev] [PATCH v4 2/4] net/iavf: add offload path for Tx AVX512

2021-04-08 Thread Wenzhuo Lu
Add a specific path for TX AVX512. In this path, support the HW offload features, like, checksum insertion, VLAN insertion. This path is chosen automatically according to the configuration. 'inline' is used, then the duplicate code is generated by the compiler. Signed-off-by: Wenzhuo Lu --- dri

[dpdk-dev] [PATCH v4 1/4] net/iavf: store offload flag of Rx queue

2021-04-08 Thread Wenzhuo Lu
Add the offload flag for RX queues to know which offload features are set. Signed-off-by: Wenzhuo Lu --- drivers/net/iavf/iavf_rxtx.c | 4 drivers/net/iavf/iavf_rxtx.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 541

[dpdk-dev] [PATCH v4 0/4] add Rx/Tx offload paths for IAVF AVX512

2021-04-08 Thread Wenzhuo Lu
Add specific paths for RX/TX AVX512, called offload paths. In these paths, support the HW offload features, like, checksum, VLAN, RSS offload. These paths are chosen automatically according to the configuration. v2: - Fixed compile error. v3: - Used 'inline' to drop the duplicate code. - some

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd

2021-04-08 Thread Yu, DapengX
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, April 8, 2021 11:42 PM > To: Yu, DapengX ; Li, Xiaoyun > ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload > reconfig cmd > > On 4/1/2021 9:28 AM,

[dpdk-dev] [PATCH 1/2] net/hns3: refactor VF support LSC event report

2021-04-08 Thread Min Hu (Connor)
From: Chengwen Feng Currently, VF driver periodic obtains link status from PF kernel driver, and report lsc event when detect link status change. Because the period is 1 second, it's probably too late to report especially in sush as bonding scenario. To solve this problem we use the following sc

[dpdk-dev] [PATCH 2/2] net/hns3: refactor PF support LSC event report

2021-04-08 Thread Min Hu (Connor)
From: Chengwen Feng Currently, PF driver will report lsc when it detect the link status change, it's not a generic implementation. We refactor PF lsc event report by following scheme: 1. PF driver marks RTE_PCI_DRV_INTR_LSC in rte_pci_driver default. 2. In the init stage, PF driver will detect f

[dpdk-dev] [PATCH 0/2] refactor support LSC event report

2021-04-08 Thread Min Hu (Connor)
This set of patches refactor support LSC event report. Chengwen Feng (2): net/hns3: refactor VF support LSC event report net/hns3: refactor PF support LSC event report doc/guides/nics/features/hns3.ini| 1 + doc/guides/nics/features/hns3_vf.ini | 1 + drivers/net/hns3/hns3_ethdev.c

[dpdk-dev] [PATCH] ethdev: introduce indirect action APIs

2021-04-08 Thread Bing Zhao
Right now, rte_flow_shared_action_* APIs are used for some shared actions, like RSS, count. The shared action shoule be created before using it inside a flow. These shared actions sometimes are not really shared but just some indirect actions decoupled from a flow. The new functions rte_flow_actio

Re: [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture

2021-04-08 Thread Amber, Kumar
Hi Thomas , Pls reject it -Original Message- From: Thomas Monjalon Sent: Friday, April 9, 2021 4:12 AM To: Amber, Kumar Cc: Wang, Yipeng1 ; dev@dpdk.org; Richardson, Bruce ; Gobriel, Sameh Subject: Re: [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture 25/03/2021 09

[dpdk-dev] [PATCH v4 3/3] net/i40e: fix segment fault in AVX512

2021-04-08 Thread Wenzhuo Lu
Fix segment fault when failing to get the memory from the pool. Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path") Cc: sta...@dpdk.org Reported-by: David Coyle Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_rxtx_vec_avx2.c | 117 +-- drivers/net/i40e/i40e_rxtx_vec_

[dpdk-dev] [PATCH v4 2/3] net/ice: fix segment fault in AVX512

2021-04-08 Thread Wenzhuo Lu
Fix segment fault when failing to get the memory from the pool. Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path") Cc: sta...@dpdk.org Reported-by: David Coyle Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx_vec_avx2.c | 120 +--- drivers/net/ice/ice_rxtx_vec_avx5

[dpdk-dev] [PATCH v4 1/3] net/iavf: fix segment fault in AVX512

2021-04-08 Thread Wenzhuo Lu
Fix segment fault when failing to get the memory from the pool. Fixes: 31737f2b66fb ("net/iavf: enable AVX512 for legacy Rx") Cc: sta...@dpdk.org Reported-by: David Coyle Signed-off-by: Wenzhuo Lu --- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 120 +-- drivers/net/iavf/iavf_rxtx

[dpdk-dev] [PATCH v4 0/3] fix segment fault in avx512 code

2021-04-08 Thread Wenzhuo Lu
Fix no memory segment fault of iavf, ice, i40e. v2: - Drop the duplicate code. v3: - Fix compile error on no-x86 platform. v4: - minor performance optimization. Wenzhuo Lu (3): net/iavf: fix segment fault in AVX512 net/ice: fix segment fault in AVX512 net/i40e: fix segment fault in AVX

Re: [dpdk-dev] [PATCH 4/5] net/virtio: refactor Tx offload helper

2021-04-08 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Thursday, April 1, 2021 5:53 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; olivier.m...@6wind.com; > f...@sysclose.org; i.maxim...@ovn.org; Chenbo Xia ; > Bruce Richardson ; Konstantin Ananyev > ; jer...@marvell.com; Ruifeng Wan

Re: [dpdk-dev] [PATCH v2] net/e1000: fix max Rx packet size

2021-04-08 Thread Wang, Haiyue
> -Original Message- > From: Zhang, AlvinX > Sent: Thursday, April 8, 2021 15:41 > To: Wang, Haiyue ; Guo, Jia > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH v2] net/e1000: fix max Rx packet size > > According to E1000_ETH_OVERHEAD definition, max_rx_pkt_len contai

Re: [dpdk-dev] [PATCH v8] app/testpmd: support multi-process

2021-04-08 Thread Min Hu (Connor)
在 2021/4/8 21:27, Ferruh Yigit 写道: On 4/8/2021 11:32 AM, Min Hu (Connor) wrote: Hi, Ferry and all,  This patch has been acked:  Acked-by: Xiaoyun Li  Acked-by: Ajit Khaparde  Are there any other comments about that patch? Hi Connor, In today's release status meeting I a

Re: [dpdk-dev] [PATCH v3 4/5] bus: add device arguments name parsing API

2021-04-08 Thread Thomas Monjalon
01/04/2021 17:13, Xueming(Steven) Li: >From: Thomas Monjalon > >30/03/2021 14:15, Xueming Li: > >> To use Global Device Syntax as devargs, name is required for device > >> management. > > > >Context is missing. > >You mean the argument "name" for the vdev bus? > > Devargs.name, it is used by prob

[dpdk-dev] [PATCH] net/enic: fix flow initialization error handling

2021-04-08 Thread John Daley
Fix a rare case in rte_flow initialization where the action hash table is not freed if allocating a NIC match table fails. Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager API") Cc: sta...@dpdk.org Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/

Re: [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture

2021-04-08 Thread Stephen Hemminger
On Fri, 09 Apr 2021 00:41:34 +0200 Thomas Monjalon wrote: > 25/03/2021 09:06, Thomas Monjalon: > > 24/03/2021 23:59, Wang, Yipeng1: > > > From: kumar amber > > > > > > > > add _SSE42_ flag to enable compilation of > > > > sse42 specific instructions only on supported architecture > > > > >

Re: [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture

2021-04-08 Thread Thomas Monjalon
25/03/2021 09:06, Thomas Monjalon: > 24/03/2021 23:59, Wang, Yipeng1: > > From: kumar amber > > > > > > add _SSE42_ flag to enable compilation of > > > sse42 specific instructions only on supported architecture > > > > > > Signed-off-by: kumar amber [...] > > [Wang, Yipeng] > > Hi, Kumar, thank

Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap

2021-04-08 Thread Thomas Monjalon
Thank you, the fix looks good. I would like to improve the explanation. If I understand the issue, the title should be "build: remove redundant libpcap link" 26/03/2021 09:22, Gabriel Ganne: > libpcap is already found and registered as a dependency by meson, and > the dependency is already correc

[dpdk-dev] [PATCH v2] examples/l3fwd: skip TX queue drain on first iteration

2021-04-08 Thread Kathleen Capella
Initialize prev_tsc to cur_tsc. This avoids running the TX queue drain in the first iteration of the packet processing loop. Signed-off-by: Kathleen Capella Reviewed-by: Honnappa Nagarahalli --- examples/l3fwd/l3fwd_em.c | 9 + examples/l3fwd/l3fwd_lpm.c | 9 + 2 files changed,

Re: [dpdk-dev] [PATCH 0/2] Fix unit tests execution for ENA PMD

2021-04-08 Thread Thomas Monjalon
26/03/2021 11:47, Michal Krawczyk: > ENA PMD uses timer service to implement various periodic device status > check routine. Because of that, it already initializes the timer > subsystem. As unit tests also initalizes the timer subsystem, return > value is equal to -EAGAIN, as it was already done b

Re: [dpdk-dev] [PATCH v5 0/3] regex/mlx5: support scattered mbuf

2021-04-08 Thread Thomas Monjalon
> Suanming Mou (3): > common/mlx5: add user memory registration bits > regex/mlx5: add data path scattered mbuf process > app/test-regex: support scattered mbuf input Applied, thanks

[dpdk-dev] [PATCH 24/24] crypto/mlx5: adjust to the multiple data unit API

2021-04-08 Thread Shiri Kuzin
In AES-XTS the data to be encrypted\decrypted does not have to be in multiples of 16B size, the unit of data is called data-unit. As a result of patch [1] a new field is added to the cipher capability, called dataunit_set, where the devices can report the range of supported data-unit sizes. The n

[dpdk-dev] [PATCH 21/24] crypto/mlx5: add dev stop and start operations

2021-04-08 Thread Shiri Kuzin
Add the dev_start function that is used to start a configured device. Add the dev_stop function that is used to stop a configured device. Both functions set the dev parameter as used and return 0. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 17 +

[dpdk-dev] [PATCH 23/24] crypto/mlx5: create login object using DevX

2021-04-08 Thread Shiri Kuzin
To work with crypto engines that are marked with wrapped_import_method, a login session is required. A crypto login object needs to be created using DevX. The crypto login object contains: - The credential pointer. - The import_KEK pointer to be used for all secured information

[dpdk-dev] [PATCH 22/24] crypto/mlx5: add memory region management

2021-04-08 Thread Shiri Kuzin
Mellanox user space drivers don't deal with physical addresses as part of a memory protection mechanism. The device translates the given virtual address to a physical address using the given memory key as an address space identifier. That's why any mbuf virtual address is moved directly to the HW d

[dpdk-dev] [PATCH 20/24] crypto/mlx5: support queue pairs operations

2021-04-08 Thread Shiri Kuzin
The HW queue pairs are a pair of send queue and receive queue of independent work queues packed together in one object for the purpose of transferring data between nodes of a network. Completion Queue is a FIFO queue of completed work requests. In crypto driver we use one QP in loopback in order

[dpdk-dev] [PATCH 18/24] crypto/mlx5: support session operations

2021-04-08 Thread Shiri Kuzin
Sessions are used in symmetric transformations in order to prepare objects and data for packet processing stage. A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct, bsf_size, bsf_p_type, encryption_order and encryption standard. Implement the next session operations: mlx

[dpdk-dev] [PATCH 19/24] crypto/mlx5: add basic operations

2021-04-08 Thread Shiri Kuzin
The basic dev control operations are configure, close and get info. Extended the existing support of configure and close: -mlx5_crypto_dev_configure- function used to configure device. -mlx5_crypto_dev_close- function used to close a configured device. Added support of g

[dpdk-dev] [PATCH 14/24] common/mlx5: add crypto register structs and defs

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled Encryption key management requires use of several related registers. This patch adds the relevant structs and values, according to PRM definitions. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 41 ++ 1

[dpdk-dev] [PATCH 15/24] common/mlx5: support register write access

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled This patch adds support of write operation to NIC registers. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 67 +++- drivers/common/mlx5/mlx5_devx_cmds.h | 4 ++ drivers/common/mlx5/version.map | 20 +

[dpdk-dev] [PATCH 17/24] crypto/mlx5: add DEK object management

2021-04-08 Thread Shiri Kuzin
A DEK(Data encryption Key) is an mlx5 HW object which represents the cipher algorithm key. The DEKs are used during data encryption/decryption operations. In symmetric algorithms like AES-STS, we use the same DEK for both encryption and decryption. Use the mlx5 hash-list tool to manage the DEK ob

[dpdk-dev] [PATCH 16/24] drivers: introduce mlx5 crypto PMD

2021-04-08 Thread Shiri Kuzin
Add a new PMD for Nvidia devices- crypto PMD. The crypto PMD will be supported starting Nvidia ConnectX6 and BlueField2. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. This patch adds

[dpdk-dev] [PATCH 11/24] common/mlx5: share hash list tool

2021-04-08 Thread Shiri Kuzin
In order to use the hash list defined in net in other drivers, the hash list is moved to common utilities. In addition, the log definition was moved from the common utilities to a dedicated new log file in common in order to prevent a conflict. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad -

[dpdk-dev] [PATCH 12/24] common/mlx5: share get ib device match function

2021-04-08 Thread Shiri Kuzin
The get_ib_device_match function iterates over the list of ib devices returned by the get_device_list glue function and returns the ib device matching the provided address. Since this function is in use by several drivers, in this patch we share the function in common part. Signed-off-by: Shiri K

[dpdk-dev] [PATCH 13/24] common/mlx5: support general obj CREDENTIAL create

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled CREDENTIAL object is used for any crypto operation in wrapped mode. This patch add support of CREDENTIAL object create operation. Add reading of CREDENTIAL support capability. Add function to create general object type CREDENTIAL, using DevX API. Signed-off-by: Dekel Peled Ac

[dpdk-dev] [PATCH 10/24] common/mlx5: add crypto BSF struct and defines

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled This patch adds the struct defining crypto BSF segment of UMR WQE, and the related value definitions and offsets. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 66 ++ 1 file changed, 66 insertions(+) di

[dpdk-dev] [PATCH 09/24] common/mlx5: support general obj CRYPTO LOGIN create

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled CRYPTO_LOGIN Object is used to login to the device as crypto user or crypto officer. Required in order to perform any crypto related control operations. This patch adds support of CRYPTO_LOGIN object create operation. Add reading of CRYPTO_LOGIN support capability. Add function

[dpdk-dev] [PATCH 08/24] common/mlx5: support general obj IMPORT KEK create

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled IMPORT_KEK object is used to wrap (encrypt) critical security parameters, such as other keys and credentials, when those need to be passed between the device and the software. This patch add support of IMPORT_KEK object create operation. Add reading of IMPORT_KEK support capabi

[dpdk-dev] [PATCH 07/24] common/mlx5: support umr en field in MKEY context

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled MKEY that will be used in UMR operations must be created with umr_en attribute. This patch adds support for setting umr_en attribute in MKEY context. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 + drivers/common/mlx5/mlx5_dev

[dpdk-dev] [PATCH 04/24] common/mlx5: add HCA cap for AES-XTS crypto

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled Update the PRM structure and HCA capabilities reading, to include relevant capabilities for AES-XTS crypto. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ drivers/common/mlx5/mlx

[dpdk-dev] [PATCH 06/24] common/mlx5: add crypto en field to MKEY context

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled MKEY that will be used for crypto purposes must be created with crypto_en attribute. This patch adds support for crypto_en attribute in MKEY context. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 + drivers/common/mlx5/mlx5_de

[dpdk-dev] [PATCH 05/24] common/mlx5: support general object DEK create op

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled Data Encryption Keys (DEKs) are the keys used for data encryption/decryption operations. Add reading of DEK support capability. Add function to create general object type DEK, using DevX API. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx

[dpdk-dev] [PATCH 03/24] common/mlx5: optimize read of general obj type caps

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled General object types support is indicated in bitmap general_obj_types, which is part of HCA capabilities list. Currently this bitmap is read multiple times, and each time a different bit is extracted. This patch optimizes the code, reading the bitmap once into a local variable,

[dpdk-dev] [PATCH 01/24] common/mlx5: remove redundant spaces in header file

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled File drivers/common/mlx5/mlx5_prm.h includes structs representing data items as defined in PRM document. Some of these structs were copied as-is from kernel file mlx5_ifc.h. As result the structs are not all aligned with the same spacing. This patch removes redundant spaces and

[dpdk-dev] [PATCH 00/24] drivers: introduce mlx5 crypto PMD

2021-04-08 Thread Shiri Kuzin
Add a new PMD for Nvidia devices- crypto PMD. The crypto PMD will be supported on Nvidia ConnectX6-Dx and Bluefield 2. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. This series includ

[dpdk-dev] [PATCH 02/24] common/mlx5: update GENEVE TLV OPT obj name

2021-04-08 Thread Shiri Kuzin
From: Dekel Peled Rename MLX5_OBJ_TYPE_GENEVE_TLV_OPT as MLX5_GENERAL_OBJ_TYPE_GENEVE_TLV_OPT, to align with other general objects names. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 +- drivers/common/mlx5/mlx5_prm.h | 4 ++-- 2 files ch

Re: [dpdk-dev] rte_flow ageing

2021-04-08 Thread David Bouyeure
As seen with Matan, there's really a bug preventing to schedule a later age event(with /rte_flow_get_aged_flows()/) from the user's callback itself. I could suggest the following patch: --- dpdk-21.02/drivers/net/mlx5/mlx5.c    2021-02-14 10:58:34.0 +0100 +++ dpdk-21.02/drivers/net/ml

Re: [dpdk-dev] [PATCH v8 4/4] net: provide IP-related API on any OS

2021-04-08 Thread Dmitry Kozlyuk
2021-04-08 13:45 (UTC+0200), Olivier Matz: [...] > > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c > > index c572d003cb..e7361bf520 100644 > > --- a/drivers/net/i40e/i40e_fdir.c > > +++ b/drivers/net/i40e/i40e_fdir.c > > @@ -22,6 +22,7 @@ > > #include > > #include > >

[dpdk-dev] [PATCH v5 0/3] Enhancements to crypto adapter forward mode

2021-04-08 Thread Shijith Thotton
This series proposes a new event device enqueue operation if crypto adapter forward mode is supported. Second patch in the series is the implementation of the same in PMD. Test application changes are added in third patch. v5: - Set rte_errno if crypto adapter enqueue fails in driver. - Test appli

[dpdk-dev] [PATCH v5 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-08 Thread Shijith Thotton
Use rte_event_crypto_adapter_enqueue() API to enqueue events to crypto adapter if forward mode is supported in driver. Signed-off-by: Shijith Thotton --- app/test/test_event_crypto_adapter.c | 33 ++-- 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/app/te

[dpdk-dev] [PATCH v5 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-08 Thread Shijith Thotton
From: Akhil Goyal In case an event from a previous stage is required to be forwarded to a crypto adapter and PMD supports internal event port in crypto adapter, exposed via capability RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not have a way to check in the API rte_event_enqueue_bur

[dpdk-dev] [PATCH v5 2/3] event/octeontx2: support crypto adapter forward mode

2021-04-08 Thread Shijith Thotton
Advertise crypto adapter forward mode capability and set crypto adapter enqueue function in driver. Signed-off-by: Shijith Thotton --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 42 ++ drivers/event/octeontx2/otx2_evdev.c | 5 +- .../event/octeontx2/otx2_evdev_crypto_adptr

Re: [dpdk-dev] [PATCH v4 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-08 Thread Akhil Goyal
> > Hi Abhinandan, > > > > > > > > > > > > In case an event from a previous stage is required to be > > > > > > forwarded to a crypto adapter and PMD supports internal event > > > > > > port in crypto adapter, exposed via capability > > > > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we

Re: [dpdk-dev] [PATCH 5/5] vhost: fix offload flags in Rx path

2021-04-08 Thread Flavio Leitner
On Thu, Apr 01, 2021 at 11:52:43AM +0200, David Marchand wrote: > The vhost library current configures Tx offloading (PKT_TX_*) on any > packet received from a guest virtio device which asks for some offloading. > > This is problematic, as Tx offloading is something that the application > must ask

Re: [dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic

2021-04-08 Thread Luc Pelletier
> Thank you for these 2 fixes. Note the the title of your patches do not > contain the version (should have been v8?). I don't know how critical > it is for commiters. Thanks Olivier. I'll admit that I wasn't sure if I should version the patches after splitting the original. I opted not to but it

Re: [dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic

2021-04-08 Thread Honnappa Nagarahalli
> > The affinity of a control thread is set after it has been launched. If > setting the > affinity fails, pthread_cancel is called followed by a call to pthread_join, > which > can hang forever if the thread's start routine doesn't call a pthread > cancellation point. > > This patch modifies

Re: [dpdk-dev] [PATCH 1/2] eal: fix race in ctrl thread creation

2021-04-08 Thread Honnappa Nagarahalli
> > The creation of control threads uses a pthread barrier for synchronization. > This patch fixes a race condition where the pthread barrier could get > destroyed while one of the threads has not yet returned from the > pthread_barrier_wait function, which could result in undefined behaviour. >

Re: [dpdk-dev] [PATCH 00/10] some bugfixes for hns3 PMD

2021-04-08 Thread Ferruh Yigit
On 3/31/2021 11:01 AM, Min Hu (Connor) wrote: This set of patches are bugfixes for hns3 PMD. Chengchang Tang (1): net/hns3: fix lack of rollback after setting PVID failed Chengwen Feng (4): net/hns3: fix set default MAC addr fail in bonding of VF net/hns3: fix flow counter not cleared

Re: [dpdk-dev] [PATCH v4 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-08 Thread Gujjar, Abhinandan S
> -Original Message- > From: Akhil Goyal > Sent: Thursday, April 8, 2021 8:27 PM > To: Gujjar, Abhinandan S ; Shijith Thotton > ; dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > hemant.agra...@nxp.com; nipun.gu...@nxp.com; > sachin.sax...@oss.nxp.com; Anoob Joseph

[dpdk-dev] [PATCH v7 4/4] log: add option argument help

2021-04-08 Thread Thomas Monjalon
The option --log-level was not completely described in the usage text, and it was difficult to guess the names of the log types and levels. A new value "help" is accepted after --log-level to give more details about the syntax and listing the log types and levels. The array "levels" used for leve

[dpdk-dev] [PATCH v7 3/4] log: catch invalid level option number

2021-04-08 Thread Thomas Monjalon
The parsing check for invalid log level was not trying to catch irrelevant numeric values. A log level 0 becomes a failure in parsing so it can be caught early. A log level higher than the max (8) is accepted with a warning message. Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson Acked

[dpdk-dev] [PATCH v7 2/4] log: introduce macro for maximum level

2021-04-08 Thread Thomas Monjalon
RTE_DIM(...) and RTE_LOG_DEBUG were used to get the highest log level. For better clarity a new constant RTE_LOG_MAX is introduced and mapped to RTE_LOG_DEBUG. Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko Reviewed-by: David Marchand --- lib/librte_eal/c

[dpdk-dev] [PATCH v7 1/4] log: move private functions

2021-04-08 Thread Thomas Monjalon
Some private log functions had a wrong "rte_" prefix. All private log functions are moved from eal_private.h to the new file eal_log.h: rte_eal_log_init -> eal_log_init rte_log_save_regexp -> eal_log_save_regexp rte_log_save_pattern -> eal_log_save_pattern eal_log_s

[dpdk-dev] [PATCH v7 0/4] log level enhancements

2021-04-08 Thread Thomas Monjalon
This series is a part of a bigger one split after v4: "improve options help" The main intent of this series is to provide a nice help for the --log-level option. v7: - free sorted array of log types v6: - fix commit log v5: - rename more private functions - sort log types when

Re: [dpdk-dev] [PATCH v3 0/3] cleanup drivers log registration

2021-04-08 Thread David Marchand
On Tue, Apr 6, 2021 at 3:22 PM Thomas Monjalon wrote: > > After working on the option "--log-level help", > it became clear that few adjustments were required > for the log registration of some drivers. > > v3: >- rename pmd.afu.ipn3ke log type to pmd.net.ipn3ke > v2: >- align bonding and

Re: [dpdk-dev] [PATCH] eal: fix telemetry logtype registration

2021-04-08 Thread David Marchand
On Tue, Apr 6, 2021 at 12:18 PM Bruce Richardson wrote: > > On Tue, Apr 06, 2021 at 11:25:45AM +0200, David Marchand wrote: > > rte_log_register_type_and_pick_level() returns an int. > > Casting to a uin32_t will make us miss the -1 passed in case of failure. > > > > Fixes: 37b881a96194 ("telemetr

Re: [dpdk-dev] [PATCH] ethdev: fix VXLAN mask initialization value

2021-04-08 Thread Ivan Malov
On 4/8/2021 7:48 AM, Gregory Etelson wrote: > In GCC compiler, __builtin_constant_p(exp) is a function. > The function returns the integer 1 if the argument is known to be > a compile-time constant. > Therefore, __builtin_constant_p(0xff << 8) returned 1. > As the result, rte_flow_item_vxlan_m

Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file

2021-04-08 Thread David Marchand
On Tue, Apr 6, 2021 at 7:59 PM David Marchand wrote: > > Rather than have two files that keeps getting out of sync, let's > annotate the version.map to generate the Windows export file. > > Note: Existing version.map annotation achieved with: > $ for dir in lib/librte_eal drivers/common/mlx5; do >

Re: [dpdk-dev] [dpdk-stable] [PATCH] service: clean references to removed symbol

2021-04-08 Thread David Marchand
On Wed, Apr 7, 2021 at 11:08 AM David Marchand wrote: > > rte_service_get_id() was removed in v17.11 but the API description > still referenced it and a version node was still present in EAL map. > > Fixes: 8edc9aaaf217 ("service: use id in get by name function") > Cc: sta...@dpdk.org > > Signed-o

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/1] app/test: fix TCP header initialization

2021-04-08 Thread Ferruh Yigit
On 3/30/2021 2:23 PM, Lance Richardson wrote: Initialize TCP data offset field with TCP header length, this field is used to derive L4 header length and by hardware to validate a TCP header. Fixes: 41f72ec94074 ("test: add packet burst generator functions") Cc: sta...@dpdk.org Signed-off-by: La

Re: [dpdk-dev] [PATCH] net/hns3: fix copyright date

2021-04-08 Thread Ferruh Yigit
On 4/7/2021 10:19 AM, Min Hu (Connor) wrote: This patch updates copyright date for hns3 PMD files. Fixes: 565829db8b8f ("net/hns3: add build and doc infrastructure") Fixes: 952ebacce4f2 ("net/hns3: support SVE Rx") Fixes: e31f123db06b ("net/hns3: support NEON Tx") Fixes: c09c7847d892 ("net/hns3:

Re: [dpdk-dev] [PATCH v2 0/3] Predictable RSS feature

2021-04-08 Thread Stephen Hemminger
On Tue, 6 Apr 2021 20:50:40 +0100 Vladimir Medvedkin wrote: > This patch series introduces predictable RSS feature. > It is based on the idea of searching for partial hash collisions > within Toeplitz hash. > > The Toeplitz hash function is a homomorphism between (G, ^) and (H, ^), > where (G,

Re: [dpdk-dev] [PATCH v2 2/3] log: track log level changes

2021-04-08 Thread Thomas Monjalon
24/03/2021 11:32, David Marchand: > Add a log message when registering log types and changing log levels. [...] > + RTE_LOG(DEBUG, EAL, "%s logtype level changed from %s to %s\n", I would prefer "foo log level changed" instead of "foo logtype level changed". Opinions? > +

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd

2021-04-08 Thread Ferruh Yigit
On 4/1/2021 9:28 AM, dapengx...@intel.com wrote: From: Dapeng Yu Configure per queue rx offloading and per queue tx offloading command shouldn't trigger the rte_eth_dev_configure() to reconfigure device. The patch sets the queue reconfiguration flag only, and does not set the device reconfigur

Re: [dpdk-dev] [PATCH] ethdev: fix VXLAN mask initialization value

2021-04-08 Thread Ferruh Yigit
On 4/8/2021 7:48 AM, Gregory Etelson wrote: In GCC compiler, __builtin_constant_p(exp) is a function. The function returns the integer 1 if the argument is known to be a compile-time constant. Therefore, __builtin_constant_p(0xff << 8) returned 1. As the result, rte_flow_item_vxlan_mask was i

Re: [dpdk-dev] [EXT] Re: [PATCH 1/6] baseband: introduce NXP LA12xx driver

2021-04-08 Thread Chautru, Nicolas
Note that I did not review this serie yet as v2 was pending (+ did not receive the initial serie). Planning to send comments once that v2 is formally shared. > -Original Message- > From: Akhil Goyal > Sent: Thursday, April 8, 2021 1:56 AM > To: hemant.agra...@nxp.com; David Marchand >

Re: [dpdk-dev] [PATCH v2] net/octeontx2: support flow action port id

2021-04-08 Thread Ferruh Yigit
On 4/8/2021 11:21 AM, smad...@marvell.com wrote: From: Smadar Fuks Action port_id was not supported until now. In this patch the action port_id supports passing from input port PF to output port which is one of input port respective VF Signed-off-by: Smadar Fuks Carrying ack from previous v

Re: [dpdk-dev] [PATCH v4 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-08 Thread Akhil Goyal
Hi Abhinandan, > > > > > > > > In case an event from a previous stage is required to be forwarded > > > > to a crypto adapter and PMD supports internal event port in crypto > > > > adapter, exposed via capability > > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do > > not have a > > >

Re: [dpdk-dev] [PATCH v3 2/3] test/power: fix a bug in cpufreq autotest

2021-04-08 Thread Burakov, Anatoly
On 08-Apr-21 3:10 AM, Richael Zhuang wrote: Hi, Thanks for your comments. My change is to make the check_power_turbo() to continue only when rte_power_turbo_status(TEST_POWER_LCORE_ID) returns 1 which means turbo is available. Sure, but the code reads like if the turbo status isn't availab

Re: [dpdk-dev] [PATCH] service: clean references to removed symbol

2021-04-08 Thread Thomas Monjalon
08/04/2021 16:04, David Marchand: > On Thu, Apr 8, 2021 at 3:08 PM Van Haaren, Harry > wrote: > > > > For rte_service.h doc changes I'm all fine. > > > > > > > > For ABI consistency, this removes a function from the DPDK_21 version > > > > map that > > > didn't exist in > > > > the shared object

Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file

2021-04-08 Thread Thomas Monjalon
06/04/2021 19:59, David Marchand: > Rather than have two files that keeps getting out of sync, let's > annotate the version.map to generate the Windows export file. > > Note: Existing version.map annotation achieved with: > $ for dir in lib/librte_eal drivers/common/mlx5; do > ./buildtools/map

[dpdk-dev] [RFC PATCH v2] ethdev: introduce indirect action APIs

2021-04-08 Thread Bing Zhao
Right now, rte_flow_shared_action_* APIs are used for some shared actions, like RSS, count. The shared action shoule be created before using it inside a flow. These shared actions sometimes are not really shared but just some indirect actions decoupled from a flow. The new functions rte_flow_actio

[dpdk-dev] [PATCH] vhost: don't track remaining packets separately

2021-04-08 Thread Balazs Nemeth
The remained variable stores the same information as the difference between count and pkt_idx. Remove the remained variable to simplify. Signed-off-by: Balazs Nemeth --- lib/librte_vhost/virtio_net.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/lib/librte_vhos

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add pre-defined meter policy API

2021-04-08 Thread Li Zhang
Hi Ori, Thank you for your comments. I will add it into V3 patch. Regards, Li Zhang > -Original Message- > From: Ori Kam > Sent: Thursday, April 8, 2021 9:55 PM > To: Li Zhang ; dek...@nvidia.com; Slava Ovsiienko > ; Matan Azrad ; Shahaf > Shuler ; cristian.dumitre...@intel.com; > lir...

Re: [dpdk-dev] [PATCH] net/hns3: support wait to complete in link update API

2021-04-08 Thread Ferruh Yigit
On 3/30/2021 1:53 PM, Min Hu (Connor) wrote: From: Huisong Li There are two APIs in ethdev layer to get link status of device, namely, "rte_eth_link_get" and "rte_eth_link_get_nowait". When the device link is unstable or auto-negotiation is in progress, the first API supports the function of wa

Re: [dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic

2021-04-08 Thread Olivier Matz
Hi Luc, On Wed, Apr 07, 2021 at 04:16:06PM -0400, Luc Pelletier wrote: > The affinity of a control thread is set after it has been launched. If > setting the affinity fails, pthread_cancel is called followed by a call > to pthread_join, which can hang forever if the thread's start routine > doesn'

Re: [dpdk-dev] [PATCH 1/2] eal: fix race in ctrl thread creation

2021-04-08 Thread Olivier Matz
On Wed, Apr 07, 2021 at 04:16:04PM -0400, Luc Pelletier wrote: > The creation of control threads uses a pthread barrier for > synchronization. This patch fixes a race condition where the pthread > barrier could get destroyed while one of the threads has not yet > returned from the pthread_barrier_w

Re: [dpdk-dev] [PATCH v2 1/2] common/mlx5: support device global syntax

2021-04-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Xueming(Steven) Li > Sent: Thursday, April 8, 2021 5:08 PM > To: Raslan Darawsheh ; Slava Ovsiienko > > Cc: dev@dpdk.org; Matan Azrad ; Shahaf Shuler > ; NBU-Contact-Thomas Monjalon > ; Asaf Penso ; > ferruh.yi...@intel.com > Subject: RE: [PATCH v2 1/2] c

  1   2   3   >