[dpdk-dev] [PATCH v2 4/4] doc: update async vhost register/unregister

2021-04-01 Thread Jiayu Hu
Signed-off-by: Jiayu Hu --- doc/guides/prog_guide/vhost_lib.rst | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst index dc29229..333bd0a 100644 --- a/doc/guides/prog_guide/vhost_lib.rst +++

[dpdk-dev] [PATCH v2 3/4] vhost: avoid deadlock on async register

2021-04-01 Thread Jiayu Hu
Users can register async copy device in vring_state_changed(), when vhost queue is enabled. However, a deadlock occurs inside rte_vhost_async_channel_register(), if VHOST_USER_F_PROTOCOL_FEATURES is not supported, as vhost_user_msg_handler() takes vq->access_lock before calling vhost_user_set_vring

[dpdk-dev] [PATCH v2 2/4] vhost: remove unnecessary free

2021-04-01 Thread Jiayu Hu
This patch removes unnecessary rte_free() for async_pkts_info and async_descs_split. Signed-off-by: Jiayu Hu Reviewed-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c ind

[dpdk-dev] [PATCH v2 1/4] vhost: fix uninitialized vhost queue

2021-04-01 Thread Jiayu Hu
This patch allocates vhost queue by rte_zmalloc() to avoid undefined values. Fixes: a277c7159876 ("vhost: refactor code structure") Cc: sta...@dpdk.org Signed-off-by: Jiayu Hu --- lib/librte_vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost

[dpdk-dev] [PATCH v2 0/4] Refactor async vhost control path

2021-04-01 Thread Jiayu Hu
This patch set refactors async vhost control path. Change log == v2: - correct fix commit - update commit log Jiayu Hu (4): vhost: fix uninitialized vhost queue vhost: remove unnecessary free vhost: avoid deadlock on async register doc: update async vhost register/unregister doc

Re: [dpdk-dev] [PATCH v2] eal: fix race in ctrl thread creation

2021-04-01 Thread Honnappa Nagarahalli
> > As reported by Luc, there is a race where the barrier is destroyed by one > thread, while the other thread did not yet leave pthread_barrier_wait. Please correct me if I am wrong. We are using the pthread_barrier to 1) know when to free 'params'. 2) set the thread affinity before the thread

[dpdk-dev] [PATCH] net/bnxt: fix configuring LRO

2021-04-01 Thread Kalesh A P
From: Kalesh AP While configuring LRO, driver should check the return value of bnxt_hwrm_vnic_tpa_cfg() HWRM command and return error when the FW command fails. Fixes: 0958d8b6435d ("net/bnxt: support LRO") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/n

Re: [dpdk-dev] [PATCH 0/3] fix miss input validation

2021-04-01 Thread Min Hu (Connor)
在 2021/4/1 23:37, Ferruh Yigit 写道: On 3/27/2021 7:38 AM, Min Hu (Connor) wrote: The validity verification of input parameters should be performed at API layer, not in the PMD. This set of patches fix miss input validation. Chengchang Tang (3):    ethdev: fix miss input validation in module

[dpdk-dev] [PATCH v2 1/3] ethdev: fix miss input validation in module EEPROM dump API

2021-04-01 Thread Min Hu (Connor)
From: Chengchang Tang The validity verification of input parameters should be performed at API layer, not in the PMD. Fixes: 3a18c44b45df ("ethdev: add access to EEPROM") Fixes: 40ff8b305ab8 ("net/e1000: add module EEPROM callbacks for e1000") Fixes: f2088e785cca ("net/i40e: fix dereference befo

[dpdk-dev] [PATCH v2 0/3] fix miss input validation

2021-04-01 Thread Min Hu (Connor)
The validity verification of input parameters should be performed at API layer, not in the PMD. This set of patches fix miss input validation. --- v2: * Fixed mixes in ethdev header file and ethdev .c file. Chengchang Tang (3): ethdev: fix miss input validation in module EEPROM dump API ethde

[dpdk-dev] [PATCH v2 2/3] ethdev: fix miss input validation when access reg info

2021-04-01 Thread Min Hu (Connor)
From: Chengchang Tang This patch adds validity check of input pointer in regs dump API. Fixes: 7a3f27cbf59b ("ethdev: add access to specific device info") Fixes: 936eda25e8da ("net/hns3: support dump register") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor)

[dpdk-dev] [PATCH v2 3/3] ethdev: fix miss input validation when access EEPROM info

2021-04-01 Thread Min Hu (Connor)
From: Chengchang Tang This patch adds validity check of input pointer in EEPROM dump API. Fixes: 7a3f27cbf59b ("ethdev: add access to specific device info") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- lib/librte_ethdev/rte_ethdev.c | 4 lib/libr

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx

2021-04-01 Thread Li, Xiaoyun
> -Original Message- > From: oulijun > Sent: Friday, April 2, 2021 09:45 > To: Li, Xiaoyun ; Yigit, Ferruh > Cc: dev@dpdk.org; linux...@openeuler.org > Subject: Re: [PATCH 2/3] app/testpmd: remove forwarding config from parsing > Rx and Tx > > > > 在 2021/3/29 9:53, Li, Xiaoyun 写道: >

[dpdk-dev] [PATCH] net/mlx5: fix modify field action endianness

2021-04-01 Thread Alexander Kozyrev
Converting modify_field action masks to the big endian format is wrong for small (less than 4 bytes) fields. Use the BE conversions appropriate for a field size, not rte_cpu_to_be_32 for everything. Fixes: 7ffda9dbed ("net/mlx5: adjust modify field action endianness") Cc: sta...@dpdk.org Signed-o

Re: [dpdk-dev] [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet

2021-04-01 Thread Guo, Jia
Hi, ting > -Original Message- > From: Xu, Ting > Sent: Tuesday, March 30, 2021 11:25 AM > To: Guo, Jia ; Yang, Qiming ; > Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet > > Hi, Jeff > > > -Original Message- > > From: Gu

[dpdk-dev] [PATCH] net/ice: fix illegal pointer access when removing mac filter

2021-04-01 Thread Wenwu Ma
When removing the mac filter in ice_remove_all_mac_vlan_filters(), TAILQ_FOREACH_SAFE should be used instead of TAILQ_FOREACH, Otherwise, it will result in a illegal pointer access. Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops") Cc: sta...@dpdk.org Signed-off-by: Wenwu Ma --- drivers/net/ice

Re: [dpdk-dev] [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet

2021-04-01 Thread Guo, Jia
Hi, ting > -Original Message- > From: Xu, Ting > Sent: Thursday, April 1, 2021 10:08 AM > To: Guo, Jia ; Yang, Qiming ; > Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet > > Hi, Jeff > > See inline > > Best Regards, > Xu Ting >

Re: [dpdk-dev] [PATCH] net/hns3: use the correct HiSilicon copyright

2021-04-01 Thread Min Hu (Connor)
在 2021/4/1 22:45, Ferruh Yigit 写道: On 4/1/2021 9:53 AM, Min Hu (Connor) wrote: According to the suggestion of our legal department, to standardize the copyright license of our code to avoid potential copyright risks, we make a unified modification to the "Hisilicon", which was nonstandard, in

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx

2021-04-01 Thread oulijun
在 2021/3/29 9:53, Li, Xiaoyun 写道: -Original Message- From: oulijun Sent: Thursday, March 25, 2021 11:04 To: Li, Xiaoyun ; Yigit, Ferruh Cc: dev@dpdk.org; linux...@openeuler.org Subject: Re: [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx 在 2021/3/24 9:4

[dpdk-dev] [PATCH v5] pflock: implementation of phase-fair reader writer locks

2021-04-01 Thread Stephen Hemminger
This is a new type of reader-writer lock that provides better fairness guarantees which better suited for typical DPDK applications. A pflock has two ticket pools, one for readers and one for writers. Phase fair reader writer locks ensure that neither reader nor writer will be starved. Neither rea

Re: [dpdk-dev] [PATCH v4] pflock: add phase-fair reader writer locks

2021-04-01 Thread Stephen Hemminger
On Wed, 31 Mar 2021 04:19:14 + Honnappa Nagarahalli wrote: > > +__rte_experimental > > +static inline void > Minor, this API does not need to be inline. Unfortunately, it has to be inline otherwise Gcc warns about unused static function in every file that doesn't use it.

[dpdk-dev] [PATCH v3 1/3] build: enable iavf base code to build on windows

2021-04-01 Thread Pallavi Kadam
Enable IAVF driver to build on Windows as it is required to build ice PMD. Disable all other drivers from common directory. This patch also includes fix for a macro redefinition warning in the IAVF driver. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Acked-by: Jie Zhou --- drivers/co

[dpdk-dev] [PATCH v3 0/3] Support ice PMD on Windows

2021-04-01 Thread Pallavi Kadam
This patch-set enables building the Intel ice PMD on Windows. v3 changes: - Rebase on latest head - Replaced 'unsigned long long' with 'size_t' - Moved cflag '-fno-asynchronous-unwind-tables' above the assignment "c_args = cflags" - Updated release notes t

[dpdk-dev] [PATCH v3 2/3] net/ice: build on Windows

2021-04-01 Thread Pallavi Kadam
- Add Intel ice PMD support on Windows. - Remove #include sys/ioctl header file as it is not needed. - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types. - Replace POSIX usleep() API with rte API. - Add a new macro for the access() API as the original function has bee

[dpdk-dev] [PATCH v3 3/3] net/ice: disable ice DDP package on Windows

2021-04-01 Thread Pallavi Kadam
Disable loading of external DDP package as it is not supported on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Acked-by: Jie Zhou --- doc/guides/nics/ice.rst | 5 + drivers/net/ice/ice_ethdev.c | 6 ++ 2 files changed, 11 insertions(+) diff --git a/doc/guides/n

Re: [dpdk-dev] [PATCH] doc: fix sphinx rtd theme import in GHA

2021-04-01 Thread Thomas Monjalon
01/04/2021 22:37, Aaron Conole: > David Marchand writes: > > > If the rtd theme is available, passing it by name is enough to select > > it. Sphinx itself recognises the "sphinx_rtd_theme" name as a special > > case and tries to find its path automatically. > > > > On the other hand, passing a ht

[dpdk-dev] [Bug 600] Windows DPDK real-time priority threads causing thread starvation

2021-04-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=600 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolutio

[dpdk-dev] [Bug 238] [tree-wide] enhance getopt_long usage

2021-04-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=238 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolutio

Re: [dpdk-dev] [PATCH v6 3/5] eal: make OS shims internal

2021-04-01 Thread Thomas Monjalon
02/04/2021 01:10, Dmitry Kozlyuk: > 2021-03-31 23:55 (UTC+0200), Thomas Monjalon: > > 31/03/2021 23:45, Nick Connolly: > > > > > > > > I don't understand your point. > > > > I am just proposing to allow some apps to explicitly include the shim > > > > for their convenience in case they are fully ba

Re: [dpdk-dev] [PATCH v6 3/5] eal: make OS shims internal

2021-04-01 Thread Dmitry Kozlyuk
2021-03-31 23:55 (UTC+0200), Thomas Monjalon: > 31/03/2021 23:45, Nick Connolly: > > > > > > I don't understand your point. > > > I am just proposing to allow some apps to explicitly include the shim > > > for their convenience in case they are fully based on DPDK and > > > understand the risk of c

Re: [dpdk-dev] [PATCH v6 5/5] net: replace Windows networking shim

2021-04-01 Thread Dmitry Kozlyuk
2021-03-26 10:28 (UTC+0100), Thomas Monjalon: > 20/03/2021 14:05, Dmitry Kozlyuk: [...] > > --- a/drivers/net/i40e/i40e_fdir.c > > +++ b/drivers/net/i40e/i40e_fdir.c > > @@ -22,6 +22,7 @@ > > #include > > #include > > #include > > +#include > > Why is it needed? I deliberately put all sh

Re: [dpdk-dev] [PATCH] doc: fix sphinx rtd theme import in GHA

2021-04-01 Thread Aaron Conole
David Marchand writes: > If the rtd theme is available, passing it by name is enough to select > it. Sphinx itself recognises the "sphinx_rtd_theme" name as a special > case and tries to find its path automatically. > > On the other hand, passing a html_theme_path makes sphinx parse all > themes

[dpdk-dev] [PATCH] doc: fix sphinx rtd theme import in GHA

2021-04-01 Thread David Marchand
If the rtd theme is available, passing it by name is enough to select it. Sphinx itself recognises the "sphinx_rtd_theme" name as a special case and tries to find its path automatically. On the other hand, passing a html_theme_path makes sphinx parse all themes availables in this path, which in so

Re: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows errors to errno-style errors

2021-04-01 Thread Narcisa Ana Maria Vasile
On Wed, Mar 31, 2021 at 01:56:09PM +, Tal Shnaiderman wrote: > > Subject: [PATCH v5 03/10] windows/eal: translate Windows errors to errno- > > style errors > > > > External email: Use caution opening links or attachments > > > > > > From: Narcisa Vasile > > > > Add function to translate Wi

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: update qfi definition

2021-04-01 Thread Ferruh Yigit
On 3/30/2021 9:00 AM, Raslan Darawsheh wrote: qfi field is 8 bits which represent single bit for PPP (paging Policy Presence) single bit for RQI (Reflective QoS Indicator) and 6 bits for qfi (QoS Flow Identifier) based on RFC 38415-g30 This update the doxygen format and the mask for qfi to prope

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add new ext hdr for gtp psc

2021-04-01 Thread Ferruh Yigit
On 3/30/2021 9:00 AM, Raslan Darawsheh wrote: Define new rte header for gtp PDU session container based on RFC 38415-g30 Signed-off-by: Raslan Darawsheh --- lib/librte_net/rte_gtp.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/lib/librte_net/rte_gtp

Re: [dpdk-dev] [PATCH v3 0/2] Support PTP for hns3 PMD

2021-04-01 Thread Ferruh Yigit
On 4/1/2021 2:38 PM, Min Hu (Connor) wrote: This set includes two patches, one patch is to fix cyclomatic complexity, the other patch is to support PTP, but depends on the first patch. So the two forms one set of patches. --- v3: * Delete "RTE_LIBRTE_IEEE1588". v2: * Add release doc for version

Re: [dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated protocol features

2021-04-01 Thread Keiichi Watanabe
On Fri, Apr 2, 2021 at 1:28 AM Ferruh Yigit wrote: > On 4/1/2021 5:05 PM, Keiichi Watanabe wrote: > > Thanks for the review! > > Should I send the updated version of the patch series? Or, can I ask you > to make > > the follow up changes as a maintainer? > > > > No new version is required, alread

Re: [dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated protocol features

2021-04-01 Thread Ferruh Yigit
On 4/1/2021 5:05 PM, Keiichi Watanabe wrote: Thanks for the review! Should I send the updated version of the patch series? Or, can I ask you to make the follow up changes as a maintainer? No new version is required, already updated in the next-net [1] repo. [1] https://git.dpdk.org/next/dpd

Re: [dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated protocol features

2021-04-01 Thread Keiichi Watanabe
Thanks for the review! Should I send the updated version of the patch series? Or, can I ask you to make the follow up changes as a maintainer? Keiichi On Thu, Apr 1, 2021 at 5:42 PM Kinsella, Ray wrote: > > > On 31/03/2021 17:45, Ferruh Yigit wrote: > > On 3/22/2021 7:22 AM, Keiichi Watanabe wr

Re: [dpdk-dev] [PATCH 0/3] fix miss input validation

2021-04-01 Thread Ferruh Yigit
On 3/27/2021 7:38 AM, Min Hu (Connor) wrote: The validity verification of input parameters should be performed at API layer, not in the PMD. This set of patches fix miss input validation. Chengchang Tang (3): ethdev: fix miss input validation in module EEPROM dump API ethdev: fix miss inp

Re: [dpdk-dev] [PATCH 3/3] ethdev: fix miss input validation when access EEPROM info

2021-04-01 Thread Ferruh Yigit
On 3/27/2021 7:38 AM, Min Hu (Connor) wrote: From: Chengchang Tang This patch adds validity check of input pointer in EEPROM dump API. Fixes: 7a3f27cbf59b ("ethdev: add access to specific device info") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) Revie

Re: [dpdk-dev] [PATCH 2/3] ethdev: fix miss input validation when access reg info

2021-04-01 Thread Ferruh Yigit
On 3/27/2021 7:38 AM, Min Hu (Connor) wrote: From: Chengchang Tang This patch adds validity check of input pointer in regs dump API. Fixes: 7a3f27cbf59b ("ethdev: add access to specific device info") Fixes: 936eda25e8da ("net/hns3: support dump register") Cc: sta...@dpdk.org Signed-off-by: Ch

Re: [dpdk-dev] [PATCH 1/3] ethdev: fix miss input validation in module EEPROM dump API

2021-04-01 Thread Ferruh Yigit
On 3/27/2021 7:38 AM, Min Hu (Connor) wrote: From: Chengchang Tang The validity verification of input parameters should be performed at API layer, not in the PMD. Fixes: 3a18c44b45df ("ethdev: add access to EEPROM") Fixes: 40ff8b305ab8 ("net/e1000: add module EEPROM callbacks for e1000") Fixes

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v5 09/10] eal: add EAL argument for setting thread priority

2021-04-01 Thread Dmitry Malloy
The internal discussion was about the fact that this EAL parameter is: a) optional b) modifies default behavior (which is different on Windows or on Linux) Unless admin decides to use this option - no one is regressed. This patch is not forcing a change in default behavior. It gives the admin a

Re: [dpdk-dev] [PATCH v3 4/5] bus: add device arguments name parsing API

2021-04-01 Thread Xueming(Steven) Li
>-Original Message- >From: Thomas Monjalon >Sent: Wednesday, March 31, 2021 6:20 PM >To: Xueming(Steven) Li >Cc: Gaetan Rivet ; dev@dpdk.org; Asaf Penso >; david.march...@redhat.com; >ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru; hemant.agra...@nxp.com; >step...@networkplumbe

[dpdk-dev] [PATCH v3 2/2] power: do not skip saving original pstate governor

2021-04-01 Thread Anatoly Burakov
Currently, when we set the pstate governor to "performance", we check if it is already set to this value, and if it is, we skip setting it. However, we never save this value anywhere, so that next time we come back and request the governor to be set to its original value, the original value is emp

[dpdk-dev] [PATCH v3 1/2] power: fix pstate base frequency handling

2021-04-01 Thread Anatoly Burakov
Previous fix for base frequency handling in pstate mode introduced a couple of issues: - When base_frequency file does not exist, it simply bails out because of what appears to be accidental addition of FOPEN_OR_ERR_RET. This is incorrect, as absence of this file is not fatal and is in fact

[dpdk-dev] [PATCH 21.08] power: refactor pstate sysfs handling

2021-04-01 Thread Anatoly Burakov
Currently, pstate sysfs handling code is a bit of an unmaintainable mess, which has contributed to various errors leading to bugs. Refactor the code in a way that makes it more maintainable and less error prone. Signed-off-by: Anatoly Burakov --- lib/librte_power/meson.build| 7 +

[dpdk-dev] [PATCH v2 1/2] power: fix pstate base frequency handling

2021-04-01 Thread Anatoly Burakov
Previous fix for base frequency handling in pstate mode introduced a couple of issues: - When base_frequency file does not exist, it simply bails out because of what appears to be accidental addition of FOPEN_OR_ERR_RET. This is incorrect, as absence of this file is not fatal and is in fact

[dpdk-dev] [PATCH v2 2/2] power: do not skip saving original pstate governor

2021-04-01 Thread Anatoly Burakov
Currently, when we set the pstate governor to "performance", we check if it is already set to this value, and if it is, we skip setting it. However, we never save this value anywhere, so that next time we come back and request the governor to be set to its original value, the original value is emp

Re: [dpdk-dev] [PATCH] net/hns3: use the correct HiSilicon copyright

2021-04-01 Thread Ferruh Yigit
On 4/1/2021 9:53 AM, Min Hu (Connor) wrote: According to the suggestion of our legal department, to standardize the copyright license of our code to avoid potential copyright risks, we make a unified modification to the "Hisilicon", which was nonstandard, in the main modules we maintain. We chan

Re: [dpdk-dev] [PATCH v6 1/8] ether: refine debug build option

2021-04-01 Thread Ferruh Yigit
On 3/31/2021 10:52 AM, Qi Zhang wrote: PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. The patch introduces below build options for data path deb

Re: [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K

2021-04-01 Thread Honnappa Nagarahalli
> > > > Subject: Re: [dpdk-dev] [PATCH] config/arm: add support for > > > > Marvell CN10K > > > > > > > > On Wed, Mar 31, 2021 at 10:53 PM Nithin Dabilpuram > > > > wrote: > > > > > > > > > > From: Pavan Nikhilesh > > > > > > > > > > Add config support to cross compile for Marvell CN10K SoC. >

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-04-01 Thread Ori Kam
Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian > > Hi Ori, > > > -Original Message- > > From: Ori Kam > > Hi Cristian, > > > > > -Original Message- > > > From: Dumitrescu, Cristian > > > Hi Ori, > > > > > > > -Original Message- > > > > From: Or

Re: [dpdk-dev] [PATCH v6 0/8] ether: refine debug build option

2021-04-01 Thread Ferruh Yigit
On 3/31/2021 10:52 AM, Qi Zhang wrote: PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. Patch 1/8: introduces new compile options for data path de

Re: [dpdk-dev] [RFC PATCH 00/14] Build file update proposals

2021-04-01 Thread Bruce Richardson
On Thu, Apr 01, 2021 at 03:36:39PM +0200, Thomas Monjalon wrote: > 01/04/2021 13:49, Bruce Richardson: > > This RFC contains 5 changes/updates to the DPDK build and build files. These > > updates all assume that the minimum version for DPDK has increased to at > > least > > meson 0.49 as proposed

Re: [dpdk-dev] [RFC PATCH 06/14] build: reduce indentation in app build spec

2021-04-01 Thread Bruce Richardson
On Thu, Apr 01, 2021 at 03:32:14PM +0200, Thomas Monjalon wrote: > 01/04/2021 13:50, Bruce Richardson: > > As with the lib and drivers directories, we can use "continue" keyword to > > reduce the indentation level of the majority of the foreach block. At the > > same time, we can also replace tab i

Re: [dpdk-dev] [RFC PATCH 03/14] build: correct indentation in list of libs

2021-04-01 Thread Bruce Richardson
On Thu, Apr 01, 2021 at 03:30:24PM +0200, Thomas Monjalon wrote: > 01/04/2021 13:49, Bruce Richardson: > > With the lib/meson.build file changed from C-style indentation to > > python-style indentation, we need to correct the indentation of the lists > > of libraries, since these libs were not modi

Re: [dpdk-dev] [RFC PATCH 13/14] lib: remove librte_ prefix from directory names

2021-04-01 Thread Thomas Monjalon
01/04/2021 13:50, Bruce Richardson: > There is no reason for the DPDK libraries to all have 'librte_' prefix on > the directory names. This prefix makes the directory names longer and also > makes it awkward to add features referring to individual libraries in the > build - should the lib names be

[dpdk-dev] [PATCH v3 2/2] net/hns3: support IEEE 1588 PTP

2021-04-01 Thread Min Hu (Connor)
Add hns3 support for new ethdev APIs to enable and read IEEE1588/ 802.1AS PTP timestamps. Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 2 + doc/guides/nics/hns3.rst | 1 + doc/guides/rel_notes/release_21_05.rst | 1 + drivers/net/hns3/hns3_cmd.h

[dpdk-dev] [PATCH v3 1/2] net/hns3: fix code check warning

2021-04-01 Thread Min Hu (Connor)
This patch fixed cyclomatic complexity about MTU in device configure process. Fixes: 1f5ca0b460cd ("net/hns3: support some device operations") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 61 +- 1 file changed, 3

[dpdk-dev] [PATCH v3 0/2] Support PTP for hns3 PMD

2021-04-01 Thread Min Hu (Connor)
This set includes two patches, one patch is to fix cyclomatic complexity, the other patch is to support PTP, but depends on the first patch. So the two forms one set of patches. --- v3: * Delete "RTE_LIBRTE_IEEE1588". v2: * Add release doc for version 21.05. Min Hu (Connor) (2): net/hns3: fix c

Re: [dpdk-dev] [RFC PATCH 00/14] Build file update proposals

2021-04-01 Thread Thomas Monjalon
01/04/2021 13:49, Bruce Richardson: > This RFC contains 5 changes/updates to the DPDK build and build files. These > updates all assume that the minimum version for DPDK has increased to at least > meson 0.49 as proposed in [1]. > > The changes in this set are: > 1. Use "continue" keyword, new in

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-04-01 Thread Dumitrescu, Cristian
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Thursday, April 1, 2021 2:14 PM > To: Dumitrescu, Cristian ; Matan Azrad > ; Li Zhang ; Dekel Peled > ; Slava Ovsiienko ; Shahaf > Shuler ; lir...@marvell.com; Singh, Jasvinder > ; NBU-Contact-Thomas Monjalon > ; Yigit, Ferruh ; Andrew

Re: [dpdk-dev] [RFC PATCH 06/14] build: reduce indentation in app build spec

2021-04-01 Thread Thomas Monjalon
01/04/2021 13:50, Bruce Richardson: > As with the lib and drivers directories, we can use "continue" keyword to > reduce the indentation level of the majority of the foreach block. At the > same time, we can also replace tab indentation with spaces. > > Signed-off-by: Bruce Richardson > --- > +

Re: [dpdk-dev] [RFC PATCH 03/14] build: correct indentation in list of libs

2021-04-01 Thread Thomas Monjalon
01/04/2021 13:49, Bruce Richardson: > With the lib/meson.build file changed from C-style indentation to > python-style indentation, we need to correct the indentation of the lists > of libraries, since these libs were not modified in the previous patches. > > Signed-off-by: Bruce Richardson > ---

Re: [dpdk-dev] [PATCH] drivers/net: remove useless autoneg capability

2021-04-01 Thread Ferruh Yigit
On 3/29/2021 3:12 PM, Ajit Khaparde wrote: On Mon, Mar 29, 2021 at 12:29 AM Thomas Monjalon wrote: The flag ETH_LINK_SPEED_AUTONEG is 0, so it cannot be used in a capability bitmap. Having 0 in speed capability means all speeds are accepted. Signed-off-by: Thomas Monjalon --- drivers/net/

[dpdk-dev] [PATCH] doc: update push/pop VLAN support in mlx5 guide

2021-04-01 Thread Dong Zhou
Updates the documentation for push/pop VLAN support. In E-Switch mode, push VLAN on ingress traffic and pop VLAN in egress traffic are both support. Signed-off-by: Dong Zhou --- doc/guides/nics/mlx5.rst | 12 ++-- doc/guides/rel_notes/release_21_05.rst | 6 ++ 2 files

Re: [dpdk-dev] [PATCH] net/i40e: add Tx preparation for vector data path

2021-04-01 Thread Ananyev, Konstantin
> > On Wed, Mar 31, 2021 at 11:17 AM Leyi Rong wrote: > > > > Fill up dev->tx_pkt_prepare to i40e_pkt_prepare when on vector and simple > > data path selection, as the sanity check is needed ideally. > > > > Signed-off-by: Leyi Rong > > --- > > drivers/net/i40e/i40e_rxtx.c | 2 +- > > 1 file

Re: [dpdk-dev] [PATCH] doc: add Linux rawio capability requirement in mlx5 guide

2021-04-01 Thread Thomas Monjalon
01/04/2021 14:06, Eli Britstein: > On 4/1/2021 2:39 PM, Thomas Monjalon wrote: > > About the title: "rawio" is not a word. > > "raw IO" would be better. > > It was meant for cap_sys_rawio. As underscores are not allowed in the > title, I used "rawio". > > I think "raw IO" misses that meaning. Wh

Re: [dpdk-dev] [RFC PATCH 00/14] Build file update proposals

2021-04-01 Thread Luca Boccassi
On Thu, 2021-04-01 at 15:27 +0300, Andrew Rybchenko wrote: > On 4/1/21 2:49 PM, Bruce Richardson wrote: > > This RFC contains 5 changes/updates to the DPDK build and build files. These > > updates all assume that the minimum version for DPDK has increased to at > > least > > meson 0.49 as proposed

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-04-01 Thread Ori Kam
Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian > Hi Ori, > > > -Original Message- > > From: Ori Kam > > Hi All, > > > > > -Original Message- > > > From: Matan Azrad > > > Subject: RE: [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API > > > > >

Re: [dpdk-dev] [PATCH v5 3/5] examples/l3fwd: add FIB infrastructure

2021-04-01 Thread Walsh, Conor
> > > @@ -310,7 +328,10 @@ print_usage(const char *prgname) > > " Valid only if --mode=eventdev\n" > > " --event-eth-rxqs: Number of ethernet RX queues per > device.\n" > > "Default: 1\n" > > - "

[dpdk-dev] [PATCH v3 52/52] common/cnxk: add support for rss action in rte_flow

2021-04-01 Thread Nithin Dabilpuram
From: Satheesh Paul Added support for allocating rss group and setting it as action of an NPC rule for rte_flow. Signed-off-by: Satheesh Paul --- drivers/common/cnxk/roc_npc.c | 159 + drivers/common/cnxk/roc_npc.h | 20 + drivers/common/cnxk/

[dpdk-dev] [PATCH v3 51/52] common/cnxk: add tim irq support

2021-04-01 Thread Nithin Dabilpuram
From: Pavan Nikhilesh Add TIM LF IRQ register and un-register functions. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_tim.c | 51 ++ drivers/common/cnxk/roc_tim_irq.c | 104 + d

[dpdk-dev] [PATCH v3 50/52] common/cnxk: add base tim device support

2021-04-01 Thread Nithin Dabilpuram
From: Pavan Nikhilesh Add TIM device init, fini which are used to attach TIM LF resources to the RVU PF/VF and TIM LF alloc and free. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_api.h | 3 + drivers/common/cnxk/roc_platform.c |

[dpdk-dev] [PATCH v3 49/52] common/cnxk: add sso debug support

2021-04-01 Thread Nithin Dabilpuram
From: Pavan Nikhilesh Add sso debug dump support. This dumps all SSO LF register values to a given file handle. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_sso.h | 4 +++ drivers/common/cnxk/roc_sso_debug.c | 68

[dpdk-dev] [PATCH v3 47/52] common/cnxk: add sso hwgrp interface

2021-04-01 Thread Nithin Dabilpuram
From: Pavan Nikhilesh Add SSO HWGRP interface for configuring XAQ pool, setting priority and internal HW buffer limits for each HWGRP. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_sso.c | 110 drivers/common/cnxk/roc_sso.h | 21 ++

[dpdk-dev] [PATCH v3 48/52] common/cnxk: add sso irq support

2021-04-01 Thread Nithin Dabilpuram
From: Pavan Nikhilesh Add support to registering and un-registering SSO HWS and HWGRP IRQs. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_sso.c | 41 ++ drivers/common/cnxk/roc_sso_irq.c | 164 +

[dpdk-dev] [PATCH v3 46/52] common/cnxk: add sso hws interface

2021-04-01 Thread Nithin Dabilpuram
From: Pavan Nikhilesh Add SSO HWS interface for setting/unsetting links, retrieving base address and nanoseconds to getwork timeout. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_sso.c | 128 - drivers/common/cnxk/roc_sso.h | 6 ++ d

[dpdk-dev] [PATCH v3 45/52] common/cnxk: add base sso device support

2021-04-01 Thread Nithin Dabilpuram
From: Pavan Nikhilesh Add SSO device init and fini which attach SSO LF resources to the RVU PF/VF and SSO HWS and HWGRP LFs alloc, free. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 3 + drivers/common/cnxk/roc_idev.c

[dpdk-dev] [PATCH v3 44/52] common/cnxk: add npc init and fini support

2021-04-01 Thread Nithin Dabilpuram
From: Kiran Kumar K Adding support initialize and fini the npc. Further, adding APIs to create and destroy the npc rules. Signed-off-by: Kiran Kumar K --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_npc.c | 713 drivers/common/cnx

[dpdk-dev] [PATCH v3 43/52] common/cnxk: add npc parsing API

2021-04-01 Thread Nithin Dabilpuram
From: Kiran Kumar K Adding npc parsing API support to parse different patterns and actions. Based on the pattern and actions ltype values will be chosen and mcam data will be configured at perticular offsets. Signed-off-by: Kiran Kumar K --- drivers/common/cnxk/meson.build | 1 + drivers

[dpdk-dev] [PATCH v3 42/52] common/cnxk: add mcam utility API

2021-04-01 Thread Nithin Dabilpuram
From: Kiran Kumar K Adding mcam utility functions like reading KEX and reserving and writing mcam rules. Signed-off-by: Kiran Kumar K --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_npc_mcam.c | 708 + drivers/common/cnxk/roc_npc_priv

[dpdk-dev] [PATCH v3 41/52] common/cnxk: add npc helper API

2021-04-01 Thread Nithin Dabilpuram
From: Kiran Kumar K Adding NPC helper APIs to manage MCAM like pre allocating the mcam, configuring the rules, shifting mcam rules and preparing the data for mcam based on KEX. Signed-off-by: Kiran Kumar K --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_npc_priv.h |

[dpdk-dev] [PATCH v3 40/52] common/cnxk: add npc support

2021-04-01 Thread Nithin Dabilpuram
From: Kiran Kumar K Adding initial support for programming NPC. NPC is Network Parser and CAM unit that provides Rx and Tx packet parsing and packet manipulation functionality on Marvell CN9K and CN10K SoC's. It is mapped to RTE Flow in DPDK. Signed-off-by: Kiran Kumar K --- drivers/common/cnx

[dpdk-dev] [PATCH v3 39/52] common/cnxk: add nix tm debug support and misc utils

2021-04-01 Thread Nithin Dabilpuram
Add support to dump TM HW registers and hierarchy on error. This patch also adds support for misc utils such as API to query TM HW resource availability, resource pre-allocation and static priority support on root node. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h

[dpdk-dev] [PATCH v3 38/52] common/cnxk: add nix tm dynamic update support

2021-04-01 Thread Nithin Dabilpuram
Add support for dynamic node update of shaper profile, RR quantum and also support to suspend or resume an active TM node. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h| 10 ++ drivers/common/cnxk/roc_nix_tm_ops.c | 220 +++ drivers/c

[dpdk-dev] [PATCH v3 37/52] common/cnxk: add nix tm support for internal hierarchy

2021-04-01 Thread Nithin Dabilpuram
Add support to create internal TM default hierarchy and ratelimit hierarchy and API to ratelimit SQ to a given rate. This will be used by cnxk ethdev driver's tx queue ratelimit op. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h| 7 ++ drivers/common/cnxk/roc_nix_pr

[dpdk-dev] [PATCH v3 36/52] common/cnxk: add nix tm hierarchy enable/disable

2021-04-01 Thread Nithin Dabilpuram
Add support to enable or disable hierarchy along with allocating node HW resources such as shapers and schedulers and configuring them to match the user created or default hierarchy. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h | 8 + drivers/common/cnxk/roc_nix_

[dpdk-dev] [PATCH v3 35/52] common/cnxk: add nix tm helper to alloc and free resource

2021-04-01 Thread Nithin Dabilpuram
Add TM helper API to estimate, alloc, assign, and free resources for a NIX LF / ethdev. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h | 1 + drivers/common/cnxk/roc_nix_priv.h | 16 ++ drivers/common/cnxk/roc_nix_tm.c | 461 +

[dpdk-dev] [PATCH v3 34/52] common/cnxk: add nix tm shaper profile add support

2021-04-01 Thread Nithin Dabilpuram
From: Satha Rao Add support to add/delete/update shaper profile for a given NIX. Also add support to walk through existing shaper profiles. Signed-off-by: Nithin Dabilpuram Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix.h | 25 + drivers/common/cnxk/roc_nix_priv.h

[dpdk-dev] [PATCH v3 33/52] common/cnxk: add nix tm support to add/delete node

2021-04-01 Thread Nithin Dabilpuram
Add support to add/delete nodes in a hierarchy. This patch also adds misc utils to get node name, walk through nodes etc. Signed-off-by: Nithin Dabilpuram Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix.h | 42 +++ drivers/common/cnxk/roc_nix_priv.h | 14 +++ drivers

Re: [dpdk-dev] [RFC PATCH 05/14] build: clean up driver list indentation

2021-04-01 Thread Andrew Rybchenko
On 4/1/21 3:33 PM, Bruce Richardson wrote: > On Thu, Apr 01, 2021 at 03:14:40PM +0300, Andrew Rybchenko wrote: >> On 4/1/21 2:50 PM, Bruce Richardson wrote: >>> Ensure all lists of drivers are one-per-line and replace tabs with spaces >>> in each file to correspond to the new standard. >>> >>> Sign

[dpdk-dev] [PATCH v3 31/52] common/cnxk: add nix LSO support and misc utils

2021-04-01 Thread Nithin Dabilpuram
From: Sunil Kumar Kori Add support to create LSO formats for TCP segmentation offload for IPv4/IPv6, tunnel and non-tunnel protocols. Tunnel protocol support is for GRE and UDP based tunnel protocols. This patch also adds other helper API to retrieve eeprom info and configure Rx for different sw

[dpdk-dev] [PATCH v3 32/52] common/cnxk: add nix traffic management base support

2021-04-01 Thread Nithin Dabilpuram
Add nix traffic management base support to init/fini node, shaper profile and topology, setup SQ for a given user hierarchy or default internal hierarchy. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/meson.build| 3 + drivers/common/cnxk/roc_nix.c | 7 + drivers/

[dpdk-dev] [PATCH v3 30/52] common/cnxk: add nix flow control support

2021-04-01 Thread Nithin Dabilpuram
From: Sunil Kumar Kori Add support to enable/disable Rx/Tx flow control and pause frame configuration on NIX. Signed-off-by: Sunil Kumar Kori --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_nix.h| 34 ++ drivers/common/cnxk/roc_nix_fc.c | 251

[dpdk-dev] [PATCH v3 29/52] common/cnxk: add VLAN filter support

2021-04-01 Thread Nithin Dabilpuram
From: Sunil Kumar Kori Add helper API to support VLAN filtering and stripping on Rx and VLAN insertion on Tx. Signed-off-by: Sunil Kumar Kori --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_nix.h | 45 drivers/common/cnxk/roc_nix_vlan.c | 205

[dpdk-dev] [PATCH v3 28/52] common/cnxk: add nix debug dump support

2021-04-01 Thread Nithin Dabilpuram
From: Jerin Jacob Add support to dump NIX RQ, SQ and CQ contexts apart from NIX LF registers. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_nix.h | 10 + drivers/common/cnxk/roc_nix_debug.c | 805

  1   2   3   >