Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-22 Thread Gabriel Ganne
Hi, Thanks for the review. I have some reservations about those TODO: they are about rewriting the same functionality with a newer meson feature. No functional change is expected. => Why not write a commit that implements such a TODO and bumps meson version at the same time independently ? In an

Re: [dpdk-dev] [PATCH v5 1/8] net/hns3: support runtime config to select IO burst func

2021-03-22 Thread fengchengwen
sorry to send again: +to Ferruh On 2021/3/22 21:58, Ferruh Yigit wrote: > On 3/19/2021 1:07 AM, Min Hu (Connor) wrote: >> From: Chengwen Feng >> >> Currently, the driver support multiple IO burst function and auto >> selection of the most appropriate function based on offload >> configuration. >>

Re: [dpdk-dev] [PATCH v5 1/8] net/hns3: support runtime config to select IO burst func

2021-03-22 Thread fengchengwen
On 2021/3/22 21:58, Ferruh Yigit wrote: > On 3/19/2021 1:07 AM, Min Hu (Connor) wrote: >> From: Chengwen Feng >> >> Currently, the driver support multiple IO burst function and auto >> selection of the most appropriate function based on offload >> configuration. >> >> Most applications such as

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd

2021-03-22 Thread Li, Xiaoyun
Hi > -Original Message- > From: Lijun Ou > Sent: Friday, March 5, 2021 18:22 > To: Yigit, Ferruh > Cc: Li, Xiaoyun ; dev@dpdk.org; > linux...@openeuler.org > Subject: [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd > > From: Hongbo Zheng > > In testpmd, when we input "show config rxtx"

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd

2021-03-22 Thread Li, Xiaoyun
Hi > -Original Message- > From: Lijun Ou > Sent: Friday, March 5, 2021 18:22 > To: Yigit, Ferruh > Cc: Li, Xiaoyun ; dev@dpdk.org; > linux...@openeuler.org > Subject: [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd > > From: Hongbo Zheng > > In testpmd, when we input "show config rxt

Re: [dpdk-dev] [PATCH v2 01/10] eal: add thread id and simple thread functions

2021-03-22 Thread Stephen Hemminger
On Mon, 22 Mar 2021 17:20:26 -0700 Narcisa Ana Maria Vasile wrote: > @@ -59,7 +92,7 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp); > * > * @return > * On success, zero. > - * On failure, a negative number. > + * On failure, return a positive errno-style error number. > */

[dpdk-dev] [PATCH v3 6/6] net/ngbe: define registers

2021-03-22 Thread Jiawen Wu
Define all registers that will be used. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 1489 + drivers/net/ngbe/base/ngbe_type.h |2 + 2 files changed, 1491 insertions(+) create mode 100644 drivers/net/ngbe/base/ngbe_regs.h diff --git a/drivers

[dpdk-dev] [PATCH v3 4/6] net/ngbe: add device init and uninit

2021-03-22 Thread Jiawen Wu
Add basic init and uninit function. Map device IDs and subsystem IDs to single ID for easy operation. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 4 +- drivers/net/ngbe/base/ngbe.h | 11 ++ drivers/net/ngbe/base/ngbe_hw.c| 59 ++ drivers/net/ngbe/base/

[dpdk-dev] [PATCH v3 5/6] net/ngbe: add log type and error type

2021-03-22 Thread Jiawen Wu
Add log type and error type to trace functions. Signed-off-by: Jiawen Wu --- doc/guides/nics/ngbe.rst| 20 + drivers/net/ngbe/base/ngbe_status.h | 124 drivers/net/ngbe/base/ngbe_type.h | 1 + drivers/net/ngbe/ngbe_ethdev.c | 16 drive

[dpdk-dev] [PATCH v3 3/6] net/ngbe: support probe and remove

2021-03-22 Thread Jiawen Wu
Add basic PCIe ethdev probe and remove. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 1 + drivers/net/ngbe/ngbe_ethdev.c| 77 +-- 2 files changed, 75 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/features/ngbe.ini b/doc/guides/n

[dpdk-dev] [PATCH v3 2/6] net/ngbe: add device IDs

2021-03-22 Thread Jiawen Wu
Add device IDs for Wangxun 1Gb NICs, and register rte_ngbe_pmd. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 18 +++ drivers/net/ngbe/base/ngbe_devids.h | 83 + drivers/net/ngbe/meson.build| 6 +++ drivers/net/ngbe/ngbe_ethdev.c

[dpdk-dev] [PATCH v3 1/6] net/ngbe: add build and doc infrastructure

2021-03-22 Thread Jiawen Wu
Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for ngbe PMD. Signed-off-by: Jiawen Wu --- MAINTAINERS| 6 ++ doc/guides/nics/features/ngbe.ini | 10 + doc/guides/nics/index.rst | 1 + doc/guide

[dpdk-dev] [PATCH v3 0/6] net: ngbe PMD

2021-03-22 Thread Jiawen Wu
This patch set provides a skeleton of ngbe PMD, which adapted to Wangxun WX1860 series NICs. v3: - Use rte_ether functions to define marcos. v2: - Correct some clerical errors. - Use ethdev debug flags instead of driver own Jiawen Wu (6): net/ngbe: add build and doc infrastructure net/ngbe:

Re: [dpdk-dev] [PATCH v1 4/4] net/iavf: support FDIR for IP fragment packet

2021-03-22 Thread Guo, Jia
Hi, xiaoyun > -Original Message- > From: Li, Xiaoyun > Sent: Friday, March 19, 2021 3:57 PM > To: Guo, Jia ; or...@nvidia.com; Zhang, Qi Z > ; Xing, Beilei ; Wu, Jingjing > > Cc: Zhang, Yuying ; Xu, Ting ; > dev@dpdk.org > Subject: RE: [PATCH v1 4/4] net/iavf: support FDIR for IP fragmen

[dpdk-dev] How about add rte flow get capablity APIs

2021-03-22 Thread Fengchengwen
Hi, Ori and Ferruh Currently, the rte flow APIs lack of get capability APIs, upper-application could not get the device capability unless look doc or code or even test it. Maybe it's a good idea to add the get capability like traffic manager framework, what do you think? Regards

[dpdk-dev] [PATCH v2 08/10] eal: implement functions for thread barrier management

2021-03-22 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for barrier init, destroy, wait. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 16 +++ lib/librte_eal/include/rte_thread.h | 46 +++ lib/librte_eal/include/rte_thread_types.h | 2 + .../in

[dpdk-dev] [PATCH v2 06/10] eal: add thread lifetime management

2021-03-22 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for thread creation, join, canceling. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c | 110 lib/librte_eal/include/rte_thread.h | 53 lib/librte_eal/windows/rte_thread.c | 125 ++

[dpdk-dev] [PATCH v2 09/10] eal: add EAL argument for setting thread priority

2021-03-22 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Allow the user to choose the thread priority through an EAL command line argument. The user can select the thread priority to be either 'normal' or 'critical': --thread-prio normal --thread-prio realtime Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/eal_common_o

[dpdk-dev] [PATCH v2 07/10] eal: implement functions for mutex management

2021-03-22 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for mutex init, destroy, lock, unlock. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 24 lib/librte_eal/include/rte_thread.h | 55 +++ lib/librte_eal/include/rte_thread_types.h | 3 +

[dpdk-dev] [PATCH v2 05/10] eal: implement thread priority management functions

2021-03-22 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for setting the priority for a thread. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c | 25 ++ lib/librte_eal/include/rte_thread.h | 17 +++ lib/librte_eal/windows/rte_thread.c | 76 + 3 files chan

[dpdk-dev] [PATCH v2 03/10] windows/eal: translate Windows errors to errno-style errors

2021-03-22 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. Signed-off-by: Narcisa Vasile --- lib/librte_eal/windows/rte_thread.c | 59 - 1 file changed, 50 insertions(+), 9 deletions(-) diff --git a/lib/librte_eal/windows/rte_thr

[dpdk-dev] [PATCH v2 04/10] eal: implement functions for thread affinity management

2021-03-22 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement functions for getting/setting thread affinity. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/librte_eal/common/rte_thread.c | 13 ++ lib/librte_eal/include/rte_thread.h | 41 +++ lib/librte_eal/windows/eal_lcore.c | 170 ++

[dpdk-dev] [PATCH v2 02/10] eal: add thread attributes

2021-03-22 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 53 lib/librte_eal/include/rte_thread.h | 82 +

[dpdk-dev] [PATCH v2 01/10] eal: add thread id and simple thread functions

2021-03-22 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add the thread identifier type. Add functions for comparing thread ids and obtaining the thread id for the current thread. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 101 ++ lib/librte_eal/include/rte_thread.h

[dpdk-dev] [PATCH v2 00/10] eal: Add new API for threading

2021-03-22 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread matched interfaces. Gi

Re: [dpdk-dev] [PATCH] eal: update all buses default scan mode

2021-03-22 Thread Dmitry Kozlyuk
2021-03-16 20:45 (UTC+0800), Xueming Li: [...] > diff --git a/lib/librte_eal/common/eal_common_bus.c > b/lib/librte_eal/common/eal_common_bus.c > index baa5b532af..ebbb3995f6 100644 > --- a/lib/librte_eal/common/eal_common_bus.c > +++ b/lib/librte_eal/common/eal_common_bus.c > @@ -277,3 +277,19 @@

Re: [dpdk-dev] [PATCH] net/bnxt: fix memory allocation for command response

2021-03-22 Thread Ajit Khaparde
On Fri, Mar 19, 2021 at 11:27 PM Kalesh A P wrote: > > From: Kalesh AP > > Driver re-allocates memory for the command response buffer > when the installed firmware version is newer (and has a larger > max response length) than the version of HWRM that was used to > build the PMD. > > This change

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v2] app/test-pmd: enable testpmd on windows

2021-03-22 Thread Dmitry Kozlyuk
2021-03-22 21:55 (UTC+), Jie Zhou: > Thank you Dmitry! > > Regarding " I can make eal_mem_free() behave as expected at issue 2. Or > should we simple disable this code when where's no multiprocess support (how > do we test for it properly, BTW)?". The issue hit when I ran testpmd (with > i4

Re: [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson

2021-03-22 Thread Dmitry Kozlyuk
2021-03-22 16:04 (UTC+), Nick Connolly: > > meson guarantees this is portable, so this also allows us to remove a > > is_windows switch. > Hi Gabriel, > > On Windows, there are at least three different compilation options: > > * MinGW-w64 with posix threads > * MinGW-w64 with win32 thre

Re: [dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-22 Thread Ananyev, Konstantin
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, March 22, 2021 5:08 PM > To: Ananyev, Konstantin ; Yigit, Ferruh > ; Lijun Ou ; > tho...@monjalon.net > Cc: dev@dpdk.org; linux...@openeuler.org; Andrew Rybchenko > ; David Marchand > ; Ray Kinsella ; Luca Boccassi > > Sub

Re: [dpdk-dev] [PATCH] net/cxgbe: disable Rx path during port link down

2021-03-22 Thread Ferruh Yigit
On 3/15/2021 9:51 PM, Rahul Lakkireddy wrote: When link goes down, disable the port's Rx path to drop the incoming traffic closer to the wire, instead of accepting them in for further Rx processing, only to eventually drop them at the port's Rxqs. This prevents unnecessary congestion in the Rx pa

Re: [dpdk-dev] [PATCH v2 1/8] ether: refine debug compile option

2021-03-22 Thread Ferruh Yigit
On 3/16/2021 4:37 PM, Ferruh Yigit wrote: On 3/16/2021 1:39 PM, Thomas Monjalon wrote: 16/03/2021 14:05, Ferruh Yigit: On 3/12/2021 12:12 PM, Qi Zhang wrote: PMDs use RTE_LIBRTE__DEBUG_RX|TX as compile option to wrap data path debug code. As .config has been removed since the meson build, It i

Re: [dpdk-dev] [PATCH v1 1/1] net/hinic: fix coredump when PMD used by fstack

2021-03-22 Thread Ferruh Yigit
On 3/15/2021 8:14 AM, Guoyang Zhou wrote: The fstack will use secondary process to access the memory of eth_dev_ops , and it wants to get the info of dev, but hinic driver does not initialized it when in secondary process. I guess the issue is not specific to the f-stack, perhaps can generaliz

Re: [dpdk-dev] [EXT] [PATCH 0/8] Optimize qede use of rx/tx_entries

2021-03-22 Thread Igor Russkikh
On 3/5/2021 2:13 PM, Balazs Nemeth wrote: > External Email > > -- > This patch set optimizes qede_{rx,tx}_entry and introduces > rte_pktmbuf_free_bulk in qede_process_tx_compl. The overall performance > improvement depends on t

Re: [dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-22 Thread Andrew Rybchenko
On 3/22/21 7:53 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Monday, March 22, 2021 4:02 PM >> To: Ananyev, Konstantin ; Yigit, Ferruh >> ; Lijun Ou ; >> tho...@monjalon.net >> Cc: dev@dpdk.org; linux...@openeuler.org; Andrew Rybchenko >>

Re: [dpdk-dev] [PATCH 1/2] net/sfc: improve tunnel TSO mask calculation

2021-03-22 Thread Ferruh Yigit
On 3/11/2021 12:25 PM, Andrew Rybchenko wrote: Corresponding tunnel TSO is not supported if the tunnel is not supported. Signed-off-by: Andrew Rybchenko Series applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-22 Thread Ananyev, Konstantin
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, March 22, 2021 4:02 PM > To: Ananyev, Konstantin ; Yigit, Ferruh > ; Lijun Ou ; > tho...@monjalon.net > Cc: dev@dpdk.org; linux...@openeuler.org; Andrew Rybchenko > ; David Marchand > ; Ray Kinsella ; Luca Boccassi > > Sub

Re: [dpdk-dev] [PATCH v2 01/10] ethdev: reuse header definition in flow pattern item ETH

2021-03-22 Thread Ferruh Yigit
On 3/12/2021 11:07 AM, Ivan Malov wrote: One ought to reuse existing header structs in flow items. This particular item contains non-header fields, so it's important to keep the header fields in a separate struct. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreto

Re: [dpdk-dev] [PATCH v2 4/4] event/octeontx2: timer always use virtual counter

2021-03-22 Thread Jerin Jacob
On Sun, Mar 21, 2021 at 2:20 PM wrote: > > From: Pavan Nikhilesh > > Use virtual counter for estimating current bucket as PMU cannot be > reliably used to estimate time. > > Signed-off-by: Pavan Nikhilesh There is a genuine Travis build issue with this patch. Please check http://patches.dpdk.

Re: [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson

2021-03-22 Thread Nick Connolly
meson guarantees this is portable, so this also allows us to remove a is_windows switch. Hi Gabriel, On Windows, there are at least three different compilation options: * MinGW-w64 with posix threads * MinGW-w64 with win32 threads (different download) * Clang without threads support The

Re: [dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-22 Thread Andrew Rybchenko
On 3/22/21 6:45 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev On Behalf Of Andrew Rybchenko >> Sent: Monday, March 22, 2021 2:49 PM >> To: Yigit, Ferruh ; Lijun Ou ; >> tho...@monjalon.net >> Cc: dev@dpdk.org; linux...@openeuler.org; Andrew Rybchenko >> ; David

Re: [dpdk-dev] [PATCH v5 1/6] net/ark: update pkt director initial state

2021-03-22 Thread Ferruh Yigit
On 3/18/2021 5:36 PM, Ed Czeck wrote: Fixes: b33ccdb17f55 ("net/ark: provide API for hardware modules MPU RQP and pktdir") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck Series applied to dpdk-next-net/main, thanks. Release note updates distributed into relevant patches while merging.

Re: [dpdk-dev] [EXT] Re: [PATCH v2 0/2] qede: 2020-02 minor fixes

2021-03-22 Thread Igor Russkikh
>> Patch Series ACKed, >> Acked-by: Devendra Singh Rawat > > Fixed the check-git-log.sh issues and Applied to > dpdk-next-net-mrvl/for-main. Thanks Thanks, Jerin, for taking care of that! Igor

[dpdk-dev] [PATCH] net/mlx5: add Rx checksum offload flag return bad

2021-03-22 Thread Jiawei Zhu
From: Jiawei Zhu When open the rx checksum offload and receive the wrong checksum, add the ol_flags return bad. And it's not best to use multiplication and division here. Signed-off-by: Jiawei Zhu --- drivers/net/mlx5/mlx5_rxtx.c | 17 ++--- drivers/net/mlx5/mlx5_utils.h | 6

Re: [dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-22 Thread Ananyev, Konstantin
> -Original Message- > From: dev On Behalf Of Andrew Rybchenko > Sent: Monday, March 22, 2021 2:49 PM > To: Yigit, Ferruh ; Lijun Ou ; > tho...@monjalon.net > Cc: dev@dpdk.org; linux...@openeuler.org; Andrew Rybchenko > ; David Marchand > ; Ray Kinsella ; Luca Boccassi > > Subject: R

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-22 Thread Dmitry Kozlyuk
2021-03-22 09:34 (UTC+), Bruce Richardson: > On Mon, Mar 22, 2021 at 09:38:59AM +0100, Gabriel Ganne wrote: > > WARNING: Project targetting '>= 0.47.1' but tried to use feature introduced > > in '0.48.0': console arg in custom_target > > > > console argument is used within kernel/linu

[dpdk-dev] [PATCH] raw/octeontx2_dma: fix unavailable PCI device in dpivf

2021-03-22 Thread Radha Mohan Chintakuntla
Add PCI device to dpivf structure. Fixes: 4495bd887d38 ("raw/octeontx2_dma: support multiple DPI blocks") Signed-off-by: Radha Mohan Chintakuntla --- drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c b/dr

Re: [dpdk-dev] [RFC] ethdev: introduce conntrack flow action and item

2021-03-22 Thread Andrew Rybchenko
On 3/18/21 10:30 AM, Bing Zhao wrote: > This commit introduced the conntrack action and item. > > Usually the HW offloading is stateless. For some stateful offloading > like a TCP connection, HW module will help provide the ability of a > full offloading w/o SW participation after the connection w

Re: [dpdk-dev] [PATCH 6/7] raw/octeontx2: enable build only for 64bit Linux

2021-03-22 Thread Radha Mohan
On Thu, Feb 25, 2021 at 10:33 PM wrote: > > From: Pavan Nikhilesh > > Due to Linux kernel dependency, only enable build for 64bit Linux. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/raw/octeontx2_dma/meson.build | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff -

Re: [dpdk-dev] [RFC] ethdev: introduce action context APIs

2021-03-22 Thread Andrew Rybchenko
On 3/17/21 7:10 PM, Bing Zhao wrote: > Hi Thomas, > >> -Original Message- >> From: Thomas Monjalon >> Sent: Wednesday, March 17, 2021 4:29 PM >> To: Bing Zhao >> Cc: Ori Kam ; ferruh.yi...@intel.com; >> andrew.rybche...@oktetlabs.ru; dev@dpdk.org >> Subject: Re: [RFC] ethdev: introduce a

Re: [dpdk-dev] [PATCH v2 0/2] qede: 2020-02 minor fixes

2021-03-22 Thread Jerin Jacob
On Mon, Mar 22, 2021 at 10:56 AM Devendra Singh Rawat wrote: > > > > > -Original Message- > > From: Igor Russkikh > > Sent: Friday, March 19, 2021 3:17 PM > > To: dev@dpdk.org > > Cc: Rasesh Mody ; Devendra Singh Rawat > > ; Igor Russkikh > > Subject: [PATCH v2 0/2] qede: 2020-02 minor f

Re: [dpdk-dev] [RFC] ethdev: introduce action context APIs

2021-03-22 Thread Andrew Rybchenko
On 3/17/21 11:28 AM, Thomas Monjalon wrote: > 17/03/2021 08:59, Bing Zhao: >> The new functions rte_flow_action_ctx* that were added will replace >> the curret shared functions rte_flow_shared_action_*. >> - rte_flow_shared_action_create >> - rte_flow_shared_action_destroy >> - rte_flow_share

Re: [dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-22 Thread Andrew Rybchenko
On 3/22/21 12:22 PM, Ferruh Yigit wrote: > On 3/18/2021 12:25 PM, Lijun Ou wrote: >> Currently, upper-layer application could get queue state only >> through pointers such as dev->data->tx_queue_state[queue_id], >> this is not the recommended way to access it. So this patch >> add get queue state w

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-22 Thread Christian Ehrhardt
On Mon, Mar 22, 2021 at 1:25 PM Thomas Monjalon wrote: > > 22/03/2021 12:59, Luca Boccassi: > > On Mon, 2021-03-22 at 11:41 +, Bruce Richardson wrote: > > > On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt wrote: > > > > On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil > > > > wrote:

[dpdk-dev] [PATCH v2 3/3] meson: remove unnecessary explicit link to libpcap

2021-03-22 Thread Gabriel Ganne
libpcap is already found and registered as a dependency by meson, and the dependency is already correctly used in librte_port. This line is just unnecessary. It also has the side effect of messing with the meson link line: dpdk link will be declared twice: manually and then through pkg-config. If

[dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson

2021-03-22 Thread Gabriel Ganne
meson guarantees this is portable, so this also allows us to remove a is_windows switch. Link: https://mesonbuild.com/howtox.html#enable-threads Signed-off-by: Gabriel Ganne --- config/meson.build | 5 + lib/librte_metrics/meson.build | 2 ++ lib/librte_telemetry/meson.build

[dpdk-dev] [PATCH v2 1/3] meson: fix minimum required meson version

2021-03-22 Thread Gabriel Ganne
WARNING: Project targeting '>= 0.47.1' but tried to use feature introduced in '0.48.0': console arg in custom_target console argument is used within kernel/linux/kni/meson.build Update documentation and travis setup script accordingly. Signed-off-by: Gabriel Ganne --- .ci/linux-setup.

Re: [dpdk-dev] [PATCH v5 1/8] net/hns3: support runtime config to select IO burst func

2021-03-22 Thread Ferruh Yigit
On 3/22/2021 1:58 PM, Ferruh Yigit wrote: On 3/19/2021 1:07 AM, Min Hu (Connor) wrote: From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate function based on offload configuration. Most applications such as l2fwd/l3fwd don't p

Re: [dpdk-dev] [PATCH v5 1/8] net/hns3: support runtime config to select IO burst func

2021-03-22 Thread Ferruh Yigit
On 3/19/2021 1:07 AM, Min Hu (Connor) wrote: From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate function based on offload configuration. Most applications such as l2fwd/l3fwd don't provide the means to change offload configur

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-22 Thread David Marchand
On Mon, Mar 22, 2021 at 9:39 AM Gabriel Ganne wrote: > > WARNING: Project targetting '>= 0.47.1' but tried to use feature introduced > in '0.48.0': console arg in custom_target > > console argument is used within kernel/linux/kni/meson.build > > Signed-off-by: Gabriel Ganne > --- > meso

Re: [dpdk-dev] [PATCH v2] net/ice: fix unchecked return value

2021-03-22 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Friday, February 26, 2021 3:22 PM > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Cc: Wu, Wenjun1 ; sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix unchecked return value > > Fix unchecked return values reported by coverity. > >

Re: [dpdk-dev] [PATCH] net/mlx5: support RSS expansion for IPv6 GRE

2021-03-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Jack Min > Sent: Thursday, March 18, 2021 1:04 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > Yongseok Koh ; NBU-Contact-N?lio Laranjeiro > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: support

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-22 Thread Thomas Monjalon
22/03/2021 12:59, Luca Boccassi: > On Mon, 2021-03-22 at 11:41 +, Bruce Richardson wrote: > > On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt wrote: > > > On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil > > > wrote: > > > > Hi Christian, Ilya > > > > From: Ilya Maximets > > > > > O

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-22 Thread Luca Boccassi
On Mon, 2021-03-22 at 11:41 +, Bruce Richardson wrote: > On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt wrote: > > On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil wrote: > > > Hi Christian, Ilya > > > > > > > -Original Message- > > > > From: Ilya Maximets > > > > Sent: Thu

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-22 Thread Bruce Richardson
On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt wrote: > On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil wrote: > > > > Hi Christian, Ilya > > > > > -Original Message- > > > From: Ilya Maximets > > > Sent: Thursday, March 18, 2021 8:18 PM > > > To: Pai G, Sunil ; Christian Ehrha

Re: [dpdk-dev] Questions about keeping CRC

2021-03-22 Thread Min Hu (Connor)
Hi, Lance ,Stephen and Ferruh, Got it, thanks for your reply. 在 2021/3/22 18:53, Ferruh Yigit 写道: On 3/19/2021 5:02 PM, Lance Richardson wrote: On Fri, Mar 19, 2021 at 12:07 PM Stephen Hemminger wrote: On Fri, 19 Mar 2021 20:13:20 +0800 "Min Hu (Connor)" wrote: Hi, all,    DPD

Re: [dpdk-dev] [PATCH v4] app/testpmd: support multi-process

2021-03-22 Thread Ferruh Yigit
On 3/22/2021 7:07 AM, Min Hu (Connor) wrote: From: Lijun Ou This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a

Re: [dpdk-dev] [EXT] Re: [PATCH v4 2/8] eventdev: introduce event vector Rx capability

2021-03-22 Thread Kinsella, Ray
On 22/03/2021 10:07, Pavan Nikhilesh Bhagavatula wrote: > >> On 19/03/2021 20:57, pbhagavat...@marvell.com wrote: >>> From: Pavan Nikhilesh >>> >>> Introduce event ethernet Rx adapter event vector capability. >>> >>> If an event eth Rx adapter has the capability of >>> RTE_EVENT_ETH_RX_ADAPTER

Re: [dpdk-dev] Questions about keeping CRC

2021-03-22 Thread Ferruh Yigit
On 3/19/2021 5:02 PM, Lance Richardson wrote: On Fri, Mar 19, 2021 at 12:07 PM Stephen Hemminger wrote: On Fri, 19 Mar 2021 20:13:20 +0800 "Min Hu (Connor)" wrote: Hi, all, DPDK has introduced one offload: DEV_RX_OFFLOAD_KEEP_CRC. It means that the device has the ablility of keeping

Re: [dpdk-dev] [PATCH 3/3] drivers: align log names

2021-03-22 Thread David Marchand
On Wed, Mar 10, 2021 at 3:02 PM Thomas Monjalon wrote: > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > index 6a1b44bc77..bf7afe4610 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -25,7 +25,7 @@ > > #include "base/ifcvf.h" > >

Re: [dpdk-dev] DEV Ask For Help about patch sumbit

2021-03-22 Thread Ferruh Yigit
On 3/19/2021 3:27 AM, caowe...@mucse.com wrote: Hi Ferruh I’am a developer of MuChuang IIC. Welcome to reach us on website http://www.mucse.com.// Now we want to support our 10/40 Ethernet Nic and then continue the development and maintenance in community. But I don’t know  the first thing

Re: [dpdk-dev] [PATCH v2 01/10] ethdev: reuse header definition in flow pattern item ETH

2021-03-22 Thread Andrew Rybchenko
On 3/22/21 12:01 PM, Ferruh Yigit wrote: > On 3/17/2021 6:40 AM, Andrew Rybchenko wrote: >> On 3/16/21 8:38 PM, Ferruh Yigit wrote: >>> On 3/12/2021 11:07 AM, Ivan Malov wrote: One ought to reuse existing header structs in flow items. This particular item contains non-header fields, so it

Re: [dpdk-dev] [EXT] Re: [PATCH v4 2/8] eventdev: introduce event vector Rx capability

2021-03-22 Thread Pavan Nikhilesh Bhagavatula
>On 19/03/2021 20:57, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Introduce event ethernet Rx adapter event vector capability. >> >> If an event eth Rx adapter has the capability of >> RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx >queue >> can be configured to enab

Re: [dpdk-dev] [RFC] eventdev: introduce event dispatcher

2021-03-22 Thread Mattias Rönnblom
On 2021-03-15 16:00, Van Haaren, Harry wrote: >> -Original Message- >> From: dev On Behalf Of Mattias Rönnblom >> Sent: Monday, March 15, 2021 2:45 PM >> To: Jerin Jacob >> Cc: Jerin Jacob ; dpdk-dev ; Richardson, >> Bruce >> Subject: Re: [dpdk-dev] [RFC] eventdev: introduce event dispat

Re: [dpdk-dev] [PATCH v3 1/3] eventdev: introduce adapter flags for periodic mode

2021-03-22 Thread Jerin Jacob
On Wed, Mar 17, 2021 at 11:37 PM Carrillo, Erik G wrote: > > > -Original Message- > > From: Shijith Thotton > > Sent: Wednesday, March 17, 2021 3:04 AM > > To: Carrillo, Erik G > > Cc: Shijith Thotton ; Pavan Nikhilesh > > ; Jerin Jacob ; > > dev@dpdk.org > > Subject: [PATCH v3 1/3] even

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-22 Thread Christian Ehrhardt
On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil wrote: > > Hi Christian, Ilya > > > -Original Message- > > From: Ilya Maximets > > Sent: Thursday, March 18, 2021 8:18 PM > > To: Pai G, Sunil ; Christian Ehrhardt > > ; Stokes, Ian ; > > Ilya Maximets ; Govindharajan, Hariprasad > > > > Cc: R

Re: [dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-22 Thread oulijun
在 2021/3/22 17:22, Ferruh Yigit 写道: On 3/18/2021 12:25 PM, Lijun Ou wrote: Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add get queue state when call rte_

Re: [dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-22 Thread Kinsella, Ray
On 22/03/2021 09:22, Ferruh Yigit wrote: > On 3/18/2021 12:25 PM, Lijun Ou wrote: >> Currently, upper-layer application could get queue state only >> through pointers such as dev->data->tx_queue_state[queue_id], >> this is not the recommended way to access it. So this patch >> add get queue stat

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-22 Thread Bruce Richardson
On Mon, Mar 22, 2021 at 09:38:59AM +0100, Gabriel Ganne wrote: > WARNING: Project targetting '>= 0.47.1' but tried to use feature introduced > in '0.48.0': console arg in custom_target > > console argument is used within kernel/linux/kni/meson.build > > Signed-off-by: Gabriel Ganne > --

Re: [dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-22 Thread Ferruh Yigit
On 3/18/2021 12:25 PM, Lijun Ou wrote: Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add get queue state when call rte_eth_rx_queue_info_get and rte_eth_tx_que

Re: [dpdk-dev] [PATCH v4 2/8] eventdev: introduce event vector Rx capability

2021-03-22 Thread Kinsella, Ray
On 19/03/2021 20:57, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Introduce event ethernet Rx adapter event vector capability. > > If an event eth Rx adapter has the capability of > RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx queue > can be configured to enable ev

Re: [dpdk-dev] [EXT] Re: [PATCH v4 1/8] eventdev: introduce event vector capability

2021-03-22 Thread Pavan Nikhilesh Bhagavatula
>On 19/03/2021 20:57, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Introduce rte_event_vector datastructure which is capable of holding >> multiple uintptr_t of the same flow thereby allowing applications >> to vectorize their pipeline and reducing the complexity of pipelining >>

Re: [dpdk-dev] [PATCH v4 1/8] eventdev: introduce event vector capability

2021-03-22 Thread Kinsella, Ray
On 19/03/2021 20:57, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Introduce rte_event_vector datastructure which is capable of holding > multiple uintptr_t of the same flow thereby allowing applications > to vectorize their pipeline and reducing the complexity of pipelining > th

Re: [dpdk-dev] [PATCH v4 11/11] app/testpmd: fix usage text

2021-03-22 Thread Bing Zhao
Hi Thomas, > -Original Message- > From: Jens Freimann > Sent: Monday, March 22, 2021 4:27 PM > To: NBU-Contact-Thomas Monjalon > Cc: dev@dpdk.org; david.march...@redhat.com; sta...@dpdk.org; Ajit > Khaparde ; Bruce Richardson > ; Andrew Rybchenko > ; Xiaoyun Li ; > Ori Kam ; Bing Zhao ;

Re: [dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.

2021-03-22 Thread Ferruh Yigit
On 3/18/2021 6:12 AM, Wangxiaoyun (Cloud) wrote: Hi Ferruh, For secondary process fix,you can refer to this patch "net/hinic: fix coredump when PMD used by fstack". Thanks Got it, thanks for new version. I am marking the old one as superseded. For reference, the old one is: https://patc

Re: [dpdk-dev] [PATCH v2 01/10] ethdev: reuse header definition in flow pattern item ETH

2021-03-22 Thread Ferruh Yigit
On 3/17/2021 6:40 AM, Andrew Rybchenko wrote: On 3/16/21 8:38 PM, Ferruh Yigit wrote: On 3/12/2021 11:07 AM, Ivan Malov wrote: One ought to reuse existing header structs in flow items. This particular item contains non-header fields, so it's important to keep the header fields in a separate str

Re: [dpdk-dev] [PATCH v7 02/17] buildtools: fix build with busybox

2021-03-22 Thread Kinsella, Ray
On 22/03/2021 08:55, Thomas Monjalon wrote: > 22/03/2021 09:52, Kinsella, Ray: >> On 19/03/2021 14:57, Thomas Monjalon wrote: >>> --- a/buildtools/check-symbols.sh >>> +++ b/buildtools/check-symbols.sh >>> -DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXX.objdump) >>> +DUMPFILE=$(mktemp -t dpdk.${0##*/}.X

Re: [dpdk-dev] [PATCH v5 1/5] eal: add sleep API

2021-03-22 Thread Kinsella, Ray
On 20/03/2021 11:27, Dmitry Kozlyuk wrote: > POSIX sleep(3) is missing from Windows. > Add generic rte_thread_sleep() to suspend current OS thread. > > Signed-off-by: Dmitry Kozlyuk > Acked-by: Khoa To > --- > lib/librte_eal/common/eal_common_timer.c | 5 +++-- > lib/librte_eal/include/rte_t

Re: [dpdk-dev] [PATCH v7 02/17] buildtools: fix build with busybox

2021-03-22 Thread Thomas Monjalon
22/03/2021 09:52, Kinsella, Ray: > On 19/03/2021 14:57, Thomas Monjalon wrote: > > --- a/buildtools/check-symbols.sh > > +++ b/buildtools/check-symbols.sh > > -DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXX.objdump) > > +DUMPFILE=$(mktemp -t dpdk.${0##*/}.XX) > > Does it make sense to change it to >

Re: [dpdk-dev] [PATCH v7 02/17] buildtools: fix build with busybox

2021-03-22 Thread Kinsella, Ray
On 19/03/2021 14:57, Thomas Monjalon wrote: > If using busybox for mktemp and awk (as in Alpine), > some bugs prevent the script from running: > > 1/ It seems busybox mktemp requires the pattern to have at least > 6 X and no other suffix. > The same has been fixed for other scripts in the past:

[dpdk-dev] [PATCH 3/3] meson: remove unnecessary explicit link to libpcap

2021-03-22 Thread Gabriel Ganne
libpcap is already found and registered as a dependency by meson, and the dependency is already correctly used in librte_port. This line is just unnecessary. It also has the side effect of messing with the meson link line: dpdk link will be declared twice: manually and then through pkg-config. If

[dpdk-dev] [PATCH 2/3] meson: use threads dependency as provided by meson

2021-03-22 Thread Gabriel Ganne
meson guarantees this is portable, so this also allows us to remove a is_windows switch. Link: https://mesonbuild.com/howtox.html#enable-threads Signed-off-by: Gabriel Ganne --- config/meson.build | 5 + lib/librte_metrics/meson.build | 2 ++ lib/librte_telemetry/meson.build

[dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-22 Thread Gabriel Ganne
WARNING: Project targetting '>= 0.47.1' but tried to use feature introduced in '0.48.0': console arg in custom_target console argument is used within kernel/linux/kni/meson.build Signed-off-by: Gabriel Ganne --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [dpdk-dev] [PATCH v4 11/11] app/testpmd: fix usage text

2021-03-22 Thread Jens Freimann
On Sun, Mar 21, 2021 at 11:31:15PM +0100, Thomas Monjalon wrote: The options help text was including an incomplete and redundant summary of the options before explaining each. The summary is dropped. The details of the option --hairpin-mode had an extra space, breaking the alignment with the nex

[dpdk-dev] [PATCH v2 2/2] examples/vhost_blk: Check protocol features before getting inflight info

2021-03-22 Thread Keiichi Watanabe
Avoid calling rte_vhost_get_vhost_ring_inflight() and rte_vhost_get_vring_base_from_inflight() when VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD is not set. Signed-off-by: Keiichi Watanabe --- examples/vhost_blk/vhost_blk.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-)

[dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated protocol features

2021-03-22 Thread Keiichi Watanabe
Add rte_vhost_get_negotiated_protocol_features, which returns a set of enabled protocol features. Signed-off-by: Keiichi Watanabe --- lib/librte_vhost/rte_vhost.h | 15 +++ lib/librte_vhost/version.map | 1 + lib/librte_vhost/vhost.c | 14 ++ 3 files changed, 30 inse

[dpdk-dev] [PATCH v2 0/2] vhost: Add API to get negotiated protocol features

2021-03-22 Thread Keiichi Watanabe
This patchset adds an API to get negotiated vhost protocol features in librte_vhost so we can use it to check if an optional feature is enabled. v1: https://mails.dpdk.org/archives/dev/2021-February/199044.html Keiichi Watanabe (2): vhost: Add API to get negotiated protocol features examples/

[dpdk-dev] [PATCH v4] app/testpmd: support multi-process

2021-03-22 Thread Min Hu (Connor)
From: Lijun Ou This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ --rxq=4 --t