Re: [dpdk-dev] [PATCH 1/6] baseband: introduce NXP LA12xx driver

2021-03-18 Thread Hemant Agrawal
On 3/18/2021 8:23 PM, David Marchand wrote: On Thu, Mar 18, 2021 at 7:38 AM Hemant Agrawal wrote: This patch introduce the baseband device drivers for NXP's LA1200 series software defined baseband modem. Such a series deserves a cover letter. Ok. I will do that in v2. You should copy bbdev

[dpdk-dev] [PATCH] net/octeontx2: add support for rte_flow_item_raw

2021-03-18 Thread psatheesh
From: Satheesh Paul Add support for rte_flow_item_raw to parse custom L2 and L3 protocols. Signed-off-by: Satheesh Paul --- doc/guides/nics/octeontx2.rst | 39 +++- drivers/common/octeontx2/hw/otx2_npc.h | 2 + drivers/common/octeontx2/otx2_mbox.h| 6 +- drive

[dpdk-dev] [PATCH] net/bnxt: check return value

2021-03-18 Thread Ajit Khaparde
Check return value of rte_kvargs_process() Coverity issue: 357765 Fixes: ba404aacc5cf ("net/bnxt: set maximum flow count") Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats") Fixes: 7b0940653720 ("net/bnxt: support host memory based TruFlow") Cc: sta...@dpdk.org Signed-off-by: Aj

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix unsupported handling in PTP

2021-03-18 Thread Ajit Khaparde
On Thu, Mar 18, 2021 at 2:13 AM Kalesh A P wrote: > > From: Kalesh AP > > Fixed to return error when PTP support is not supported on the port. > Also, removed an unnecessary check inside bnxt_get_rx_ts(). > > Fixes: b11cceb83a34 ("net/bnxt: support timesync") > Cc: sta...@dpdk.org > > Signed-off-

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix link state operations

2021-03-18 Thread Ajit Khaparde
On Thu, Mar 18, 2021 at 2:13 AM Kalesh A P wrote: > > From: Kalesh AP > > VFs does not have the privilege to change link configuration. > But the driver silently returns success to these ethdev callbacks > without actually issuing the HWRM command to bring the link up/down. > > Fixes: 5c206086fea

Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value

2021-03-18 Thread Xiaozhen Ban
> > -Original Message- > > From: Xiaozhen Ban > > Sent: Thursday, March 18, 2021 19:44 > > To: Guo, Jia ; Wang, Haiyue > > Cc: dev at dpdk.org; stable at dpdk.org > > Subject: RE: RE: [PATCH] net/e1000: fix filter control return value > > > > OK, but I think this bug affects all stable r

Re: [dpdk-dev] [PATCH] net/bnxt: fix RSS context cleanup

2021-03-18 Thread Ajit Khaparde
On Wed, Mar 17, 2021 at 5:47 PM Ajit Khaparde wrote: > > The PMD is allocating an extra RSS context with each port start. > But it is freeing only one RSS context during port stop. So at some point > we run out of RSS contexts when we do multiple port stop/start sequences. > bnxt_hwrm_vnic_ctx_all

[dpdk-dev] [PATCH] net/i40e: fix inappropriate config during flow validate

2021-03-18 Thread Murphy Yang
The configuration of FDIR input set should not be set during flow validate. It should be set when flow create. Fixes: fe5d0e85b713 ("net/i40e: fix flow director flex configuration") Fixes: 15018d79f0be ("net/i40e: add FDIR support for GTP-C and GTP-U") Signed-off-by: Murphy Yang --- drivers/net

Re: [dpdk-dev] [PATCH 1/6] net/ngbe: add build and doc infrastructure

2021-03-18 Thread Jiawen Wu
On Thursday, March 18, 2021 8:05 PM, Thomas Monjalon wrote: > 18/03/2021 10:32, Jiawen Wu: > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -886,6 +886,12 @@ F: drivers/net/txgbe/ > > F: doc/guides/nics/txgbe.rst > > F: doc/guides/nics/features/txgbe.ini > > > > +Wangxun txgbe > > +M: Jiawen Wu

Re: [dpdk-dev] [PATCH v3 1/8] net/hns3: support runtime config to select IO burst func

2021-03-18 Thread Min Hu (Connor)
在 2021/3/17 23:28, Ferruh Yigit 写道: On 3/17/2021 1:14 AM, Min Hu (Connor) wrote: 在 2021/3/16 20:40, Ferruh Yigit 写道: On 3/12/2021 11:51 AM, Min Hu (Connor) wrote: From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate func

[dpdk-dev] [PATCH v5 1/8] net/hns3: support runtime config to select IO burst func

2021-03-18 Thread Min Hu (Connor)
From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate function based on offload configuration. Most applications such as l2fwd/l3fwd don't provide the means to change offload configuration, so it will use the auto selection's io b

[dpdk-dev] [PATCH v5 3/8] net/hns3: adjust the format of RAS related structures

2021-03-18 Thread Min Hu (Connor)
From: Hongbo Zheng Adjust the format of hns3 RAS related structures to resolve the static check warnings. Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- v3: - change code styles. --- drivers/net/hns3/hns3_intr.c | 2126 -- 1 file changed

[dpdk-dev] [PATCH v5 2/8] net/hns3: support for outer UDP cksum

2021-03-18 Thread Min Hu (Connor)
From: Chengchang Tang Kunpeng930 support outer UDP cksum, this patch add support for it. Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- doc/guides/rel_notes/release_21_05.rst | 1 + drivers/net/hns3/hns3_cmd.c| 3 ++ drivers/net/hns3/hns3_ethdev.c | 3

[dpdk-dev] [PATCH v5 4/8] net/hns3: delete redundant xstats RAS statistics

2021-03-18 Thread Min Hu (Connor)
From: Hongbo Zheng The current RAS code stores the reported RAS statistics in xstats. This part of statistics is of little use in practice, and because of the change of RAS scheme on Kunpeng930, the driver can not obtain the RAS information any more, so this patch delete these redundant RAS stati

[dpdk-dev] [PATCH v5 5/8] net/hns3: support imissed stats for PF/VF

2021-03-18 Thread Min Hu (Connor)
This patch added function level imissed stats for PF and VF. In kunpeng920, imissed is supported, only including RPU drop stats in PF. In kunpeng930, imissed is supported,including RPU drop stats and SSU drop stats in PF. Signed-off-by: Min Hu (Connor) --- v4: - rename variable name oq_glb_drop_c

[dpdk-dev] [PATCH v5 8/8] net/hns3: support query Rx descriptor status

2021-03-18 Thread Min Hu (Connor)
From: Hongbo Zheng Add support for query Rx descriptor status in hns3 driver. Check the descriptor specified and provide the status information of the corresponding descriptor. Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 1 + doc/gu

[dpdk-dev] [PATCH v5 6/8] net/hns3: support oerrors stats in PF

2021-03-18 Thread Min Hu (Connor)
This patch added oerrors stats for PF in kunpeng930. Signed-off-by: Min Hu (Connor) --- v4: - rename variable name oq_glb_drop_cnt to oq_drop_cnt. --- drivers/net/hns3/hns3_ethdev.h | 1 + drivers/net/hns3/hns3_stats.c | 64 +- 2 files changed, 64 insert

[dpdk-dev] [PATCH v5 7/8] net/hns3: support query Tx descriptor status

2021-03-18 Thread Min Hu (Connor)
From: Hongbo Zheng Add support for query Tx descriptor status in hns3 driver. Check the descriptor specified and provide the status information of the corresponding descriptor. Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 1 + doc/gu

[dpdk-dev] [PATCH v5 0/8] features and bugfixes for hns3

2021-03-18 Thread Min Hu (Connor)
This series add four features according to the 21.05 roadmap, and also two cleanups added. Chengchang Tang (1): net/hns3: support for outer UDP cksum Chengwen Feng (1): net/hns3: support runtime config to select IO burst func Hongbo Zheng (4): net/hns3: adjust the format of RAS related str

[dpdk-dev] [PATCH 1/1] net/bnxt: fix Rx buffer posting

2021-03-18 Thread Lance Richardson
Remove early buffer posting logic from burst receive loop to address several issues: - Posting receive descriptors without first posting completion entries risks overflowing the completion queue. - Posting receive descriptors without updating rx_raw_prod creates the possibility that

[dpdk-dev] [PATCH 1/1] net/bnxt: fix handling of null flow mask

2021-03-18 Thread Lance Richardson
When the mask field of an rte_flow pattern item is NULL, the default mask for that item type should be used. Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_flow.c | 47 +++-

[dpdk-dev] [PATCH 1/1] net/bnxt: fix transmit length hint threshold

2021-03-18 Thread Lance Richardson
Use correct threshold when selecting "greater than or equal to 2K" length hint. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_txr.c | 2 +- 1 file

[dpdk-dev] [RFC 3/3] net/virtio: add MAC device config getter and setter

2021-03-18 Thread Maxime Coquelin
This patch uses the new device config ops to get and set the MAC address if supported. If a valid MAC address is passed as devarg of the Virtio-user PMD, the driver will try to store it in the device config space. Otherwise the one provided in the device config space will be used, if available. S

[dpdk-dev] [RFC 2/3] net/virtio: add device config support to vDPA

2021-03-18 Thread Maxime Coquelin
This patch introduces two virtio-user callbacks to get and set device's config, and implements it for vDPA backends. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h | 3 + drivers/net/virtio/virtio_user/vhost_vdpa.c | 69 + 2 files changed, 72

[dpdk-dev] [RFC 1/3] net/virtio: keep device and frontend features separated

2021-03-18 Thread Maxime Coquelin
This patch is preliminary rework to add support for getting and setting device's config space. In order to get or set a device config such as its MAC address, we need to know whether the device itself support the feature, or if it is emulated by the frontend. Signed-off-by: Maxime Coquelin ---

[dpdk-dev] [RFC 0/3] net/virtio: add vdpa device config support

2021-03-18 Thread Maxime Coquelin
This patch adds vDPA device config space requests support. For now, it only adds MAC address get and set. It may be extended in next revision to support other configs like link state. Regarding the MAC selection strategy, if devargs MAC address is set by the user and valid, the driver tries to sto

Re: [dpdk-dev] [PATCH v2] bus/pci: fix Windows kernel driver categories

2021-03-18 Thread Ranjit Menon
On 3/18/2021 3:48 AM, Thomas Monjalon wrote: In Windows probing, the value RTE_PCI_KDRV_NONE was used instead of RTE_PCI_KDRV_UNKNOWN. This value covers the mlx case where the kernel driver is in place, offering a bifurcated mode to the userspace driver. When the kernel driver is listed as unknow

Re: [dpdk-dev] [PATCH] bus/pci: fix Windows kernel driver categories

2021-03-18 Thread Ranjit Menon
On 3/18/2021 12:49 AM, Thomas Monjalon wrote: 18/03/2021 00:17, Ranjit Menon: Hi Thomas, On 3/16/2021 4:11 PM, Thomas Monjalon wrote: In Windows probing, the value RTE_PCI_KDRV_NONE was used instead of RTE_PCI_KDRV_UNKNOWN (mlx case), and RTE_PCI_KDRV_NIC_UIO (FreeBSD) was re-used instead of

[dpdk-dev] Arm roadmap for 21.05

2021-03-18 Thread Honnappa Nagarahalli
(Bcc: Arm internal stake holders) Hello, Following are the work items planned for 21.05: 1) Performance improvements in L3fwd example. 2) Use C11 atomic built-ins in EAL, Service Core library and MLX4/MLX5 PMDs. 3) Enhance mempool library with additional debug counters. 4) Meson build imp

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

2021-03-18 Thread Ilya Maximets
On 3/18/21 8:47 PM, Ilya Maximets wrote: > On 3/18/21 6:52 PM, Stefan Hajnoczi wrote: >> On Wed, Mar 17, 2021 at 09:25:26PM +0100, Ilya Maximets wrote: >> Hi, >> Some questions to understand the problems that SocketPair Broker solves: >> >>> Even more configuration tricks required in order to share

Re: [dpdk-dev] [PATCH 1/3] Add EAL threads API

2021-03-18 Thread Tyler Retzlaff
On Thu, Mar 18, 2021 at 02:48:01PM +, Tal Shnaiderman wrote: > > I don't know if this table is needed, the approach should be to have the > return value/rte_errno identical between the OSs. > And having the specific OS errno printed. the underlying problem here is that dpdk is adopting linux

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

2021-03-18 Thread Ilya Maximets
On 3/18/21 6:52 PM, Stefan Hajnoczi wrote: > On Wed, Mar 17, 2021 at 09:25:26PM +0100, Ilya Maximets wrote: > Hi, > Some questions to understand the problems that SocketPair Broker solves: > >> Even more configuration tricks required in order to share some sockets >> between different containers a

Re: [dpdk-dev] [PATCH v5 5/5] doc/guides/l3_forward: update documentation for FIB

2021-03-18 Thread Mcnamara, John
> -Original Message- > From: dev On Behalf Of Conor Walsh > Sent: Monday, March 15, 2021 11:35 AM > To: jer...@marvell.com; step...@networkplumber.org; Iremonger, Bernard > ; Ananyev, Konstantin > ; Medvedkin, Vladimir > ; Burakov, Anatoly > > Cc: dev@dpdk.org; Walsh, Conor > Subject:

Re: [dpdk-dev] [PATCH 1/3] Add EAL threads API

2021-03-18 Thread Narcisa Ana Maria Vasile
On Thu, Mar 18, 2021 at 02:48:01PM +, Tal Shnaiderman wrote: > > Subject: [dpdk-dev] [PATCH 1/3] Add EAL threads API > > > > From: Narcisa Vasile > > > > EAL must hide the environment specifics from apps and libraries. > > Add an EAL API for managing threads. > > > > Signed-off-by: Narcisa

Re: [dpdk-dev] [PATCH 1/3] Add EAL threads API

2021-03-18 Thread Narcisa Ana Maria Vasile
On Thu, Mar 18, 2021 at 04:48:49PM +0100, David Marchand wrote: > On Thu, Mar 18, 2021 at 2:01 AM Narcisa Ana Maria Vasile > wrote: > > diff --git a/lib/librte_eal/common/eal_common_thread.c > > b/lib/librte_eal/common/eal_common_thread.c > > index 73a055902..5219e783e 100644 > > --- a/lib/librte

[dpdk-dev] DPDK Release Status Meeting 18/03/2021

2021-03-18 Thread Mcnamara, John
Release status meeting minutes {Date} = :Date: 18 March 2021 :toc: .Agenda: * Release Dates * Subtrees * LTS * Conferences * Opens .Participants: * Arm * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - * `v21.05` dates - P

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-18 Thread Pai G, Sunil
Hi Christian, Ilya > -Original Message- > From: Ilya Maximets > Sent: Thursday, March 18, 2021 8:18 PM > To: Pai G, Sunil ; Christian Ehrhardt > ; Stokes, Ian ; > Ilya Maximets ; Govindharajan, Hariprasad > > Cc: Richardson, Bruce ; Luca Boccassi > ; sta...@dpdk.org; dev ; James Page >

[dpdk-dev] [PATCH v1 6/6] raw/ioat: add bus driver for device scanning automatically

2021-03-18 Thread Bruce Richardson
Rather than using a vdev with args, DPDK can scan and initialize the devices automatically using a bus-type driver. This bus does not need to worry about registering device drivers, rather it can initialize the devices directly on probe. The device instances (queues) to use are detected from /dev

[dpdk-dev] [PATCH v1 5/6] raw/ioat: add api to query remaining ring space

2021-03-18 Thread Bruce Richardson
From: Kevin Laatz Add a new API to query remaining descriptor ring capacity. This API is useful, for example, when an application needs to enqueue a fragmented packet and wants to ensure that all segments of the packet will be enqueued together. Signed-off-by: Kevin Laatz --- drivers/raw/ioat/

[dpdk-dev] [PATCH v1 4/6] raw/ioat: rework SW ring layout

2021-03-18 Thread Bruce Richardson
The ring management in the idxd part of the driver is more complex than it needs to be, tracking individual batches in a ring and having null descriptors as padding to avoid having single-operation batches. This can be simplified by using a regular ring-based layout, with additional overflow at the

[dpdk-dev] [PATCH v1 3/6] raw/ioat: add explicit padding to descriptor struct

2021-03-18 Thread Bruce Richardson
Add an explicit padding field to the end of the descriptor structure so that when the batch descriptor is defined on the stack for perform-ops, the unused space is all zeroed appropriately. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/rte_ioat_rawdev_fns.h | 5 - 1 file changed, 4 in

[dpdk-dev] [PATCH v1 2/6] raw/ioat: add component prefix to log messages

2021-03-18 Thread Bruce Richardson
Add the driver prefix "IOAT" to log messages for the driver. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/ioat_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/raw/ioat/ioat_private.h b/drivers/raw/ioat/ioat_private.h index 6c423811ec..f032d5fe3d 1006

[dpdk-dev] [PATCH v1 1/6] raw/ioat: support limiting queues for idxd PCI device

2021-03-18 Thread Bruce Richardson
When using a full device instance via vfio, allow the user to specify a maximum number of queues to configure rather than always using the max number of supported queues. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/idxd_pci.c | 28 ++-- 1 file changed, 26 inserti

[dpdk-dev] [PATCH v1 0/6] ioat driver updates

2021-03-18 Thread Bruce Richardson
This set contains a series of updates to the ioat driver, described in each of the individual patchsets. Comments would be especially appreciated for the last patch in this set, which converts the existing idxd vdev driver to a bus driver so that probing and scanning can be done automatically. Thi

[dpdk-dev] [PATCH] [RFC] eventdev: introduce crypto adapter enqueue API

2021-03-18 Thread Akhil Goyal
In case an event from a previous stage is required to be forwarded to a crypto adapter and PMD supports internal event port in crypto adapter, exposed via capability RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not have a way to check in the API rte_event_enqueue_burst(), whether it is

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

2021-03-18 Thread Stefan Hajnoczi
On Wed, Mar 17, 2021 at 09:25:26PM +0100, Ilya Maximets wrote: Hi, Some questions to understand the problems that SocketPair Broker solves: > Even more configuration tricks required in order to share some sockets > between different containers and not only with the host, e.g. to > create service c

[dpdk-dev] [PATCH v5 6/6] net/ark: localize internal packet generator code

2021-03-18 Thread Ed Czeck
remove unnecessary includes no functional changes Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 17 ++--- drivers/net/ark/ark_pktchkr.c | 4 drivers/net/ark/ark_pktgen.c | 20 ++-- drivers/net/ark/ark_pktgen.h | 1 + 4 files changed, 17 insertio

[dpdk-dev] [PATCH v5 5/6] net/ark: generalize meta data between FPGA and PMD

2021-03-18 Thread Ed Czeck
In this commit we generalize the movement of user-specified meta data between mbufs and FPGA AXIS tuser fields using user-defined hook functions. - Previous use of PMD dynfields are removed - Remove emptied rte_pmd_ark.h - Hook function added to ark_user_ext - Add hook function calls in Rx and Tx

[dpdk-dev] [PATCH v5 4/6] net/ark: cleanup ark dynamic extension interface

2021-03-18 Thread Ed Czeck
- Rename extension functions with rte_pmd_ark prefix - Update local function documentation Signed-off-by: Ed Czeck --- v3: - split function rename from previous commit v4: - reorder patches renaming before adding v5: - Keep the extension function changes in ark_ext.h --- drivers/net/ark/ark_ethd

[dpdk-dev] [PATCH v5 3/6] net/ark: update internal structs to reflect FPGA updates

2021-03-18 Thread Ed Czeck
- New PCIe IDs using net/ark driver - Update Version IDs and structures specified by hardware - New internal descriptor status for TX - Adjust data placement in RX operations, headroom in retained for segmented mbufs Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 5 ++ drivers/n

[dpdk-dev] [PATCH v5 2/6] net/ark: refactor Rx buffer recovery

2021-03-18 Thread Ed Czeck
Allocate mbufs for Rx path in bulk of at least 64 buffers to improve performance. Allow recovery even without a Rx operation to support lack of buffers in pool. Fixes: be410a861598 ("net/ark: add recovery for lack of mbufs") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- drivers/net/ark/ark_et

[dpdk-dev] [PATCH v5 1/6] net/ark: update pkt director initial state

2021-03-18 Thread Ed Czeck
Fixes: b33ccdb17f55 ("net/ark: provide API for hardware modules MPU RQP and pktdir") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 1 + drivers/net/ark/ark_pktdir.c | 2 +- drivers/net/ark/ark_pktdir.h | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) di

Re: [dpdk-dev] [PATCH 1/3] Add EAL threads API

2021-03-18 Thread David Marchand
On Thu, Mar 18, 2021 at 2:01 AM Narcisa Ana Maria Vasile wrote: > diff --git a/lib/librte_eal/common/eal_common_thread.c > b/lib/librte_eal/common/eal_common_thread.c > index 73a055902..5219e783e 100644 > --- a/lib/librte_eal/common/eal_common_thread.c > +++ b/lib/librte_eal/common/eal_common_thr

Re: [dpdk-dev] [PATCH] eal: fix version macro

2021-03-18 Thread Bruce Richardson
On Thu, Mar 18, 2021 at 03:41:35PM +0100, Thomas Monjalon wrote: > 18/03/2021 13:28, Bruce Richardson: > > On Wed, Mar 17, 2021 at 11:01:25AM +0100, Thomas Monjalon wrote: > > > 17/03/2021 10:48, David Marchand: > > > > On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon > > > > wrote: > > > > > > >

Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value

2021-03-18 Thread Wang, Haiyue
> -Original Message- > From: Xiaozhen Ban > Sent: Thursday, March 18, 2021 19:44 > To: Guo, Jia ; Wang, Haiyue > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: RE: [PATCH] net/e1000: fix filter control return value > > OK, but I think this bug affects all stable release about 6 years b

Re: [dpdk-dev] [PATCH 1/6] baseband: introduce NXP LA12xx driver

2021-03-18 Thread David Marchand
On Thu, Mar 18, 2021 at 7:38 AM Hemant Agrawal wrote: > > This patch introduce the baseband device drivers for NXP's > LA1200 series software defined baseband modem. Such a series deserves a cover letter. You should copy bbdev maintainer and cryptodev subtree maintainer. Quickly looked at the se

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-18 Thread Ilya Maximets
On 3/18/21 2:36 PM, Pai G, Sunil wrote: > Hey Christian, > > > >> back in 19.11.4 these DPDK changes were not picked up as they have broken >> builds as discussed here. >> Later on the communication was that all this works fine now and thereby >> Luca has "reverted the reverts" in 19.11.6 [1].

Re: [dpdk-dev] [PATCH 1/3] Add EAL threads API

2021-03-18 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH 1/3] Add EAL threads API > > From: Narcisa Vasile > > EAL must hide the environment specifics from apps and libraries. > Add an EAL API for managing threads. > > Signed-off-by: Narcisa Vasile > Signed-off-by: Dmitry Malloy > --- Hi Naty, Dmitry, Thank you for a

Re: [dpdk-dev] [PATCH] eal: fix version macro

2021-03-18 Thread Thomas Monjalon
18/03/2021 13:28, Bruce Richardson: > On Wed, Mar 17, 2021 at 11:01:25AM +0100, Thomas Monjalon wrote: > > 17/03/2021 10:48, David Marchand: > > > On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon > > > wrote: > > > > > > > > The macro RTE_VERSION is broken since updated with function calls. > > >

Re: [dpdk-dev] [PATCH] net/mlx5: support RSS expansion for IPv6 GRE

2021-03-18 Thread Matan Azrad
From: Jack Min > Currently RSS expansion only support IPv4 as GRE payload or delivery protocol > (RFC2784). IPv6 as GRE payload or delivery protocol > (RFC7676) is not supported. > > This patch add RSS expansion for RFC7676 so PMD can expand flow item > correctly. > > Fixes: f4b901a46aec ("n

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-18 Thread Pai G, Sunil
Hey Christian, > back in 19.11.4 these DPDK changes were not picked up as they have broken > builds as discussed here. > Later on the communication was that all this works fine now and thereby > Luca has "reverted the reverts" in 19.11.6 [1]. > > But today we were made aware that still no OVS

[dpdk-dev] [PATCH] crypto/qat: fix to small sgl oop min offset

2021-03-18 Thread Arek Kusztal
This commit fixes problem with to small offset when both offsets (auth, cipher) are non zero in digest encrypt case, when using out-of-place and sgl. Fixes: 40002f6c2a24 ("crypto/qat: extend support for digest-encrypted auth-cipher") Cc: sta...@dpdk.org Signed-off-by: Arek Kusztal --- drivers/

Re: [dpdk-dev] [PATCH 21.05] net/virtio: remove duplicate port id from virtio_user

2021-03-18 Thread David Marchand
On Wed, Mar 17, 2021 at 9:04 PM Maxime Coquelin wrote: > > diff --git a/drivers/net/virtio/virtio_user/vhost_user.c > > b/drivers/net/virtio/virtio_user/vhost_user.c > > index ec2c53c8fb..18ae29eed2 100644 > > --- a/drivers/net/virtio/virtio_user/vhost_user.c > > +++ b/drivers/net/virtio/virtio_u

Re: [dpdk-dev] [PATCH] eal: mark version parts API as experimental

2021-03-18 Thread Bruce Richardson
On Wed, Mar 17, 2021 at 04:15:35PM +0100, Thomas Monjalon wrote: > Some functions were introduced in DPDK 21.05 to query the version parts > (prefix, year, month, minor, suffix, release) at runtime. > Per guidelines, these new public functions must be marked with > __rte_experimental and ABI versio

Re: [dpdk-dev] [PATCH] eal: fix version macro

2021-03-18 Thread Bruce Richardson
On Wed, Mar 17, 2021 at 11:01:25AM +0100, Thomas Monjalon wrote: > 17/03/2021 10:48, David Marchand: > > On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon > > wrote: > > > > > > The macro RTE_VERSION is broken since updated with function calls. > > > It is a build-time version number, and must be

[dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-18 Thread Lijun Ou
Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add get queue state when call rte_eth_rx_queue_info_get and rte_eth_tx_queue_info_get API. Note: The hairpin queue

Re: [dpdk-dev] [PATCH 1/6] net/ngbe: add build and doc infrastructure

2021-03-18 Thread Thomas Monjalon
18/03/2021 10:32, Jiawen Wu: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -886,6 +886,12 @@ F: drivers/net/txgbe/ > F: doc/guides/nics/txgbe.rst > F: doc/guides/nics/features/txgbe.ini > > +Wangxun txgbe > +M: Jiawen Wu > +F: drivers/net/ngbe/ > +F: doc/guides/nics/ngbe.rst > +F: doc/guides/ni

Re: [dpdk-dev] [PATCH 5/6] net/ngbe: add log type and error type

2021-03-18 Thread Thomas Monjalon
18/03/2021 10:32, Jiawen Wu: > +#ifdef RTE_LIBRTE_NGBE_DEBUG_RX > +extern int ngbe_logtype_rx; > +#define PMD_RX_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, ngbe_logtype_rx, \ > + "%s(): " fmt "\n", __func__, ##args) > +#else > +#define PMD_RX_LOG(level, fmt, args.

Re: [dpdk-dev] [PATCH v2] bus/pci: fix Windows kernel driver categories

2021-03-18 Thread Tal Shnaiderman
> Subject: [PATCH v2] bus/pci: fix Windows kernel driver categories > > In Windows probing, the value RTE_PCI_KDRV_NONE was used instead of > RTE_PCI_KDRV_UNKNOWN. > This value covers the mlx case where the kernel driver is in place, offering a > bifurcated mode to the userspace driver. > When the

[dpdk-dev] [PATCH v2 2/2] qos: rearrange enqueue procedure

2021-03-18 Thread Konstantin Ananyev
In many usage scenarios input mbufs for rte_sched_port_enqueue() are not yet in the CPU cache(s). That causes quite significant stalls due to memory latency. Current implementation tries to migitate it using SW pipeline and SW prefetch techniques, but stalls are still present. Rework rte_sched_port

[dpdk-dev] [PATCH v2 1/2] examples/qos_sched: fixup colors value overrun

2021-03-18 Thread Konstantin Ananyev
'3' is not valid RTE_COLOR_ enum value. Fixes: de3cfa2c9823 ("sched: initial import") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev --- examples/qos_sched/app_thread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/qos_sched/app_thread.c b/examples/qos_sche

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-18 Thread Christian Ehrhardt
On Tue, Sep 1, 2020 at 3:23 PM Pai G, Sunil wrote: > > Hi, > > Yes , OVS was using pkg-config even before these patches were rolled out. > But it always used to pick the DPDK shared libs by default for OVS even on > using the -Bstatic/-Bshared flags. > These patches from Bruce simplify the proces

Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value

2021-03-18 Thread Xiaozhen Ban
OK, but I think this bug affects all stable release about 6 years before today.

[dpdk-dev] [PATCH v2] lib/mempool: distinguish debug counters from cache and pool

2021-03-18 Thread Joyce Kong
If cache is enabled, objects will be retrieved/put from/to cache, subsequently from/to the common pool. Now the debug stats calculate the objects retrieved/put from/to cache and pool together, it is better to distinguish the data number from local cache and common pool. Signed-off-by: Joyce Kong

[dpdk-dev] [PATCH v1] lib/mempool: distinguish debug counters from cache and pool

2021-03-18 Thread Joyce Kong
If cache is enabled, objects will be retrieved/put from/to cache, subsequently from/to the common pool. Now the debug stats caculate the objects retrived/put from/to cache and pool together, it is better to distinguish the data number from local cache and common pool. Signed-off-by: Joyce Kong --

[dpdk-dev] [PATCH] net/mlx5: support RSS expansion for IPv6 GRE

2021-03-18 Thread Jack Min
Currently RSS expansion only support IPv4 as GRE payload or delivery protocol (RFC2784). IPv6 as GRE payload or delivery protocol (RFC7676) is not supported. This patch add RSS expansion for RFC7676 so PMD can expand flow item correctly. Fixes: f4b901a46aec ("net/mlx5: add flow GRE item") Cc: sta

[dpdk-dev] [PATCH] doc: fix names of UIO drivers

2021-03-18 Thread Thomas Monjalon
Fix typos in the names of kernel drivers based on UIO, and make sure the generic term for the interface is UIO in capitals. Fixes: 3a78b2f73206 ("doc: add virtio crypto PMD guide") Fixes: 3cc4d996fa75 ("doc: update VFIO usage in qat crypto guide") Fixes: 39922c470e3c ("doc: add known uio_pci_gener

[dpdk-dev] [PATCH v2] bus/pci: fix Windows kernel driver categories

2021-03-18 Thread Thomas Monjalon
In Windows probing, the value RTE_PCI_KDRV_NONE was used instead of RTE_PCI_KDRV_UNKNOWN. This value covers the mlx case where the kernel driver is in place, offering a bifurcated mode to the userspace driver. When the kernel driver is listed as unknown, there is no special treatment in DPDK probin

Re: [dpdk-dev] [PATCH] bus/pci: fix Windows kernel driver categories

2021-03-18 Thread Thomas Monjalon
18/03/2021 09:36, Slava Ovsiienko: > From: Thomas Monjalon > > In Windows probing, the value RTE_PCI_KDRV_NONE was used instead of > > RTE_PCI_KDRV_UNKNOWN (mlx case), and RTE_PCI_KDRV_NIC_UIO > > (FreeBSD) was re-used instead of having a new RTE_PCI_KDRV_NET_UIO for > > Windows NetUIO. > > As far

Re: [dpdk-dev] [PATCH 2/2] net/ice: add Rx AVX512 offload path

2021-03-18 Thread Van Haaren, Harry
> -Original Message- > From: dev On Behalf Of Leyi Rong > Sent: Wednesday, March 17, 2021 9:14 AM > To: Zhang, Qi Z ; Lu, Wenzhuo > Cc: dev@dpdk.org; Rong, Leyi > Subject: [dpdk-dev] [PATCH 2/2] net/ice: add Rx AVX512 offload path > > Split AVX512 Rx data path into two, one is for basic

[dpdk-dev] [PATCH 4/4] examples/l3fwd: make data struct to be memory efficient

2021-03-18 Thread Ruifeng Wang
There are some holes in data struct lcore_conf. The holes are due to alignment requirement. For struct lcore_rx_queue, there is no need to make every element of this type to be cache line aligned, because the data is not shared between cores. Member len of struct mbuf_table can be moved out. So d

[dpdk-dev] [PATCH 3/4] examples/l3fwd: eliminate unnecessary reloads in loop

2021-03-18 Thread Ruifeng Wang
Number of rx queue and number of rx port in lcore config are constants during the period of l3 forward application running. But compiler has no this information. Copied values from lcore config to local variables and used the local variables for iteration. Compiler can see that the local variables

[dpdk-dev] [PATCH 2/4] examples/l3fwd: eliminate unnecessary calculations

2021-03-18 Thread Ruifeng Wang
Both L2 and L3 headers will be used in forward processing. And these two headers are in the same cache line. It has the same effect for prefetching with L2 header address and prefetching with L3 header address. Changed to use L2 header address for prefetching. The change showed no measurable perfo

[dpdk-dev] [PATCH 1/4] examples/l3fwd: tune prefetch for better performance

2021-03-18 Thread Ruifeng Wang
Packet header is prefetched before packet processing for better memory access performance. As L2 header will be updated by l3fwd, using of prefetch for store hint will set cache line to proper status and reduce cache maintenance overhead. With this change, 12.9% performance uplift was measured on

[dpdk-dev] [PATCH 0/4] l3fwd improvements

2021-03-18 Thread Ruifeng Wang
This series of patches include changes to l3fwd example application. Some improvements are made for better usage of CPU cycles and memory. Ruifeng Wang (4): examples/l3fwd: tune prefetch for better performance examples/l3fwd: eliminate unnecessary calculations examples/l3fwd: eliminate unnec

Re: [dpdk-dev] [PATCH] examples/packet_ordering: use local port config

2021-03-18 Thread Pattan, Reshma
> -Original Message- > From: dapengx...@intel.com > > Fixes: 6833f919f56b ("examples/packet_ordering: convert to new ethdev > offloads API") > Cc: sta...@dpdk.org Also, need to add CC: i.e CC: Shahaf Shuler Other than that , patch looks ok to me. Please include my ack in next vers

Re: [dpdk-dev] [PATCH v2 2/4] common/mlx5: enable debug logs dynamically

2021-03-18 Thread Matan Azrad
From: Thomas Monjalon > 17/03/2021 18:39, Ferruh Yigit: > > On 3/9/2021 9:48 AM, Thomas Monjalon wrote: > > > Most debug logs are using DRV_LOG(DEBUG,) but some were using > > > DEBUG(). > > > The macro DEBUG is doing nothing if not compiled with > > > RTE_LIBRTE_MLX5_DEBUG. > > > > > > As it is

[dpdk-dev] [PATCH 1/2] net/mlx5: workaround ASO memory region creation

2021-03-18 Thread Michael Baum
Due to kernel issue in direct MKEY creation using the DevX API for physical memory, this patch replaces the ASO MR creation to use Verbs API. Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/co

[dpdk-dev] [PATCH 0/2] adjusting mkey creations

2021-03-18 Thread Michael Baum
Adjusting mkey creations to use Verbs instead of DevX API. Michael Baum (2): net/mlx5: workaround ASO memory region creation net/mlx5: workaround counter memory region creation drivers/common/mlx5/linux/mlx5_common_verbs.c | 1 - drivers/common/mlx5/windows/mlx5_common_os.c | 23 +++---

[dpdk-dev] [PATCH 2/2] net/mlx5: workaround counter memory region creation

2021-03-18 Thread Michael Baum
Due to kernel issue in direct MKEY creation using the DevX API for physical memory, this patch replaces the counter MR creation to use Verbs API. Fixes: 3aa279157fa0 ("net/mlx5: synchronize flow counter pool creation") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- d

[dpdk-dev] [PATCH 6/6] net/ngbe: define registers

2021-03-18 Thread Jiawen Wu
Define all registers that will be used. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 1489 + drivers/net/ngbe/base/ngbe_type.h |2 + 2 files changed, 1491 insertions(+) create mode 100644 drivers/net/ngbe/base/ngbe_regs.h diff --git a/drivers

[dpdk-dev] [PATCH 3/6] net/ngbe: support probe and remove

2021-03-18 Thread Jiawen Wu
Add basic PCIe ethdev probe and remove. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 1 + drivers/net/ngbe/ngbe_ethdev.c| 77 +-- 2 files changed, 75 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/features/ngbe.ini b/doc/guides/n

[dpdk-dev] [PATCH 5/6] net/ngbe: add log type and error type

2021-03-18 Thread Jiawen Wu
Add log type and error type to trace functions. Signed-off-by: Jiawen Wu --- doc/guides/nics/ngbe.rst| 41 + drivers/net/ngbe/base/ngbe_status.h | 124 drivers/net/ngbe/base/ngbe_type.h | 1 + drivers/net/ngbe/ngbe_ethdev.c | 20 +

[dpdk-dev] [PATCH 4/6] net/ngbe: add device init and uninit

2021-03-18 Thread Jiawen Wu
Add basic init and uninit function. Map device IDs and subsystem IDs to single ID for easy opearation. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 4 +- drivers/net/ngbe/base/ngbe.h | 11 ++ drivers/net/ngbe/base/ngbe_hw.c| 59 ++ drivers/net/ngbe/base

[dpdk-dev] [PATCH 0/6] net: ngbe PMD

2021-03-18 Thread Jiawen Wu
This patch set provides a skeleton of ngbe PMD, which adapted to Wangxun WX1860 series NICs. Jiawen Wu (6): net/ngbe: add build and doc infrastructure net/ngbe: add device IDs net/ngbe: support probe and remove net/ngbe: add device init and uninit net/ngbe: add log type and error type

[dpdk-dev] [PATCH 2/6] net/ngbe: add device IDs

2021-03-18 Thread Jiawen Wu
Add device IDs for Wangxun 1Gb NICs, and register rte_ngbe_pmd. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 18 +++ drivers/net/ngbe/base/ngbe_devids.h | 83 + drivers/net/ngbe/meson.build| 6 +++ drivers/net/ngbe/ngbe_ethdev.c

[dpdk-dev] [PATCH 1/6] net/ngbe: add build and doc infrastructure

2021-03-18 Thread Jiawen Wu
Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for ngbe PMD. Signed-off-by: Jiawen Wu --- MAINTAINERS| 6 ++ doc/guides/nics/features/ngbe.ini | 10 + doc/guides/nics/index.rst | 1 + doc/guide

Re: [dpdk-dev] [PATCH v2 2/5] devargs: refactor scratch buffer storage

2021-03-18 Thread Thomas Monjalon
18/01/2021 16:16, Xueming Li: > In current design, legacy parser rte_devargs_parse() saved scratch > buffer to devargs.args while new parser rte_devargs_layers_parse() saved > to devargs.data. Code using devargs had to know the difference and > cleaned up memory accordingly - error prone. > > This

[dpdk-dev] [PATCH] vdpa/mlx5: improve interrupt management

2021-03-18 Thread Matan Azrad
The driver should notify the guest for each traffic burst detected by CQ polling. The CQ polling trigger is defined by `event_mode` device argument, either by busy polling on all the CQs or by blocked call to HW completion event using DevX channel. Also, the polling event modes can move to blocke

[dpdk-dev] [PATCH 2/2] net/bnxt: fix unsupported handling in PTP

2021-03-18 Thread Kalesh A P
From: Kalesh AP Fixed to return error when PTP support is not supported on the port. Also, removed an unnecessary check inside bnxt_get_rx_ts(). Fixes: b11cceb83a34 ("net/bnxt: support timesync") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Somnat

  1   2   >