[dpdk-dev] [PATCH 6/6] baseband/la12xx: add documentation support

2021-03-17 Thread Hemant Agrawal
This patch add documentation for LA12xx PMD. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- MAINTAINERS| 9 ++ doc/guides/bbdevs/features/la12xx.ini | 14 +++ doc/guides/bbdevs/index.rst| 1 + doc/guides/bbdevs/la12xx.rst | 1

[dpdk-dev] [PATCH 5/6] baseband/la12xx: add enqueue and dequeue support

2021-03-17 Thread Hemant Agrawal
Add support for enqueue and dequeue the LDPC enc/dec from the modem device. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 393 - drivers/baseband/la12xx/bbdev_la12xx_ipc.h | 37 ++ 2 files changed, 426 insertions(+

[dpdk-dev] [PATCH 4/6] baseband/la12xx: add queue and modem config support

2021-03-17 Thread Hemant Agrawal
This patch add support for connecting with modem and creating the ipc channel as queues with modem for the exchange of data. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 566 - drivers/baseband/la12xx/bbdev_la12xx.

[dpdk-dev] [PATCH 2/6] baseband/la12xx: add devargs for max queues

2021-03-17 Thread Hemant Agrawal
This patch adds dev args to take max queues as input Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 72 +- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/dri

[dpdk-dev] [PATCH 1/6] baseband: introduce NXP LA12xx driver

2021-03-17 Thread Hemant Agrawal
This patch introduce the baseband device drivers for NXP's LA1200 series software defined baseband modem. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c| 110 ++ .../baseband/la12xx/bbdev_la12xx_pmd_logs.h | 38

[dpdk-dev] [PATCH 3/6] baseband/la12xx: add support for multiple modems

2021-03-17 Thread Hemant Agrawal
This patch add support for multiple modems by assigning a modem id as dev args in vdev creation. Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 62 +++--- drivers/baseband/la12xx/bbdev_la12xx.h | 56 +++ drivers/baseband/la12xx/

[dpdk-dev] [PATCH] app/test-pmd: enable testpmd on windows

2021-03-17 Thread Jie Zhou
From: Jie Zhou This patch is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that TestPMD depends on - Enable building testpmd on Windows - Resolve name collisions with Windows types - Add clock_gettime_monotic for testpmd on Windows - Make printf format w

Re: [dpdk-dev] [PATCH v3 1/8] eventdev: introduce event vector capability

2021-03-17 Thread Pavan Nikhilesh Bhagavatula
>Posting my comments in beginning. No further comments. > >@pbhagavat...@marvell.com, it seems like v3 patch1 drops some >changes from v2 patch1 (for e.g. missing event vector pointer in >rte_event) causing build failure. Could you have a look? Ah, my bad, my auto-formatter really messed-up the se

Re: [dpdk-dev] [PATCH v3 1/8] eventdev: introduce event vector capability

2021-03-17 Thread Jayatheerthan, Jay
Posting my comments in beginning. No further comments. @pbhagavat...@marvell.com, it seems like v3 patch1 drops some changes from v2 patch1 (for e.g. missing event vector pointer in rte_event) causing build failure. Could you have a look? Thanks! -Jay > -Original Message- > From: pbh

Re: [dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.

2021-03-17 Thread Wangxiaoyun (Cloud)
Hi Ferruh, For secondary process fix,you can refer to this patch "net/hinic: fix coredump when PMD used by fstack". Thanks 在 2020/11/12 20:30, Wangxiaoyun (Cloud) 写道: When we complete repair and testing, we will upstream the patch in next release, maybe not keep up with 20.11. 在 2020/1

[dpdk-dev] [PATCH v2 4/4] net/iavf: add offload path for Rx AVX512 flex desc

2021-03-17 Thread Wenzhuo Lu
Add a specific path for RX AVX512 (flexible descriptor). In this path, support the HW offload features, like, checksum, VLAN stripping, RSS hash. This path is chosen automatically according to the configuration. All the code for the above HW offload features is removed from the legacy path. Signe

[dpdk-dev] [PATCH v2 3/4] net/iavf: add offload path for Rx AVX512

2021-03-17 Thread Wenzhuo Lu
Add a specific path for RX AVX512 (traditional). In this path, support the HW offload features, like, checksum, VLAN stripping, RSS hash. This path is chosen automatically according to the configuration. All the code for the above HW offload features is removed from the legacy path. Signed-off-by

[dpdk-dev] [PATCH v2 2/4] net/iavf: add offload path for Tx AVX512

2021-03-17 Thread Wenzhuo Lu
Add a specific path for TX AVX512. In this path, support the HW offload features, like, checksum insertion, VLAN insertion. This path is chosen automatically according to the configuration. Signed-off-by: Wenzhuo Lu --- drivers/net/iavf/iavf_rxtx.c| 50 ++ drivers/net/iavf/i

[dpdk-dev] [PATCH v2 1/4] net/iavf: store offload flag of Rx queue

2021-03-17 Thread Wenzhuo Lu
Add the offload flag for RX queues to know which offload features are set. Signed-off-by: Wenzhuo Lu --- drivers/net/iavf/iavf_rxtx.c | 4 drivers/net/iavf/iavf_rxtx.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 8fa

[dpdk-dev] [PATCH v2 0/4] add Rx/Tx offload paths for IAVF AVX512

2021-03-17 Thread Wenzhuo Lu
Add specific paths for RX/TX AVX512, called offload paths. In these paths, support the HW offload features, like, checksum, VLAN, RSS offload. These paths are chosen automatically according to the configuration. The code for the above HW offload features, which are supported by offload paths, is r

[dpdk-dev] [PATCH] net/bnxt: fix RSS context cleanup

2021-03-17 Thread Ajit Khaparde
The PMD is allocating an extra RSS context with each port start. But it is freeing only one RSS context during port stop. So at some point we run out of RSS contexts when we do multiple port stop/start sequences. bnxt_hwrm_vnic_ctx_alloc() is called by bnxt_setup_one_vnic(), but bnxt_hwrm_vnic_ctx_

Re: [dpdk-dev] [PATCH] net/bnxt: fix Tx timestamp init

2021-03-17 Thread Ajit Khaparde
On Mon, Mar 15, 2021 at 10:41 PM Somnath Kotur wrote: > > Fix to read the sequence ID register to get Tx timestamp. > Reading the sequence ID register is necessary for the HW FIFO to > advance and thereby get the correct value of the timestamp on Tx side. > This patch fixes that. > > Fixes: b11cce

Re: [dpdk-dev] [PATCH] net/bnxt: fix unchecked return value

2021-03-17 Thread Ajit Khaparde
On Mon, Mar 15, 2021 at 10:19 PM Kalesh A P wrote: > > From: Kalesh AP > > CID 363716 (#1 of 1): Unchecked return value (CHECKED_RETURN) > check_return: Calling rte_pci_write_config without checking > return value (as is done elsewhere 46 out of 49 times). > > Coverity issue: 363716 > > Fixes: be

Re: [dpdk-dev] [Linuxarm] Re: [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-17 Thread oulijun
在 2021/3/17 20:07, Thomas Monjalon 写道: 17/03/2021 12:30, oulijun: 2021/3/12 19:21, Thomas Monjalon: 12/03/2021 11:29, oulijun: 2021/3/10 15:59, Thomas Monjalon: 10/03/2021 02:48, oulijun: Can we add an API such as rte_eth_get_device(pord_id) for example: struct rte_eth_dev * rte_eth_get_

Re: [dpdk-dev] [PATCH v3 2/3] vhost: move dirty logging cache out of the virtqueue

2021-03-17 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Thursday, March 18, 2021 1:09 AM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; > david.march...@redhat.com; olivier.m...@6wind.com; bnem...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v3 2/3] vhost: move dirty logging ca

Re: [dpdk-dev] [PATCH v3 3/3] vhost: optimize vhost virtqueue struct

2021-03-17 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, March 18, 2021 1:09 AM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; > david.march...@redhat.com; olivier.m...@6wind.com; bnem...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v3 3/3] vhost: optimize

Re: [dpdk-dev] [PATCH] net/ice/base: fix out of memory bound for MAC addresses

2021-03-17 Thread Yang, Qiming
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, March 17, 2021 14:02 > To: Yang, Qiming > Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Qi Z > ; sta...@dpdk.org > Subject: [PATCH] net/ice/base: fix out of memory bound for MAC addresses > > Not enough memory be allocated for dev-

[dpdk-dev] [PATCH v4 8/8] net/igc: refine debug build option

2021-03-17 Thread Qi Zhang
1. replace RTE_LIBRTE_IGC_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IGC_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/igc/igc_logs.h | 4 ++-- drivers/net/igc/igc_txrx.c | 2 +- 2 files changed,

[dpdk-dev] [PATCH v4 7/8] net/ixgbe: refine debug build option

2021-03-17 Thread Qi Zhang
1. replace RTE_LIBRTE_IXGBE_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IXGBE_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_IXGBE_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 7 +--- dr

[dpdk-dev] [PATCH v4 6/8] net/ice: refine debug build option

2021-03-17 Thread Qi Zhang
1. replace RTE_LIBRTE_ICE_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_ICE_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_ICE_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_LIBRTE_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 7 ++- drivers/n

[dpdk-dev] [PATCH v4 5/8] net/iavf: refine debug build option

2021-03-17 Thread Qi Zhang
1. replace RTE_LIBRTE_IAVF_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IAVF_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_IAVF_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/iavf/iavf_ethdev.c | 7 ++- driv

[dpdk-dev] [PATCH v4 4/8] net/i40e: refine debug build option

2021-03-17 Thread Qi Zhang
1. replace RTE_LIBRTE_I40E_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_I40E_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_I40E_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 7 ++- driv

[dpdk-dev] [PATCH v4 3/8] net/e1000: refine debug build option

2021-03-17 Thread Qi Zhang
1. replace RTE_LIBRTE_E1000_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_E1000_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_E1000_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/e1000/e1000_logs.c | 17 --

[dpdk-dev] [PATCH v4 2/8] net/fm10k: refine debug build option

2021-03-17 Thread Qi Zhang
1. replace RTE_LIBRTE_FM10K_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_FM10K_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_FM10K_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/fm10k/fm10k_ethdev.c | 7 ++-

[dpdk-dev] [PATCH v4 1/8] ether: refine debug build option

2021-03-17 Thread Qi Zhang
PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. The patch introduces below build options for data path debug, so PMD can choose to reuse them to av

[dpdk-dev] [PATCH v4 0/8] ether: refine debug build option

2021-03-17 Thread Qi Zhang
PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. Patch 1/8: introduces new compile options for data path debug in ether layer, PMD can choose to reu

Re: [dpdk-dev] [dpdk-stable] [PATCH v16 0/3] raw/ifpga: add extra APIs for Cyborg

2021-03-17 Thread Huang, Wei
Ferruh, Yes, they have been rejected. Thanks -Original Message- From: Yigit, Ferruh Sent: Thursday, March 18, 2021 01:09 To: Huang, Wei ; dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z Cc: sta...@dpdk.org; Zhang, Tianfei Subject: Re: [dpdk-stable] [PATCH v16 0/3] raw/ifpga: add extra APIs fo

[dpdk-dev] [PATCH 1/3] Add EAL threads API

2021-03-17 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL must hide the environment specifics from apps and libraries. Add an EAL API for managing threads. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/librte_eal/common/eal_common_thread.c | 6 +- lib/librte_eal/common/rte_thread.c| 346

[dpdk-dev] [PATCH 2/3] Add EAL argument for setting thread priority

2021-03-17 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile This patch introduces a new EAL argument that allows the user to choose the desired thread priority (realtime or normal). Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/eal_common_options.c | 28 +- lib/librte_eal/common/eal_internal_cfg.h |

[dpdk-dev] [PATCH 0/3] eal: Add new API for threading

2021-03-17 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread API. Given that EAL sh

Re: [dpdk-dev] [PATCH v3 2/9] net: replace build option

2021-03-17 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, March 18, 2021 6:01 AM > To: Zhang, Qi Z ; Andrew Rybchenko > ; Yigit, Ferruh > Cc: dev@dpdk.org; Richardson, Bruce ; Wang, > Xiao W ; Wu, Jingjing ; Xing, > Beilei ; Guo, Jia ; Yang, Qiming > ; Wang, Haiyue > Subject: Re:

Re: [dpdk-dev] [PATCH v1] bbdev: adding explicit enum for code block mode

2021-03-17 Thread Chautru, Nicolas
Hi Akhil, Any chance to review this one to be applied? Thanks > -Original Message- > From: Tom Rix > Sent: Wednesday, March 3, 2021 12:04 PM > To: Chautru, Nicolas ; dev@dpdk.org; > akhil.go...@nxp.com; tho...@monjalon.net > Subject: Re: [PATCH v1] bbdev: adding explicit enum for code bl

Re: [dpdk-dev] [PATCH] bus/pci: fix Windows kernel driver categories

2021-03-17 Thread Ranjit Menon
Hi Thomas, On 3/16/2021 4:11 PM, Thomas Monjalon wrote: In Windows probing, the value RTE_PCI_KDRV_NONE was used instead of RTE_PCI_KDRV_UNKNOWN (mlx case), and RTE_PCI_KDRV_NIC_UIO (FreeBSD) was re-used instead of having a new RTE_PCI_KDRV_NET_UIO for Windows NetUIO. Shouldn't the mlx case act

Re: [dpdk-dev] [PATCH] bus/pci: fix Windows kernel driver categories

2021-03-17 Thread Dmitry Kozlyuk
2021-03-17 00:11 (UTC+0100), Thomas Monjalon: [...] > diff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h > index fdda046515..3d009cc74b 100644 > --- a/drivers/bus/pci/rte_bus_pci.h > +++ b/drivers/bus/pci/rte_bus_pci.h > @@ -52,12 +52,13 @@ TAILQ_HEAD(rte_pci_driver_list, rt

Re: [dpdk-dev] [PATCH v6 00/17] Alpine/musl build support

2021-03-17 Thread Thomas Monjalon
28/02/2021 13:53, Thomas Monjalon: > These patches fix some build errors/warning for Alpine Linux, > using musl and busybox. > Few improvements are added on the way. No more comment on this series? Ready to merge?

Re: [dpdk-dev] [PATCH v3 2/9] net: replace build option

2021-03-17 Thread Thomas Monjalon
17/03/2021 22:47, Ferruh Yigit: > On 3/17/2021 11:15 AM, Qi Zhang wrote: > > Replace RTE_LIBRTE_ETHDEV_DEBUG with RTE_ETHDEV_DEBUG. > > > > Signed-off-by: Qi Zhang > > Hi Qi, Thomas, > > I see Thomas mentioned 'LIBRTE_' is redundant but not sure about renaming the > existing compile time flag

Re: [dpdk-dev] [PATCH v3 2/9] net: replace build option

2021-03-17 Thread Ferruh Yigit
On 3/17/2021 11:15 AM, Qi Zhang wrote: Replace RTE_LIBRTE_ETHDEV_DEBUG with RTE_ETHDEV_DEBUG. Signed-off-by: Qi Zhang Hi Qi, Thomas, I see Thomas mentioned 'LIBRTE_' is redundant but not sure about renaming the existing compile time flag without notice. The flag is to be used for users, i

[dpdk-dev] [RFC 4/4] net/virtio: add support for SocketPair Broker

2021-03-17 Thread Ilya Maximets
New configuration option 'broker-key' to specify that the socket path is actually a path to SocketPair Broker's socket. The value of a 'broker-key' argument will be used as a broker key, so the broker will be able to identify which vhost device virtio-user should be paired with. Ex.: --vdev="ne

[dpdk-dev] [RFC 3/4] net/vhost: add support for SocketPair Broker

2021-03-17 Thread Ilya Maximets
New configuration option "broker-key" to identify that "iface" points to the socket of SocketPair Broker and provide the pairing key. Some functions inside rte_eth_vhost.c are using socket path as a unique identifier, but that is not true. Simply concatinating key to iface name to avoid big code

[dpdk-dev] [RFC 2/4] vhost: add support for SocketPair Broker

2021-03-17 Thread Ilya Maximets
New flag RTE_VHOST_USER_SOCKETPAIR_BROKER to say that provided socket is a path to SocketPair Broker socket in a following format: '/path/to/socketpair/broker.sock,broker-key=' This format is chosen to avoid lots of code changes and refactoring inside the vhost library, mainly because vhost lib

[dpdk-dev] [PATCH 1/4] net/virtio: fix interrupt unregistering for listening socket

2021-03-17 Thread Ilya Maximets
virtio_user_dev_server_reconnect() is typically called from the interrupt context while checking the link state: vhost_user_update_link_state() --> virtio_user_dev_server_reconnect() Under this conditions callback unregistering always fails. This means that listenfd is never unregistered and

[dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

2021-03-17 Thread Ilya Maximets
TL;DR; Managing socket files is too much fun. :) And here is how this could be improved: https://github.com/igsilya/one-socket https://github.com/igsilya/one-socket/blob/main/doc/socketpair-broker.rst In particular for vhost-user case. In modern virtualization setups there are tens

Re: [dpdk-dev] [PATCH 21.05] net/virtio: remove duplicate port id from virtio_user

2021-03-17 Thread Maxime Coquelin
On 2/1/21 6:46 PM, David Marchand wrote: > The private virtio_user_dev structure embeds a virtio_hw which itself > contains the ethdev port_id. > Make use of it and remove the duplicate port_id field. > > Signed-off-by: David Marchand > --- > Posting this cleanup that I caught when reviewing/d

Re: [dpdk-dev] [PATCH v4 0/4] eal/windows: do not expose POSIX symbols

2021-03-17 Thread Ranjit Menon
On 3/5/2021 4:04 PM, Dmitry Kozlyuk wrote: On Windows, rte_os.h contains a small POSIX compatibility set of functions and macros. Exposing it from EAL can break consumer own POSIX compatibility layer and is against standards in general. Hide these symbols from external consumers, while keeping th

Re: [dpdk-dev] [PATCH v3 0/4] net: replace Windows networking shim

2021-03-17 Thread Ranjit Menon
On 3/13/2021 2:22 PM, Dmitry Kozlyuk wrote: Networking header shim in Windows EAL conflicts with system headers and tries to provide POSIX compatibility out of scope for DPDK. Remove dependency on POSIX headers from libraries supported on Windows, then replace shim with librte_net with workaround

Re: [dpdk-dev] [PATCH 0/7] eal/windows: do not expose POSIX symbols

2021-03-17 Thread Ranjit Menon
On 2/20/2021 3:29 PM, Dmitry Kozlyuk wrote: On Windows, rte_os.h contains a small POSIX compatibility set of functions and macros. Exposing it from EAL can break consumer own POSIX compatibility layer and is against standards in general. First define required wrappers, then fix POSIX dependencie

Re: [dpdk-dev] [PATCH v3 2/3] test/event: add unit tests for periodic timer

2021-03-17 Thread Carrillo, Erik G
> -Original Message- > From: Shijith Thotton > Sent: Wednesday, March 17, 2021 3:04 AM > To: Carrillo, Erik G > Cc: Shijith Thotton ; Pavan Nikhilesh > ; Jerin Jacob ; > dev@dpdk.org > Subject: [PATCH v3 2/3] test/event: add unit tests for periodic timer > > Add tests to arm and cancel p

Re: [dpdk-dev] [PATCH v3 1/3] eventdev: introduce adapter flags for periodic mode

2021-03-17 Thread Carrillo, Erik G
> -Original Message- > From: Shijith Thotton > Sent: Wednesday, March 17, 2021 3:04 AM > To: Carrillo, Erik G > Cc: Shijith Thotton ; Pavan Nikhilesh > ; Jerin Jacob ; > dev@dpdk.org > Subject: [PATCH v3 1/3] eventdev: introduce adapter flags for periodic mode > > A timer adapter in peri

Re: [dpdk-dev] [PATCH v3 0/5] mlx5: add timestamp format support

2021-03-17 Thread Ferruh Yigit
On 3/14/2021 12:12 PM, Viacheslav Ovsiienko wrote: There are two different timestamp formats can be provided potentially by mlx5 supported hardware. The free-running format provides some opaque values captured from internal clock counter clocked by some independent oscillator. The free-running f

Re: [dpdk-dev] [PATCH] app/eventdev: fix timeout accuracy

2021-03-17 Thread Carrillo, Erik G
Hi Pavan, > -Original Message- > From: dev On Behalf Of > pbhagavat...@marvell.com > Sent: Thursday, February 25, 2021 6:02 AM > To: jer...@marvell.com > Cc: dev@dpdk.org; Pavan Nikhilesh ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/eventdev: fix timeout accuracy > > From: Pavan

Re: [dpdk-dev] [PATCH v2 2/4] common/mlx5: enable debug logs dynamically

2021-03-17 Thread Thomas Monjalon
17/03/2021 18:39, Ferruh Yigit: > On 3/9/2021 9:48 AM, Thomas Monjalon wrote: > > Most debug logs are using DRV_LOG(DEBUG,) > > but some were using DEBUG(). > > The macro DEBUG is doing nothing if not compiled with > > RTE_LIBRTE_MLX5_DEBUG. > > > > As it is not used in the data path, the macro DE

Re: [dpdk-dev] [PATCH v2 1/4] net/mlx4: enable debug logs dynamically

2021-03-17 Thread Thomas Monjalon
17/03/2021 18:29, Ferruh Yigit: > On 3/9/2021 9:48 AM, Thomas Monjalon wrote: > > The macro DEBUG was doing nothing if not compiled with > > RTE_LIBRTE_MLX4_DEBUG. > > > > As it is not used in the data path, it can be always enabled at > > compilation time. Then it can be enabled at runtime with:

Re: [dpdk-dev] [PATCH v2 2/4] common/mlx5: enable debug logs dynamically

2021-03-17 Thread Ferruh Yigit
On 3/9/2021 9:48 AM, Thomas Monjalon wrote: Most debug logs are using DRV_LOG(DEBUG,) but some were using DEBUG(). The macro DEBUG is doing nothing if not compiled with RTE_LIBRTE_MLX5_DEBUG. As it is not used in the data path, the macro DEBUG can be replaced with DRV_LOG. Then all debug logs ca

Re: [dpdk-dev] [PATCH v2 1/4] net/mlx4: enable debug logs dynamically

2021-03-17 Thread Ferruh Yigit
On 3/9/2021 9:48 AM, Thomas Monjalon wrote: The macro DEBUG was doing nothing if not compiled with RTE_LIBRTE_MLX4_DEBUG. As it is not used in the data path, it can be always enabled at compilation time. Then it can be enabled at runtime with: --log-level pmd.net.mlx4:debug Signed-off-b

Re: [dpdk-dev] [PATCH v3 3/4] net/mlx5: remove POSIX dependency

2021-03-17 Thread Tyler Retzlaff
On Sun, Mar 14, 2021 at 01:22:15AM +0300, Dmitry Kozlyuk wrote: > Use for IP-related defines instead of POSIX headers. > Keep , because it is incorporated into DPDK. > > Signed-off-by: Dmitry Kozlyuk Acked-by: Tyler Retzlaff

Re: [dpdk-dev] [PATCH v3 2/4] ethdev: remove POSIX dependency

2021-03-17 Thread Tyler Retzlaff
On Sun, Mar 14, 2021 at 01:22:14AM +0300, Dmitry Kozlyuk wrote: > Use for IP-related defines instead of POSIX headers. > Keep , because it is incorporated into DPDK. > Cleanup, group, and sort remaining includes per coding style. > > Signed-off-by: Dmitry Kozlyuk Acked-by: Tyler Retzlaff

Re: [dpdk-dev] [PATCH v3 1/4] cmdline: remove POSIX dependency

2021-03-17 Thread Tyler Retzlaff
On Sun, Mar 14, 2021 at 01:22:13AM +0300, Dmitry Kozlyuk wrote: > Use for IP-related defines instead of POSIX headers. > > Signed-off-by: Dmitry Kozlyuk Acked-by: Tyler Retzlaff

Re: [dpdk-dev] [PATCH v9 08/10] ethdev: new API to get representor info

2021-03-17 Thread Ferruh Yigit
On 3/17/2021 6:57 AM, Thomas Monjalon wrote: 17/03/2021 00:34, Ferruh Yigit: On 3/16/2021 9:19 PM, Thomas Monjalon wrote: 16/03/2021 20:18, Ferruh Yigit: On 3/11/2021 1:13 PM, Xueming Li wrote: + # added in 21.05 + rte_eth_representor_info_get; New API documented in release note

[dpdk-dev] [dpdk-announce] DPDK 19.11.7 released

2021-03-17 Thread Christian Ehrhardt
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-19.11.7.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=19.11 Christian Ehrhardt --- VERSION| 2 +- app/meson.build

[dpdk-dev] [PATCH v3 3/3] vhost: optimize vhost virtqueue struct

2021-03-17 Thread Maxime Coquelin
This patch moves vhost_virtqueue struct fields in order to both optimize packing and move hot fields on the first cachelines. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 6 ++-- lib/librte_vhost/vhost.h | 54 ++- lib/librte_vhost/vhost

[dpdk-dev] [PATCH v3 2/3] vhost: move dirty logging cache out of the virtqueue

2021-03-17 Thread Maxime Coquelin
This patch moves the per-virtqueue's dirty logging cache out of the virtqueue struct, by allocating it dynamically only when live-migration is enabled. It saves 8 cachelines in vhost_virtqueue struct. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 13 + lib/librt

[dpdk-dev] [PATCH v3 1/3] vhost: remove unused Vhost virtqueue field

2021-03-17 Thread Maxime Coquelin
This patch removes the "backend" field of the vhost_virtqueue struct, which is not used by the library. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/librte_vhost/vhost.c | 2 -- lib/librte_vhost/vhost.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/librte_vhost/vho

[dpdk-dev] [PATCH v3 0/3] vhost: make virtqueue cache-friendly

2021-03-17 Thread Maxime Coquelin
As done for Virtio PMD, this series improves cache utilization of the vhost_virtqueue struct by removing unused field, make the live-migration cache dynamically allocated at live-migration setup time and by moving fields around so that hot fields are on the first cachelines. With this series, The

Re: [dpdk-dev] [dpdk-stable] [PATCH v16 0/3] raw/ifpga: add extra APIs for Cyborg

2021-03-17 Thread Ferruh Yigit
On 3/17/2021 7:59 AM, Wei Huang wrote: Cyborg is part of OpenStack, it needs some extra APIs to manage devices with Intel FPGA. These patches add APIs to meet Cyborg requirement. Main changes from v15: - remove example from the patch set Wei Huang (3): raw/ifpga: add fpga rsu APIs raw/ifp

[dpdk-dev] [PATCH] event/dlb2: Optimize Dequeue Operations

2021-03-17 Thread Timothy McDaniel
Convert code to use x86 vector instructions, thereby significantly improving dequeue performance. Signed-off-by: Timothy McDaniel --- config/rte_config.h|1 + drivers/event/dlb2/dlb2.c | 607 drivers/event/dlb2/dlb2_priv.h | 19 +-

Re: [dpdk-dev] [PATCH v2] bus/pci: fix probing for non-netuio bound devices

2021-03-17 Thread Kadam, Pallavi
On 3/16/2021 4:20 AM, Thomas Monjalon wrote: Implement rte_pci_map_device() to distinguish between the devices bound to netuio and NDIS devices. Only return success for the netuio devices. v2 changes: - Extended the comment to mention about mapping - replaced the return errno

Re: [dpdk-dev] [PATCH v1 1/1] net/mlx5: fix port id / push VLAN actions index incorrect

2021-03-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Li Zhang > Sent: Tuesday, March 16, 2021 2:05 PM > To: dev@dpdk.org; Ori Kam ; Slava Ovsiienko > ; Matan Azrad ; Suanming > Mou > Cc: NBU-Contact-Thomas Monjalon ; Raslan > Darawsheh ; sta...@dpdk.org > Subject: [PATCH v1 1/1] net/mlx5: fix port id / push

Re: [dpdk-dev] [PATCH v3] doc: update sample actions support in mlx5 guide

2021-03-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei Wang > Sent: Tuesday, March 16, 2021 5:18 PM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; NBU-Contact-Thomas > Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v3] doc: update sample actions support in mlx5 guide > > Updates t

[dpdk-dev] [PATCH v2] eal: declare extern "C" linkage when building with __cplusplus

2021-03-17 Thread Tyler Retzlaff
Add missing extern "C" linkage for rte_reciprocal.h consistent with other eal headers. Fixes: ffe3ec811ef5 ("sched: introduce reciprocal divide") Cc: sta...@dpdk.org Signed-off-by: Tyler Retzlaff --- * fixed commit title line link->linkage * added Fixes and Cc from dmitryk feedback lib/librte

Re: [dpdk-dev] [RFC] ethdev: introduce action context APIs

2021-03-17 Thread Bing Zhao
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 17, 2021 4:29 PM > To: Bing Zhao > Cc: Ori Kam ; ferruh.yi...@intel.com; > andrew.rybche...@oktetlabs.ru; dev@dpdk.org > Subject: Re: [RFC] ethdev: introduce action context APIs > > External email: Use caut

Re: [dpdk-dev] [PATCH] eal: fix version macro

2021-03-17 Thread Thomas Monjalon
17/03/2021 16:36, David Marchand: > On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon wrote: > > > > The macro RTE_VERSION is broken since updated with function calls. > > It is a build-time version number, and must be built with macros. > > For a run-time version number, there is the function rte_

Re: [dpdk-dev] [PATCH] eal: fix version macro

2021-03-17 Thread David Marchand
On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon wrote: > > The macro RTE_VERSION is broken since updated with function calls. > It is a build-time version number, and must be built with macros. > For a run-time version number, there is the function rte_version(). > > Fixes: 5b637a848195 ("eal: fi

Re: [dpdk-dev] [PATCH v3 1/8] net/hns3: support runtime config to select IO burst func

2021-03-17 Thread Ferruh Yigit
On 3/17/2021 1:14 AM, Min Hu (Connor) wrote: 在 2021/3/16 20:40, Ferruh Yigit 写道: On 3/12/2021 11:51 AM, Min Hu (Connor) wrote: From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate function based on offload configuration. Mo

[dpdk-dev] [PATCH] eal: mark version parts API as experimental

2021-03-17 Thread Thomas Monjalon
Some functions were introduced in DPDK 21.05 to query the version parts (prefix, year, month, minor, suffix, release) at runtime. Per guidelines, these new public functions must be marked with __rte_experimental and ABI versioned as EXPERIMENTAL. Fixes: 5b637a848195 ("eal: fix querying DPDK versio

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

2021-03-17 Thread Thomas Monjalon
17/03/2021 15:44, Aaron Conole: > The hugepage test really needs to check multiple things on Linux: > > 1. Are hugepages reserved in the system? > > 2. Is the hugepage mountpoint available so that we can allocate them? > > 3. Do we have permissions to write into the hugepage mountpoint? > > The

Re: [dpdk-dev] [PATCH v2] guides: add a testing guide for developing tests

2021-03-17 Thread Aaron Conole
David Marchand writes: > On Tue, Mar 9, 2021 at 5:14 PM Aaron Conole wrote: >> >>> > +The suites can be selected by adding the ``--suite`` option to the >> >>> > +``meson test`` command. Ex: ``meson test --suite fast-tests``:: >> >>> > + >> >>> > + $ meson test -C build --suite fast-tests >> >

[dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

2021-03-17 Thread Aaron Conole
The hugepage test really needs to check multiple things on Linux: 1. Are hugepages reserved in the system? 2. Is the hugepage mountpoint available so that we can allocate them? 3. Do we have permissions to write into the hugepage mountpoint? The existing hugepage check only verifies the first.

[dpdk-dev] [PATCH v14 7/7] doc: add aarch32 build guidance

2021-03-17 Thread Juraj Linkeš
From: Phil Yang Add cross-compiling guidance for 32-bit aarch32 DPDK on aarch64 host. Signed-off-by: Phil Yang Acked-by: Ruifeng Wang Acked-by: Aaron Conole --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 38 +++ 1 file changed, 31 insertions(+), 7 deletions(-) diff --gi

[dpdk-dev] [PATCH v14 6/7] ci: add aarch64 -> aarch32 cross compiling jobs

2021-03-17 Thread Juraj Linkeš
Add two jobs (static and shared libs), both building on aarch64 and producing 32-bit arm binaries executable on armv8-a, but not armv7. Do not run tests in these jobs. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang Acked-by: Aaron Conole --- .ci/linux-build.sh | 7 ++- .travis.yml

[dpdk-dev] [PATCH v14 5/7] build: add aarch32 to meson cross-compilation

2021-03-17 Thread Juraj Linkeš
Create meson cross file arm32_armv8a_linux_gcc. Use arm-linux-gnueabihf- toolset which comes with standard packages on most used systems, such as Ubuntu and CentOS. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- config/arm/arm32_armv8a_linux_gcc | 17 + 1 file changed, 1

[dpdk-dev] [PATCH v14 4/7] build: add aarch32 meson build flags

2021-03-17 Thread Juraj Linkeš
Add aarch32 extra build flags and aarch32 machine flags to generic machine args. Also modify how arm flags are updated in meson build - for 32-bit build, update only if cross-compiling. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- config/arm/meson.build | 24 +---

[dpdk-dev] [PATCH v14 3/7] net/virtio: fix aarch32 build

2021-03-17 Thread Juraj Linkeš
NEON vector path of the PMD needs aarch64 support. But it was enabled for aarch32 build as well because aarch32 build had cpu_family set to aarch64. So build for aarch32 will fail due to unsupported intrinsics. Fix aarch32 build by updating meson file to exclude NEON vector implementation for aarc

[dpdk-dev] [PATCH v14 2/7] net/bnxt: fix aarch32 build

2021-03-17 Thread Juraj Linkeš
From: Ruifeng Wang NEON vector path of the PMD needs aarch64 support. But it was enabled for aarch32 build as well because aarch32 build had cpu_family set to aarch64. So build for aarch32 will fail due to unsupported intrinsics. Fix aarch32 build by updating meson file to exclude NEON vector im

[dpdk-dev] [PATCH v14 1/7] net/sfc: fix aarch32 build

2021-03-17 Thread Juraj Linkeš
From: Ruifeng Wang The sfc PMD was enabled for aarch32 which is 32-bit mode but has cpu_family set to aarch64. As sfc support only 64-bit system, it should be disabled for aarch32. Updated meson file to disable sfc for aarch32 build. Fixes: 141d2870675a ("net/sfc: support aarch64 architecture")

[dpdk-dev] [PATCH v14 0/7] aarch64 -> aarch32 cross compilation support

2021-03-17 Thread Juraj Linkeš
Add support for aarch32 cross build in meson and add aarch64 -> aarch32 cross build to Travis. Aarch32 is an execution state that allows execution of 32-bit code on armv8 machines. This execution state contains a superset of previous armv7 32-bit instructions and features. Thus the aarch32 build i

Re: [dpdk-dev] [PATCH] ptpclient: enable timestamp offload support

2021-03-17 Thread Thomas Monjalon
04/03/2021 17:59, Rybalchenko, Kirill: > From: Hemant Agrawal > > > > This patch add support to enabled rx offload for timestamp. > > It is required to be enabled for some pmds e.g. dpaa2 > > > > Signed-off-by: Gagandeep Singh > > Signed-off-by: Hemant Agrawal > > Acked-by: Kirill Rybalchenko

Re: [dpdk-dev] [PATCH v11 0/2] support both PIO and MMIO BAR for legacy virito device

2021-03-17 Thread 谢华伟(此时此刻)
On 2021/3/15 22:16, David Marchand wrote: v10 changes: - trival fixes in commit message, like > 75 chars v11 changes: - commit message fix and change Aligned Sob and Author to fix the last checkpatch warning. Series applied to the main branch. Thanks Huawei and thanks too to revie

Re: [dpdk-dev] [Linuxarm] Re: [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-17 Thread Thomas Monjalon
17/03/2021 12:30, oulijun: > 2021/3/12 19:21, Thomas Monjalon: > > 12/03/2021 11:29, oulijun: > >> 2021/3/10 15:59, Thomas Monjalon: > >>> 10/03/2021 02:48, oulijun: > Can we add an API such as rte_eth_get_device(pord_id) > > for example: > struct rte_eth_dev * > rte_eth_ge

[dpdk-dev] [PATCH v3] table: fix actions with different data size

2021-03-17 Thread Cristian Dumitrescu
The table layer provisions an action_id and action_data_size data bytes for each table key. This action_data_size is a maximal amount, as some actions (depending on action_id) can require zero or less data bytes than the maximal action_data_size. This fix allows for actions with different data size

Re: [dpdk-dev] [Linuxarm] Re: [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-17 Thread oulijun
在 2021/3/12 19:21, Thomas Monjalon 写道: 12/03/2021 11:29, oulijun: 2021/3/10 15:59, Thomas Monjalon: 10/03/2021 02:48, oulijun: Can we add an API such as rte_eth_get_device(pord_id) for example: struct rte_eth_dev * rte_eth_get_device(uint16_t port_id) { return &rte_eth_devices[po

Re: [dpdk-dev] [PATCH] crypto/octeontx2: remove redundant code

2021-03-17 Thread Anoob Joseph
Acked-by: Anoob Joseph > > Removing redundant field in a union. > > Signed-off-by: Tejasree Kondoj > ---

Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value

2021-03-17 Thread Wang, Haiyue
> -Original Message- > From: Xiaozhen Ban > Sent: Wednesday, March 17, 2021 17:16 > To: Guo, Jia ; Wang, Haiyue > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/e1000: fix filter control return value > > If filter_type not supported, eth_igb_filter_ctrl() will return > incorrec

Re: [dpdk-dev] [PATCH 2/2] doc: add PMD power management to doxygen API index

2021-03-17 Thread Thomas Monjalon
03/03/2021 13:35, Anatoly Burakov: > Currently, the PMD power management API header is missing from the API > index generated by doxygen. Add it. > > Fixes: 682a645438c5 ("power: add ethdev power management") Cc: sta...@dpdk.org > Signed-off-by: Anatoly Burakov [...] > --- a/doc/api/doxy-api-in

[dpdk-dev] [PATCH v3 7/9] net/ice: refine debug build option

2021-03-17 Thread Qi Zhang
1. replace RTE_LIBRTE_ICE_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_ICE_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_ICE_DEBUG_TX_FREE and RTE_ETHDEV_DEBUG into RTE_LIBRTE_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 7 ++- drivers/net/ice/

[dpdk-dev] [PATCH v3 9/9] net/igc: refine debug build option

2021-03-17 Thread Qi Zhang
1. replace RTE_LIBRTE_IGC_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IGC_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/igc/igc_logs.h | 4 ++-- drivers/net/igc/igc_txrx.c | 2 +- 2 files changed, 3 inse

  1   2   >