Re: [dpdk-dev] [PATCH 3/3] drivers: align log names

2021-03-11 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64

2021-03-11 Thread Morten Brørup
CC: ABI Policy maintainers. You might have an opinion. Or not. :-) > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tyler Retzlaff > Sent: Wednesday, March 10, 2021 11:53 PM > > On Wed, Mar 10, 2021 at 10:49:42AM -0800, Stephen Hemminger wrote: > > On Tue, 9 Mar 2021 22:41:06 -0800 > > Tyl

Re: [dpdk-dev] [PATCH 1/2] ethdev: replace callback getting filter operations

2021-03-11 Thread Andrew Rybchenko
On 3/12/21 1:17 AM, Thomas Monjalon wrote: > Since rte_flow is the only API for filtering operations, > the legacy driver interface filter_ctrl was too much complicated > for the simple task of getting the struct rte_flow_ops. > > The filter type RTE_ETH_FILTER_GENERIC and > the filter operarion R

Re: [dpdk-dev] [PATCH] eal: avoid side effects in RTE_ALIGN_MUL_NEAR(v, mul) for v and mul

2021-03-11 Thread Tyler Retzlaff
On Thu, Mar 11, 2021 at 08:41:58PM -0800, Ranjit Menon wrote: > > On 3/11/2021 5:34 PM, Tyler Retzlaff wrote: > >On Thu, Mar 11, 2021 at 04:40:58PM -0800, Ranjit Menon wrote: > >>On 3/11/2021 1:08 PM, Tyler Retzlaff wrote: > >>>diff --git a/lib/librte_eal/include/rte_common.h > >>>b/lib/librte_ea

Re: [dpdk-dev] [PATCH] eal: avoid side effects in RTE_ALIGN_MUL_NEAR(v, mul) for v and mul

2021-03-11 Thread Ranjit Menon
On 3/11/2021 5:34 PM, Tyler Retzlaff wrote: On Thu, Mar 11, 2021 at 04:40:58PM -0800, Ranjit Menon wrote: On 3/11/2021 1:08 PM, Tyler Retzlaff wrote: diff --git a/lib/librte_eal/include/rte_common.h b/lib/librte_eal/include/rte_common.h index 1b630baf1..640befee2 100644 --- a/lib/librte_eal/

Re: [dpdk-dev] [PATCH v2 06/12] net/bnxt: update HWRM structures

2021-03-11 Thread Ajit Khaparde
On Thu, Mar 11, 2021 at 4:08 PM Ferruh Yigit wrote: > > On 3/10/2021 9:26 PM, Ajit Khaparde wrote: > > From: Kalesh AP > > > > Patch brings in the latest hsi_struct_def_dpdk.h. > > HWRM API is now updated to version 1.10.2.15. > > > > Signed-off-by: Kalesh AP > > Reviewed-by: Ajit Khaparde > >

Re: [dpdk-dev] [PATCH 0/3] bnxt fixes

2021-03-11 Thread Ajit Khaparde
On Thu, Mar 4, 2021 at 12:45 AM Kalesh A P wrote: > > From: Kalesh AP > > Please apply. Patchset applied to dpdk-next-net-brcm. Thanks > > Ajit Khaparde (1): > net/bnxt: check flush status during ring free > > Kalesh AP (2): > net/bnxt: fix ver get HWRM command > net/bnxt: fix VF info allo

Re: [dpdk-dev] [PATCH] net/bnxt: rename a member to avoid conflict

2021-03-11 Thread Ajit Khaparde
On Thu, Mar 11, 2021 at 3:30 PM Ajit Khaparde wrote: > > Address build issues with Clang and without glibc on ppc64le. > Vector can be a keyword and should not be used in code. > Renaming it to avoid conflict. > > Reported-by: Piotr Kubaj > Signed-off-by: Ajit Khaparde Patch applied to dpdk-next

Re: [dpdk-dev] [PATCH 0/2] bnxt bug fixes

2021-03-11 Thread Ajit Khaparde
On Tue, Mar 9, 2021 at 11:28 PM Kalesh A P wrote: > > From: Kalesh AP > > This series contain couple of bug fixes in bnxt PMD. > > Kalesh AP (2): > net/bnxt: fix HWRM and FW incompatibility handling > net/bnxt: mute some failure logs Patchset applied to dpdk-next-net-brcm. > > drivers/net/b

Re: [dpdk-dev] [PATCH] net/bnxt: don't set mbuf pointers to null in vector PMD

2021-03-11 Thread Ajit Khaparde
On Tue, Mar 2, 2021 at 7:16 AM Lance Richardson wrote: > > Remove code for setting consumed mbuf pointers to NULL from the > vector receive functions as a minor performance optimization. > > Signed-off-by: Lance Richardson > Reviewed-by: Ajit Kumar Khaparde > Reviewed-by: Somnath Kotur Patch a

Re: [dpdk-dev] [PATCH v3] net/bnxt: fix Rx descriptor status

2021-03-11 Thread Ajit Khaparde
On Thu, Mar 11, 2021 at 12:05 PM Ajit Khaparde wrote: > > From: Lance Richardson > > Fix a number of issues in the bnxt receive descriptor status > function, including: >- Provide status of receive descriptor instead of completion > descriptor. >- Remove invalid comparison of raw rin

[dpdk-dev] [PATCH] net/bnxt: rename a member to avoid conflict

2021-03-11 Thread Ajit Khaparde
Address build issues with Clang and without glibc on ppc64le. Vector can be a keyword and should not be used in code. Renaming it to avoid conflict. Reported-by: Piotr Kubaj Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_irq.c | 2 +- drivers/net/bnxt/bnxt_irq.h | 2 +- 2 files changed,

[dpdk-dev] [PATCH] net/bnxt: address unused variable warning

2021-03-11 Thread Ajit Khaparde
Fix a potential unused variable warning when compiling on PPC. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 3f28e0ea45..b561ff5520 100644

Re: [dpdk-dev] [PATCH v2 4/9] net/hns3: adjust the format of RAS related structures

2021-03-11 Thread Min Hu (Connor)
在 2021/3/12 2:25, Ferruh Yigit 写道: On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: From: Hongbo Zheng Adjust the format of hns3 RAS related structures to resolve the static check warnings of reviewbot_c.This patch has no impact on function. The correspond warnings of reviewbot_c: When struct

Re: [dpdk-dev] [PATCH] app/testpmd: log reason of port start failure

2021-03-11 Thread Li, Xiaoyun
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, March 11, 2021 18:49 > To: Li, Xiaoyun > Cc: dev@dpdk.org > Subject: [PATCH] app/testpmd: log reason of port start failure > > Provide a bit more diagnostics information when port start fails. > > Signed-off-by: Andrew R

Re: [dpdk-dev] [PATCH 1/2] ethdev: replace callback getting filter operations

2021-03-11 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Friday, March 12, 2021 06:18 > To: dev@dpdk.org > Cc: Ori Kam ; Ajit Khaparde ; > Somnath Kotur > ; Chas Williams ; Min Hu (Connor) > ; > Rahul Lakkireddy ; Hemant Agrawal > ; Sachin > Saxena ; Guo, Jia ; Wang, > Haiyue ; > Daley, Jo

Re: [dpdk-dev] [PATCH] eal: avoid side effects in RTE_ALIGN_MUL_NEAR(v, mul) for v and mul

2021-03-11 Thread Tyler Retzlaff
On Thu, Mar 11, 2021 at 04:40:58PM -0800, Ranjit Menon wrote: > > On 3/11/2021 1:08 PM, Tyler Retzlaff wrote: > >diff --git a/lib/librte_eal/include/rte_common.h > >b/lib/librte_eal/include/rte_common.h > >index 1b630baf1..640befee2 100644 > >--- a/lib/librte_eal/include/rte_common.h > >+++ b/lib

[dpdk-dev] [PATCH 3/3] net/i40e: fix segment fault in AVX512

2021-03-11 Thread Wenzhuo Lu
Fix segment fault when failing to get the memory from the pool. Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path") Cc: sta...@dpdk.org Reported-by: David Coyle Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_rxtx_vec_avx512.c | 128 1 file changed, 12

[dpdk-dev] [PATCH 2/3] net/ice: fix segment fault in AVX512

2021-03-11 Thread Wenzhuo Lu
Fix segment fault when failing to get the memory from the pool. Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path") Cc: sta...@dpdk.org Reported-by: David Coyle Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx_vec_avx512.c | 129 ++ 1 file changed, 129

[dpdk-dev] [PATCH 1/3] net/iavf: fix segment fault in AVX512

2021-03-11 Thread Wenzhuo Lu
Fix segment fault when failing to get the memory from the pool. Fixes: 31737f2b66fb ("net/iavf: enable AVX512 for legacy Rx") Cc: sta...@dpdk.org Reported-by: David Coyle Signed-off-by: Wenzhuo Lu --- drivers/net/iavf/iavf_rxtx_vec_avx512.c | 130 1 file change

Re: [dpdk-dev] [PATCH 2/2] drivers/net: remove explicit include of legacy filtering

2021-03-11 Thread Xu, Rosen
Hi, -Original Message- From: Thomas Monjalon Sent: Friday, March 12, 2021 6:18 AM To: dev@dpdk.org Cc: Hemant Agrawal ; Sachin Saxena ; Wu, Jingjing ; Xing, Beilei ; Yang, Qiming ; Zhang, Qi Z ; Guo, Jia ; Wang, Haiyue ; Xu, Rosen Subject: [PATCH 2/2] drivers/net: remove explicit in

Re: [dpdk-dev] [PATCH v2 1/9] net/hns3: support runtime config to select IO burst func

2021-03-11 Thread Min Hu (Connor)
在 2021/3/12 1:39, Ferruh Yigit 写道: On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate function based on offload configuration. Most applications such as l2fwd/l3fwd don't provi

Re: [dpdk-dev] [PATCH v2 1/9] net/hns3: support runtime config to select IO burst func

2021-03-11 Thread Min Hu (Connor)
在 2021/3/12 1:31, Ferruh Yigit 写道: On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate function based on offload configuration. Most applications such as l2fwd/l3fwd don't provi

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-03-11 Thread Ajit Khaparde
On Thu, Mar 11, 2021 at 8:11 AM Piotr Kubaj wrote: > > There are couple of issues when building with Clang: > 1. vector is a keyword and should not be used in code. I undefined it, > but it would probably be better to just change the variable name. > 2. vector long is deprecated by Clang and shoul

Re: [dpdk-dev] [PATCH] eal: avoid side effects in RTE_ALIGN_MUL_NEAR(v, mul) for v and mul

2021-03-11 Thread Ranjit Menon
On 3/11/2021 1:08 PM, Tyler Retzlaff wrote: Avoid expanding v and mul parameters multiple times in the macro. based on usage of the macro it seems like side effects were not intended. For example: ``return RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ);'' Signed-off-by: Tyler Retzl

Re: [dpdk-dev] [PATCH v2 06/12] net/bnxt: update HWRM structures

2021-03-11 Thread Ferruh Yigit
On 3/12/2021 12:17 AM, Ajit Khaparde wrote: On Thu, Mar 11, 2021 at 4:08 PM Ferruh Yigit wrote: On 3/10/2021 9:26 PM, Ajit Khaparde wrote: From: Kalesh AP Patch brings in the latest hsi_struct_def_dpdk.h. HWRM API is now updated to version 1.10.2.15. Signed-off-by: Kalesh AP Reviewed-by:

Re: [dpdk-dev] [PATCH v2 01/12] devtools: update word list

2021-03-11 Thread Ferruh Yigit
On 3/10/2021 9:26 PM, Ajit Khaparde wrote: Update word list with VNIC and Thor to catch errors in patch title. Suggested-by: Ferruh Yigit Signed-off-by: Ajit Khaparde Acked-by: Ferruh Yigit Thanks for the update.

Re: [dpdk-dev] [PATCH v2 06/12] net/bnxt: update HWRM structures

2021-03-11 Thread Ferruh Yigit
On 3/10/2021 9:26 PM, Ajit Khaparde wrote: From: Kalesh AP Patch brings in the latest hsi_struct_def_dpdk.h. HWRM API is now updated to version 1.10.2.15. Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- doc/guides/rel_notes/release_21_05.rst |4 + drivers/net/bnxt/hsi_struct_d

[dpdk-dev] [PATCH v3] net/bnxt: fix Rx descriptor status

2021-03-11 Thread Ajit Khaparde
From: Lance Richardson Fix a number of issues in the bnxt receive descriptor status function, including: - Provide status of receive descriptor instead of completion descriptor. - Remove invalid comparison of raw ring index with masked ring index. - Correct misinterpretation of

[dpdk-dev] [PATCH v2] net/bnxt: fix Rx descriptor status

2021-03-11 Thread Ajit Khaparde
From: Lance Richardson Fix a number of issues in the bnxt receive descriptor status function, including: - Provide status of receive descriptor instead of completion descriptor. - Remove invalid comparison of raw ring index with masked ring index. - Correct misinterpretation of

[dpdk-dev] [PATCH 2/2] drivers/net: remove explicit include of legacy filtering

2021-03-11 Thread Thomas Monjalon
The header file rte_eth_ctrl.h should not be needed because this legacy filtering API is completely replaced with the rte_flow API. However some definitions from this file are still used by some drivers, but such usage is already covered by an implicit include via rte_ethdev.h. Signed-off-by: Thom

[dpdk-dev] [PATCH 1/2] ethdev: replace callback getting filter operations

2021-03-11 Thread Thomas Monjalon
Since rte_flow is the only API for filtering operations, the legacy driver interface filter_ctrl was too much complicated for the simple task of getting the struct rte_flow_ops. The filter type RTE_ETH_FILTER_GENERIC and the filter operarion RTE_ETH_FILTER_GET are removed. The new driver callback

[dpdk-dev] [PATCH 0/2] ethdev: remove some use of legacy filtering interface

2021-03-11 Thread Thomas Monjalon
The ultimate goal is to remove all traces of the legacy filtering API from ethdev_driver.h and rte_eth_ctrl.h (whole file). This is just one more step of cleanup in progress. The next steps will require the involvement of some driver maintainers. Thomas Monjalon (2): ethdev: replace callback ge

Re: [dpdk-dev] [PATCH v2] guides: add a testing guide for developing tests

2021-03-11 Thread David Marchand
On Tue, Mar 9, 2021 at 5:14 PM Aaron Conole wrote: > >>> > +The suites can be selected by adding the ``--suite`` option to the > >>> > +``meson test`` command. Ex: ``meson test --suite fast-tests``:: > >>> > + > >>> > + $ meson test -C build --suite fast-tests > >>> > + ninja: Entering director

Re: [dpdk-dev] [PATCH v2 00/12] bnxt fixes

2021-03-11 Thread Ajit Khaparde
On Wed, Mar 10, 2021 at 1:26 PM Ajit Khaparde wrote: > > This patchset contain bnxt bug fixes and enhancements. > > Please apply. > > v1->v2: > - Updated word list as per recommendation to include VNIC, Thor. > - Fixed checkpatch errors pointed in 2/11. > - Updated release notes to indicate HWR

[dpdk-dev] [PATCH] eal: avoid side effects in RTE_ALIGN_MUL_NEAR(v, mul) for v and mul

2021-03-11 Thread Tyler Retzlaff
Avoid expanding v and mul parameters multiple times in the macro. based on usage of the macro it seems like side effects were not intended. For example: ``return RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ);'' Signed-off-by: Tyler Retzlaff --- lib/librte_eal/include/rte_common.h | 8

Re: [dpdk-dev] [PATCH 1/3] eventdev: introduce adapter flags for periodic mode

2021-03-11 Thread Carrillo, Erik G
Hi Shijith, > -Original Message- > From: Shijith Thotton > Sent: Wednesday, March 10, 2021 3:15 AM > To: Carrillo, Erik G > Cc: Shijith Thotton ; Pavan Nikhilesh > ; Jerin Jacob ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] eventdev: introduce adapter flags for > periodic mode >

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: reduce log level of alignment message

2021-03-11 Thread Matan Azrad
From: Thomas Monjalon > Having to force an alignment does not impact the user, so it should not be a > warning. > The log level is reduced from warning to debug. > > Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v2 3/4] common/mlx5: remove extra line feed in log messages

2021-03-11 Thread Matan Azrad
From: Thomas Monjalon > The macro DRV_LOG already includes a terminating line feed character > defined in PMD_DRV_LOG_. > The extra line feeds added in some messages are removed. > > Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v2 2/4] common/mlx5: enable debug logs dynamically

2021-03-11 Thread Matan Azrad
From: Thomas Monjalon > Most debug logs are using DRV_LOG(DEBUG,) but some were using DEBUG(). > The macro DEBUG is doing nothing if not compiled with > RTE_LIBRTE_MLX5_DEBUG. > > As it is not used in the data path, the macro DEBUG can be replaced with > DRV_LOG. > Then all debug logs can be en

Re: [dpdk-dev] [PATCH v2 1/4] net/mlx4: enable debug logs dynamically

2021-03-11 Thread Matan Azrad
From: Thomas Monjalon > The macro DEBUG was doing nothing if not compiled with > RTE_LIBRTE_MLX4_DEBUG. > > As it is not used in the data path, it can be always enabled at compilation > time. > Then it can be enabled at runtime with: > --log-level pmd.net.mlx4:debug > > Signed-off-by:

Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx metadata leftovers

2021-03-11 Thread Matan Azrad
From: Viacheslav Ovsiienko > The Rx metadata might use the metadata register C0 to keep the values. The > same register C0 might be used by kernel for source vport value handling, > kernel uses upper half of the register, leaving the lower half for application > usage. > > In the extended metad

Re: [dpdk-dev] [PATCH 5/5] compress/mlx5: add timestamp format support

2021-03-11 Thread Matan Azrad
From: Viacheslav Ovsiienko > This patch add support for the timestamp format settings for the receive and > send queues. If the firmware version x.30.256 or above is installed and the > NIC > timestamps are configured with the real-time format, the default zero values > for new added values cau

Re: [dpdk-dev] [PATCH 4/5] regex/mlx5: add timestamp format support

2021-03-11 Thread Matan Azrad
From: Viacheslav Ovsiienko > This patch adds support for the timestamp format settings for the receive and > send queues. If the firmware version x.30.256 or above is installed and the > NIC > timestamps are configured with the real-time format, the default zero values > for new added values ca

Re: [dpdk-dev] [PATCH 3/5] vdpa/mlx5: add timestamp format support

2021-03-11 Thread Matan Azrad
From: Viacheslav Ovsiienko > This patch adds support for the timestamp format settings for the queues > pairs. > If the firmware version x.30.256 or above is installed and the NIC timestamps > are configured with the real-time format, the default zero values for new > added values cause the que

Re: [dpdk-dev] [PATCH 2/5] net/mlx5: add timestamp format support

2021-03-11 Thread Matan Azrad
From: Viacheslav Ovsiienko > This patch adds support for the timestamp format settings for the receive and > send queues. If the firmware version x.30.256 or above is installed and the > NIC > timestamps are configured with the real-time format, the default zero values > for new added values ca

Re: [dpdk-dev] [PATCH 1/5] common/mlx5: add timestamp format support to DevX

2021-03-11 Thread Matan Azrad
From: Viacheslav Ovsiienko > This patch handles the NIC supported timestamp formats via DevX. > There are two different timestamp format can be provided potentially. > The free-running is some opaque values captured from internal clock counter > clocked by some independent oscillator. The free-r

[dpdk-dev] [PATCH] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-11 Thread Tyler Retzlaff
Introduce a meson option enable_driver_sdk when true installs internal driver headers for ethdev. this allows drivers that do not depend on stable api/abi to be built external to the dpdk source tree. Signed-off-by: Tyler Retzlaff --- it's still unclear to me if we should be renaming the headers

Re: [dpdk-dev] [PATCH v2 4/9] net/hns3: adjust the format of RAS related structures

2021-03-11 Thread Ferruh Yigit
On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: From: Hongbo Zheng Adjust the format of hns3 RAS related structures to resolve the static check warnings of reviewbot_c.This patch has no impact on function. The correspond warnings of reviewbot_c: When struct and union members are initialized, each

Re: [dpdk-dev] [PATCH v2 2/9] net/hns3: support Tx push quick doorbell to improve perf

2021-03-11 Thread Ferruh Yigit
On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: From: Chengwen Feng Kunpeng 930 support Tx push mode which could improve performance, It works like below: 1. Add pcie bar45 which support driver direct write the Tx descriptor or tail reg to it. 2. Support three operations: a) direct write one Tx de

Re: [dpdk-dev] [PATCH v2 1/9] net/hns3: support runtime config to select IO burst func

2021-03-11 Thread Ferruh Yigit
On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate function based on offload configuration. Most applications such as l2fwd/l3fwd don't provide the means to change offload configur

Re: [dpdk-dev] [PATCH v2 1/9] net/hns3: support runtime config to select IO burst func

2021-03-11 Thread Ferruh Yigit
On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate function based on offload configuration. Most applications such as l2fwd/l3fwd don't provide the means to change offload configur

Re: [dpdk-dev] [dpdk-techboard] RFC: DPDK drivers for DPDK bus types

2021-03-11 Thread Bruce Richardson
On Thu, Mar 11, 2021 at 06:06:48PM +0100, Thomas Monjalon wrote: > 11/03/2021 17:45, Bruce Richardson: > > On Thu, Mar 11, 2021 at 04:40:14PM +, Bruce Richardson wrote: > > > On Thu, Mar 11, 2021 at 04:44:49PM +0100, Thomas Monjalon wrote: > > > > 11/03/2021 16:19, Bruce Richardson: > > > > > H

Re: [dpdk-dev] [PATCH v16 1/3] build: disable/enable drivers in Arm builds

2021-03-11 Thread Jerin Jacob
On Thu, Mar 11, 2021 at 1:06 AM Honnappa Nagarahalli wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Mar 09, 2021 at 08:58:39AM +, Juraj Linkeš > > wrote: > > > > > > > > > > > > Honnappa, Thomas, Bruce, Jerin, you've comments in the > > past. > > > > > > > > > >

Re: [dpdk-dev] [PATCH v2] doc: announce API changes for Windows compatibility

2021-03-11 Thread Tyler Retzlaff
On Thu, Mar 11, 2021 at 08:01:01PM +0300, Dmitry Kozlyuk wrote: > 2021-03-11 16:19 (UTC+), John Alexander: > [...] > > > * `struct rte_param_log2_range`, `struct rte_crypto_param_range`: > > > > > > * `min` -> `minimum` > > > * `max` -> `maximum` > > > > > > The min/max macros in t

Re: [dpdk-dev] [dpdk-techboard] RFC: DPDK drivers for DPDK bus types

2021-03-11 Thread Thomas Monjalon
11/03/2021 17:45, Bruce Richardson: > On Thu, Mar 11, 2021 at 04:40:14PM +, Bruce Richardson wrote: > > On Thu, Mar 11, 2021 at 04:44:49PM +0100, Thomas Monjalon wrote: > > > 11/03/2021 16:19, Bruce Richardson: > > > > Hi all, > > > > > > > > looking for input here into the area of bus-type dr

Re: [dpdk-dev] [PATCH v2] doc: announce API changes for Windows compatibility

2021-03-11 Thread Dmitry Kozlyuk
2021-03-11 16:19 (UTC+), John Alexander: [...] > > * `struct rte_param_log2_range`, `struct rte_crypto_param_range`: > > > > * `min` -> `minimum` > > * `max` -> `maximum` > > > The min/max macros in the Windows headers cause issues with C++ projects also > (breaks std::min/std::ma

Re: [dpdk-dev] [dpdk-techboard] RFC: DPDK drivers for DPDK bus types

2021-03-11 Thread Bruce Richardson
On Thu, Mar 11, 2021 at 04:40:14PM +, Bruce Richardson wrote: > On Thu, Mar 11, 2021 at 04:44:49PM +0100, Thomas Monjalon wrote: > > 11/03/2021 16:19, Bruce Richardson: > > > Hi all, > > > > > > looking for input here into the area of bus-type drivers and interaction > > > with other drivers i

Re: [dpdk-dev] [dpdk-techboard] RFC: DPDK drivers for DPDK bus types

2021-03-11 Thread Bruce Richardson
On Thu, Mar 11, 2021 at 04:44:49PM +0100, Thomas Monjalon wrote: > 11/03/2021 16:19, Bruce Richardson: > > Hi all, > > > > looking for input here into the area of bus-type drivers and interaction > > with other drivers in DPDK. > > > > By way of context, I'm looking at extending the vdev support

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2021-03-11 Thread Jan Viktorin
On Thu, 11 Mar 2021 02:11:07 + "Jiawei(Jonny) Wang" wrote: > Hi Jan, > > Sorry for late response, > > First rule is invalid, port only works on FDB domain so need 'transfer' here; > Second rule should be ok, could you please check if the port 1 was enabled > on you dpdk application? I a

Re: [dpdk-dev] [PATCH v2] doc: announce API changes for Windows compatibility

2021-03-11 Thread John Alexander
> -Original Message- > From: dev On Behalf Of Dmitry Kozlyuk > Sent: 10 March 2021 23:54 > To: dev@dpdk.org > Cc: Ferruh Yigit ; Pallavi Kadam > ; Dmitry Malloy ; > Narcisa Ana Maria Vasile ; Stephen > Hemminger ; Tyler Retzlaff > ; Declan Doherty > ; Fiona Trahe ; Ashish > Gupta ; Dmitr

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-11 Thread Honnappa Nagarahalli
> > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > wrote: > > > > > > > > Hello, > > > > Performance of L3fwd example application is one of the key > > > benchmarks in DPDK. However, the application does not have many > > > debugging statistics to understand the

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-11 Thread Thomas Monjalon
11/03/2021 16:18, Honnappa Nagarahalli: > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > wrote: > > > > > > Hello, > > > Performance of L3fwd example application is one of the key > > benchmarks in DPDK. However, the application does not have many > > debugging stat

Re: [dpdk-dev] [dpdk-techboard] RFC: DPDK drivers for DPDK bus types

2021-03-11 Thread Thomas Monjalon
11/03/2021 16:19, Bruce Richardson: > Hi all, > > looking for input here into the area of bus-type drivers and interaction > with other drivers in DPDK. > > By way of context, I'm looking at extending the vdev support in the > "raw/ioat" driver (file raw/ioat/idxd_vdev.c) to make it more user > f

[dpdk-dev] RFC: DPDK drivers for DPDK bus types

2021-03-11 Thread Bruce Richardson
Hi all, looking for input here into the area of bus-type drivers and interaction with other drivers in DPDK. By way of context, I'm looking at extending the vdev support in the "raw/ioat" driver (file raw/ioat/idxd_vdev.c) to make it more user friendly. These devices are accessed by DPDK via nod

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-11 Thread Honnappa Nagarahalli
> > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > wrote: > > > > Hello, > > Performance of L3fwd example application is one of the key > benchmarks in DPDK. However, the application does not have many > debugging statistics to understand the performance issues. We have added >

[dpdk-dev] DPDK Release Status Meeting 11/03/2021

2021-03-11 Thread Ferruh Yigit
Release status meeting minutes {Date} = :Date: 11 March 2021 :toc: .Agenda: * Release Dates * Subtrees * LTS * Conferences * Opens .Participants: * Arm * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - * `v21.05` dates - P

Re: [dpdk-dev] [PATCH v1] net/iavf: implement power management API

2021-03-11 Thread Burakov, Anatoly
On 11-Mar-21 11:55 AM, David Hunt wrote: Implement support for the power management API by implementing a `get_monitor_addr` function that will return an address of an RX ring's status bit. This patch is basically a cut-and-paste of the changes already committed in ixgbe, i40e and ice drivers in

Re: [dpdk-dev] [PATCH v8 8/9] ethdev: representor iterator compare complete info

2021-03-11 Thread Xueming(Steven) Li
>-Original Message- >From: Andrew Rybchenko >Sent: Tuesday, March 9, 2021 4:20 PM >To: Xueming(Steven) Li >Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso >; NBU-Contact-Thomas Monjalon >; Ferruh Yigit ; Ray Kinsella >; Neil Horman > >Subject: Re: [PATCH v8 8/9] ethdev: representor ite

Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD

2021-03-11 Thread Ed Czeck
On Wed, Mar 10, 2021 at 5:46 PM Ferruh Yigit wrote: > > On 3/10/2021 9:53 PM, Ed Czeck wrote: > > On Wed, Mar 10, 2021 at 11:44 AM Ferruh Yigit > > wrote: > >> > >> On 3/10/2021 3:02 PM, Ed Czeck wrote: > >>> On Tue, Mar 9, 2021 at 12:36 PM Ferruh Yigit > >>> wrote: > > On 3/9/2021 4

[dpdk-dev] [PATCH v9 10/10] doc/release: add representor enhancements

2021-03-11 Thread Xueming Li
Updates 21.05 release notes to include representor enhancements. Signed-off-by: Xueming Li --- doc/guides/rel_notes/release_21_05.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst index 23f

[dpdk-dev] [PATCH v9 09/10] ethdev: representor iterator compare complete info

2021-03-11 Thread Xueming Li
The NIC can have multiple PCIe links and can be attached to multiple hosts, for example the same single NIC can be shared for multiple server units in the rack. On each PCIe link NIC can provide multiple PFs and VFs/SFs based on these ones. The full representor identifier consists of three indices

[dpdk-dev] [PATCH v9 08/10] ethdev: new API to get representor info

2021-03-11 Thread Xueming Li
The NIC can have multiple PCIe links and can be attached to multiple hosts, for example the same single NIC can be shared for multiple server units in the rack. On each PCIe link NIC can provide multiple PFs and VFs/SFs based on these ones. The full representor identifier consists of three indices

[dpdk-dev] [PATCH v9 07/10] ethdev: support multi-host in representor

2021-03-11 Thread Xueming Li
The NIC can have multiple PCIe links and can be attached to the multiple hosts, for example the same single NIC can be shared for multiple server units in the rack. On each PCIe link NIC can provide multiple PFs and VFs/SFs based on these ones. To provide the unambiguous identification of the PCIe

[dpdk-dev] [PATCH v9 06/10] ethdev: support PF index in representor

2021-03-11 Thread Xueming Li
With Kernel bonding, multiple underlying PFs are bonded, VFs come from different PF, need to identify representor of VFs unambiguously by adding PF index. This patch introduces optional 'pf' section to representor devargs syntax, examples: representor=pf0vf0 - single VF representor r

[dpdk-dev] [PATCH v9 05/10] kvargs: update parser to support multiple lists

2021-03-11 Thread Xueming Li
This patch updates kvargs parser to support value of multiple lists or ranges: k1=v[1,2]v[3-5] Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko Acked-by: Thomas Monjalon --- app/test/test_kvargs.c | 46 +-- lib/librte_kvargs/rte_kvargs.c | 101 +++

[dpdk-dev] [PATCH v9 04/10] ethdev: support sub function representor

2021-03-11 Thread Xueming Li
SubFunction is a portion of the PCI device, created on demand, a SF netdev has its own dedicated queues(txq, rxq). A SF netdev supports eswitch representation offload similar to existing PF and VF representors. To support SF representor, this patch introduces new devargs syntax, examples: represe

[dpdk-dev] [PATCH v9 03/10] ethdev: support new VF representor syntax

2021-03-11 Thread Xueming Li
Current VF representor syntax: representor=2 - single representor representor=[0-3] - single range To prepare for more representor types, this patch adds compatible VF representor devargs syntax: vf#: representor=vf2 - single representor representor=vf[1,3,5]- singl

[dpdk-dev] [PATCH v9 02/10] ethdev: refactor representor port list parsing

2021-03-11 Thread Xueming Li
To the extended representor syntax which need to reuse the value parsing function for controller and pf section, this patch refactors the port list parsing. Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko Acked-by: Thomas Monjalon Acked-by: Andrew Rybchenko --- lib/librte_ethdev/ethd

[dpdk-dev] [PATCH v9 01/10] ethdev: introduce representor type

2021-03-11 Thread Xueming Li
To support more representor type, this patch introduces representor type enum. The enum is subject to be extended to support new representor in patches upcoming. For each devarg structure, only one type supported. Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko Acked-by: Thomas Monjalo

[dpdk-dev] [PATCH v9 00/10] ethdev: support SubFunction representor

2021-03-11 Thread Xueming Li
SubFunction [1] is a portion of the PCI device, a SF netdev has its own dedicated queues(txq, rxq). A SF netdev supports E-Switch representation offload similar to existing PF and VF representors. A SF shares PCI level resources with other SFs and/or with its parent PCI function. >From SmartNIC pe

[dpdk-dev] [RFC] bus/auxiliary: introduce auxiliary bus

2021-03-11 Thread Xueming Li
Auxiliary [1] provides a way to split function into child-devices representing sub-domains of functionality. Each auxiliary_device represents a part of its parent functionality. Auxiliary device is identified by unique device name, sysfs path: /sys/bus/auxiliary/devices/ [1] kernel auxiliary bu

Re: [dpdk-dev] [PATCH 4/4] telemetry: move init function to internal header

2021-03-11 Thread Power, Ciara
>-Original Message- >From: dev On Behalf Of Bruce Richardson >Sent: Wednesday 10 March 2021 17:25 >To: dev@dpdk.org >Cc: Richardson, Bruce ; Laatz, Kevin > >Subject: [dpdk-dev] [PATCH 4/4] telemetry: move init function to internal >header > >The rte_telemetry_init() function is for EAL u

Re: [dpdk-dev] [PATCH 3/4] telemetry: create internal-only header file

2021-03-11 Thread Power, Ciara
>-Original Message- >From: dev On Behalf Of Bruce Richardson >Sent: Wednesday 10 March 2021 17:24 >To: dev@dpdk.org >Cc: Richardson, Bruce ; Laatz, Kevin > >Subject: [dpdk-dev] [PATCH 3/4] telemetry: create internal-only header file > >The header file containing the legacy telemetry func

Re: [dpdk-dev] [PATCH 2/4] telemetry: make the legacy registration function internal

2021-03-11 Thread Power, Ciara
>-Original Message- >From: dev On Behalf Of Bruce Richardson >Sent: Wednesday 10 March 2021 17:24 >To: dev@dpdk.org >Cc: Richardson, Bruce ; Laatz, Kevin >; Ray Kinsella ; Neil Horman > >Subject: [dpdk-dev] [PATCH 2/4] telemetry: make the legacy registration >function internal > >The fun

Re: [dpdk-dev] [PATCH 1/4] telemetry: use rte_log for logging

2021-03-11 Thread Power, Ciara
>-Original Message- >From: dev On Behalf Of Bruce Richardson >Sent: Wednesday 10 March 2021 17:24 >To: dev@dpdk.org >Cc: Richardson, Bruce ; Laatz, Kevin > >Subject: [dpdk-dev] [PATCH 1/4] telemetry: use rte_log for logging > >Rather than passing back an error string to the caller, take

[dpdk-dev] [PATCH 2/2] common/sfc_efx: remove GENEVE from list of supported tunnels

2021-03-11 Thread Andrew Rybchenko
The first GA of the SN1022 does not support Geneve. Fixes: d874d2a149ed ("common/sfc_efx/base: support UDP tunnel operations for EF100") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/rhead_nic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/co

[dpdk-dev] [PATCH 1/2] net/sfc: improve tunnel TSO mask calculation

2021-03-11 Thread Andrew Rybchenko
Corresponding tunnel TSO is not supported if the tunnel is not supported. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_tx.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c index 4db39415de..28d696de61

Re: [dpdk-dev] [PATCH] eal: allow user to override DPDK runtime path

2021-03-11 Thread Bruce Richardson
On Wed, Mar 10, 2021 at 10:33:50AM -0800, Stephen Hemminger wrote: > On Wed, 10 Mar 2021 17:27:17 + > Bruce Richardson wrote: > > > On Wed, Mar 10, 2021 at 09:21:37AM -0800, Stephen Hemminger wrote: > > > There can be cases such as containers or other runtime environments > > > where DPDK may

[dpdk-dev] [PATCH v4 3/5] examples/l3fwd: add FIB infrastructure

2021-03-11 Thread Conor Walsh
The purpose of this commit is to add the necessary function calls and supporting infrastructure to allow the Forwarding Information Base (FIB) library to be integrated into the l3fwd sample app. Instead of adding an individual flag for FIB, a new flag '--lookup' has been added that allows the user

[dpdk-dev] [Bug 656] CVE-YYYY-NNNN State: Report

2021-03-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=656 Bug ID: 656 Summary: CVE-- State: Report Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: High

[dpdk-dev] [PATCH v4 5/5] doc/guides/l3_forward: update documentation for FIB

2021-03-11 Thread Conor Walsh
The purpose of this patch is to update the l3fwd user guide to include the changes proposed in this patchset. Signed-off-by: Conor Walsh --- doc/guides/sample_app_ug/l3_forward.rst | 113 +--- 1 file changed, 100 insertions(+), 13 deletions(-) diff --git a/doc/guides/sample_

[dpdk-dev] [PATCH v4 4/5] examples/l3fwd: implement FIB lookup method

2021-03-11 Thread Conor Walsh
This patch implements the Forwarding Information Base (FIB) library in l3fwd using the function calls and infrastructure introduced in the previous patch. Signed-off-by: Conor Walsh Acked-by: Konstantin Ananyev --- examples/l3fwd/l3fwd_fib.c | 482 - 1 file c

[dpdk-dev] [PATCH v4 2/5] examples/l3fwd: move l3fwd routes to common header

2021-03-11 Thread Conor Walsh
To prevent code duplication from the addition of lookup methods the routes specified in lpm should be moved to a common header. Signed-off-by: Conor Walsh Acked-by: Konstantin Ananyev Acked-by: Vladimir Medvedkin --- examples/l3fwd/l3fwd_common_route.h | 48 +++ examples/l3fwd/

[dpdk-dev] [PATCH v4 1/5] examples/l3fwd: fix LPM IPv6 subnets

2021-03-11 Thread Conor Walsh
The IPv6 subnets used were not within the 2001:200::/48 subnet Changed to 2001:200:0:{0-7}::/64 where 0-7 is the port ID Fixes: 37afe381bde4 ("examples/l3fwd: use reserved IP addresses") Signed-off-by: Conor Walsh Acked-by: Vladimir Medvedkin --- examples/l3fwd/l3fwd_lpm.c | 26 +++

[dpdk-dev] [PATCH v4 0/5] examples/l3fwd: add FIB lookup method to l3fwd

2021-03-11 Thread Conor Walsh
Currently the l3fwd sample app supports LPM and EM lookup methods this patchset implements the FIB library as another lookup method for l3fwd. Instead of adding an individual flag for FIB, a new flag '--lookup' has been added that allows the user to select their desired lookup method. The flags '-E

[dpdk-dev] [PATCH v1] net/iavf: implement power management API

2021-03-11 Thread David Hunt
Implement support for the power management API by implementing a `get_monitor_addr` function that will return an address of an RX ring's status bit. This patch is basically a cut-and-paste of the changes already committed in ixgbe, i40e and ice drivers in 21.02. This extends the availability of th

Re: [dpdk-dev] [PATCH v11 0/2] support both PIO and MMIO BAR for legacy virito device

2021-03-11 Thread Wang, Yinan
Tested-by: Wang, Yinan Tested PVP case with virtio PMD assumes legacy device, VM with below kernel LTS versions, all pass except vfio-pci test blocked with kernel v4.4. 5.10.0-051000-generic virtio-pmd test with vfio-pci/ igb_uio/uio_pci_generic all pass 5.4.0-050400-gener

[dpdk-dev] [PATCH 8/8] drivers: add common driver API to get efx family

2021-03-11 Thread Andrew Rybchenko
From: Vijay Kumar Srivastava Move function to get efx family from net driver into common driver. Signed-off-by: Vijay Kumar Srivastava Signed-off-by: Andrew Rybchenko --- drivers/common/meson.build | 2 +- drivers/common/sfc_efx/meson.build | 1 + drivers/common/sfc_efx/sfc_efx.c

[dpdk-dev] [PATCH 7/8] net/sfc: skip driver probe for incompatible device class

2021-03-11 Thread Andrew Rybchenko
From: Vijay Kumar Srivastava Driver would be probed only for the net device class. Signed-off-by: Vijay Kumar Srivastava Signed-off-by: Andrew Rybchenko --- doc/guides/nics/sfc_efx.rst | 8 drivers/net/sfc/sfc.h| 1 + drivers/net/sfc/sfc_ethdev.c | 7 +++ drivers/net/sfc

  1   2   >