[dpdk-dev] [RFC] drivers: introduce mlx5 crypto PMD

2021-03-10 Thread Matan Azrad
From: Shiri Kuzin Add a new PMD for Mellanox devices- crypto PMD. The crypto PMD will be supported starting Mellanox ConnectX6 and BlueField2. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5

[dpdk-dev] [PATCH] vhost: add header check in dequeue offload

2021-03-10 Thread Xiao Wang
When parsing the virtio net header and packet header for dequeue offload, we need to perform sanity check on the packet header to ensure: - No out-of-boundary memory access. - The packet header and virtio_net header are valid and aligned. Fixes: d0cf91303d73 ("vhost: add Tx offload capabilitie

Re: [dpdk-dev] [PATCH v11 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-10 Thread Wang, Haiyue
Hi Huawei, > -Original Message- > From: dev On Behalf Of ???() > Sent: Thursday, March 11, 2021 01:37 > To: david.march...@redhat.com; maxime.coque...@redhat.com; Yigit, Ferruh > > Cc: dev@dpdk.org; Burakov, Anatoly ; > xuemi...@nvidia.com; gr...@u256.net; > 谢华伟(此时此刻) > Subject: [

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-10 Thread Jerin Jacob
On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli wrote: > > Hello, > Performance of L3fwd example application is one of the key benchmarks > in DPDK. However, the application does not have many debugging statistics to > understand the performance issues. We have added L3fwd as anoth

[dpdk-dev] [PATCH] examples/packet_ordering: use local port config

2021-03-10 Thread dapengx . yu
From: Dapeng Yu A global ethernet port configuration is assigned to local variable because in this way the local variable may be updated as required. But this local variable is not used as input of rte_eth_dev_configure() in original implementation, and cause that fast mbuf free feature cannot be

Re: [dpdk-dev] [PATCH 3/3] drivers: align log names

2021-03-10 Thread Wang, Xiao W
Hi, BRs, Xiao > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 10, 2021 10:01 PM > To: dev@dpdk.org > Cc: Griffin, John ; Trahe, Fiona > ; Jain, Deepak K ; Ajit > Khaparde ; Raveendra Padasalagi > ; Vikas Gupta > ; Xu, Rosen ; Zhang, > Tianfei ; Richardson, Bruce > ;

Re: [dpdk-dev] [PATCH 3/3] drivers: align log names

2021-03-10 Thread Xu, Rosen
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 10, 2021 22:01 > To: dev@dpdk.org > Cc: Griffin, John ; Trahe, Fiona > ; Jain, Deepak K ; Ajit > Khaparde ; Raveendra Padasalagi > ; Vikas Gupta > ; Xu, Rosen ; Zhang, > Tianfei ; Richardson, Bruce > ; Nipun Gupta ;

[dpdk-dev] [PATCH v2] app/testpmd: support multi-process

2021-03-10 Thread Min Hu (Connor)
From: Lijun Ou This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ --rxq=4 --t

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2021-03-10 Thread Jiawei(Jonny) Wang
Hi Jan, Sorry for late response, First rule is invalid, port only works on FDB domain so need 'transfer' here; Second rule should be ok, could you please check if the port 1 was enabled on you dpdk application? Thanks. Jonny > -Original Message- > From: Jan Viktorin > Sent: Monday,

[dpdk-dev] [PATCH v2 12/12] net/bnxt: fix PTP support for Thor

2021-03-10 Thread Ajit Khaparde
From: Kalesh AP On Thor, Rx timestamp is present in the Rx completion record. Only 32 bits of the timestamp is present in the completion. The driver needs to periodically poll the current 48 bit free running timer using the HWRM_PORT_TS_QUERY command. It can combine the upper 16 bits from the HWR

[dpdk-dev] [PATCH v2 10/12] net/bnxt: fix firmware fatal error handling

2021-03-10 Thread Ajit Khaparde
From: Kalesh AP During some fatal firmware error conditions, the PCI config space register 0x2e which normally contains the subsystem ID will become 0x. This register will revert back to the normal value after the chip has completed core reset. If we detect this condition, we can poll this co

[dpdk-dev] [PATCH v2 09/12] net/bnxt: handle echo request async message

2021-03-10 Thread Ajit Khaparde
From: Kalesh AP This is a new async message that the firmware can send to check if it can communicate with the driver. This is an added error detection scheme that firmware can use if it suspects errors in the PCIe interface. When the driver receives this async message, it will reply back echoing

[dpdk-dev] [PATCH v2 11/12] net/bnxt: fix FW readiness check during recovery

2021-03-10 Thread Ajit Khaparde
From: Kalesh AP Moved fw readiness check to a new routine bnxt_check_fw_ready(). During error recovery, driver needs to wait for fw readiness. For that, it uses bnxt_hwrm_ver_get() function now and that function does parsing of the VER_GET response as well. Added a new lightweight function bnxt

[dpdk-dev] [PATCH v2 05/12] net/bnxt: fix queues per VNIC

2021-03-10 Thread Ajit Khaparde
From: Venkat Duvvuru Update queues per VNIC in single queue mode. bp->rx_num_qs_per_vnic is not initialized in the single queue mode. As a result of this when an interface is reconfigured to single queue mode from an existing multiqueue mode, bp->rx_num_qs_per_vnic is not updated to the value of

[dpdk-dev] [PATCH v2 08/12] net/bnxt: log port id in async events

2021-03-10 Thread Ajit Khaparde
From: Kalesh AP 1. Used port id in async event logs. 2. Added a debug log in bnxt_hwrm_func_driver_unregister(). Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c | 14 +- drivers/net/bnxt/bnxt_hwrm.c | 2 ++ 2 files

[dpdk-dev] [PATCH v2 07/12] net/bnxt: update to new version of backing store

2021-03-10 Thread Ajit Khaparde
Update HWRM headers to version 1.10.2.15 which updates the backing store API for additional TQM rings. Add support for 9th TQM ring using latest firmware interface. Also make sure that we set only necessary bits in the enables field in backing store request. Signed-off-by: Ajit Khaparde Reviewed

[dpdk-dev] [PATCH v2 03/12] net/bnxt: fix VNIC configuration

2021-03-10 Thread Ajit Khaparde
From: Kalesh AP PMD should not set any flags to receive RoCE traffic while configuring the vnic. Since the PMD does not support RoCE some of the flags and code is unused. Clean it up. Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Cc: sta...@dpdk.org Signed

[dpdk-dev] [PATCH v2 04/12] net/bnxt: remove extra blank line

2021-03-10 Thread Ajit Khaparde
From: Kalesh AP Removed an unnecessary extra blank line. Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_hwrm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 5366fe72ca..e11502c706 100644 ---

[dpdk-dev] [PATCH v2 02/12] net/bnxt: remove unused macro

2021-03-10 Thread Ajit Khaparde
From: Kalesh AP remove HWRM_SEQ_ID_INVALID macro. Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.h | 1 - 1 file changed, 1 deletion(-

[dpdk-dev] [PATCH v2 0/3] Support ice PMD on Windows

2021-03-10 Thread Pallavi Kadam
This patch-set enables building the Intel ice PMD on Windows. v2 changes: - Updated patch#1 title to reflect the iavf base code support - Added cflag '-fno-asynchronous-unwind-tables' to base driver - Updated doc patch with the DDP documentation and integrated it

[dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows

2021-03-10 Thread Pallavi Kadam
- Add Intel ice PMD support on Windows. - Remove #include sys/ioctl header file as it is not needed. - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types. - Replace POSIX usleep() API with rte API. - Add a new macro for the access() API as the original function has been de

[dpdk-dev] [PATCH v2 01/12] devtools: update word list

2021-03-10 Thread Ajit Khaparde
Update word list with VNIC and Thor to catch errors in patch title. Suggested-by: Ferruh Yigit Signed-off-by: Ajit Khaparde --- devtools/words-case.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/devtools/words-case.txt b/devtools/words-case.txt index 38084ec883..a0ff8eb5b9 100644 ---

[dpdk-dev] [PATCH v2 00/12] bnxt fixes

2021-03-10 Thread Ajit Khaparde
This patchset contain bnxt bug fixes and enhancements. Please apply. v1->v2: - Updated word list as per recommendation to include VNIC, Thor. - Fixed checkpatch errors pointed in 2/11. - Updated release notes to indicate HWRM API version change. - Check and addressed warnings reported by chec

[dpdk-dev] [PATCH v2 1/3] build: enable iavf base code to build on windows

2021-03-10 Thread Pallavi Kadam
Enable IAVF driver to build on Windows as it is required to build ice PMD. Disable all other drivers from common directory. This patch also includes fix for a macro redefinition warning in the IAVF driver. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- drivers/common/cpt/meson.build

[dpdk-dev] [PATCH v2 3/3] net/ice: disable ice DDP package on Windows

2021-03-10 Thread Pallavi Kadam
Disable loading of external DDP package as it is not supported on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- drivers/net/ice/ice_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index d22bc92f

[dpdk-dev] [PATCH v2] doc: announce API changes for Windows compatibility

2021-03-10 Thread Dmitry Kozlyuk
Windows socket headers define `s_addr`, `min`, and `max` macros which break structure definitions containing fields with one of these names. Undefining those macros would break some consumers as well. Example 1: #include #include struct in_addr addr; /* addr.s_addr = 0; ERRO

[dpdk-dev] [PATCH] doc: propose correction rte_bsf64 return type declaration

2021-03-10 Thread Tyler Retzlaff
It is clear from the change that introduced the rte_bsf64 inline function and an evaluation of usage that the initial revision was intended to return uint32_t and not int. It is proposed the return type of int be changed to uint32_t. -static inline int +static inline uint32_t rte_bsf64(uint64_t

Re: [dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64

2021-03-10 Thread Tyler Retzlaff
On Wed, Mar 10, 2021 at 10:49:42AM -0800, Stephen Hemminger wrote: > On Tue, 9 Mar 2021 22:41:06 -0800 > Tyler Retzlaff wrote: > > > based on the original commit and the usage of rte_bsf64 it appears the > > function should always have returned uint32_t instead of int which is > > consistent wit

Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD

2021-03-10 Thread Ferruh Yigit
On 3/10/2021 9:53 PM, Ed Czeck wrote: On Wed, Mar 10, 2021 at 11:44 AM Ferruh Yigit wrote: On 3/10/2021 3:02 PM, Ed Czeck wrote: On Tue, Mar 9, 2021 at 12:36 PM Ferruh Yigit wrote: On 3/9/2021 4:08 PM, Ed Czeck wrote: In this commit we generalize the movement of user-specified meta data b

[dpdk-dev] [PATCH v2] update Intel roadmap for 21.05

2021-03-10 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- v2: * there won't be a new driver for dlb2.5 * reword thash library support --- content/roadmap/_index.md | 10 ++ 1 file changed, 10 insertions(+) diff --git a/content/roadmap/_index.md b/content/roadmap/_index.md index c6a67a986876..f97818266765 100644 -

Re: [dpdk-dev] [PATCH v3 0/7] Enhancements and fixes for flow-perf

2021-03-10 Thread Alexander Kozyrev
> -Original Message- > From: Wisam Monther > Sent: Wednesday, March 10, 2021 8:56 > To: arybche...@solarflare.com; NBU-Contact-Thomas Monjalon > ; Alexander Kozyrev ; > Raslan Darawsheh ; dev@dpdk.org > Subject: [PATCH v3 0/7] Enhancements and fixes for flow-perf > > -- > v2: > * Add

Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD

2021-03-10 Thread Ed Czeck
On Wed, Mar 10, 2021 at 11:44 AM Ferruh Yigit wrote: > > On 3/10/2021 3:02 PM, Ed Czeck wrote: > > On Tue, Mar 9, 2021 at 12:36 PM Ferruh Yigit wrote: > >> > >> On 3/9/2021 4:08 PM, Ed Czeck wrote: > >>> In this commit we generalize the movement of user-specified > >>> meta data between mbufs and

Re: [dpdk-dev] [dpdk-web] [PATCH] update Intel roadmap for 21.05

2021-03-10 Thread Ferruh Yigit
On 3/10/2021 8:20 PM, David Marchand wrote: On Wed, Mar 10, 2021 at 7:40 PM Ferruh Yigit wrote: @@ -41,6 +50,7 @@ This list is obviously neither complete nor guaranteed. - event vector support to reduce scheduler overhead and to improve performance - event vector support in SW Rx eventde

Re: [dpdk-dev] officially support building driver plugins externally

2021-03-10 Thread Tyler Retzlaff
On Wed, Mar 10, 2021 at 09:52:58PM +0100, Thomas Monjalon wrote: > 12/02/2021 20:09, Tyler Retzlaff: > > Recently installation of driver headers and export of functions was > > pulled back from being public to private > >

Re: [dpdk-dev] officially support building driver plugins externally

2021-03-10 Thread Thomas Monjalon
12/02/2021 20:09, Tyler Retzlaff: > Recently installation of driver headers and export of functions was > pulled back from being public to private > (commit > df96fd0d73955bdc7ca3909e772ff2ad90

Re: [dpdk-dev] [dpdk-web] [PATCH] update Intel roadmap for 21.05

2021-03-10 Thread David Marchand
On Wed, Mar 10, 2021 at 7:40 PM Ferruh Yigit wrote: > @@ -41,6 +50,7 @@ This list is obviously neither complete nor guaranteed. > > - event vector support to reduce scheduler overhead and to improve > performance > - event vector support in SW Rx eventdev adapter > +- new dynamic load balance

Re: [dpdk-dev] [PATCH v1] net/i40e: fix parse ptype issue for NEON vector

2021-03-10 Thread Kathleen Capella
Tested-by: Kathleen Capella > -Original Message- > From: dev On Behalf Of Feifei Wang > Sent: Tuesday, March 9, 2021 9:40 PM > To: jer...@marvell.com; Ruifeng Wang ; Beilei Xing > ; Jeff Guo ; Bruce Richardson > ; Jianbo Liu > Cc: dev@dpdk.org; nd ; Feifei Wang ; > sta...@dpdk.org > Sub

Re: [dpdk-dev] [PATCH v4 1/2] eal: error number enhancement for thread TLS API

2021-03-10 Thread Narcisa Ana Maria Vasile
On Wed, Mar 10, 2021 at 02:48:55PM +0200, Tal Shnaiderman wrote: > add error number reporting to rte_errno in all > functions in the rte_thread_tls_* API. > > Suggested-by: Anatoly Burakov > Signed-off-by: Tal Shnaiderman > --- > lib/librte_eal/include/rte_thread.h | 14 +++--- > lib/li

Re: [dpdk-dev] [PATCH v16 1/3] build: disable/enable drivers in Arm builds

2021-03-10 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Mar 09, 2021 at 08:58:39AM +, Juraj Linkeš > wrote: > > > > > > > > > > > Honnappa, Thomas, Bruce, Jerin, you've comments in the > past. > > > > > > > > > > > Do you have > > > > > > > > > > any further input? > > > > > > > > > > > > >

Re: [dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64

2021-03-10 Thread Stephen Hemminger
On Tue, 9 Mar 2021 22:41:06 -0800 Tyler Retzlaff wrote: > based on the original commit and the usage of rte_bsf64 it appears the > function should always have returned uint32_t instead of int which is > consistent with the cast introduced in the return statement. > > Fixes: 4e261f551986 ("eal:

[dpdk-dev] [PATCH] update Intel roadmap for 21.05

2021-03-10 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- content/roadmap/_index.md | 10 ++ 1 file changed, 10 insertions(+) diff --git a/content/roadmap/_index.md b/content/roadmap/_index.md index c6a67a986876..9789e132c57e 100644 --- a/content/roadmap/_index.md +++ b/content/roadmap/_index.md @@ -18,6 +18,8 @@

Re: [dpdk-dev] [PATCH] eal: allow user to override DPDK runtime path

2021-03-10 Thread Stephen Hemminger
On Wed, 10 Mar 2021 17:27:17 + Bruce Richardson wrote: > On Wed, Mar 10, 2021 at 09:21:37AM -0800, Stephen Hemminger wrote: > > There can be cases such as containers or other runtime environments > > where DPDK may not be able to access the default runtime path. > > This patch introduces DPDK

Re: [dpdk-dev] Reg DPDK EAL log-level=8 options is not throwing any DEBUG messages in /var/log/messages

2021-03-10 Thread Shanmugasundaram M
can i use ./sources/dpdk-18.11/drivers/net/vmxnet3/vmxnet3_ethdev.c:1422: rte_log_set_level(vmxnet3_logtype_driver, RTE_LOG_WARNING); after EAL driver routine completes ( pci_common.c, etc) its initialization ? Please let me know where do i need to call rte_log_set_level() in EAL driver init co

[dpdk-dev] L3fwd mode in testpmd

2021-03-10 Thread Honnappa Nagarahalli
Hello, Performance of L3fwd example application is one of the key benchmarks in DPDK. However, the application does not have many debugging statistics to understand the performance issues. We have added L3fwd as another mode/stream to testpmd which provides enough statistics at various l

Re: [dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64

2021-03-10 Thread Ranjit Menon
On 3/9/2021 10:41 PM, Tyler Retzlaff wrote: based on the original commit and the usage of rte_bsf64 it appears the function should always have returned uint32_t instead of int which is consistent with the cast introduced in the return statement. Fixes: 4e261f551986 ("eal: add 64-bit bsf and 32-b

Re: [dpdk-dev] Reg DPDK EAL log-level=8 options is not throwing any DEBUG messages in /var/log/messages

2021-03-10 Thread Stephen Hemminger
On Wed, 10 Mar 2021 23:49:17 +0530 Shanmugasundaram M wrote: > THanks Steven for the quick response. I want to enable EAL module > (complete logging at debug level ) only during bootup of fastpath. Once > bootup is done, i want to move this module log-level to default/ original. > Currently I'm

Re: [dpdk-dev] Reg DPDK EAL log-level=8 options is not throwing any DEBUG messages in /var/log/messages

2021-03-10 Thread Shanmugasundaram M
THanks Steven for the quick response. I want to enable EAL module (complete logging at debug level ) only during bootup of fastpath. Once bootup is done, i want to move this module log-level to default/ original. Currently I'm using --log-level='.*',8 along with ./sources/fp/common/fp-var.h

Re: [dpdk-dev] [PATCH v3 0/3] AF_XDP Preferred Busy Polling

2021-03-10 Thread Ferruh Yigit
On 3/10/2021 7:48 AM, Ciara Loftus wrote: Single-core performance of AF_XDP at high loads can be poor because a heavily loaded NAPI context will never enter or allow for busy-polling. 1C testpmd rxonly (both IRQs and PMD on core 0): ./dpdk-testpmd -l 0-1 --vdev=net_af_xdp0,iface=eth0 --main-lcor

Re: [dpdk-dev] Behavior inconsistency in QAT PMD code

2021-03-10 Thread Trahe, Fiona
Including Declan and Arek. Hi Linfeng, Thanks for raising this. I passed it on yesterday to the team, they are investigating. Regards, Fiona From: Linfeng Li Sent: Wednesday, March 10, 2021 5:38 PM To: dev@dpdk.org Cc: Griffin, John ; Trahe, Fiona ; Jain, Deepak K ; Steve Rizor ; Emil Meng

[dpdk-dev] [PATCH v11 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-10 Thread 谢华伟(此时此刻)
With I/O BAR, we get PIO(port-mapped I/O) address. With MMIO(memory-mapped I/O) BAR, we get mapped virtual address. We distinguish PIO and MMIO by their address range like how kernel does, i.e, address below 64K is PIO. ioread/write8/16/32 is provided to access PIO/MMIO. By the way, for virtio on a

[dpdk-dev] [PATCH v11 0/2] support both PIO and MMIO BAR for legacy virito device

2021-03-10 Thread 谢华伟(此时此刻)
virtio PMD assumes legacy device only supports PIO(port-mapped) BAR resource. This is wrong. As we need to create lots of devices, adn PIO resource on x86 is very limited, we expose MMIO(memory-mapped I/O) BAR. Kernel supports both PIO and MMIO BAR for legacy virtio-pci device, and for all other p

[dpdk-dev] [PATCH v11 1/2] bus/pci: use PCI standard sysfs entry to get PIO address

2021-03-10 Thread 谢华伟(此时此刻)
Currently virtio PMD assumes legacy device uses PIO bar. There are three ways to get PIO(PortIO) address for virtio legacy device. 1) under igb_uio, get PIO address from uio/uio# sysfs attribute, for instance: /sys/bus/pci/devices/:00:09.0/uio/uio0/portio/port0/start 2) under uio_pci_ge

Re: [dpdk-dev] [PATCH] eal: allow user to override DPDK runtime path

2021-03-10 Thread Bruce Richardson
On Wed, Mar 10, 2021 at 09:21:37AM -0800, Stephen Hemminger wrote: > There can be cases such as containers or other runtime environments > where DPDK may not be able to access the default runtime path. > This patch introduces DPDK_RUNTIME_DIR as an environment variable > to allow controlling and ov

[dpdk-dev] [PATCH 4/4] telemetry: move init function to internal header

2021-03-10 Thread Bruce Richardson
The rte_telemetry_init() function is for EAL use only, so can be moved to the internal header rather than being in the public one. Signed-off-by: Bruce Richardson --- lib/librte_eal/freebsd/eal.c | 2 +- lib/librte_eal/linux/eal.c| 2 +- lib/librte_telemetry/rte_te

[dpdk-dev] [PATCH 3/4] telemetry: create internal-only header file

2021-03-10 Thread Bruce Richardson
The header file containing the legacy telemetry function prototypes was all internal-only, so we rename the file to be an internal-only one to make it clearer it's not for installation. Signed-off-by: Bruce Richardson --- lib/librte_metrics/rte_metrics_telemetry.c | 2 +- lib/li

[dpdk-dev] [PATCH 2/4] telemetry: make the legacy registration function internal

2021-03-10 Thread Bruce Richardson
The function for registration of callbacks for legacy telemetry was documented as internal-only in the API documents, but marked as experimental in the version.map file. Since this is an internal-only function, for consistency we update the version mapping to have it as internal. Signed-off-by: Br

[dpdk-dev] [PATCH 1/4] telemetry: use rte_log for logging

2021-03-10 Thread Bruce Richardson
Rather than passing back an error string to the caller, take as input the rte_log function to use, and just use regular logging. Signed-off-by: Bruce Richardson --- lib/librte_eal/freebsd/eal.c | 10 ++-- lib/librte_eal/linux/eal.c | 10 ++-- lib/librte_telemetry/rte_telemetry.

[dpdk-dev] [PATCH 0/4] telemetry logging improvements and cleanup

2021-03-10 Thread Bruce Richardson
This set adds support for using the regular rte_log functions from the telemetry library; avoiding circular dependencies by having EAL register the telemetry library itself and then passing the required handles to that library as part of the telemetry_init call. Beyond this change, the other three

[dpdk-dev] [PATCH] eal: allow user to override DPDK runtime path

2021-03-10 Thread Stephen Hemminger
There can be cases such as containers or other runtime environments where DPDK may not be able to access the default runtime path. This patch introduces DPDK_RUNTIME_DIR as an environment variable to allow controlling and overriding the path. The example we have is DPDK application running in an u

[dpdk-dev] [Bug 652] Link detection failing when DPDK takes control of XXV710 NIC

2021-03-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=652 Bug ID: 652 Summary: Link detection failing when DPDK takes control of XXV710 NIC Product: DPDK Version: 18.05 Hardware: All OS: All Status: UNCONFIRMED

Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.

2021-03-10 Thread Singh, Jasvinder
> -Original Message- > From: Dharmappa, Savinay > Sent: Tuesday, March 9, 2021 4:10 PM > To: Singh, Jasvinder ; Dumitrescu, Cristian > ; dev@dpdk.org > Cc: Dharmappa, Savinay > Subject: [PATCH v2] sched : Initialize tc ov watermark. > > tc ov watermark is initialized with computed val

Re: [dpdk-dev] [PATCH 06/11] eal: catch invalid log level number

2021-03-10 Thread Bruce Richardson
On Wed, Mar 10, 2021 at 02:35:47PM +0100, Thomas Monjalon wrote: > 10/03/2021 14:26, Bruce Richardson: > > On Wed, Mar 10, 2021 at 01:33:20PM +0100, Thomas Monjalon wrote: > > > 10/03/2021 13:19, Bruce Richardson: > > > > On Wed, Mar 10, 2021 at 12:31:10AM +0100, Thomas Monjalon wrote: > > > > > Th

Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD

2021-03-10 Thread Ferruh Yigit
On 3/10/2021 3:02 PM, Ed Czeck wrote: On Tue, Mar 9, 2021 at 12:36 PM Ferruh Yigit wrote: On 3/9/2021 4:08 PM, Ed Czeck wrote: In this commit we generalize the movement of user-specified meta data between mbufs and FPGA AXIS tuser fields using user-defined hook functions. - Previous use of P

Re: [dpdk-dev] [PATCH 06/11] eal: catch invalid log level number

2021-03-10 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, March 10, 2021 2:36 PM > > 10/03/2021 14:26, Bruce Richardson: > > On Wed, Mar 10, 2021 at 01:33:20PM +0100, Thomas Monjalon wrote: > > > 10/03/2021 13:19, Bruce Richardson: > > > > On Wed, Mar 10, 2021 at 12

Re: [dpdk-dev] [PATCH v4 4/6] net/ark: cleanup ark dynamic extension interface

2021-03-10 Thread Ferruh Yigit
On 3/10/2021 3:11 PM, Ed Czeck wrote: On Tue, Mar 9, 2021 at 12:50 PM Ferruh Yigit wrote: On 3/9/2021 4:08 PM, Ed Czeck wrote: - Rename extension functions with rte_pmd_ark prefix - Move extension prototype to rte_pmd_ark.h - Update local function documentation Signed-off-by: Ed Czeck --- v

Re: [dpdk-dev] [PATCH 06/11] eal: catch invalid log level number

2021-03-10 Thread Stephen Hemminger
On Wed, 10 Mar 2021 12:19:24 + Bruce Richardson wrote: > On Wed, Mar 10, 2021 at 12:31:10AM +0100, Thomas Monjalon wrote: > > The parsing check for invalid log level was not trying to catch > > irrelevant numeric values. > > A log level 0 or too high is now a failure in options parsing > > so

Re: [dpdk-dev] [PATCH v4 4/6] net/ark: cleanup ark dynamic extension interface

2021-03-10 Thread Ed Czeck
On Tue, Mar 9, 2021 at 12:50 PM Ferruh Yigit wrote: > > On 3/9/2021 4:08 PM, Ed Czeck wrote: > > - Rename extension functions with rte_pmd_ark prefix > > - Move extension prototype to rte_pmd_ark.h > > - Update local function documentation > > > > Signed-off-by: Ed Czeck > > --- > > v3: > > - spl

Re: [dpdk-dev] [PATCH] checkpatch: enable volatile warning

2021-03-10 Thread Stephen Hemminger
On Wed, 10 Mar 2021 12:10:01 +0100 Thomas Monjalon wrote: > 10/03/2021 12:04, Dharmik Thakkar: > > Enable volatile considered harmful warning since use of volatile > > is suspect. > > > > Suggested-by: Stephen Hemminger > > Signed-off-by: Dharmik Thakkar > > Reviewed-by: Ruifeng Wang > > g

Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD

2021-03-10 Thread Ed Czeck
On Tue, Mar 9, 2021 at 12:36 PM Ferruh Yigit wrote: > > On 3/9/2021 4:08 PM, Ed Czeck wrote: > > In this commit we generalize the movement of user-specified > > meta data between mbufs and FPGA AXIS tuser fields using > > user-defined hook functions. > > > > - Previous use of PMD dynfields are rem

Re: [dpdk-dev] [PATCH 3/3] drivers: align log names

2021-03-10 Thread Bruce Richardson
On Wed, Mar 10, 2021 at 03:01:07PM +0100, Thomas Monjalon wrote: > The log levels are configured by using the name of the logs. > Some drivers are aligned to follow a common log name standard: > pmd.class.driver[.sub] > Some "common" drivers skip the "class" part: > pmd.driver.sub > >

[dpdk-dev] [RFC] net/mlx5: support count action in shared action API

2021-03-10 Thread Michael Baum
Existing API supports counter action to count traffic of a single flow. The user could use the shared flag to share the action between different flows. The user gives an id for counter action in creating the flow, and when he wants to share it with another flow, he uses the same id. Recent patch [

[dpdk-dev] [PATCH 2/3] drivers: fix log level after loading

2021-03-10 Thread Thomas Monjalon
When compiled as a shared object, and loaded at runtime as a plugin, the drivers should get the log level set earlier at EAL init by the user through --log-level option. The function for applying the log level setting is rte_log_register_type_and_pick_level(). It is called by most drivers via RTE_

[dpdk-dev] [PATCH 3/3] drivers: align log names

2021-03-10 Thread Thomas Monjalon
The log levels are configured by using the name of the logs. Some drivers are aligned to follow a common log name standard: pmd.class.driver[.sub] Some "common" drivers skip the "class" part: pmd.driver.sub Signed-off-by: Thomas Monjalon --- doc/guides/cryptodevs/qat.rst

[dpdk-dev] [PATCH 0/3] cleanup drivers log registration

2021-03-10 Thread Thomas Monjalon
After working on the option "--log-level help", it became clear that few adjustments were required for the log registration of some drivers. Thomas Monjalon (3): log: choose EAL log type on registration failure drivers: fix log level after loading drivers: align log names doc/guides/crypto

[dpdk-dev] [PATCH 1/3] log: choose EAL log type on registration failure

2021-03-10 Thread Thomas Monjalon
In the unlikely case where something goes wrong while registering a log type, the fallback is to use the log type 0, assigned to EAL. Signed-off-by: Thomas Monjalon --- lib/librte_eal/include/rte_log.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/include/rte_log.h b/lib/lib

[dpdk-dev] [PATCH v3 5/7] app/flow-perf: fix the incremental IPv6 src set

2021-03-10 Thread Wisam Jaddo
Currently the memset() will not set a correct src ip that represent the incremental value of the counter. This commit will fix this and each flow will have correct IPv6.src that it's incremental from previous flow and equal to the decimal values. Fixes: bf3688f1e816 ("app/flow-perf: add insertion

[dpdk-dev] [PATCH v3 7/7] app/flow-perf: fix setting decap data for decap actions

2021-03-10 Thread Wisam Jaddo
When using decap actions it's been set to the data to decap into the encap_data instead of decap_data, as a results we end up with bad encap and decap data in many cases. Fixes: 0c8f1f4ab90e ("app/flow-perf: support raw encap/decap actions") Cc: sta...@dpdk.org Signed-off-by: Wisam Jaddo --- ap

[dpdk-dev] [PATCH v3 6/7] app/flow-perf: add first flow latency support

2021-03-10 Thread Wisam Jaddo
Starting from this commit the app will always report the first flow latency. This is useful in debugging to check the first flow insertion before any caching effect. Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-fl

[dpdk-dev] [PATCH v3 4/7] app/flow-perf: fix report total stats for masked ports

2021-03-10 Thread Wisam Jaddo
Take into consideration that the user may call portmask for any run, thus the app should always check if port is needed to collect and report or not. Fixes: 070316d01d3e ("app/flow-perf: add multi-core rule insertion and deletion") Fixes: d8099d7ecbd0 ("app/flow-perf: split dump functions") Cc: d

[dpdk-dev] [PATCH v3 3/7] app/flow-perf: fix naming of CPU used structured data

2021-03-10 Thread Wisam Jaddo
create_flow and create_meter are not correct names since those are records that contain creation and deletion, which makes them more of a record for such data. Fixes: d8099d7ecbd0 ("app/flow-perf: split dump functions") Cc: dongz...@nvidia.com Signed-off-by: Wisam Jaddo --- app/test-flow-perf/m

[dpdk-dev] [PATCH v3 2/7] app/flow-perf: add new option to use unique data on the fly

2021-03-10 Thread Wisam Jaddo
Current support for unique data is to compile with config.h var as FIXED_VALUES as 0, and this is only supported on compilation time, as a result the user may use only single mode for each compilation. Starting with this commit the user will have the ability to use this feature on the fly by using

[dpdk-dev] [PATCH v3 1/7] app/flow-perf: start using more generic wrapper for cycles

2021-03-10 Thread Wisam Jaddo
rdtsc() is x86 related, while this might fail for other archs, so it's better to use more generic API for cycles measurement. Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/app/test-flow-perf

[dpdk-dev] [PATCH v3 0/7] Enhancements and fixes for flow-perf

2021-03-10 Thread Wisam Jaddo
-- v2: * Add first insertion flow latency calculation. * Fix for decap data set. v3: * Fixes in commit message. * Fixes the cover page. Wisam Jaddo (7): app/flow-perf: start using more generic wrapper for cycles app/flow-perf: add new option to use unique data on the fly app/flow-perf:

[dpdk-dev] [PATCH v3 6/7] app/flow-perf: add first flow latency support

2021-03-10 Thread Wisam Jaddo
Starting from this commit the app will always report the first flow latency. This is useful in debugging to check the first flow insertion before any caching effect. Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-fl

[dpdk-dev] [PATCH v3 4/7] app/flow-perf: fix report total stats for masked ports

2021-03-10 Thread Wisam Jaddo
Take into consideration that the user may call portmask for any run, thus the app should always check if port is needed to collect and report or not. Fixes: 070316d01d3e ("app/flow-perf: add multi-core rule insertion and deletion") Fixes: d8099d7ecbd0 ("app/flow-perf: split dump functions") Cc: d

[dpdk-dev] [PATCH v3 5/7] app/flow-perf: fix the incremental IPv6 src set

2021-03-10 Thread Wisam Jaddo
Currently the memset() will not set a correct src ip that represent the incremental value of the counter. This commit will fix this and each flow will have correct IPv6.src that it's incremental from previous flow and equal to the decimal values. Fixes: bf3688f1e816 ("app/flow-perf: add insertion

[dpdk-dev] [PATCH v3 3/7] app/flow-perf: fix naming of CPU used structured data

2021-03-10 Thread Wisam Jaddo
create_flow and create_meter are not correct names since those are records that contain creation and deletion, which makes them more of a record for such data. Fixes: d8099d7ecbd0 ("app/flow-perf: split dump functions") Cc: dongz...@nvidia.com Signed-off-by: Wisam Jaddo --- app/test-flow-perf/m

[dpdk-dev] [PATCH v3 2/7] app/flow-perf: add new option to use unique data on the fly

2021-03-10 Thread Wisam Jaddo
Current support for unique data is to compile with config.h var as FIXED_VALUES as 0, and this is only supported on compilation time, as a result the user may use only single mode for each compilation. Starting with this commit the user will have the ability to use this feature on the fly by using

[dpdk-dev] [PATCH v3 1/7] app/flow-perf: start using more generic wrapper for cycles

2021-03-10 Thread Wisam Jaddo
rdtsc() is x86 related, while this might fail for other archs, so it's better to use more generic API for cycles measurement. Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/app/test-flow-perf

[dpdk-dev] [PATCH v3 0/7] Enhancements and fixes for flow-perf

2021-03-10 Thread Wisam Jaddo
-- v2: * Add first insertion flow latency calculation. * Fix for decap data set. v3: * Fixes in commit message. * Fixes the cover page. Wisam Jaddo (7): app/flow-perf: start using more generic wrapper for cycles app/flow-perf: add new option to use unique data on the fly app/flow-perf:

[dpdk-dev] [PATCH v2 7/7] app/flow-perf: fix setting decap data for decap actions

2021-03-10 Thread Wisam Jaddo
When using decap actions it's been set to the data to decap into the encap_data instead of decap_data, as a results we end up with bad encap and decap data in many cases. Fixes: 0c8f1f4ab90e ("app/flow-perf: support raw encap/decap actions") Cc: sta...@dpdk.org Signed-off-by: Wisam Jaddo --- ap

[dpdk-dev] [PATCH v2 6/7] app/flow-perf: add first flow latency support

2021-03-10 Thread Wisam Jaddo
Starting from this commit the app will always report the first flow latency. This is useful in debugging to check the first flow insertion before any caching effect. Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-fl

[dpdk-dev] [PATCH v2 5/7] app/flow-perf: fix the incremental IPv6 src set

2021-03-10 Thread Wisam Jaddo
Currently the memset() will not set a correct src ip that represent the incremental value of the counter. This commit will fix this and each flow will have correct IPv6.src that it's incremental from previous flow and equal to the decimal values. Fixes: bf3688f1e816 ("app/flow-perf: add insertion

[dpdk-dev] [PATCH v2 4/7] app/flow-perf: fix report total stats for masked ports

2021-03-10 Thread Wisam Jaddo
Take into consideration that the user may call portmask for any run, thus the app should always check if port is needed to collect and report or not. Fixes: 070316d01d3e ("app/flow-perf: add multi-core rule insertion and deletion") Fixes: d8099d7ecbd0 ("app/flow-perf: split dump functions") Cc: d

[dpdk-dev] [PATCH v2 3/7] app/flow-perf: fix naming of CPU used structured data

2021-03-10 Thread Wisam Jaddo
create_flow and create_meter are not correct names since those are records that contain creation and deletion, which makes them more of a record for such data. Fixes: d8099d7ecbd0 ("app/flow-perf: split dump functions") Cc: dongz...@nvidia.com Signed-off-by: Wisam Jaddo --- app/test-flow-perf/m

[dpdk-dev] [PATCH v2 2/7] app/flow-perf: add new option to use unique data on the fly

2021-03-10 Thread Wisam Jaddo
Current support for unique data is to compile with config.h var as FIXED_VALUES as 0, and this is only supported on compilation time, as a result the user may use only single mode for each compilation. Starting with this commit the user will have the ability to use this feature on the fly by using

[dpdk-dev] [PATCH v2 1/7] app/flow-perf: start using more generic wrapper for cycles

2021-03-10 Thread Wisam Jaddo
rdtsc() is x86 related, while this might fail for other archs, so it's better to use more generic API for cycles measurement. Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/app/test-flow-perf

[dpdk-dev] [PATCH v2 0/7] Enhancements and fixes for flow-perf

2021-03-10 Thread Wisam Jaddo
changes in V2: 1- Add first flow insertion latency calculation. 2- Fix for decap data in raw decap actions. Wisam Jaddo (7): app/flow-perf: start using more generic wrapper for cycles app/flow-perf: add new option to use unique data on the fly app/flow-perf: fix naming of CPU used structured

[dpdk-dev] [PATCH v2 6/7] app/flow-perf: add first flow latency support

2021-03-10 Thread Wisam Jaddo
Starting from this commit the app will always report the first flow latency. This is useful in debugging to check the first flow insertion before any caching effect. Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-fl

[dpdk-dev] [PATCH v2 5/7] app/flow-perf: fix the incremental IPv6 src set

2021-03-10 Thread Wisam Jaddo
Currently the memset() will not set a correct src ip that represent the incremental value of the counter. This commit will fix this and each flow will have correct IPv6.src that it's incremental from previous flow and equal to the decimal values. Fixes: bf3688f1e816 ("app/flow-perf: add insertion

  1   2   >