[dpdk-dev] [PATCH 14/14] net/ice/base: cleanup fltr list in case of allocation issues

2021-03-01 Thread Qi Zhang
When ice_remove_vsi_lkup_fltr is called, by calling ice_add_to_vsi_fltr_list local copy of vsi filter list is created. If any issues during creation of vsi filter list occurs it up for the caller to free already allocated memory. This patch ensures proper memory deallocation in these cases. Fixes:

[dpdk-dev] [PATCH 13/14] net/ice/base: fix uninitialized struct

2021-03-01 Thread Qi Zhang
One of the structs being used for ACL counter rules was allocated on the stack and left uninitialized. Rather than depending on undefined behavior around the .amount member during rule removal, just leave a comment and initialize the struct to zero, as this is a slow path call anyway. This bug cou

[dpdk-dev] [PATCH 12/14] net/ice/base: update GTPU EH dummy pkts for FDIR

2021-03-01 Thread Qi Zhang
Update GTPU EH dummy pkts for FDIR, including EH/DL/UL. Signed-off-by: Junfeng Guo Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 176 +++- 1 file changed, 84 insertions(+), 92 deletions(-) diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ic

[dpdk-dev] [PATCH 11/14] net/ice/base: add code to update boost TCAM for DVM

2021-03-01 Thread Qi Zhang
Add code to update boost TCAM entries to enable DVM. This requires enabled DVM entries, and disabling SVM entries. Signed-off-by: Dan Nowlin Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 223 +++ drivers/net/ice/base/ice_flex_pipe.h | 1 + drivers/

[dpdk-dev] [PATCH 10/14] net/ice/base: mark PTYPE 2 as reserved

2021-03-01 Thread Qi Zhang
The entry for PTYPE 2 in the ice_ptype_lkup table incorrectly states that this is an L2 packet with no payload. According to the datasheet, this PTYPE is actually unused and reserved. Modify the lookup entry to indicate this is an unused entry that is reserved. Signed-off-by: Jacob Keller Signed

[dpdk-dev] [PATCH 09/14] net/ice/base: fix incorrect payload indicator on PTYPE

2021-03-01 Thread Qi Zhang
The entry for PTYPE 90 indicates that the payload is layer 3. This does not match the specification in the datasheet which indicates the packet is a MAC, IPv6, UDP packet, with a payload in layer 4. Fix the lookup table to match the data sheet. Fixes: 64e9587d5629 ("net/ice/base: add structures f

[dpdk-dev] [PATCH 08/14] net/ice/base: support GTPU IP inner IPv6 for FDIR

2021-03-01 Thread Qi Zhang
Support IPV4_GTPU with inner IPV6/UDP/TCP for FDIR. Signed-off-by: Junfeng Guo Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 106 drivers/net/ice/base/ice_fdir.h | 9 +++ drivers/net/ice/base/ice_type.h | 3 + 3 files changed, 118 insertions(

[dpdk-dev] [PATCH 07/14] net/ice/base: support for switch filter (GTP tunnel+IP flow)

2021-03-01 Thread Qi Zhang
Enabled support for advanced switch filter to satisfy match criteria such as: GTP tunnel + Inner IPv4[6] Signed-off-by: Kiran Patil Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_protocol_type.h | 8 +- drivers/net/ice/base/ice_switch.c| 114 --- 2 files chan

[dpdk-dev] [PATCH 06/14] net/ice/base: enable more GTPU inner L3 fields for FDIR

2021-03-01 Thread Qi Zhang
Add support for FDIR filter by GTPU inner L3 fields (i.e., tos, ttl, proto). Signed-off-by: Junfeng Guo Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 8 drivers/net/ice/base/ice_fdir.h | 3 +++ 2 files changed, 11 insertions(+) diff --git a/drivers/net/ice/base/ice_fdi

[dpdk-dev] [PATCH 05/14] net/ice/base: expose link configuration error

2021-03-01 Thread Qi Zhang
Store the link_cfg_err byte in order to determine whether an unsupported power configuration is preventing link establishment. Signed-off-by: Jeb Cramer Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 1 + drivers/net/ice/base/ice_common.c | 1 + drivers/net/ice/base/ice

[dpdk-dev] [PATCH 04/14] net/ice/base: enable GTPU inner L3/L4 for FDIR

2021-03-01 Thread Qi Zhang
For FDIR, GTPU with inner L3/L4 layers should only support inner L3/L4 addrs/ports, instead of outer fields. Thus, we use TUN offsets for GTPU IP/EH to insert inner L3/L4 addrs/ports fields. Signed-off-by: Junfeng Guo Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 122 +++

[dpdk-dev] [PATCH 03/14] net/ice/base: post update double reset solution restriction

2021-03-01 Thread Qi Zhang
Add capability which indicates double reset solution restriction. Added "Post-update EMPR enabled" field to "Response Flags" field (byte 19 in the response structure). Signed-off-by: Amir Shay Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 2 ++ 1 file changed, 2 insertions

[dpdk-dev] [PATCH 02/14] net/ice/base: signed external device package programming

2021-03-01 Thread Qi Zhang
External topology devices (e.g. PHYs) connected to Columbiaville or to SoC that includes CPK IP might have a firmware engine within the device and the firmware is usually loaded from NVM connected to the topology device. In some cases, those firmware packages might need to be regularly updated in a

[dpdk-dev] [PATCH 01/14] net/ice/base: add firmware log support

2021-03-01 Thread Qi Zhang
Currently we do not provide full end-to-end solution for system level debug and diagnostics. This change purpose is to fulfill design and implementation gaps to provide full end-to-end (HW-FW-SW) diagnostic solution. In addition to functional improvements, it will provide feasible, user-friendly De

[dpdk-dev] [PATCH 00/14] ice: base code update

2021-03-01 Thread Qi Zhang
Main change: 1. Support GTPU inner l3/l4 for FDIR 2. Support GTPU extention header for FDIR 3. Support switch filter (GTPU tunnel + IP flow) 4. couple bug fixes. Qi Zhang (14): net/ice/base: add firmware log support net/ice/base: signed external device package programming net/ice/base: post

Re: [dpdk-dev] [PATCH v2] net/i40e: fix IPv4 fragment offload issue

2021-03-01 Thread Xing, Beilei
> -Original Message- > From: Li, Xiaoyun > Sent: Tuesday, March 2, 2021 3:03 PM > To: Xing, Beilei ; Guo, Jia ; Lu, > Wenzhuo > Cc: dev@dpdk.org; Li, Xiaoyun ; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix IPv4 fragment offload issue > > IPv4 fragment_offset mask was required to

Re: [dpdk-dev] [PATCH] net/i40e: fix IPv4 fragment offload issue

2021-03-01 Thread Li, Xiaoyun
Hi > -Original Message- > From: Xing, Beilei > Sent: Tuesday, March 2, 2021 14:54 > To: Li, Xiaoyun ; dev@dpdk.org; Guo, Jia > ; Finn, Emma > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/i40e: fix IPv4 fragment offload issue > > > > > -Original Message- > > From: Li, Xiaoyun

[dpdk-dev] [PATCH v2] net/i40e: fix IPv4 fragment offload issue

2021-03-01 Thread Xiaoyun Li
IPv4 fragment_offset mask was required to be 0 no matter what the spec value was. But zero mask means not caring about fragment_offset field then both non-frag and frag packets should hit the rule. But the actual fragment rules should be like the following: Only non-fragment packets can hit Rule 1

Re: [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-01 Thread Matan Azrad
Hi Cristian Thank you for review, please see inline. From: Dumitrescu, Cristian > > From: dev On Behalf Of Li Zhang > We had this same problem earlier for the rte_tm.h API, where people asked to > add support for WRED and shaper rates specified in packets to the existing > byte > rate suppo

Re: [dpdk-dev] [PATCH] net/i40e: fix IPv4 fragment offload issue

2021-03-01 Thread Xing, Beilei
> -Original Message- > From: Li, Xiaoyun > Sent: Friday, February 26, 2021 4:15 PM > To: dev@dpdk.org; Xing, Beilei ; Guo, Jia > ; Finn, Emma > Cc: Li, Xiaoyun ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix IPv4 fragment offload issue > > IPv4 fragment_offset mask was required to

[dpdk-dev] [PATCH] net/iavf: deprecate i40evf pmd

2021-03-01 Thread Robin Zhang
Avf PMD was introduced from DPDK 18.02 to promote Intel Adaptive Virtual Function with device ID is 0x1889 aligned with AVF public spec. At the meanwhile, i40evf PMD was co-existed to support other existing device IDs of i40e devices. So on i40e devices, iavf PMD can only run in the VM whose hyperv

Re: [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-01 Thread Ajit Khaparde
On Mon, Mar 1, 2021 at 5:20 AM Dumitrescu, Cristian wrote: > > > -Original Message- > > From: dev On Behalf Of Li Zhang > > Sent: Monday, March 1, 2021 10:35 AM > > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com; > > ma...@nvidia.com > > Cc: dev@dpdk.org; tho...@monjalon.

[dpdk-dev] [PATCH v1] net/ice: fix wrong RSS hash update

2021-03-01 Thread Wenjun Wu
This patch removes redundant judgment statements to disable RSS when RSS hash function configured is not supported. Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config") Cc: sta...@dpdk.org Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_ethdev.c | 3 --- 1 file chang

Re: [dpdk-dev] 19.11.7 patches review and test

2021-03-01 Thread Chen, BoX C
Hi Ehrhardt, Quick sync up dpdk 19.11.7-rc1 test status of Intel part here. 50% is executed. 3 issues are found tille now: (1) Compiling dpdk with "make" failed. The bad commit id is: b086808ceed59989b5e7b83ce99c98719f45a6bf (2) The dpdk script usertools/dpdk-devbind.py cannot be used in p

Re: [dpdk-dev] [RFC 3/5] eal: lcore state FINISHED is not required

2021-03-01 Thread Honnappa Nagarahalli
> > > > > > Subject: [RFC 3/5] eal: lcore state FINISHED is not required > > > > > > > > FINISHED state seems to be used to indicate that the worker's > > > > update of the 'state' is not visible to other threads. There seems > > > > to be no requirement to have such a state. > > > > > > I am not

Re: [dpdk-dev] [RFC v4 4/4] app/testpmd: add meter pps mode cmd

2021-03-01 Thread Li Zhang
Hi Xiao yun, Thanks for your comments. We will follow other commands in our new command's helper_str. Regards, Li Zhang > -Original Message- > From: dev On Behalf Of Li, Xiaoyun > Sent: Tuesday, March 2, 2021 9:48 AM > To: Li Zhang ; Dekel Peled ; Ori Kam > ; Slava Ovsiienko ; Matan > Az

[dpdk-dev] [PATCH v3 6/6] net/ice: clean GTPU flow_type for FDIR

2021-03-01 Thread Zhirun Yan
Currently, FDIR only support GTPU outer fields in PF. Clean the redundant GTPU inner info in flow type definition and align with shared code. Signed-off-by: Zhirun Yan Signed-off-by: Junfeng Guo --- drivers/net/ice/ice_fdir_filter.c | 19 --- 1 file changed, 8 insertions(+), 11

[dpdk-dev] [PATCH v3 5/6] net/ice: add outer input set mask to distinguish outer fields

2021-03-01 Thread Zhirun Yan
Distinguish input_set_mask to inner and outer part. Use input_set_mask_o for tunnel outer or non-tunnel input set. input_set_mask_i is used for tunnel inner fields only. Adjust indentation of ice_pattern_match_item list in switch, ACL, RSS and FDIR for easy review. For switch, ACL and RSS, only use

[dpdk-dev] [PATCH v3 4/6] net/ice: refactor input set conf

2021-03-01 Thread Zhirun Yan
For tunnel or non-tunnel packet, the input set is in outer_input_set and use seg_tun[0]. seg_tun[1] is only used for tunnel inner fields. This patch make align with input_set inner/outer with seg_tun[] and simplify it. Signed-off-by: Zhirun Yan --- drivers/net/ice/ice_fdir_filter.c | 12

[dpdk-dev] [PATCH v3 3/6] net/ice: refactor flow pattern parser

2021-03-01 Thread Zhirun Yan
Distinguish inner/outer input_set. And avoid too many nested conditionals in each type's parser. input_set_o is used for tunnel outer fields or non-tunnel fields , input_set_i is only used for inner fields. For GTPU, store the outer IP fields in inner part to align with shared code behavior. Sign

[dpdk-dev] [PATCH v3 2/6] net/ice: refactor structure field

2021-03-01 Thread Zhirun Yan
This patch use input_set_o and input_set_i to distinguish inner/outer input set. input_set_i is only used for inner field. Signed-off-by: Zhirun Yan --- drivers/net/ice/ice_ethdev.h | 4 ++-- drivers/net/ice/ice_fdir_filter.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) dif

[dpdk-dev] [PATCH v3 1/6] net/ice: clean input set macro definition

2021-03-01 Thread Zhirun Yan
Currently, the macro of input set use 2 bits, one bit for protocol and inner/outer, another bit for src/dst field. But this could not distinguish a rule with inner and outer fields for tunnel packet. Redefine input set macro to make it clear. Only use these two bits for protocol and field. Ignore t

[dpdk-dev] [PATCH v3 0/6] Refactor FDIR pattern parser

2021-03-01 Thread Zhirun Yan
V3: Clear the variable name of input_set_o and input_set_i. Use input_set_o for tunnerl outer or non-tunnel fields, let ice_pattern_match_item 3rd columns all none in ACL, RSS, switch. Add new patch to use seg_tun[1] to record tunnel inner part. Add new patch to clean GTPU inner flow type for PF.

[dpdk-dev] [Bug 646] mrvl: memset wrong struct when session clear

2021-03-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=646 Bug ID: 646 Summary: mrvl: memset wrong struct when session clear Product: DPDK Version: 20.08 Hardware: ARM OS: Linux Status: UNCONFIRMED Severity: minor

Re: [dpdk-dev] [RFC v4 4/4] app/testpmd: add meter pps mode cmd

2021-03-01 Thread Li, Xiaoyun
Hi > -Original Message- > From: dev On Behalf Of Li Zhang > Sent: Monday, March 1, 2021 18:36 > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com; > ma...@nvidia.com > Cc: dev@dpdk.org; tho...@monjalon.net; rasl...@nvidia.com; > m...@smartsharesystems.com; ajit.khapa...@broa

Re: [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-01 Thread Li Zhang
Thanks Thomas. I will use it next time. Regards, Li Zhang > -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Monday, March 1, 2021 11:54 PM > To: Li Zhang > Cc: Dekel Peled ; Ori Kam ; Slava > Ovsiienko ; Matan Azrad ; > Dumitrescu, Cristian ; dev@dpdk.org; Raslan > Da

Re: [dpdk-dev] [PATCH v2 1/7] eal: add wrappers for POSIX string functions

2021-03-01 Thread Dmitry Kozlyuk
2021-03-01 21:31, Nick Connolly: > > There's a meson issue with `cc.has_function()`: > > https://github.com/mesonbuild/meson/issues/5628 > > > > What if we just define RTE_INTERNAL for librte_eal/windows/include/rte_os.h > > (and other public headers if need be) to distinguish the case when it's us

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-03-01 Thread Dmitry Kozlyuk
2021-03-02 02:05, Dmitry Kozlyuk: > 2021-03-01 21:43, Nick Connolly: > > > Complete removal of non-standard dependencies in headers is within a > > > grasp. > > > Then we can remove shims and include whatever needed. > > > Thoughts? > > Sounds good. A couple of 'gotchas' that I've come across (b

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-03-01 Thread Dmitry Kozlyuk
2021-03-01 21:43, Nick Connolly: > > Complete removal of non-standard dependencies in headers is within a grasp. > > Then we can remove shims and include whatever needed. > > Thoughts? > Sounds good. A couple of 'gotchas' that I've come across (but may not be > an issue for DPDK): > > * Memory

Re: [dpdk-dev] [PATCH v2 1/6] eal: add internal API for current time

2021-03-01 Thread Nick Connolly
Many PMDs use POSIX gettimeofday(). Add rte_time_get_us() function to obtain current time with microsecond precision on all platforms. Acked-by: Nick Connolly

Re: [dpdk-dev] [PATCH 1/6] eal: add internal API for current time

2021-03-01 Thread Nick Connolly
Calculation of usec value is incorrect - 'ticks' is not adjusted for epoch, whereas 'sec' has been, also subtraction has mismatched units - ticks in 100ns and sec * USEC_PER_SEC in usecs. Ignore - fixed in later version which I hadn't spotted.

Re: [dpdk-dev] [PATCH 2/6] net/pcap: fix format string

2021-03-01 Thread Nick Connolly
Use PRIu32 for uint32_t (found by -Wformat with Clang on Windows). Acked-by: Nick Connolly

Re: [dpdk-dev] [PATCH 1/6] eal: add internal API for current time

2021-03-01 Thread Nick Connolly
Calculation of usec value is incorrect - 'ticks' is not adjusted for epoch, whereas 'sec' has been, also subtraction has mismatched units - ticks in 100ns and sec * USEC_PER_SEC in usecs. On 14/02/2021 01:20, Dmitry Kozlyuk wrote: + GetSystemTimePreciseAsFileTime(&ft); + ticks = (

Re: [dpdk-dev] [kmods PATCH] windows/netuio: add vmxnet3 device ID

2021-03-01 Thread Nick Connolly
+%vmxnet3.Description%=netuio_Device, PCI\VEN_15AD&DEV_07B0 Acked-by: Nick Connolly PCI hardware IDs verified against: https://devicehunt.com/view/type/pci/vendor/15AD/device/07B0

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-03-01 Thread Nick Connolly
Complete removal of non-standard dependencies in headers is within a grasp. Then we can remove shims and include whatever needed. Thoughts? Sounds good. A couple of 'gotchas' that I've come across (but may not be an issue for DPDK): * Memory allocation / free that spans a dll boundary (see

Re: [dpdk-dev] [PATCH v2 1/7] eal: add wrappers for POSIX string functions

2021-03-01 Thread Nick Connolly
There's a meson issue with `cc.has_function()`: https://github.com/mesonbuild/meson/issues/5628 What if we just define RTE_INTERNAL for librte_eal/windows/include/rte_os.h (and other public headers if need be) to distinguish the case when it's used from within DPDK? It's a pragmatic solution t

Re: [dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v4

2021-03-01 Thread Dan Gora
This is from my git commit fixing this: kni: separate releasing netdev from freeing KNI interface Currently the rte_kni kernel driver suffers from a problem where when the interface is released, it generates a callback to the DPDK application to change the interface state to Down. Ho

Re: [dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v4

2021-03-01 Thread Dan Gora
Hi All, Sorry to butt in on this, but I fixed this same issue about 3 years ago in my application, but I was never able to get the changes integrated and eventually just gave up trying. The rule with KNI is: 1) The app should have a separate control thread per rte_kni which just spins calling rte

[dpdk-dev] telemetry logs

2021-03-01 Thread Thomas Monjalon
Hi, Sorry if I already asked this question. Would it be possible to use rte_log in rte_telemetry instead of returning telemetry_log_error at init?

[dpdk-dev] DPDK 21.05 NVIDIA Mellanox Roadmap

2021-03-01 Thread Asaf Penso
Below is NVIDIA Mellanox's roadmap for DPDK21.05, on which we are currently working: rte_flow new APIs: === [1]Support a new action offload which perform connection tracking window validation. Motivation: TCP connection tracking is needed for many applications that act as a mediator

Re: [dpdk-dev] [PATCH] eal/windows: add missing SPDX license tag

2021-03-01 Thread Ranjit Menon
On 2/27/2021 12:32 PM, Dmitry Kozlyuk wrote: Fixes: c08bd191b13d ("eal/windows: initialize hugepage info") Cc: sta...@dpdk.org Reported-by: Stephen Hemminger Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/windows/eal_hugepages.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/

[dpdk-dev] [PATCH 4/4] doc: update 21.05 release notes to announce removal of DLB V1

2021-03-01 Thread Timothy McDaniel
Support for DLB v1 is being removed from dpdk in 21.05. Signed-off-by: Timothy McDaniel --- doc/guides/rel_notes/release_21_05.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst index 5aa9ed7db..a941d89ef 100

[dpdk-dev] [PATCH 2/4] event/dlb: remove DLB V1 documentation

2021-03-01 Thread Timothy McDaniel
Support for DLB v1 is being removed from dpdk in 21.05. Signed-off-by: Timothy McDaniel --- doc/api/doxy-api-index.md | 1 - doc/api/doxy-api.conf.in | 1 - doc/guides/eventdevs/dlb.rst | 341 - doc/guides/eventdevs/index.rst | 1 - 4 files chan

Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong segmented packet in Rx

2021-03-01 Thread Jiawei Zhu
Hi, Slava Thank you for your agreement. Here is the v2 patch: https://patches.dpdk.org/project/dpdk/patch/1614617885-2650-1-git-send-email-17826875...@163.com/ With best regards, Jiawei On 2021/3/1 5:13 PM, Slava Ovsiienko wrote: Hi, Jiawei Thank you for the clarification. I missed the point

[dpdk-dev] [PATCH 1/4] event/dlb: remove DLB V1 from build

2021-03-01 Thread Timothy McDaniel
Support for DLB v1 is being removed from dpdk in 21.05. Signed-off-by: Timothy McDaniel --- config/rte_config.h | 6 -- drivers/event/meson.build | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/config/rte_config.h b/config/rte_config.h index 55a2fc50e..aedb68c42 1

[dpdk-dev] [PATCH 0/4] Remove Support For DLB V1

2021-03-01 Thread Timothy McDaniel
This patch set removes DLB V1 from DPDK 21.05. All DLB V1 customers obtain the source code for that device directly from Intel, and will continue to do so in the future. DLB V2 remains in DPDK, and will be supplemented with support for DLB V2.5 in a future patch set tageted for DPDK 21.05. Timot

[dpdk-dev] [PATCH v2] net/mlx5: fix wrong segmented packet in Rx

2021-03-01 Thread Jiawei Zhu
Fixed issue could occur when Mbuf starvation happens in a middle of reception of a segmented packet. In such a situation, after release the segments of that packet, it does not align consumer index to the next stride. This would cause receive a wrong segmented packet. Here is a possible error. - w

Re: [dpdk-dev] [RFC 0/5] Use correct memory ordering in eal functions

2021-03-01 Thread Stephen Hemminger
On Wed, 24 Feb 2021 15:20:13 -0600 Honnappa Nagarahalli wrote: > rte_eal_remote_launch and rte_eal_wait_lcore need to provide > correct memory ordering to address the data communication from > main core to worker core and vice versa. > > There are 2 use cases: > 1) All the store operations (mean

Re: [dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v4

2021-03-01 Thread Stephen Hemminger
On Mon, 1 Mar 2021 11:10:01 +0300 Igor Ryzhov wrote: > Stephen, > > No, I don't have a better proposal, but I think it is not correct to change > the behavior of KNI (making link down without a real response). > Even though we know that communicating with userspace under rtnl_lock is a > bad ide

Re: [dpdk-dev] [PATCH 3/3] net/af_xdp: preferred busy polling

2021-03-01 Thread Ferruh Yigit
On 2/24/2021 11:18 AM, Ciara Loftus wrote: This commit introduces support for preferred busy polling to the AF_XDP PMD. This feature aims to improve single-core performance for AF_XDP sockets under heavy load. A new vdev arg is introduced called 'busy_budget' whose default value is 64. busy_budg

Re: [dpdk-dev] [PATCH 1/3] net/af_xdp: Increase max batch size to 512

2021-03-01 Thread Ferruh Yigit
On 2/24/2021 11:18 AM, Ciara Loftus wrote: Prior to this the max size was 32 which was unnecessarily small. Can you please describe the impact? Why changed from 32 to 512? I assume this is to improve the performance but can you please explicitly document it in the commit log? Also enforce

[dpdk-dev] [PATCH v8 0/2] support both PIO and MMIO BAR for legacy device in virtio PMD

2021-03-01 Thread 谢华伟(此时此刻)
From: "huawei.xhw" virtio PMD assumes legacy device only supports PIO BAR resource. This is wrong. As we need to create lots of devices, as PIO resource on x86 is very limited, we expose MMIO(memory IO) BAR. Kernel supports both PIO and MMIO BAR for legacy virtio-pci device, and for all other p

[dpdk-dev] [PATCH v8 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-01 Thread 谢华伟(此时此刻)
From: "huawei.xhw" With IO BAR, we get PIO(programmed IO) address. With MMIO BAR, we get mapped virtual address. We distinguish PIO(Programmed IO) and MMIO(memory mapped IO) by their address like how kernel does. ioread/write8/16/32 is provided to access PIO/MMIO. By the way, for virtio on arch

[dpdk-dev] [PATCH v8 1/2] bus/pci: use PCI standard sysfs entry to get PIO address

2021-03-01 Thread 谢华伟(此时此刻)
From: "huawei.xhw" Currently virtio PMD asssumes legacy device uses PIO bar. There are three ways to get PIO(PortIO) address for virtio legacy device. under igb_uio, get pio address from uio/uio# sysfs attribute under uio_pci_generic: for X86, get PIO address from /proc/ioport

Re: [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-01 Thread Thomas Monjalon
01/03/2021 14:20, Dumitrescu, Cristian: > From: Li Zhang > > As specified in the MAINTEINERS file of DPDK, I am the maintainer of this > > API, so please make sure you add my email in the To: list of future > > revisions of this patch set. This kind of miss should be solved by using --cc-cmd dev

Re: [dpdk-dev] [PATCH v6 1/2] bus/pci: use PCI standard sysfs entry to get PIO address

2021-03-01 Thread 谢华伟(此时此刻)
On 2021/2/25 1:52, David Marchand wrote: On Wed, Feb 24, 2021 at 4:29 PM 谢华伟(此时此刻) wrote: Did you check that virtio devices bound to uio_pci_generic still works with legacy mode + PIO? I had verified PIO, might under igb_uio driver. Well, if you are unsure, please retest both cases, igb_uio

Re: [dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-01 Thread 谢华伟(此时此刻)
On 2021/2/25 17:52, David Marchand wrote: On Thu, Feb 25, 2021 at 5:00 AM 谢华伟(此时此刻) wrote: Is the 'outb_p' to 'outb' conversion intentional? And if so why? Same of the all 'outb_p', 'outw_p', 'outl_p'. There is no need to delay for virtio device, as we can see in virtio legacy driver. IMO,

[dpdk-dev] [PATCH v2] driver/net/pcap fix: fd leak bug

2021-03-01 Thread ZhangTengfei
pcap fd was opend when vdev probed, but not closed when vdev removed. This bug appears in dpdk-pdump Signed-off-by: ZhangTengfei --- drivers/net/pcap/rte_eth_pcap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 90f5d

Re: [dpdk-dev] 回复: [PATCH] driver/net/pcap fix: pcap fd leak

2021-03-01 Thread Tengfei Zhang
On 2021/3/1 下午7:40, Ferruh Yigit wrote: Please do not top post, message moved down. On 2/26/2021 5:47 PM, 张 杨 wrote: I think your idea is fine What do you think just record file path in "pmd_pcap_probe()", Perform an open operation only in "eth_dev_start()"? When the secondary process add pc

Re: [dpdk-dev] [PATCH 07/13] net/hns3: support PF on electrical net device

2021-03-01 Thread Ferruh Yigit
On 3/1/2021 2:17 PM, oulijun wrote: 在 2021/2/26 23:25, Ferruh Yigit 写道: On 2/24/2021 1:28 AM, Lijun Ou wrote: From: Huisong Li The normal operation of electrical interface devices depends on the initialization and configuration of the PHY chip. The task of driving the PHY chip is implemente

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2021-03-01 Thread Jan Viktorin
On Mon, 1 Mar 2021 14:34:07 + Slava Ovsiienko wrote: > Hi, Jan > > To use port action (I see it is in your sample action list) the flow should > be applied to the FDB domain, > ie "transfer" attribute should be specified: > > flow validate 0 ingress transfer... As you can see (however, it

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2021-03-01 Thread Slava Ovsiienko
Hi, Jan To use port action (I see it is in your sample action list) the flow should be applied to the FDB domain, ie "transfer" attribute should be specified: flow validate 0 ingress transfer... With best regards, Slava > -Original Message- > From: Jan Viktorin > Sent: Monday, March 1

Re: [dpdk-dev] [PATCH v6 07/17] drivers: replace page size definitions with function

2021-03-01 Thread Andrew Boyer
> On Feb 28, 2021, at 7:53 AM, Thomas Monjalon wrote: > > The page size is often retrieved from the macro PAGE_SIZE. > If PAGE_SIZE is not defined, it is either using hard coded default, > or getting the system value from the UNIX-only function sysconf(). > > Such definitions are replaced with

Re: [dpdk-dev] [PATCH 07/13] net/hns3: support PF on electrical net device

2021-03-01 Thread oulijun
在 2021/2/26 23:25, Ferruh Yigit 写道: On 2/24/2021 1:28 AM, Lijun Ou wrote: From: Huisong Li The normal operation of electrical interface devices depends on the initialization and configuration of the PHY chip. The task of driving the PHY chip is implemented in some firmware versions. If firm

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix nfp multiport syntax

2021-03-01 Thread Ferruh Yigit
On 2/25/2021 11:46 AM, Heinrich Kuhn wrote: From: "Chaoyong.He" 1. Fixup the suffix of the PCI ID to be consistent with the code. 2. Add specification of using MAC address to identify port. Fixes: 979f2bae0 ("doc: improve multiport PF in nfp guide") Cc: sta...@dpdk.org Signed-off-by: Chaoyong

Re: [dpdk-dev] [PATCH] net/ring: support secondary process

2021-03-01 Thread Bruce Richardson
On Wed, Sep 30, 2020 at 12:02:40PM +0100, Ferruh Yigit wrote: > Also add missing .ini feature list documentation and document some > existing features including new "Multiprocess aware" feature. > > Signed-off-by: Ferruh Yigit > --- > Cc: Kevin Laatz > --- > doc/guides/nics/features/ring.ini |

Re: [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-01 Thread Dumitrescu, Cristian
> -Original Message- > From: dev On Behalf Of Li Zhang > Sent: Monday, March 1, 2021 10:35 AM > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com; > ma...@nvidia.com > Cc: dev@dpdk.org; tho...@monjalon.net; rasl...@nvidia.com; > m...@smartsharesystems.com; ajit.khapa...@broad

Re: [dpdk-dev] [PATCH] [RFC, v2]: adds support PPS(packet per second) on meter

2021-03-01 Thread Dumitrescu, Cristian
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, January 28, 2021 6:28 PM > To: Li Zhang ; dek...@nvidia.com; or...@nvidia.com; > viachesl...@nvidia.com; ma...@nvidia.com; Dumitrescu, Cristian > > Cc: dev@dpdk.org; tho...@monjalon.net; rasl...@nvidia.com > Subject: Re: [dpdk-

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2021-03-01 Thread Jan Viktorin
Hello Asaf, it is a while we were in touch regarding this topic. Finally, I am again trying to get work this feature. I've seen that sampling is already upstreamed which is great. However, I am not very successful with that. There is nearly no documentation, just [1], I found no examples, just com

[dpdk-dev] [PATCH 2/2] app/crypto-perf: close PMD after benchmark run

2021-03-01 Thread Adam Dybkowski
This patch adds closing of the PMD after running the benchmark. Signed-off-by: Adam Dybkowski --- app/test-crypto-perf/main.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 49af812d8..c1d338fa4 100644 --

[dpdk-dev] [PATCH 1/2] test/crypto: close PMD after tests

2021-03-01 Thread Adam Dybkowski
This patch adds closing of the PMD after running the tests. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index f91debc16..7dcd255de 100644 --- a/app/test/tes

Re: [dpdk-dev] [PATCH] app/testpmd: add support for forced ethernet speed

2021-03-01 Thread Ferruh Yigit
On 2/26/2021 4:18 PM, Andrew Boyer wrote: On Feb 26, 2021, at 6:21 AM, Ferruh Yigit wrote: On 2/26/2021 6:43 AM, Andrew Rybchenko wrote: On 2/25/21 9:25 PM, Ferruh Yigit wrote: On 2/22/2021 7:18 PM, Ajit Khaparde wrote: Add support for forced ethernet speed setting. Currently testpmd trie

Re: [dpdk-dev] [PATCH v8 0/3] fix issue with partial DMA unmap

2021-03-01 Thread David Marchand
On Fri, Jan 15, 2021 at 8:33 AM Nithin Dabilpuram wrote: > > Partial DMA unmap is not supported by VFIO type1 IOMMU > in Linux. Though the return value is zero, the returned > DMA unmap size is not same as expected size. > So add test case and fix to both heap triggered DMA > mapping and user trig

Re: [dpdk-dev] 回复: [PATCH] driver/net/pcap fix: pcap fd leak

2021-03-01 Thread Ferruh Yigit
Please do not top post, message moved down. On 2/26/2021 5:47 PM, 张 杨 wrote: I think your idea is fine What do you think just record file path in "pmd_pcap_probe()", Perform an open operation only in "eth_dev_start()"? When the secondary process add pcap vdev, it send the request to primary

[dpdk-dev] [PATCH] doc: fix dpdk-graph-crypto-perf dependencies

2021-03-01 Thread Ciara Power
The script dependencies list was incomplete, this patch adds missing modules and removes an unnecessary entry. The installation command was also added. Fixes: f400e0b82bf1 ("app/crypto-perf: add script to graph perf results") Signed-off-by: Ciara Power --- doc/guides/tools/cryptoperf.rst | 8 ++

[dpdk-dev] [Bug 645] mlx5 does not reflect lpbk_mode setting

2021-03-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=645 Bug ID: 645 Summary: mlx5 does not reflect lpbk_mode setting Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [PATCH] net/af_xdp: fix error handling during Rx queue setup

2021-03-01 Thread Ciara Loftus
Prior to this commit, if rte_pktmbuf_alloc_bullk failed during rx queue setup the error was not returned to the user and they may incorrectly assume that the rx queue had been successfully set up. This commit ensures that the error is returned to the user. Bugzilla ID: 643 Fixes: d8a210774e1d ("ne

Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build

2021-03-01 Thread Juraj Linkeš
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, February 24, 2021 1:10 PM > To: Juraj Linkeš > Cc: oulijun ; ferruh.yi...@intel.com; dev@dpdk.org; > linux...@openeuler.org > Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC > build > > 24/02/2

Re: [dpdk-dev] [PATCH] mem: fix free segment when using huge-unlink option

2021-03-01 Thread Burakov, Anatoly
On 28-Feb-21 1:21 PM, Roy Shterman wrote: On Mon, Feb 22, 2021 at 5:53 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 22-Feb-21 10:41 AM, Roy Shterman wrote: > When using huge_unlink we unlink the segment right > after allocation. Although we unlink the file w

[dpdk-dev] [PATCH] vdpa/mlx5: fix virtq cleaning

2021-03-01 Thread Matan Azrad
The HW virtq object can be destroyed ether when the device is closed or when the state of the virtq becomes disabled. Some parameters of the virtq should continue to be managed when the virtq state is changed but all of them must be initialized when the device is closed. Wrongly, the enable param

[dpdk-dev] [RFC v4 4/4] app/testpmd: add meter pps mode cmd

2021-03-01 Thread Li Zhang
Support meter pps mode Signed-off-by: Li Zhang --- app/test-pmd/cmdline.c | 4 + app/test-pmd/cmdline_mtr.c | 105 app/test-pmd/cmdline_mtr.h | 1 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 15 +++ 4 files chan

[dpdk-dev] [RFC v4 3/4] net/mlx5: support meter PPS profile

2021-03-01 Thread Li Zhang
Currently meter algorithms only supports bytes per second(BPS). Such as Single Rate Three Color Marker (srTCM rfc2697) Add this new meter srTCMp algorithm to support rate is packet per second. So that it can meter traffic by packet per second (PPS). Signed-off-by: Li Zhang --- doc/guides/nics/ml

[dpdk-dev] [RFC v4 2/4] common/mlx5: add meter mode definition in PRM file

2021-03-01 Thread Li Zhang
Add meter mode definition in PRM file Signed-off-by: Li Zhang --- drivers/common/mlx5/mlx5_prm.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index e3d4120849..609b1c3951 100644 --- a/drivers/common/mlx5/mlx5_prm.h ++

[dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-01 Thread Li Zhang
Currently meter algorithms only supports rate is bytes per second(BPS). Add this new meter srTCMp algorithm to support rate is packet per second. So that it can meter traffic by packet per second. The below structure will be extended: rte_mtr_algorithm rte_mtr_meter_profile Signed-off-by: Li Zhang

[dpdk-dev] [RFC v4 0/4] adds support PPS(packet per second) on meter

2021-03-01 Thread Li Zhang
Currently the flow Meter algorithms in rte_flow only supports bytes per second(BPS). Such as Single Rate Three Color Marker (srTCM rfc2697) This RFC adds the packet per second definition in Meter algorithms structure, to support the rte_mtr APIs with type srTCM pps mode. The below structure will be

Re: [dpdk-dev] [PATCH v6 07/17] drivers: replace page size definitions with function

2021-03-01 Thread Bruce Richardson
On Mon, Mar 01, 2021 at 10:53:46AM +0100, Thomas Monjalon wrote: > 01/03/2021 10:41, Bruce Richardson: > > On Sun, Feb 28, 2021 at 01:53:42PM +0100, Thomas Monjalon wrote: > > > The page size is often retrieved from the macro PAGE_SIZE. > > > If PAGE_SIZE is not defined, it is either using hard cod

Re: [dpdk-dev] [Bug 644] [dpdk-19.11.7]usertools/dpdk-devbind.py: bind NIC port to DPDK failed in vm.

2021-03-01 Thread Bruce Richardson
On Mon, Mar 01, 2021 at 01:48:49AM +, bugzi...@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=644 > > Bug ID: 644 >Summary: [dpdk-19.11.7]usertools/dpdk-devbind.py: bind NIC port > to DPDK failed in vm. >Product: DPDK >

Re: [dpdk-dev] [PATCH] eal/windows: add missing SPDX license tag

2021-03-01 Thread Nick Connolly
Fixes: c08bd191b13d ("eal/windows: initialize hugepage info") Cc: sta...@dpdk.org Reported-by: Stephen Hemminger Signed-off-by: Dmitry Kozlyuk Acked-by: Nick Connolly

[dpdk-dev] [PATCH v7] bus/pci: nvme on Windows requires class id and bus

2021-03-01 Thread Nick Connolly
Attaching to an NVMe disk on Windows using SPDK requires the PCI class ID and device.bus fields. Decode the class ID from the PCI device info strings if it is present and set device.bus. Signed-off-by: Nick Connolly Acked-by: Tal Shnaiderman Acked-by: Dmitry Kozlyuk --- v7: * Improve comments a

[dpdk-dev] [RFC v3 2/4] common/mlx5: add meter mode definition in PRM file

2021-03-01 Thread Li Zhang
Add meter mode definition in PRM file Signed-off-by: Li Zhang --- drivers/common/mlx5/mlx5_prm.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index e3d4120849..609b1c3951 100644 --- a/drivers/common/mlx5/mlx5_prm.h ++

  1   2   >